Skip to content

[cloud/1.54] feat(agent): improve onboarding card focus, navigation, and replay (#18911) - #19045

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport-18911-to-cloud-1.54
Sep 28, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport-18911-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #18911 to cloud/1.54. Cherry-picked cleanly — no conflicts, no manual resolution.

This is the only branch #18911 can go to. The automated run also tried core/1.54, core/1.55 and cloud/1.55, and all three conflicted on AgentPanelRoot.vue, OnboardingCoach.vue and OnboardingCoach.test.ts. The cause is not a merge accident: those branches lack the onboarding telemetry this change builds on — no trackAgentOnboardingStep, no AgentOnboardingAction, and no previous on useOnboarding.

That substrate came from #18503 ("complete the agent activation funnel", PM-1474), which was labelled cloud/1.54 only — deliberately, by its author. It is 934 insertions across 23 files touching the telemetry registry, both providers and the composer store. Carrying it into three more release branches to land a UX refinement would be well out of proportion for a patch release, and would override a scoping decision someone already made on purpose.

The alternative — backporting #18911 with its telemetry calls stripped — would leave three bespoke variants of OnboardingCoach across release branches. Not worth it.

So the other three labels are being removed from #18911 rather than left to fail silently.

@christian-byrne
christian-byrne requested a review from a team as a code owner September 27, 2026 04:02
@vercel

vercel Bot commented Sep 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 27, 2026 4:02am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 27, 2026 4:02am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: a53c2867-d4c2-4d95-ad72-8fb7e82297bb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/27/2026, 08:04:58 AM UTC

Links

🎭 Playwright: ✅ 1961 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1940 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 145ms TBT · 104.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.9 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 64ms TBT · 168.3 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 444ms TBT · 171.4 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 485ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 57.7 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -195
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 34ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 916ms
canvas-mouse-sweep: script duration 167ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.9 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -182
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 350ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.1 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 447ms
dom-widget-clipping: script duration 164ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.7 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 591ms
large-graph-idle: script duration 30ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.6 MB
large-graph-idle: DOM nodes -276
large-graph-idle: event listeners -179
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1677ms
large-graph-pan: script duration 850ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 78.3 MB
large-graph-pan: DOM nodes -280
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1642ms
large-graph-zoom: script duration 780ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.6 MB
large-graph-zoom: DOM nodes -273
large-graph-zoom: event listeners -90
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1914ms
legacy-node-drag: script duration 953ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.5 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 587ms
minimap-idle: script duration 32ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.2 MB
minimap-idle: DOM nodes -280
minimap-idle: event listeners -164
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 409ms
subgraph-dom-widget-clipping: script duration 140ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.1 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 484ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 57.8 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 30ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 802ms
subgraph-mouse-sweep: script duration 108ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 67.0 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 938ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 145ms
subgraph-transition-enter: heap used 104.9 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 5847ms
viewport-pan-sweep: script duration 2736ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.7 MB
viewport-pan-sweep: DOM nodes -258
viewport-pan-sweep: event listeners -162
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16216ms
vue-large-graph-idle: script duration 268ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.9 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 171
vue-large-graph-pan: task duration 20051ms
vue-large-graph-pan: script duration 913ms
vue-large-graph-pan: TBT 64ms
vue-large-graph-pan: heap used 168.3 MB
vue-large-graph-pan: DOM nodes -8083
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 80ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5940ms
vue-node-resize-workload: script duration 121ms
vue-node-resize-workload: TBT 444ms
vue-node-resize-workload: heap used 171.4 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8185ms
vue-zoom-out-idle: script duration 133ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -13
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 4
workflow-execution: style recalc count 14
workflow-execution: task duration 104ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.9 MB
workflow-execution: DOM nodes 138
workflow-execution: event listeners 41
Raw data
{
  "timestamp": "2026-09-27T08:14:25.832Z",
  "gitSha": "40ecc1b34705b92017e7b00c2ab3585d49b6e4fd",
  "branch": "backport-18911-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2056.458999999961,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.702,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 483.245,
      "heapDeltaBytes": -6916512,
      "heapUsedBytes": 62608060,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.865,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2031.1699999999746,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.45,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 486.378,
      "heapDeltaBytes": -11225316,
      "heapUsedBytes": 58396280,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.825000000000002,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2046.510000000012,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 38.502,
      "layouts": 14,
      "layoutDurationMs": 4.071,
      "taskDurationMs": 976.529,
      "heapDeltaBytes": -3470336,
      "heapUsedBytes": 66900876,
      "domNodes": -281,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 176.177,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1887.8349999999955,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 28.759,
      "layouts": 14,
      "layoutDurationMs": 3.732,
      "taskDurationMs": 855.2769999999999,
      "heapDeltaBytes": 4393096,
      "heapUsedBytes": 75415512,
      "domNodes": -281,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 158.615,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1719.789999999989,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.368000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.1720000000000002,
      "taskDurationMs": 340.428,
      "heapDeltaBytes": 4605444,
      "heapUsedBytes": 75683804,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.562000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.4110000000182,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.996000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.163,
      "taskDurationMs": 359.60699999999997,
      "heapDeltaBytes": 4615972,
      "heapUsedBytes": 75507376,
      "domNodes": 74,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 11.234000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 635.39499999996,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.022,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.77900000000005,
      "heapDeltaBytes": -6900152,
      "heapUsedBytes": 63203304,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 164.106,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 642.9910000000518,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.8870000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.75100000000003,
      "heapDeltaBytes": 19377576,
      "heapUsedBytes": 89274212,
      "domNodes": 16,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 164.632,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2033.8669999999865,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.054000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 603.085,
      "heapDeltaBytes": 11115580,
      "heapUsedBytes": 87991312,
      "domNodes": -281,
      "jsHeapTotalBytes": -626688,
      "scriptDurationMs": 28.578000000000007,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2031.507999999917,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.637,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 579.3760000000001,
      "heapDeltaBytes": 10492984,
      "heapUsedBytes": 87241464,
      "domNodes": -271,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 31.044,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2298.849999999959,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.213,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1698.9630000000002,
      "heapDeltaBytes": 21931104,
      "heapUsedBytes": 87408940,
      "domNodes": -275,
      "jsHeapTotalBytes": 1536000,
      "scriptDurationMs": 887.17,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2242.6100000000133,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.219,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1654.858,
      "heapDeltaBytes": -903372,
      "heapUsedBytes": 76736980,
      "domNodes": -285,
      "jsHeapTotalBytes": 385024,
      "scriptDurationMs": 813.7840000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3453.458000000012,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 11.036000000000001,
      "layouts": 60,
      "layoutDurationMs": 11.302,
      "taskDurationMs": 1571.9149999999997,
      "heapDeltaBytes": -7134036,
      "heapUsedBytes": 71718872,
      "domNodes": -260,
      "jsHeapTotalBytes": -102400,
      "scriptDurationMs": 764.8620000000001,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3634.4739999999547,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.420000000000005,
      "layouts": 60,
      "layoutDurationMs": 11.381,
      "taskDurationMs": 1711.6160000000002,
      "heapDeltaBytes": 10101684,
      "heapUsedBytes": 76431112,
      "domNodes": -285,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 794.807,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2947.2450000000094,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.390999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1877.8710000000003,
      "heapDeltaBytes": 20261804,
      "heapUsedBytes": 88391240,
      "domNodes": 0,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 941.981,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3167.148999999995,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.638,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1950.2680000000003,
      "heapDeltaBytes": 24594664,
      "heapUsedBytes": 93034820,
      "domNodes": 0,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 963.5490000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2010.942,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.719999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 597.418,
      "heapDeltaBytes": 2731304,
      "heapUsedBytes": 80452980,
      "domNodes": -285,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 30.85299999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2019.6800000001076,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.21,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 575.7929999999999,
      "heapDeltaBytes": 10127956,
      "heapUsedBytes": 87762132,
      "domNodes": -275,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 32.22899999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 590.989000000036,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.285000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.75899999999996,
      "heapDeltaBytes": 14911892,
      "heapUsedBytes": 88075288,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 138.91299999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 573.172999999997,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.917000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.2570000000001,
      "heapDeltaBytes": 14816848,
      "heapUsedBytes": 88277652,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 140.233,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2019.9049999999943,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.580999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 486.72099999999995,
      "heapDeltaBytes": -13692708,
      "heapUsedBytes": 59112380,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.676,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.1349999999584,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.065999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.91200000000003,
      "heapDeltaBytes": -10472020,
      "heapUsedBytes": 62185880,
      "domNodes": -294,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.844999999999998,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.0700000000206,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 25.857000000000006,
      "layouts": 18,
      "layoutDurationMs": 4.311,
      "taskDurationMs": 791.7230000000001,
      "heapDeltaBytes": -5456056,
      "heapUsedBytes": 67715388,
      "domNodes": -296,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 107.519,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1768.6050000000932,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 34.095,
      "layouts": 18,
      "layoutDurationMs": 4.4559999999999995,
      "taskDurationMs": 813.057,
      "heapDeltaBytes": -787768,
      "heapUsedBytes": 72768748,
      "domNodes": -298,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 107.592,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.1259999999393,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 33.01800000000001,
      "layouts": 15,
      "layoutDurationMs": 15.824000000000002,
      "taskDurationMs": 937.7120000000001,
      "heapDeltaBytes": 21065340,
      "heapUsedBytes": 110009312,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 30.421999999999997,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 145,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8320.610999999986,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 34.665,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5701.059,
      "heapDeltaBytes": 6954304,
      "heapUsedBytes": 82928372,
      "domNodes": -247,
      "jsHeapTotalBytes": -139264,
      "scriptDurationMs": 2662.057,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8669.911999999953,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 37.767,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5992.553,
      "heapDeltaBytes": 16381780,
      "heapUsedBytes": 92698704,
      "domNodes": -269,
      "jsHeapTotalBytes": -139264,
      "scriptDurationMs": 2809.05,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16641.584999999963,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16192.293,
      "heapDeltaBytes": -39418612,
      "heapUsedBytes": 178004388,
      "domNodes": -8068,
      "jsHeapTotalBytes": -7397376,
      "scriptDurationMs": 265.82000000000005,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16762.76000000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16238.894000000002,
      "heapDeltaBytes": -55552044,
      "heapUsedBytes": 178381420,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17780736,
      "scriptDurationMs": 270.244,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20524.614999999925,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 17.129999999999978,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20114.607,
      "heapDeltaBytes": -48588488,
      "heapUsedBytes": 169360740,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12333056,
      "scriptDurationMs": 921.6519999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 68,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20429.381999999918,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 17.449999999999967,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19988.047000000002,
      "heapDeltaBytes": -35042716,
      "heapUsedBytes": 183534500,
      "domNodes": -8097,
      "jsHeapTotalBytes": -11755520,
      "scriptDurationMs": 904.003,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 60,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6057.108999999969,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.51999999999998,
      "layouts": 20,
      "layoutDurationMs": 23.535000000000014,
      "taskDurationMs": 5933.573000000001,
      "heapDeltaBytes": -35966652,
      "heapUsedBytes": 182401316,
      "domNodes": -8068,
      "jsHeapTotalBytes": 17301504,
      "scriptDurationMs": 107.16499999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 510,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6075.7070000000795,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.322,
      "layouts": 20,
      "layoutDurationMs": 21.240999999999996,
      "taskDurationMs": 5945.798,
      "heapDeltaBytes": -41111112,
      "heapUsedBytes": 177119852,
      "domNodes": -8068,
      "jsHeapTotalBytes": 5283840,
      "scriptDurationMs": 135.679,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 377,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8431.013000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8133.453999999999,
      "heapDeltaBytes": 2309836,
      "heapUsedBytes": 178313684,
      "domNodes": 0,
      "jsHeapTotalBytes": -21757952,
      "scriptDurationMs": 131.718,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8534.19299999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8236.416000000001,
      "heapDeltaBytes": 5637936,
      "heapUsedBytes": 178343400,
      "domNodes": 0,
      "jsHeapTotalBytes": -13369344,
      "scriptDurationMs": 135.20699999999997,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 504.50499999999465,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 27.439999999999998,
      "layouts": 5,
      "layoutDurationMs": 2.4070000000000005,
      "taskDurationMs": 133.283,
      "heapDeltaBytes": 5028224,
      "heapUsedBytes": 74416896,
      "domNodes": 150,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 13.709000000000001,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 110.7920000000604,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 14.43,
      "layouts": 2,
      "layoutDurationMs": 1.314,
      "taskDurationMs": 74.406,
      "heapDeltaBytes": 3001196,
      "heapUsedBytes": 72207588,
      "domNodes": 126,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.461,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50652 75840 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 27, 2026
@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19045   +/-   ##
=============================================
  Coverage              ?   83.95%           
=============================================
  Files                 ?     2117           
  Lines                 ?   126145           
  Branches              ?    31966           
=============================================
  Hits                  ?   105908           
  Misses                ?    20060           
  Partials              ?      177           
Flag Coverage Δ
e2e 66.79% <100.00%> (?)
unit 79.04% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/useTooltipConfig.ts 100.00% <100.00%> (ø)
src/platform/onboarding/coachmarkLayout.ts 97.29% <100.00%> (ø)
...extensions/vueNodes/composables/useNodeTooltips.ts 100.00% <ø> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 91.55% <100.00%> (ø)
...h/extensions/agent/components/agent/AgentPanel.vue 96.82% <100.00%> (ø)
...ensions/agent/components/agent/OnboardingCoach.vue 100.00% <100.00%> (ø)
.../extensions/agent/components/agent/PanelHeader.vue 100.00% <100.00%> (ø)
...xtensions/agent/composables/agent/useOnboarding.ts 98.14% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…18911)

Make the agent onboarding tour easier to follow. The tour gets clearer
focus, a Back button, a replay button, and copy that matches automatic
workflow targeting.

Depends on #18377. Merge #18377 first. This branch contains the commits
from #18377.

- **What**:
  - Add a 2px border around the onboarding spotlight.
- Add Back navigation to the cards (from #18377). The Back button is at
the left edge of the card.
- In step 4, show the chat history button in its hover state, with its
tooltip. The spotlight covers the button and the tooltip.
- Show the chat history tooltip to the right of the button, in the tour
and on hover.
- Add an info button next to the Comfy Agent title. The button starts
the tour again from the first card.
- Rewrite the step 2 copy. The agent follows the visible tab, so the
card does not tell the user to select a workflow.
- Wrap card text with `text-pretty`. This prevents a single word on the
last line.
- Fix the shared tooltip arrow. The arrow colored only its top edge.
Tooltips on the right, left, or bottom showed half a triangle.

- The arrow fix changes `buildTooltipConfig` and `useNodeTooltips`.
About 15 components use these. Arrows on tooltips that are not above
their target now use the tooltip border color.
- The step 4 tooltip is a copy that the tour draws. The real PrimeVue
tooltip shows only on mouse hover, and it is below the dark overlay.
Both use `TOOLTIP_TEXT_CLASS`.
- The info button removes the seen flag from local storage. Then it
remounts `OnboardingCoach`. If the tour is paused (for example, in App
Mode), the tour starts when the pause ends.
- Each restart sends the onboarding shown telemetry event again.
- This PR does not include the step 3 visibility item from DES-1208.

Linear:
[DES-1208](https://linear.app/comfyorg/issue/DES-1208/des-design-onboarding-card-navigation-and-step-focus).
Parent:
[PM-1374](https://linear.app/comfyorg/issue/PM-1374/test-onboarding-cards-need-a-back-button-and-clearer-step-3-and-step-4).

| Change | Before | After |
|---|---|---|
| Step 2: copy, Back button, spotlight border | <img
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/step2-before.png"
width="420" alt="Step 2 card before"> | <img
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/0797967f2d4bcec33325f95d61c28653a73e066f/.github/pr-images/des-1208/step2-after-v2.png"
width="420" alt="Step 2 card after"> |
| Step 4: hover state, tooltip, spotlight border, text wrap | <img
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/step4-before.png"
width="300" alt="Step 4 card before"> | <img
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/step4-after.png"
width="400" alt="Step 4 card after"> |
| Header: info button with tooltip | <img
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/header-before.png"
width="340" alt="Panel header before"> | <img
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/header-after.png"
width="340" alt="Panel header after, info button hovered"> |
| Chat history tooltip on hover | <img
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/history-tooltip-before.png"
width="150" alt="History tooltip before, below the button"> | <img
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/history-tooltip-after.png"
width="190" alt="History tooltip after, right of the button"> |

---------

Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: GitHub Action <action@github.com>
(cherry picked from commit ffc6359)
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Rebased onto current cloud/1.54; it had gone DIRTY.

Apologies for the churn in the history here — I force-pushed while the cherry-pick still had an unresolved conflict, so HEAD was still the base commit and the push briefly emptied the branch. GitHub auto-closed the PR because the diff became zero. Both are fixed: the conflict is resolved, the commit is on the branch (8e2a72aae), and the PR is reopened with its 16 files back, matching #18911.

The one conflict was in AgentPanelRoot.test.ts and was additive — this branch's two legacy-seen-flag tests against #18911's replay tests. Kept both. Verified the resolved file parses (oxfmt clean, braces balanced) and the file list matches the original exactly, with no conflict markers.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-onboarding Agent consent, first-use tour or onboarding gates agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 27, 2026
@christian-byrne
christian-byrne merged commit 31f142b into cloud/1.54 Sep 28, 2026
136 of 137 checks passed
@christian-byrne
christian-byrne deleted the backport-18911-to-cloud-1.54 branch September 28, 2026 03:02
christian-byrne added a commit that referenced this pull request Oct 1, 2026
…and replay (#18911) (#19045)

Backport of #18911 to `cloud/1.54`. Cherry-picked cleanly — no
conflicts, no manual resolution.

**This is the only branch #18911 can go to.** The automated run also
tried `core/1.54`, `core/1.55` and `cloud/1.55`, and all three
conflicted on `AgentPanelRoot.vue`, `OnboardingCoach.vue` and
`OnboardingCoach.test.ts`. The cause is not a merge accident: those
branches lack the onboarding telemetry this change builds on — no
`trackAgentOnboardingStep`, no `AgentOnboardingAction`, and no
`previous` on `useOnboarding`.

That substrate came from #18503 ("complete the agent activation funnel",
PM-1474), which was labelled **`cloud/1.54` only** — deliberately, by
its author. It is 934 insertions across 23 files touching the telemetry
registry, both providers and the composer store. Carrying it into three
more release branches to land a UX refinement would be well out of
proportion for a patch release, and would override a scoping decision
someone already made on purpose.

The alternative — backporting #18911 with its telemetry calls stripped —
would leave three bespoke variants of `OnboardingCoach` across release
branches. Not worth it.

So the other three labels are being removed from #18911 rather than left
to fail silently.

Co-authored-by: uytieu <uytieu@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
(cherry picked from commit 31f142b)

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — 8e2a72aa Deployed Sep 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-onboarding Agent consent, first-use tour or onboarding gates agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants