Repository navigation
[cloud/1.54] feat(agent): improve onboarding card focus, navigation, and replay (#18911) - #19045
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1961 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-27T08:14:25.832Z",
"gitSha": "40ecc1b34705b92017e7b00c2ab3585d49b6e4fd",
"branch": "backport-18911-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2056.458999999961,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.702,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.245,
"heapDeltaBytes": -6916512,
"heapUsedBytes": 62608060,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.865,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2031.1699999999746,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.45,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.378,
"heapDeltaBytes": -11225316,
"heapUsedBytes": 58396280,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.825000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2046.510000000012,
"styleRecalcs": 79,
"styleRecalcDurationMs": 38.502,
"layouts": 14,
"layoutDurationMs": 4.071,
"taskDurationMs": 976.529,
"heapDeltaBytes": -3470336,
"heapUsedBytes": 66900876,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 176.177,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1887.8349999999955,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.759,
"layouts": 14,
"layoutDurationMs": 3.732,
"taskDurationMs": 855.2769999999999,
"heapDeltaBytes": 4393096,
"heapUsedBytes": 75415512,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 158.615,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.789999999989,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.368000000000002,
"layouts": 6,
"layoutDurationMs": 1.1720000000000002,
"taskDurationMs": 340.428,
"heapDeltaBytes": 4605444,
"heapUsedBytes": 75683804,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.562000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.4110000000182,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.996000000000002,
"layouts": 6,
"layoutDurationMs": 1.163,
"taskDurationMs": 359.60699999999997,
"heapDeltaBytes": 4615972,
"heapUsedBytes": 75507376,
"domNodes": 74,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.234000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 635.39499999996,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.77900000000005,
"heapDeltaBytes": -6900152,
"heapUsedBytes": 63203304,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 164.106,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 642.9910000000518,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.8870000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.75100000000003,
"heapDeltaBytes": 19377576,
"heapUsedBytes": 89274212,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 164.632,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2033.8669999999865,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.054000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.085,
"heapDeltaBytes": 11115580,
"heapUsedBytes": 87991312,
"domNodes": -281,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 28.578000000000007,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2031.507999999917,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.637,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.3760000000001,
"heapDeltaBytes": 10492984,
"heapUsedBytes": 87241464,
"domNodes": -271,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 31.044,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2298.849999999959,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.213,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1698.9630000000002,
"heapDeltaBytes": 21931104,
"heapUsedBytes": 87408940,
"domNodes": -275,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 887.17,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2242.6100000000133,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.219,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1654.858,
"heapDeltaBytes": -903372,
"heapUsedBytes": 76736980,
"domNodes": -285,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 813.7840000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3453.458000000012,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.036000000000001,
"layouts": 60,
"layoutDurationMs": 11.302,
"taskDurationMs": 1571.9149999999997,
"heapDeltaBytes": -7134036,
"heapUsedBytes": 71718872,
"domNodes": -260,
"jsHeapTotalBytes": -102400,
"scriptDurationMs": 764.8620000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3634.4739999999547,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.420000000000005,
"layouts": 60,
"layoutDurationMs": 11.381,
"taskDurationMs": 1711.6160000000002,
"heapDeltaBytes": 10101684,
"heapUsedBytes": 76431112,
"domNodes": -285,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 794.807,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 2947.2450000000094,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.390999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1877.8710000000003,
"heapDeltaBytes": 20261804,
"heapUsedBytes": 88391240,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 941.981,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3167.148999999995,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.638,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1950.2680000000003,
"heapDeltaBytes": 24594664,
"heapUsedBytes": 93034820,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 963.5490000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.942,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.719999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.418,
"heapDeltaBytes": 2731304,
"heapUsedBytes": 80452980,
"domNodes": -285,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 30.85299999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.6800000001076,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.21,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.7929999999999,
"heapDeltaBytes": 10127956,
"heapUsedBytes": 87762132,
"domNodes": -275,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 32.22899999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.989000000036,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.285000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.75899999999996,
"heapDeltaBytes": 14911892,
"heapUsedBytes": 88075288,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 138.91299999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.172999999997,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.917000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.2570000000001,
"heapDeltaBytes": 14816848,
"heapUsedBytes": 88277652,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.233,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.9049999999943,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.580999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.72099999999995,
"heapDeltaBytes": -13692708,
"heapUsedBytes": 59112380,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.676,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.1349999999584,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.065999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.91200000000003,
"heapDeltaBytes": -10472020,
"heapUsedBytes": 62185880,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.844999999999998,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.0700000000206,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.857000000000006,
"layouts": 18,
"layoutDurationMs": 4.311,
"taskDurationMs": 791.7230000000001,
"heapDeltaBytes": -5456056,
"heapUsedBytes": 67715388,
"domNodes": -296,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 107.519,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1768.6050000000932,
"styleRecalcs": 78,
"styleRecalcDurationMs": 34.095,
"layouts": 18,
"layoutDurationMs": 4.4559999999999995,
"taskDurationMs": 813.057,
"heapDeltaBytes": -787768,
"heapUsedBytes": 72768748,
"domNodes": -298,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 107.592,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.1259999999393,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.01800000000001,
"layouts": 15,
"layoutDurationMs": 15.824000000000002,
"taskDurationMs": 937.7120000000001,
"heapDeltaBytes": 21065340,
"heapUsedBytes": 110009312,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 30.421999999999997,
"eventListeners": 2387,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8320.610999999986,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.665,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5701.059,
"heapDeltaBytes": 6954304,
"heapUsedBytes": 82928372,
"domNodes": -247,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 2662.057,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8669.911999999953,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.767,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5992.553,
"heapDeltaBytes": 16381780,
"heapUsedBytes": 92698704,
"domNodes": -269,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 2809.05,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16641.584999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16192.293,
"heapDeltaBytes": -39418612,
"heapUsedBytes": 178004388,
"domNodes": -8068,
"jsHeapTotalBytes": -7397376,
"scriptDurationMs": 265.82000000000005,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16762.76000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16238.894000000002,
"heapDeltaBytes": -55552044,
"heapUsedBytes": 178381420,
"domNodes": -8068,
"jsHeapTotalBytes": -17780736,
"scriptDurationMs": 270.244,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20524.614999999925,
"styleRecalcs": 170,
"styleRecalcDurationMs": 17.129999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20114.607,
"heapDeltaBytes": -48588488,
"heapUsedBytes": 169360740,
"domNodes": -8068,
"jsHeapTotalBytes": -12333056,
"scriptDurationMs": 921.6519999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 68,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20429.381999999918,
"styleRecalcs": 172,
"styleRecalcDurationMs": 17.449999999999967,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19988.047000000002,
"heapDeltaBytes": -35042716,
"heapUsedBytes": 183534500,
"domNodes": -8097,
"jsHeapTotalBytes": -11755520,
"scriptDurationMs": 904.003,
"eventListeners": -14927,
"totalBlockingTimeMs": 60,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6057.108999999969,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.51999999999998,
"layouts": 20,
"layoutDurationMs": 23.535000000000014,
"taskDurationMs": 5933.573000000001,
"heapDeltaBytes": -35966652,
"heapUsedBytes": 182401316,
"domNodes": -8068,
"jsHeapTotalBytes": 17301504,
"scriptDurationMs": 107.16499999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 510,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6075.7070000000795,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.322,
"layouts": 20,
"layoutDurationMs": 21.240999999999996,
"taskDurationMs": 5945.798,
"heapDeltaBytes": -41111112,
"heapUsedBytes": 177119852,
"domNodes": -8068,
"jsHeapTotalBytes": 5283840,
"scriptDurationMs": 135.679,
"eventListeners": -14931,
"totalBlockingTimeMs": 377,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8431.013000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8133.453999999999,
"heapDeltaBytes": 2309836,
"heapUsedBytes": 178313684,
"domNodes": 0,
"jsHeapTotalBytes": -21757952,
"scriptDurationMs": 131.718,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8534.19299999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8236.416000000001,
"heapDeltaBytes": 5637936,
"heapUsedBytes": 178343400,
"domNodes": 0,
"jsHeapTotalBytes": -13369344,
"scriptDurationMs": 135.20699999999997,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 504.50499999999465,
"styleRecalcs": 20,
"styleRecalcDurationMs": 27.439999999999998,
"layouts": 5,
"layoutDurationMs": 2.4070000000000005,
"taskDurationMs": 133.283,
"heapDeltaBytes": 5028224,
"heapUsedBytes": 74416896,
"domNodes": 150,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.709000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 110.7920000000604,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.43,
"layouts": 2,
"layoutDurationMs": 1.314,
"taskDurationMs": 74.406,
"heapDeltaBytes": 3001196,
"heapUsedBytes": 72207588,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.461,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #19045 +/- ##
=============================================
Coverage ? 83.95%
=============================================
Files ? 2117
Lines ? 126145
Branches ? 31966
=============================================
Hits ? 105908
Misses ? 20060
Partials ? 177
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
0e1ad58 to
2cf98e3
Compare
…18911) Make the agent onboarding tour easier to follow. The tour gets clearer focus, a Back button, a replay button, and copy that matches automatic workflow targeting. Depends on #18377. Merge #18377 first. This branch contains the commits from #18377. - **What**: - Add a 2px border around the onboarding spotlight. - Add Back navigation to the cards (from #18377). The Back button is at the left edge of the card. - In step 4, show the chat history button in its hover state, with its tooltip. The spotlight covers the button and the tooltip. - Show the chat history tooltip to the right of the button, in the tour and on hover. - Add an info button next to the Comfy Agent title. The button starts the tour again from the first card. - Rewrite the step 2 copy. The agent follows the visible tab, so the card does not tell the user to select a workflow. - Wrap card text with `text-pretty`. This prevents a single word on the last line. - Fix the shared tooltip arrow. The arrow colored only its top edge. Tooltips on the right, left, or bottom showed half a triangle. - The arrow fix changes `buildTooltipConfig` and `useNodeTooltips`. About 15 components use these. Arrows on tooltips that are not above their target now use the tooltip border color. - The step 4 tooltip is a copy that the tour draws. The real PrimeVue tooltip shows only on mouse hover, and it is below the dark overlay. Both use `TOOLTIP_TEXT_CLASS`. - The info button removes the seen flag from local storage. Then it remounts `OnboardingCoach`. If the tour is paused (for example, in App Mode), the tour starts when the pause ends. - Each restart sends the onboarding shown telemetry event again. - This PR does not include the step 3 visibility item from DES-1208. Linear: [DES-1208](https://linear.app/comfyorg/issue/DES-1208/des-design-onboarding-card-navigation-and-step-focus). Parent: [PM-1374](https://linear.app/comfyorg/issue/PM-1374/test-onboarding-cards-need-a-back-button-and-clearer-step-3-and-step-4). | Change | Before | After | |---|---|---| | Step 2: copy, Back button, spotlight border | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/step2-before.png" width="420" alt="Step 2 card before"> | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/0797967f2d4bcec33325f95d61c28653a73e066f/.github/pr-images/des-1208/step2-after-v2.png" width="420" alt="Step 2 card after"> | | Step 4: hover state, tooltip, spotlight border, text wrap | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/step4-before.png" width="300" alt="Step 4 card before"> | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/step4-after.png" width="400" alt="Step 4 card after"> | | Header: info button with tooltip | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/header-before.png" width="340" alt="Panel header before"> | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/header-after.png" width="340" alt="Panel header after, info button hovered"> | | Chat history tooltip on hover | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/history-tooltip-before.png" width="150" alt="History tooltip before, below the button"> | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/history-tooltip-after.png" width="190" alt="History tooltip after, right of the button"> | --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit ffc6359)
|
Rebased onto current Apologies for the churn in the history here — I force-pushed while the cherry-pick still had an unresolved conflict, so HEAD was still the base commit and the push briefly emptied the branch. GitHub auto-closed the PR because the diff became zero. Both are fixed: the conflict is resolved, the commit is on the branch ( The one conflict was in |
…and replay (#18911) (#19045) Backport of #18911 to `cloud/1.54`. Cherry-picked cleanly — no conflicts, no manual resolution. **This is the only branch #18911 can go to.** The automated run also tried `core/1.54`, `core/1.55` and `cloud/1.55`, and all three conflicted on `AgentPanelRoot.vue`, `OnboardingCoach.vue` and `OnboardingCoach.test.ts`. The cause is not a merge accident: those branches lack the onboarding telemetry this change builds on — no `trackAgentOnboardingStep`, no `AgentOnboardingAction`, and no `previous` on `useOnboarding`. That substrate came from #18503 ("complete the agent activation funnel", PM-1474), which was labelled **`cloud/1.54` only** — deliberately, by its author. It is 934 insertions across 23 files touching the telemetry registry, both providers and the composer store. Carrying it into three more release branches to land a UX refinement would be well out of proportion for a patch release, and would override a scoping decision someone already made on purpose. The alternative — backporting #18911 with its telemetry calls stripped — would leave three bespoke variants of `OnboardingCoach` across release branches. Not worth it. So the other three labels are being removed from #18911 rather than left to fail silently. Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit 31f142b)
Backport of #18911 to
cloud/1.54. Cherry-picked cleanly — no conflicts, no manual resolution.This is the only branch #18911 can go to. The automated run also tried
core/1.54,core/1.55andcloud/1.55, and all three conflicted onAgentPanelRoot.vue,OnboardingCoach.vueandOnboardingCoach.test.ts. The cause is not a merge accident: those branches lack the onboarding telemetry this change builds on — notrackAgentOnboardingStep, noAgentOnboardingAction, and nopreviousonuseOnboarding.That substrate came from #18503 ("complete the agent activation funnel", PM-1474), which was labelled
cloud/1.54only — deliberately, by its author. It is 934 insertions across 23 files touching the telemetry registry, both providers and the composer store. Carrying it into three more release branches to land a UX refinement would be well out of proportion for a patch release, and would override a scoping decision someone already made on purpose.The alternative — backporting #18911 with its telemetry calls stripped — would leave three bespoke variants of
OnboardingCoachacross release branches. Not worth it.So the other three labels are being removed from #18911 rather than left to fail silently.