Skip to content

[cloud/1.54] fix(agent): keep the expanded agent panel inside the window (#18182) - #19040

Merged
christian-byrne merged 2 commits into
cloud/1.54from
backport-18182-to-cloud-1.54
Sep 28, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
backport-18182-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Manual backport of #18182. The automated run failed on all four branches with real conflicts, so each is resolved by hand.

Conflicts and how they were resolved

browser_tests/tests/agent/agentPanelViewportDrag.spec.ts — dropped. The file does not exist on any release branch; it is main-only test infrastructure. The original commit only removed two test.fail markers from it, and those markers do not exist here, so there is nothing to carry over.

src/components/graph/GraphCanvasMenu.vue — release toolbar kept, wrapper re-applied. The toolbar on this branch is the older one (stringifiedMinimapStyles, bg-comfy-menu-bg, a zoom-controls button) and has diverged substantially from main's. Taking main's version wholesale — which is what the PR on main did — would have imported an unrelated toolbar redesign into a release branch. Instead only the actual fix is applied: the pointer-events-none absolute inset-x-0 bottom-0 flex wrapper, and pointer-events-auto ml-auto max-w-full min-w-0 overflow-x-auto on the ButtonGroup, replacing its absolute right-0 bottom-0. Every button, style binding and handler on this branch is untouched.

agentPanelStore.ts — import line only. Took the incoming useEventListener, useWindowSize + clamp import. es-toolkit is already a dependency here (^1.39.9).

agentPanelStore.test.ts — purely additive. The conflict had an empty base side; the new clamping tests were taken as-is, and the helpers they use (resizeWindowTo, SIDEBAR_OPEN, SIDEBAR_CLOSED) came in with the same patch.

Verification

Conflict markers: none remain anywhere in src/ or browser_tests/. Formatted with oxfmt.

I could not meaningfully run the unit tests locally: a worktree of a release branch against main's node_modules is broken on its own. The control proves it — pristine core/1.55 with no backport applied fails 27 of 27 in that harness, while the backported tree gets 14 passing. So the local numbers measure the harness, not the change, and I am not claiming them as a pass. CI on this branch is the real check.

Extra conflicts specific to the 1.54 branches

LiteGraphCanvasSplitterOverlay.test.ts — this branch stubs @/stores/authStore directly where main mocks firebase/auth. Kept the branch's stub, added the two incoming imports (useSidebarTabStore, SidebarTabExtension — both used twice by the new cases), and dropped the incoming vi.mock(import('firebase/auth')), which would have been the only reference to firebase in the file.

DockedAgentPanel.test.ts — import union. The branch needs createPinia/setActivePinia, the incoming tests need onTestFinished; all three are used.

The agent panel kept its width when the window became narrower. An
expanded panel went past the right edge of the window and out of sight.
The panel now becomes narrower with the window, and it stops when it
meets the sidebar.

- **What**:
- The width of the panel is now the result of two values. The first
value is the width the user asked for. The second value is the space
that the workspace to the left needs.
- The panel becomes narrower when the window becomes narrower. The panel
returns to the requested width when the window becomes wider again. The
user does not lose the choice they made.
- The workspace needs room for the side toolbar and for the sidebar. The
panel stops at the sidebar. When no sidebar is open, the panel can use
that room instead.
- The maximize button read the panel width and compared it to a fixed
number. A panel that the window made narrower failed that comparison, so
the button showed the wrong icon. The button now reads explicit state.
- The canvas toolbar at the bottom of the graph was anchored to the
right edge. A toolbar wider than the canvas hung over the left edge and
went behind the sidebar. The toolbar now stays inside the canvas. A
toolbar with more buttons than the canvas holds scrolls sideways.

- **The panel respects the minimum width of the sidebar, not the current
width of the sidebar.** The sidebar is a percentage of the area beside
the panel. If the panel reads the live width of the sidebar, the sidebar
gets wider. A wider sidebar then makes the panel narrower again. This
loop has no end. The minimum width breaks it. The effect is that a
sidebar the user dragged wider still gives room back to the panel.
- A window with less room than `PANEL_MIN_WIDTH` now gets a panel
narrower than that minimum. A panel of 232px in a 600px window is poor,
and a panel that leaves the window is worse. A window this narrow is
below the desktop range.
- `SIDE_TOOLBAR_WIDTH` is 56px. A measurement in the browser gave this
number. It is the connected rail, which adds `--sidebar-padding` on each
side of the 48px icons. My first value of 48px made the panel start 8px
inside the rail.

https://github.com/user-attachments/assets/e9a3554c-ac91-4de4-839f-5fb8a9469c7d

Linear:
[DES-1037](https://linear.app/comfyorg/issue/DES-1037/des-keep-expanded-agent-panel-within-window-bounds)

---------

Co-authored-by: bymyself <cbyrne@comfy.org>
(cherry picked from commit ffdf258)
@vercel

vercel Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 27, 2026 3:44am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 27, 2026 3:44am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 7155fd4c-e03e-4b07-b877-4006d7a2ca19

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1958 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1937 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/27/2026, 03:46:38 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 22ms TBT · 71.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 69ms TBT · 61.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 112ms TBT · 102.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.2 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.7 MB heap
vue-large-graph-pan: · 59.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 159.0 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 14ms TBT · 173.0 MB heap
vue-zoom-out-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 434ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 64.2 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -195
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 24ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 734ms
canvas-mouse-sweep: script duration 101ms
canvas-mouse-sweep: TBT 22ms
canvas-mouse-sweep: heap used 71.9 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -194
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 12ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 269ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.6 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 9
dom-widget-clipping: task duration 436ms
dom-widget-clipping: script duration 116ms
dom-widget-clipping: TBT 69ms
dom-widget-clipping: heap used 61.2 MB
dom-widget-clipping: DOM nodes 13
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 492ms
large-graph-idle: script duration 29ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.1 MB
large-graph-idle: DOM nodes -276
large-graph-idle: event listeners -190
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1312ms
large-graph-pan: script duration 609ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 79.9 MB
large-graph-pan: DOM nodes -280
large-graph-pan: event listeners -190
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1405ms
large-graph-zoom: script duration 589ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 76.8 MB
large-graph-zoom: DOM nodes -141
large-graph-zoom: event listeners -94
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1445ms
legacy-node-drag: script duration 685ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 82.7 MB
legacy-node-drag: DOM nodes 1
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 464ms
minimap-idle: script duration 28ms
minimap-idle: TBT 0ms
minimap-idle: heap used 77.0 MB
minimap-idle: DOM nodes -276
minimap-idle: event listeners -160
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 8ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 305ms
subgraph-dom-widget-clipping: script duration 99ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.4 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 384ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.8 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -226
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 21ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 628ms
subgraph-mouse-sweep: script duration 76ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.7 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -225
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 25ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 653ms
subgraph-transition-enter: script duration 22ms
subgraph-transition-enter: TBT 112ms
subgraph-transition-enter: heap used 102.0 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4326ms
viewport-pan-sweep: script duration 1933ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.2 MB
viewport-pan-sweep: DOM nodes -279
viewport-pan-sweep: event listeners -162
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11667ms
vue-large-graph-idle: script duration 187ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.7 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14936
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 69
vue-large-graph-pan: task duration 14112ms
vue-large-graph-pan: script duration 710ms
vue-large-graph-pan: TBT 0ms
vue-large-graph-pan: heap used 159.0 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14933
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 57ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4223ms
vue-node-resize-workload: script duration 81ms
vue-node-resize-workload: TBT 14ms
vue-node-resize-workload: heap used 173.0 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14931
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5606ms
vue-zoom-out-idle: script duration 97ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 172.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -10
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 3
workflow-execution: style recalc count 20
workflow-execution: task duration 104ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.6 MB
workflow-execution: DOM nodes 149
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-09-27T03:55:14.172Z",
  "gitSha": "43e8f52c2b7191e666849ba9d24b9e4c129046f7",
  "branch": "backport-18182-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2085.055000000011,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.483,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 484.139,
      "heapDeltaBytes": 4323436,
      "heapUsedBytes": 75561100,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.045000000000002,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 1990.6680000000279,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.747999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 384.007,
      "heapDeltaBytes": -11190272,
      "heapUsedBytes": 59009940,
      "domNodes": -280,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.743999999999998,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1876.29000000004,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 23.217,
      "layouts": 14,
      "layoutDurationMs": 2.989,
      "taskDurationMs": 800.149,
      "heapDeltaBytes": 9718820,
      "heapUsedBytes": 80683836,
      "domNodes": -283,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 93.69500000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 43,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1753.4590000000208,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 24.317,
      "layouts": 14,
      "layoutDurationMs": 3.9890000000000003,
      "taskDurationMs": 667.103,
      "heapDeltaBytes": 427808,
      "heapUsedBytes": 70105600,
      "domNodes": -278,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 107.646,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1670.1140000000123,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 12.838,
      "layouts": 6,
      "layoutDurationMs": 1.1320000000000001,
      "taskDurationMs": 264.115,
      "heapDeltaBytes": 4639268,
      "heapUsedBytes": 75531236,
      "domNodes": 78,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 9.345,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1671.2860000000092,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 12.129000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.0359999999999998,
      "taskDurationMs": 273.406,
      "heapDeltaBytes": 4292540,
      "heapUsedBytes": 74673040,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.447000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 713.9920000000757,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.309,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 519.199,
      "heapDeltaBytes": -6626924,
      "heapUsedBytes": 64879064,
      "domNodes": 6,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 114.20899999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 137,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 542.0820000000504,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.903999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 353.008,
      "heapDeltaBytes": -7653792,
      "heapUsedBytes": 63379228,
      "domNodes": 20,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 117.86,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.633999999931,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.863000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 473.81100000000004,
      "heapDeltaBytes": 5627804,
      "heapUsedBytes": 81882404,
      "domNodes": -277,
      "jsHeapTotalBytes": -626688,
      "scriptDurationMs": 28.295999999999996,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2057.138000000009,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.893999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 510.0769999999999,
      "heapDeltaBytes": 7341172,
      "heapUsedBytes": 84026868,
      "domNodes": -275,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 30.61,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2131.464000000051,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.517,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1339.0339999999999,
      "heapDeltaBytes": 524908,
      "heapUsedBytes": 77713624,
      "domNodes": -288,
      "jsHeapTotalBytes": -663552,
      "scriptDurationMs": 626.0949999999999,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2131.623999999988,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.985999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1285.19,
      "heapDeltaBytes": 12439468,
      "heapUsedBytes": 89893312,
      "domNodes": -271,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 592.5709999999999,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3229.000000000042,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 12.69,
      "layouts": 60,
      "layoutDurationMs": 12.862,
      "taskDurationMs": 1294.419,
      "heapDeltaBytes": 8517048,
      "heapUsedBytes": 76222608,
      "domNodes": 8,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 557.018,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3341.7100000000346,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 15.240999999999998,
      "layouts": 60,
      "layoutDurationMs": 14.98,
      "taskDurationMs": 1516.2220000000002,
      "heapDeltaBytes": 5874936,
      "heapUsedBytes": 84924584,
      "domNodes": -290,
      "jsHeapTotalBytes": 4091904,
      "scriptDurationMs": 620.802,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2155.520000000024,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.182,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1382.819,
      "heapDeltaBytes": 17227096,
      "heapUsedBytes": 84949928,
      "domNodes": 2,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 655.3720000000001,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2211.2119999999322,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 6.113,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1506.724,
      "heapDeltaBytes": 20435476,
      "heapUsedBytes": 88434852,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 713.78,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.2679999999546,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.333,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 427.545,
      "heapDeltaBytes": 9518200,
      "heapUsedBytes": 87753392,
      "domNodes": -266,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 25.064999999999998,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2016.356000000087,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.273999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 499.921,
      "heapDeltaBytes": -3315076,
      "heapUsedBytes": 73813076,
      "domNodes": -286,
      "jsHeapTotalBytes": -626688,
      "scriptDurationMs": 30.244,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 460.5150000001004,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 293.684,
      "heapDeltaBytes": 14837728,
      "heapUsedBytes": 88211400,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 94.528,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 533.9239999999563,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.319,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 316.6290000000001,
      "heapDeltaBytes": 15152016,
      "heapUsedBytes": 88686904,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 102.87599999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.9280000000263,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.439999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 379.104,
      "heapDeltaBytes": -5393016,
      "heapUsedBytes": 67692548,
      "domNodes": -294,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.316,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2010.1509999999507,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.6899999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 389.25100000000003,
      "heapDeltaBytes": 3365744,
      "heapUsedBytes": 76596284,
      "domNodes": -298,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.286,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.8969999999554,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 20.223,
      "layouts": 18,
      "layoutDurationMs": 4.234,
      "taskDurationMs": 614.466,
      "heapDeltaBytes": -6920224,
      "heapUsedBytes": 65580940,
      "domNodes": -298,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 72.47099999999999,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1694.7450000000117,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 21.526,
      "layouts": 18,
      "layoutDurationMs": 4.064,
      "taskDurationMs": 640.64,
      "heapDeltaBytes": -2529148,
      "heapUsedBytes": 70030644,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 78.80899999999998,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 881.9929999999658,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 25.022000000000002,
      "layouts": 16,
      "layoutDurationMs": 10.064000000000002,
      "taskDurationMs": 652.636,
      "heapDeltaBytes": 21862448,
      "heapUsedBytes": 106905908,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 21.568999999999992,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 112,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8141.83300000002,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 33.72,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4023.9669999999996,
      "heapDeltaBytes": 13491280,
      "heapUsedBytes": 89958500,
      "domNodes": -271,
      "jsHeapTotalBytes": -1449984,
      "scriptDurationMs": 1782.781,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8176.739999999995,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 45.906000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4628.195,
      "heapDeltaBytes": 5822300,
      "heapUsedBytes": 82400436,
      "domNodes": -286,
      "jsHeapTotalBytes": 1171456,
      "scriptDurationMs": 2083.704,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12345.135000000028,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11606.481,
      "heapDeltaBytes": -57643908,
      "heapUsedBytes": 178419996,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18526208,
      "scriptDurationMs": 187.519,
      "eventListeners": -14937,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12517.30699999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11728.128999999999,
      "heapDeltaBytes": -49893116,
      "heapUsedBytes": 183675788,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12574720,
      "scriptDurationMs": 186.99500000000003,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.216666666666665,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14772.639000000026,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 15.097,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14196.471000000001,
      "heapDeltaBytes": -58032300,
      "heapUsedBytes": 167326596,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16613376,
      "scriptDurationMs": 732.8050000000001,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333326,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14594.201999999996,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.248999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14026.872000000001,
      "heapDeltaBytes": -45920880,
      "heapUsedBytes": 166170812,
      "domNodes": -8068,
      "jsHeapTotalBytes": -22392832,
      "scriptDurationMs": 686.468,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4428.662000000031,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 58.59399999999998,
      "layouts": 20,
      "layoutDurationMs": 24.35699999999999,
      "taskDurationMs": 4258.768,
      "heapDeltaBytes": -42017156,
      "heapUsedBytes": 177040728,
      "domNodes": -8068,
      "jsHeapTotalBytes": 9740288,
      "scriptDurationMs": 88.645,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 14,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4329.8449999999775,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 55.48700000000004,
      "layouts": 20,
      "layoutDurationMs": 22.738999999999994,
      "taskDurationMs": 4188.081999999999,
      "heapDeltaBytes": -49790828,
      "heapUsedBytes": 185715744,
      "domNodes": -8068,
      "jsHeapTotalBytes": 19300352,
      "scriptDurationMs": 73.748,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 14,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6144.767999999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5844.737,
      "heapDeltaBytes": 6244752,
      "heapUsedBytes": 180693856,
      "domNodes": 0,
      "jsHeapTotalBytes": -14417920,
      "scriptDurationMs": 94.64700000000003,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5659.667000000127,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5367.803999999999,
      "heapDeltaBytes": 1595688,
      "heapUsedBytes": 180123944,
      "domNodes": 0,
      "jsHeapTotalBytes": -23330816,
      "scriptDurationMs": 98.55600000000003,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 453.28200000005836,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 19.909000000000002,
      "layouts": 2,
      "layoutDurationMs": 1.523,
      "taskDurationMs": 108.58399999999999,
      "heapDeltaBytes": 5010384,
      "heapUsedBytes": 74175620,
      "domNodes": 149,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 12.763,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 459.6090000000004,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 15.841999999999999,
      "layouts": 3,
      "layoutDurationMs": 1.647,
      "taskDurationMs": 98.76400000000001,
      "heapDeltaBytes": 4881408,
      "heapUsedBytes": 73794796,
      "domNodes": 148,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 7.590000000000002,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50620 75816 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 27, 2026
@datadog-official

This comment has been minimized.

The hunk that widened the pinia import on main did not apply here, so an
auto-merged use of getActivePinia had no import. The 1.55 branches took
the widened import cleanly and are unaffected.
@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/graph/GraphCanvasMenu.vue 18.18% 9 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #19040   +/-   ##
=============================================
  Coverage              ?   83.92%           
=============================================
  Files                 ?     2116           
  Lines                 ?   126062           
  Branches              ?    31942           
=============================================
  Hits                  ?   105795           
  Misses                ?    20090           
  Partials              ?      177           
Flag Coverage Δ
e2e 66.77% <73.33%> (?)
unit 79.01% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/LiteGraphCanvasSplitterOverlay.vue 83.46% <100.00%> (ø)
src/constants/splitterConstants.ts 100.00% <100.00%> (ø)
...h/extensions/agent/stores/agent/agentPanelStore.ts 99.02% <100.00%> (ø)
src/components/graph/GraphCanvasMenu.vue 58.10% <18.18%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 27, 2026
@christian-byrne
christian-byrne merged commit da49632 into cloud/1.54 Sep 28, 2026
129 of 132 checks passed
@christian-byrne
christian-byrne deleted the backport-18182-to-cloud-1.54 branch September 28, 2026 03:11

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — d68e954d Deployed Sep 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants