Repository navigation
[core/1.54] fix(agent): keep the expanded agent panel inside the window (#18182) - #19039
Conversation
The agent panel kept its width when the window became narrower. An expanded panel went past the right edge of the window and out of sight. The panel now becomes narrower with the window, and it stops when it meets the sidebar. - **What**: - The width of the panel is now the result of two values. The first value is the width the user asked for. The second value is the space that the workspace to the left needs. - The panel becomes narrower when the window becomes narrower. The panel returns to the requested width when the window becomes wider again. The user does not lose the choice they made. - The workspace needs room for the side toolbar and for the sidebar. The panel stops at the sidebar. When no sidebar is open, the panel can use that room instead. - The maximize button read the panel width and compared it to a fixed number. A panel that the window made narrower failed that comparison, so the button showed the wrong icon. The button now reads explicit state. - The canvas toolbar at the bottom of the graph was anchored to the right edge. A toolbar wider than the canvas hung over the left edge and went behind the sidebar. The toolbar now stays inside the canvas. A toolbar with more buttons than the canvas holds scrolls sideways. - **The panel respects the minimum width of the sidebar, not the current width of the sidebar.** The sidebar is a percentage of the area beside the panel. If the panel reads the live width of the sidebar, the sidebar gets wider. A wider sidebar then makes the panel narrower again. This loop has no end. The minimum width breaks it. The effect is that a sidebar the user dragged wider still gives room back to the panel. - A window with less room than `PANEL_MIN_WIDTH` now gets a panel narrower than that minimum. A panel of 232px in a 600px window is poor, and a panel that leaves the window is worse. A window this narrow is below the desktop range. - `SIDE_TOOLBAR_WIDTH` is 56px. A measurement in the browser gave this number. It is the connected rail, which adds `--sidebar-padding` on each side of the 48px icons. My first value of 48px made the panel start 8px inside the rail. https://github.com/user-attachments/assets/e9a3554c-ac91-4de4-839f-5fb8a9469c7d Linear: [DES-1037](https://linear.app/comfyorg/issue/DES-1037/des-keep-expanded-agent-panel-within-window-bounds) --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit ffdf258)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1954 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-27T03:58:04.287Z",
"gitSha": "9d4f917779f259ea120aeb4f4ef6f541f4fd7d0d",
"branch": "backport-18182-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2051.378999999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.216999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.1790000000001,
"heapDeltaBytes": -11728012,
"heapUsedBytes": 58400036,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 9.790999999999997,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2039.7540000000163,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.691999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.102,
"heapDeltaBytes": 10192572,
"heapUsedBytes": 81328588,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.669999999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1878.1270000000063,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.047000000000004,
"layouts": 14,
"layoutDurationMs": 4.223,
"taskDurationMs": 901.1799999999998,
"heapDeltaBytes": 13133424,
"heapUsedBytes": 83908404,
"domNodes": -283,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 146.207,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1815.2479999999969,
"styleRecalcs": 75,
"styleRecalcDurationMs": 27.138,
"layouts": 14,
"layoutDurationMs": 3.8339999999999996,
"taskDurationMs": 880.509,
"heapDeltaBytes": 1577200,
"heapUsedBytes": 72508612,
"domNodes": -276,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 144.757,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1663.6960000000158,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.739000000000003,
"layouts": 6,
"layoutDurationMs": 1.0939999999999999,
"taskDurationMs": 354.519,
"heapDeltaBytes": 4633736,
"heapUsedBytes": 75708344,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.416000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.1879999999364,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.782999999999998,
"layouts": 6,
"layoutDurationMs": 1.0540000000000003,
"taskDurationMs": 372.614,
"heapDeltaBytes": 4582544,
"heapUsedBytes": 75803452,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.707000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 676.0540000000219,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.287999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.85699999999997,
"heapDeltaBytes": 18371716,
"heapUsedBytes": 88754288,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 152.581,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 659.9309999999718,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.781999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.71,
"heapDeltaBytes": 18041884,
"heapUsedBytes": 88322340,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 157.526,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2040.6239999999798,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.788,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 596.148,
"heapDeltaBytes": 10540676,
"heapUsedBytes": 87022492,
"domNodes": -273,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 34.151,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2045.913999999982,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.574000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.231,
"heapDeltaBytes": -15747284,
"heapUsedBytes": 86937704,
"domNodes": -267,
"jsHeapTotalBytes": -1376256,
"scriptDurationMs": 33.358,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2462.4579999999696,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.471,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1733.904,
"heapDeltaBytes": 11764000,
"heapUsedBytes": 88816552,
"domNodes": -271,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 803.598,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2269.9499999999944,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.317000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1636.4810000000002,
"heapDeltaBytes": 8276060,
"heapUsedBytes": 85585608,
"domNodes": -279,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 783.4350000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3786.2269999999967,
"styleRecalcs": 62,
"styleRecalcDurationMs": 13.109000000000002,
"layouts": 60,
"layoutDurationMs": 12.961,
"taskDurationMs": 1860.049,
"heapDeltaBytes": -2437740,
"heapUsedBytes": 76199056,
"domNodes": -278,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 798.551,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3598.287999999968,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.807999999999998,
"layouts": 60,
"layoutDurationMs": 12.190999999999999,
"taskDurationMs": 1705.7249999999997,
"heapDeltaBytes": 9948848,
"heapUsedBytes": 76984740,
"domNodes": -280,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 748.0219999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3189.5900000000097,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.824,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2123.005,
"heapDeltaBytes": 8468608,
"heapUsedBytes": 89154184,
"domNodes": -286,
"jsHeapTotalBytes": -995328,
"scriptDurationMs": 997.4129999999999,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3192.7949999999896,
"styleRecalcs": 44,
"styleRecalcDurationMs": 9.588999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2032.126,
"heapDeltaBytes": 786148,
"heapUsedBytes": 81537612,
"domNodes": -254,
"jsHeapTotalBytes": 1626112,
"scriptDurationMs": 953.13,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2009.4560000000001,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.500999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.79,
"heapDeltaBytes": 21820756,
"heapUsedBytes": 87758392,
"domNodes": -266,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.39399999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2063.2980000000316,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.727999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 642.221,
"heapDeltaBytes": 6391128,
"heapUsedBytes": 84119460,
"domNodes": -275,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 32.66100000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 693.2370000000105,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.755999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.246,
"heapDeltaBytes": 15100628,
"heapUsedBytes": 88508876,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 150.08700000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 616.7479999999159,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.005999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.069,
"heapDeltaBytes": 15108084,
"heapUsedBytes": 88411188,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 138.16099999999997,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.164000000027,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.569000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.708,
"heapDeltaBytes": -536328,
"heapUsedBytes": 71640052,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.12,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.0890000000222,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.65,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.0290000000001,
"heapDeltaBytes": -12975456,
"heapUsedBytes": 60309408,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.921999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.601000000007,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.737000000000005,
"layouts": 18,
"layoutDurationMs": 4.9719999999999995,
"taskDurationMs": 857.6779999999999,
"heapDeltaBytes": 4361572,
"heapUsedBytes": 77427360,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 103.566,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1752.6879999999778,
"styleRecalcs": 76,
"styleRecalcDurationMs": 26.295,
"layouts": 18,
"layoutDurationMs": 5.207,
"taskDurationMs": 880.4590000000001,
"heapDeltaBytes": 581696,
"heapUsedBytes": 73462596,
"domNodes": -297,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 109.294,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.317000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 30.091999999999995,
"layouts": 16,
"layoutDurationMs": 14.487,
"taskDurationMs": 937.7870000000001,
"heapDeltaBytes": 21096732,
"heapUsedBytes": 110271428,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 29.828000000000007,
"eventListeners": 2385,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8824.61699999999,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.206,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6120.538,
"heapDeltaBytes": 13905000,
"heapUsedBytes": 90290392,
"domNodes": -271,
"jsHeapTotalBytes": 1171456,
"scriptDurationMs": 2716.674,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8386.062999999922,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.466,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5951.628,
"heapDeltaBytes": -7717428,
"heapUsedBytes": 68926164,
"domNodes": -283,
"jsHeapTotalBytes": 3305472,
"scriptDurationMs": 2615.659,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15518.182999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14957.694,
"heapDeltaBytes": -60954268,
"heapUsedBytes": 178762164,
"domNodes": -8068,
"jsHeapTotalBytes": -18264064,
"scriptDurationMs": 237.917,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16218.876999999906,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15518.688,
"heapDeltaBytes": -32441872,
"heapUsedBytes": 179372356,
"domNodes": -8068,
"jsHeapTotalBytes": -17215488,
"scriptDurationMs": 249.05,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 18901.78199999997,
"styleRecalcs": 146,
"styleRecalcDurationMs": 17.427,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18607.194,
"heapDeltaBytes": -51417368,
"heapUsedBytes": 179929856,
"domNodes": -8068,
"jsHeapTotalBytes": -18264064,
"scriptDurationMs": 845.343,
"eventListeners": -14931,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20832.359999999993,
"styleRecalcs": 158,
"styleRecalcDurationMs": 19.323000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20507.804999999997,
"heapDeltaBytes": -37004288,
"heapUsedBytes": 177471304,
"domNodes": -8068,
"jsHeapTotalBytes": 4132864,
"scriptDurationMs": 948.984,
"eventListeners": -14899,
"totalBlockingTimeMs": 148,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5600.226000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.66199999999998,
"layouts": 20,
"layoutDurationMs": 23.805999999999994,
"taskDurationMs": 5533.977,
"heapDeltaBytes": -42244236,
"heapUsedBytes": 183801816,
"domNodes": -8068,
"jsHeapTotalBytes": 12169216,
"scriptDurationMs": 103.018,
"eventListeners": -14931,
"totalBlockingTimeMs": 275,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5691.149999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 94.78099999999998,
"layouts": 20,
"layoutDurationMs": 30.93499999999999,
"taskDurationMs": 5600.34,
"heapDeltaBytes": -53315332,
"heapUsedBytes": 174396224,
"domNodes": -8068,
"jsHeapTotalBytes": 1613824,
"scriptDurationMs": 99.518,
"eventListeners": -14931,
"totalBlockingTimeMs": 278,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7982.965999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7585.164000000001,
"heapDeltaBytes": 21905416,
"heapUsedBytes": 178581160,
"domNodes": -3,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 135.316,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7985.743999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7696.5329999999985,
"heapDeltaBytes": 8103424,
"heapUsedBytes": 178841352,
"domNodes": 0,
"jsHeapTotalBytes": -6815744,
"scriptDurationMs": 118.263,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 115.09499999999662,
"styleRecalcs": 9,
"styleRecalcDurationMs": 14.805000000000001,
"layouts": 2,
"layoutDurationMs": 0.7540000000000001,
"taskDurationMs": 77.748,
"heapDeltaBytes": 3117964,
"heapUsedBytes": 71410796,
"domNodes": 112,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.679000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 473.27800000005027,
"styleRecalcs": 15,
"styleRecalcDurationMs": 20.837,
"layouts": 3,
"layoutDurationMs": 0.913,
"taskDurationMs": 111.47900000000003,
"heapDeltaBytes": 4763168,
"heapUsedBytes": 73290668,
"domNodes": 121,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.890999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
CI caught two things I took too wholesale when resolving the conflicts. `useEventListener` came in with main's import line but is unused here: main uses it for the pagehide/pageshow handlers, which are not on this branch and are not part of this fix. The 'persists isOpen where the run-attribution flag reads it' test came in as collateral from adjacent hunks. It exercises `@/platform/telemetry/utils/getAgentPanelOpen`, which does not exist on this branch, and it guards a telemetry pairing unrelated to the panel clamp. Porting that util to carry a test would be scope the patch release did not ask for, so the test is dropped instead.
The hunk that widened the pinia import on main did not apply here, so an auto-merged use of getActivePinia had no import. The 1.55 branches took the widened import cleanly and are unaffected.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #19039 +/- ##
============================================
Coverage 83.81% 83.81%
============================================
Files 2107 2107
Lines 125139 125161 +22
Branches 31710 33583 +1873
============================================
+ Hits 104885 104905 +20
- Misses 20076 20078 +2
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Manual backport of #18182. The automated run failed on all four branches with real conflicts, so each is resolved by hand.
Conflicts and how they were resolved
browser_tests/tests/agent/agentPanelViewportDrag.spec.ts— dropped. The file does not exist on any release branch; it is main-only test infrastructure. The original commit only removed twotest.failmarkers from it, and those markers do not exist here, so there is nothing to carry over.src/components/graph/GraphCanvasMenu.vue— release toolbar kept, wrapper re-applied. The toolbar on this branch is the older one (stringifiedMinimapStyles,bg-comfy-menu-bg, a zoom-controls button) and has diverged substantially from main's. Taking main's version wholesale — which is what the PR on main did — would have imported an unrelated toolbar redesign into a release branch. Instead only the actual fix is applied: thepointer-events-none absolute inset-x-0 bottom-0 flexwrapper, andpointer-events-auto ml-auto max-w-full min-w-0 overflow-x-autoon theButtonGroup, replacing itsabsolute right-0 bottom-0. Every button, style binding and handler on this branch is untouched.agentPanelStore.ts— import line only. Took the incominguseEventListener, useWindowSize+clampimport.es-toolkitis already a dependency here (^1.39.9).agentPanelStore.test.ts— purely additive. The conflict had an empty base side; the new clamping tests were taken as-is, and the helpers they use (resizeWindowTo,SIDEBAR_OPEN,SIDEBAR_CLOSED) came in with the same patch.Verification
Conflict markers: none remain anywhere in
src/orbrowser_tests/. Formatted withoxfmt.I could not meaningfully run the unit tests locally: a worktree of a release branch against main's
node_modulesis broken on its own. The control proves it — pristinecore/1.55with no backport applied fails 27 of 27 in that harness, while the backported tree gets 14 passing. So the local numbers measure the harness, not the change, and I am not claiming them as a pass. CI on this branch is the real check.Extra conflicts specific to the 1.54 branches
LiteGraphCanvasSplitterOverlay.test.ts— this branch stubs@/stores/authStoredirectly where main mocksfirebase/auth. Kept the branch's stub, added the two incoming imports (useSidebarTabStore,SidebarTabExtension— both used twice by the new cases), and dropped the incomingvi.mock(import('firebase/auth')), which would have been the only reference to firebase in the file.DockedAgentPanel.test.ts— import union. The branch needscreatePinia/setActivePinia, the incoming tests needonTestFinished; all three are used.