Repository navigation
[cloud/1.55] fix(agent): keep the expanded agent panel inside the window (#18182) - #19038
Conversation
The agent panel kept its width when the window became narrower. An expanded panel went past the right edge of the window and out of sight. The panel now becomes narrower with the window, and it stops when it meets the sidebar. - **What**: - The width of the panel is now the result of two values. The first value is the width the user asked for. The second value is the space that the workspace to the left needs. - The panel becomes narrower when the window becomes narrower. The panel returns to the requested width when the window becomes wider again. The user does not lose the choice they made. - The workspace needs room for the side toolbar and for the sidebar. The panel stops at the sidebar. When no sidebar is open, the panel can use that room instead. - The maximize button read the panel width and compared it to a fixed number. A panel that the window made narrower failed that comparison, so the button showed the wrong icon. The button now reads explicit state. - The canvas toolbar at the bottom of the graph was anchored to the right edge. A toolbar wider than the canvas hung over the left edge and went behind the sidebar. The toolbar now stays inside the canvas. A toolbar with more buttons than the canvas holds scrolls sideways. - **The panel respects the minimum width of the sidebar, not the current width of the sidebar.** The sidebar is a percentage of the area beside the panel. If the panel reads the live width of the sidebar, the sidebar gets wider. A wider sidebar then makes the panel narrower again. This loop has no end. The minimum width breaks it. The effect is that a sidebar the user dragged wider still gives room back to the panel. - A window with less room than `PANEL_MIN_WIDTH` now gets a panel narrower than that minimum. A panel of 232px in a 600px window is poor, and a panel that leaves the window is worse. A window this narrow is below the desktop range. - `SIDE_TOOLBAR_WIDTH` is 56px. A measurement in the browser gave this number. It is the connected rail, which adds `--sidebar-padding` on each side of the 48px icons. My first value of 48px made the panel start 8px inside the rail. https://github.com/user-attachments/assets/e9a3554c-ac91-4de4-839f-5fb8a9469c7d Linear: [DES-1037](https://linear.app/comfyorg/issue/DES-1037/des-keep-expanded-agent-panel-within-window-bounds) --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit ffdf258)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3e437226c9f677228843fd696602d994dcc1d49d
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-27T05:25:20.351Z",
"gitSha": "3b14c17416219ec4d47a5128df5e51328ab14d4f",
"branch": "backport-18182-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.840000000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.783,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.782,
"heapDeltaBytes": 10462688,
"heapUsedBytes": 78054156,
"domNodes": -259,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.275000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1997.9429999999638,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.069,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.031,
"heapDeltaBytes": 10915176,
"heapUsedBytes": 78724496,
"domNodes": -262,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.822000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1758.803999999941,
"styleRecalcs": 48,
"styleRecalcDurationMs": 15.746999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 786.9699999999999,
"heapDeltaBytes": -341912,
"heapUsedBytes": 67255944,
"domNodes": -259,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 160.914,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.265000000014,
"styleRecalcs": 48,
"styleRecalcDurationMs": 17.576,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 843.32,
"heapDeltaBytes": -494788,
"heapUsedBytes": 67173756,
"domNodes": -260,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 168.238,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.5109999999831,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.788999999999998,
"layouts": 6,
"layoutDurationMs": 1.2249999999999999,
"taskDurationMs": 322.04299999999995,
"heapDeltaBytes": 3049404,
"heapUsedBytes": 70548192,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.452999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1711.7979999999307,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.625,
"layouts": 6,
"layoutDurationMs": 0.9980000000000002,
"taskDurationMs": 293.033,
"heapDeltaBytes": 3197024,
"heapUsedBytes": 70544696,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 14.101000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 615.1570000000675,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.8469999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.6290000000001,
"heapDeltaBytes": 18594120,
"heapUsedBytes": 86230056,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 166.781,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 658.5549999999785,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.666,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.441,
"heapDeltaBytes": 18949824,
"heapUsedBytes": 85713412,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 172.491,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1202.177000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 859.917,
"heapDeltaBytes": 38997260,
"heapUsedBytes": 104276524,
"domNodes": -294,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 72.25800000000001,
"eventListeners": -195,
"totalBlockingTimeMs": 576,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1160.062000000039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 806.837,
"heapDeltaBytes": 38846532,
"heapUsedBytes": 105346016,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 67.205,
"eventListeners": 0,
"totalBlockingTimeMs": 535,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.0860000000239,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.05499999999955,
"heapDeltaBytes": 14260780,
"heapUsedBytes": 90610304,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.57100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 239,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 855.6020000000899,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.93900000000036,
"heapDeltaBytes": 14715424,
"heapUsedBytes": 90947000,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.08900000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11044.674999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10114.989000000001,
"heapDeltaBytes": 8645072,
"heapUsedBytes": 86048860,
"domNodes": -16,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8340.795,
"eventListeners": 0,
"totalBlockingTimeMs": 1344,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10437.080000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9595.24,
"heapDeltaBytes": -4975700,
"heapUsedBytes": 72186048,
"domNodes": -273,
"jsHeapTotalBytes": 2351104,
"scriptDurationMs": 7923.344,
"eventListeners": -174,
"totalBlockingTimeMs": 1173,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11724.124000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10801.351999999999,
"heapDeltaBytes": -4347964,
"heapUsedBytes": 78127264,
"domNodes": -16,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 9073.751999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1899,
"frameDurationMs": 19.996666666666595,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11812.540000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10820.907,
"heapDeltaBytes": 2468036,
"heapUsedBytes": 84573048,
"domNodes": -14,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 9135.796,
"eventListeners": 0,
"totalBlockingTimeMs": 1807,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2056.1800000000403,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.681,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.8460000000001,
"heapDeltaBytes": -7050380,
"heapUsedBytes": 79920448,
"domNodes": -250,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 36.371,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2025.7159999999885,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.1739999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.377,
"heapDeltaBytes": -3608660,
"heapUsedBytes": 83373132,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 34.702,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2242.9220000000214,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.097,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1645.083,
"heapDeltaBytes": 19745752,
"heapUsedBytes": 84372528,
"domNodes": -242,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 857.2109999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2278.188,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.765000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1682.415,
"heapDeltaBytes": -3375648,
"heapUsedBytes": 84325448,
"domNodes": -245,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 848.671,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3515.544000000091,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.887000000000002,
"layouts": 60,
"layoutDurationMs": 12.612000000000002,
"taskDurationMs": 1662.774,
"heapDeltaBytes": 9415532,
"heapUsedBytes": 74972180,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 792.6270000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3644.468999999958,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.687,
"layouts": 60,
"layoutDurationMs": 13.432999999999998,
"taskDurationMs": 1754.0780000000002,
"heapDeltaBytes": 8123188,
"heapUsedBytes": 74121696,
"domNodes": 6,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 815.7169999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3051.4249999999947,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.045999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1905.195,
"heapDeltaBytes": 23664392,
"heapUsedBytes": 90042872,
"domNodes": 8,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 998.3029999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3165.1480000000447,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.821,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1975.3220000000003,
"heapDeltaBytes": 872084,
"heapUsedBytes": 66608528,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 997.203,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.3069999999643,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.599,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.956,
"heapDeltaBytes": 20618528,
"heapUsedBytes": 84595880,
"domNodes": -246,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.862,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2030.6040000000394,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.455000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.843,
"heapDeltaBytes": -4752760,
"heapUsedBytes": 84214492,
"domNodes": -250,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 33.649,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.5370000000867,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.719,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.63699999999994,
"heapDeltaBytes": 13788172,
"heapUsedBytes": 83522816,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 141.88500000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.2380000000003,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.370000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.94599999999997,
"heapDeltaBytes": 14059996,
"heapUsedBytes": 84187584,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 149.518,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2001.2980000000198,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.017999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.09200000000004,
"heapDeltaBytes": 987564,
"heapUsedBytes": 70979668,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.748999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2002.81700000005,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.289000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.27599999999995,
"heapDeltaBytes": 10717448,
"heapUsedBytes": 80890012,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.5,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.6570000000538,
"styleRecalcs": 47,
"styleRecalcDurationMs": 16.686,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 638.86,
"heapDeltaBytes": 7367664,
"heapUsedBytes": 76321012,
"domNodes": -272,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 107.431,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.646000000058,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.735999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 721.109,
"heapDeltaBytes": -3195196,
"heapUsedBytes": 60318484,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 102.33500000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.7450000000135,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.250000000000004,
"layouts": 5,
"layoutDurationMs": 13.214,
"taskDurationMs": 857.345,
"heapDeltaBytes": -6215484,
"heapUsedBytes": 82247160,
"domNodes": 13667,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 30.180000000000007,
"eventListeners": 2383,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8272.918000000005,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.19,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5183.96,
"heapDeltaBytes": -19698332,
"heapUsedBytes": 67210156,
"domNodes": -248,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 2834.683,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8521.355999999969,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.815000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6023.294,
"heapDeltaBytes": -10473212,
"heapUsedBytes": 76120432,
"domNodes": -241,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 2808.874,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 12630.141999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11792.087000000001,
"heapDeltaBytes": -45364840,
"heapUsedBytes": 195515552,
"domNodes": -8062,
"jsHeapTotalBytes": -11210752,
"scriptDurationMs": 216.021,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17005.51999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16629.449,
"heapDeltaBytes": -44907316,
"heapUsedBytes": 168817348,
"domNodes": -8061,
"jsHeapTotalBytes": -12115968,
"scriptDurationMs": 293.24,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20236.117000000035,
"styleRecalcs": 160,
"styleRecalcDurationMs": 16.145999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19891.308,
"heapDeltaBytes": -65665252,
"heapUsedBytes": 169128048,
"domNodes": -8061,
"jsHeapTotalBytes": -13381632,
"scriptDurationMs": 866.182,
"eventListeners": -14928,
"totalBlockingTimeMs": 40,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20870.38300000006,
"styleRecalcs": 156,
"styleRecalcDurationMs": 18.875999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20658.22,
"heapDeltaBytes": -49061356,
"heapUsedBytes": 192416908,
"domNodes": -8061,
"jsHeapTotalBytes": -21962752,
"scriptDurationMs": 932.325,
"eventListeners": -14928,
"totalBlockingTimeMs": 66,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5962.44200000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.64600000000002,
"layouts": 20,
"layoutDurationMs": 22.469,
"taskDurationMs": 5827.647999999999,
"heapDeltaBytes": 1837264,
"heapUsedBytes": 175823772,
"domNodes": -8061,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 112.46700000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 409,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6118.96200000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.763,
"layouts": 20,
"layoutDurationMs": 24.040000000000006,
"taskDurationMs": 6059.310999999999,
"heapDeltaBytes": -47381180,
"heapUsedBytes": 180205116,
"domNodes": -8061,
"jsHeapTotalBytes": 9760768,
"scriptDurationMs": 112.24600000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 476,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8369.053000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8143.5819999999985,
"heapDeltaBytes": 15673884,
"heapUsedBytes": 188687552,
"domNodes": 0,
"jsHeapTotalBytes": -29622272,
"scriptDurationMs": 156.62499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8703.08399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8508.999999999998,
"heapDeltaBytes": -5460660,
"heapUsedBytes": 176073280,
"domNodes": 0,
"jsHeapTotalBytes": -18350080,
"scriptDurationMs": 157.49800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 470.766000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.068,
"layouts": 4,
"layoutDurationMs": 1.942,
"taskDurationMs": 131.011,
"heapDeltaBytes": 5302440,
"heapUsedBytes": 70810784,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.384,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 107.29000000003452,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.438000000000002,
"layouts": 2,
"layoutDurationMs": 0.7220000000000001,
"taskDurationMs": 76.028,
"heapDeltaBytes": 3065328,
"heapUsedBytes": 68765756,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.768999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
CI caught two things I took too wholesale when resolving the conflicts. `useEventListener` came in with main's import line but is unused here: main uses it for the pagehide/pageshow handlers, which are not on this branch and are not part of this fix. The 'persists isOpen where the run-attribution flag reads it' test came in as collateral from adjacent hunks. It exercises `@/platform/telemetry/utils/getAgentPanelOpen`, which does not exist on this branch, and it guards a telemetry pairing unrelated to the panel clamp. Porting that util to carry a test would be scope the patch release did not ask for, so the test is dropped instead.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19038 +/- ##
=============================================
Coverage ? 84.60%
=============================================
Files ? 2297
Lines ? 131688
Branches ? 33396
=============================================
Hits ? 111420
Misses ? 19955
Partials ? 313
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The cherry-pick retargeted this assertion from 'width' to 'targetTracking' because width becomes a computed with this change and so leaves pinia state. This branch has no targetTracking, and the change's own reservedWorkspaceWidth is internal rather than returned, so neither works here. The store returns seven writable refs; workflowTargetSelection is one, and pins the same property the test is named for.
Manual backport of #18182. The automated run failed on all four branches with real conflicts, so each is resolved by hand.
Conflicts and how they were resolved
browser_tests/tests/agent/agentPanelViewportDrag.spec.ts— dropped. The file does not exist on any release branch; it is main-only test infrastructure. The original commit only removed twotest.failmarkers from it, and those markers do not exist here, so there is nothing to carry over.src/components/graph/GraphCanvasMenu.vue— release toolbar kept, wrapper re-applied. The toolbar on this branch is the older one (stringifiedMinimapStyles,bg-comfy-menu-bg, a zoom-controls button) and has diverged substantially from main's. Taking main's version wholesale — which is what the PR on main did — would have imported an unrelated toolbar redesign into a release branch. Instead only the actual fix is applied: thepointer-events-none absolute inset-x-0 bottom-0 flexwrapper, andpointer-events-auto ml-auto max-w-full min-w-0 overflow-x-autoon theButtonGroup, replacing itsabsolute right-0 bottom-0. Every button, style binding and handler on this branch is untouched.agentPanelStore.ts— import line only. Took the incominguseEventListener, useWindowSize+clampimport.es-toolkitis already a dependency here (^1.39.9).agentPanelStore.test.ts— purely additive. The conflict had an empty base side; the new clamping tests were taken as-is, and the helpers they use (resizeWindowTo,SIDEBAR_OPEN,SIDEBAR_CLOSED) came in with the same patch.Verification
Conflict markers: none remain anywhere in
src/orbrowser_tests/. Formatted withoxfmt.I could not meaningfully run the unit tests locally: a worktree of a release branch against main's
node_modulesis broken on its own. The control proves it — pristinecore/1.55with no backport applied fails 27 of 27 in that harness, while the backported tree gets 14 passing. So the local numbers measure the harness, not the change, and I am not claiming them as a pass. CI on this branch is the real check.