Repository navigation
Measure spent automatic consent offers - #19034
christian-byrne wants to merge 1 commit into
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2140 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (7 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2ea640aa4d6d01def161e9ec2870acd01ab21e05
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 134 kB (baseline 134 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.98 MB (baseline 3.98 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 15 unchanged Utilities & Hooks — 576 kB (baseline 576 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category Status: 301 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-27T03:05:35.416Z",
"gitSha": "c1b12c78a6bb7c06fbf4371fb0ff49c4f8f998b0",
"branch": "gc-40-consent-oneshot",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.4289999999824,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.62,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.682,
"heapDeltaBytes": 12325592,
"heapUsedBytes": 74114728,
"domNodes": -228,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.981999999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2021.5289999999868,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.139,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.352,
"heapDeltaBytes": 8645428,
"heapUsedBytes": 71046332,
"domNodes": -228,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.272000000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1796.1859999999774,
"styleRecalcs": 72,
"styleRecalcDurationMs": 17.244,
"layouts": 12,
"layoutDurationMs": 4.922999999999999,
"taskDurationMs": 754.077,
"heapDeltaBytes": 1242624,
"heapUsedBytes": 62275948,
"domNodes": -228,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 171.28199999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1770.7309999999552,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.903999999999996,
"layouts": 12,
"layoutDurationMs": 4.6129999999999995,
"taskDurationMs": 743.214,
"heapDeltaBytes": 4166704,
"heapUsedBytes": 65911828,
"domNodes": -228,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 174.47899999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.6730000000389,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.636999999999999,
"layouts": 6,
"layoutDurationMs": 1.4089999999999998,
"taskDurationMs": 328.0850000000001,
"heapDeltaBytes": 2173148,
"heapUsedBytes": 64557720,
"domNodes": 53,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.588000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.9949999999826,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.044,
"layouts": 6,
"layoutDurationMs": 1.257,
"taskDurationMs": 323.249,
"heapDeltaBytes": 2100436,
"heapUsedBytes": 64494060,
"domNodes": 53,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.412000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 709.6789999999942,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.9830000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.508,
"heapDeltaBytes": 19385008,
"heapUsedBytes": 80584320,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 171.95300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 648.8169999998945,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.126999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.08099999999996,
"heapDeltaBytes": 18817116,
"heapUsedBytes": 81129456,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 171.29,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1192.0479999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 865.35,
"heapDeltaBytes": 34777488,
"heapUsedBytes": 101429776,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 68.88299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 579,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1274.0350000000262,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 991.259,
"heapDeltaBytes": -14839204,
"heapUsedBytes": 72691756,
"domNodes": -259,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 74.234,
"eventListeners": -207,
"totalBlockingTimeMs": 603,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.331000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.805,
"heapDeltaBytes": 14941244,
"heapUsedBytes": 91899424,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.325,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.8759999999857,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.77099999999996,
"heapDeltaBytes": 15754360,
"heapUsedBytes": 91213268,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 178.60000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11082.980000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10093.349,
"heapDeltaBytes": -10628764,
"heapUsedBytes": 71987504,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8416.454000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 1591,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11085.00700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10058.911,
"heapDeltaBytes": -13532908,
"heapUsedBytes": 69346964,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8276.128,
"eventListeners": 0,
"totalBlockingTimeMs": 1462,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8982.708000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8304.154,
"heapDeltaBytes": 8426900,
"heapUsedBytes": 85231440,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7070.62,
"eventListeners": 0,
"totalBlockingTimeMs": 1112,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11568.61600000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10486.236,
"heapDeltaBytes": -2792936,
"heapUsedBytes": 74500348,
"domNodes": -228,
"jsHeapTotalBytes": 2088960,
"scriptDurationMs": 8629.854,
"eventListeners": -164,
"totalBlockingTimeMs": 1567,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 1983.0600000000231,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.146000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.478,
"heapDeltaBytes": 19687392,
"heapUsedBytes": 83693588,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.634999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2029.8749999999472,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2090000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.216,
"heapDeltaBytes": 2596376,
"heapUsedBytes": 83231360,
"domNodes": -228,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 30.829000000000008,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2396.965000000023,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.552999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1605.0900000000001,
"heapDeltaBytes": 24306228,
"heapUsedBytes": 88928976,
"domNodes": -228,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 840.729,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2415.66899999998,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.884,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1634.008,
"heapDeltaBytes": -1109640,
"heapUsedBytes": 81064160,
"domNodes": -228,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 855.562,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3647.3529999999528,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.895,
"layouts": 60,
"layoutDurationMs": 13.383000000000001,
"taskDurationMs": 1710.7730000000001,
"heapDeltaBytes": -8840480,
"heapUsedBytes": 74788604,
"domNodes": -228,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 790.3599999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3582.5059999999667,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.463999999999997,
"layouts": 60,
"layoutDurationMs": 13.385000000000002,
"taskDurationMs": 1668.7369999999999,
"heapDeltaBytes": 7805920,
"heapUsedBytes": 74417736,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 785.048,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3142.24999999999,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.409999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1930.605,
"heapDeltaBytes": 28145452,
"heapUsedBytes": 94073860,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1009.0670000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3087.5260000000253,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.5459999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1867.143,
"heapDeltaBytes": 25217612,
"heapUsedBytes": 91223872,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 954.3600000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.0110000000295,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0909999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 736.953,
"heapDeltaBytes": 19665532,
"heapUsedBytes": 84076120,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 44.61799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2018.3980000000474,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3609999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.9340000000001,
"heapDeltaBytes": -4464752,
"heapUsedBytes": 84050128,
"domNodes": -228,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 35.91899999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 601.6560000000482,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.743999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.6770000000001,
"heapDeltaBytes": 14039616,
"heapUsedBytes": 76870228,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.091,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.3879999999808,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.902000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.013,
"heapDeltaBytes": 13534788,
"heapUsedBytes": 77152688,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 145.19400000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.3279999999963,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.270999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.9219999999999,
"heapDeltaBytes": 8922700,
"heapUsedBytes": 72630140,
"domNodes": -244,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.971000000000002,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.1780000000672,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.1899999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.70799999999997,
"heapDeltaBytes": 3025424,
"heapUsedBytes": 66455776,
"domNodes": -244,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.286999999999998,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1715.537999999981,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.335999999999995,
"layouts": 16,
"layoutDurationMs": 5.505,
"taskDurationMs": 773.531,
"heapDeltaBytes": -4435112,
"heapUsedBytes": 59229424,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 110.74499999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.6529999999702,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.237000000000002,
"layouts": 16,
"layoutDurationMs": 5.7059999999999995,
"taskDurationMs": 761.235,
"heapDeltaBytes": 7853220,
"heapUsedBytes": 71582280,
"domNodes": -244,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 111.508,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1433.2429999999476,
"styleRecalcs": 17,
"styleRecalcDurationMs": 32.139,
"layouts": 5,
"layoutDurationMs": 14.030999999999999,
"taskDurationMs": 1038.916,
"heapDeltaBytes": 21343056,
"heapUsedBytes": 101448372,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 36.36099999999999,
"eventListeners": 2383,
"totalBlockingTimeMs": 161,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8492.36499999995,
"styleRecalcs": 249,
"styleRecalcDurationMs": 31.045,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5697.4839999999995,
"heapDeltaBytes": -939184,
"heapUsedBytes": 80664444,
"domNodes": -228,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 2801.926,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8363.642000000027,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.226,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5280.643999999999,
"heapDeltaBytes": -15253128,
"heapUsedBytes": 66287424,
"domNodes": -228,
"jsHeapTotalBytes": 2125824,
"scriptDurationMs": 2885.5750000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18264.939000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17835.737999999998,
"heapDeltaBytes": -61584596,
"heapUsedBytes": 178193632,
"domNodes": -8049,
"jsHeapTotalBytes": -17326080,
"scriptDurationMs": 298.586,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16936.378999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16505.657,
"heapDeltaBytes": -38966308,
"heapUsedBytes": 200734120,
"domNodes": -8049,
"jsHeapTotalBytes": -13750272,
"scriptDurationMs": 259.923,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21815.686000000027,
"styleRecalcs": 151,
"styleRecalcDurationMs": 20.518000000000036,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21635.629999999997,
"heapDeltaBytes": -47816460,
"heapUsedBytes": 191898680,
"domNodes": -8049,
"jsHeapTotalBytes": -17788928,
"scriptDurationMs": 918.385,
"eventListeners": -14923,
"totalBlockingTimeMs": 106,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 20781.566999999995,
"styleRecalcs": 169,
"styleRecalcDurationMs": 15.786999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20426.195,
"heapDeltaBytes": -69847004,
"heapUsedBytes": 170028704,
"domNodes": -8049,
"jsHeapTotalBytes": -19030016,
"scriptDurationMs": 860.8249999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 43,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6508.138000000031,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.41100000000002,
"layouts": 20,
"layoutDurationMs": 28.19399999999998,
"taskDurationMs": 6433.584,
"heapDeltaBytes": -47355344,
"heapUsedBytes": 171094108,
"domNodes": -8049,
"jsHeapTotalBytes": 14147584,
"scriptDurationMs": 127.44800000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 335,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6031.6819999999325,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.684,
"layouts": 20,
"layoutDurationMs": 22.573999999999998,
"taskDurationMs": 5949.026000000001,
"heapDeltaBytes": -41830260,
"heapUsedBytes": 183268120,
"domNodes": -8048,
"jsHeapTotalBytes": 15458304,
"scriptDurationMs": 106.22700000000002,
"eventListeners": -14923,
"totalBlockingTimeMs": 341,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8931.708000000071,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8777.568000000001,
"heapDeltaBytes": 539656,
"heapUsedBytes": 198002164,
"domNodes": 0,
"jsHeapTotalBytes": -22806528,
"scriptDurationMs": 140.07800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8457.685999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8224.263,
"heapDeltaBytes": -15870972,
"heapUsedBytes": 171404296,
"domNodes": 0,
"jsHeapTotalBytes": -7602176,
"scriptDurationMs": 145.1140000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 128.4369999999626,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.948,
"layouts": 3,
"layoutDurationMs": 1.5650000000000002,
"taskDurationMs": 92.67799999999998,
"heapDeltaBytes": 3169848,
"heapUsedBytes": 65197440,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.213000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 112.29500000001735,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.265,
"layouts": 3,
"layoutDurationMs": 1.2779999999999998,
"taskDurationMs": 84.85300000000001,
"heapDeltaBytes": 3070236,
"heapUsedBytes": 65067228,
"domNodes": 94,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.232000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe consent-offer flow now reports ChangesConsent offer reporting
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The consent-offer measurement change has no established merge-blocking risk. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19034 +/- ##
==========================================
+ Coverage 84.03% 84.93% +0.90%
==========================================
Files 3158 2309 -849
Lines 154414 133076 -21338
Branches 40011 35969 -4042
==========================================
- Hits 129763 113033 -16730
+ Misses 23046 19725 -3321
+ Partials 1605 318 -1287
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 856 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Closing as superseded by #18978, which is merged and records this same spent-one-shot-key state through app:agent_consent_offer_exited with exit=already_offered and stage=offer. Current main includes regression coverage for that case. The conflict here is in that same reporting branch, so this no longer needs a separate event path. |
Summary
Emit the existing consent-not-offered event with
reason=already_offeredwhen a browser one-shot key is set but server-backed consent is absent. This makes the terminal state measurable before deciding whether re-offering is safe.Changes
Review Focus
The key is deliberately not cleared: an absent server setting also covers rejection, dismissal, and save failure, so clearing it would re-offer on every load without evidence that the state is a revocation.