Repository navigation
[backport core/1.55] FE-2897 feat(account-core): session lifecycle, create on sign-in, delete on sign-out, heartbeat - #19020
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky📊 Browser Reports
🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6ddb354bba1dd2af8d906003c720ec37ae716682
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-27T05:59:55.098Z",
"gitSha": "907cb6e6e190ca0175ec591cbfcb154ccc385a1d",
"branch": "backport-18719-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1999.9070000000074,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.764,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.642,
"heapDeltaBytes": -9488232,
"heapUsedBytes": 58304028,
"domNodes": -258,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.548,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1992.8840000000037,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.149,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.99199999999996,
"heapDeltaBytes": -6618096,
"heapUsedBytes": 55850824,
"domNodes": -257,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.4959999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.6729999999898,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.377999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.559,
"heapDeltaBytes": 9036296,
"heapUsedBytes": 76849588,
"domNodes": -256,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 92.39,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.2749999999241,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.7719999999999,
"heapDeltaBytes": 5626352,
"heapUsedBytes": 73242656,
"domNodes": -258,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 101.909,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.4899999999975,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.8,
"layouts": 6,
"layoutDurationMs": 0.85,
"taskDurationMs": 234.047,
"heapDeltaBytes": 3076572,
"heapUsedBytes": 70813960,
"domNodes": 79,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8.199,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.801000000065,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.222999999999999,
"layouts": 6,
"layoutDurationMs": 0.9229999999999999,
"taskDurationMs": 224.742,
"heapDeltaBytes": 3148120,
"heapUsedBytes": 70767940,
"domNodes": 79,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7.237,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 465.802999999994,
"styleRecalcs": 14,
"styleRecalcDurationMs": 5.952,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.154,
"heapDeltaBytes": 18313904,
"heapUsedBytes": 86050376,
"domNodes": 23,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 104.78299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 493.19600000001174,
"styleRecalcs": 14,
"styleRecalcDurationMs": 5.885000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.312,
"heapDeltaBytes": 18639100,
"heapUsedBytes": 86491676,
"domNodes": 23,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 107.97500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1006.5830000000346,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 639.486,
"heapDeltaBytes": -13514464,
"heapUsedBytes": 72819980,
"domNodes": -294,
"jsHeapTotalBytes": 19267584,
"scriptDurationMs": 39.525999999999996,
"eventListeners": -217,
"totalBlockingTimeMs": 374,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 968.3610000000158,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.096,
"heapDeltaBytes": 38656476,
"heapUsedBytes": 105076116,
"domNodes": -259,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 42.01199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 355,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 700.0089999999659,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.80899999999997,
"heapDeltaBytes": 14269040,
"heapUsedBytes": 90674096,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 88.68199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 100,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 697.3910000000387,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.4930000000002,
"heapDeltaBytes": 14811604,
"heapUsedBytes": 91900276,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 85.259,
"eventListeners": 0,
"totalBlockingTimeMs": 96,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6009.342000000004,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.9200000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5054.664,
"heapDeltaBytes": 17535552,
"heapUsedBytes": 91212164,
"domNodes": 4,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 3932.596,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5469.454999999982,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.8090000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4739.268,
"heapDeltaBytes": -756260,
"heapUsedBytes": 81263404,
"domNodes": -14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 3774.344,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5849.619999999959,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6390000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4927.339,
"heapDeltaBytes": 499936,
"heapUsedBytes": 82305584,
"domNodes": -16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 3774.127,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5791.446000000007,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.9359999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5059.7029999999995,
"heapDeltaBytes": 9514668,
"heapUsedBytes": 82321176,
"domNodes": -8,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 3903.866,
"eventListeners": 0,
"totalBlockingTimeMs": 27,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2007.6859999999783,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.241,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.99700000000007,
"heapDeltaBytes": -7329004,
"heapUsedBytes": 79976524,
"domNodes": -238,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 26.338000000000008,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.290999999972,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.855,
"heapDeltaBytes": -7677348,
"heapUsedBytes": 79907376,
"domNodes": -238,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 25.748,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2138.4369999999535,
"styleRecalcs": 70,
"styleRecalcDurationMs": 18.106,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1244.0990000000002,
"heapDeltaBytes": -1011896,
"heapUsedBytes": 80362368,
"domNodes": -242,
"jsHeapTotalBytes": 741376,
"scriptDurationMs": 599.75,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2121.3050000000067,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.811000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1094.0620000000001,
"heapDeltaBytes": -8277584,
"heapUsedBytes": 79800696,
"domNodes": -240,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 514.64,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3130.442999999957,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.308,
"layouts": 60,
"layoutDurationMs": 13.738,
"taskDurationMs": 1227.0780000000002,
"heapDeltaBytes": -8610288,
"heapUsedBytes": 74251580,
"domNodes": -239,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 557.573,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3112.2080000000096,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.286000000000001,
"layouts": 60,
"layoutDurationMs": 12.497,
"taskDurationMs": 1244.2869999999998,
"heapDeltaBytes": -15470640,
"heapUsedBytes": 74025436,
"domNodes": -241,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 527.7109999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2172.8350000000205,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.489,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1386.7100000000003,
"heapDeltaBytes": -1196732,
"heapUsedBytes": 83215000,
"domNodes": -242,
"jsHeapTotalBytes": -638976,
"scriptDurationMs": 662.864,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2205.2909999999883,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.337999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1247.874,
"heapDeltaBytes": -20251648,
"heapUsedBytes": 71261476,
"domNodes": -213,
"jsHeapTotalBytes": 1601536,
"scriptDurationMs": 583.422,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.0289999999654,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.365000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.0130000000001,
"heapDeltaBytes": -6502460,
"heapUsedBytes": 83408444,
"domNodes": -243,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 24.28299999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.2480000000141,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.273,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.92799999999994,
"heapDeltaBytes": -5763440,
"heapUsedBytes": 83367460,
"domNodes": -239,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 24.286,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 413.52799999998524,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.3260000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 268.022,
"heapDeltaBytes": 13621732,
"heapUsedBytes": 76838900,
"domNodes": 23,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 91.126,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 413.5559999999714,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.316,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 267.961,
"heapDeltaBytes": 13728700,
"heapUsedBytes": 83612552,
"domNodes": 23,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 89.074,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1989.3509999999992,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.172000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.93600000000004,
"heapDeltaBytes": -4694996,
"heapUsedBytes": 65221452,
"domNodes": -272,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.114000000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2005.3839999999354,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.187000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.33299999999997,
"heapDeltaBytes": -4561680,
"heapUsedBytes": 58742856,
"domNodes": -272,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.433999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.677000000017,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.908000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.4649999999999,
"heapDeltaBytes": -4300976,
"heapUsedBytes": 58965004,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 60.977999999999994,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.8360000000803,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.581,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.785,
"heapDeltaBytes": -8501052,
"heapUsedBytes": 61662348,
"domNodes": -272,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 61.324,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 799.1079999999897,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.259999999999998,
"layouts": 5,
"layoutDurationMs": 7.613000000000001,
"taskDurationMs": 579.461,
"heapDeltaBytes": 20216936,
"heapUsedBytes": 103424440,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 17.983000000000008,
"eventListeners": 2383,
"totalBlockingTimeMs": 88,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8168.255999999985,
"styleRecalcs": 252,
"styleRecalcDurationMs": 36.407999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4240.988,
"heapDeltaBytes": 13871740,
"heapUsedBytes": 101156420,
"domNodes": -205,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 1962.7020000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8126.521000000025,
"styleRecalcs": 249,
"styleRecalcDurationMs": 25.568,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3689.8689999999997,
"heapDeltaBytes": -7389100,
"heapUsedBytes": 80193460,
"domNodes": -240,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 1667.424,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10725.880999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9854.706,
"heapDeltaBytes": -48448808,
"heapUsedBytes": 165662604,
"domNodes": -8062,
"jsHeapTotalBytes": -11808768,
"scriptDurationMs": 146.969,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10189.327999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9084.628999999999,
"heapDeltaBytes": -60884820,
"heapUsedBytes": 179978376,
"domNodes": -8062,
"jsHeapTotalBytes": -17297408,
"scriptDurationMs": 121.91199999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13378.635999999971,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.278000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12760.775000000003,
"heapDeltaBytes": -42863368,
"heapUsedBytes": 171202848,
"domNodes": -8062,
"jsHeapTotalBytes": -10235904,
"scriptDurationMs": 625.245,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13067.221000000018,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.136999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12451.688999999998,
"heapDeltaBytes": -64383044,
"heapUsedBytes": 176944788,
"domNodes": -8062,
"jsHeapTotalBytes": -13045760,
"scriptDurationMs": 601.5429999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 6,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3770.8770000000413,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.894999999999996,
"layouts": 20,
"layoutDurationMs": 19.195999999999998,
"taskDurationMs": 3581.424,
"heapDeltaBytes": -47572888,
"heapUsedBytes": 193759624,
"domNodes": -8061,
"jsHeapTotalBytes": 9760768,
"scriptDurationMs": 56.241,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3633.472999999981,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.43600000000001,
"layouts": 20,
"layoutDurationMs": 20.653000000000006,
"taskDurationMs": 3460.1749999999997,
"heapDeltaBytes": -36631452,
"heapUsedBytes": 183857288,
"domNodes": -8062,
"jsHeapTotalBytes": 14090240,
"scriptDurationMs": 55.46199999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 59,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5358.111999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5002.245,
"heapDeltaBytes": 10511888,
"heapUsedBytes": 192090280,
"domNodes": 0,
"jsHeapTotalBytes": -18087936,
"scriptDurationMs": 71.19799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5433.5700000000315,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5119.943000000001,
"heapDeltaBytes": -8652432,
"heapUsedBytes": 182300500,
"domNodes": 0,
"jsHeapTotalBytes": -19398656,
"scriptDurationMs": 75.37499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 83.07299999995621,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.855,
"layouts": 4,
"layoutDurationMs": 1.6010000000000002,
"taskDurationMs": 63.71500000000001,
"heapDeltaBytes": 3232888,
"heapUsedBytes": 69210124,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.218000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 438.2630000000063,
"styleRecalcs": 16,
"styleRecalcDurationMs": 14.303999999999998,
"layouts": 2,
"layoutDurationMs": 0.4990000000000001,
"taskDurationMs": 88.88700000000001,
"heapDeltaBytes": 4786116,
"heapUsedBytes": 70750760,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.586,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.55 #19020 +/- ##
=============================================
- Coverage 84.60% 83.68% -0.93%
=============================================
Files 2298 3025 +727
Lines 131671 149480 +17809
Branches 35560 40536 +4976
=============================================
+ Hits 111403 125094 +13691
- Misses 19954 23063 +3109
- Partials 314 1323 +1009
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 735 files with indirect coverage changes 🚀 New features to boost your workflow:
|
68d77a8 to
78b0ee5
Compare
…ete on sign-out, heartbeat (#18719) > **Stacked on #18715 (FE-2894) → #18710 (FE-2892). Do not merge** until those merge and BE-17061 (C1) and BE-17063 (C3) are on testcloud (the web session backend is not on staging yet). The base of this PR is the FE-2894 branch. ## Why With one shared session, signing in or out on one site has to reach every open tab on every other site, and a tab must never finish Alice's action as Bob. TDD §7, §12 and A8 define how: create the session only on a real sign-in, delete it on sign-out, and run a heartbeat that notices a remote sign-out or an account change and tells the app to reset. ## How This extends the FE-2894 state machine rather than adding a second module, so there is still one state and one pure transition. - `signedIn(getProof)`: the host calls it only after an interactive sign-in. A token refresh never creates a session. - `signOut()`: signs the tab out at once, sends `DELETE /api/auth/session` (which works on a dead session), and tells sibling tabs. - Heartbeat: `GET /session` every 10 minutes while the tab is visible, and once when it becomes visible. The GET never extends the idle timer. - A new CSRF token is adopted silently. - `session_revoked` → signed out. - `no_session`/`session_expired` → restore in place from the remembered login, without bumping the epoch. - `SESSION_UNAVAILABLE` and other ambiguous answers keep the user signed in; the next beat tries again. - Cross-tab: within one site, only a visible, signed-in tab holds the lead and beats. Siblings adopt `ok` and `revoked` answers over the existing broadcast port and validate each message with a schema before adopting it. - `CrossTabRefreshPort` gains a message type parameter (`<Message = AccountCredential>`). The change is type-only, and the cloud app's existing `createWebCrossTabRefreshPort()` call keeps the same runtime behaviour. - `createWebVisibilityPort()` joins `./web`, so the core still touches no browser global. - Account change: `onAccountChanged` fires on a remote sign-out, a different user in any answer, and the host's own sign-out. `getEpoch()` goes up on each change, and an answer started under an older epoch is discarded. The host tags requests with the epoch and clears its own caches, workspace selection and socket (FE-2903). `onSignedOutRemotely` is the `session_signed_out_remotely` event (revoked only). - Inert until `boot()`: nothing watches visibility or the channel before then; the inert-import test now covers `./web`. - Size: about 358 net non-test lines, over the ~300 guideline. If you want it smaller, the split is cross-tab adoption + the visibility port + the generic port type (~70 lines) into a follow-up, or the pure transition into its own module. ## AS IS / TO BE No UI; the evidence is tests with injected time, fake visibility and a fake cross-tab port, no sleeps. - AS IS: no session lifecycle or heartbeat. - TO BE: `webSessionIdentity.lifecycle.test.ts` covers: - a sign-out on another site reaching this tab at its next beat or on focus; - a different user in a heartbeat resetting state, with a pending answer from the old epoch dropped; - a hidden tab never beating; - followers adopting instead of reading; - a token refresh never creating a session; - `SESSION_UNAVAILABLE` never signing out. ``` pnpm --filter @comfyorg/account-core test Tests 1094 passed pnpm --filter @comfyorg/account-core typecheck / lint clean pnpm typecheck clean pnpm knip clean pnpm fallow audit --base <FE-2894 branch> No issues in 6 changed files ``` Mutation checks (each reverted): | Mutation | Result | | --- | --- | | hidden tab beats | 2 red | | followers read too | 1 red | | heartbeat creates a session | 5 red | | `SESSION_UNAVAILABLE` signs out | 1 red | | old-epoch answer applied after an account change | 1 red | For review: - The CSRF token travels on the same-origin broadcast channel, the same trust boundary the port already documents for the workspace token. - `signOut()` calls `RememberedLogin.signOutLocally` itself, which may overlap the host's own Firebase sign-out. ## Links - TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b (sections 7, 12, 15 F2, A8) - Action items and dependency graph: https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3 - Linear: https://linear.app/comfyorg/issue/FE-2897 ## Where this PR sits in the plan | Ticket | Scope | Blocked by | State | | --- | --- | --- | --- | | FE-2891 | `unified_web_session` client flag, off by default | BE-17135 to turn on; C11 for website/billing-web readers | #18708 | | FE-2892 | account-core web session client + error codes | C1, C3 (BE-17063 generated types) | #18710, do not merge | | FE-2893 | ADR for the shared web session | none | #18707 | | FE-2901 | non-web clients stay on tokens (baseline) | FE-2895 for `authorize()` rows | #18711 | | FE-2894 | session-backed identity + boot rules (stacked on #18710) | FE-2892, C3 | #18715, do not merge | | FE-2895 | `authorize()` for cookie requests (stacked on #18710) | FE-2892, C5 | #18716, do not merge | | **FE-2897 (this PR)** | session lifecycle, heartbeat (stacked on #18715) | FE-2894, C1, C3 | #18719, do not merge | | FE-2906 | cross-origin E2E harness + §17 test ids | C3/C5/C6/C7 on staging for the rows | #18718 (harness only) | | FE-2896, 2898–2900, 2902–2905, 2907, 2908 | apps, token mint, rollout, cleanup | C5/C6/C7/C8/C11 contracts | not started | ```mermaid flowchart LR subgraph BE["BE · cloud ingest and infra"] C0["BE-17071 C0 preview CORS gate"] C1["BE-17061 C1 sessions table + revocable cookie"] C3["BE-17063 C3 GET /session, trusted origins, flag"] C4["BE-17062 C4 shared workspace resolution"] C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"] C2["BE-17064 C2 revoke-all, purge, caps"] C6["BE-17067 C6 WebSocket on session"] C7["BE-17068 C7 scoped media"] C8["BE-17069 C8 token mint from session"] C9["BE-17065 C9 Redis cache + load test"] C10["BE-17072 C10 prod config, cleanup"] C11["C11 flag before sign-in (OQ17)"] B135["BE-17135 serve unified_web_session (server AND)"] I2["BE-17070 I2 edge limit, log + DNS audit"] end subgraph SDK["FE · account-core"] F2891["FE-2891 flag"] F2892["FE-2892 web session client"] F2894["FE-2894 identity + boot rules"] F2897["FE-2897 lifecycle, heartbeat"] F2895["FE-2895 authorize()"] F2900["FE-2900 lazy token mint"] F2901["FE-2901 non-web stay on tokens"] end subgraph APPS["FE · apps"] F2896["FE-2896 website header"] F2903["FE-2903 cloud lifecycle"] F2899["FE-2899 website credits"] F2904["FE-2904 cloud API client"] F2905["FE-2905 socket + media"] F2898["FE-2898 billing-web joins session"] F2902["FE-2902 platform"] end subgraph QA["QA · rollout · docs"] F2906["FE-2906 cross-origin E2E"] F2893["FE-2893 ADR + docs"] F2907["FE-2907 ramp + rollback"] F2908["FE-2908 cleanup"] end C0 --> C1 --> C3 --> C5 C3 --> C11 --> F2891 B135 --> F2891 C4 --> C5 C1 --> C2 C1 --> C9 C5 --> C6 & C7 & C8 C3 --> F2892 C1 --> F2892 F2891 --> F2894 C3 --> F2894 F2892 --> F2894 --> F2896 F2894 --> F2897 --> F2903 C1 --> F2897 F2892 --> F2895 C5 --> F2895 F2895 --> F2899 & F2904 & F2900 & F2901 & F2902 C5 --> F2899 & F2904 F2903 --> F2904 --> F2905 C6 --> F2905 C7 --> F2905 C8 --> F2900 F2894 --> F2898 F2895 --> F2898 C3 --> F2898 C5 --> F2898 F2903 & F2904 & F2905 & F2898 --> F2906 C3 & C2 --> F2906 F2906 --> F2907 C9 & C10 & I2 --> F2907 F2907 --> F2908 C10 --> F2908 classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000 class F2897 thisPr ``` - Blocked by: #18715 (FE-2894), #18710 (FE-2892), BE-17061 (C1), BE-17063 (C3). - Unblocks: FE-2903 (cloud app joins the lifecycle), and through it FE-2904, FE-2905 and FE-2906 rows E2E-02/05/07. --------- Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com> (cherry picked from commit 1685d33)
78b0ee5 to
194ee20
Compare
Backport of #18719 to
core/1.55(cherry-pick -x of 1685d33).Merge #19018 first. This branch is stacked on it, so until #19018 merges the diff also shows its #18715 commit.
Why
The unified web session stack is going to 1.55. #18719 adds the session lifecycle to
webSessionIdentity(create on sign-in, delete on sign-out, heartbeat) and generalisesCrossTabRefreshPortso the web cross-tab port can carry it. It builds on #18715 (backported in #19018).Root cause (what conflicted)
Nothing. On top of the #18715 backport the cherry-pick applied cleanly; every touched file (
sessionContracts.ts,webSessionIdentity.ts,web/crossTabRefresh.ts, their tests,webSessionInertImport.test.ts) matches main's pre-#18719 state for these lines. The@comfyorg/account-core/webentry it adds to the inert-import test is already exported oncore/1.55.How
Kept everything from #18719 verbatim; dropped nothing. No files from other PRs.
Validation:
pnpm typecheck:account-coreexit 0; vitestwebSessionIdentity,webSessionIdentity.lifecycle,webSession,importGuard,webSessionInertImport,web/crossTabRefresh,session,requestAuth214/214 pass; package.json parses.AS IS / TO BE
No UI change (inert behind
unified_web_session).