Repository navigation
fix(website): video controls stay long enough to use on a phone - #19017
mariana953 wants to merge 1 commit into
Conversation
The bar was summoned by any pointer activity and left after 800ms. A pointer that hovers keeps it up for as long as it rests on the player, so that window never bit on a desktop. A finger cannot hover: the window is the whole of the bar's visit, and 800ms was long enough to see the controls and too short to hit one — on the Hub's own output panel, where the bar waits for a pointer, there was then no way to reach it at all. Where the device cannot hover, the bar now waits four seconds.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1685d3352be73fb15bfac57c3c9858031d2d60f7
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19017.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-e3ukfbrce-comfyui.vercel.app Last updated: 2026-09-26T16:56:23Z for |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe video player selects its controls’ inactivity timeout based on hover support. Tests cover control-bar pointer reachability at different playback times. ChangesVideo player control timeout
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The longer touch-device control window has no established issue requiring a fix before merge. Complete the normal test checks. Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (6 passed)
Full details: Website End-To-End Regression CoverageExplanation The PR changes observable website runtime behavior in
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19017 +/- ##
==========================================
- Coverage 84.04% 84.02% -0.03%
==========================================
Files 3158 3123 -35
Lines 154414 153648 -766
Branches 41918 41725 -193
==========================================
- Hits 129772 129097 -675
+ Misses 23037 22996 -41
+ Partials 1605 1555 -50
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 35 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
On the one failing pre-merge check, Website End-To-End Regression Coverage: I took the first half of its resolution before the second. I wrote the Playwright test, ran it against a fresh The blocker is the fixture, not the effort. The only player that holds What is covered, against a real Generated by Claude Code |
|
Included unmodified in #19255, which lands Mar's Hub V2 PRs together as part of the stack #18988 → #19023 → #19255 → #19256. Review fixes for this area are in #19256. Closing in favour of the stack. Your branch is untouched; for further changes, please open a PR on top of #19256 rather than pushing here. |
…te PRs (#19255) ## Summary Mar's Hub V2, staged as one reviewable phase. This combines the 23 PRs from her [#proj-comfy-hub post](https://comfy-organization.slack.com/archives/C0AEPRS8N74/p1790528696016959), including the latest head of #19004, while preserving her presentation and commit history. Review fixes remain isolated in #19256 above this PR. Design reference (not for review): #17804 · [V2 Hub preview](https://comfy-website-preview-pr-17804.vercel.app/hub/) ## Included **Independent:** #19031 Hub not Models · #18916 search with filter and sort · #18915 shorter workflows banner · #18979 filter chips · #19012 one "browse all" · #19016 shelf stops promising more · #18987 home hub workflows tab · #19025 Apps tab · #19090 filter named after what it filters · #19017 phone video controls · #19011 API tab endpoint · #19014 workflow header **Catalogue cards:** #18921 → #19015 **Workflow page V2:** #19009 → #19004 → #19008 → #19010 → #19029 **Run states:** #19005 → #19006 → #19007 → #19022 ## Integration with current main - Rebases the phase onto current `main`, including the canonical `/models/apps/<slug>/` routes and the separate Apps feature flag. - Keeps Mar's Apps shelf and card presentation while sourcing its entries and links from the canonical app catalogue. - Keeps Apps gated by `workshop-apps-enabled`; Workflows remain gated independently by `workshop-workflows-enabled`. - Keeps Mar's latest #19004 Details cleanup and single template-author attribution while retaining the later interactive graph work in #19008/#19010. - Resolves the combined `/models/` JavaScript budget to 1,820,000 bytes. ## Not included - #19241 (API tab rail): conflicts with #19011 and still needs a design call. - #19227 (draft), #17865 and #18306: not part of the Hub V2 set. ## Verification - Full website unit suite: 9,494 passed, 4 skipped. - Focused post-rebase app/catalogue suite: 98 passed. - Website typecheck: 0 errors. - Commit and push checks: formatting, lint, app/website typechecks, knip and Fallow passed. - `workshop-workflows-enabled` gates the home tab, catalogue tab, direct `?type=` URLs and detail pages without flashing gated content. --------- Co-authored-by: Mariana Martinho <mariana@comfy.org> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <github-actions@github.com>
Summary
VideoPlayer's control bar left 800 ms after the last pointer activity. A pointer that hovers keeps it up for as long as it rests on the player, so that window never bit on a desktop; a finger cannot hover, so 800 ms was the whole of the bar's visit — long enough to see the controls and too short to hit one.Changes
refAutoReset's window is now read from a getter: 800 ms where(hover: hover)matches, four seconds where it does not.Review Focus
The worst case is the Hub's output panel, which passes
controls-on-hover. There, once a generated video is playing,controlsVisibleisfocused || hovering || recentActivity— on a phone none of the three survives 800 ms, so there was no way to reach play, scrub, mute or fullscreen on your own generation at all.The test asserts the window rather than the styling: it drives playback (the only thing that summons the bar where there is no pointer to rest), advances fake timers, and reads whether the bar is still reachable. I checked it fails with the delay pinned back to a constant 800 — the touch-at-1000 ms row goes red and the other two stay green.
(hover: hover)rather than a width query on purpose: a touch laptop and a phone have the same problem, and a narrow desktop window does not.Four seconds is a judgement call, not a measured figure. It is long enough to aim at the scrub bar without leaving the bar sitting over the picture; happy to move it.
Why no Playwright test under
apps/website/e2e/I wrote one and could not make it prove anything, so it is not in the diff. Two facts about the website's browser suite defeat it:
blockExternalMediafixture withe2e/assets/placeholder.webm, which is 0.12 s long. The bar's window is seconds; the clip is over long before it, and a stopped video shows the bar on purpose (controlsVisiblestarts with!playing). So the assertion reads "visible" whether the timer works or not.playingtrue past that — the Hub output panel'sautoplay loopplayer, which is also the one that carriescontrols-on-hover— is reachable only through a mocked run that delivers a video output, and no existing spec sets one up. Building that pipeline to time asetTimeoutwould put the proof further from the thing being changed, not closer.What the component test does cover is the branch itself, against a real
matchMedia: three rows over(hover: hover)true/false at 1000 ms and 5000 ms, failing when the delay goes back to a constant. The column count and layout of the bar stay with thevisual-responsivebaselines, which render at real widths.