Repository navigation
feat(website): the workflow header stops repeating the rail, and its shelf leads somewhere #19014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c2af889
feat(website): the workflow header stops repeating the rail, and its …
mariana953 e17c80a
test(website): the eyebrow's shelf leads to that shelf
mariana953 9f3adc4
test(website): the eyebrow leads back to its shelf, in the browser too
mariana953 800ba6f
feat(website): the workflow header names who made it
mariana953 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import { render, screen } from '@testing-library/vue' | ||
| import { assert, describe, expect, it } from 'vitest' | ||
|
|
||
| import { workflowDetailsBySlug } from '../../config/workshop-workflow-content' | ||
| import WorkflowPage from './WorkflowPage.vue' | ||
|
|
||
| const model = workflowDetailsBySlug.get('workflows/remove-background') | ||
| assert(model) | ||
|
|
||
| // Who made the workflow stands over its name, and the shelf it sits on is the | ||
| // one thing up there that leads somewhere. | ||
| describe('WorkflowPage header', () => { | ||
| it('sends the shelf it names to that shelf, filtered', () => { | ||
| render(WorkflowPage, { props: { model } }) | ||
|
|
||
| const shelf = screen.getByTestId('workflow-use-case') | ||
| expect(shelf.textContent.trim()).toBe('Edit images') | ||
| expect(shelf.getAttribute('href')).toBe('/models?useCase=edit-images') | ||
| }) | ||
|
|
||
| it('says nothing about a shelf a workflow has none of', () => { | ||
| render(WorkflowPage, { | ||
| props: { | ||
| model: { | ||
| ...model, | ||
| useCases: [], | ||
| task: undefined, | ||
| modality: undefined | ||
| } | ||
| } | ||
| }) | ||
|
|
||
| expect(screen.queryByTestId('workflow-use-case')).toBeNull() | ||
| }) | ||
|
|
||
| it.for([ | ||
| { author: 'ComfyUI', authors: 1 }, | ||
| { author: undefined, authors: 0 } | ||
| ] as const)('names $authors author(s)', ({ author, authors }) => { | ||
| render(WorkflowPage, { props: { model: { ...model, author } } }) | ||
|
|
||
| const named = screen.queryAllByTestId('workflow-author') | ||
| expect(named).toHaveLength(authors) | ||
| if (author) expect(named[0]).toHaveTextContent(author) | ||
| expect(screen.getByTestId('workflow-use-case')).toBeTruthy() | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.