Repository navigation
fix(website): the catalogue asks to browse all once, at the end of the list - #19012
mariana953 wants to merge 1 commit into
Conversation
Browse all sat beside the hero's subtitle and again under the whole list, so the page offered the same way out twice — the first time before the reader had seen anything to browse past. The one at the top goes. The one at the end of the list stays, where it reads as what follows the list rather than as a way around it, and it is what the tests and the browser tests now press.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1685d3352be73fb15bfac57c3c9858031d2d60f7
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19012.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-1pkvfk0kb-comfyui.vercel.app Last updated: 2026-09-26T15:26:50Z for |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe workshop hero no longer displays its browse-all button. Unit and end-to-end tests now use the ChangesWorkshop catalogue
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The duplicate hero browse action is removed while end-of-catalogue browsing remains available for models and workflows. No material user-facing merge risk is evident. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19012 +/- ##
==========================================
- Coverage 84.04% 84.02% -0.03%
==========================================
Files 3158 3123 -35
Lines 154414 153643 -771
Branches 41918 41723 -195
==========================================
- Hits 129772 129092 -680
+ Misses 23037 22996 -41
+ Partials 1605 1555 -50
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 35 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Included unmodified in #19255, which lands Mar's Hub V2 PRs together as part of the stack #18988 → #19023 → #19255 → #19256. Review fixes for this area are in #19256. Closing in favour of the stack. Your branch is untouched; for further changes, please open a PR on top of #19256 rather than pushing here. |
…te PRs (#19255) ## Summary Mar's Hub V2, staged as one reviewable phase. This combines the 23 PRs from her [#proj-comfy-hub post](https://comfy-organization.slack.com/archives/C0AEPRS8N74/p1790528696016959), including the latest head of #19004, while preserving her presentation and commit history. Review fixes remain isolated in #19256 above this PR. Design reference (not for review): #17804 · [V2 Hub preview](https://comfy-website-preview-pr-17804.vercel.app/hub/) ## Included **Independent:** #19031 Hub not Models · #18916 search with filter and sort · #18915 shorter workflows banner · #18979 filter chips · #19012 one "browse all" · #19016 shelf stops promising more · #18987 home hub workflows tab · #19025 Apps tab · #19090 filter named after what it filters · #19017 phone video controls · #19011 API tab endpoint · #19014 workflow header **Catalogue cards:** #18921 → #19015 **Workflow page V2:** #19009 → #19004 → #19008 → #19010 → #19029 **Run states:** #19005 → #19006 → #19007 → #19022 ## Integration with current main - Rebases the phase onto current `main`, including the canonical `/models/apps/<slug>/` routes and the separate Apps feature flag. - Keeps Mar's Apps shelf and card presentation while sourcing its entries and links from the canonical app catalogue. - Keeps Apps gated by `workshop-apps-enabled`; Workflows remain gated independently by `workshop-workflows-enabled`. - Keeps Mar's latest #19004 Details cleanup and single template-author attribution while retaining the later interactive graph work in #19008/#19010. - Resolves the combined `/models/` JavaScript budget to 1,820,000 bytes. ## Not included - #19241 (API tab rail): conflicts with #19011 and still needs a design call. - #19227 (draft), #17865 and #18306: not part of the Hub V2 set. ## Verification - Full website unit suite: 9,494 passed, 4 skipped. - Focused post-rebase app/catalogue suite: 98 passed. - Website typecheck: 0 errors. - Commit and push checks: formatting, lint, app/website typechecks, knip and Fallow passed. - `workshop-workflows-enabled` gates the home tab, catalogue tab, direct `?type=` URLs and detail pages without flashing gated content. --------- Co-authored-by: Mariana Martinho <mariana@comfy.org> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <github-actions@github.com>
Summary
"Browse all models" sat beside the hero's subtitle and again under the whole list, so the page offered the same way out twice — the first time before the reader had seen anything to browse past. The one at the top goes; the one at the end of the list stays.
Changes
#asidebutton fromWorkshopHeroinModelsCatalogue.vue, on both the Models and Workflows tabs. Thebrowse-all-endbutton at the foot of the models grid and of the workflow catalogue is unchanged and still the thing that opens the full list.The three component tests and the two browser tests that pressed the top button now press the one at the end. They were testing that the full list opens, not where the reader presses, and the remaining button renders in exactly the same state the removed one did.
Review Focus
WorkshopHero'sasideslot now has no caller. It is left in place as an extension point rather than removed, since the hero is shared withHubBrowse; say the word if it should go too.Verified on the running page at 1440 and 390, on both tabs: the top button is gone, the one at the end of the list is there, the hero reads eyebrow / heading / subtitle with no gap where the link was, and
documentElement.scrollWidthequals the viewport.Screenshots (if applicable)
Captured locally at both widths on both tabs. This session cannot attach binaries to a pull request; the preview link shows the result once
deploy-previewpasses.