Repository navigation
[backport cloud/1.55] FE-2900 feat(account-core): lazy workspace-token mint from the web session - #19001
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3e437226c9f677228843fd696602d994dcc1d49d
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-27T06:01:51.965Z",
"gitSha": "6941b45e0c73075a0015954e9370e4b181b0e7e0",
"branch": "backport-18870-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.3429999999826,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.9750000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.52500000000003,
"heapDeltaBytes": -8153588,
"heapUsedBytes": 59376976,
"domNodes": -259,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.516,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2014.3920000000435,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.74999999999994,
"heapDeltaBytes": -8171808,
"heapUsedBytes": 59384264,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.953000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.2929999999965,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.387,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.225,
"heapDeltaBytes": -7541176,
"heapUsedBytes": 60122984,
"domNodes": -259,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 118.085,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.3009999999722,
"styleRecalcs": 45,
"styleRecalcDurationMs": 11.371,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.8790000000001,
"heapDeltaBytes": -2335636,
"heapUsedBytes": 60142180,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 117.91300000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.3649999999716,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.462,
"layouts": 6,
"layoutDurationMs": 0.9460000000000001,
"taskDurationMs": 256.776,
"heapDeltaBytes": 3152256,
"heapUsedBytes": 70409808,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.551,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.697999999974,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.941000000000003,
"layouts": 6,
"layoutDurationMs": 1.06,
"taskDurationMs": 265.883,
"heapDeltaBytes": 3120192,
"heapUsedBytes": 70801972,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.549000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 541.5229999999838,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.237,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.471,
"heapDeltaBytes": 18644500,
"heapUsedBytes": 86175388,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 131.855,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 543.6520000000655,
"styleRecalcs": 15,
"styleRecalcDurationMs": 8.32,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.742,
"heapDeltaBytes": 18939884,
"heapUsedBytes": 86721148,
"domNodes": 25,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 134.38799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1013.7880000000337,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.636,
"heapDeltaBytes": 35314176,
"heapUsedBytes": 104157764,
"domNodes": 0,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 50.30599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 403,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1057.7560000000403,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 685.199,
"heapDeltaBytes": 10048416,
"heapUsedBytes": 100712892,
"domNodes": -293,
"jsHeapTotalBytes": 24268800,
"scriptDurationMs": 49.96099999999999,
"eventListeners": -195,
"totalBlockingTimeMs": 432,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 762.3570000000086,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.8979999999996,
"heapDeltaBytes": 14499048,
"heapUsedBytes": 90911204,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 111.29300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 154,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 766.2050000000136,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.8940000000004,
"heapDeltaBytes": 14827904,
"heapUsedBytes": 91319148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.55599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 156,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7128.05400000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6318.249,
"heapDeltaBytes": -7881296,
"heapUsedBytes": 74080352,
"domNodes": -18,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 5272.897999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 27,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6943.208000000027,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.5980000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6159.889999999999,
"heapDeltaBytes": -4223820,
"heapUsedBytes": 73486104,
"domNodes": -265,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 4935.474999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 26,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7362.223999999969,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.09699999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6487.233,
"heapDeltaBytes": 10459416,
"heapUsedBytes": 85323356,
"domNodes": -6,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 5247.448,
"eventListeners": 0,
"totalBlockingTimeMs": 100,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6601.585,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.1480000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5922.192,
"heapDeltaBytes": 6573436,
"heapUsedBytes": 84469116,
"domNodes": -231,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 4730.367,
"eventListeners": -174,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2023.3670000000075,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.589999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.387,
"heapDeltaBytes": -6748084,
"heapUsedBytes": 80328184,
"domNodes": -242,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 27.654000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.276999999899,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.049999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.9720000000001,
"heapDeltaBytes": -7567088,
"heapUsedBytes": 79870528,
"domNodes": -241,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 34.089999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2189.6830000000023,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.654999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1360.0330000000001,
"heapDeltaBytes": 114684,
"heapUsedBytes": 81707628,
"domNodes": -213,
"jsHeapTotalBytes": 2314240,
"scriptDurationMs": 692.62,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2132.0619999999053,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.819,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1291.234,
"heapDeltaBytes": -12566820,
"heapUsedBytes": 75660940,
"domNodes": -248,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 654.029,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3219.5730000000253,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.189999999999998,
"layouts": 60,
"layoutDurationMs": 12.132,
"taskDurationMs": 1400.4309999999998,
"heapDeltaBytes": -15201636,
"heapUsedBytes": 74522676,
"domNodes": -244,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 642.685,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3142.673000000059,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.739999999999998,
"layouts": 60,
"layoutDurationMs": 12.17,
"taskDurationMs": 1379.53,
"heapDeltaBytes": -15977592,
"heapUsedBytes": 74024608,
"domNodes": -250,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 617.572,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2296.4850000000183,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.6,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1532.8300000000002,
"heapDeltaBytes": -13176212,
"heapUsedBytes": 78041932,
"domNodes": 14,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 789.174,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2299.4090000000824,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.035000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1502.053,
"heapDeltaBytes": 17630696,
"heapUsedBytes": 83599152,
"domNodes": 6,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 761.366,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.3300000000118,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.923000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.7870000000001,
"heapDeltaBytes": -5890172,
"heapUsedBytes": 82515012,
"domNodes": -244,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 29.891000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2024.7349999999642,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.127999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.62,
"heapDeltaBytes": -5890124,
"heapUsedBytes": 83087828,
"domNodes": -247,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 32.212,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 491.74899999997024,
"styleRecalcs": 50,
"styleRecalcDurationMs": 10.272,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 313.986,
"heapDeltaBytes": 14013568,
"heapUsedBytes": 82931884,
"domNodes": 25,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 115.87700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 510.8500000000049,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.400000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 317.18499999999995,
"heapDeltaBytes": 13807564,
"heapUsedBytes": 83846852,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 115.65400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1988.5949999999752,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.645000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.38500000000005,
"heapDeltaBytes": -6528132,
"heapUsedBytes": 63432428,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.790999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2005.7590000000118,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.768000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.544,
"heapDeltaBytes": -6512376,
"heapUsedBytes": 63489388,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.042999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.3089999999993,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.062000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.199,
"heapDeltaBytes": -8151848,
"heapUsedBytes": 61893260,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 76.656,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.0889999999863,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.677999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.1129999999999,
"heapDeltaBytes": 10594624,
"heapUsedBytes": 80626624,
"domNodes": -273,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 74.58000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 867.2159999999849,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.994,
"layouts": 5,
"layoutDurationMs": 9.554000000000002,
"taskDurationMs": 687.1640000000001,
"heapDeltaBytes": -6294184,
"heapUsedBytes": 81937676,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 21.025999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 96,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8196.477000000015,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.797000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4518.236,
"heapDeltaBytes": -12044860,
"heapUsedBytes": 68342936,
"domNodes": -243,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 2160.7729999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8191.927999999962,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.612,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4595.903,
"heapDeltaBytes": -8499552,
"heapUsedBytes": 78715828,
"domNodes": -233,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 2202.701,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14039.90699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13489.924000000003,
"heapDeltaBytes": -45243744,
"heapUsedBytes": 182168228,
"domNodes": -8062,
"jsHeapTotalBytes": -18677760,
"scriptDurationMs": 235.80499999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13854.844999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13402.705000000002,
"heapDeltaBytes": -74831884,
"heapUsedBytes": 162558348,
"domNodes": -8063,
"jsHeapTotalBytes": -19247104,
"scriptDurationMs": 218.90500000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16783.93900000003,
"styleRecalcs": 121,
"styleRecalcDurationMs": 13.271000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16415.899000000005,
"heapDeltaBytes": -69233928,
"heapUsedBytes": 168497844,
"domNodes": -8062,
"jsHeapTotalBytes": -16625664,
"scriptDurationMs": 682.933,
"eventListeners": -14928,
"totalBlockingTimeMs": 1,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 16821.774000000005,
"styleRecalcs": 127,
"styleRecalcDurationMs": 13.16500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16463.406,
"heapDeltaBytes": -31704180,
"heapUsedBytes": 191898512,
"domNodes": -8062,
"jsHeapTotalBytes": -21798912,
"scriptDurationMs": 682.6419999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 18,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5006.847999999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.53,
"layouts": 20,
"layoutDurationMs": 20.863000000000007,
"taskDurationMs": 4923.858,
"heapDeltaBytes": -49303976,
"heapUsedBytes": 176612064,
"domNodes": -8062,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 81.74100000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 166,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5022.99400000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.585,
"layouts": 20,
"layoutDurationMs": 20.457000000000004,
"taskDurationMs": 4986.655999999999,
"heapDeltaBytes": -57163956,
"heapUsedBytes": 177461920,
"domNodes": -8062,
"jsHeapTotalBytes": 10969088,
"scriptDurationMs": 81.896,
"eventListeners": -14928,
"totalBlockingTimeMs": 158,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6941.888000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6796.090000000001,
"heapDeltaBytes": -2365184,
"heapUsedBytes": 194636732,
"domNodes": 0,
"jsHeapTotalBytes": -28049408,
"scriptDurationMs": 101.78599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7051.68500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6872.9929999999995,
"heapDeltaBytes": -15450916,
"heapUsedBytes": 174642576,
"domNodes": 0,
"jsHeapTotalBytes": -26738688,
"scriptDurationMs": 95.14799999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 89.3909999999778,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.536999999999999,
"layouts": 2,
"layoutDurationMs": 1.1409999999999998,
"taskDurationMs": 63.78799999999998,
"heapDeltaBytes": 3178960,
"heapUsedBytes": 68692544,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.280000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 436.4060000000336,
"styleRecalcs": 16,
"styleRecalcDurationMs": 17.619,
"layouts": 3,
"layoutDurationMs": 0.7649999999999999,
"taskDurationMs": 88.157,
"heapDeltaBytes": 4914364,
"heapUsedBytes": 70498044,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.88,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19001 +/- ##
=============================================
Coverage ? 83.68%
=============================================
Files ? 3025
Lines ? 149444
Branches ? 40540
=============================================
Hits ? 125063
Misses ? 23063
Partials ? 1318
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified against #18870 before approving: identical file list, and no conflict markers anywhere in the diff. All three required checks green (lint-and-format, test, e2e-status).
|
Rebased onto current |
…ssion (#18870) > **Stacked on #18716 (FE-2895). Do not merge** until #18716 merges and C8 (BE-17069, cloud#10585 + #10697: `POST /api/auth/token` accepts the cookie) is on testcloud. ## Why comfy-api and the other services cannot read the session cookie. A site that arrived by session has no Firebase login to hand them. TDD §7/§12 has the site mint a short-lived workspace token from the session, lazily and only when a non-ingest call needs one. This is the token source `authorize()` (#18716) takes for its `resource` target. ## How New entry `@comfyorg/account-core/sessionTokenMint`: `createSessionTokenMint({ apiBaseUrl, fetchImpl, getSession, now?, refreshBufferMs? })` returns: - `mint(workspaceId?)`, which returns a coded result; - `getWorkspaceToken(workspaceId?)`, which plugs into `createRequestAuthorizer({ getWorkspaceToken })` and rejects with `SessionTokenError` on failure. Details: - **Request.** `POST /auth/token` with `credentials: 'include'`, `X-Comfy-Client`, `X-CSRF-Token` and `X-Comfy-Workspace-ID`. The body is `{}` for the personal workspace or `{ workspace_id }`. No `Authorization` header is sent. The response is parsed with the generated `zExchangeTokenResponse`, since C8 leaves the 200 shape unchanged. - **Lazy.** Nothing is sent until the first call. - **Cache.** Tokens are cached per workspace and owned by the current session user, and reused until 60 s before expiry. Concurrent callers for one workspace share a single request. A user change or sign-out drops the cache and anything in flight, and a token that arrives after the user changed is not cached. - **Failure codes.** A 401 is the session's code (and clears the cache). 403 `csrf_invalid` is `CSRF_STALE` and 403 `workspace_access_denied` is `WORKSPACE_ACCESS_DENIED`. Other 403s, 400 and 404 are refused. 5xx and network errors are transient. A 429 carries `retryAfterMs` and holds further requests until then. - **Inert on import.** It is added to the importGuard closure, the inert-import test, package exports and smokePack. No app wires it yet, and the flag-off harness is unchanged (4/4). - **For review:** - It sends `X-Comfy-Workspace-ID` equal to the body's `workspace_id`. C8 only rejects a header that names a different workspace; if you'd rather send none, it's a one-line removal. - It has its own classifier because C8 defines a code-less 401 as a dead session, where `webSession.ts` refuses it. ## AS IS / TO BE No UI; the evidence is tests. - AS IS: a session-only site has no token for comfy-api. - TO BE: tests cover zero requests before the first call, headers and credentials, cache hit, re-mint at expiry, single-flight, the cache dropping on a user change, per-workspace keys, a late token not cached across users, 401/403/404/429/5xx mapping, and Retry-After. Eight mutations, each reverted with the full suite rerun, all go red: cache key, user-change drop, expiry buffer, credentials, single-flight, Retry-After, stale-owner guard, and 401 cache clear. Checks: account-core 1139 tests pass; typecheck, lint, knip, fallow and smoke:pack are clean. ## Links - TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b (sections 7, 9, 12, F6) - Action items: https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3 - Linear: https://linear.app/comfyorg/issue/FE-2900 - Contract: Comfy-Org/cloud#10585, Comfy-Org/cloud#10697 ## Where this PR sits in the plan | Ticket | Scope | Blocked by | State | | --- | --- | --- | --- | | FE-2891 | flag (cloud) + website/billing-web readers | C11 cloud#10689 + probe switch (readers) | #18708 merged; readers in progress | | FE-2892 | web session client (+ revoke-all follow-up) | C2a cloud#10589 for revoke-all | #18710 merged; revoke-all #18869, do not merge | | FE-2893 | ADR | none | #18707 merged | | FE-2894 | identity + boot rules | BE-17063 on testcloud | #18715, do not merge | | FE-2895 | `authorize()` | C5 cloud#10555 | #18716, do not merge | | FE-2897 | lifecycle, heartbeat | FE-2894, C1 | #18719, do not merge | | **FE-2900 (this PR)** | lazy token mint from the session | FE-2895, C8 cloud#10585 | #18870, do not merge | | FE-2901 | non-web clients stay on tokens | — | #18711 | | FE-2903 | cloud app joins the lifecycle | FE-2897 | #18871, do not merge | | FE-2904 | cloud API client on `authorize()` | FE-2903, FE-2895, C5 | in progress | | FE-2905 | socket + media carry workspace | FE-2904, C6, C7 | next | | FE-2896 / 2899 / 2898 | website header, website credits, billing-web | FE-2891 readers, FE-2894/2895, C5, C11 | next | | FE-2906 | cross-origin E2E harness | — | #18718 (harness only) | | FE-2902 / 2907 / 2908 | platform, rollout, cleanup | other repo / ops / after ramp | not started | ```mermaid flowchart LR subgraph BE["BE · cloud ingest and infra"] C0["BE-17071 C0 preview CORS gate"] C1["BE-17061 C1 sessions table + revocable cookie"] C3["BE-17063 C3 GET /session, trusted origins, flag"] C4["BE-17062 C4 shared workspace resolution"] C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"] C2["BE-17064 C2 revoke-all, purge, caps"] C6["BE-17067 C6 WebSocket on session"] C7["BE-17068 C7 scoped media"] C8["BE-17069 C8 token mint from session"] C9["BE-17065 C9 Redis cache + load test"] C10["BE-17072 C10 prod config, cleanup"] C11["C11 flag before sign-in (OQ17)"] B135["BE-17135 serve unified_web_session (server AND)"] I2["BE-17070 I2 edge limit, log + DNS audit"] end subgraph SDK["FE · account-core"] F2891["FE-2891 flag"] F2892["FE-2892 web session client"] F2894["FE-2894 identity + boot rules"] F2897["FE-2897 lifecycle, heartbeat"] F2895["FE-2895 authorize()"] F2900["FE-2900 lazy token mint"] F2901["FE-2901 non-web stay on tokens"] end subgraph APPS["FE · apps"] F2896["FE-2896 website header"] F2903["FE-2903 cloud lifecycle"] F2899["FE-2899 website credits"] F2904["FE-2904 cloud API client"] F2905["FE-2905 socket + media"] F2898["FE-2898 billing-web joins session"] F2902["FE-2902 platform"] end subgraph QA["QA · rollout · docs"] F2906["FE-2906 cross-origin E2E"] F2893["FE-2893 ADR + docs"] F2907["FE-2907 ramp + rollback"] F2908["FE-2908 cleanup"] end C0 --> C1 --> C3 --> C5 C3 --> C11 --> F2891 B135 --> F2891 C4 --> C5 C1 --> C2 C1 --> C9 C5 --> C6 & C7 & C8 C3 --> F2892 C1 --> F2892 F2891 --> F2894 C3 --> F2894 F2892 --> F2894 --> F2896 F2894 --> F2897 --> F2903 C1 --> F2897 F2892 --> F2895 C5 --> F2895 F2895 --> F2899 & F2904 & F2900 & F2901 & F2902 C5 --> F2899 & F2904 F2903 --> F2904 --> F2905 C6 --> F2905 C7 --> F2905 C8 --> F2900 F2894 --> F2898 F2895 --> F2898 C3 --> F2898 C5 --> F2898 F2903 & F2904 & F2905 & F2898 --> F2906 C3 & C2 --> F2906 F2906 --> F2907 C9 & C10 & I2 --> F2907 F2907 --> F2908 C10 --> F2908 classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000 class F2900 thisPr ``` - Blocked by: #18716 (FE-2895) and C8 cloud#10585 on testcloud. - Unblocks: comfy-api callers on session sites (FE-2904 host wiring, FE-2898 billing-web). --------- Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com> (cherry picked from commit 70ce571)
a9d120c to
a312ba8
Compare
|
Correction to my earlier note: that rebase never reached the branch. I pushed with a bare Redone properly, with an explicit refspec and the remote SHA checked against local. The cherry-pick applies clean onto current |
Backport of #18870 to
cloud/1.55(cherry-pick -x of 70ce571).Why
Ships the lazy workspace-token mint (
@comfyorg/account-core/sessionTokenMint) on the 1.55 line, next toauthorize()from #18716 (already backported as #18940/#18941).Root cause
The backport bot hit conflicts in
packages/account-core/package.json(exports),scripts/smokePack.ts,src/core/importGuard.test.tsandsrc/webSessionInertImport.test.ts. On main these lists also carrywebSessionIdentityfrom #18715 (FE-2894), which is not on 1.55.How
Kept the release branch's code and added only #18870's own entries: the
./sessionTokenMintexport (source + dist), its smoke-pack import/value/type, its inert-import case, and the Firebase import-guard case (it.for(['webSession.ts', 'sessionTokenMint.ts'])). Dropped everywebSessionIdentityentry.sessionTokenMint.tsand its test apply unchanged; they import onlyrequestAuth,credentialCache,sessionContracts,testingand@comfyorg/ingest-types/zod, all present on 1.55. Verified withpnpm typecheck:account-coreand the sessionTokenMint, importGuard, webSessionInertImport and requestAuth vitest files (73 passed).AS IS / TO BE
No UI change (inert behind
unified_web_session).