Skip to content

[backport cloud/1.55] FE-2900 feat(account-core): lazy workspace-token mint from the web session - #19001

Merged
christian-byrne merged 1 commit into
cloud/1.55from
backport-18870-to-cloud-1.55
Sep 27, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.55from
backport-18870-to-cloud-1.55

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Backport of #18870 to cloud/1.55 (cherry-pick -x of 70ce571).

Why

Ships the lazy workspace-token mint (@comfyorg/account-core/sessionTokenMint) on the 1.55 line, next to authorize() from #18716 (already backported as #18940/#18941).

Root cause

The backport bot hit conflicts in packages/account-core/package.json (exports), scripts/smokePack.ts, src/core/importGuard.test.ts and src/webSessionInertImport.test.ts. On main these lists also carry webSessionIdentity from #18715 (FE-2894), which is not on 1.55.

How

Kept the release branch's code and added only #18870's own entries: the ./sessionTokenMint export (source + dist), its smoke-pack import/value/type, its inert-import case, and the Firebase import-guard case (it.for(['webSession.ts', 'sessionTokenMint.ts'])). Dropped every webSessionIdentity entry. sessionTokenMint.ts and its test apply unchanged; they import only requestAuth, credentialCache, sessionContracts, testing and @comfyorg/ingest-types/zod, all present on 1.55. Verified with pnpm typecheck:account-core and the sessionTokenMint, importGuard, webSessionInertImport and requestAuth vitest files (73 passed).

AS IS / TO BE

No UI change (inert behind unified_web_session).

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f889bdde-06fe-4937-ad6c-a27d8b511a45

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2101 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/27/2026, 05:52:26 AM UTC

Links

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 3e437226c9f677228843fd696602d994dcc1d49d

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.4 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 418ms TBT · 97.7 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 155ms TBT · 86.9 MB heap
extension-clean-combined-draw: · 55.4 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 27ms TBT · 70.4 MB heap
extension-rgthree-prototype-draw: · 56.3 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 66ms TBT · 81.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 96ms TBT · 78.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 164.4 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 10ms TBT · 171.9 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 162ms TBT · 168.8 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 176.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 371ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 56.6 MB
canvas-idle: DOM nodes -259
canvas-idle: event listeners -174
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 0ms
canvas-mouse-sweep: style recalc duration 12ms
canvas-mouse-sweep: layout count 0
canvas-mouse-sweep: style recalc count 46
canvas-mouse-sweep: task duration 600ms
canvas-mouse-sweep: script duration 118ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 57.3 MB
canvas-mouse-sweep: DOM nodes -260
canvas-mouse-sweep: event listeners -174
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 12ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 29
canvas-zoom-sweep: task duration 261ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 67.3 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 366ms
dom-widget-clipping: script duration 133ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 82.4 MB
dom-widget-clipping: DOM nodes 24
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 661ms
dom-widget-order-dense-n200-w200-i120: script duration 50ms
dom-widget-order-dense-n200-w200-i120: TBT 418ms
dom-widget-order-dense-n200-w200-i120: heap used 97.7 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -147
dom-widget-order-dense-n200-w200-i120: event listeners -98
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 366ms
dom-widget-order-sparse-n1000-w20-i120: script duration 112ms
dom-widget-order-sparse-n1000-w20-i120: TBT 155ms
dom-widget-order-sparse-n1000-w20-i120: heap used 86.9 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 18ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 1
extension-clean-combined-draw: task duration 6239ms
extension-clean-combined-draw: script duration 5104ms
extension-clean-combined-draw: TBT 27ms
extension-clean-combined-draw: heap used 70.4 MB
extension-clean-combined-draw: DOM nodes -142
extension-clean-combined-draw: event listeners -87
extension-rgthree-prototype-draw: avg frame time 18ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 2
extension-rgthree-prototype-draw: task duration 6205ms
extension-rgthree-prototype-draw: script duration 4989ms
extension-rgthree-prototype-draw: TBT 66ms
extension-rgthree-prototype-draw: heap used 81.0 MB
extension-rgthree-prototype-draw: DOM nodes -119
extension-rgthree-prototype-draw: event listeners -87
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 11
large-graph-idle: task duration 488ms
large-graph-idle: script duration 31ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 76.4 MB
large-graph-idle: DOM nodes -242
large-graph-idle: event listeners -174
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1326ms
large-graph-pan: script duration 673ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 75.0 MB
large-graph-pan: DOM nodes -231
large-graph-pan: event listeners -174
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 1390ms
large-graph-zoom: script duration 630ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.8 MB
large-graph-zoom: DOM nodes -247
large-graph-zoom: event listeners -174
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1517ms
legacy-node-drag: script duration 775ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.1 MB
legacy-node-drag: DOM nodes 10
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 471ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 79.0 MB
minimap-idle: DOM nodes -246
minimap-idle: event listeners -174
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 50
subgraph-dom-widget-clipping: task duration 316ms
subgraph-dom-widget-clipping: script duration 116ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 79.5 MB
subgraph-dom-widget-clipping: DOM nodes 25
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 13
subgraph-idle: task duration 369ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.5 MB
subgraph-idle: DOM nodes -274
subgraph-idle: event listeners -220
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 0ms
subgraph-mouse-sweep: style recalc duration 12ms
subgraph-mouse-sweep: layout count 0
subgraph-mouse-sweep: style recalc count 47
subgraph-mouse-sweep: task duration 564ms
subgraph-mouse-sweep: script duration 76ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 68.0 MB
subgraph-mouse-sweep: DOM nodes -274
subgraph-mouse-sweep: event listeners -209
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 22ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 687ms
subgraph-transition-enter: script duration 21ms
subgraph-transition-enter: TBT 96ms
subgraph-transition-enter: heap used 78.1 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 4557ms
viewport-pan-sweep: script duration 2182ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 70.1 MB
viewport-pan-sweep: DOM nodes -238
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 13446ms
vue-large-graph-idle: script duration 227ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 164.4 MB
vue-large-graph-idle: DOM nodes -8063
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 13ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 124
vue-large-graph-pan: task duration 16440ms
vue-large-graph-pan: script duration 683ms
vue-large-graph-pan: TBT 10ms
vue-large-graph-pan: heap used 171.9 MB
vue-large-graph-pan: DOM nodes -8062
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 58ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4955ms
vue-node-resize-workload: script duration 82ms
vue-node-resize-workload: TBT 162ms
vue-node-resize-workload: heap used 168.8 MB
vue-node-resize-workload: DOM nodes -8062
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6835ms
vue-zoom-out-idle: script duration 98ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 176.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 3
workflow-execution: style recalc count 12
workflow-execution: task duration 76ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.4 MB
workflow-execution: DOM nodes 127
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-09-27T06:01:51.965Z",
  "gitSha": "6941b45e0c73075a0015954e9370e4b181b0e7e0",
  "branch": "backport-18870-to-cloud-1.55",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2017.3429999999826,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.9750000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 375.52500000000003,
      "heapDeltaBytes": -8153588,
      "heapUsedBytes": 59376976,
      "domNodes": -259,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 7.516,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2014.3920000000435,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.74999999999994,
      "heapDeltaBytes": -8171808,
      "heapUsedBytes": 59384264,
      "domNodes": -259,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.953000000000002,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1678.2929999999965,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 12.387,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 570.225,
      "heapDeltaBytes": -7541176,
      "heapUsedBytes": 60122984,
      "domNodes": -259,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 118.085,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1695.3009999999722,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 11.371,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 629.8790000000001,
      "heapDeltaBytes": -2335636,
      "heapUsedBytes": 60142180,
      "domNodes": -261,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 117.91300000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1693.3649999999716,
      "styleRecalcs": 28,
      "styleRecalcDurationMs": 11.462,
      "layouts": 6,
      "layoutDurationMs": 0.9460000000000001,
      "taskDurationMs": 256.776,
      "heapDeltaBytes": 3152256,
      "heapUsedBytes": 70409808,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 9.551,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1691.697999999974,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 11.941000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.06,
      "taskDurationMs": 265.883,
      "heapDeltaBytes": 3120192,
      "heapUsedBytes": 70801972,
      "domNodes": 78,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 9.549000000000001,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 541.5229999999838,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 7.237,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.471,
      "heapDeltaBytes": 18644500,
      "heapUsedBytes": 86175388,
      "domNodes": 22,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 131.855,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 543.6520000000655,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 8.32,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.742,
      "heapDeltaBytes": 18939884,
      "heapUsedBytes": 86721148,
      "domNodes": 25,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 134.38799999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1013.7880000000337,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 637.636,
      "heapDeltaBytes": 35314176,
      "heapUsedBytes": 104157764,
      "domNodes": 0,
      "jsHeapTotalBytes": 19820544,
      "scriptDurationMs": 50.30599999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 403,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1057.7560000000403,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 685.199,
      "heapDeltaBytes": 10048416,
      "heapUsedBytes": 100712892,
      "domNodes": -293,
      "jsHeapTotalBytes": 24268800,
      "scriptDurationMs": 49.96099999999999,
      "eventListeners": -195,
      "totalBlockingTimeMs": 432,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 762.3570000000086,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.8979999999996,
      "heapDeltaBytes": 14499048,
      "heapUsedBytes": 90911204,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 111.29300000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 154,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 766.2050000000136,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.8940000000004,
      "heapDeltaBytes": 14827904,
      "heapUsedBytes": 91319148,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 113.55599999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 156,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7128.05400000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6318.249,
      "heapDeltaBytes": -7881296,
      "heapUsedBytes": 74080352,
      "domNodes": -18,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 5272.897999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 27,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 33.30000000000109
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6943.208000000027,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.5980000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6159.889999999999,
      "heapDeltaBytes": -4223820,
      "heapUsedBytes": 73486104,
      "domNodes": -265,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 4935.474999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 26,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7362.223999999969,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.09699999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6487.233,
      "heapDeltaBytes": 10459416,
      "heapUsedBytes": 85323356,
      "domNodes": -6,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 5247.448,
      "eventListeners": 0,
      "totalBlockingTimeMs": 100,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6601.585,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.1480000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5922.192,
      "heapDeltaBytes": 6573436,
      "heapUsedBytes": 84469116,
      "domNodes": -231,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 4730.367,
      "eventListeners": -174,
      "totalBlockingTimeMs": 31,
      "frameDurationMs": 17.773333333333298,
      "p95FrameDurationMs": 33.30000000000109
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2023.3670000000075,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.589999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 484.387,
      "heapDeltaBytes": -6748084,
      "heapUsedBytes": 80328184,
      "domNodes": -242,
      "jsHeapTotalBytes": -757760,
      "scriptDurationMs": 27.654000000000003,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2042.276999999899,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.049999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.9720000000001,
      "heapDeltaBytes": -7567088,
      "heapUsedBytes": 79870528,
      "domNodes": -241,
      "jsHeapTotalBytes": 1077248,
      "scriptDurationMs": 34.089999999999996,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2189.6830000000023,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 12.654999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1360.0330000000001,
      "heapDeltaBytes": 114684,
      "heapUsedBytes": 81707628,
      "domNodes": -213,
      "jsHeapTotalBytes": 2314240,
      "scriptDurationMs": 692.62,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2132.0619999999053,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 12.819,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1291.234,
      "heapDeltaBytes": -12566820,
      "heapUsedBytes": 75660940,
      "domNodes": -248,
      "jsHeapTotalBytes": 1302528,
      "scriptDurationMs": 654.029,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3219.5730000000253,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 14.189999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.132,
      "taskDurationMs": 1400.4309999999998,
      "heapDeltaBytes": -15201636,
      "heapUsedBytes": 74522676,
      "domNodes": -244,
      "jsHeapTotalBytes": 28672,
      "scriptDurationMs": 642.685,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3142.673000000059,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 12.739999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.17,
      "taskDurationMs": 1379.53,
      "heapDeltaBytes": -15977592,
      "heapUsedBytes": 74024608,
      "domNodes": -250,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 617.572,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2296.4850000000183,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.6,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1532.8300000000002,
      "heapDeltaBytes": -13176212,
      "heapUsedBytes": 78041932,
      "domNodes": 14,
      "jsHeapTotalBytes": 6328320,
      "scriptDurationMs": 789.174,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2299.4090000000824,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 6.035000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1502.053,
      "heapDeltaBytes": 17630696,
      "heapUsedBytes": 83599152,
      "domNodes": 6,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 761.366,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2046.3300000000118,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.923000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.7870000000001,
      "heapDeltaBytes": -5890172,
      "heapUsedBytes": 82515012,
      "domNodes": -244,
      "jsHeapTotalBytes": 28672,
      "scriptDurationMs": 29.891000000000002,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2024.7349999999642,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.127999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 454.62,
      "heapDeltaBytes": -5890124,
      "heapUsedBytes": 83087828,
      "domNodes": -247,
      "jsHeapTotalBytes": 28672,
      "scriptDurationMs": 32.212,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 491.74899999997024,
      "styleRecalcs": 50,
      "styleRecalcDurationMs": 10.272,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 313.986,
      "heapDeltaBytes": 14013568,
      "heapUsedBytes": 82931884,
      "domNodes": 25,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 115.87700000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 510.8500000000049,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 10.400000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 317.18499999999995,
      "heapDeltaBytes": 13807564,
      "heapUsedBytes": 83846852,
      "domNodes": 24,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 115.65400000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1988.5949999999752,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.645000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 371.38500000000005,
      "heapDeltaBytes": -6528132,
      "heapUsedBytes": 63432428,
      "domNodes": -274,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 6.790999999999999,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.7590000000118,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 7.768000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 367.544,
      "heapDeltaBytes": -6512376,
      "heapUsedBytes": 63489388,
      "domNodes": -273,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.042999999999999,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.3089999999993,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.062000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 570.199,
      "heapDeltaBytes": -8151848,
      "heapUsedBytes": 61893260,
      "domNodes": -274,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 76.656,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.0889999999863,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.677999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 557.1129999999999,
      "heapDeltaBytes": 10594624,
      "heapUsedBytes": 80626624,
      "domNodes": -273,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 74.58000000000001,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 867.2159999999849,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 21.994,
      "layouts": 5,
      "layoutDurationMs": 9.554000000000002,
      "taskDurationMs": 687.1640000000001,
      "heapDeltaBytes": -6294184,
      "heapUsedBytes": 81937676,
      "domNodes": 13667,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 21.025999999999996,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 96,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8196.477000000015,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 33.797000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4518.236,
      "heapDeltaBytes": -12044860,
      "heapUsedBytes": 68342936,
      "domNodes": -243,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 2160.7729999999997,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8191.927999999962,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 33.612,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4595.903,
      "heapDeltaBytes": -8499552,
      "heapUsedBytes": 78715828,
      "domNodes": -233,
      "jsHeapTotalBytes": 778240,
      "scriptDurationMs": 2202.701,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14039.90699999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13489.924000000003,
      "heapDeltaBytes": -45243744,
      "heapUsedBytes": 182168228,
      "domNodes": -8062,
      "jsHeapTotalBytes": -18677760,
      "scriptDurationMs": 235.80499999999998,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13854.844999999954,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13402.705000000002,
      "heapDeltaBytes": -74831884,
      "heapUsedBytes": 162558348,
      "domNodes": -8063,
      "jsHeapTotalBytes": -19247104,
      "scriptDurationMs": 218.90500000000003,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16783.93900000003,
      "styleRecalcs": 121,
      "styleRecalcDurationMs": 13.271000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16415.899000000005,
      "heapDeltaBytes": -69233928,
      "heapUsedBytes": 168497844,
      "domNodes": -8062,
      "jsHeapTotalBytes": -16625664,
      "scriptDurationMs": 682.933,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16821.774000000005,
      "styleRecalcs": 127,
      "styleRecalcDurationMs": 13.16500000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16463.406,
      "heapDeltaBytes": -31704180,
      "heapUsedBytes": 191898512,
      "domNodes": -8062,
      "jsHeapTotalBytes": -21798912,
      "scriptDurationMs": 682.6419999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5006.847999999991,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 57.53,
      "layouts": 20,
      "layoutDurationMs": 20.863000000000007,
      "taskDurationMs": 4923.858,
      "heapDeltaBytes": -49303976,
      "heapUsedBytes": 176612064,
      "domNodes": -8062,
      "jsHeapTotalBytes": 7331840,
      "scriptDurationMs": 81.74100000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 166,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5022.99400000004,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 58.585,
      "layouts": 20,
      "layoutDurationMs": 20.457000000000004,
      "taskDurationMs": 4986.655999999999,
      "heapDeltaBytes": -57163956,
      "heapUsedBytes": 177461920,
      "domNodes": -8062,
      "jsHeapTotalBytes": 10969088,
      "scriptDurationMs": 81.896,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 158,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6941.888000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6796.090000000001,
      "heapDeltaBytes": -2365184,
      "heapUsedBytes": 194636732,
      "domNodes": 0,
      "jsHeapTotalBytes": -28049408,
      "scriptDurationMs": 101.78599999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7051.68500000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6872.9929999999995,
      "heapDeltaBytes": -15450916,
      "heapUsedBytes": 174642576,
      "domNodes": 0,
      "jsHeapTotalBytes": -26738688,
      "scriptDurationMs": 95.14799999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 89.3909999999778,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 13.536999999999999,
      "layouts": 2,
      "layoutDurationMs": 1.1409999999999998,
      "taskDurationMs": 63.78799999999998,
      "heapDeltaBytes": 3178960,
      "heapUsedBytes": 68692544,
      "domNodes": 129,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.280000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 436.4060000000336,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 17.619,
      "layouts": 3,
      "layoutDurationMs": 0.7649999999999999,
      "taskDurationMs": 88.157,
      "heapDeltaBytes": 4914364,
      "heapUsedBytes": 70498044,
      "domNodes": 125,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.88,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52315 79094 66.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.8% 1153
src/LGraphNode.ts 70.5% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.1% 330
src/LGraph.ts 78.6% 272
src/scripts/app.ts 72.3% 259
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.3% 233
src/scripts/pnginfo.ts 20.8% 221

@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.56098% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/account-core/src/core/sessionTokenMint.ts 97.56% 1 Missing and 1 partial ⚠️
@@              Coverage Diff              @@
##             cloud/1.55   #19001   +/-   ##
=============================================
  Coverage              ?   83.68%           
=============================================
  Files                 ?     3025           
  Lines                 ?   149444           
  Branches              ?    40540           
=============================================
  Hits                  ?   125063           
  Misses                ?    23063           
  Partials              ?     1318           
Flag Coverage Δ
billing-web-unit 88.44% <ø> (?)
e2e 66.13% <ø> (?)
unit 80.51% <97.56%> (?)
website-unit 76.24% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/account-core/src/core/sessionTokenMint.ts 97.56% <97.56%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 26, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against #18870 before approving: identical file list, and no conflict markers anywhere in the diff. All three required checks green (lint-and-format, test, e2e-status).

@christian-byrne

Copy link
Copy Markdown
Contributor

Rebased onto current cloud/1.55 — the branch went DIRTY when the PRs ahead of it merged. Cherry-pick reapplied clean, no conflicts, same 6 files as the original. Force-pushed.

…ssion (#18870)

> **Stacked on #18716 (FE-2895). Do not merge** until #18716 merges and
C8 (BE-17069, cloud#10585 + #10697: `POST /api/auth/token` accepts the
cookie) is on testcloud.

## Why

comfy-api and the other services cannot read the session cookie. A site
that arrived by session has no Firebase login to hand them. TDD §7/§12
has the site mint a short-lived workspace token from the session, lazily
and only when a non-ingest call needs one. This is the token source
`authorize()` (#18716) takes for its `resource` target.

## How

New entry `@comfyorg/account-core/sessionTokenMint`:
`createSessionTokenMint({ apiBaseUrl, fetchImpl, getSession, now?,
refreshBufferMs? })` returns:
- `mint(workspaceId?)`, which returns a coded result;
- `getWorkspaceToken(workspaceId?)`, which plugs into
`createRequestAuthorizer({ getWorkspaceToken })` and rejects with
`SessionTokenError` on failure.

Details:
- **Request.** `POST /auth/token` with `credentials: 'include'`,
`X-Comfy-Client`, `X-CSRF-Token` and `X-Comfy-Workspace-ID`. The body is
`{}` for the personal workspace or `{ workspace_id }`. No
`Authorization` header is sent. The response is parsed with the
generated `zExchangeTokenResponse`, since C8 leaves the 200 shape
unchanged.
- **Lazy.** Nothing is sent until the first call.
- **Cache.** Tokens are cached per workspace and owned by the current
session user, and reused until 60 s before expiry. Concurrent callers
for one workspace share a single request. A user change or sign-out
drops the cache and anything in flight, and a token that arrives after
the user changed is not cached.
- **Failure codes.** A 401 is the session's code (and clears the cache).
403 `csrf_invalid` is `CSRF_STALE` and 403 `workspace_access_denied` is
`WORKSPACE_ACCESS_DENIED`. Other 403s, 400 and 404 are refused. 5xx and
network errors are transient. A 429 carries `retryAfterMs` and holds
further requests until then.
- **Inert on import.** It is added to the importGuard closure, the
inert-import test, package exports and smokePack. No app wires it yet,
and the flag-off harness is unchanged (4/4).
- **For review:**
- It sends `X-Comfy-Workspace-ID` equal to the body's `workspace_id`. C8
only rejects a header that names a different workspace; if you'd rather
send none, it's a one-line removal.
- It has its own classifier because C8 defines a code-less 401 as a dead
session, where `webSession.ts` refuses it.

## AS IS / TO BE

No UI; the evidence is tests.

- AS IS: a session-only site has no token for comfy-api.
- TO BE: tests cover zero requests before the first call, headers and
credentials, cache hit, re-mint at expiry, single-flight, the cache
dropping on a user change, per-workspace keys, a late token not cached
across users, 401/403/404/429/5xx mapping, and Retry-After.

Eight mutations, each reverted with the full suite rerun, all go red:
cache key, user-change drop, expiry buffer, credentials, single-flight,
Retry-After, stale-owner guard, and 401 cache clear.

Checks: account-core 1139 tests pass; typecheck, lint, knip, fallow and
smoke:pack are clean.

## Links

- TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b
(sections 7, 9, 12, F6)
- Action items:
https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3
- Linear: https://linear.app/comfyorg/issue/FE-2900
- Contract: Comfy-Org/cloud#10585, Comfy-Org/cloud#10697

## Where this PR sits in the plan

| Ticket | Scope | Blocked by | State |
| --- | --- | --- | --- |
| FE-2891 | flag (cloud) + website/billing-web readers | C11 cloud#10689
+ probe switch (readers) | #18708 merged; readers in progress |
| FE-2892 | web session client (+ revoke-all follow-up) | C2a
cloud#10589 for revoke-all | #18710 merged; revoke-all #18869, do not
merge |
| FE-2893 | ADR | none | #18707 merged |
| FE-2894 | identity + boot rules | BE-17063 on testcloud | #18715, do
not merge |
| FE-2895 | `authorize()` | C5 cloud#10555 | #18716, do not merge |
| FE-2897 | lifecycle, heartbeat | FE-2894, C1 | #18719, do not merge |
| **FE-2900 (this PR)** | lazy token mint from the session | FE-2895, C8
cloud#10585 | #18870, do not merge |
| FE-2901 | non-web clients stay on tokens | — | #18711 |
| FE-2903 | cloud app joins the lifecycle | FE-2897 | #18871, do not
merge |
| FE-2904 | cloud API client on `authorize()` | FE-2903, FE-2895, C5 |
in progress |
| FE-2905 | socket + media carry workspace | FE-2904, C6, C7 | next |
| FE-2896 / 2899 / 2898 | website header, website credits, billing-web |
FE-2891 readers, FE-2894/2895, C5, C11 | next |
| FE-2906 | cross-origin E2E harness | — | #18718 (harness only) |
| FE-2902 / 2907 / 2908 | platform, rollout, cleanup | other repo / ops
/ after ramp | not started |

```mermaid
flowchart LR
  subgraph BE["BE · cloud ingest and infra"]
    C0["BE-17071 C0 preview CORS gate"]
    C1["BE-17061 C1 sessions table + revocable cookie"]
    C3["BE-17063 C3 GET /session, trusted origins, flag"]
    C4["BE-17062 C4 shared workspace resolution"]
    C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"]
    C2["BE-17064 C2 revoke-all, purge, caps"]
    C6["BE-17067 C6 WebSocket on session"]
    C7["BE-17068 C7 scoped media"]
    C8["BE-17069 C8 token mint from session"]
    C9["BE-17065 C9 Redis cache + load test"]
    C10["BE-17072 C10 prod config, cleanup"]
    C11["C11 flag before sign-in (OQ17)"]
    B135["BE-17135 serve unified_web_session (server AND)"]
    I2["BE-17070 I2 edge limit, log + DNS audit"]
  end
  subgraph SDK["FE · account-core"]
    F2891["FE-2891 flag"]
    F2892["FE-2892 web session client"]
    F2894["FE-2894 identity + boot rules"]
    F2897["FE-2897 lifecycle, heartbeat"]
    F2895["FE-2895 authorize()"]
    F2900["FE-2900 lazy token mint"]
    F2901["FE-2901 non-web stay on tokens"]
  end
  subgraph APPS["FE · apps"]
    F2896["FE-2896 website header"]
    F2903["FE-2903 cloud lifecycle"]
    F2899["FE-2899 website credits"]
    F2904["FE-2904 cloud API client"]
    F2905["FE-2905 socket + media"]
    F2898["FE-2898 billing-web joins session"]
    F2902["FE-2902 platform"]
  end
  subgraph QA["QA · rollout · docs"]
    F2906["FE-2906 cross-origin E2E"]
    F2893["FE-2893 ADR + docs"]
    F2907["FE-2907 ramp + rollback"]
    F2908["FE-2908 cleanup"]
  end
  C0 --> C1 --> C3 --> C5
  C3 --> C11 --> F2891
  B135 --> F2891
  C4 --> C5
  C1 --> C2
  C1 --> C9
  C5 --> C6 & C7 & C8
  C3 --> F2892
  C1 --> F2892
  F2891 --> F2894
  C3 --> F2894
  F2892 --> F2894 --> F2896
  F2894 --> F2897 --> F2903
  C1 --> F2897
  F2892 --> F2895
  C5 --> F2895
  F2895 --> F2899 & F2904 & F2900 & F2901 & F2902
  C5 --> F2899 & F2904
  F2903 --> F2904 --> F2905
  C6 --> F2905
  C7 --> F2905
  C8 --> F2900
  F2894 --> F2898
  F2895 --> F2898
  C3 --> F2898
  C5 --> F2898
  F2903 & F2904 & F2905 & F2898 --> F2906
  C3 & C2 --> F2906
  F2906 --> F2907
  C9 & C10 & I2 --> F2907
  F2907 --> F2908
  C10 --> F2908
  classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000
  class F2900 thisPr
```

- Blocked by: #18716 (FE-2895) and C8 cloud#10585 on testcloud.
- Unblocks: comfy-api callers on session sites (FE-2904 host wiring,
FE-2898 billing-web).

---------

Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com>
(cherry picked from commit 70ce571)
@christian-byrne
christian-byrne force-pushed the backport-18870-to-cloud-1.55 branch from a9d120c to a312ba8 Compare September 27, 2026 05:45
@christian-byrne

Copy link
Copy Markdown
Contributor

Correction to my earlier note: that rebase never reached the branch. I pushed with a bare git push -f from a worktree branch that had no upstream configured, then reported success from the local SHA instead of the remote one — so the branch stayed on its original commit and showed DIRTY again.

Redone properly, with an explicit refspec and the remote SHA checked against local. The cherry-pick applies clean onto current cloud/1.55, no conflicts, same file list as the original.

@christian-byrne
christian-byrne merged commit 146c193 into cloud/1.55 Sep 27, 2026
113 checks passed
@christian-byrne
christian-byrne deleted the backport-18870-to-cloud-1.55 branch September 27, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants