Repository navigation
[backport core/1.55] FE-2900 feat(account-core): lazy workspace-token mint from the web session - #19000
Conversation
…ssion (#18870) > **Stacked on #18716 (FE-2895). Do not merge** until #18716 merges and C8 (BE-17069, cloud#10585 + #10697: `POST /api/auth/token` accepts the cookie) is on testcloud. comfy-api and the other services cannot read the session cookie. A site that arrived by session has no Firebase login to hand them. TDD §7/§12 has the site mint a short-lived workspace token from the session, lazily and only when a non-ingest call needs one. This is the token source `authorize()` (#18716) takes for its `resource` target. New entry `@comfyorg/account-core/sessionTokenMint`: `createSessionTokenMint({ apiBaseUrl, fetchImpl, getSession, now?, refreshBufferMs? })` returns: - `mint(workspaceId?)`, which returns a coded result; - `getWorkspaceToken(workspaceId?)`, which plugs into `createRequestAuthorizer({ getWorkspaceToken })` and rejects with `SessionTokenError` on failure. Details: - **Request.** `POST /auth/token` with `credentials: 'include'`, `X-Comfy-Client`, `X-CSRF-Token` and `X-Comfy-Workspace-ID`. The body is `{}` for the personal workspace or `{ workspace_id }`. No `Authorization` header is sent. The response is parsed with the generated `zExchangeTokenResponse`, since C8 leaves the 200 shape unchanged. - **Lazy.** Nothing is sent until the first call. - **Cache.** Tokens are cached per workspace and owned by the current session user, and reused until 60 s before expiry. Concurrent callers for one workspace share a single request. A user change or sign-out drops the cache and anything in flight, and a token that arrives after the user changed is not cached. - **Failure codes.** A 401 is the session's code (and clears the cache). 403 `csrf_invalid` is `CSRF_STALE` and 403 `workspace_access_denied` is `WORKSPACE_ACCESS_DENIED`. Other 403s, 400 and 404 are refused. 5xx and network errors are transient. A 429 carries `retryAfterMs` and holds further requests until then. - **Inert on import.** It is added to the importGuard closure, the inert-import test, package exports and smokePack. No app wires it yet, and the flag-off harness is unchanged (4/4). - **For review:** - It sends `X-Comfy-Workspace-ID` equal to the body's `workspace_id`. C8 only rejects a header that names a different workspace; if you'd rather send none, it's a one-line removal. - It has its own classifier because C8 defines a code-less 401 as a dead session, where `webSession.ts` refuses it. No UI; the evidence is tests. - AS IS: a session-only site has no token for comfy-api. - TO BE: tests cover zero requests before the first call, headers and credentials, cache hit, re-mint at expiry, single-flight, the cache dropping on a user change, per-workspace keys, a late token not cached across users, 401/403/404/429/5xx mapping, and Retry-After. Eight mutations, each reverted with the full suite rerun, all go red: cache key, user-change drop, expiry buffer, credentials, single-flight, Retry-After, stale-owner guard, and 401 cache clear. Checks: account-core 1139 tests pass; typecheck, lint, knip, fallow and smoke:pack are clean. - TDD: https://app.notion.com/p/3de6d73d365081d7a4c8f808c0a0384b (sections 7, 9, 12, F6) - Action items: https://app.notion.com/p/3e56d73d3650812d962decc97fbd9ea3 - Linear: https://linear.app/comfyorg/issue/FE-2900 - Contract: Comfy-Org/cloud#10585, Comfy-Org/cloud#10697 | Ticket | Scope | Blocked by | State | | --- | --- | --- | --- | | FE-2891 | flag (cloud) + website/billing-web readers | C11 cloud#10689 + probe switch (readers) | #18708 merged; readers in progress | | FE-2892 | web session client (+ revoke-all follow-up) | C2a cloud#10589 for revoke-all | #18710 merged; revoke-all #18869, do not merge | | FE-2893 | ADR | none | #18707 merged | | FE-2894 | identity + boot rules | BE-17063 on testcloud | #18715, do not merge | | FE-2895 | `authorize()` | C5 cloud#10555 | #18716, do not merge | | FE-2897 | lifecycle, heartbeat | FE-2894, C1 | #18719, do not merge | | **FE-2900 (this PR)** | lazy token mint from the session | FE-2895, C8 cloud#10585 | #18870, do not merge | | FE-2901 | non-web clients stay on tokens | — | #18711 | | FE-2903 | cloud app joins the lifecycle | FE-2897 | #18871, do not merge | | FE-2904 | cloud API client on `authorize()` | FE-2903, FE-2895, C5 | in progress | | FE-2905 | socket + media carry workspace | FE-2904, C6, C7 | next | | FE-2896 / 2899 / 2898 | website header, website credits, billing-web | FE-2891 readers, FE-2894/2895, C5, C11 | next | | FE-2906 | cross-origin E2E harness | — | #18718 (harness only) | | FE-2902 / 2907 / 2908 | platform, rollout, cleanup | other repo / ops / after ramp | not started | ```mermaid flowchart LR subgraph BE["BE · cloud ingest and infra"] C0["BE-17071 C0 preview CORS gate"] C1["BE-17061 C1 sessions table + revocable cookie"] C3["BE-17063 C3 GET /session, trusted origins, flag"] C4["BE-17062 C4 shared workspace resolution"] C5["BE-17066 C5 cookie on API: CSRF, Origin, workspace header"] C2["BE-17064 C2 revoke-all, purge, caps"] C6["BE-17067 C6 WebSocket on session"] C7["BE-17068 C7 scoped media"] C8["BE-17069 C8 token mint from session"] C9["BE-17065 C9 Redis cache + load test"] C10["BE-17072 C10 prod config, cleanup"] C11["C11 flag before sign-in (OQ17)"] B135["BE-17135 serve unified_web_session (server AND)"] I2["BE-17070 I2 edge limit, log + DNS audit"] end subgraph SDK["FE · account-core"] F2891["FE-2891 flag"] F2892["FE-2892 web session client"] F2894["FE-2894 identity + boot rules"] F2897["FE-2897 lifecycle, heartbeat"] F2895["FE-2895 authorize()"] F2900["FE-2900 lazy token mint"] F2901["FE-2901 non-web stay on tokens"] end subgraph APPS["FE · apps"] F2896["FE-2896 website header"] F2903["FE-2903 cloud lifecycle"] F2899["FE-2899 website credits"] F2904["FE-2904 cloud API client"] F2905["FE-2905 socket + media"] F2898["FE-2898 billing-web joins session"] F2902["FE-2902 platform"] end subgraph QA["QA · rollout · docs"] F2906["FE-2906 cross-origin E2E"] F2893["FE-2893 ADR + docs"] F2907["FE-2907 ramp + rollback"] F2908["FE-2908 cleanup"] end C0 --> C1 --> C3 --> C5 C3 --> C11 --> F2891 B135 --> F2891 C4 --> C5 C1 --> C2 C1 --> C9 C5 --> C6 & C7 & C8 C3 --> F2892 C1 --> F2892 F2891 --> F2894 C3 --> F2894 F2892 --> F2894 --> F2896 F2894 --> F2897 --> F2903 C1 --> F2897 F2892 --> F2895 C5 --> F2895 F2895 --> F2899 & F2904 & F2900 & F2901 & F2902 C5 --> F2899 & F2904 F2903 --> F2904 --> F2905 C6 --> F2905 C7 --> F2905 C8 --> F2900 F2894 --> F2898 F2895 --> F2898 C3 --> F2898 C5 --> F2898 F2903 & F2904 & F2905 & F2898 --> F2906 C3 & C2 --> F2906 F2906 --> F2907 C9 & C10 & I2 --> F2907 F2907 --> F2908 C10 --> F2908 classDef thisPr fill:#ffe08a,stroke:#b8860b,stroke-width:4px,color:#000 class F2900 thisPr ``` - Blocked by: #18716 (FE-2895) and C8 cloud#10585 on testcloud. - Unblocks: comfy-api callers on session sites (FE-2904 host wiring, FE-2898 billing-web). --------- Co-authored-by: mattmillerai <7741082+mattmillerai@users.noreply.github.com> (cherry picked from commit 70ce571)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 003b462f86a01d7f23fd1494238d7e20e8dfaad2
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-26T12:58:01.582Z",
"gitSha": "14df49895d8deccbe952017ff657b7ed8d1facbb",
"branch": "backport-18870-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.5960000000114,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.078,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.13599999999997,
"heapDeltaBytes": -7741488,
"heapUsedBytes": 60013680,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.908000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2022.7929999999787,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.915999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.4939999999999,
"heapDeltaBytes": 10092440,
"heapUsedBytes": 77508332,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.921999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.3140000000217,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.652999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 760.648,
"heapDeltaBytes": 10596228,
"heapUsedBytes": 78195056,
"domNodes": -260,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 153.91100000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.316999999981,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.122,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 781.856,
"heapDeltaBytes": 10467284,
"heapUsedBytes": 77956888,
"domNodes": -260,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 157.36999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.3579999999952,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.294999999999998,
"layouts": 6,
"layoutDurationMs": 1.186,
"taskDurationMs": 319.83099999999996,
"heapDeltaBytes": 3149008,
"heapUsedBytes": 70787980,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.624999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.7639999999437,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.687000000000001,
"layouts": 6,
"layoutDurationMs": 1.059,
"taskDurationMs": 314.76400000000007,
"heapDeltaBytes": 3135768,
"heapUsedBytes": 70896496,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.062999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 628.8010000000099,
"styleRecalcs": 14,
"styleRecalcDurationMs": 10.004000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.781,
"heapDeltaBytes": 19180544,
"heapUsedBytes": 86681256,
"domNodes": 24,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 165.615,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 635.0049999999783,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.494,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.49899999999997,
"heapDeltaBytes": 18945444,
"heapUsedBytes": 86554576,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 169.44600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1216.7059999999879,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 861.097,
"heapDeltaBytes": -17287128,
"heapUsedBytes": 72728232,
"domNodes": -294,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 75.70700000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 560,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1224.7899999999845,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 897.099,
"heapDeltaBytes": -17186528,
"heapUsedBytes": 73008732,
"domNodes": -292,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 73.34400000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 554,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 840.1700000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.5399999999996,
"heapDeltaBytes": 14786792,
"heapUsedBytes": 91076728,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.74300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.3269999999502,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.4440000000001,
"heapDeltaBytes": 14645432,
"heapUsedBytes": 91083452,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.47,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10557.32599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9635.912,
"heapDeltaBytes": 3328576,
"heapUsedBytes": 85244480,
"domNodes": -16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8241.152,
"eventListeners": 0,
"totalBlockingTimeMs": 1342,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10350.174000000039,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9463.248,
"heapDeltaBytes": 11550788,
"heapUsedBytes": 93535696,
"domNodes": -16,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 7887.374000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 937,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9948.341999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9103.107,
"heapDeltaBytes": 10775764,
"heapUsedBytes": 93201936,
"domNodes": -16,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7538.009,
"eventListeners": 0,
"totalBlockingTimeMs": 828,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10151.758000000085,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9322.706999999999,
"heapDeltaBytes": -9854840,
"heapUsedBytes": 72380788,
"domNodes": -12,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7748.3910000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 928,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2039.4360000000233,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.386999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.2139999999998,
"heapDeltaBytes": -3486416,
"heapUsedBytes": 83778736,
"domNodes": -238,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 30.196,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2036.1749999999574,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.077999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.7130000000001,
"heapDeltaBytes": -2823252,
"heapUsedBytes": 83633612,
"domNodes": -239,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 28.787999999999993,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2184.6249999999827,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.488999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1551.2749999999999,
"heapDeltaBytes": 15644284,
"heapUsedBytes": 79957052,
"domNodes": -248,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 817.629,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2208.804999999984,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.588,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1626.7640000000001,
"heapDeltaBytes": -3877800,
"heapUsedBytes": 84023116,
"domNodes": -246,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 841.0089999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3515.3930000000173,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.141000000000004,
"layouts": 60,
"layoutDurationMs": 12.972000000000001,
"taskDurationMs": 1652.5349999999999,
"heapDeltaBytes": 7364220,
"heapUsedBytes": 73915388,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 785.377,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3485.712999999919,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.381000000000002,
"layouts": 60,
"layoutDurationMs": 12.504000000000001,
"taskDurationMs": 1613.595,
"heapDeltaBytes": 8012728,
"heapUsedBytes": 74237536,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 769.784,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2903.7459999999555,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.779,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1853.1190000000001,
"heapDeltaBytes": 19785552,
"heapUsedBytes": 85636376,
"domNodes": 6,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 967.237,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3067.8040000000237,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.904000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1950.9569999999999,
"heapDeltaBytes": -7340284,
"heapUsedBytes": 76955660,
"domNodes": -224,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 972.1769999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2038.2860000000278,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.871000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.174,
"heapDeltaBytes": -6112876,
"heapUsedBytes": 82339692,
"domNodes": -248,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 31.15,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2025.66499999989,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.318,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.8669999999998,
"heapDeltaBytes": -4996160,
"heapUsedBytes": 84155728,
"domNodes": -247,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.11899999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 563.5769999999525,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.349,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.086,
"heapDeltaBytes": 13992948,
"heapUsedBytes": 82979692,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 149.10600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 585.8850000000757,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.443,
"heapDeltaBytes": 13384188,
"heapUsedBytes": 83509364,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 144.156,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.312999999997,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.293999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.00699999999995,
"heapDeltaBytes": 11793132,
"heapUsedBytes": 81582424,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.862,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.756000000043,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.55,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.4509999999999,
"heapDeltaBytes": -3595548,
"heapUsedBytes": 65981704,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.496999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.209000000029,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.098999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 701.1769999999999,
"heapDeltaBytes": -9688008,
"heapUsedBytes": 60282916,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 100.827,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1703.055000000063,
"styleRecalcs": 45,
"styleRecalcDurationMs": 12.565,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 706.01,
"heapDeltaBytes": 7965612,
"heapUsedBytes": 77781020,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 99.76599999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1350.928999999951,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.221000000000004,
"layouts": 5,
"layoutDurationMs": 12.781999999999998,
"taskDurationMs": 861.129,
"heapDeltaBytes": -6266712,
"heapUsedBytes": 80884556,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 28.925,
"eventListeners": 2383,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8474.306000000013,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.647,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5852.875999999999,
"heapDeltaBytes": -7676604,
"heapUsedBytes": 79158056,
"domNodes": -241,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 2913.56,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8342.396000000008,
"styleRecalcs": 251,
"styleRecalcDurationMs": 34.35,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5604.639,
"heapDeltaBytes": -5894012,
"heapUsedBytes": 81104752,
"domNodes": -237,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 2717.707,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16563.107000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15671.003000000002,
"heapDeltaBytes": -29120132,
"heapUsedBytes": 190788168,
"domNodes": -8061,
"jsHeapTotalBytes": -15970304,
"scriptDurationMs": 287.248,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16366.807999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15545.644999999999,
"heapDeltaBytes": -51785208,
"heapUsedBytes": 168827192,
"domNodes": -8062,
"jsHeapTotalBytes": -21561344,
"scriptDurationMs": 269.115,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20037.119000000017,
"styleRecalcs": 164,
"styleRecalcDurationMs": 16.182000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19668.938000000002,
"heapDeltaBytes": -72229284,
"heapUsedBytes": 168874164,
"domNodes": -8062,
"jsHeapTotalBytes": -20647936,
"scriptDurationMs": 920.65,
"eventListeners": -14928,
"totalBlockingTimeMs": 78,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20086.663999999928,
"styleRecalcs": 161,
"styleRecalcDurationMs": 15.485,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19723.585,
"heapDeltaBytes": -68673552,
"heapUsedBytes": 169228360,
"domNodes": -8061,
"jsHeapTotalBytes": -17235968,
"scriptDurationMs": 877.037,
"eventListeners": -14928,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5884.348999999986,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.73599999999998,
"layouts": 20,
"layoutDurationMs": 21.988000000000007,
"taskDurationMs": 5787.474,
"heapDeltaBytes": -34770676,
"heapUsedBytes": 182918880,
"domNodes": -8061,
"jsHeapTotalBytes": 14483456,
"scriptDurationMs": 104.79399999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 333,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5939.044999999965,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.105,
"layouts": 20,
"layoutDurationMs": 22.157999999999998,
"taskDurationMs": 5834.496999999999,
"heapDeltaBytes": -72131960,
"heapUsedBytes": 168396432,
"domNodes": -8061,
"jsHeapTotalBytes": 2203648,
"scriptDurationMs": 123.56099999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 316,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8287.33299999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7958.2029999999995,
"heapDeltaBytes": -8957168,
"heapUsedBytes": 179193752,
"domNodes": 0,
"jsHeapTotalBytes": -6553600,
"scriptDurationMs": 151.40900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8159.648999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7811.512999999998,
"heapDeltaBytes": 10004456,
"heapUsedBytes": 191270636,
"domNodes": 0,
"jsHeapTotalBytes": -27262976,
"scriptDurationMs": 120.76400000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 477.22699999997076,
"styleRecalcs": 23,
"styleRecalcDurationMs": 29.816,
"layouts": 5,
"layoutDurationMs": 2.595,
"taskDurationMs": 150.69000000000003,
"heapDeltaBytes": 5379184,
"heapUsedBytes": 70969504,
"domNodes": 157,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 17.21,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 102.99900000006801,
"styleRecalcs": 9,
"styleRecalcDurationMs": 17.252999999999997,
"layouts": 3,
"layoutDurationMs": 1.503,
"taskDurationMs": 77.63899999999998,
"heapDeltaBytes": 3094104,
"heapUsedBytes": 68505376,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.9110000000000005,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.55 #19000 +/- ##
=============================================
- Coverage 84.61% 83.69% -0.93%
=============================================
Files 2296 3023 +727
Lines 131458 149223 +17765
Branches 35487 40460 +4973
=============================================
+ Hits 111227 124885 +13658
- Misses 19927 23028 +3101
- Partials 304 1310 +1006
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 730 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #18870 to
core/1.55(cherry-pick -x of 70ce571).Why
Ships the lazy workspace-token mint (
@comfyorg/account-core/sessionTokenMint) on the 1.55 line, next toauthorize()from #18716 (already backported as #18940/#18941).Root cause
The backport bot hit conflicts in
packages/account-core/package.json(exports),scripts/smokePack.ts,src/core/importGuard.test.tsandsrc/webSessionInertImport.test.ts. On main these lists also carrywebSessionIdentityfrom #18715 (FE-2894), which is not on 1.55.How
Kept the release branch's code and added only #18870's own entries: the
./sessionTokenMintexport (source + dist), its smoke-pack import/value/type, its inert-import case, and the Firebase import-guard case (it.for(['webSession.ts', 'sessionTokenMint.ts'])). Dropped everywebSessionIdentityentry.sessionTokenMint.tsand its test apply unchanged; they import onlyrequestAuth,credentialCache,sessionContracts,testingand@comfyorg/ingest-types/zod, all present on 1.55. Verified withpnpm typecheck:account-coreand the sessionTokenMint, importGuard, webSessionInertImport and requestAuth vitest files (73 passed).AS IS / TO BE
No UI change (inert behind
unified_web_session).