Repository navigation
[backport cloud/1.54] feat: add agent_panel_open to run attribution events (PM-1471) (#18401) - #18923
Conversation
…vents (PM-1471) (#18401) Records whether the agent panel was open when a run was submitted, on both run-attribution events the frontend emits - app:run_button_click and execution_start. agent_panel_open: boolean is added to RunButtonProperties and populated in getRunButtonTelemetryProperties(); added to the execution_start payload in PostHogTelemetryProvider, carried over from the run button so the two events a single run produces agree; forwarded by GtmTelemetryProvider.trackRunButton. New getAgentPanelOpen() util in platform/telemetry/utils/ reads the key useAgentPanelStore persists isOpen to, since the enforced layer architecture forbids platform/ from importing workbench/. Additive property on two existing events; no breaking changes. Manual backport of #18401 (f2fdbe3) after the automated backport hit cherry-pick conflicts. Conflicts resolved in: - src/platform/telemetry/providers/cloud/PostHogTelemetryProvider.ts - src/platform/telemetry/providers/cloud/PostHogTelemetryProvider.test.ts
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1958 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-25T23:14:40.076Z",
"gitSha": "5d77eaebc19b9483f87f74e484b26971b8965a37",
"branch": "backport-18401-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.1289999999972,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.026000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 290.715,
"heapDeltaBytes": 6560360,
"heapUsedBytes": 76726532,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.257999999999998,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2015.38800000003,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.965000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 273.471,
"heapDeltaBytes": -13057624,
"heapUsedBytes": 56621756,
"domNodes": 1,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 4.9510000000000005,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.812999999997,
"styleRecalcs": 72,
"styleRecalcDurationMs": 21.281000000000002,
"layouts": 14,
"layoutDurationMs": 3.727,
"taskDurationMs": 577.981,
"heapDeltaBytes": -2992904,
"heapUsedBytes": 67974728,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 97.851,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1705.769000000032,
"styleRecalcs": 75,
"styleRecalcDurationMs": 20.53,
"layouts": 14,
"layoutDurationMs": 3.5969999999999995,
"taskDurationMs": 510.7020000000001,
"heapDeltaBytes": 4183468,
"heapUsedBytes": 74013576,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 87.60799999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.7540000000117,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.386,
"layouts": 6,
"layoutDurationMs": 0.911,
"taskDurationMs": 209.48099999999997,
"heapDeltaBytes": 4509260,
"heapUsedBytes": 74702332,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6.949000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1660.8359999999607,
"styleRecalcs": 29,
"styleRecalcDurationMs": 9.729,
"layouts": 6,
"layoutDurationMs": 0.874,
"taskDurationMs": 205.754,
"heapDeltaBytes": 4635568,
"heapUsedBytes": 75822212,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 6.606000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 521.3300000000061,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.882,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 313.108,
"heapDeltaBytes": -7517420,
"heapUsedBytes": 63396400,
"domNodes": 22,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 109.14699999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 399.84800000001997,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.115999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 270.124,
"heapDeltaBytes": -8203128,
"heapUsedBytes": 62995696,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 93.99,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2009.4470000000229,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.231000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.989,
"heapDeltaBytes": 6377976,
"heapUsedBytes": 82703604,
"domNodes": -268,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 19.012999999999995,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2009.5400000000154,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.325000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.3739999999999,
"heapDeltaBytes": 4763736,
"heapUsedBytes": 81030688,
"domNodes": -278,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 20.941999999999997,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2091.575999999975,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.819,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 985.4749999999999,
"heapDeltaBytes": 19997940,
"heapUsedBytes": 85981488,
"domNodes": -266,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 501.09899999999993,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2146.464999999978,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.049999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1078.1109999999999,
"heapDeltaBytes": -8455668,
"heapUsedBytes": 68451184,
"domNodes": -269,
"jsHeapTotalBytes": 1470464,
"scriptDurationMs": 542.158,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3076.2730000000147,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.067000000000002,
"layouts": 60,
"layoutDurationMs": 12.398,
"taskDurationMs": 1071.9440000000002,
"heapDeltaBytes": -2538540,
"heapUsedBytes": 76193356,
"domNodes": -272,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 470.332,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3064.1160000000127,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.897,
"layouts": 60,
"layoutDurationMs": 12.211,
"taskDurationMs": 1053.369,
"heapDeltaBytes": 9792976,
"heapUsedBytes": 76978940,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 485.096,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2280.175999999983,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.608999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1252.287,
"heapDeltaBytes": 18365596,
"heapUsedBytes": 86480264,
"domNodes": 8,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 647.777,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2138.0189999999857,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.03,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1150.6180000000002,
"heapDeltaBytes": 16518492,
"heapUsedBytes": 84276324,
"domNodes": 10,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 576.827,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.56499999999,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.928,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 306.22299999999996,
"heapDeltaBytes": 21580212,
"heapUsedBytes": 88356164,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.119000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.096999999978,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.622000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.85200000000003,
"heapDeltaBytes": -23676496,
"heapUsedBytes": 70532872,
"domNodes": -283,
"jsHeapTotalBytes": 3219456,
"scriptDurationMs": 20.347000000000005,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 427.8850000000034,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.049000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 267.31899999999996,
"heapDeltaBytes": 14698408,
"heapUsedBytes": 86398304,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 91.88499999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 413.8320000000135,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.264999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 244.381,
"heapDeltaBytes": 14874860,
"heapUsedBytes": 88211704,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 85.66299999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.4289999999971,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.612999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.428,
"heapDeltaBytes": 9032928,
"heapUsedBytes": 81973988,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 5.257,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1992.85500000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.869999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.22100000000006,
"heapDeltaBytes": -8094420,
"heapUsedBytes": 64190116,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 4.574,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.842999999997,
"styleRecalcs": 78,
"styleRecalcDurationMs": 21.578999999999997,
"layouts": 18,
"layoutDurationMs": 4.5120000000000005,
"taskDurationMs": 511.88,
"heapDeltaBytes": 8046804,
"heapUsedBytes": 81177020,
"domNodes": -293,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 72.797,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.8989999999935,
"styleRecalcs": 78,
"styleRecalcDurationMs": 20.378999999999998,
"layouts": 18,
"layoutDurationMs": 4.307,
"taskDurationMs": 559.002,
"heapDeltaBytes": 4802740,
"heapUsedBytes": 78181452,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 75.255,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 783.3909999999946,
"styleRecalcs": 21,
"styleRecalcDurationMs": 20.032,
"layouts": 17,
"layoutDurationMs": 10.278999999999998,
"taskDurationMs": 525.287,
"heapDeltaBytes": -7296404,
"heapUsedBytes": 86977968,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 16.439000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 57,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8194.664000000046,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.195,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3662.4550000000004,
"heapDeltaBytes": 6224840,
"heapUsedBytes": 82204840,
"domNodes": -236,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 1803.6180000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8150.888000000009,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.695,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3428.8379999999997,
"heapDeltaBytes": 5399292,
"heapUsedBytes": 81540704,
"domNodes": -266,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 1674.271,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10718.064000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9831.865,
"heapDeltaBytes": -42261168,
"heapUsedBytes": 176816380,
"domNodes": -8068,
"jsHeapTotalBytes": -14663680,
"scriptDurationMs": 157.464,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10461.468000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9415.92,
"heapDeltaBytes": -55767420,
"heapUsedBytes": 176479152,
"domNodes": -8068,
"jsHeapTotalBytes": -15200256,
"scriptDurationMs": 147.69100000000003,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13507.423999999957,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.470000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12978.77,
"heapDeltaBytes": -53617532,
"heapUsedBytes": 165952752,
"domNodes": -8068,
"jsHeapTotalBytes": -15368192,
"scriptDurationMs": 590.9,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 13916.357000000005,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.020000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13199.690999999999,
"heapDeltaBytes": -55125592,
"heapUsedBytes": 184723924,
"domNodes": -8068,
"jsHeapTotalBytes": -24059904,
"scriptDurationMs": 617.474,
"eventListeners": -14931,
"totalBlockingTimeMs": 26,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3939.164000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.42100000000002,
"layouts": 20,
"layoutDurationMs": 18.360000000000003,
"taskDurationMs": 3837.7799999999997,
"heapDeltaBytes": -58984388,
"heapUsedBytes": 179978632,
"domNodes": -8068,
"jsHeapTotalBytes": 10350592,
"scriptDurationMs": 60.681,
"eventListeners": -14933,
"totalBlockingTimeMs": 73,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 3920.1889999999935,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.11300000000002,
"layouts": 20,
"layoutDurationMs": 18.107,
"taskDurationMs": 3787.3230000000003,
"heapDeltaBytes": -41548792,
"heapUsedBytes": 183476196,
"domNodes": -8068,
"jsHeapTotalBytes": 8445952,
"scriptDurationMs": 60.65599999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 71,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5219.299999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4693.763000000001,
"heapDeltaBytes": -2886128,
"heapUsedBytes": 177200208,
"domNodes": 0,
"jsHeapTotalBytes": -44040192,
"scriptDurationMs": 92.38099999999999,
"eventListeners": 14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5445.806999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5147.733,
"heapDeltaBytes": -647672,
"heapUsedBytes": 184731236,
"domNodes": 0,
"jsHeapTotalBytes": -18087936,
"scriptDurationMs": 67.46799999999998,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 67.34299999999394,
"styleRecalcs": 5,
"styleRecalcDurationMs": 10.086,
"layouts": 2,
"layoutDurationMs": 0.93,
"taskDurationMs": 43.21799999999999,
"heapDeltaBytes": 3009288,
"heapUsedBytes": 72380816,
"domNodes": 125,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 2.8269999999999995,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 59.91600000004382,
"styleRecalcs": 5,
"styleRecalcDurationMs": 8.496,
"layouts": 2,
"layoutDurationMs": 0.6859999999999999,
"taskDurationMs": 43.23600000000001,
"heapDeltaBytes": 3026712,
"heapUsedBytes": 71828516,
"domNodes": 103,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.0139999999999993,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18923 +/- ##
=============================================
Coverage ? 83.83%
=============================================
Files ? 2115
Lines ? 125701
Branches ? 34032
=============================================
Hits ? 105379
Misses ? 20144
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified rather than rubber-stamped: the changed-file list matches the original PR exactly, the diff carries no conflict markers, and no required check is red.
Required checks on this branch are lint-and-format, test and e2e-status; anything else red here is advisory and does not gate the merge.
Manual backport of #18401 to
cloud/1.54.Original squash commit:
f2fdbe3762c1dcd2f2079de929790d32dbf9d0c3The automated
pr-backport.yamlbot attempted this and failed with cherry-pick conflicts, then deleted its branch. This PR redoes it by hand. Authorship of the original commit is preserved.Conflicts and how they were resolved
Both conflicts were in the same two files. In each case the incoming side carried
main's full file state, which includes changes from other PRs that were never backported tocloud/1.54. Each hunk was therefore re-applied againstgit show f2fdbe3762c1dcd2f2079de929790d32dbf9d0c3 -- <path>— the PR's own diff — rather than unioning the conflict markers.src/platform/telemetry/providers/cloud/PostHogTelemetryProvider.tsImport-ordering conflict only.
mainsortswhenStoresReadybeforeimport type { RemoteConfig };cloud/1.54sorts them the other way. Kept the release branch's existing order and inserted only this PR's new import (getAgentPanelOpen) ahead ofgetExecutionContext. The other three hunks (thelastAgentPanelOpenfield, the assignment intrackRunButton, and theexecution_startpayload plus its reset) applied cleanly.src/platform/telemetry/providers/cloud/PostHogTelemetryProvider.test.tsTwo conflict regions, both resolved by taking the release branch's content and adding only what this PR contributes:
main's list also containsBootstrapCompleteMetadata, which backs a test that exists only onmain. Importing it here would have been an unused import. Added onlyRunButtonProperties; the import goes multi-line because it now exceeds the 80-column width.mainautomocksuseBillingContextviavi.mock(import('@/composables/billing/useBillingContext'));cloud/1.54uses a factory mock that wires uphoisted.refs.tier. This PR does not touch that mock, so the release branch's factory version was kept verbatim and the newgetAgentPanelOpenmock inserted above it, matching the PR's placement.Nothing from an unbackported PR was pulled in as a result.
Verification
File set is identical to the original — this prints nothing:
The +3 is entirely the type-import reformat described above: on
mainthat import was already multi-line, so the PR added 2 lines there; oncloud/1.54it was a single line that had to be expanded to five. Per-file comparison of the added/removed line sets is byte-identical to the original for 11 of 12 files, with that import block the only difference.Checks
pnpm typecheck— clean, exit 0pnpm exec vitest runover the telemetry and agent trees — 163 files, 2607 passed, 7 expected-fail, exit 0. Re-run limited to the 7 test files this PR touches: 179 passed, exit 0, includingcarries the run button panel state onto execution start,reads the agent panel state for a run the button did not start, all fourgetAgentPanelOpencases, and thepersists isOpen where the run-attribution flag reads itkey-drift guard.pnpm exec eslinton the 12 changed files — 0 errors, 0 warningspnpm exec oxfmt --checkon the 12 changed files — all correctly formattedVercel – billing-web-testis red pre-existing across this repo, including on already-merged PRs. It is not related to this diff.Merge order
Full queue across the backports currently open:
Batch 1 is still unmerged and touches the same telemetry regions, so this PR will likely need a rebase once batch 1 lands. It has deliberately not been pre-emptively rebased onto anything other than current
origin/cloud/1.54.#18413 stacks on this PR and must merge after it. #18413 (
fix: read agent_panel_open fresh; drop client-side agent thread attribution (PM-1472)) modifiesgetAgentPanelOpen.ts, the file this PR creates, so it cannot be backported until this lands. A throwaway probe cherry-picking #18413 on top of this branch applied cleanly — no conflicts, 3 files, +35/−34, byte-identical to the original.