Skip to content

[backport cloud/1.54] feat: attribute agent paywall purchases through checkout telemetry (#18390) - #18922

Merged
huntcsg merged 1 commit into
cloud/1.54from
backport-18390-to-cloud-1.54
Sep 26, 2026
Merged

huntcsg merged 1 commit into
cloud/1.54from
backport-18390-to-cloud-1.54

Conversation

@huntcsg

@huntcsg huntcsg commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Manual backport of #18390 to cloud/1.54.

Original merge commit: 17af6397a1050edd0be6ee9cea573e4348b77d18 — "feat: attribute agent paywall purchases through checkout telemetry (#18390)".

The automated pr-backport.yaml bot could not cherry-pick this cleanly and deleted its branch, so this was redone by hand.

Conflicts and how they were resolved

Every conflict was resolved per file against the original commit's own diff (git show 17af6397a1 -- <path>), not by unioning the markers. The incoming side of each marker carried main's full file state, which includes changes from PRs not backported to cloud/1.54; those were deliberately left out.

File Resolution
src/platform/telemetry/TelemetryRegistry.ts Import list: added only AgentPaywallCtaMetadata / AgentPaywallShownMetadata. Dropped AgentConsentResolvedMetadata / AgentConsentShownMetadata (not on this branch).
src/platform/telemetry/providers/host/HostTelemetrySink.ts Same: added only the two paywall metadata imports, dropped the ~10 unrelated agent-metadata imports from main.
src/platform/workspace/components/SubscriptionRequiredDialogContentUnified.test.ts Applied the PR's own change (hoisted mockUseSubscriptionCheckout, factory wrapped to record args) inside this branch's vi.mock(<string>, …) form rather than importing main's typed vi.mock<unknown>(import(…)) form.
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts Applied the renderDialog(props) signature change; dropped the mockBillingContext() context line, which does not exist on this branch. New tests assert through this branch's mockTrackCheckoutJourneyEvent handle instead of main's automocked useTelemetry().
src/platform/workspace/composables/useSubscriptionCheckout.test.ts Applied the journeyEvents() / journeyPhases() split, reading from this branch's mockTrackCheckoutJourneyEvent.
src/workbench/extensions/agent/AgentPanelRoot.test.ts The PR's only change here was a 3-line comment edit on an expectWithheldPurchaseActions() helper that does not exist on this branch (this branch still has the inline it.for([...]) form), so that hunk has no counterpart and was dropped. All substantive hunks applied.
src/workbench/extensions/agent/stores/agent/agentConversationStore.ts Added reportedPaywallImpressions and claimPaywallImpression; kept this branch's exported resolvePaywalls rather than main's renamed setPaywallsResolved.

Non-conflicting adaptations

main has test-mock infrastructure this branch lacks (src/composables/billing/__mocks__/, automocked useDialogService / useBillingRouting / useBillingCapabilities). The PR's new tests were rewritten onto this branch's explicit mock handles so they compile and run; assertions are unchanged:

  • useAccountPreconditionDialog.test.ts — useDialogService() → mockDialogService
  • useSubscriptionDialog.test.ts — routing helper sets mockShouldUseWorkspaceBilling / mockShouldUseUnifiedPricing (this branch's routing mock has no type)
  • dialogService.topUpCredits.test.ts — capability setters use the hoisted state; showDialog read directly
  • SubscriptionRequiredDialogContent.test.ts — explicit useBillingContext factory instead of the bare automock
  • AgentPanelRoot.test.ts — three vi.fn() entries added to the existing hoisted telemetry mock; assertions use telemetry.*

Verification

File set is identical to the original commit's:

$ diff <(git show --name-only --format="" 17af6397a1 | sort -u) \
       <(git diff --name-only origin/cloud/1.54...backport-18390-to-cloud-1.54 | sort -u)
(no output)
files insertions deletions
original #18390 31 1347 121
this backport 31 1341 120

The small deltas are from the adaptations above (shorter mock-handle expressions, the dropped comment-only hunk, the added vi.fn() entries).

Checks

  • pnpm typecheck — pass, exit 0, no errors
  • pnpm exec vitest run over src/platform/telemetry, src/platform/workspace, src/platform/cloud/subscription, src/services/dialogService*.test.ts, src/workbench/extensions/agent — 253/253 files, 4496 passed, 7 expected-fail, 0 failed
  • pnpm exec eslint on the 31 changed files — pass, exit 0
  • pnpm exec oxfmt --check on the 31 changed files — pass

Vercel – billing-web-test is red pre-existing across this repo, including on already-merged PRs. Not from this diff.

Merge order

Seven backports are queued against cloud/1.54 and touch overlapping telemetry files:

Batch 1 is unmerged and touches the same regions (the telemetry import lists and the agent conversation store in particular), so this PR will likely need a rebase once batch 1 lands. It is currently based on origin/cloud/1.54 as of the time of writing and has not been pre-emptively rebased onto anything else.

@huntcsg huntcsg added the backport Backporting a PR onto a release candidate label Sep 25, 2026
@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 25, 2026 11:39pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 25, 2026 11:39pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 226ca370-72aa-49a7-9011-86e3ade17abd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/25/2026, 11:40:38 PM UTC

Links

🎭 Playwright: ✅ 1956 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1935 / ❌ 0 / ⚠️ 2 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 79ms TBT · 101.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.9 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.5 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 52ms TBT · 159.3 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 366ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.2 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -178
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 25ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 644ms
canvas-mouse-sweep: script duration 110ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 72.7 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -177
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 13ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 225ms
canvas-zoom-sweep: script duration 9ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.1 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 300ms
dom-widget-clipping: script duration 100ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 61.6 MB
dom-widget-clipping: DOM nodes 22
dom-widget-clipping: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 426ms
large-graph-idle: script duration 29ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.7 MB
large-graph-idle: DOM nodes -271
large-graph-idle: event listeners -191
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 16ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1148ms
large-graph-pan: script duration 538ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 73.3 MB
large-graph-pan: DOM nodes -272
large-graph-pan: event listeners -191
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1143ms
large-graph-zoom: script duration 506ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.0 MB
large-graph-zoom: DOM nodes 2
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 1349ms
legacy-node-drag: script duration 659ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 82.7 MB
legacy-node-drag: DOM nodes 5
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 374ms
minimap-idle: script duration 27ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.7 MB
minimap-idle: DOM nodes -271
minimap-idle: event listeners -79
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 273ms
subgraph-dom-widget-clipping: script duration 89ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.5 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 317ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.8 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -224
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 27ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 599ms
subgraph-mouse-sweep: script duration 90ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 66.3 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -238
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 24ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 674ms
subgraph-transition-enter: script duration 24ms
subgraph-transition-enter: TBT 79ms
subgraph-transition-enter: heap used 101.1 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 42ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 3989ms
viewport-pan-sweep: script duration 1841ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.8 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -160
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11916ms
vue-large-graph-idle: script duration 182ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.9 MB
vue-large-graph-idle: DOM nodes -8069
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 71
vue-large-graph-pan: task duration 14537ms
vue-large-graph-pan: script duration 658ms
vue-large-graph-pan: TBT 0ms
vue-large-graph-pan: heap used 167.5 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14931
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 54ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4501ms
vue-node-resize-workload: script duration 80ms
vue-node-resize-workload: TBT 52ms
vue-node-resize-workload: heap used 159.3 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14931
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6119ms
vue-zoom-out-idle: script duration 89ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 171.6 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -8
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 2
workflow-execution: style recalc count 6
workflow-execution: task duration 54ms
workflow-execution: script duration 4ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.9 MB
workflow-execution: DOM nodes 115
workflow-execution: event listeners 26
Raw data
{
  "timestamp": "2026-09-25T23:48:20.106Z",
  "gitSha": "5ea89fabb3122387392a92eaf9c2570f39042047",
  "branch": "backport-18390-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2010.05600000002,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.2780000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 335.09299999999996,
      "heapDeltaBytes": 7230508,
      "heapUsedBytes": 77866808,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.299,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2007.7009999999973,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.533999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 396.29600000000005,
      "heapDeltaBytes": -8105176,
      "heapUsedBytes": 63129740,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 10.037,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1783.7000000000103,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 25.663999999999998,
      "layouts": 14,
      "layoutDurationMs": 4.2,
      "taskDurationMs": 689.006,
      "heapDeltaBytes": 10000264,
      "heapUsedBytes": 79592300,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 117.54199999999999,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1707.478999999978,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 24.101999999999997,
      "layouts": 14,
      "layoutDurationMs": 3.8019999999999996,
      "taskDurationMs": 599.615,
      "heapDeltaBytes": 3244492,
      "heapUsedBytes": 72889384,
      "domNodes": -279,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 102.351,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.7689999999611,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 12.918000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.1500000000000001,
      "taskDurationMs": 223.133,
      "heapDeltaBytes": 4681276,
      "heapUsedBytes": 76071688,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.157,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1669.6410000000128,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 13.203999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.9359999999999999,
      "taskDurationMs": 226.232,
      "heapDeltaBytes": 4257816,
      "heapUsedBytes": 75201564,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.411999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 428.0499999999847,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 8.721,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 288.804,
      "heapDeltaBytes": -7802592,
      "heapUsedBytes": 63094304,
      "domNodes": 24,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 96.38100000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.65999999999999,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 497.09400000000414,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.1160000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 310.713,
      "heapDeltaBytes": -6507412,
      "heapUsedBytes": 66129248,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 103.614,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2008.5819999999899,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.239000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 404.15000000000003,
      "heapDeltaBytes": 4866124,
      "heapUsedBytes": 81150344,
      "domNodes": -270,
      "jsHeapTotalBytes": -626688,
      "scriptDurationMs": 25.294999999999998,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.9400000000055,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.5440000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 447.1700000000001,
      "heapDeltaBytes": 9191688,
      "heapUsedBytes": 85914740,
      "domNodes": -272,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 32.74,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2413.3840000000077,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 15.593999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1164.0059999999999,
      "heapDeltaBytes": 8004144,
      "heapUsedBytes": 85263552,
      "domNodes": -266,
      "jsHeapTotalBytes": -139264,
      "scriptDurationMs": 533.233,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2168.655000000001,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 15.56,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1131.03,
      "heapDeltaBytes": -9110064,
      "heapUsedBytes": 68483432,
      "domNodes": -278,
      "jsHeapTotalBytes": -888832,
      "scriptDurationMs": 542.967,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3249.8729999999796,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 13.252,
      "layouts": 60,
      "layoutDurationMs": 13.426,
      "taskDurationMs": 1161.566,
      "heapDeltaBytes": 8818636,
      "heapUsedBytes": 76901932,
      "domNodes": 6,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 515.4730000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3076.724000000013,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 12.378,
      "layouts": 60,
      "layoutDurationMs": 13.103,
      "taskDurationMs": 1123.55,
      "heapDeltaBytes": 9519956,
      "heapUsedBytes": 76112456,
      "domNodes": -3,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 496.208,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2329.88499999999,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 7.800999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1311.92,
      "heapDeltaBytes": 16796096,
      "heapUsedBytes": 84502824,
      "domNodes": 6,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 641.5699999999999,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2372.507999999982,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.98,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1385.577,
      "heapDeltaBytes": 20623356,
      "heapUsedBytes": 88873100,
      "domNodes": 4,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 676.941,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.8720000000212,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.875999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 388.59299999999996,
      "heapDeltaBytes": 10375960,
      "heapUsedBytes": 87676844,
      "domNodes": -270,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 26.14400000000001,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2007.2850000000244,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.6300000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 359.70799999999997,
      "heapDeltaBytes": 21765676,
      "heapUsedBytes": 87812004,
      "domNodes": -272,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 28.808,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 409.79200000003857,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 9.596,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 263.81100000000004,
      "heapDeltaBytes": 14748624,
      "heapUsedBytes": 88362000,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 88.686,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 413.9329999999859,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.837,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 281.415,
      "heapDeltaBytes": 13960236,
      "heapUsedBytes": 86679492,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 88.923,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2025.1340000000368,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 11.028,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 279.39799999999997,
      "heapDeltaBytes": -9360716,
      "heapUsedBytes": 64220748,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 7.282000000000002,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1992.4040000000218,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.067999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 355.18,
      "heapDeltaBytes": -2904760,
      "heapUsedBytes": 69679004,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.546000000000001,
      "eventListeners": -208,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1714.0019999999936,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 25.124,
      "layouts": 18,
      "layoutDurationMs": 4.827999999999999,
      "taskDurationMs": 599.823,
      "heapDeltaBytes": -6256040,
      "heapUsedBytes": 66038896,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 85.2,
      "eventListeners": -238,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.6129999999807,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 28.019,
      "layouts": 18,
      "layoutDurationMs": 5.528,
      "taskDurationMs": 597.491,
      "heapDeltaBytes": -282372,
      "heapUsedBytes": 72984944,
      "domNodes": -294,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 95.311,
      "eventListeners": -238,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 901.4460000000213,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 24.468000000000004,
      "layouts": 17,
      "layoutDurationMs": 11.822,
      "taskDurationMs": 674.4760000000001,
      "heapDeltaBytes": 21820732,
      "heapUsedBytes": 106038540,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 24.090000000000007,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 79,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9238.243000000011,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 44.13499999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4156.887000000001,
      "heapDeltaBytes": 2819688,
      "heapUsedBytes": 82556324,
      "domNodes": -269,
      "jsHeapTotalBytes": 647168,
      "scriptDurationMs": 1881.927,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8226.587999999992,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 40.778,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3820.534,
      "heapDeltaBytes": 14989764,
      "heapUsedBytes": 90995964,
      "domNodes": -269,
      "jsHeapTotalBytes": 909312,
      "scriptDurationMs": 1800.8339999999998,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12653.280999999992,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12054.644,
      "heapDeltaBytes": -34408332,
      "heapUsedBytes": 179094024,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12595200,
      "scriptDurationMs": 181.34300000000002,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12559.827000000041,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11777.307,
      "heapDeltaBytes": -57278620,
      "heapUsedBytes": 181370240,
      "domNodes": -8069,
      "jsHeapTotalBytes": -20885504,
      "scriptDurationMs": 182.28400000000002,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14727.663000000008,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.250000000000012,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14354.980999999998,
      "heapDeltaBytes": -49910204,
      "heapUsedBytes": 169946096,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13905920,
      "scriptDurationMs": 637.8040000000001,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15190.094000000045,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 16.593999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14718.735999999999,
      "heapDeltaBytes": -28388316,
      "heapUsedBytes": 181306916,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16592896,
      "scriptDurationMs": 677.515,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4552.90100000002,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 54.541000000000004,
      "layouts": 20,
      "layoutDurationMs": 22.189,
      "taskDurationMs": 4444.126,
      "heapDeltaBytes": -53395028,
      "heapUsedBytes": 166325100,
      "domNodes": -8068,
      "jsHeapTotalBytes": 11784192,
      "scriptDurationMs": 77.97500000000001,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 30,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4624.501000000009,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 53.48,
      "layouts": 20,
      "layoutDurationMs": 24.506999999999987,
      "taskDurationMs": 4558.492,
      "heapDeltaBytes": -52289440,
      "heapUsedBytes": 167810552,
      "domNodes": -8068,
      "jsHeapTotalBytes": 14884864,
      "scriptDurationMs": 82.26100000000001,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 73,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6295.5160000000205,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6003.086000000001,
      "heapDeltaBytes": 3559540,
      "heapUsedBytes": 180505048,
      "domNodes": 0,
      "jsHeapTotalBytes": -23068672,
      "scriptDurationMs": 86.55900000000005,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6381.795000000011,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6234.741,
      "heapDeltaBytes": 2946504,
      "heapUsedBytes": 179333424,
      "domNodes": 0,
      "jsHeapTotalBytes": -20185088,
      "scriptDurationMs": 91.85900000000002,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 77.54600000004075,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 11.532,
      "layouts": 2,
      "layoutDurationMs": 0.604,
      "taskDurationMs": 49.870999999999995,
      "heapDeltaBytes": 3098184,
      "heapUsedBytes": 72454848,
      "domNodes": 107,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 4.224,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 85.76200000004519,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 14.226,
      "layouts": 2,
      "layoutDurationMs": 1.027,
      "taskDurationMs": 59.019000000000005,
      "heapDeltaBytes": 2965672,
      "heapUsedBytes": 72109136,
      "domNodes": 123,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.2509999999999994,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50607 75801 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 25, 2026
@github-actions
github-actions Bot requested a review from huang47 September 25, 2026 22:59

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified rather than rubber-stamped: the changed-file list matches the original PR exactly, the diff carries no conflict markers, and no required check is red.

Required checks on this branch are lint-and-format, test and e2e-status; anything else red here is advisory and does not gate the merge.

@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.55556% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/workspace/utils/checkoutJourney.ts 86.36% 3 Missing ⚠️
src/services/dialogService.ts 91.66% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18922   +/-   ##
=============================================
  Coverage              ?   83.89%           
=============================================
  Files                 ?     2115           
  Lines                 ?   125864           
  Branches              ?    34057           
=============================================
  Hits                  ?   105596           
  Misses                ?    20091           
  Partials              ?      177           
Flag Coverage Δ
e2e 66.77% <26.08%> (?)
unit 78.97% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...n/components/SubscriptionRequiredDialogContent.vue 74.57% <ø> (ø)
...iption/composables/useAccountPreconditionDialog.ts 100.00% <100.00%> (ø)
.../subscription/composables/useSubscriptionDialog.ts 92.23% <100.00%> (ø)
.../subscription/utils/subscriptionCheckoutTracker.ts 89.38% <ø> (ø)
src/platform/telemetry/TelemetryRegistry.ts 42.69% <100.00%> (ø)
...emetry/providers/cloud/PostHogTelemetryProvider.ts 70.90% <100.00%> (ø)
...form/telemetry/providers/host/HostTelemetrySink.ts 45.80% <100.00%> (ø)
src/platform/telemetry/types.ts 92.59% <ø> (ø)
...nents/SubscriptionRequiredDialogContentUnified.vue 60.55% <100.00%> (ø)
...nts/SubscriptionRequiredDialogContentWorkspace.vue 100.00% <100.00%> (ø)
... and 7 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

… checkout telemetry (#18390)

Backport of #18390 (17af639) to cloud/1.54.

Adds an `agent_paywall` source across the checkout flow so agent-driven
purchases can be attributed, and instruments the agent paywall card itself.

Conflicts were resolved per file against the original commit's own diff,
adapting hunks whose context comes from changes not present on cloud/1.54.
@huntcsg
huntcsg force-pushed the backport-18390-to-cloud-1.54 branch from f4663a5 to cf581d1 Compare September 25, 2026 23:38
@DrJKL DrJKL added the agent Comfy Agent product, integration, tests or product documentation label Sep 25, 2026
@huntcsg
huntcsg enabled auto-merge (squash) September 25, 2026 23:55
@huntcsg
huntcsg merged commit d4640a8 into cloud/1.54 Sep 26, 2026
105 of 106 checks passed
@huntcsg
huntcsg deleted the backport-18390-to-cloud-1.54 branch September 26, 2026 00:01
@huntcsg

huntcsg commented Sep 26, 2026

Copy link
Copy Markdown
Contributor Author

Rebased twice onto a moving cloud/1.54 and re-verified; the PR then auto-merged as d4640a87ec.

Rebase 1 — onto f088965d91, after #18908 (←#18503) and #18904 (←#18664) landed. Two import-list conflicts:

  • TelemetryRegistry.ts — kept the base's AgentConsentResolvedMetadata/AgentConsentShownMetadata and added this PR's AgentPaywallCtaMetadata/AgentPaywallShownMetadata.
  • HostTelemetrySink.ts — kept the base's AgentOnboardingStepMetadata, added the same two.

Rebase 2 — onto 3c1223e096, after #18907 (←#18376) landed mid-run. One more conflict in the same import block of HostTelemetrySink.ts: kept the base's AgentPanelClosedMetadata/AgentPanelOpenedMetadata/AgentWorkflowAppliedMetadata and placed the two paywall imports in their alphabetical slot between them.

All three were additive. This PR's contribution to both files stayed pure insertions — nothing from the batch-1 backports was dropped, and nothing from them was absorbed into this diff.

Re-verified after each rebase: file set still identical to the original commit (diff of the two --name-only lists is empty), 31 files, +1341/−120 against the original's +1347/−121. The merged squash commit carries the same 31-file set.

Checks: pnpm typecheck exit 0; eslint + oxfmt --check clean on all 31 files; this PR's own 14 test files 795/795 pass; broader sweep over the telemetry / workspace / cloud-subscription / dialogService / agent trees 4556 passed, 7 expected-fail. The required lint-and-format, test and e2e-status all passed on the final SHA.

Two red checks, neither from this diff:

  1. Vercel – billing-web-test — the known pre-existing failure across this repo, including on already-merged PRs.

  2. create-tag failed post-merge and cloud/v1.54.15 was never pushed — worth someone's attention, since tags exist through cloud/v1.54.14. The tag push was rejected by GitHub with:

    ! [remote rejected] cloud/v1.54.15 -> cloud/v1.54.15
      (Unable to determine if workflow can be created or updated due to timeout;
       `workflows` scope may be required.)
    

    This merge touches 31 files, all under src/ — nothing in .github/, so the workflows scope should not have been needed. The "unable to determine ... due to timeout" wording points at a transient GitHub-side evaluation failure rather than a real permission gap, so re-running the Cloud Backport Tag job is likely all that is needed. I have deliberately not re-run it or pushed the tag by hand.

Remaining in the queue against this base: the #18413 backport.

@DrJKL DrJKL added agent-backport Agent changes targeting a stable cloud/core release branch agent-billing Agent admission limits, credits, subscriptions or paywalls agent-session Agent sessions, history, turn lifecycle or workflow binding agent-telemetry Agent analytics, diagnostics, error reporting or observability agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 27, 2026

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — cf581d17 Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-billing Agent admission limits, credits, subscriptions or paywalls agent-session Agent sessions, history, turn lifecycle or workflow binding agent-telemetry Agent analytics, diagnostics, error reporting or observability agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants