Repository navigation
[backport cloud/1.54] feat: attribute agent paywall purchases through checkout telemetry (#18390) - #18922
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1956 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-25T23:48:20.106Z",
"gitSha": "5ea89fabb3122387392a92eaf9c2570f39042047",
"branch": "backport-18390-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.05600000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.2780000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.09299999999996,
"heapDeltaBytes": 7230508,
"heapUsedBytes": 77866808,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.299,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.7009999999973,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.533999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.29600000000005,
"heapDeltaBytes": -8105176,
"heapUsedBytes": 63129740,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.037,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1783.7000000000103,
"styleRecalcs": 74,
"styleRecalcDurationMs": 25.663999999999998,
"layouts": 14,
"layoutDurationMs": 4.2,
"taskDurationMs": 689.006,
"heapDeltaBytes": 10000264,
"heapUsedBytes": 79592300,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 117.54199999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1707.478999999978,
"styleRecalcs": 74,
"styleRecalcDurationMs": 24.101999999999997,
"layouts": 14,
"layoutDurationMs": 3.8019999999999996,
"taskDurationMs": 599.615,
"heapDeltaBytes": 3244492,
"heapUsedBytes": 72889384,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 102.351,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.7689999999611,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.918000000000001,
"layouts": 6,
"layoutDurationMs": 1.1500000000000001,
"taskDurationMs": 223.133,
"heapDeltaBytes": 4681276,
"heapUsedBytes": 76071688,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.157,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.6410000000128,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.203999999999999,
"layouts": 6,
"layoutDurationMs": 0.9359999999999999,
"taskDurationMs": 226.232,
"heapDeltaBytes": 4257816,
"heapUsedBytes": 75201564,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.411999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 428.0499999999847,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.721,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 288.804,
"heapDeltaBytes": -7802592,
"heapUsedBytes": 63094304,
"domNodes": 24,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 96.38100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65999999999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 497.09400000000414,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.1160000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 310.713,
"heapDeltaBytes": -6507412,
"heapUsedBytes": 66129248,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 103.614,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2008.5819999999899,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.239000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.15000000000003,
"heapDeltaBytes": 4866124,
"heapUsedBytes": 81150344,
"domNodes": -270,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 25.294999999999998,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2022.9400000000055,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.5440000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.1700000000001,
"heapDeltaBytes": 9191688,
"heapUsedBytes": 85914740,
"domNodes": -272,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 32.74,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2413.3840000000077,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.593999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1164.0059999999999,
"heapDeltaBytes": 8004144,
"heapUsedBytes": 85263552,
"domNodes": -266,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 533.233,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2168.655000000001,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.56,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1131.03,
"heapDeltaBytes": -9110064,
"heapUsedBytes": 68483432,
"domNodes": -278,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 542.967,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3249.8729999999796,
"styleRecalcs": 62,
"styleRecalcDurationMs": 13.252,
"layouts": 60,
"layoutDurationMs": 13.426,
"taskDurationMs": 1161.566,
"heapDeltaBytes": 8818636,
"heapUsedBytes": 76901932,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 515.4730000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3076.724000000013,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.378,
"layouts": 60,
"layoutDurationMs": 13.103,
"taskDurationMs": 1123.55,
"heapDeltaBytes": 9519956,
"heapUsedBytes": 76112456,
"domNodes": -3,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 496.208,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2329.88499999999,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.800999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1311.92,
"heapDeltaBytes": 16796096,
"heapUsedBytes": 84502824,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 641.5699999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2372.507999999982,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.98,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1385.577,
"heapDeltaBytes": 20623356,
"heapUsedBytes": 88873100,
"domNodes": 4,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 676.941,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2031.8720000000212,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.875999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.59299999999996,
"heapDeltaBytes": 10375960,
"heapUsedBytes": 87676844,
"domNodes": -270,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 26.14400000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2007.2850000000244,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.6300000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.70799999999997,
"heapDeltaBytes": 21765676,
"heapUsedBytes": 87812004,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.808,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 409.79200000003857,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.596,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 263.81100000000004,
"heapDeltaBytes": 14748624,
"heapUsedBytes": 88362000,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 88.686,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 413.9329999999859,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.837,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 281.415,
"heapDeltaBytes": 13960236,
"heapUsedBytes": 86679492,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 88.923,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2025.1340000000368,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 279.39799999999997,
"heapDeltaBytes": -9360716,
"heapUsedBytes": 64220748,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.282000000000002,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1992.4040000000218,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.067999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.18,
"heapDeltaBytes": -2904760,
"heapUsedBytes": 69679004,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.546000000000001,
"eventListeners": -208,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1714.0019999999936,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.124,
"layouts": 18,
"layoutDurationMs": 4.827999999999999,
"taskDurationMs": 599.823,
"heapDeltaBytes": -6256040,
"heapUsedBytes": 66038896,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 85.2,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.6129999999807,
"styleRecalcs": 80,
"styleRecalcDurationMs": 28.019,
"layouts": 18,
"layoutDurationMs": 5.528,
"taskDurationMs": 597.491,
"heapDeltaBytes": -282372,
"heapUsedBytes": 72984944,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 95.311,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 901.4460000000213,
"styleRecalcs": 21,
"styleRecalcDurationMs": 24.468000000000004,
"layouts": 17,
"layoutDurationMs": 11.822,
"taskDurationMs": 674.4760000000001,
"heapDeltaBytes": 21820732,
"heapUsedBytes": 106038540,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 24.090000000000007,
"eventListeners": 2385,
"totalBlockingTimeMs": 79,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9238.243000000011,
"styleRecalcs": 251,
"styleRecalcDurationMs": 44.13499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4156.887000000001,
"heapDeltaBytes": 2819688,
"heapUsedBytes": 82556324,
"domNodes": -269,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 1881.927,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8226.587999999992,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.778,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3820.534,
"heapDeltaBytes": 14989764,
"heapUsedBytes": 90995964,
"domNodes": -269,
"jsHeapTotalBytes": 909312,
"scriptDurationMs": 1800.8339999999998,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12653.280999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12054.644,
"heapDeltaBytes": -34408332,
"heapUsedBytes": 179094024,
"domNodes": -8068,
"jsHeapTotalBytes": -12595200,
"scriptDurationMs": 181.34300000000002,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12559.827000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11777.307,
"heapDeltaBytes": -57278620,
"heapUsedBytes": 181370240,
"domNodes": -8069,
"jsHeapTotalBytes": -20885504,
"scriptDurationMs": 182.28400000000002,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14727.663000000008,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.250000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14354.980999999998,
"heapDeltaBytes": -49910204,
"heapUsedBytes": 169946096,
"domNodes": -8068,
"jsHeapTotalBytes": -13905920,
"scriptDurationMs": 637.8040000000001,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15190.094000000045,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.593999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14718.735999999999,
"heapDeltaBytes": -28388316,
"heapUsedBytes": 181306916,
"domNodes": -8068,
"jsHeapTotalBytes": -16592896,
"scriptDurationMs": 677.515,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4552.90100000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.541000000000004,
"layouts": 20,
"layoutDurationMs": 22.189,
"taskDurationMs": 4444.126,
"heapDeltaBytes": -53395028,
"heapUsedBytes": 166325100,
"domNodes": -8068,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 77.97500000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 30,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4624.501000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.48,
"layouts": 20,
"layoutDurationMs": 24.506999999999987,
"taskDurationMs": 4558.492,
"heapDeltaBytes": -52289440,
"heapUsedBytes": 167810552,
"domNodes": -8068,
"jsHeapTotalBytes": 14884864,
"scriptDurationMs": 82.26100000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 73,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6295.5160000000205,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6003.086000000001,
"heapDeltaBytes": 3559540,
"heapUsedBytes": 180505048,
"domNodes": 0,
"jsHeapTotalBytes": -23068672,
"scriptDurationMs": 86.55900000000005,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6381.795000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6234.741,
"heapDeltaBytes": 2946504,
"heapUsedBytes": 179333424,
"domNodes": 0,
"jsHeapTotalBytes": -20185088,
"scriptDurationMs": 91.85900000000002,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 77.54600000004075,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.532,
"layouts": 2,
"layoutDurationMs": 0.604,
"taskDurationMs": 49.870999999999995,
"heapDeltaBytes": 3098184,
"heapUsedBytes": 72454848,
"domNodes": 107,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.224,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 85.76200000004519,
"styleRecalcs": 6,
"styleRecalcDurationMs": 14.226,
"layouts": 2,
"layoutDurationMs": 1.027,
"taskDurationMs": 59.019000000000005,
"heapDeltaBytes": 2965672,
"heapUsedBytes": 72109136,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.2509999999999994,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified rather than rubber-stamped: the changed-file list matches the original PR exactly, the diff carries no conflict markers, and no required check is red.
Required checks on this branch are lint-and-format, test and e2e-status; anything else red here is advisory and does not gate the merge.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #18922 +/- ##
=============================================
Coverage ? 83.89%
=============================================
Files ? 2115
Lines ? 125864
Branches ? 34057
=============================================
Hits ? 105596
Misses ? 20091
Partials ? 177
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
8b1c893 to
f4663a5
Compare
… checkout telemetry (#18390) Backport of #18390 (17af639) to cloud/1.54. Adds an `agent_paywall` source across the checkout flow so agent-driven purchases can be attributed, and instruments the agent paywall card itself. Conflicts were resolved per file against the original commit's own diff, adapting hunks whose context comes from changes not present on cloud/1.54.
f4663a5 to
cf581d1
Compare
|
Rebased twice onto a moving Rebase 1 — onto
Rebase 2 — onto All three were additive. This PR's contribution to both files stayed pure insertions — nothing from the batch-1 backports was dropped, and nothing from them was absorbed into this diff. Re-verified after each rebase: file set still identical to the original commit ( Checks: Two red checks, neither from this diff:
Remaining in the queue against this base: the #18413 backport. |
Manual backport of #18390 to
cloud/1.54.Original merge commit:
17af6397a1050edd0be6ee9cea573e4348b77d18— "feat: attribute agent paywall purchases through checkout telemetry (#18390)".The automated
pr-backport.yamlbot could not cherry-pick this cleanly and deleted its branch, so this was redone by hand.Conflicts and how they were resolved
Every conflict was resolved per file against the original commit's own diff (
git show 17af6397a1 -- <path>), not by unioning the markers. The incoming side of each marker carriedmain's full file state, which includes changes from PRs not backported tocloud/1.54; those were deliberately left out.src/platform/telemetry/TelemetryRegistry.tsAgentPaywallCtaMetadata/AgentPaywallShownMetadata. DroppedAgentConsentResolvedMetadata/AgentConsentShownMetadata(not on this branch).src/platform/telemetry/providers/host/HostTelemetrySink.tsmain.src/platform/workspace/components/SubscriptionRequiredDialogContentUnified.test.tsmockUseSubscriptionCheckout, factory wrapped to record args) inside this branch'svi.mock(<string>, …)form rather than importingmain's typedvi.mock<unknown>(import(…))form.src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.tsrenderDialog(props)signature change; dropped themockBillingContext()context line, which does not exist on this branch. New tests assert through this branch'smockTrackCheckoutJourneyEventhandle instead ofmain's automockeduseTelemetry().src/platform/workspace/composables/useSubscriptionCheckout.test.tsjourneyEvents()/journeyPhases()split, reading from this branch'smockTrackCheckoutJourneyEvent.src/workbench/extensions/agent/AgentPanelRoot.test.tsexpectWithheldPurchaseActions()helper that does not exist on this branch (this branch still has the inlineit.for([...])form), so that hunk has no counterpart and was dropped. All substantive hunks applied.src/workbench/extensions/agent/stores/agent/agentConversationStore.tsreportedPaywallImpressionsandclaimPaywallImpression; kept this branch's exportedresolvePaywallsrather thanmain's renamedsetPaywallsResolved.Non-conflicting adaptations
mainhas test-mock infrastructure this branch lacks (src/composables/billing/__mocks__/, automockeduseDialogService/useBillingRouting/useBillingCapabilities). The PR's new tests were rewritten onto this branch's explicit mock handles so they compile and run; assertions are unchanged:useAccountPreconditionDialog.test.ts—useDialogService()→mockDialogServiceuseSubscriptionDialog.test.ts— routing helper setsmockShouldUseWorkspaceBilling/mockShouldUseUnifiedPricing(this branch's routing mock has notype)dialogService.topUpCredits.test.ts— capability setters use the hoistedstate;showDialogread directlySubscriptionRequiredDialogContent.test.ts— explicituseBillingContextfactory instead of the bare automockAgentPanelRoot.test.ts— threevi.fn()entries added to the existing hoisted telemetry mock; assertions usetelemetry.*Verification
File set is identical to the original commit's:
The small deltas are from the adaptations above (shorter mock-handle expressions, the dropped comment-only hunk, the added
vi.fn()entries).Checks
pnpm typecheck— pass, exit 0, no errorspnpm exec vitest runoversrc/platform/telemetry,src/platform/workspace,src/platform/cloud/subscription,src/services/dialogService*.test.ts,src/workbench/extensions/agent— 253/253 files, 4496 passed, 7 expected-fail, 0 failedpnpm exec eslinton the 31 changed files — pass, exit 0pnpm exec oxfmt --checkon the 31 changed files — passVercel – billing-web-testis red pre-existing across this repo, including on already-merged PRs. Not from this diff.Merge order
Seven backports are queued against
cloud/1.54and touch overlapping telemetry files:Batch 1 is unmerged and touches the same regions (the telemetry import lists and the agent conversation store in particular), so this PR will likely need a rebase once batch 1 lands. It is currently based on
origin/cloud/1.54as of the time of writing and has not been pre-emptively rebased onto anything else.