Repository navigation
feat(website): gate Workshop apps on workshop-apps-enabled - #18912
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 769b00cd28a32b6231c3bcd1c56dae64b6964420
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-18912.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-nvqf7dlon-comfyui.vercel.app Last updated: 2026-09-26T00:52:28Z for |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe website adds a separate PostHog flag and local-development override for workshop apps. Cinematic Studio’s page, featured slide, and model-page link now use this flag instead of the workshop workflows flag. ChangesWorkshop apps feature flag
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~15 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The separate apps flag appears ready for normal merge checks; no concrete issue requiring a pre-merge fix was established. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to Cinematic Studio becomes visible under a separate apps flag, but the reviewed code retains the broader Workshop gate and separate checks before generation. No new security vulnerability was established. The live flag targeting and server-side authorization were not verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18912 +/- ##
==========================================
- Coverage 83.99% 83.97% -0.02%
==========================================
Files 3156 3121 -35
Lines 153987 153231 -756
Branches 41488 41298 -190
==========================================
- Hits 129346 128681 -665
+ Misses 23046 23005 -41
+ Partials 1595 1545 -50
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 35 files with indirect coverage changes 🚀 New features to boost your workflow:
|
The pre-merge review is superseded: all current checks pass and there are no actionable review threads.
benjcooley
left a comment
There was a problem hiding this comment.
🧐 TED — review of ae23773
Verdict: good to go from my side. It's a clean flag switch. I'm posting this as a comment because GitHub doesn't let the author approve their own PR.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
Checked
- Entry points: all three Cinematic Studio entry points now use
useWorkshopAppsEnabled: the/cinematic-studiopage gate (CinematicStudioPage, which also covers Re-shoot), the featured studio slide inWorkshopModelsGrid, and the Open in Studio link inModelDetail. Nothing else links to the studio. The remaininguseWorkshopWorkflowsEnabledusers (ModelsPage,WorkflowPlayground) are workflow surfaces. - Identity resets: the flag is reset in all three paths (
refreshFlagForSameIdentity,adoptNewIdentity, and the identify-failure path) and read in bothinitPostHogbranches, mirroring the workflows flag exactly. The new test covers the reset on identity change. - Tests (local): 206 pass across
posthog,ModelDetail,WorkshopModelsGridandCinematicStudio.
Before deploying
- Create
workshop-apps-enabledin PostHog and target the same staff cohort first. Otherwise the studio disappears for staff who see it today through the workflows flag. - The catalogue's Apps tab is still behind the workflows flag and says "coming soon" even when the apps flag is on. That's fine as a placeholder, but it's not an entry point yet.
- #18928's
CinematicStudio.test.tsstill mocksuseWorkshopWorkflowsEnabledfor the "outside the staff rollout" case. Whichever PR lands second needs that switched touseWorkshopAppsEnabled.
ae23773 to
8954773
Compare
benjcooley
left a comment
There was a problem hiding this comment.
🧐 TED — re-review of 8954773
Verdict: still clean after the rebase. There's nothing to fix, and CI is green on everything that covers the website.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 0 |
What changed since ae23773
- The gate commit: a clean rebase onto
769b00c(#18928). A range-diff shows only a context line inModelDetail.vuechanged. - Cinematic Studio no longer uses the workflows flag: no file in it references
useWorkshopWorkflowsEnabledorworkshop-workflows-enabledany more. The only users left are workflow surfaces (ModelsPage,WorkflowPlayground) and the e2e flag mocks. - New
e2e/workshop-apps.spec.ts: it mocks PostHog/flagsthe same wayworkshop-workflows.spec.tsdoes. It asserts two things:/cinematic-studioshowsdata-testid="cinematic"with only the apps flag on, and shows the "not open yet" fallback with only the workflows flag on. Both selectors exist in the source. The website e2e total in CI went from 631 to 633, so the new spec is running.
Checks
- Local: 646 unit tests pass (posthog + Workshop components), and
pnpm typecheckis clean. - CI on
8954773: 49 passed, 33 skipped, none failed. That includes all fourwebsite-e2eshards andwebsite-unit.pr-riskwas still running when I checked.
Before deploying: create workshop-apps-enabled in PostHog and target staff first. Otherwise Cinematic Studio disappears for staff who can see it today.
About "sign-off": this review is posted from the author's own account (@benjcooley), so it can't count as an approval. The PR still needs one from comfy_website_devs. #18928 was merged without one and is now Comfy-Org/unreviewed-merges#345, next to #343 for #18763.
Summary
Gates Cinematic Studio and its Re-shoot app on the
workshop-apps-enabledPostHog flag instead ofworkshop-workflows-enabled, so apps and Cloud workflows roll out independently. Follow-up to #18695.Changes
useWorkshopAppsEnabled()inscripts/posthog.ts, resolved alongside the other Workshop flags and cleared on identity change;PUBLIC_WORKSHOP_APPS_ENABLED=1forces it on in local dev./cinematic-studiopage gate, the Cinematic Studio featured slide on/models, and a model page's Open in Studio link read the apps flag. Cloud workflow pages keepworkshop-workflows-enabled.workshop-apps.spec.ts:/cinematic-studioopens on the apps flag alone and stays closed when only the workflows flag is on.Review Focus
workshop-apps-enabledexists in PostHog: 100% forcomfy_staff = true, 0% otherwise.identifyInPostHogsetscomfy_staff: true, which that condition matches.posthog.test.tscase: the apps flag resolves independently of the workflows flag and resets on a caller change.Validation: website unit tests for posthog, ModelDetail, WorkshopModelsGrid, CinematicStudio, ModelsPage and WorkflowPlayground pass; the new e2e spec passes against a production build;
typecheck:website, eslint, oxlint, oxfmt and fallow clean.