Repository navigation
FE-2905 feat(cloud): socket and media URLs carry the web session workspace #18878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dante01yoon
merged 61 commits into
main
from
dante01yoon/fe-2905-socket-media-workspace
Sep 29, 2026
Merged
Changes from all commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
58f8b47
feat(account-core): web session client and session error codes
dante01yoon 0771e75
test: pin the cloud auth requests with unified_web_session off
dante01yoon 3171270
test(account-core): route table for the fake web session endpoint
dante01yoon 7974b8b
test: pin sign-out and the WebSocket URL with unified_web_session off
dante01yoon a2b3d13
test: pin customer provisioning and media URLs with unified_web_sessi…
dante01yoon 5976451
feat(account-core): session-backed identity and boot rules
dante01yoon d66f19d
feat(account-core): requestAuth authorize() for cookie requests
dante01yoon 404220c
fix(account-core): keep a network-lost restore unspent
dante01yoon f1d353d
feat(account-core): web session lifecycle and heartbeat
dante01yoon 5dfb638
test: assert sign-out closes the previous WebSocket
dante01yoon 59e9361
[chore] Update Ingest API types from cloud@70c573d
mattmillerai 2bd9659
Merge remote-tracking branch 'origin/main' into fe-2892-types
dante01yoon 522d1c3
Merge #18714 (ingest types from cloud@70c573d) for the generated GET …
dante01yoon 5a09df1
refactor(account-core): parse GET /session with the generated schema
dante01yoon 7906683
Merge remote-tracking branch 'origin/dante01yoon/fe-2892-web-session-…
dante01yoon 32f5da1
Merge branch 'dante01yoon/fe-2894-web-session-boot' into dante01yoon/…
dante01yoon 31eca58
fix(account-core): refuse unrecognised 4xx bodies and hold revoke-all…
dante01yoon 4542391
Merge remote-tracking branch 'origin/dante01yoon/fe-2892-web-session-…
dante01yoon 9989b1b
Merge remote-tracking branch 'origin/dante01yoon/fe-2892-web-session-…
dante01yoon a910388
Merge branch 'dante01yoon/fe-2894-web-session-boot' into dante01yoon/…
dante01yoon c22e39b
fix(account-core): keep a 200 that fails the session schema transient
dante01yoon a3138c9
Merge remote-tracking branch 'origin/dante01yoon/fe-2892-web-session-…
dante01yoon 8002741
Merge remote-tracking branch 'origin/dante01yoon/fe-2892-web-session-…
dante01yoon 1c450b4
Merge branch 'dante01yoon/fe-2894-web-session-boot' into dante01yoon/…
dante01yoon 4306c12
Merge remote-tracking branch 'origin/main' into dante01yoon/fe-2894-w…
dante01yoon 34142ed
Merge remote-tracking branch 'origin/main' into dante01yoon/fe-2895-r…
dante01yoon 7089780
Merge branch 'dante01yoon/fe-2894-web-session-boot' into dante01yoon/…
dante01yoon 2789fe7
fix(account-core): check the restored user and retry a failed remembe…
dante01yoon d032f28
Merge branch 'dante01yoon/fe-2894-web-session-boot' into dante01yoon/…
dante01yoon 2e14bae
Merge remote-tracking branch 'origin/main' into dante01yoon/fe-2895-r…
dante01yoon dc08d68
Merge remote-tracking branch 'origin/main' into dante01yoon/fe-2894-w…
dante01yoon 5021c16
Merge branch 'dante01yoon/fe-2894-web-session-boot' into dante01yoon/…
dante01yoon e595360
feat(cloud): join the shared web session lifecycle behind unified_web…
dante01yoon c32b77a
refactor(account-core): pull the transient lookup-error rule out of t…
dante01yoon 1b3aeda
Merge branch 'dante01yoon/fe-2894-web-session-boot' into dante01yoon/…
dante01yoon 5211cf1
Merge remote-tracking branch 'origin/dante01yoon/fe-2895-request-auth…
dante01yoon e7085c1
feat(cloud): send ingest requests on the web session behind unified_w…
dante01yoon da544d5
feat(cloud): scope the socket and media URLs to the web session works…
dante01yoon bbd56b6
fix(cloud): send the workspace on a session media fetch only in the h…
dante01yoon 927ca82
Merge remote-tracking branch 'origin/main' into dante01yoon/fe-2895-r…
dante01yoon dc0cac1
Merge remote-tracking branch 'origin/main' into dante01yoon/fe-2897-w…
dante01yoon 8f31e90
fix(account-core): a signed-out tab adopts only a sibling's sign-in
dante01yoon 3a26e60
Merge branch 'dante01yoon/fe-2897-web-session-lifecycle' into dante01…
dante01yoon bd081ef
fix(cloud): type the web session cross-tab port with the shared message
dante01yoon afa3165
Merge branch 'dante01yoon/fe-2903-cloud-session-lifecycle' into dante…
dante01yoon af689d8
Merge branch 'dante01yoon/fe-2895-request-auth' into dante01yoon/fe-2…
dante01yoon e6d4ba4
Merge branch 'dante01yoon/fe-2904-cloud-api-on-session' into dante01y…
dante01yoon 77f2d97
Merge remote-tracking branch 'origin/main' into dante01yoon/fe-2903-c…
dante01yoon e5b476e
test(account-core): drop duplicated lines in the pack smoke consumer
dante01yoon 7606d9f
Merge branch 'dante01yoon/fe-2903-cloud-session-lifecycle' into dante…
dante01yoon 3fc326b
test(account-core): drop duplicated lines in the pack smoke consumer
dante01yoon 0a189b8
Merge branch 'dante01yoon/fe-2904-cloud-api-on-session' into dante01y…
dante01yoon 5f76d6d
[automated] Apply ESLint and Oxfmt fixes
actions-user 1d2145d
[automated] Apply ESLint and Oxfmt fixes
actions-user 07f9665
Merge remote-tracking branch 'origin/main' into dante01yoon/fe-2904-c…
dante01yoon 566d14f
fix(workspace): keep the current workspace when re-entering it on the…
dante01yoon a7b31b4
test(cloud): a request sent on the web session reports as authenticated
dante01yoon 6fb9dbf
Merge remote-tracking branch 'origin/dante01yoon/fe-2904-cloud-api-on…
dante01yoon 6f7bedb
Merge remote-tracking branch 'origin/main' into dante01yoon/fe-2905-s…
dante01yoon 9b3e71e
test(account-core): list requestAuth once in the inert-import check
dante01yoon 0041723
test(cloud): assert sign-out closes the session socket before the ser…
dante01yoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| const MEDIA_ROUTE = | ||
| /^(?:\/api)?\/(?:view|viewvideo|vhs\/viewvideo|vhs\/viewaudio|assets\/[^/?#]+\/content)(?:\?|$)/ | ||
|
|
||
| /** | ||
| * Names the workspace on a media route, which an image or video tag loads | ||
| * without headers; absent means the personal workspace. | ||
| */ | ||
| export function scopeMediaRoute( | ||
| route: string, | ||
| workspaceId: string | undefined | ||
| ): string { | ||
| if (!workspaceId || !MEDIA_ROUTE.test(route)) return route | ||
| if (/[?&]workspace_id=/.test(route)) return route | ||
| const separator = route.includes('?') ? '&' : '?' | ||
| return `${route}${separator}workspace_id=${encodeURIComponent(workspaceId)}` | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.