Skip to content

[backport cloud/1.55] fix(agent): stop remote setWidget ops clobbering an in-progress local edit (#18766) - #18814

Merged
christian-byrne merged 1 commit into
cloud/1.55from
backport-18766-to-cloud-1.55
Sep 25, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.55from
backport-18766-to-cloud-1.55

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #18766 to cloud/1.55. Original authorship and commit message preserved (cherry-pick of the squashed merge commit, not a re-authored patch).

Why

Typing into any text widget while the agent panel is open garbles the text: the host echoes the user's own set_widget ops back as whole-value doc frames that are stale by however many keystrokes are in flight, and replaying one deletes text under the cursor. Reported on prod cloud.comfy.org by four users over ten days and hit the Silverside customer demo.

cloud/1.55 does not currently serve users (no 1.55 release exists on PyPI, and prod is pinned to a cloud/1.54 commit), but it is the next train — without this carrier both defects return the moment 1.55 ships.

The automatic backport workflow ran on #18766 and failed with cherry-pick conflicts on all four targets, so this carrier is a hand cherry-pick.

Conflict resolution

  • browser_tests/tests/agent/agentConversationReplay.spec.ts — exists on this branch; the source PR's test.fail() removal applied cleanly.
  • browser_tests/tests/agent/agentCrdtReconcileOverwrite.spec.ts and agentWidgetTypingReconcile.spec.ts — modify/delete conflicts: these specs do not exist on any release branch. Kept the branch's state; no spec was deleted and none was newly introduced (verified with git diff --diff-filter=D).
  • graphMutations.test.ts — content conflict resolved by taking the incoming side (the source PR's unit tests; no same-named test exists on this branch).

No package, lockfile, core-type or business-logic conflict arose; nothing was resolved creatively.

Marker evidence

skipStaleReconcile occurrences in src/workbench/extensions/agent/crdt/graphMutations.ts: 4 before → 5 after on this branch (5 on main). The one added call site — the incremental setWidget case consulting the local-dirty guard — is the fix.

Verification

pnpm test:unit src/workbench/extensions/agent/crdt/graphMutations.test.ts green on this branch (NODE_OPTIONS=--no-experimental-webstorage). Proved red-on-parent honestly rather than trusting a clean pick: reverting only the graphMutations.ts hunk and rerunning turns 4 tests red, including the PM-1191/PM-1697 keystroke-echo round trip.


Carried by the in-app-agent program row bp-1.

… edit (#18766)

Typing into any text widget while the agent panel is open garbles — the
cursor jumps and fast typing deletes letters (PM-1191, PM-1697, live on
cloud at 5% exposure). Root cause: the incremental `setWidget` apply
path writes remote doc-frame values into `widgetValueStore` with no
in-progress-local-edit guard, so the host's echo of the user's *own*
keystroke ops (whole-value, stale by however many keystrokes are in
flight) deletes text under the cursor. The same unguarded path let an
agent turn's `set_widget` overwrite a widget the user was mid-editing.

- **What**: `graphMutations.ts` — the incremental `setWidget` commit now
consults the same `skipStaleReconcile` local-dirty guard the
full-reconcile path already uses: a remote value that differs from a
locally-dirty widget is skipped until the document catches up to the
local value; the write that finally matches clears the mark (its
context-carrying no-op write), after which remote/agent writes land
normally. The old escape hatch that let a single-widget op bypass the
guard "regardless of value" is retired — that bypass *was* the garble.
- **Pins flipped green honestly** (each red on parent, green here):
- `graphMutations.test.ts` "preserves a locally newer widget value
across a direct setWidget op" (`it.fails` → `it`), plus a new round-trip
test covering skip-stale-echo → catch-up-clears → agent-write-lands.
- `agentCrdtReconcileOverwrite.spec.ts` widget-overwrite case
(`test.fail()` removed; now proves the agent frame really applied via
the CRDT debug-panel outcomes counter *and* that the user's text
survived).
- `agentConversationReplay.spec.ts` "keeps prompt keystrokes when a doc
frame resyncs the widget" (`test.fail()` removed — with this fix it
passes deterministically, not by echo-latency luck; supersedes the
marker-only removal in #18649).
- Two unit tests that pinned the old escape-hatch contract are updated
to the new one (a differing remote write holds; only a matching one
resolves the mark). The trade: a widget stranded dirty by an
unsuppressed structural replay now stays local-valued until a matching
remote write, instead of being unstuck by the next agent op — the
suppression brackets those tests also pin are what prevent that state.

- The guard-clearing rule: convergence relies on the user's own minted
keystroke ops echoing back; once the echo value equals the local value,
the contexted write clears `locallyDirtyWidgets`. Verified in
`graphMutations.test.ts` round-trip test.
- Open test PRs
[#18089](#18089) and
[#18705](#18705) both
flip to "expected to fail, but passed" when run against this branch
(verified locally; #18705's attachment shows the stale echo arriving and
being skipped) — their `test.fail()` markers should drop on rebase after
this merges.
- Freeze note: this is the authorized P0 exception to the informal
remote-ops freeze. `graphMutations.ts` is deleted by the #18700
refactor; the property this restores — *a local edit in progress is
never overwritten by a remote or reconciled write* — must be re-asserted
on the new graph-API apply path (own-actor echo skip at follower entry +
a provenance-aware guard at the widget setter). The three flipped
black-box/unit pins are the acceptance tests for that re-assertion; they
survive the refactor even though this implementation does not.

Evidence: reported by four users over ten days (Memie 09-15 w/ CRDT
debug report `F0C22E6U70E`, Denys 09-22, Luke 09-24, Doug 09-24
Silverside demo).
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Sep 25, 2026
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2101 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/25/2026, 07:20:24 AM UTC

Links

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (7 changed files).

Kind Finding Where Usual remedy
Complexity commit() — cyclomatic 30, CRAP 224.4 src/workbench/extensions/agent/crdt/graphMutations.ts:2086 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since fa2519e77478c572ccb79c99d5074305745758ee

Full docs: ADR-DEVEX-LINT-0015

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.4 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 395ms TBT · 69.5 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 156ms TBT · 86.3 MB heap
extension-clean-combined-draw: · 56.3 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 61ms TBT · 87.2 MB heap
extension-rgthree-prototype-draw: · 56.3 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 65ms TBT · 93.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 87ms TBT · 81.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 181.9 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 82ms TBT · 175.5 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 275ms TBT · 174.1 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 12
canvas-idle: task duration 384ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 72.0 MB
canvas-idle: DOM nodes -269
canvas-idle: event listeners -152
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 0ms
canvas-mouse-sweep: style recalc duration 13ms
canvas-mouse-sweep: layout count 0
canvas-mouse-sweep: style recalc count 48
canvas-mouse-sweep: task duration 630ms
canvas-mouse-sweep: script duration 117ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 74.4 MB
canvas-mouse-sweep: DOM nodes -258
canvas-mouse-sweep: event listeners -152
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 12ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 29
canvas-zoom-sweep: task duration 269ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 67.4 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 362ms
dom-widget-clipping: script duration 134ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 82.4 MB
dom-widget-clipping: DOM nodes 23
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 696ms
dom-widget-order-dense-n200-w200-i120: script duration 50ms
dom-widget-order-dense-n200-w200-i120: TBT 395ms
dom-widget-order-dense-n200-w200-i120: heap used 69.5 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -294
dom-widget-order-dense-n200-w200-i120: event listeners -217
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 370ms
dom-widget-order-sparse-n1000-w20-i120: script duration 117ms
dom-widget-order-sparse-n1000-w20-i120: TBT 156ms
dom-widget-order-sparse-n1000-w20-i120: heap used 86.3 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 18ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 3
extension-clean-combined-draw: task duration 6449ms
extension-clean-combined-draw: script duration 5269ms
extension-clean-combined-draw: TBT 61ms
extension-clean-combined-draw: heap used 87.2 MB
extension-clean-combined-draw: DOM nodes -136
extension-clean-combined-draw: event listeners -87
extension-rgthree-prototype-draw: avg frame time 18ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 2
extension-rgthree-prototype-draw: task duration 6262ms
extension-rgthree-prototype-draw: script duration 5105ms
extension-rgthree-prototype-draw: TBT 65ms
extension-rgthree-prototype-draw: heap used 93.0 MB
extension-rgthree-prototype-draw: DOM nodes -139
extension-rgthree-prototype-draw: event listeners -87
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 510ms
large-graph-idle: script duration 32ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 78.0 MB
large-graph-idle: DOM nodes -239
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1288ms
large-graph-pan: script duration 652ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 77.9 MB
large-graph-pan: DOM nodes -115
large-graph-pan: event listeners -76
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 67
large-graph-zoom: task duration 1433ms
large-graph-zoom: script duration 642ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 68.5 MB
large-graph-zoom: DOM nodes -233
large-graph-zoom: event listeners -174
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 10ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 48
legacy-node-drag: task duration 1610ms
legacy-node-drag: script duration 807ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 74.8 MB
legacy-node-drag: DOM nodes -245
legacy-node-drag: event listeners 6
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 490ms
minimap-idle: script duration 30ms
minimap-idle: TBT 0ms
minimap-idle: heap used 78.6 MB
minimap-idle: DOM nodes -243
minimap-idle: event listeners -163
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 50
subgraph-dom-widget-clipping: task duration 325ms
subgraph-dom-widget-clipping: script duration 120ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 80.1 MB
subgraph-dom-widget-clipping: DOM nodes 24
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 361ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.1 MB
subgraph-idle: DOM nodes -275
subgraph-idle: event listeners -209
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 0ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 0
subgraph-mouse-sweep: style recalc count 48
subgraph-mouse-sweep: task duration 557ms
subgraph-mouse-sweep: script duration 80ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.2 MB
subgraph-mouse-sweep: DOM nodes -271
subgraph-mouse-sweep: event listeners -218
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 9ms
subgraph-transition-enter: style recalc duration 22ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 687ms
subgraph-transition-enter: script duration 22ms
subgraph-transition-enter: TBT 87ms
subgraph-transition-enter: heap used 81.4 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 4996ms
viewport-pan-sweep: script duration 2383ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 71.8 MB
viewport-pan-sweep: DOM nodes -223
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14050ms
vue-large-graph-idle: script duration 205ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 181.9 MB
vue-large-graph-idle: DOM nodes -8062
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 94
vue-large-graph-pan: task duration 15419ms
vue-large-graph-pan: script duration 743ms
vue-large-graph-pan: TBT 82ms
vue-large-graph-pan: heap used 175.5 MB
vue-large-graph-pan: DOM nodes -8062
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 60ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5239ms
vue-node-resize-workload: script duration 87ms
vue-node-resize-workload: TBT 275ms
vue-node-resize-workload: heap used 174.1 MB
vue-node-resize-workload: DOM nodes -8062
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6980ms
vue-zoom-out-idle: script duration 100ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 171.8 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 4
workflow-execution: style recalc count 14
workflow-execution: task duration 85ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.7 MB
workflow-execution: DOM nodes 140
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-09-25T07:30:10.747Z",
  "gitSha": "a304fc7e77d2cbf2e1c4dd4db79dc71f34a20abf",
  "branch": "backport-18766-to-cloud-1.55",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 1991.1489999999503,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.941000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 380.17900000000003,
      "heapDeltaBytes": 10092696,
      "heapUsedBytes": 77481048,
      "domNodes": -258,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.027000000000001,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2013.569000000075,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.014000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 387,
      "heapDeltaBytes": 5388204,
      "heapUsedBytes": 73611692,
      "domNodes": -279,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 8.138,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1688.3789999999408,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 13.927,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 631.293,
      "heapDeltaBytes": 9689556,
      "heapUsedBytes": 77412232,
      "domNodes": -258,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 115.35,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1692.3120000000154,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 13.064000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 628.722,
      "heapDeltaBytes": 10942484,
      "heapUsedBytes": 78682076,
      "domNodes": -257,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 118.579,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1700.7519999999658,
      "styleRecalcs": 28,
      "styleRecalcDurationMs": 12.402999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.9600000000000001,
      "taskDurationMs": 268.297,
      "heapDeltaBytes": 3091360,
      "heapUsedBytes": 70777424,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 9.893000000000002,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1693.8310000000456,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 12.549999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.925,
      "taskDurationMs": 269.64,
      "heapDeltaBytes": 3168504,
      "heapUsedBytes": 70518232,
      "domNodes": 78,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.162,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 556.1549999999897,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 8.363,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.01,
      "heapDeltaBytes": 18658476,
      "heapUsedBytes": 86330484,
      "domNodes": 24,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 135.821,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 532.6169999999593,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 7.68,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 358.471,
      "heapDeltaBytes": 18929272,
      "heapUsedBytes": 86390048,
      "domNodes": 22,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 131.463,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1033.0470000000105,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 684.5559999999999,
      "heapDeltaBytes": -17566348,
      "heapUsedBytes": 72789288,
      "domNodes": -293,
      "jsHeapTotalBytes": 20316160,
      "scriptDurationMs": 49.91900000000002,
      "eventListeners": -217,
      "totalBlockingTimeMs": 384,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1052.1980000000895,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 706.6450000000001,
      "heapDeltaBytes": -17443076,
      "heapUsedBytes": 73064304,
      "domNodes": -294,
      "jsHeapTotalBytes": 20840448,
      "scriptDurationMs": 50.05799999999999,
      "eventListeners": -217,
      "totalBlockingTimeMs": 406,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 784.6179999999094,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 371.95500000000027,
      "heapDeltaBytes": 14746788,
      "heapUsedBytes": 90007876,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 120.06400000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 155,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 766.0909999999603,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 368.4069999999999,
      "heapDeltaBytes": 14506688,
      "heapUsedBytes": 90890012,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 114.83699999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 157,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7310.289000000012,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.6630000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6427.854,
      "heapDeltaBytes": 18405492,
      "heapUsedBytes": 93321424,
      "domNodes": -12,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 5355.317999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 85,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7308.330999999953,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 1.6019999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6470.854,
      "heapDeltaBytes": 11800448,
      "heapUsedBytes": 89587688,
      "domNodes": -260,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 5183.428999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 36,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6703.373999999996,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.12799999999999964,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6035.275000000001,
      "heapDeltaBytes": 12305448,
      "heapUsedBytes": 94026076,
      "domNodes": -16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 5001.893,
      "eventListeners": 0,
      "totalBlockingTimeMs": 98,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7305.258999999978,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.7319999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6489.232999999999,
      "heapDeltaBytes": 24720040,
      "heapUsedBytes": 101109764,
      "domNodes": -261,
      "jsHeapTotalBytes": 7856128,
      "scriptDurationMs": 5207.245000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 31,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2035.7429999999113,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.779,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 523,
      "heapDeltaBytes": -3827776,
      "heapUsedBytes": 83094016,
      "domNodes": -236,
      "jsHeapTotalBytes": -1019904,
      "scriptDurationMs": 33.562,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.686000000027,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.050999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.0740000000001,
      "heapDeltaBytes": -6576564,
      "heapUsedBytes": 80543560,
      "domNodes": -242,
      "jsHeapTotalBytes": 290816,
      "scriptDurationMs": 30.314999999999994,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2156.998000000044,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.447,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1317.5539999999999,
      "heapDeltaBytes": 18569680,
      "heapUsedBytes": 83571240,
      "domNodes": 12,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 663.753,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2096.4480000000094,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 12.593,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1259.28,
      "heapDeltaBytes": 15842372,
      "heapUsedBytes": 79891220,
      "domNodes": -242,
      "jsHeapTotalBytes": 1273856,
      "scriptDurationMs": 639.559,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3232.221999999979,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 13.344999999999999,
      "layouts": 60,
      "layoutDurationMs": 13.004999999999999,
      "taskDurationMs": 1452.1330000000003,
      "heapDeltaBytes": -16326256,
      "heapUsedBytes": 73795824,
      "domNodes": -251,
      "jsHeapTotalBytes": -1282048,
      "scriptDurationMs": 640.92,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3236.1059999999497,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.752999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.649000000000001,
      "taskDurationMs": 1413.624,
      "heapDeltaBytes": -19422884,
      "heapUsedBytes": 69837200,
      "domNodes": -214,
      "jsHeapTotalBytes": 290816,
      "scriptDurationMs": 642.458,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2368.0389999999534,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 9.226,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1600.65,
      "heapDeltaBytes": -17433144,
      "heapUsedBytes": 73844692,
      "domNodes": -244,
      "jsHeapTotalBytes": -8192,
      "scriptDurationMs": 811.85,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2553.7050000000363,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.051999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1620.0800000000002,
      "heapDeltaBytes": -7935704,
      "heapUsedBytes": 83061188,
      "domNodes": -245,
      "jsHeapTotalBytes": 1232896,
      "scriptDurationMs": 802.293,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2036.2269999999398,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.522999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 521.4110000000001,
      "heapDeltaBytes": -8429252,
      "heapUsedBytes": 80200648,
      "domNodes": -243,
      "jsHeapTotalBytes": 1077248,
      "scriptDurationMs": 30.285000000000007,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2015.555000000063,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.527000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.042,
      "heapDeltaBytes": 20635256,
      "heapUsedBytes": 84579240,
      "domNodes": -242,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 30.355000000000008,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 506.4280000000281,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 10.697999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 325.242,
      "heapDeltaBytes": 14165228,
      "heapUsedBytes": 83988984,
      "domNodes": 23,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 120.18799999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 493.9689999999928,
      "styleRecalcs": 50,
      "styleRecalcDurationMs": 10.743999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 324.69000000000005,
      "heapDeltaBytes": 14139448,
      "heapUsedBytes": 84021088,
      "domNodes": 25,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 120.79,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.21900000003,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.183000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 361.95300000000003,
      "heapDeltaBytes": 10484160,
      "heapUsedBytes": 80385672,
      "domNodes": -274,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.29,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1991.057000000069,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.384999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 360.339,
      "heapDeltaBytes": -2685196,
      "heapUsedBytes": 60379888,
      "domNodes": -275,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 7.0859999999999985,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1690.921000000003,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 14.828,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 616.2950000000001,
      "heapDeltaBytes": -10948752,
      "heapUsedBytes": 59095468,
      "domNodes": -271,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 83.09000000000002,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1690.8260000000155,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.556,
      "heapDeltaBytes": -6809760,
      "heapUsedBytes": 63019504,
      "domNodes": -271,
      "jsHeapTotalBytes": 7593984,
      "scriptDurationMs": 77.303,
      "eventListeners": -215,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 867.3780000000306,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 21.768000000000008,
      "layouts": 5,
      "layoutDurationMs": 9.368000000000002,
      "taskDurationMs": 686.7049999999999,
      "heapDeltaBytes": -6420836,
      "heapUsedBytes": 85312316,
      "domNodes": 13667,
      "jsHeapTotalBytes": 11796480,
      "scriptDurationMs": 21.525999999999996,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 87,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8402.134000000045,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 39.629999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5202.501,
      "heapDeltaBytes": -11793640,
      "heapUsedBytes": 68114924,
      "domNodes": -209,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 2395.6659999999997,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8261.167000000001,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 37.162,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4789.609,
      "heapDeltaBytes": -5149504,
      "heapUsedBytes": 82504148,
      "domNodes": -236,
      "jsHeapTotalBytes": 1302528,
      "scriptDurationMs": 2370.269,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14131.230999999956,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13858.333,
      "heapDeltaBytes": -23709896,
      "heapUsedBytes": 187110200,
      "domNodes": -8062,
      "jsHeapTotalBytes": -11644928,
      "scriptDurationMs": 200.71300000000002,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14390.378999999939,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14242.429999999998,
      "heapDeltaBytes": -42397232,
      "heapUsedBytes": 194278704,
      "domNodes": -8062,
      "jsHeapTotalBytes": -9809920,
      "scriptDurationMs": 208.98699999999997,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17215.084000000046,
      "styleRecalcs": 121,
      "styleRecalcDurationMs": 16.011999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17093.115,
      "heapDeltaBytes": -42431076,
      "heapUsedBytes": 192143944,
      "domNodes": -8062,
      "jsHeapTotalBytes": -13217792,
      "scriptDurationMs": 750.0870000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 75,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13928.563000000053,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.952999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13745.291000000001,
      "heapDeltaBytes": -66615956,
      "heapUsedBytes": 175828836,
      "domNodes": -8062,
      "jsHeapTotalBytes": -26152960,
      "scriptDurationMs": 736.213,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 88,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5163.345999999933,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 58.71299999999999,
      "layouts": 20,
      "layoutDurationMs": 21.65500000000001,
      "taskDurationMs": 5143.607999999999,
      "heapDeltaBytes": -47844852,
      "heapUsedBytes": 189575272,
      "domNodes": -8062,
      "jsHeapTotalBytes": 17715200,
      "scriptDurationMs": 84.21399999999998,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 214,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5350.010999999995,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 62.001,
      "layouts": 20,
      "layoutDurationMs": 23.76299999999999,
      "taskDurationMs": 5334.12,
      "heapDeltaBytes": -72527776,
      "heapUsedBytes": 175520204,
      "domNodes": -8062,
      "jsHeapTotalBytes": 12611584,
      "scriptDurationMs": 88.88199999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 335,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7101.391999999919,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6929.121,
      "heapDeltaBytes": 15013748,
      "heapUsedBytes": 194737148,
      "domNodes": 0,
      "jsHeapTotalBytes": -13893632,
      "scriptDurationMs": 101.25,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7091.908999999987,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7030.963000000002,
      "heapDeltaBytes": -4551936,
      "heapUsedBytes": 165486332,
      "domNodes": 0,
      "jsHeapTotalBytes": -31719424,
      "scriptDurationMs": 99.29899999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 450.16800000007606,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 19.509999999999998,
      "layouts": 3,
      "layoutDurationMs": 1.3419999999999999,
      "taskDurationMs": 103.16300000000001,
      "heapDeltaBytes": 5193816,
      "heapUsedBytes": 71076192,
      "domNodes": 153,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.395,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 95.02799999995659,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 13.398,
      "layouts": 4,
      "layoutDurationMs": 1.469,
      "taskDurationMs": 66.317,
      "heapDeltaBytes": 3029656,
      "heapUsedBytes": 68738712,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.688000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52306 79042 66.2% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.8% 1153
src/LGraphNode.ts 70.5% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.8% 320
src/LGraph.ts 78.6% 272
src/scripts/app.ts 72.3% 259
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 0.9% 232
src/scripts/pnginfo.ts 20.8% 221

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 1c900174-06ed-49e6-b84a-0edcba031765

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Playwright videos for new tests

Download the recorded videos and HTML report

Recorded projects: cloud

Recorded test titles:

  • all tests in browser_tests/tests/agent/agentConversationReplay.spec.ts

@codecov

codecov Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.55   #18814   +/-   ##
=============================================
  Coverage              ?   84.58%           
=============================================
  Files                 ?     2294           
  Lines                 ?   131270           
  Branches              ?    35427           
=============================================
  Hits                  ?   111039           
  Misses                ?    19931           
  Partials              ?      300           
Flag Coverage Δ
e2e 66.17% <ø> (?)
unit 80.46% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../workbench/extensions/agent/crdt/graphMutations.ts 94.25% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Landing under Christian's backport merge grant (program/release-backport-authority.md; extended to the 1.55 trains by Christian on 2026-09-25). Reviewed as the carrier author, so this is an honest COMMENT — no self-approval is being manufactured.

Evidence at 132232e7f438f9aba078b1bb68fc6803c1040d9b:

  • required checks (lint-and-format, test, e2e-status) green; Vercel – billing-web-test is red on every PR on this train, including the commit production is currently pinned to, and is not a required check
  • target-aware exact-head guard run (scripts/check-merge-ready.sh ... --target-branch cloud/1.55); verdict recorded in reports/jobs/bp-1.md
  • focused suites green locally at this head with NODE_OPTIONS=--no-experimental-webstorage
  • marker verified on the branch, not inferred from a clean cherry-pick

@christian-byrne
christian-byrne merged commit bccf739 into cloud/1.55 Sep 25, 2026
116 checks passed
@christian-byrne
christian-byrne deleted the backport-18766-to-cloud-1.55 branch September 25, 2026 08:20
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants