Repository navigation
[backport core/1.55] fix(agent): stop remote setWidget ops clobbering an in-progress local edit (#18766) - #18812
Conversation
… edit (#18766) Typing into any text widget while the agent panel is open garbles — the cursor jumps and fast typing deletes letters (PM-1191, PM-1697, live on cloud at 5% exposure). Root cause: the incremental `setWidget` apply path writes remote doc-frame values into `widgetValueStore` with no in-progress-local-edit guard, so the host's echo of the user's *own* keystroke ops (whole-value, stale by however many keystrokes are in flight) deletes text under the cursor. The same unguarded path let an agent turn's `set_widget` overwrite a widget the user was mid-editing. - **What**: `graphMutations.ts` — the incremental `setWidget` commit now consults the same `skipStaleReconcile` local-dirty guard the full-reconcile path already uses: a remote value that differs from a locally-dirty widget is skipped until the document catches up to the local value; the write that finally matches clears the mark (its context-carrying no-op write), after which remote/agent writes land normally. The old escape hatch that let a single-widget op bypass the guard "regardless of value" is retired — that bypass *was* the garble. - **Pins flipped green honestly** (each red on parent, green here): - `graphMutations.test.ts` "preserves a locally newer widget value across a direct setWidget op" (`it.fails` → `it`), plus a new round-trip test covering skip-stale-echo → catch-up-clears → agent-write-lands. - `agentCrdtReconcileOverwrite.spec.ts` widget-overwrite case (`test.fail()` removed; now proves the agent frame really applied via the CRDT debug-panel outcomes counter *and* that the user's text survived). - `agentConversationReplay.spec.ts` "keeps prompt keystrokes when a doc frame resyncs the widget" (`test.fail()` removed — with this fix it passes deterministically, not by echo-latency luck; supersedes the marker-only removal in #18649). - Two unit tests that pinned the old escape-hatch contract are updated to the new one (a differing remote write holds; only a matching one resolves the mark). The trade: a widget stranded dirty by an unsuppressed structural replay now stays local-valued until a matching remote write, instead of being unstuck by the next agent op — the suppression brackets those tests also pin are what prevent that state. - The guard-clearing rule: convergence relies on the user's own minted keystroke ops echoing back; once the echo value equals the local value, the contexted write clears `locallyDirtyWidgets`. Verified in `graphMutations.test.ts` round-trip test. - Open test PRs [#18089](#18089) and [#18705](#18705) both flip to "expected to fail, but passed" when run against this branch (verified locally; #18705's attachment shows the stale echo arriving and being skipped) — their `test.fail()` markers should drop on rebase after this merges. - Freeze note: this is the authorized P0 exception to the informal remote-ops freeze. `graphMutations.ts` is deleted by the #18700 refactor; the property this restores — *a local edit in progress is never overwritten by a remote or reconciled write* — must be re-asserted on the new graph-API apply path (own-actor echo skip at follower entry + a provenance-aware guard at the widget setter). The three flipped black-box/unit pins are the acceptance tests for that re-assertion; they survive the refactor even though this implementation does not. Evidence: reported by four users over ten days (Memie 09-15 w/ CRDT debug report `F0C22E6U70E`, Denys 09-22, Luke 09-24, Doug 09-24 Silverside demo).
🎭 Playwright: ✅ 2124 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (7 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3fdef47dc5e21af1c6c178a42e4c50adeb3b3bc2
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T07:29:42.532Z",
"gitSha": "5b7c46e8a531eb480d66dae0db27ef21f109c0c8",
"branch": "backport-18766-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1993.5440000000426,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.301999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.569,
"heapDeltaBytes": -10567840,
"heapUsedBytes": 57397376,
"domNodes": -258,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.566,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1989.6340000000237,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 273.098,
"heapDeltaBytes": -7612532,
"heapUsedBytes": 59581020,
"domNodes": -255,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.413999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.557000000008,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.331,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.1259999999999,
"heapDeltaBytes": -4957524,
"heapUsedBytes": 57453424,
"domNodes": -259,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 99.17399999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.2690000000766,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.806,
"heapDeltaBytes": 8977164,
"heapUsedBytes": 76539312,
"domNodes": -258,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 94.53200000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.2540000000245,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.725000000000001,
"layouts": 6,
"layoutDurationMs": 1.183,
"taskDurationMs": 262.478,
"heapDeltaBytes": 3033408,
"heapUsedBytes": 70581288,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.977999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.7279999999646,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.789000000000001,
"layouts": 6,
"layoutDurationMs": 1.076,
"taskDurationMs": 233.92000000000002,
"heapDeltaBytes": 3148464,
"heapUsedBytes": 70790376,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7.539000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 494.562999999971,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.499999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 310.78,
"heapDeltaBytes": 18581548,
"heapUsedBytes": 86352624,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 107.453,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 493.378000000007,
"styleRecalcs": 14,
"styleRecalcDurationMs": 5.923999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 299.71000000000004,
"heapDeltaBytes": 17955824,
"heapUsedBytes": 80431372,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 106.29899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 952.6619999999753,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.452,
"heapDeltaBytes": 38290936,
"heapUsedBytes": 105018952,
"domNodes": 0,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 44.96199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 359,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 981.6849999999704,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.9700000000001,
"heapDeltaBytes": 39029100,
"heapUsedBytes": 108046808,
"domNodes": 0,
"jsHeapTotalBytes": 20082688,
"scriptDurationMs": 40.376,
"eventListeners": 0,
"totalBlockingTimeMs": 371,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 698.0120000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.5770000000002,
"heapDeltaBytes": 14669968,
"heapUsedBytes": 90834600,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 99.03399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 103,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 700.3330000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 274.79699999999997,
"heapDeltaBytes": 14874088,
"heapUsedBytes": 89919712,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 85.505,
"eventListeners": 0,
"totalBlockingTimeMs": 96,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6131.764999999973,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.7090000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5226.4220000000005,
"heapDeltaBytes": -10757308,
"heapUsedBytes": 71108460,
"domNodes": -14,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 3945.393,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5941.531999999938,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.2010000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5150.039,
"heapDeltaBytes": 4966028,
"heapUsedBytes": 82176860,
"domNodes": -267,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 3947.716,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6162.162000000024,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.1799999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5318.316,
"heapDeltaBytes": 2764732,
"heapUsedBytes": 80289216,
"domNodes": -265,
"jsHeapTotalBytes": 8904704,
"scriptDurationMs": 4126.807,
"eventListeners": -174,
"totalBlockingTimeMs": 35,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6377.141999999935,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.8299999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5457.575999999999,
"heapDeltaBytes": 13093232,
"heapUsedBytes": 95010980,
"domNodes": -14,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 4304.366,
"eventListeners": 0,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2008.449999999982,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.222000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.79999999999995,
"heapDeltaBytes": -7862028,
"heapUsedBytes": 79565856,
"domNodes": -239,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 27.724,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2011.908999999946,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.481000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.714,
"heapDeltaBytes": -4065692,
"heapUsedBytes": 83130092,
"domNodes": -234,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 23.155999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2152.8190000000222,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.709999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1191.7359999999999,
"heapDeltaBytes": -7825652,
"heapUsedBytes": 80162532,
"domNodes": -240,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 569.519,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2090.512999999987,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.661,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1013.4020000000002,
"heapDeltaBytes": 11872548,
"heapUsedBytes": 75992900,
"domNodes": -235,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 496.421,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3176.70899999996,
"styleRecalcs": 66,
"styleRecalcDurationMs": 17.249999999999996,
"layouts": 60,
"layoutDurationMs": 14.915999999999999,
"taskDurationMs": 1384.242,
"heapDeltaBytes": -16062484,
"heapUsedBytes": 73818188,
"domNodes": -243,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 589.4970000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3065.849000000071,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.424,
"layouts": 60,
"layoutDurationMs": 10.208,
"taskDurationMs": 1161.703,
"heapDeltaBytes": -15614588,
"heapUsedBytes": 73700188,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 492.59799999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2193.4179999999515,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.496999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1372.891,
"heapDeltaBytes": -10235664,
"heapUsedBytes": 73960700,
"domNodes": -245,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 653.609,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2173.347000000035,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.078,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1243.373,
"heapDeltaBytes": -17433888,
"heapUsedBytes": 73987804,
"domNodes": -222,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 580.457,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2030.5489999999509,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.526999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.69199999999995,
"heapDeltaBytes": -8637824,
"heapUsedBytes": 79539988,
"domNodes": -245,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 28.679000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.7140000000363,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.094000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.127,
"heapDeltaBytes": -5656016,
"heapUsedBytes": 82487896,
"domNodes": -236,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 25.305999999999994,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 475.2530000000661,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.308,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.808,
"heapDeltaBytes": 13386928,
"heapUsedBytes": 83526600,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 103.18900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 410.11200000002646,
"styleRecalcs": 50,
"styleRecalcDurationMs": 8.283999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 270.89000000000004,
"heapDeltaBytes": 13799596,
"heapUsedBytes": 83504624,
"domNodes": 25,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 88.999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 1992.3370000000205,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.802999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.048,
"heapDeltaBytes": -6934196,
"heapUsedBytes": 63130512,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.843,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2010.1280000000088,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.981,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.968,
"heapDeltaBytes": -7845652,
"heapUsedBytes": 62432836,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.4159999999999995,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.5950000000257,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.223,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.62,
"heapDeltaBytes": -7868056,
"heapUsedBytes": 62212384,
"domNodes": -274,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 73.274,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.8389999999645,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.979,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.252,
"heapDeltaBytes": -8176092,
"heapUsedBytes": 61657636,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 60.155,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 849.0830000000642,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.1,
"layouts": 5,
"layoutDurationMs": 7.69,
"taskDurationMs": 599.5409999999998,
"heapDeltaBytes": 20195052,
"heapUsedBytes": 103677772,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 20.414,
"eventListeners": 2383,
"totalBlockingTimeMs": 93,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8189.606000000026,
"styleRecalcs": 252,
"styleRecalcDurationMs": 43.837999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3923.3320000000003,
"heapDeltaBytes": -44304,
"heapUsedBytes": 80236420,
"domNodes": -239,
"jsHeapTotalBytes": 741376,
"scriptDurationMs": 1955.394,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8123.467000000005,
"styleRecalcs": 250,
"styleRecalcDurationMs": 23.56,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3739.2299999999996,
"heapDeltaBytes": -2192612,
"heapUsedBytes": 85516928,
"domNodes": -239,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 1751.5409999999997,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11549.030000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10606.664999999999,
"heapDeltaBytes": -31503636,
"heapUsedBytes": 183215684,
"domNodes": -8062,
"jsHeapTotalBytes": -12390400,
"scriptDurationMs": 150.921,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 10954.307000000084,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9970.475,
"heapDeltaBytes": -22076224,
"heapUsedBytes": 191392908,
"domNodes": -8062,
"jsHeapTotalBytes": -13090816,
"scriptDurationMs": 138.12399999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13435.071999999991,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.81199999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12817.069,
"heapDeltaBytes": -51378740,
"heapUsedBytes": 191099060,
"domNodes": -8062,
"jsHeapTotalBytes": -16498688,
"scriptDurationMs": 639.718,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12939.226999999959,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.154,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12208.106000000002,
"heapDeltaBytes": -71978196,
"heapUsedBytes": 169491152,
"domNodes": -8062,
"jsHeapTotalBytes": -23007232,
"scriptDurationMs": 624.33,
"eventListeners": -14928,
"totalBlockingTimeMs": 10,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4110.329999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.41299999999999,
"layouts": 20,
"layoutDurationMs": 22.375000000000007,
"taskDurationMs": 3973.936,
"heapDeltaBytes": -44422728,
"heapUsedBytes": 196284796,
"domNodes": -8062,
"jsHeapTotalBytes": 12644352,
"scriptDurationMs": 68.64499999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3630.9009999999944,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.09900000000001,
"layouts": 20,
"layoutDurationMs": 20.598,
"taskDurationMs": 3481.819,
"heapDeltaBytes": -35650268,
"heapUsedBytes": 177422864,
"domNodes": -8062,
"jsHeapTotalBytes": 22036480,
"scriptDurationMs": 54.617000000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5545.521000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5197.515000000001,
"heapDeltaBytes": 1719320,
"heapUsedBytes": 189983728,
"domNodes": -1,
"jsHeapTotalBytes": -21757952,
"scriptDurationMs": 74.03700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5432.85800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5079.018,
"heapDeltaBytes": 11119828,
"heapUsedBytes": 195866156,
"domNodes": 0,
"jsHeapTotalBytes": -8650752,
"scriptDurationMs": 72.291,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 442.8100000000086,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.509,
"layouts": 5,
"layoutDurationMs": 1.8999999999999997,
"taskDurationMs": 101.657,
"heapDeltaBytes": 5300108,
"heapUsedBytes": 70865072,
"domNodes": 153,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.306999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 71.00000000002638,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.773000000000001,
"layouts": 3,
"layoutDurationMs": 1.1190000000000002,
"taskDurationMs": 53.806000000000004,
"heapDeltaBytes": 2993812,
"heapUsedBytes": 68670140,
"domNodes": 122,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.272999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #18812 +/- ##
=============================================
- Coverage 84.59% 84.58% -0.01%
=============================================
Files 2294 2294
Lines 131265 131266 +1
Branches 35425 35426 +1
=============================================
- Hits 111045 111037 -8
- Misses 19920 19929 +9
Partials 300 300
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Landing under Christian's backport merge grant (program/release-backport-authority.md; extended to the 1.55 trains by Christian on 2026-09-25). Reviewed as the carrier author, so this is an honest COMMENT — no self-approval is being manufactured.
Evidence at b16e8c4d748849a24862cb5584cf42bb5fab5a2e:
- required checks (
lint-and-format,test,e2e-status) green;Vercel – billing-web-testis red on every PR on this train, including the commit production is currently pinned to, and is not a required check - target-aware exact-head guard run (
scripts/check-merge-ready.sh ... --target-branch core/1.55); verdict recorded inreports/jobs/bp-1.md - focused suites green locally at this head with
NODE_OPTIONS=--no-experimental-webstorage - marker verified on the branch, not inferred from a clean cherry-pick
Backport of #18766 to
core/1.55. Original authorship and commit message preserved (cherry-pick of the squashed merge commit, not a re-authored patch).Why
Typing into any text widget while the agent panel is open garbles the text: the host echoes the user's own
set_widgetops back as whole-value doc frames that are stale by however many keystrokes are in flight, and replaying one deletes text under the cursor. Reported on prodcloud.comfy.orgby four users over ten days and hit the Silverside customer demo.core/1.55does not currently serve users (no 1.55 release exists on PyPI, and prod is pinned to acloud/1.54commit), but it is the next train — without this carrier both defects return the moment 1.55 ships.The automatic backport workflow ran on #18766 and failed with cherry-pick conflicts on all four targets, so this carrier is a hand cherry-pick.
Conflict resolution
browser_tests/tests/agent/agentConversationReplay.spec.ts— exists on this branch; the source PR'stest.fail()removal applied cleanly.browser_tests/tests/agent/agentCrdtReconcileOverwrite.spec.tsandagentWidgetTypingReconcile.spec.ts— modify/delete conflicts: these specs do not exist on any release branch. Kept the branch's state; no spec was deleted and none was newly introduced (verified withgit diff --diff-filter=D).graphMutations.test.ts— content conflict resolved by taking the incoming side (the source PR's unit tests; no same-named test exists on this branch).No package, lockfile, core-type or business-logic conflict arose; nothing was resolved creatively.
Marker evidence
skipStaleReconcileoccurrences insrc/workbench/extensions/agent/crdt/graphMutations.ts: 4 before → 5 after on this branch (5 onmain). The one added call site — the incrementalsetWidgetcase consulting the local-dirty guard — is the fix.Verification
pnpm test:unit src/workbench/extensions/agent/crdt/graphMutations.test.tsgreen on this branch (NODE_OPTIONS=--no-experimental-webstorage). Proved red-on-parent honestly rather than trusting a clean pick: reverting only thegraphMutations.tshunk and rerunning turns 4 tests red, including the PM-1191/PM-1697 keystroke-echo round trip.Carried by the in-app-agent program row
bp-1.