Skip to content

fix: gate Mixpanel and Customer.io user identification on store readiness (cloud/1.54) - #18694

Merged
christian-byrne merged 1 commit into
cloud/1.54from
fe-2909-cloud-1.54-telemetry-store-readiness
Sep 27, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
fe-2909-cloud-1.54-telemetry-store-readiness

Conversation

@mattmillerai

Copy link
Copy Markdown
Member

STACKED — merging lands on cloud/1.54 (release branch, no owning PR), NOT main

ELI-5

When the app starts, Mixpanel and Customer.io could try to find out "who is the current user" before the app's data stores were set up. When that happens, analytics can end up tagged to the wrong user or to no user at all. main already makes both providers wait until the stores are ready. This PR backports that wait to cloud/1.54.

Summary

Backports main's whenStoresReady() gate to MixpanelTelemetryProvider and CustomerIoTelemetryProvider on cloud/1.54. It completes the follow-up flagged in #18690, which added the storeReadiness mechanism here and gated PostHog.

Changes

  • What: Both provider sources are now byte-identical to origin/main.
    • Mixpanel: the loaded callback waits on whenStoresReady() before useCurrentUser().onUserResolved(...). Failures go to reportError with mixpanel_user_identification_failure.
    • Customer.io: the dynamic-import callback is now async and awaits whenStoresReady() before assigning this.analytics or calling useCurrentUser(). The in-app-plugin registration .catch moves inline and now reports via reportError (customerio_in_app_plugin_registration_failure) instead of console.error, matching main.
  • Tests:
    • Adds one regression test per provider: with Pinia detached and markStoresPending(), the provider does not wire onUserResolved until markStoresReady() is called. Both tests fail against the old sources and pass with this change.
    • Updates the Customer.io in-app-failure test to assert reportError instead of console.error.
    • The existing Mixpanel identify test now uses vi.waitFor, because wiring is one microtask later.

Review Focus

  • Customer.io: this.analytics is now assigned after the await. While stores are pending, track* calls go into the existing queue (flushQueue() runs after wiring), and page views stay gated on in-app registration as before.
  • Both files stay under providers/cloud/ and are only constructed on cloud builds. There is no OSS/desktop behavior change and no feature flag, because this restores main's existing gating.

Residual

  • Other telemetry modules on cloud/1.54 still use stores without the gate (swept src/platform/telemetry): SentryTelemetryProvider.ts, SyftTelemetryProvider.ts, ImpactTelemetryProvider.ts, hostUserIdSync.ts, utils/getExecutionContext.ts, utils/getShellLayoutSnapshot.ts. None of them are gated on main either (main's only whenStoresReady callers are PostHog, Mixpanel and Customer.io), so this PR leaves them alone. Whether any of them has the same race is unverified and would need its own look, on main first.
  • Tree-shaking not verified: I did not run a non-cloud production build to confirm both files are tree-shaken out. This PR does not change their import sites, so it is the same as before.
  • Not exercised end to end: the change was verified only with unit tests. I did not test the startup race in a deployed cloud build. Unlike the PostHog case, this gap had no known user-facing symptom to reproduce.
  • Source threads not read: the internal chat threads that led to this follow-up were not readable from the worker environment. The work is based on the fix: gate PostHog user identification on store readiness #18690 PR body and a direct comparison of main and cloud/1.54.

Provenance

  • Authored by: agent-work loop
  • Verified: vitest src/platform/telemetry: 33 files, 450 passed, 0 failed. Red check: the 2 new tests plus the updated Customer.io test fail against the old sources (3 failed). pnpm typecheck clean. pnpm knip clean. eslint + oxlint + oxfmt on changed files clean. git diff origin/main on both provider sources is empty.
  • Deviations: none from main's source. The tests keep cloud/1.54's existing mock style instead of copying main's test rewrite (which relies on auto-mocks this branch does not have) and add the readiness regression tests main lacks.

🤖 Generated with Claude Code

…ness

Port main's whenStoresReady() guard to the Mixpanel and Customer.io
telemetry providers on cloud/1.54, matching the PostHog fix in #18690.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mattmillerai mattmillerai added agent-coded Opened by the agent-work code loop cursor-review Trigger multi-model Cursor agent review on this PR labels Sep 24, 2026
@vercel

vercel Bot commented Sep 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 24, 2026 6:42am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 24, 2026 6:42am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 3f227e72-77c5-4c84-8823-373f08e5e984

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/24/2026, 06:44:31 AM UTC

Links

🎭 Playwright: ✅ 1951 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1930 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 75ms TBT · 102.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 174.1 MB heap
vue-large-graph-pan: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.6 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 21ms TBT · 165.2 MB heap
vue-zoom-out-idle: · 59.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 182.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 316ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 64.8 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -178
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 22ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 570ms
canvas-mouse-sweep: script duration 100ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.9 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -179
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 266ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.3 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 286ms
dom-widget-clipping: script duration 98ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.3 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 421ms
large-graph-idle: script duration 29ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.3 MB
large-graph-idle: DOM nodes -271
large-graph-idle: event listeners -191
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1128ms
large-graph-pan: script duration 546ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.7 MB
large-graph-pan: DOM nodes -119
large-graph-pan: event listeners -92
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 16ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 67
large-graph-zoom: task duration 1252ms
large-graph-zoom: script duration 522ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 85.5 MB
large-graph-zoom: DOM nodes -286
large-graph-zoom: event listeners -194
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1290ms
legacy-node-drag: script duration 628ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 79.8 MB
legacy-node-drag: DOM nodes 8
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 419ms
minimap-idle: script duration 27ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.6 MB
minimap-idle: DOM nodes -131
minimap-idle: event listeners -94
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 286ms
subgraph-dom-widget-clipping: script duration 94ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.0 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 302ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 65.5 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -238
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 22ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 544ms
subgraph-mouse-sweep: script duration 76ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 66.5 MB
subgraph-mouse-sweep: DOM nodes -294
subgraph-mouse-sweep: event listeners -225
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 22ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 575ms
subgraph-transition-enter: script duration 19ms
subgraph-transition-enter: TBT 75ms
subgraph-transition-enter: heap used 102.6 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 43ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4215ms
viewport-pan-sweep: script duration 1894ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.0 MB
viewport-pan-sweep: DOM nodes -268
viewport-pan-sweep: event listeners -159
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11854ms
vue-large-graph-idle: script duration 179ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 174.1 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14934
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 13ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 72
vue-large-graph-pan: task duration 13821ms
vue-large-graph-pan: script duration 610ms
vue-large-graph-pan: TBT 0ms
vue-large-graph-pan: heap used 167.6 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14931
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 52ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4255ms
vue-node-resize-workload: script duration 67ms
vue-node-resize-workload: TBT 21ms
vue-node-resize-workload: heap used 165.2 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14931
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5450ms
vue-zoom-out-idle: script duration 73ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 182.2 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 4
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 9ms
workflow-execution: layout count 2
workflow-execution: style recalc count 6
workflow-execution: task duration 49ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.6 MB
workflow-execution: DOM nodes 124
workflow-execution: event listeners 17
Raw data
{
  "timestamp": "2026-09-24T06:51:29.296Z",
  "gitSha": "7015deb2a3609c0e8a4f53cd233d7efac256b4a9",
  "branch": "fe-2909-cloud-1.54-telemetry-store-readiness",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2004.9510000000055,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.273999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 334.675,
      "heapDeltaBytes": -10117732,
      "heapUsedBytes": 59714172,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.680999999999998,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2007.396999999969,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.2059999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 297.926,
      "heapDeltaBytes": 6463700,
      "heapUsedBytes": 76173368,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 6.437000000000002,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1702.6299999999992,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 23.706999999999997,
      "layouts": 14,
      "layoutDurationMs": 3.7250000000000005,
      "taskDurationMs": 599.337,
      "heapDeltaBytes": -3424152,
      "heapUsedBytes": 66881584,
      "domNodes": -278,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 102.707,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1711.0739999999396,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 21.246000000000002,
      "layouts": 14,
      "layoutDurationMs": 3.633,
      "taskDurationMs": 539.941,
      "heapDeltaBytes": 2880696,
      "heapUsedBytes": 67171520,
      "domNodes": -284,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 97.274,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1657.1250000000646,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.303000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.0070000000000001,
      "taskDurationMs": 263.18199999999996,
      "heapDeltaBytes": 4522880,
      "heapUsedBytes": 75366356,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.264999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1687.7170000000206,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.729000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.069,
      "taskDurationMs": 269.32599999999996,
      "heapDeltaBytes": 4498288,
      "heapUsedBytes": 74195300,
      "domNodes": 77,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 12.231,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 431.70599999996284,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.587999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 289.32199999999995,
      "heapDeltaBytes": 18103868,
      "heapUsedBytes": 88297608,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 99.853,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 446.7299999998886,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.218999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 281.96900000000005,
      "heapDeltaBytes": 18031632,
      "heapUsedBytes": 88396416,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 96.147,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2043.4940000000097,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.542,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.96600000000007,
      "heapDeltaBytes": 6873884,
      "heapUsedBytes": 83234148,
      "domNodes": -274,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 31.217999999999996,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.7850000000044,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.890999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 375.28299999999996,
      "heapDeltaBytes": 10814172,
      "heapUsedBytes": 87177268,
      "domNodes": -268,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 27.268,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2419.443000000001,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.386,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1123.408,
      "heapDeltaBytes": 26868376,
      "heapUsedBytes": 93190432,
      "domNodes": 10,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 537.556,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2220.3810000000885,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.336999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1132.767,
      "heapDeltaBytes": 6780072,
      "heapUsedBytes": 84348992,
      "domNodes": -247,
      "jsHeapTotalBytes": -139264,
      "scriptDurationMs": 553.573,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3502.6340000000005,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 16.188000000000002,
      "layouts": 60,
      "layoutDurationMs": 13.567,
      "taskDurationMs": 1279.297,
      "heapDeltaBytes": 14764744,
      "heapUsedBytes": 93860516,
      "domNodes": -287,
      "jsHeapTotalBytes": 3567616,
      "scriptDurationMs": 536.312,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3372.0120000000406,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 15.845,
      "layouts": 60,
      "layoutDurationMs": 13.126,
      "taskDurationMs": 1224.388,
      "heapDeltaBytes": 7013416,
      "heapUsedBytes": 85541596,
      "domNodes": -284,
      "jsHeapTotalBytes": 4878336,
      "scriptDurationMs": 507.0060000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2377.615999999989,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 7.975000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1303.593,
      "heapDeltaBytes": 17529932,
      "heapUsedBytes": 85042164,
      "domNodes": 8,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 630.427,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2314.12899999998,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 7.9330000000000025,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1276.297,
      "heapDeltaBytes": 14148300,
      "heapUsedBytes": 82232304,
      "domNodes": 8,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 626.451,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2023.415,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.2700000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.7830000000001,
      "heapDeltaBytes": 9395108,
      "heapUsedBytes": 87677532,
      "domNodes": -269,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 26.230000000000004,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 1992.497999999955,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 2.645999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 421.888,
      "heapDeltaBytes": 21775380,
      "heapUsedBytes": 87574392,
      "domNodes": 8,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 27.812000000000005,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 460.52099999997154,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 10.378000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 294.832,
      "heapDeltaBytes": 15019604,
      "heapUsedBytes": 87921728,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 95.18,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 429.36199999996916,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.286000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 277.204,
      "heapDeltaBytes": 14673112,
      "heapUsedBytes": 88254716,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 92.28999999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2010.1659999999697,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.0649999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 299.992,
      "heapDeltaBytes": -4331756,
      "heapUsedBytes": 69011548,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 6.465,
      "eventListeners": -238,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1994.0579999999954,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.533000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 303.25100000000003,
      "heapDeltaBytes": -4966940,
      "heapUsedBytes": 68389232,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 6.3660000000000005,
      "eventListeners": -238,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1689.596999999992,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 20.985999999999997,
      "layouts": 18,
      "layoutDurationMs": 4.116,
      "taskDurationMs": 530.092,
      "heapDeltaBytes": -10546684,
      "heapUsedBytes": 61537652,
      "domNodes": -294,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 74.95700000000001,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.802999999899,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 23.467,
      "layouts": 18,
      "layoutDurationMs": 4.383000000000001,
      "taskDurationMs": 557.334,
      "heapDeltaBytes": 4861532,
      "heapUsedBytes": 77869440,
      "domNodes": -294,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 78.00500000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 833.389000000011,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 22.182,
      "layouts": 17,
      "layoutDurationMs": 11.017000000000001,
      "taskDurationMs": 574.676,
      "heapDeltaBytes": 23748084,
      "heapUsedBytes": 107543576,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 19.383,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 75,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8835.053000000016,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 43.018,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4239.6269999999995,
      "heapDeltaBytes": 5535300,
      "heapUsedBytes": 81960292,
      "domNodes": -268,
      "jsHeapTotalBytes": 385024,
      "scriptDurationMs": 1917.4679999999998,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8962.184999999976,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 43.187999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4190.562,
      "heapDeltaBytes": -9430680,
      "heapUsedBytes": 94184572,
      "domNodes": -267,
      "jsHeapTotalBytes": -888832,
      "scriptDurationMs": 1869.9519999999998,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12534.779999999955,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11827.383000000002,
      "heapDeltaBytes": -50199160,
      "heapUsedBytes": 183933048,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9375744,
      "scriptDurationMs": 171.32599999999996,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12467.999000000076,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11879.949999999999,
      "heapDeltaBytes": -37613556,
      "heapUsedBytes": 181243128,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9449472,
      "scriptDurationMs": 187.07600000000002,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14431.655999999975,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 13.321,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13962.605,
      "heapDeltaBytes": -39435684,
      "heapUsedBytes": 165975188,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13627392,
      "scriptDurationMs": 625.485,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14185.075999999981,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 12.240999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13680.123000000001,
      "heapDeltaBytes": -27205284,
      "heapUsedBytes": 185418072,
      "domNodes": -8068,
      "jsHeapTotalBytes": -20652032,
      "scriptDurationMs": 593.72,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4393.165999999951,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 50.41299999999998,
      "layouts": 20,
      "layoutDurationMs": 20.369999999999997,
      "taskDurationMs": 4279.794000000001,
      "heapDeltaBytes": -38504944,
      "heapUsedBytes": 181100128,
      "domNodes": -8068,
      "jsHeapTotalBytes": 14983168,
      "scriptDurationMs": 66.63199999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 9,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4314.883000000009,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 52.90800000000001,
      "layouts": 20,
      "layoutDurationMs": 21.099000000000007,
      "taskDurationMs": 4230.8679999999995,
      "heapDeltaBytes": -52823336,
      "heapUsedBytes": 165362220,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12587008,
      "scriptDurationMs": 66.99699999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 32,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6132.64700000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5696.838,
      "heapDeltaBytes": 16046220,
      "heapUsedBytes": 201960032,
      "domNodes": 0,
      "jsHeapTotalBytes": -49020928,
      "scriptDurationMs": 79.78299999999999,
      "eventListeners": 16,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5480.566000000067,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5203.7,
      "heapDeltaBytes": 13130920,
      "heapUsedBytes": 180127556,
      "domNodes": 0,
      "jsHeapTotalBytes": -17825792,
      "scriptDurationMs": 66.86899999999996,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 72.93200000003708,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 9.058,
      "layouts": 2,
      "layoutDurationMs": 0.973,
      "taskDurationMs": 50.86,
      "heapDeltaBytes": 3002476,
      "heapUsedBytes": 72220052,
      "domNodes": 125,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 7.716000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 67.0029999999997,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 9.493000000000002,
      "layouts": 2,
      "layoutDurationMs": 1.15,
      "taskDurationMs": 47.681000000000004,
      "heapDeltaBytes": 3099320,
      "heapUsedBytes": 71571380,
      "domNodes": 122,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.4190000000000005,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50592 75749 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @mattmillerai.

Found 4 finding(s).

Severity Count
🟠 High 1
🟡 Medium 1
🟢 Low 2

Panel: 8/8 reviewers contributed findings.

)
this.analytics = analytics

await whenStoresReady()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — await whenStoresReady() was placed before this.analytics = analytics and void this.flushQueue(), so the entire event pipeline — not just user identification — is now gated on Pinia: until the gate opens every event goes to the uncapped eventQueue, and because the gate has no timeout and cannot reject, a boot failure between markStoresPending() and markStoresReady() buffers events for the whole session with no error ever surfaced. The Mixpanel change in this same diff gets this right — it flushes first and defers only onUserResolved behind the gate. Move the assignment and the flush above the await, and/or bound the wait.

Raised by 6 of 8 reviewers (gemini-3.1-pro adversarial, gemini-3.1-pro edge-case, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).

})
})
.catch((error) => {
console.error('Failed to load Customer.io:', error)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Making the .then callback async widens this .catch to cover everything after the await, so a throw from useCurrentUser() or the watch() registration now sets isEnabled = false and discards this.eventQueue under the misleading message "Failed to load Customer.io". This handler also stays on bare console.error while the far less severe in-app-plugin failure was upgraded to reportError in this same diff, leaving the path that disables the provider entirely invisible in Sentry/Datadog.

Raised by 3 of 8 reviewers (kimi-k3-max adversarial, kimi-k3-max edge-case, claude-opus-5-thinking-max edge-case).

this.isPageViewTrackingReady = true
this.flushPageView()
})
void inAppRegistration.finally(() => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — The .finally() that sets isPageViewTrackingReady and flushes the queued page view is now attached only after await whenStoresReady(), even though page-view flushing touches no store. That widens the window in which successive trackPageView() calls collapse into the single pageViewQueued boolean, and no page view is ever sent if the gate never opens; attaching the .finally() before the await preserves the previous behaviour.

Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

}
})
})
.catch((error) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — whenStoresReady() has no timeout and never rejects, so this .catch can only fire on a synchronous useCurrentUser() throw — the very failure this deferral guards against (stores never becoming ready) leaves the .then pending forever, so signed-in users are silently never identify'd and every event stays on the anonymous distinct id with nothing reported. Racing the gate against a deadline and reporting on expiry would make a stalled boot visible instead of indistinguishable from a healthy session.

Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...metry/providers/cloud/MixpanelTelemetryProvider.ts 71.42% 2 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18694   +/-   ##
=============================================
  Coverage              ?   83.80%           
=============================================
  Files                 ?     2113           
  Lines                 ?   125625           
  Branches              ?    34007           
=============================================
  Hits                  ?   105278           
  Misses                ?    20168           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.79% <ø> (?)
unit 78.86% <87.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...try/providers/cloud/CustomerIoTelemetryProvider.ts 99.31% <100.00%> (ø)
...metry/providers/cloud/MixpanelTelemetryProvider.ts 80.24% <71.42%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

christian-byrne added a commit that referenced this pull request Sep 25, 2026
…nutes (#18852)

## Summary

Backport of
[#17398](#17398)
(`21750678e3`) — raises the `playwright-tests` job timeout from 15 to 30
minutes. `cloud/1.54` never received it because the branch was cut four
days before it landed.

## Changes

- **What**: `timeout-minutes: 15` -> `30` on the `playwright-tests` job.
Two lines, clean cherry-pick, workflow-only.
- **Breaking**: none.

## Review Focus

**Why this branch is missing the fix.** `cloud/1.54` and `core/1.54`
were both cut from `main` at `a15c5351b` on 2026-09-07. #17398 merged on
2026-09-11. `core/1.55` and `cloud/1.55` were cut 2026-09-23 and do
carry it. The 1.54 pair are the only active branches still at 15
minutes, purely by cut date.

**This branch has the same exposure.** `playwright-tests (cloud)` on
[#18694](#18694 run
[35965823183](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35965823183)
took **708s — 79% of the 900s cap** on a passing run. Its sibling branch
`core/1.54` sits in the same 62-78% band and has already lost a PR to
this: [#18512](#18512)
is blocked on required check `e2e-status` because the cloud job is
cancelled at 15m07s, twice, with no blob report and therefore no
test-level verdict.

A cancelled required check reads as a real test failure. With ~3 minutes
of slack and 1-2 ordinarily-flaky tests per run under `retries: 3`, one
bad burst is enough. Pre-empting it here rather than after it blocks an
agent backport on this branch too.

**Note for whoever approves:** `backport-auto-merge.yaml` merges
`backport`-labelled PRs on approval once required checks are green, so
approving this is merging it.

**Companions:**
[#18851](#18851) is
the same backport to `core/1.54`.
[#18850](#18850)
shards the cloud project on `main`, where the job is now at 20.3 of its
30 minutes and growing ~1.3 min/day — so the timeout does not need
raising a third time.
christian-byrne added a commit that referenced this pull request Sep 25, 2026
…utes (#18851)

## Summary

Backport of
[#17398](#17398)
(`21750678e3`) — raises the `playwright-tests` job timeout from 15 to 30
minutes. `core/1.54` never received it because the branch was cut four
days before it landed.

## Changes

- **What**: `timeout-minutes: 15` -> `30` on the `playwright-tests` job.
Two lines, clean cherry-pick, workflow-only.
- **Breaking**: none.

## Review Focus

**Why this branch is missing the fix.** `core/1.54` and `cloud/1.54`
were both cut from `main` at `a15c5351b` on 2026-09-07. #17398 merged on
2026-09-11. `core/1.55` and `cloud/1.55` were cut 2026-09-23 and do
carry it. So the 1.54 pair are the only active branches still at 15
minutes, purely by cut date — not by decision.

**The branch has no usable slack at 15 minutes.** `playwright-tests
(cloud)` on recent `core/1.54` runs:

| run | cloud job | % of the 900s cap |
|---|---|---|
|
[36062187628](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36062187628)
| 701s | 78% |
|
[36127290454](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36127290454)
| 697s | 77% |
|
[36117634179](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36117634179)
| 623s | 69% |
|
[36119756279](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36119756279)
| 615s | 68% |
|
[36130212622](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36130212622)
| 561s | 62% |

That is 62-78% consumed on a *passing* run, leaving roughly three
minutes of headroom. Those same passing runs each carry 1-2 flaky tests
that recover on retry, which is normal — but with `retries: 3` and a 15s
per-test timeout, one bad burst costs more than the remaining slack. The
result is a **cancelled** job, and a cancelled required check is
indistinguishable from a real test failure to anyone reading the PR.

**What it is blocking now.**
[#18512](#18512) — the
last carrier in a merged chain of user-visible agent fixes — is stuck on
required check `e2e-status` for exactly this. Its run
[36126194869](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36126194869)
was killed at 15m07s with 181 of 233 results emitted and no blob report
written, so there is no test-level verdict at all. Re-running was tried
twice and failed identically. Every other matrix job in that run passed
in 157-218s; only `cloud` died.

This is not one PR's problem: any `core/1.54` PR that adds a `@cloud`
test hits the same wall.

**Note for whoever approves:** `backport-auto-merge.yaml` merges
`backport`-labelled PRs on approval once required checks are green, so
approving this is merging it.

**Related, not included here:** `cloud/1.54` has the identical gap and
the same exposure (708s = 79% of cap on
[#18694](#18694
run) — see the companion backport. And on `main`, where this job is now
at 20.3 of its 30 minutes and growing,
[#18850](#18850)
shards the cloud project so the timeout does not need raising a third
time.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the description's central claim rather than taking it: both provider sources on this branch are byte-identical to origin/main — MixpanelTelemetryProvider.ts and CustomerIoTelemetryProvider.ts hash the same as main's. No conflict markers in the diff, and the only other changes are the two matching test files. All three required checks green.

@christian-byrne
christian-byrne merged commit c422771 into cloud/1.54 Sep 27, 2026
134 of 146 checks passed
@christian-byrne
christian-byrne deleted the fe-2909-cloud-1.54-telemetry-store-readiness branch September 27, 2026 06:01

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — be7ac8c7 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-coded Opened by the agent-work code loop cursor-review Trigger multi-model Cursor agent review on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants