Repository navigation
fix: gate Mixpanel and Customer.io user identification on store readiness (cloud/1.54) - #18694
Conversation
…ness Port main's whenStoresReady() guard to the Mixpanel and Customer.io telemetry providers on cloud/1.54, matching the PostHog fix in #18690. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1951 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-24T06:51:29.296Z",
"gitSha": "7015deb2a3609c0e8a4f53cd233d7efac256b4a9",
"branch": "fe-2909-cloud-1.54-telemetry-store-readiness",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2004.9510000000055,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.273999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.675,
"heapDeltaBytes": -10117732,
"heapUsedBytes": 59714172,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.680999999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2007.396999999969,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.2059999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.926,
"heapDeltaBytes": 6463700,
"heapUsedBytes": 76173368,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.437000000000002,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1702.6299999999992,
"styleRecalcs": 75,
"styleRecalcDurationMs": 23.706999999999997,
"layouts": 14,
"layoutDurationMs": 3.7250000000000005,
"taskDurationMs": 599.337,
"heapDeltaBytes": -3424152,
"heapUsedBytes": 66881584,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 102.707,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.0739999999396,
"styleRecalcs": 72,
"styleRecalcDurationMs": 21.246000000000002,
"layouts": 14,
"layoutDurationMs": 3.633,
"taskDurationMs": 539.941,
"heapDeltaBytes": 2880696,
"heapUsedBytes": 67171520,
"domNodes": -284,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 97.274,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1657.1250000000646,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.303000000000003,
"layouts": 6,
"layoutDurationMs": 1.0070000000000001,
"taskDurationMs": 263.18199999999996,
"heapDeltaBytes": 4522880,
"heapUsedBytes": 75366356,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.264999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1687.7170000000206,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.729000000000003,
"layouts": 6,
"layoutDurationMs": 1.069,
"taskDurationMs": 269.32599999999996,
"heapDeltaBytes": 4498288,
"heapUsedBytes": 74195300,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.231,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 431.70599999996284,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.587999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.32199999999995,
"heapDeltaBytes": 18103868,
"heapUsedBytes": 88297608,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 99.853,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 446.7299999998886,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.218999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 281.96900000000005,
"heapDeltaBytes": 18031632,
"heapUsedBytes": 88396416,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 96.147,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2043.4940000000097,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.542,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.96600000000007,
"heapDeltaBytes": 6873884,
"heapUsedBytes": 83234148,
"domNodes": -274,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 31.217999999999996,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.7850000000044,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.890999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.28299999999996,
"heapDeltaBytes": 10814172,
"heapUsedBytes": 87177268,
"domNodes": -268,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 27.268,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2419.443000000001,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.386,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1123.408,
"heapDeltaBytes": 26868376,
"heapUsedBytes": 93190432,
"domNodes": 10,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 537.556,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2220.3810000000885,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.336999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1132.767,
"heapDeltaBytes": 6780072,
"heapUsedBytes": 84348992,
"domNodes": -247,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 553.573,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3502.6340000000005,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.188000000000002,
"layouts": 60,
"layoutDurationMs": 13.567,
"taskDurationMs": 1279.297,
"heapDeltaBytes": 14764744,
"heapUsedBytes": 93860516,
"domNodes": -287,
"jsHeapTotalBytes": 3567616,
"scriptDurationMs": 536.312,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3372.0120000000406,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.845,
"layouts": 60,
"layoutDurationMs": 13.126,
"taskDurationMs": 1224.388,
"heapDeltaBytes": 7013416,
"heapUsedBytes": 85541596,
"domNodes": -284,
"jsHeapTotalBytes": 4878336,
"scriptDurationMs": 507.0060000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2377.615999999989,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.975000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1303.593,
"heapDeltaBytes": 17529932,
"heapUsedBytes": 85042164,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 630.427,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2314.12899999998,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.9330000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1276.297,
"heapDeltaBytes": 14148300,
"heapUsedBytes": 82232304,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 626.451,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2023.415,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.2700000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.7830000000001,
"heapDeltaBytes": 9395108,
"heapUsedBytes": 87677532,
"domNodes": -269,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 26.230000000000004,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1992.497999999955,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.645999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.888,
"heapDeltaBytes": 21775380,
"heapUsedBytes": 87574392,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.812000000000005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 460.52099999997154,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.378000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.832,
"heapDeltaBytes": 15019604,
"heapUsedBytes": 87921728,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 95.18,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 429.36199999996916,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.286000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.204,
"heapDeltaBytes": 14673112,
"heapUsedBytes": 88254716,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 92.28999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2010.1659999999697,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.0649999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 299.992,
"heapDeltaBytes": -4331756,
"heapUsedBytes": 69011548,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.465,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1994.0579999999954,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.533000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.25100000000003,
"heapDeltaBytes": -4966940,
"heapUsedBytes": 68389232,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.3660000000000005,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.596999999992,
"styleRecalcs": 79,
"styleRecalcDurationMs": 20.985999999999997,
"layouts": 18,
"layoutDurationMs": 4.116,
"taskDurationMs": 530.092,
"heapDeltaBytes": -10546684,
"heapUsedBytes": 61537652,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 74.95700000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.802999999899,
"styleRecalcs": 79,
"styleRecalcDurationMs": 23.467,
"layouts": 18,
"layoutDurationMs": 4.383000000000001,
"taskDurationMs": 557.334,
"heapDeltaBytes": 4861532,
"heapUsedBytes": 77869440,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 78.00500000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 833.389000000011,
"styleRecalcs": 21,
"styleRecalcDurationMs": 22.182,
"layouts": 17,
"layoutDurationMs": 11.017000000000001,
"taskDurationMs": 574.676,
"heapDeltaBytes": 23748084,
"heapUsedBytes": 107543576,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 19.383,
"eventListeners": 2385,
"totalBlockingTimeMs": 75,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8835.053000000016,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4239.6269999999995,
"heapDeltaBytes": 5535300,
"heapUsedBytes": 81960292,
"domNodes": -268,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 1917.4679999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8962.184999999976,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.187999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4190.562,
"heapDeltaBytes": -9430680,
"heapUsedBytes": 94184572,
"domNodes": -267,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 1869.9519999999998,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12534.779999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11827.383000000002,
"heapDeltaBytes": -50199160,
"heapUsedBytes": 183933048,
"domNodes": -8068,
"jsHeapTotalBytes": -9375744,
"scriptDurationMs": 171.32599999999996,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12467.999000000076,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11879.949999999999,
"heapDeltaBytes": -37613556,
"heapUsedBytes": 181243128,
"domNodes": -8068,
"jsHeapTotalBytes": -9449472,
"scriptDurationMs": 187.07600000000002,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14431.655999999975,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.321,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13962.605,
"heapDeltaBytes": -39435684,
"heapUsedBytes": 165975188,
"domNodes": -8068,
"jsHeapTotalBytes": -13627392,
"scriptDurationMs": 625.485,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14185.075999999981,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.240999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13680.123000000001,
"heapDeltaBytes": -27205284,
"heapUsedBytes": 185418072,
"domNodes": -8068,
"jsHeapTotalBytes": -20652032,
"scriptDurationMs": 593.72,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4393.165999999951,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.41299999999998,
"layouts": 20,
"layoutDurationMs": 20.369999999999997,
"taskDurationMs": 4279.794000000001,
"heapDeltaBytes": -38504944,
"heapUsedBytes": 181100128,
"domNodes": -8068,
"jsHeapTotalBytes": 14983168,
"scriptDurationMs": 66.63199999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4314.883000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.90800000000001,
"layouts": 20,
"layoutDurationMs": 21.099000000000007,
"taskDurationMs": 4230.8679999999995,
"heapDeltaBytes": -52823336,
"heapUsedBytes": 165362220,
"domNodes": -8068,
"jsHeapTotalBytes": 12587008,
"scriptDurationMs": 66.99699999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6132.64700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5696.838,
"heapDeltaBytes": 16046220,
"heapUsedBytes": 201960032,
"domNodes": 0,
"jsHeapTotalBytes": -49020928,
"scriptDurationMs": 79.78299999999999,
"eventListeners": 16,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5480.566000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5203.7,
"heapDeltaBytes": 13130920,
"heapUsedBytes": 180127556,
"domNodes": 0,
"jsHeapTotalBytes": -17825792,
"scriptDurationMs": 66.86899999999996,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 72.93200000003708,
"styleRecalcs": 5,
"styleRecalcDurationMs": 9.058,
"layouts": 2,
"layoutDurationMs": 0.973,
"taskDurationMs": 50.86,
"heapDeltaBytes": 3002476,
"heapUsedBytes": 72220052,
"domNodes": 125,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 7.716000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 67.0029999999997,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.493000000000002,
"layouts": 2,
"layoutDurationMs": 1.15,
"taskDurationMs": 47.681000000000004,
"heapDeltaBytes": 3099320,
"heapUsedBytes": 71571380,
"domNodes": 122,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.4190000000000005,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
| ) | ||
| this.analytics = analytics | ||
|
|
||
| await whenStoresReady() |
There was a problem hiding this comment.
🟠 High — await whenStoresReady() was placed before this.analytics = analytics and void this.flushQueue(), so the entire event pipeline — not just user identification — is now gated on Pinia: until the gate opens every event goes to the uncapped eventQueue, and because the gate has no timeout and cannot reject, a boot failure between markStoresPending() and markStoresReady() buffers events for the whole session with no error ever surfaced. The Mixpanel change in this same diff gets this right — it flushes first and defers only onUserResolved behind the gate. Move the assignment and the flush above the await, and/or bound the wait.
Raised by 6 of 8 reviewers (gemini-3.1-pro adversarial, gemini-3.1-pro edge-case, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).
| }) | ||
| }) | ||
| .catch((error) => { | ||
| console.error('Failed to load Customer.io:', error) |
There was a problem hiding this comment.
🟡 Medium — Making the .then callback async widens this .catch to cover everything after the await, so a throw from useCurrentUser() or the watch() registration now sets isEnabled = false and discards this.eventQueue under the misleading message "Failed to load Customer.io". This handler also stays on bare console.error while the far less severe in-app-plugin failure was upgraded to reportError in this same diff, leaving the path that disables the provider entirely invisible in Sentry/Datadog.
Raised by 3 of 8 reviewers (kimi-k3-max adversarial, kimi-k3-max edge-case, claude-opus-5-thinking-max edge-case).
| this.isPageViewTrackingReady = true | ||
| this.flushPageView() | ||
| }) | ||
| void inAppRegistration.finally(() => { |
There was a problem hiding this comment.
🟢 Low — The .finally() that sets isPageViewTrackingReady and flushes the queued page view is now attached only after await whenStoresReady(), even though page-view flushing touches no store. That widens the window in which successive trackPageView() calls collapse into the single pageViewQueued boolean, and no page view is ever sent if the gate never opens; attaching the .finally() before the await preserves the previous behaviour.
Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| } | ||
| }) | ||
| }) | ||
| .catch((error) => { |
There was a problem hiding this comment.
🟢 Low — whenStoresReady() has no timeout and never rejects, so this .catch can only fire on a synchronous useCurrentUser() throw — the very failure this deferral guards against (stores never becoming ready) leaves the .then pending forever, so signed-in users are silently never identify'd and every event stays on the anonymous distinct id with nothing reported. Racing the gate against a deadline and reporting on expiry would make a stalled boot visible instead of indistinguishable from a healthy session.
Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #18694 +/- ##
=============================================
Coverage ? 83.80%
=============================================
Files ? 2113
Lines ? 125625
Branches ? 34007
=============================================
Hits ? 105278
Misses ? 20168
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…nutes (#18852) ## Summary Backport of [#17398](#17398) (`21750678e3`) — raises the `playwright-tests` job timeout from 15 to 30 minutes. `cloud/1.54` never received it because the branch was cut four days before it landed. ## Changes - **What**: `timeout-minutes: 15` -> `30` on the `playwright-tests` job. Two lines, clean cherry-pick, workflow-only. - **Breaking**: none. ## Review Focus **Why this branch is missing the fix.** `cloud/1.54` and `core/1.54` were both cut from `main` at `a15c5351b` on 2026-09-07. #17398 merged on 2026-09-11. `core/1.55` and `cloud/1.55` were cut 2026-09-23 and do carry it. The 1.54 pair are the only active branches still at 15 minutes, purely by cut date. **This branch has the same exposure.** `playwright-tests (cloud)` on [#18694](#18694 run [35965823183](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35965823183) took **708s — 79% of the 900s cap** on a passing run. Its sibling branch `core/1.54` sits in the same 62-78% band and has already lost a PR to this: [#18512](#18512) is blocked on required check `e2e-status` because the cloud job is cancelled at 15m07s, twice, with no blob report and therefore no test-level verdict. A cancelled required check reads as a real test failure. With ~3 minutes of slack and 1-2 ordinarily-flaky tests per run under `retries: 3`, one bad burst is enough. Pre-empting it here rather than after it blocks an agent backport on this branch too. **Note for whoever approves:** `backport-auto-merge.yaml` merges `backport`-labelled PRs on approval once required checks are green, so approving this is merging it. **Companions:** [#18851](#18851) is the same backport to `core/1.54`. [#18850](#18850) shards the cloud project on `main`, where the job is now at 20.3 of its 30 minutes and growing ~1.3 min/day — so the timeout does not need raising a third time.
…utes (#18851) ## Summary Backport of [#17398](#17398) (`21750678e3`) — raises the `playwright-tests` job timeout from 15 to 30 minutes. `core/1.54` never received it because the branch was cut four days before it landed. ## Changes - **What**: `timeout-minutes: 15` -> `30` on the `playwright-tests` job. Two lines, clean cherry-pick, workflow-only. - **Breaking**: none. ## Review Focus **Why this branch is missing the fix.** `core/1.54` and `cloud/1.54` were both cut from `main` at `a15c5351b` on 2026-09-07. #17398 merged on 2026-09-11. `core/1.55` and `cloud/1.55` were cut 2026-09-23 and do carry it. So the 1.54 pair are the only active branches still at 15 minutes, purely by cut date — not by decision. **The branch has no usable slack at 15 minutes.** `playwright-tests (cloud)` on recent `core/1.54` runs: | run | cloud job | % of the 900s cap | |---|---|---| | [36062187628](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36062187628) | 701s | 78% | | [36127290454](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36127290454) | 697s | 77% | | [36117634179](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36117634179) | 623s | 69% | | [36119756279](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36119756279) | 615s | 68% | | [36130212622](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36130212622) | 561s | 62% | That is 62-78% consumed on a *passing* run, leaving roughly three minutes of headroom. Those same passing runs each carry 1-2 flaky tests that recover on retry, which is normal — but with `retries: 3` and a 15s per-test timeout, one bad burst costs more than the remaining slack. The result is a **cancelled** job, and a cancelled required check is indistinguishable from a real test failure to anyone reading the PR. **What it is blocking now.** [#18512](#18512) — the last carrier in a merged chain of user-visible agent fixes — is stuck on required check `e2e-status` for exactly this. Its run [36126194869](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36126194869) was killed at 15m07s with 181 of 233 results emitted and no blob report written, so there is no test-level verdict at all. Re-running was tried twice and failed identically. Every other matrix job in that run passed in 157-218s; only `cloud` died. This is not one PR's problem: any `core/1.54` PR that adds a `@cloud` test hits the same wall. **Note for whoever approves:** `backport-auto-merge.yaml` merges `backport`-labelled PRs on approval once required checks are green, so approving this is merging it. **Related, not included here:** `cloud/1.54` has the identical gap and the same exposure (708s = 79% of cap on [#18694](#18694 run) — see the companion backport. And on `main`, where this job is now at 20.3 of its 30 minutes and growing, [#18850](#18850) shards the cloud project so the timeout does not need raising a third time.
christian-byrne
left a comment
There was a problem hiding this comment.
Verified the description's central claim rather than taking it: both provider sources on this branch are byte-identical to origin/main — MixpanelTelemetryProvider.ts and CustomerIoTelemetryProvider.ts hash the same as main's. No conflict markers in the diff, and the only other changes are the two matching test files. All three required checks green.
STACKED — merging lands on cloud/1.54 (release branch, no owning PR), NOT main
ELI-5
When the app starts, Mixpanel and Customer.io could try to find out "who is the current user" before the app's data stores were set up. When that happens, analytics can end up tagged to the wrong user or to no user at all.
mainalready makes both providers wait until the stores are ready. This PR backports that wait tocloud/1.54.Summary
Backports
main'swhenStoresReady()gate toMixpanelTelemetryProviderandCustomerIoTelemetryProvideroncloud/1.54. It completes the follow-up flagged in #18690, which added thestoreReadinessmechanism here and gated PostHog.Changes
origin/main.loadedcallback waits onwhenStoresReady()beforeuseCurrentUser().onUserResolved(...). Failures go toreportErrorwithmixpanel_user_identification_failure.asyncand awaitswhenStoresReady()before assigningthis.analyticsor callinguseCurrentUser(). The in-app-plugin registration.catchmoves inline and now reports viareportError(customerio_in_app_plugin_registration_failure) instead ofconsole.error, matchingmain.markStoresPending(), the provider does not wireonUserResolveduntilmarkStoresReady()is called. Both tests fail against the old sources and pass with this change.reportErrorinstead ofconsole.error.vi.waitFor, because wiring is one microtask later.Review Focus
this.analyticsis now assigned after the await. While stores are pending,track*calls go into the existing queue (flushQueue()runs after wiring), and page views stay gated on in-app registration as before.providers/cloud/and are only constructed on cloud builds. There is no OSS/desktop behavior change and no feature flag, because this restoresmain's existing gating.Residual
cloud/1.54still use stores without the gate (sweptsrc/platform/telemetry):SentryTelemetryProvider.ts,SyftTelemetryProvider.ts,ImpactTelemetryProvider.ts,hostUserIdSync.ts,utils/getExecutionContext.ts,utils/getShellLayoutSnapshot.ts. None of them are gated onmaineither (main's onlywhenStoresReadycallers are PostHog, Mixpanel and Customer.io), so this PR leaves them alone. Whether any of them has the same race is unverified and would need its own look, onmainfirst.mainandcloud/1.54.Provenance
src/platform/telemetry: 33 files, 450 passed, 0 failed. Red check: the 2 new tests plus the updated Customer.io test fail against the old sources (3 failed).pnpm typecheckclean.pnpm knipclean. eslint + oxlint + oxfmt on changed files clean.git diff origin/mainon both provider sources is empty.main's source. The tests keepcloud/1.54's existing mock style instead of copyingmain's test rewrite (which relies on auto-mocks this branch does not have) and add the readiness regression testsmainlacks.🤖 Generated with Claude Code