Repository navigation
[backport cloud/1.54] fix(agent): wait for open dialogs before offering Agent consent (#18619) - #18671
Conversation
The automatic "Meet Comfy Agent" card opened on top of whatever dialog was already up, including the desktop sign-in approval, so people had to dismiss it before they could approve. It now waits until no dialog is open and shows in the same visit. - **What**: - The automatic consent offer holds while any dialog from the dialog store is open (desktop sign-in approval, sign-in, invite links, errors, the startup template browser) and offers once the last one closes. - It retries once, and only when an offer was actually held, so ordinary dialog closes don't re-read consent. - Once someone has seen the card this visit, from the Agent button or on its own, the automatic offer is done until the next visit. Skipping a card opened from the button no longer brings it straight back. - The Agent button is unchanged and still opens the card right away. - The hold reads `dialogStack.length`, the rule the first-run nudge already uses, not `isModalOpen`. `isModalOpen` also sees modals outside the store, which the retry can't see close, so hold and release would disagree. The trade-off: a lightbox open at the exact moment of the offer won't hold it. - The startup template browser now comes first and the card waits for it to close. That was a product call and it's agreed. - `CONSENT_DIALOG_KEY` is exported from `useAgentConsent` so the extension can tell when the card itself is open. - Unit, `agentPanel.test.ts`: hold, same-session release, a dialog opening mid-offer, a tour ending while a dialog is still open, manual Skip not re-popping, the card seen this visit, and a failing consent read not retried on every dialog close. These fail against the old code. - E2E, `agentConsent.spec.ts` (cloud): boots on a desktop sign-in link; the approval is on top and clickable, and the card appears only after approving. Red 5/5 on the old bundle, green 5/5 on the fix. - Mutation testing on the changed lines: 6/6 killed. - Fixes FE-2808 (cherry picked from commit c10ba49)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1947 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-24T01:48:37.747Z",
"gitSha": "6186f7e28b35abe1e954b70da86a4342f35270af",
"branch": "backport-18619-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2109.61599999996,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.806999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 611.4739999999999,
"heapDeltaBytes": 3730552,
"heapUsedBytes": 73929340,
"domNodes": -282,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.107999999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2073.5070000000064,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.215,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 644.167,
"heapDeltaBytes": -12992284,
"heapUsedBytes": 56602500,
"domNodes": -278,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 14.347999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1856.9410000000062,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.572999999999997,
"layouts": 14,
"layoutDurationMs": 4.012,
"taskDurationMs": 870.999,
"heapDeltaBytes": -5746396,
"heapUsedBytes": 64705492,
"domNodes": -280,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 150.533,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1911.2220000000093,
"styleRecalcs": 77,
"styleRecalcDurationMs": 33.607,
"layouts": 14,
"layoutDurationMs": 4.425,
"taskDurationMs": 990.334,
"heapDeltaBytes": -7043064,
"heapUsedBytes": 63533048,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 162.252,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.1960000000208,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.523999999999997,
"layouts": 6,
"layoutDurationMs": 1.18,
"taskDurationMs": 366.896,
"heapDeltaBytes": 4667352,
"heapUsedBytes": 75517552,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.328999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1678.4360000000333,
"styleRecalcs": 29,
"styleRecalcDurationMs": 16.671000000000003,
"layouts": 6,
"layoutDurationMs": 1.1589999999999998,
"taskDurationMs": 430.68899999999996,
"heapDeltaBytes": 4550128,
"heapUsedBytes": 75792260,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 15.263000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 632.6460000000225,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.052999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.282,
"heapDeltaBytes": -8190564,
"heapUsedBytes": 62899712,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 157.019,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 726.3229999999794,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.552,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.80800000000005,
"heapDeltaBytes": 18326296,
"heapUsedBytes": 88808216,
"domNodes": 18,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 164.697,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2040.6530000000203,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.643999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.2570000000001,
"heapDeltaBytes": 10392552,
"heapUsedBytes": 86994236,
"domNodes": -271,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 33.06399999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2076.779999999985,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.715000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 806.234,
"heapDeltaBytes": 9845884,
"heapUsedBytes": 87490120,
"domNodes": -268,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 43.32200000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2273.5190000000216,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.767000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1678.113,
"heapDeltaBytes": 11381656,
"heapUsedBytes": 88650788,
"domNodes": -279,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 807.331,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2817.713000000026,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.979,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1835.8459999999998,
"heapDeltaBytes": 27896152,
"heapUsedBytes": 93951540,
"domNodes": -275,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 891.291,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3650.6860000000074,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.51,
"layouts": 60,
"layoutDurationMs": 13.607000000000001,
"taskDurationMs": 1763.214,
"heapDeltaBytes": 10235248,
"heapUsedBytes": 76965328,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 791.5790000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3915.81199999996,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.740000000000004,
"layouts": 60,
"layoutDurationMs": 13.979999999999999,
"taskDurationMs": 1875.998,
"heapDeltaBytes": 8055644,
"heapUsedBytes": 76099296,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 821.014,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3021.232999999995,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.542000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1872.1879999999999,
"heapDeltaBytes": 18373192,
"heapUsedBytes": 85640376,
"domNodes": -11,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 947.2850000000002,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3208.9959999999564,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.674000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2126.86,
"heapDeltaBytes": 11325452,
"heapUsedBytes": 93037236,
"domNodes": -287,
"jsHeapTotalBytes": -471040,
"scriptDurationMs": 1020.8710000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2039.7930000000315,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.6099999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 628.3049999999998,
"heapDeltaBytes": 9067556,
"heapUsedBytes": 87317264,
"domNodes": -275,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 35.67999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.8239999999614,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.8849999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 714.904,
"heapDeltaBytes": 21406708,
"heapUsedBytes": 87966696,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.368,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.220999999995,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.164999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.277,
"heapDeltaBytes": 14690704,
"heapUsedBytes": 87806176,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 142.673,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 648.2879999999795,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.753,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.758,
"heapDeltaBytes": 13870084,
"heapUsedBytes": 86530720,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 145.422,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.9579999999974,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.582999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.335,
"heapDeltaBytes": -7817404,
"heapUsedBytes": 65701076,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.557,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2037.821000000008,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.749000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 617.764,
"heapDeltaBytes": -8591704,
"heapUsedBytes": 63957980,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 11.973,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.2130000000384,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.889000000000003,
"layouts": 18,
"layoutDurationMs": 4.718,
"taskDurationMs": 799.2280000000001,
"heapDeltaBytes": -4879748,
"heapUsedBytes": 68620924,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 103.056,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.7299999999714,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.345999999999997,
"layouts": 18,
"layoutDurationMs": 5.766,
"taskDurationMs": 912.6039999999998,
"heapDeltaBytes": -6692300,
"heapUsedBytes": 66588260,
"domNodes": -298,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 117.368,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.414000000012,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.707,
"layouts": 14,
"layoutDurationMs": 15.451999999999996,
"taskDurationMs": 1044.7250000000001,
"heapDeltaBytes": -7110484,
"heapUsedBytes": 83295000,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 36.703,
"eventListeners": 2385,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8541.561000000002,
"styleRecalcs": 248,
"styleRecalcDurationMs": 40.15299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5835.547999999999,
"heapDeltaBytes": 13541408,
"heapUsedBytes": 89744932,
"domNodes": -274,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 2653.018,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9111.28599999995,
"styleRecalcs": 246,
"styleRecalcDurationMs": 41.660000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6308.325,
"heapDeltaBytes": -14158624,
"heapUsedBytes": 89668048,
"domNodes": -271,
"jsHeapTotalBytes": -1445888,
"scriptDurationMs": 2775.501,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18089.710000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17366.887,
"heapDeltaBytes": -45478868,
"heapUsedBytes": 176511760,
"domNodes": -8068,
"jsHeapTotalBytes": -14688256,
"scriptDurationMs": 327.185,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18521.300999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18173.649,
"heapDeltaBytes": -70036808,
"heapUsedBytes": 165707924,
"domNodes": -8068,
"jsHeapTotalBytes": -17596416,
"scriptDurationMs": 320.44100000000003,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22711.127999999975,
"styleRecalcs": 173,
"styleRecalcDurationMs": 22.637000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22425.798,
"heapDeltaBytes": -49445012,
"heapUsedBytes": 169274760,
"domNodes": -8068,
"jsHeapTotalBytes": -10280960,
"scriptDurationMs": 936.352,
"eventListeners": -14929,
"totalBlockingTimeMs": 40,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 23561.849999999937,
"styleRecalcs": 176,
"styleRecalcDurationMs": 28.05200000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23355.204,
"heapDeltaBytes": -64121336,
"heapUsedBytes": 168657176,
"domNodes": -8068,
"jsHeapTotalBytes": -22835200,
"scriptDurationMs": 990.5870000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 218,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6516.536000000031,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.53099999999996,
"layouts": 20,
"layoutDurationMs": 24.86899999999999,
"taskDurationMs": 6490.175000000001,
"heapDeltaBytes": -39979612,
"heapUsedBytes": 179029160,
"domNodes": -8068,
"jsHeapTotalBytes": 19329024,
"scriptDurationMs": 123.51100000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 481,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6468.898999999965,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.64199999999998,
"layouts": 20,
"layoutDurationMs": 24.173000000000012,
"taskDurationMs": 6414.736000000001,
"heapDeltaBytes": -49014648,
"heapUsedBytes": 176948796,
"domNodes": -8068,
"jsHeapTotalBytes": 3452928,
"scriptDurationMs": 116.253,
"eventListeners": -14927,
"totalBlockingTimeMs": 434,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9434.575999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9364.071000000002,
"heapDeltaBytes": 6077952,
"heapUsedBytes": 188763608,
"domNodes": 0,
"jsHeapTotalBytes": -4980736,
"scriptDurationMs": 161.821,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9279.540999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9070.118,
"heapDeltaBytes": 7137312,
"heapUsedBytes": 180440992,
"domNodes": 0,
"jsHeapTotalBytes": -5767168,
"scriptDurationMs": 158.43600000000004,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 117.8600000000074,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.695,
"layouts": 2,
"layoutDurationMs": 0.662,
"taskDurationMs": 82.63300000000001,
"heapDeltaBytes": 3116076,
"heapUsedBytes": 72396572,
"domNodes": 110,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.025,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 107.0559999999432,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.939999999999998,
"layouts": 2,
"layoutDurationMs": 0.8440000000000001,
"taskDurationMs": 74.45200000000001,
"heapDeltaBytes": 3000148,
"heapUsedBytes": 71508356,
"domNodes": 106,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 4.791,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18671 +/- ##
=============================================
Coverage ? 83.75%
=============================================
Files ? 2110
Lines ? 125154
Branches ? 31707
=============================================
Hits ? 104817
Misses ? 20158
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Manual backport of #18619 to
cloud/1.54after the label-driven cherry-pick conflicted inagentPanel.test.ts. The branch already carries everything the fix builds on (#18287, #18431 and the #18603 telemetry, through the agent catch-up backports), so the source files applied cleanly.Resolution
agentPanel.test.ts: an import-block conflict only. Keeps the branch'suseExtensionServicetype import and takes the combinedCONSENT_DIALOG_KEY/useAgentConsentimport from the source commit.agentConsent.spec.ts: this branch has noinitialUrlfixture option, so the desktop sign-in test lets the normal boot finish, clears the one-shot key, then opens the?desktop_login_code=link withcomfyPage.gotoand waits for the app. Its read-count anchor now waits for a read after that navigation, so the absence check can't pass on the first boot's read.Verification
pnpm typecheck,pnpm typecheck:browser, eslint, oxlint, pre-pushknipDISTRIBUTION=cloudbuild of this branch: agent consent and onboarding specs 16/16; the desktop sign-in test fails 3/3 on a build ofcloud/1.54without the fix, at the approval being covered