Skip to content

[backport cloud/1.54] fix(agent): wait for open dialogs before offering Agent consent (#18619) - #18671

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport-18619-to-cloud-1.54
Sep 24, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport-18619-to-cloud-1.54

Conversation

@MaanilVerma

Copy link
Copy Markdown
Collaborator

Summary

Manual backport of #18619 to cloud/1.54 after the label-driven cherry-pick conflicted in agentPanel.test.ts. The branch already carries everything the fix builds on (#18287, #18431 and the #18603 telemetry, through the agent catch-up backports), so the source files applied cleanly.

Resolution

  • agentPanel.test.ts: an import-block conflict only. Keeps the branch's useExtensionService type import and takes the combined CONSENT_DIALOG_KEY / useAgentConsent import from the source commit.
  • agentConsent.spec.ts: this branch has no initialUrl fixture option, so the desktop sign-in test lets the normal boot finish, clears the one-shot key, then opens the ?desktop_login_code= link with comfyPage.goto and waits for the app. Its read-count anchor now waits for a read after that navigation, so the absence check can't pass on the first boot's read.

Verification

  • pnpm typecheck, pnpm typecheck:browser, eslint, oxlint, pre-push knip
  • Unit: 126 files, 1952 tests across the extension, agent consent, telemetry, onboarding and dialog store suites
  • E2E on a DISTRIBUTION=cloud build of this branch: agent consent and onboarding specs 16/16; the desktop sign-in test fails 3/3 on a build of cloud/1.54 without the fix, at the approval being covered

The automatic "Meet Comfy Agent" card opened on top of whatever dialog
was already up, including the desktop sign-in approval, so people had to
dismiss it before they could approve. It now waits until no dialog is
open and shows in the same visit.

- **What**:
- The automatic consent offer holds while any dialog from the dialog
store is open (desktop sign-in approval, sign-in, invite links, errors,
the startup template browser) and offers once the last one closes.
- It retries once, and only when an offer was actually held, so ordinary
dialog closes don't re-read consent.
- Once someone has seen the card this visit, from the Agent button or on
its own, the automatic offer is done until the next visit. Skipping a
card opened from the button no longer brings it straight back.
  - The Agent button is unchanged and still opens the card right away.

- The hold reads `dialogStack.length`, the rule the first-run nudge
already uses, not `isModalOpen`. `isModalOpen` also sees modals outside
the store, which the retry can't see close, so hold and release would
disagree. The trade-off: a lightbox open at the exact moment of the
offer won't hold it.
- The startup template browser now comes first and the card waits for it
to close. That was a product call and it's agreed.
- `CONSENT_DIALOG_KEY` is exported from `useAgentConsent` so the
extension can tell when the card itself is open.

- Unit, `agentPanel.test.ts`: hold, same-session release, a dialog
opening mid-offer, a tour ending while a dialog is still open, manual
Skip not re-popping, the card seen this visit, and a failing consent
read not retried on every dialog close. These fail against the old code.
- E2E, `agentConsent.spec.ts` (cloud): boots on a desktop sign-in link;
the approval is on top and clickable, and the card appears only after
approving. Red 5/5 on the old bundle, green 5/5 on the fix.
- Mutation testing on the changed lines: 6/6 killed.

- Fixes FE-2808

(cherry picked from commit c10ba49)
@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 24, 2026 1:37am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 24, 2026 1:37am UTC

Request Review

@MaanilVerma MaanilVerma added backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned) agent Comfy Agent product, integration, tests or product documentation agent-test-unit Touches Agent-related unit/component tests or their support agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-ui Agent panel, composer, transcript or other user-interface components agent-telemetry Agent analytics, diagnostics, error reporting or observability agent-onboarding Agent consent, first-use tour or onboarding gates agent-backport Agent changes targeting a stable cloud/core release branch labels Sep 24, 2026
@MaanilVerma MaanilVerma self-assigned this Sep 24, 2026
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a5db188f-547c-47f4-b4c4-a865b46e3a61

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1947 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1926 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/24/2026, 01:39:40 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 146ms TBT · 79.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.6 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 163.2 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 129ms TBT · 161.1 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 458ms TBT · 169.7 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 176.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 628ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 62.2 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -182
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 31ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 931ms
canvas-mouse-sweep: script duration 156ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 61.1 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -195
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 399ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.2 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 474ms
dom-widget-clipping: script duration 161ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.3 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 711ms
large-graph-idle: script duration 38ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.2 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -164
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1757ms
large-graph-pan: script duration 849ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 87.1 MB
large-graph-pan: DOM nodes -277
large-graph-pan: event listeners -176
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1820ms
large-graph-zoom: script duration 806ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.0 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 2000ms
legacy-node-drag: script duration 984ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 85.2 MB
legacy-node-drag: DOM nodes -149
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 672ms
minimap-idle: script duration 38ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.6 MB
minimap-idle: DOM nodes -275
minimap-idle: event listeners -163
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 423ms
subgraph-dom-widget-clipping: script duration 144ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.1 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 573ms
subgraph-idle: script duration 11ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.8 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 856ms
subgraph-mouse-sweep: script duration 110ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.5 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -241
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1045ms
subgraph-transition-enter: script duration 37ms
subgraph-transition-enter: TBT 146ms
subgraph-transition-enter: heap used 79.4 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 41ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 6072ms
viewport-pan-sweep: script duration 2714ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 85.6 MB
viewport-pan-sweep: DOM nodes -273
viewport-pan-sweep: event listeners -161
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17770ms
vue-large-graph-idle: script duration 324ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 163.2 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14931
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 25ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 175
vue-large-graph-pan: task duration 22891ms
vue-large-graph-pan: script duration 963ms
vue-large-graph-pan: TBT 129ms
vue-large-graph-pan: heap used 161.1 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 74ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6452ms
vue-node-resize-workload: script duration 120ms
vue-node-resize-workload: TBT 458ms
vue-node-resize-workload: heap used 169.7 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14927
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 9217ms
vue-zoom-out-idle: script duration 160ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 176.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 2
workflow-execution: style recalc count 8
workflow-execution: task duration 79ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.6 MB
workflow-execution: DOM nodes 108
workflow-execution: event listeners 33
Raw data
{
  "timestamp": "2026-09-24T01:48:37.747Z",
  "gitSha": "6186f7e28b35abe1e954b70da86a4342f35270af",
  "branch": "backport-18619-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2109.61599999996,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.806999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 611.4739999999999,
      "heapDeltaBytes": 3730552,
      "heapUsedBytes": 73929340,
      "domNodes": -282,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 10.107999999999999,
      "eventListeners": -168,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2073.5070000000064,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.215,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 644.167,
      "heapDeltaBytes": -12992284,
      "heapUsedBytes": 56602500,
      "domNodes": -278,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 14.347999999999999,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1856.9410000000062,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 28.572999999999997,
      "layouts": 14,
      "layoutDurationMs": 4.012,
      "taskDurationMs": 870.999,
      "heapDeltaBytes": -5746396,
      "heapUsedBytes": 64705492,
      "domNodes": -280,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 150.533,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1911.2220000000093,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 33.607,
      "layouts": 14,
      "layoutDurationMs": 4.425,
      "taskDurationMs": 990.334,
      "heapDeltaBytes": -7043064,
      "heapUsedBytes": 63533048,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 162.252,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1733.1960000000208,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 16.523999999999997,
      "layouts": 6,
      "layoutDurationMs": 1.18,
      "taskDurationMs": 366.896,
      "heapDeltaBytes": 4667352,
      "heapUsedBytes": 75517552,
      "domNodes": 75,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 12.328999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1678.4360000000333,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 16.671000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.1589999999999998,
      "taskDurationMs": 430.68899999999996,
      "heapDeltaBytes": 4550128,
      "heapUsedBytes": 75792260,
      "domNodes": 75,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 15.263000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 632.6460000000225,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.052999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 445.282,
      "heapDeltaBytes": -8190564,
      "heapUsedBytes": 62899712,
      "domNodes": 18,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 157.019,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 726.3229999999794,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.552,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.80800000000005,
      "heapDeltaBytes": 18326296,
      "heapUsedBytes": 88808216,
      "domNodes": 18,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 164.697,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.6530000000203,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.643999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 615.2570000000001,
      "heapDeltaBytes": 10392552,
      "heapUsedBytes": 86994236,
      "domNodes": -271,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 33.06399999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2076.779999999985,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.715000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 806.234,
      "heapDeltaBytes": 9845884,
      "heapUsedBytes": 87490120,
      "domNodes": -268,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 43.32200000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2273.5190000000216,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.767000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1678.113,
      "heapDeltaBytes": 11381656,
      "heapUsedBytes": 88650788,
      "domNodes": -279,
      "jsHeapTotalBytes": -139264,
      "scriptDurationMs": 807.331,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2817.713000000026,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 11.979,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1835.8459999999998,
      "heapDeltaBytes": 27896152,
      "heapUsedBytes": 93951540,
      "domNodes": -275,
      "jsHeapTotalBytes": 1536000,
      "scriptDurationMs": 891.291,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3650.6860000000074,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 11.51,
      "layouts": 60,
      "layoutDurationMs": 13.607000000000001,
      "taskDurationMs": 1763.214,
      "heapDeltaBytes": 10235248,
      "heapUsedBytes": 76965328,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 791.5790000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3915.81199999996,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 11.740000000000004,
      "layouts": 60,
      "layoutDurationMs": 13.979999999999999,
      "taskDurationMs": 1875.998,
      "heapDeltaBytes": 8055644,
      "heapUsedBytes": 76099296,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 821.014,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3021.232999999995,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.542000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1872.1879999999999,
      "heapDeltaBytes": 18373192,
      "heapUsedBytes": 85640376,
      "domNodes": -11,
      "jsHeapTotalBytes": 1728512,
      "scriptDurationMs": 947.2850000000002,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3208.9959999999564,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.674000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2126.86,
      "heapDeltaBytes": 11325452,
      "heapUsedBytes": 93037236,
      "domNodes": -287,
      "jsHeapTotalBytes": -471040,
      "scriptDurationMs": 1020.8710000000001,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2039.7930000000315,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.6099999999999977,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 628.3049999999998,
      "heapDeltaBytes": 9067556,
      "heapUsedBytes": 87317264,
      "domNodes": -275,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 35.67999999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2005.8239999999614,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.8849999999999978,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 714.904,
      "heapDeltaBytes": 21406708,
      "heapUsedBytes": 87966696,
      "domNodes": -275,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 39.368,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 592.220999999995,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.164999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 406.277,
      "heapDeltaBytes": 14690704,
      "heapUsedBytes": 87806176,
      "domNodes": 16,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 142.673,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 648.2879999999795,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.753,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 438.758,
      "heapDeltaBytes": 13870084,
      "heapUsedBytes": 86530720,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 145.422,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.9579999999974,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.582999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 527.335,
      "heapDeltaBytes": -7817404,
      "heapUsedBytes": 65701076,
      "domNodes": -297,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 9.557,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2037.821000000008,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.749000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 617.764,
      "heapDeltaBytes": -8591704,
      "heapUsedBytes": 63957980,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 11.973,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1704.2130000000384,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 27.889000000000003,
      "layouts": 18,
      "layoutDurationMs": 4.718,
      "taskDurationMs": 799.2280000000001,
      "heapDeltaBytes": -4879748,
      "heapUsedBytes": 68620924,
      "domNodes": -294,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 103.056,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1755.7299999999714,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.345999999999997,
      "layouts": 18,
      "layoutDurationMs": 5.766,
      "taskDurationMs": 912.6039999999998,
      "heapDeltaBytes": -6692300,
      "heapUsedBytes": 66588260,
      "domNodes": -298,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 117.368,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.414000000012,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 32.707,
      "layouts": 14,
      "layoutDurationMs": 15.451999999999996,
      "taskDurationMs": 1044.7250000000001,
      "heapDeltaBytes": -7110484,
      "heapUsedBytes": 83295000,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 36.703,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 146,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8541.561000000002,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 40.15299999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5835.547999999999,
      "heapDeltaBytes": 13541408,
      "heapUsedBytes": 89744932,
      "domNodes": -274,
      "jsHeapTotalBytes": 385024,
      "scriptDurationMs": 2653.018,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9111.28599999995,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 41.660000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6308.325,
      "heapDeltaBytes": -14158624,
      "heapUsedBytes": 89668048,
      "domNodes": -271,
      "jsHeapTotalBytes": -1445888,
      "scriptDurationMs": 2775.501,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18089.710000000025,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17366.887,
      "heapDeltaBytes": -45478868,
      "heapUsedBytes": 176511760,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14688256,
      "scriptDurationMs": 327.185,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18521.300999999992,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18173.649,
      "heapDeltaBytes": -70036808,
      "heapUsedBytes": 165707924,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17596416,
      "scriptDurationMs": 320.44100000000003,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22711.127999999975,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 22.637000000000018,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22425.798,
      "heapDeltaBytes": -49445012,
      "heapUsedBytes": 169274760,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10280960,
      "scriptDurationMs": 936.352,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 40,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23561.849999999937,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 28.05200000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23355.204,
      "heapDeltaBytes": -64121336,
      "heapUsedBytes": 168657176,
      "domNodes": -8068,
      "jsHeapTotalBytes": -22835200,
      "scriptDurationMs": 990.5870000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 218,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6516.536000000031,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.53099999999996,
      "layouts": 20,
      "layoutDurationMs": 24.86899999999999,
      "taskDurationMs": 6490.175000000001,
      "heapDeltaBytes": -39979612,
      "heapUsedBytes": 179029160,
      "domNodes": -8068,
      "jsHeapTotalBytes": 19329024,
      "scriptDurationMs": 123.51100000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 481,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6468.898999999965,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.64199999999998,
      "layouts": 20,
      "layoutDurationMs": 24.173000000000012,
      "taskDurationMs": 6414.736000000001,
      "heapDeltaBytes": -49014648,
      "heapUsedBytes": 176948796,
      "domNodes": -8068,
      "jsHeapTotalBytes": 3452928,
      "scriptDurationMs": 116.253,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 434,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9434.575999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9364.071000000002,
      "heapDeltaBytes": 6077952,
      "heapUsedBytes": 188763608,
      "domNodes": 0,
      "jsHeapTotalBytes": -4980736,
      "scriptDurationMs": 161.821,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9279.540999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9070.118,
      "heapDeltaBytes": 7137312,
      "heapUsedBytes": 180440992,
      "domNodes": 0,
      "jsHeapTotalBytes": -5767168,
      "scriptDurationMs": 158.43600000000004,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 117.8600000000074,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 14.695,
      "layouts": 2,
      "layoutDurationMs": 0.662,
      "taskDurationMs": 82.63300000000001,
      "heapDeltaBytes": 3116076,
      "heapUsedBytes": 72396572,
      "domNodes": 110,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 10.025,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 107.0559999999432,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 16.939999999999998,
      "layouts": 2,
      "layoutDurationMs": 0.8440000000000001,
      "taskDurationMs": 74.45200000000001,
      "heapDeltaBytes": 3000148,
      "heapUsedBytes": 71508356,
      "domNodes": 106,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 4.791,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50456 75671 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.5% 259
src/scripts/pnginfo.ts 21.4% 221

@github-actions
github-actions Bot requested a review from huang47 September 24, 2026 01:37
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18671   +/-   ##
=============================================
  Coverage              ?   83.75%           
=============================================
  Files                 ?     2110           
  Lines                 ?   125154           
  Branches              ?    31707           
=============================================
  Hits                  ?   104817           
  Misses                ?    20158           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.68% <100.00%> (?)
unit 78.81% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/extensions/core/agentPanel.ts 99.00% <100.00%> (ø)
src/platform/telemetry/types.ts 92.59% <ø> (ø)
...ensions/agent/composables/agent/useAgentConsent.ts 91.08% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit afd09fd into cloud/1.54 Sep 24, 2026
133 of 137 checks passed
@christian-byrne
christian-byrne deleted the backport-18619-to-cloud-1.54 branch September 24, 2026 02:09

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — 15b01b95 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-onboarding Agent consent, first-use tour or onboarding gates agent-telemetry Agent analytics, diagnostics, error reporting or observability agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants