Repository navigation
Conversation
🎭 Playwright: ✅ 2129 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 21a9bf716492c7de9cd62cd62a62b07829a99fc1
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle: 9.99 MB gzip 🔴 +37 BDetailsSummary
Category Glance App Entry Points — 3.83 kB (baseline 3.83 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.44 MB) • 🔴 +143 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.96 MB (baseline 3.96 MB) • 🟢 -205 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 578 kB (baseline 578 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category
Status: 74 added / 74 removed / 227 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-24T00:14:40.142Z",
"gitSha": "50f96a12349316024593158973fc44c58f8cdf00",
"branch": "cursor/stabilize-widget-resync-pin-3b07",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1999.4540000000143,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.324000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.74399999999997,
"heapDeltaBytes": 8281300,
"heapUsedBytes": 75675192,
"domNodes": -258,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.814000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1991.5190000000393,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.982999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.293,
"heapDeltaBytes": 8756964,
"heapUsedBytes": 75495408,
"domNodes": -257,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.399000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.771000000003,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.735999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 666.9770000000001,
"heapDeltaBytes": -5045852,
"heapUsedBytes": 57449040,
"domNodes": -259,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 127.963,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1733.4240000000136,
"styleRecalcs": 43,
"styleRecalcDurationMs": 13.806000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 660.1300000000001,
"heapDeltaBytes": -3591652,
"heapUsedBytes": 59128588,
"domNodes": -263,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 122.92799999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.9599999999946,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.207999999999998,
"layouts": 6,
"layoutDurationMs": 0.8430000000000001,
"taskDurationMs": 262.13399999999996,
"heapDeltaBytes": 2207856,
"heapUsedBytes": 64665632,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.119,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.4239999999463,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.151,
"layouts": 6,
"layoutDurationMs": 0.9740000000000001,
"taskDurationMs": 267.818,
"heapDeltaBytes": 2797928,
"heapUsedBytes": 70222448,
"domNodes": 79,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.176999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 531.8429999999807,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.760000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.79300000000006,
"heapDeltaBytes": 18260524,
"heapUsedBytes": 85981112,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 135.83900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 552.4410000000444,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.961999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.788,
"heapDeltaBytes": 18956792,
"heapUsedBytes": 86528876,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 131.795,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1003.6860000000161,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.147,
"heapDeltaBytes": 38255564,
"heapUsedBytes": 106044904,
"domNodes": 0,
"jsHeapTotalBytes": 20606976,
"scriptDurationMs": 48.848,
"eventListeners": 0,
"totalBlockingTimeMs": 403,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1037.6489999999876,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 700.94,
"heapDeltaBytes": -14979492,
"heapUsedBytes": 72647644,
"domNodes": -294,
"jsHeapTotalBytes": 19529728,
"scriptDurationMs": 49.230999999999995,
"eventListeners": -217,
"totalBlockingTimeMs": 396,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 766.6959999999676,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.6839999999998,
"heapDeltaBytes": 13563448,
"heapUsedBytes": 90272908,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.70900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 157,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 784.020000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.11899999999986,
"heapDeltaBytes": 15814460,
"heapUsedBytes": 92192584,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.17099999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 155,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7137.073999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6410.9929999999995,
"heapDeltaBytes": -1851204,
"heapUsedBytes": 81168424,
"domNodes": -18,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 5281.212,
"eventListeners": 0,
"totalBlockingTimeMs": 80,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7893.959999999993,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.12900000000000064,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7058.109,
"heapDeltaBytes": 4564264,
"heapUsedBytes": 82675928,
"domNodes": -275,
"jsHeapTotalBytes": 3137536,
"scriptDurationMs": 5688.833,
"eventListeners": -174,
"totalBlockingTimeMs": 41,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7979.190000000017,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.11699999999999905,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7104.026999999999,
"heapDeltaBytes": 1104296,
"heapUsedBytes": 83479580,
"domNodes": -16,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 5724.949,
"eventListeners": 0,
"totalBlockingTimeMs": 141,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7989.014999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7152.024,
"heapDeltaBytes": -750648,
"heapUsedBytes": 81365340,
"domNodes": -18,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 5842.371,
"eventListeners": 0,
"totalBlockingTimeMs": 50,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2012.6280000000065,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.221,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.73,
"heapDeltaBytes": -14987268,
"heapUsedBytes": 64237892,
"domNodes": -257,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 27.046000000000006,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.8089999999675,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.366999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.0060000000001,
"heapDeltaBytes": -5951136,
"heapUsedBytes": 81336336,
"domNodes": -242,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 29.914,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2152.6150000000257,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.116000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1397.7450000000001,
"heapDeltaBytes": -22598884,
"heapUsedBytes": 65645912,
"domNodes": -248,
"jsHeapTotalBytes": 1601536,
"scriptDurationMs": 685.396,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2168.002999999999,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.384000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1360.7420000000002,
"heapDeltaBytes": -19279124,
"heapUsedBytes": 68581900,
"domNodes": -210,
"jsHeapTotalBytes": 2650112,
"scriptDurationMs": 674.4030000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3226.0459999999966,
"styleRecalcs": 66,
"styleRecalcDurationMs": 17.753999999999998,
"layouts": 60,
"layoutDurationMs": 12.82,
"taskDurationMs": 1438.742,
"heapDeltaBytes": -15344532,
"heapUsedBytes": 74443100,
"domNodes": -244,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 650.6270000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3222.1359999999777,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.182999999999996,
"layouts": 60,
"layoutDurationMs": 12.961,
"taskDurationMs": 1406.854,
"heapDeltaBytes": 9061924,
"heapUsedBytes": 75226876,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 663.929,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2509.828999999968,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.869000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1616.5659999999998,
"heapDeltaBytes": -18320968,
"heapUsedBytes": 73016988,
"domNodes": -254,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 799.8700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2421.288000000004,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.541999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1661.7890000000002,
"heapDeltaBytes": -8345044,
"heapUsedBytes": 76462260,
"domNodes": -215,
"jsHeapTotalBytes": 1265664,
"scriptDurationMs": 823.691,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.7230000000463,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.993000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.23500000000007,
"heapDeltaBytes": -4892060,
"heapUsedBytes": 84014396,
"domNodes": -241,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 28.715000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2021.2099999999964,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.238,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.17999999999995,
"heapDeltaBytes": -4440044,
"heapUsedBytes": 84448936,
"domNodes": -238,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 30.591000000000008,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 465.7450000000267,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.774,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.439,
"heapDeltaBytes": 13976836,
"heapUsedBytes": 83780000,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 119.242,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 512.794000000099,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 319.55100000000004,
"heapDeltaBytes": 13632132,
"heapUsedBytes": 76773376,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 117.313,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.8049999999716,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.059000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.723,
"heapDeltaBytes": -14788320,
"heapUsedBytes": 55099172,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.036000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1992.118000000005,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.979000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.66499999999996,
"heapDeltaBytes": 10993016,
"heapUsedBytes": 80674300,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.825000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.9260000000331,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.533,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.9200000000001,
"heapDeltaBytes": -8381280,
"heapUsedBytes": 61405120,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 86.772,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.0620000000836,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.408000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.298,
"heapDeltaBytes": 7431464,
"heapUsedBytes": 77185492,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 83.95400000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 867.2299999999495,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.261000000000003,
"layouts": 5,
"layoutDurationMs": 9.737,
"taskDurationMs": 693.2439999999999,
"heapDeltaBytes": -6419412,
"heapUsedBytes": 85373904,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 21.746999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 98,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8181.502999999964,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.369,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4771.963000000001,
"heapDeltaBytes": -19684972,
"heapUsedBytes": 67316608,
"domNodes": -238,
"jsHeapTotalBytes": 5533696,
"scriptDurationMs": 2279.314,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8200.01400000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.491,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4687.803000000001,
"heapDeltaBytes": -19367676,
"heapUsedBytes": 67964088,
"domNodes": -218,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 2254.1319999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13990.01899999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13772.376,
"heapDeltaBytes": -19056500,
"heapUsedBytes": 195265448,
"domNodes": -8062,
"jsHeapTotalBytes": -7847936,
"scriptDurationMs": 195.24400000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14338.623999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14080.179000000002,
"heapDeltaBytes": -66283956,
"heapUsedBytes": 171200332,
"domNodes": -8062,
"jsHeapTotalBytes": -15839232,
"scriptDurationMs": 205.063,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17182.61000000001,
"styleRecalcs": 135,
"styleRecalcDurationMs": 14.342999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16905.125,
"heapDeltaBytes": -63220148,
"heapUsedBytes": 174682584,
"domNodes": -8062,
"jsHeapTotalBytes": -14004224,
"scriptDurationMs": 708.51,
"eventListeners": -14928,
"totalBlockingTimeMs": 15,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17321.850999999922,
"styleRecalcs": 125,
"styleRecalcDurationMs": 14.738000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17199.809999999998,
"heapDeltaBytes": -57156500,
"heapUsedBytes": 181505832,
"domNodes": -8062,
"jsHeapTotalBytes": -22765568,
"scriptDurationMs": 706.654,
"eventListeners": -14928,
"totalBlockingTimeMs": 4,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5111.857999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.116,
"layouts": 20,
"layoutDurationMs": 21.07600000000001,
"taskDurationMs": 5067.55,
"heapDeltaBytes": -45175000,
"heapUsedBytes": 189560544,
"domNodes": -8062,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 83.113,
"eventListeners": -14928,
"totalBlockingTimeMs": 188,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5185.551000000032,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.80499999999999,
"layouts": 20,
"layoutDurationMs": 20.668000000000006,
"taskDurationMs": 5126.471,
"heapDeltaBytes": -17689964,
"heapUsedBytes": 197700904,
"domNodes": -8062,
"jsHeapTotalBytes": 18817024,
"scriptDurationMs": 87.08099999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 176,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7226.696999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7025.039999999999,
"heapDeltaBytes": -14722992,
"heapUsedBytes": 179064420,
"domNodes": 0,
"jsHeapTotalBytes": -19660800,
"scriptDurationMs": 103.51200000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7354.851000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7224.425000000002,
"heapDeltaBytes": 7753028,
"heapUsedBytes": 178575792,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 102.74000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 440.4700000000048,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.139000000000003,
"layouts": 3,
"layoutDurationMs": 0.906,
"taskDurationMs": 95.892,
"heapDeltaBytes": 5003652,
"heapUsedBytes": 70645104,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.53,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 77.13000000001102,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.344999999999999,
"layouts": 3,
"layoutDurationMs": 1.48,
"taskDurationMs": 61.19300000000001,
"heapDeltaBytes": 3049812,
"heapUsedBytes": 68673228,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.386999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe “keeps prompt keystrokes when a doc frame resyncs the widget” test is no longer marked as expected to fail. It must now pass. ChangesConversation replay test
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The replay test now requires the prompt-preservation assertion to pass. No merge-blocking issue is evident from this change. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Comment |
Cloud CI already keeps the typed prompt across the doc-frame resync. Drop the stale test.fail() so that assertion is a normal pass.
c7a2004 to
c4c6373
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18649 +/- ##
==========================================
+ Coverage 83.74% 84.66% +0.92%
==========================================
Files 3020 2294 -726
Lines 149137 131368 -17769
Branches 38534 35442 -3092
==========================================
- Hits 124891 111226 -13665
+ Misses 22942 19842 -3100
+ Partials 1304 300 -1004
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 3 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 4d3f6c4 | Docs | View more details | Give us feedback! |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Pull request was converted to draft
|
Heads-up before this merges: this case passing on cloud CI is a latency artifact, not evidence the defect is gone. The bug it pins (PM-1191/PM-1697 — keystrokes deleted while the agent panel is open) is still live on The actual fix is up at #18766 (guards the incremental |
|
Thanks @christian-byrne closing this in favor of #18766 per suggestion |
… edit (#18766) Typing into any text widget while the agent panel is open garbles — the cursor jumps and fast typing deletes letters (PM-1191, PM-1697, live on cloud at 5% exposure). Root cause: the incremental `setWidget` apply path writes remote doc-frame values into `widgetValueStore` with no in-progress-local-edit guard, so the host's echo of the user's *own* keystroke ops (whole-value, stale by however many keystrokes are in flight) deletes text under the cursor. The same unguarded path let an agent turn's `set_widget` overwrite a widget the user was mid-editing. - **What**: `graphMutations.ts` — the incremental `setWidget` commit now consults the same `skipStaleReconcile` local-dirty guard the full-reconcile path already uses: a remote value that differs from a locally-dirty widget is skipped until the document catches up to the local value; the write that finally matches clears the mark (its context-carrying no-op write), after which remote/agent writes land normally. The old escape hatch that let a single-widget op bypass the guard "regardless of value" is retired — that bypass *was* the garble. - **Pins flipped green honestly** (each red on parent, green here): - `graphMutations.test.ts` "preserves a locally newer widget value across a direct setWidget op" (`it.fails` → `it`), plus a new round-trip test covering skip-stale-echo → catch-up-clears → agent-write-lands. - `agentCrdtReconcileOverwrite.spec.ts` widget-overwrite case (`test.fail()` removed; now proves the agent frame really applied via the CRDT debug-panel outcomes counter *and* that the user's text survived). - `agentConversationReplay.spec.ts` "keeps prompt keystrokes when a doc frame resyncs the widget" (`test.fail()` removed — with this fix it passes deterministically, not by echo-latency luck; supersedes the marker-only removal in #18649). - Two unit tests that pinned the old escape-hatch contract are updated to the new one (a differing remote write holds; only a matching one resolves the mark). The trade: a widget stranded dirty by an unsuppressed structural replay now stays local-valued until a matching remote write, instead of being unstuck by the next agent op — the suppression brackets those tests also pin are what prevent that state. - The guard-clearing rule: convergence relies on the user's own minted keystroke ops echoing back; once the echo value equals the local value, the contexted write clears `locallyDirtyWidgets`. Verified in `graphMutations.test.ts` round-trip test. - Open test PRs [#18089](#18089) and [#18705](#18705) both flip to "expected to fail, but passed" when run against this branch (verified locally; #18705's attachment shows the stale echo arriving and being skipped) — their `test.fail()` markers should drop on rebase after this merges. - Freeze note: this is the authorized P0 exception to the informal remote-ops freeze. `graphMutations.ts` is deleted by the #18700 refactor; the property this restores — *a local edit in progress is never overwritten by a remote or reconciled write* — must be re-asserted on the new graph-API apply path (own-actor echo skip at follower entry + a provenance-aware guard at the widget setter). The three flipped black-box/unit pins are the acceptance tests for that re-assertion; they survive the refactor even though this implementation does not. Evidence: reported by four users over ten days (Memie 09-15 w/ CRDT debug report `F0C22E6U70E`, Denys 09-22, Luke 09-24, Doug 09-24 Silverside demo).
… edit (Comfy-Org#18766) ## Summary Typing into any text widget while the agent panel is open garbles — the cursor jumps and fast typing deletes letters (PM-1191, PM-1697, live on cloud at 5% exposure). Root cause: the incremental `setWidget` apply path writes remote doc-frame values into `widgetValueStore` with no in-progress-local-edit guard, so the host's echo of the user's *own* keystroke ops (whole-value, stale by however many keystrokes are in flight) deletes text under the cursor. The same unguarded path let an agent turn's `set_widget` overwrite a widget the user was mid-editing. ## Changes - **What**: `graphMutations.ts` — the incremental `setWidget` commit now consults the same `skipStaleReconcile` local-dirty guard the full-reconcile path already uses: a remote value that differs from a locally-dirty widget is skipped until the document catches up to the local value; the write that finally matches clears the mark (its context-carrying no-op write), after which remote/agent writes land normally. The old escape hatch that let a single-widget op bypass the guard "regardless of value" is retired — that bypass *was* the garble. - **Pins flipped green honestly** (each red on parent, green here): - `graphMutations.test.ts` "preserves a locally newer widget value across a direct setWidget op" (`it.fails` → `it`), plus a new round-trip test covering skip-stale-echo → catch-up-clears → agent-write-lands. - `agentCrdtReconcileOverwrite.spec.ts` widget-overwrite case (`test.fail()` removed; now proves the agent frame really applied via the CRDT debug-panel outcomes counter *and* that the user's text survived). - `agentConversationReplay.spec.ts` "keeps prompt keystrokes when a doc frame resyncs the widget" (`test.fail()` removed — with this fix it passes deterministically, not by echo-latency luck; supersedes the marker-only removal in Comfy-Org#18649). - Two unit tests that pinned the old escape-hatch contract are updated to the new one (a differing remote write holds; only a matching one resolves the mark). The trade: a widget stranded dirty by an unsuppressed structural replay now stays local-valued until a matching remote write, instead of being unstuck by the next agent op — the suppression brackets those tests also pin are what prevent that state. ## Review Focus - The guard-clearing rule: convergence relies on the user's own minted keystroke ops echoing back; once the echo value equals the local value, the contexted write clears `locallyDirtyWidgets`. Verified in `graphMutations.test.ts` round-trip test. - Open test PRs [Comfy-Org#18089](Comfy-Org#18089) and [Comfy-Org#18705](Comfy-Org#18705) both flip to "expected to fail, but passed" when run against this branch (verified locally; Comfy-Org#18705's attachment shows the stale echo arriving and being skipped) — their `test.fail()` markers should drop on rebase after this merges. - Freeze note: this is the authorized P0 exception to the informal remote-ops freeze. `graphMutations.ts` is deleted by the Comfy-Org#18700 refactor; the property this restores — *a local edit in progress is never overwritten by a remote or reconciled write* — must be re-asserted on the new graph-API apply path (own-actor echo skip at follower entry + a provenance-aware guard at the widget setter). The three flipped black-box/unit pins are the acceptance tests for that re-assertion; they survive the refactor even though this implementation does not. Evidence: reported by four users over ten days (Memie 09-15 w/ CRDT debug report `F0C22E6U70E`, Denys 09-22, Luke 09-24, Doug 09-24 Silverside demo).
Summary
active widget edit › keeps prompt keystrokes when a doc frame resyncs the widgetis a normal passing test. Cloud CI already kept the typed prompt across the doc-frame resync, and the staletest.fail()made run 35929052590 fail with Expected to fail, but passed. The marker is gone. The assertion that the prompt field keepsa photo of a pierplus the typed suffix stays.Verification
browser_tests/tests/agent/agentConversationReplay.spec.tshas notest.fail()on that case. The final check is an ordinarytoHaveValue.playwright-tests (cloud, frontend-dist-cloud)):The dev-server form in
browser_tests/README.md(DISTRIBUTION=cloud pnpm dev, thenPLAYWRIGHT_TEST_URL=http://localhost:5173) covers this replay file. The case should finish as a pass.pnpm typecheck:browser, oxlint, and eslint passed on the spec in the commit hook. This environment has no ComfyUI backend, so the Playwright project was not executed here.