Repository navigation
fix: recover graph ID allocation at safe-integer boundary - #18643
claude[bot] wants to merge 12 commits into
Conversation
`findNextAvailableId` only ever advanced each counter and threw once it passed the 100M ceiling, even though most of that ceiling was IDs whose owning node/link/group/reroute had long since been deleted. Track freed IDs in a small per-counter pool, released on removal, and prefer reusing one before minting past the counter. The ceiling itself stays a true safety cap. Also: - Clamp incoming counter values on hydration and observation so a corrupted/stale persisted counter, or an ID far outside the normal range, can't push a graph's allocator toward the ceiling on its own. - Add the missing exhaustion guard to the clipboard subgraph node-ID remap, which previously had no ceiling check and would spin instead of failing clearly. - Stage ID-state changes on a disposable copy in both the subgraph dedup path and the clipboard remap path, committing only once the whole operation succeeds, so a throw partway through never leaves a graph's real allocator partially advanced.
…board data The clipboard-metadata paste path wrapped one try/catch around both the base64/JSON decode (expected to throw on garbage clipboard data) and the actual graph deserialization. A genuine deserialization/graph-mutation error — for example ID space exhaustion — was caught by the same handler, looked identical to "no valid metadata payload", and fell through to the legacy localStorage-clipboard paste, silently repeating the same failure. Split the two: an invalid payload still falls through to the other paste strategies, but a real deserialization error now surfaces to the user as a toast instead of triggering another paste attempt.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2155 passed, 0 failed · 2 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (35 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8fc88b4cf249cf3aa401f9bf31cb22bc08965b3b
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10 MB gzipDetailsSummary
Category Glance App Entry Points — 3.77 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.45 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 134 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 640 kBConfiguration panels, inspectors, and settings screens
Status: 28 added User & Accounts — 39.4 kBAuthentication, profile, and account management bundles
Status: 11 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 125 kBReusable component library chunks
Status: 16 added Data & Services — 4.02 MBStores, services, APIs, and repositories
Status: 15 added Utilities & Hooks — 579 kBHelpers, composables, and utility bundles
Status: 36 added Vendor & Third-Party — 17.4 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 17.9 MBBundles that do not match a named category
Status: 301 added ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-28T08:10:29.243Z",
"gitSha": "a641f4a91e965da58ed2289463235360f6733fb0",
"branch": "fix/node-id-space-exhaustion-recycling",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2042.2699999999736,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.4249999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.42199999999997,
"heapDeltaBytes": -21141188,
"heapUsedBytes": 77069680,
"domNodes": -228,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 9.824,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2016.8370000000095,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.2829999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.7219999999999,
"heapDeltaBytes": -1044348,
"heapUsedBytes": 77775392,
"domNodes": -228,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 9.794,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1784.1350000000489,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.546999999999997,
"layouts": 12,
"layoutDurationMs": 4.144,
"taskDurationMs": 756.414,
"heapDeltaBytes": -12477020,
"heapUsedBytes": 67226388,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 130.23000000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1753.8240000000087,
"styleRecalcs": 73,
"styleRecalcDurationMs": 14.203,
"layouts": 12,
"layoutDurationMs": 3.9959999999999996,
"taskDurationMs": 728.6819999999999,
"heapDeltaBytes": 441728,
"heapUsedBytes": 79161664,
"domNodes": -228,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 133.933,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1713.5020000000054,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.638,
"layouts": 6,
"layoutDurationMs": 1.2049999999999998,
"taskDurationMs": 320.832,
"heapDeltaBytes": 1394264,
"heapUsedBytes": 80888420,
"domNodes": 53,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 11.241000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.292000000025,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.144999999999998,
"layouts": 6,
"layoutDurationMs": 1.5050000000000001,
"taskDurationMs": 359.519,
"heapDeltaBytes": -3088324,
"heapUsedBytes": 75739408,
"domNodes": -175,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.028,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 608.4460000000149,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.2929999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.665,
"heapDeltaBytes": 18263372,
"heapUsedBytes": 96969248,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 140.824,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 643.0139999999938,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.2639999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.07,
"heapDeltaBytes": -1645700,
"heapUsedBytes": 96856636,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 146.872,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684193,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1146.614999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 795.5880000000001,
"heapDeltaBytes": 9534616,
"heapUsedBytes": 86823420,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 55.745000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 525,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1139.711000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 790.456,
"heapDeltaBytes": 6334576,
"heapUsedBytes": 83114460,
"domNodes": 0,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 56.903000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 518,
"frameDurationMs": 34.34242424242425,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 779.6240000000125,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.3669999999998,
"heapDeltaBytes": 16613740,
"heapUsedBytes": 90168424,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 130.18099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 155,
"frameDurationMs": 23.03529411764708,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 775.9509999999636,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.4529999999999,
"heapDeltaBytes": 15525904,
"heapUsedBytes": 89924036,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 121.70299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 155,
"frameDurationMs": 23.03823529411768,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8436.465999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7566.137000000001,
"heapDeltaBytes": 4561092,
"heapUsedBytes": 84463160,
"domNodes": 0,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 5905.7880000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 202,
"frameDurationMs": 29.13655172413793,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7557.730000000106,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6892.840999999999,
"heapDeltaBytes": -10355060,
"heapUsedBytes": 70722488,
"domNodes": 0,
"jsHeapTotalBytes": -13631488,
"scriptDurationMs": 5331.5740000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 52,
"frameDurationMs": 27.756249999999998,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8164.553000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7356.158,
"heapDeltaBytes": 777096,
"heapUsedBytes": 82094096,
"domNodes": 0,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 5716.976000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 171,
"frameDurationMs": 28.15965517241379,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7734.203999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6905.98,
"heapDeltaBytes": -1915600,
"heapUsedBytes": 78701560,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 5388.995000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 72,
"frameDurationMs": 28.368750000000002,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2044.7980000000143,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.959999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.1030000000002,
"heapDeltaBytes": -38612640,
"heapUsedBytes": 81480432,
"domNodes": -234,
"jsHeapTotalBytes": 425984,
"scriptDurationMs": 32.779999999999994,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80245901639344,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2046.5560000000096,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7890000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.576,
"heapDeltaBytes": -36551224,
"heapUsedBytes": 82410224,
"domNodes": -230,
"jsHeapTotalBytes": 950272,
"scriptDurationMs": 34.629000000000005,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2332.2030000000495,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.512999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1463.519,
"heapDeltaBytes": 18699644,
"heapUsedBytes": 81771940,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 740.339,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66618705035971,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2173.06700000006,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.045000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1389.0000000000002,
"heapDeltaBytes": 19334052,
"heapUsedBytes": 82024964,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 686.3170000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3448.026000000027,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.783999999999999,
"layouts": 60,
"layoutDurationMs": 13.766,
"taskDurationMs": 1466.2740000000001,
"heapDeltaBytes": 9210120,
"heapUsedBytes": 73567584,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 664.146,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66618357487923,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3408.8930000000346,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.214,
"layouts": 60,
"layoutDurationMs": 12.674000000000001,
"taskDurationMs": 1460.284,
"heapDeltaBytes": 8461568,
"heapUsedBytes": 72197412,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 655.27,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666176470588237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3089.0080000000353,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.493000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1736.2410000000002,
"heapDeltaBytes": 20988636,
"heapUsedBytes": 86083368,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 867.793,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757065217391304,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2829.2579999999816,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.858000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1652.611,
"heapDeltaBytes": 25105020,
"heapUsedBytes": 89195440,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 831.4440000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666272189349108,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2026.7809999999713,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.007000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.182,
"heapDeltaBytes": 19763664,
"heapUsedBytes": 83148424,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.614000000000004,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2035.331000000042,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5520000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.31,
"heapDeltaBytes": -39356072,
"heapUsedBytes": 82343080,
"domNodes": -228,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 30.039999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 561.4500000000362,
"styleRecalcs": 50,
"styleRecalcDurationMs": 5.492,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.215,
"heapDeltaBytes": 12657988,
"heapUsedBytes": 94177704,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 128.57600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 543.8429999999244,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.258,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.896,
"heapDeltaBytes": 12664504,
"heapUsedBytes": 93836472,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 117.925,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2025.5369999999857,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.203000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.497,
"heapDeltaBytes": -23077424,
"heapUsedBytes": 58227580,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 8.421999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2056.8799999999783,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.498000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.38700000000006,
"heapDeltaBytes": -13591396,
"heapUsedBytes": 67932308,
"domNodes": -244,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.506,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.5529999999949,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.881,
"layouts": 16,
"layoutDurationMs": 5.071,
"taskDurationMs": 686.805,
"heapDeltaBytes": -3054260,
"heapUsedBytes": 77478636,
"domNodes": -244,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 85.15100000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.829411764705885,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.4989999999661,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.732999999999997,
"layouts": 16,
"layoutDurationMs": 5.423,
"taskDurationMs": 695.269,
"heapDeltaBytes": -21182372,
"heapUsedBytes": 60051496,
"domNodes": -244,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 86.95400000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1017.0359999999619,
"styleRecalcs": 16,
"styleRecalcDurationMs": 24.772999999999996,
"layouts": 5,
"layoutDurationMs": 9.868000000000002,
"taskDurationMs": 781.8990000000001,
"heapDeltaBytes": 23226864,
"heapUsedBytes": 95128048,
"domNodes": 13667,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 23.951,
"eventListeners": 2383,
"totalBlockingTimeMs": 126,
"frameDurationMs": 20.74693877551019,
"p95FrameDurationMs": 33.19999999999982
},
{
"name": "viewport-pan-sweep",
"durationMs": 8572.227999999996,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.15,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5456.4490000000005,
"heapDeltaBytes": -34294264,
"heapUsedBytes": 84751604,
"domNodes": -228,
"jsHeapTotalBytes": 618496,
"scriptDurationMs": 2608.545,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66614785992218,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8225.80000000005,
"styleRecalcs": 249,
"styleRecalcDurationMs": 27.730000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5061.262999999999,
"heapDeltaBytes": -41216916,
"heapUsedBytes": 78513192,
"domNodes": -228,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 2340.599,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665720081135902,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14458.168999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13760.643999999998,
"heapDeltaBytes": -46477620,
"heapUsedBytes": 160825836,
"domNodes": -3045,
"jsHeapTotalBytes": 4513792,
"scriptDurationMs": 243.985,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.51340388007055,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 14059.410999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12949.763,
"heapDeltaBytes": -3071292,
"heapUsedBytes": 193375704,
"domNodes": -3045,
"jsHeapTotalBytes": 10723328,
"scriptDurationMs": 270.217,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.299170812603645,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 17733.70300000005,
"styleRecalcs": 133,
"styleRecalcDurationMs": 17.85300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17549.053999999996,
"heapDeltaBytes": -28803984,
"heapUsedBytes": 164530728,
"domNodes": 0,
"jsHeapTotalBytes": -28049408,
"scriptDurationMs": 832.2199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 27,
"frameDurationMs": 34.49922178988327,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17340.103,
"styleRecalcs": 149,
"styleRecalcDurationMs": 16.819,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16928.377999999997,
"heapDeltaBytes": -39067860,
"heapUsedBytes": 166984816,
"domNodes": -3045,
"jsHeapTotalBytes": 7442432,
"scriptDurationMs": 811.97,
"eventListeners": -14915,
"totalBlockingTimeMs": 38,
"frameDurationMs": 32.06894639556377,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 5281.991000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.277,
"layouts": 20,
"layoutDurationMs": 25.361000000000008,
"taskDurationMs": 5225.313,
"heapDeltaBytes": -12166596,
"heapUsedBytes": 212305780,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 103.624,
"eventListeners": 0,
"totalBlockingTimeMs": 259,
"frameDurationMs": 32.50925925925926,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 4955.061000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.01299999999999,
"layouts": 20,
"layoutDurationMs": 22.98700000000001,
"taskDurationMs": 4829.102,
"heapDeltaBytes": 21048388,
"heapUsedBytes": 221472136,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 89.13499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 188,
"frameDurationMs": 30.1,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7532.656000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7346.996000000001,
"heapDeltaBytes": 22542788,
"heapUsedBytes": 195232168,
"domNodes": 0,
"jsHeapTotalBytes": -29360128,
"scriptDurationMs": 121.64199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.3395104895105,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6864.778999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6511.589999999998,
"heapDeltaBytes": -28060468,
"heapUsedBytes": 188675544,
"domNodes": -3045,
"jsHeapTotalBytes": 6209536,
"scriptDurationMs": 103.90300000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.512786885245905,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 480.97200000006524,
"styleRecalcs": 20,
"styleRecalcDurationMs": 17.726,
"layouts": 4,
"layoutDurationMs": 2.016,
"taskDurationMs": 146.864,
"heapDeltaBytes": -14755712,
"heapUsedBytes": 82174808,
"domNodes": 129,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 12.386,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241382,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 477.0979999999554,
"styleRecalcs": 15,
"styleRecalcDurationMs": 12.177,
"layouts": 3,
"layoutDurationMs": 0.9259999999999999,
"taskDurationMs": 127.04099999999998,
"heapDeltaBytes": -14240632,
"heapUsedBytes": 82865748,
"domNodes": 101,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.672,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 575.0020000000404,
"styleRecalcs": 78,
"styleRecalcDurationMs": 88.73,
"layouts": 76,
"layoutDurationMs": 16.13,
"taskDurationMs": 523.891,
"heapDeltaBytes": -8285592,
"heapUsedBytes": 78618116,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 185.485,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 595.4799999999523,
"styleRecalcs": 78,
"styleRecalcDurationMs": 88.936,
"layouts": 76,
"layoutDurationMs": 16.432,
"taskDurationMs": 552.3589999999999,
"heapDeltaBytes": -14254032,
"heapUsedBytes": 72487384,
"domNodes": 76,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 201.02900000000002,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 988.1369999999379,
"styleRecalcs": 78,
"styleRecalcDurationMs": 214.945,
"layouts": 76,
"layoutDurationMs": 16.939,
"taskDurationMs": 950.994,
"heapDeltaBytes": -20966276,
"heapUsedBytes": 108506124,
"domNodes": 76,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 295.65999999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.947457627118638,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 974.5870000000423,
"styleRecalcs": 78,
"styleRecalcDurationMs": 214.825,
"layouts": 76,
"layoutDurationMs": 16.054,
"taskDurationMs": 938.3760000000001,
"heapDeltaBytes": -21212176,
"heapUsedBytes": 108547160,
"domNodes": 76,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 286.60200000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491793,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge.
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #18643 +/- ##
==========================================
+ Coverage 84.11% 85.05% +0.93%
==========================================
Files 3164 2316 -848
Lines 154834 133882 -20952
Branches 40141 34449 -5692
==========================================
- Hits 130241 113870 -16371
+ Misses 22989 19691 -3298
+ Partials 1604 321 -1283
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 930 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 4 |
| 🟡 Medium | 5 |
| 🟢 Low | 1 |
Panel: 8/8 reviewers contributed findings.
- Guard group ID release behind the found-in-list check, so a redundant remove() can't return a live group's ID to the free pool - Move MAX_ID enforcement from observe* onto mint*: observe* now records the true unclamped high-water mark (rejecting only negative/non-integer input and agent/CRDT-range node ids), while mint* refuses to allocate past the ceiling - release* now ignore ids above MAX_ID instead of pooling them - Clear executionStore progress state and cached node outputs when a node's id is released, via the existing error-clearing hook - Wrap _deserializeItems's mutation body in try/finally so afterChange()/emitAfterChange() always run, even on a mid-paste throw - Validate decoded clipboard payloads against a minimal shape before committing to the ComfyUI-clipboard paste path, falling through to legacy paste for anything that doesn't match - Project only the four persisted counters in asSerialisable(), keeping the free-id pools out of saved workflows and clipboard data - Strengthen the recycled-ID assertions in two tests that had been weakened to tolerate ID recycling
|
🔗 Commit SHA: f7cbddc | Docs | View more details | Give us feedback! |
Pasting groups/nodes minted ids directly against the live graph state one item at a time. If a later mint (e.g. node ids) hit id-space exhaustion, earlier groups already added via graph.add() stayed committed instead of the whole paste being rolled back, and the group id counter was left advanced. Preflight both the groups and nodes counts against a disposable clone of the graph's id state before any mutation, mirroring the pattern already used by remapClipboardSubgraphNodeIds, so exhaustion throws before anything is added to the graph.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes required; the original group-to-node regression is fixed, but clipboard paste is still not atomic across all ID classes.
The prior finding is partially addressed: the added test now passes, and group/node capacity is checked before those loops run. One P1 remains. Reroute or link exhaustion can still happen after subgraphs, groups, and nodes have been committed. Also, remapClipboardSubgraphNodeIds runs before this preflight and commits allocator changes, so a later group preflight failure can still advance lastNodeId.
Verification on d203bb0: the existing clipboard suite passes 18/18; two focused variants fail, one leaving a pasted group after reroute exhaustion and one advancing lastNodeId when group preflight fails after subgraph remapping. Typecheck, formatting, ESLint, and type-aware Oxlint completed with no new errors.
There was a problem hiding this comment.
Verdict: approved; the remaining clipboard atomicity issue is fixed.
The preflight now covers subgraph normalization plus root groups, nodes, reroutes, and links before any allocator or graph mutation. Regressions cover both previously reproduced failures. Verification: clipboard 20/20, changed-area suites 250/250, app typecheck, formatting, full lint, and knip all pass.
Premature approval; full re-review in progress.
…austion-recycling Amp-Thread-ID: https://ampcode.com/threads/T-01a0d0b9-b759-73a9-833a-e61f0faadb1b # Conflicts: # src/workbench/extensions/agent/crdt/linkMintPort.ts
|
Playwright chromium shards 7, 15 and 16 failed on f7cbddc. Shards 15 and 16 are not this PR's: every failure is the app never finishing boot after a reload ( Generated by Claude Code |
|
Superseded by #19239, a Christian-owned replacement carrying the reviewed net change as one commit atop current main (787ed0b). The replacement preserves the live-main usePaste overlap behavior and has fresh focused and mutation evidence. Leaving this PR open so its review history remains available while the replacement is reviewed. |
…omfy-Org#15884) > [!NOTE] > Merge order: this, then Comfy-Org#19437 (charcoal surfaces and canvas), which targets this branch, then Comfy-Org#15893 (custom-palette surfaces), which targets `main` and lands after them. This PR can merge on its own. Comfy-Org#19437 still carries an earlier revision of this PR and will pick up the final one when it is updated against this branch. ## Summary With a media node selected, Ctrl+V pastes the copied node only when the OS clipboard proves it still holds the copy in litegraph's clipboard slot. ## Changes - **What**: On `main`, pasting onto a selected media node falls through to `canvas.pasteFromClipboard()`. That call deserializes litegraph's `localStorage` slot, not the OS clipboard, so copying text in another app and pasting onto an image node still dropped the last in-app copy. With this PR, on a media node the default paste runs only when the decoded OS clipboard payload equals the slot's content byte for byte. These cases skip it and show a short info toast ("Nothing to paste into this node"): - another app's text, - an earlier copy, - a menu Copy or Duplicate after the Ctrl+C. - `useCopy` keeps `main`'s HTML wrapper and payload byte for byte. A copy with identical content from an older build or another profile pastes, since the slot holds the same nodes. - The reader also accepts the wrappers Chromium adds on Windows (CF_HTML: `<html>\r\n<body>\r\n<!--StartFragment-->` … `<!--EndFragment-->\r\n</body>\r\n</html>`) and macOS (`<meta charset='utf-8'>`). Since Comfy-Org#19239, the anchored pattern never matched on those platforms, so canvas node paste there always fell back to the slot. - The clipboard keys move to `src/lib/litegraph/src/canvas/clipboardStorage.ts`. The template paths keep `main`'s slot restore, which leaves the slot equal to the clipboard after Save Selected as Template. ## Review Focus - Behavior on Windows and macOS Chromium, verified from Chromium's clipboard source (`clipboard_util_win.cc`, `clipboard_mac.mm`) and unit rows, not on those machines. A canvas Ctrl+V there now deserializes the OS payload instead of the slot, as Linux already did. After Ctrl+C on A and a menu Copy of B, `main` pastes B there and this PR pastes A. - Trade-off: a menu Copy (no Ctrl+C) followed by Ctrl+V onto a selected media node does not paste the node, because nothing proves the OS clipboard matches the slot. The toast says so instead of failing silently. - Comfy-Org#18643 edits the same reader and predates Comfy-Org#19239. Its media-node test expects the slot paste to run, so it conflicts with this rule. ## Testing - `pnpm test:unit src/composables/useCopy.test.ts src/composables/usePaste.test.ts src/extensions/core/nodeTemplates.test.ts`. Most rows copy through the real `useCopy` handler and paste through `usePaste`. Coverage: a canvas paste of a real copy, another app's text, earlier vs. latest copy, a menu copy after Ctrl+C, the Windows and macOS wrappers, and a Comfy fragment inside arbitrary HTML. - `pnpm test:browser:local browser_tests/tests/copyPaste.spec.ts --grep "latest copy"`: passes 3/3 at head. On a `main` build it fails at the replaced-clipboard step, where `main` pastes the stale node. --- _Generated by [Claude Code](https://claude.ai/code)_ --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
Summary
Remove the arbitrary 100,000,000 graph-ID ceiling. Allocation remains monotonic through the safe-integer range, then recovers by selecting an unused positive safe integer instead of throwing or immediately recycling deleted identities.
Changes
Number.MAX_SAFE_INTEGERusing root-wide live-ID reservations.ClipboardItems; malformed data falls through to normal paste handling.Review Focus
idAllocation.ts.Test plan
pnpm typecheckpnpm lint(0 errors; existing warnings only)pnpm format:checkpnpm knip --cache