Repository navigation
Agent CRDT: pending-delete retention store (long-term, FE-2504 stopgap) - #18642
claude[bot] wants to merge 4 commits into
Conversation
Reintroduces the material split out of #18276 per DrJKL's review, on top of that PR's narrow detach()-drain fix: a PendingDeleteRetentionStore subsystem that suppresses resurrection of a human-deleted node across follower/panel/principal lifecycles, with per-op identity metadata captured by opSender at admission time and consulted by useAgentCrdtFollower's reconcile. This is an explicitly scoped, time-boxed stopgap pending FE-2504's provenance-based rework (one path through LGraph/LGraphNode commands, zero reconciles), per DrJKL's review on #18276. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QSwYxDRtea95cYt1sVq7Nc
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2159 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since dd6f1991955631061531e2fbfde898854d708615
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-28T21:54:03.877Z",
"gitSha": "a42ece0aa07c79b15db81835bdc577800ea0b263",
"branch": "agent/pending-delete-retention-store-fe-2504",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2042.1340000000328,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.4639999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.9759999999999,
"heapDeltaBytes": -38499300,
"heapUsedBytes": 59729664,
"domNodes": -228,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 11.883000000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2020.163000000025,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.304999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.79200000000003,
"heapDeltaBytes": -20013788,
"heapUsedBytes": 58777100,
"domNodes": -228,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 11.77,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1900.314000000094,
"styleRecalcs": 74,
"styleRecalcDurationMs": 20.865,
"layouts": 12,
"layoutDurationMs": 5.059,
"taskDurationMs": 935.9439999999998,
"heapDeltaBytes": -18729260,
"heapUsedBytes": 59938304,
"domNodes": -228,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 164.36999999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2000.458999999978,
"styleRecalcs": 82,
"styleRecalcDurationMs": 18.637,
"layouts": 12,
"layoutDurationMs": 5.111,
"taskDurationMs": 934.1780000000001,
"heapDeltaBytes": -15185652,
"heapUsedBytes": 63774872,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.92399999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.94830508474577,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1759.5179999999573,
"styleRecalcs": 33,
"styleRecalcDurationMs": 11.674999999999997,
"layouts": 6,
"layoutDurationMs": 1.4460000000000002,
"taskDurationMs": 396.304,
"heapDeltaBytes": 1447956,
"heapUsedBytes": 80204724,
"domNodes": 53,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 15.158000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1747.0500000000584,
"styleRecalcs": 34,
"styleRecalcDurationMs": 10.831,
"layouts": 6,
"layoutDurationMs": 1.48,
"taskDurationMs": 393.45799999999997,
"heapDeltaBytes": -18785548,
"heapUsedBytes": 79790212,
"domNodes": 53,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 14.777000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 790.3129999999692,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.321000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.5179999999999,
"heapDeltaBytes": -14019364,
"heapUsedBytes": 64572272,
"domNodes": -198,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 179.033,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.40666666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 763.3180000000266,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.384,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.1899999999999,
"heapDeltaBytes": 18300308,
"heapUsedBytes": 97532848,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 171.921,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1172.329999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 807.499,
"heapDeltaBytes": 6426472,
"heapUsedBytes": 82164704,
"domNodes": 0,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 59.74700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 549,
"frameDurationMs": 35.351515151515166,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1177.9619999999795,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 874.146,
"heapDeltaBytes": 6811536,
"heapUsedBytes": 84283372,
"domNodes": 0,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 63.270999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 553,
"frameDurationMs": 34.8029411764706,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.3099999999076,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.9409999999996,
"heapDeltaBytes": -16567564,
"heapUsedBytes": 68136936,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 145.51500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 189,
"frameDurationMs": 24.508823529411742,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 826.814000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.8649999999999,
"heapDeltaBytes": 17055284,
"heapUsedBytes": 90245652,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 156.236,
"eventListeners": 0,
"totalBlockingTimeMs": 193,
"frameDurationMs": 24.508823529411742,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9989.789999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8904.546,
"heapDeltaBytes": -10042672,
"heapUsedBytes": 70649468,
"domNodes": 0,
"jsHeapTotalBytes": -13631488,
"scriptDurationMs": 7002.244999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 601,
"frameDurationMs": 32.51758957654724,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8545.371000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7922.419000000001,
"heapDeltaBytes": 11324896,
"heapUsedBytes": 91466812,
"domNodes": 0,
"jsHeapTotalBytes": -16515072,
"scriptDurationMs": 6381.495,
"eventListeners": 0,
"totalBlockingTimeMs": 414,
"frameDurationMs": 34.062549800796816,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8383.811000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7720.148999999999,
"heapDeltaBytes": 1604516,
"heapUsedBytes": 83060392,
"domNodes": 0,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 6205.463,
"eventListeners": 0,
"totalBlockingTimeMs": 388,
"frameDurationMs": 33.66626506024096,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10065.311000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9077.318,
"heapDeltaBytes": 3761228,
"heapUsedBytes": 84466528,
"domNodes": 0,
"jsHeapTotalBytes": -1572864,
"scriptDurationMs": 7204.381,
"eventListeners": 0,
"totalBlockingTimeMs": 757,
"frameDurationMs": 31.702208201892745,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2017.7179999999453,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.021000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.028,
"heapDeltaBytes": 20107984,
"heapUsedBytes": 82053376,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.611000000000004,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2010.917999999947,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.156999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 611.0989999999999,
"heapDeltaBytes": 20148808,
"heapUsedBytes": 83020924,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.985,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3086.021999999957,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.3,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1760.116,
"heapDeltaBytes": 428316,
"heapUsedBytes": 62887908,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 870.738,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66594594594595,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3101.9390000000158,
"styleRecalcs": 66,
"styleRecalcDurationMs": 9.431999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1798.8450000000003,
"heapDeltaBytes": 24218076,
"heapUsedBytes": 86483788,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 863.667,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3968.7679999999546,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.74,
"layouts": 60,
"layoutDurationMs": 14.754000000000001,
"taskDurationMs": 1809.9389999999999,
"heapDeltaBytes": 9807344,
"heapUsedBytes": 73570624,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 809.856,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665966386554622,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4052.7060000000574,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.593,
"layouts": 60,
"layoutDurationMs": 14.847,
"taskDurationMs": 1849.573,
"heapDeltaBytes": 12894036,
"heapUsedBytes": 76649672,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 810.554,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665843621399176,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3151.535000000081,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.641000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2064.633,
"heapDeltaBytes": 2751408,
"heapUsedBytes": 67370512,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 1005.0679999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84438502673797,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3191.734999999994,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.9670000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2093.0559999999996,
"heapDeltaBytes": 31469840,
"heapUsedBytes": 95547344,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1046.8069999999998,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.841578947368426,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2025.2689999999802,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.2829999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.6349999999999,
"heapDeltaBytes": 20713116,
"heapUsedBytes": 83607740,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.06200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.7479999999596,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.2840000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 632.8380000000001,
"heapDeltaBytes": 20867344,
"heapUsedBytes": 83214400,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.846000000000004,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 737.844999999993,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.95300000000003,
"heapDeltaBytes": 13231280,
"heapUsedBytes": 93437512,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 146.242,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 729.5289999999568,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.544000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.36000000000007,
"heapDeltaBytes": 13205260,
"heapUsedBytes": 93646292,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 158.48800000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069753,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2038.2199999999102,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8590000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.7689999999999,
"heapDeltaBytes": -17880036,
"heapUsedBytes": 63303852,
"domNodes": -244,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 11.415000000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2053.062999999952,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.814999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.364,
"heapDeltaBytes": -19143832,
"heapUsedBytes": 60942624,
"domNodes": -244,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.609999999999998,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1809.7669999999653,
"styleRecalcs": 72,
"styleRecalcDurationMs": 21.293,
"layouts": 16,
"layoutDurationMs": 8.513,
"taskDurationMs": 928.9110000000001,
"heapDeltaBytes": -3369668,
"heapUsedBytes": 78135508,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.826,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.8214953271028,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1772.805999999946,
"styleRecalcs": 71,
"styleRecalcDurationMs": 18.759999999999998,
"layouts": 16,
"layoutDurationMs": 6.072000000000001,
"taskDurationMs": 819.5150000000001,
"heapDeltaBytes": -3334460,
"heapUsedBytes": 78163576,
"domNodes": -244,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 115.20400000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.82358490566038,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.2779999999339,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.772000000000006,
"layouts": 5,
"layoutDurationMs": 11.399000000000003,
"taskDurationMs": 943.9370000000002,
"heapDeltaBytes": 23295488,
"heapUsedBytes": 98330684,
"domNodes": 13667,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.86600000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 126,
"frameDurationMs": 19.952112676056345,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 11318.268999999986,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.787,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6424.778,
"heapDeltaBytes": -55292180,
"heapUsedBytes": 64110912,
"domNodes": -228,
"jsHeapTotalBytes": 425984,
"scriptDurationMs": 2876.9339999999997,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6905604719764,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11430.022000000008,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.187999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6466.0650000000005,
"heapDeltaBytes": -35611064,
"heapUsedBytes": 83211788,
"domNodes": -228,
"jsHeapTotalBytes": -167936,
"scriptDurationMs": 2878.811,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666131386861313,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15380.610999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15045.490999999998,
"heapDeltaBytes": -64348620,
"heapUsedBytes": 160542248,
"domNodes": -3045,
"jsHeapTotalBytes": 5210112,
"scriptDurationMs": 302.2,
"eventListeners": -14915,
"totalBlockingTimeMs": 5,
"frameDurationMs": 28.883646616541355,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 11490.307999999914,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11146.217,
"heapDeltaBytes": -48286952,
"heapUsedBytes": 179926604,
"domNodes": -3045,
"jsHeapTotalBytes": 2609152,
"scriptDurationMs": 275.902,
"eventListeners": -14915,
"totalBlockingTimeMs": 32,
"frameDurationMs": 21.779356060606062,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 18926.733000000015,
"styleRecalcs": 139,
"styleRecalcDurationMs": 18.647999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18780.260000000002,
"heapDeltaBytes": -10254724,
"heapUsedBytes": 187544800,
"domNodes": -3045,
"jsHeapTotalBytes": 9146368,
"scriptDurationMs": 918.755,
"eventListeners": -14915,
"totalBlockingTimeMs": 36,
"frameDurationMs": 36.73009708737864,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 19038.89700000002,
"styleRecalcs": 135,
"styleRecalcDurationMs": 17.958000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18909.992,
"heapDeltaBytes": -23154780,
"heapUsedBytes": 178940380,
"domNodes": -3046,
"jsHeapTotalBytes": 6488064,
"scriptDurationMs": 909.3570000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 20,
"frameDurationMs": 37.72138613861386,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4220.646999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.55000000000001,
"layouts": 20,
"layoutDurationMs": 26.969999999999995,
"taskDurationMs": 4145.3550000000005,
"heapDeltaBytes": 14206744,
"heapUsedBytes": 221350536,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 86.02900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 14,
"frameDurationMs": 25.60853658536586,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 5639.115000000174,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.544,
"layouts": 20,
"layoutDurationMs": 26.528999999999996,
"taskDurationMs": 5615.985,
"heapDeltaBytes": -4359900,
"heapUsedBytes": 180990632,
"domNodes": -8049,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 97.91000000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 306,
"frameDurationMs": 34.661963190184046,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5925.567999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5642.241,
"heapDeltaBytes": -19538472,
"heapUsedBytes": 180204752,
"domNodes": -3046,
"jsHeapTotalBytes": 7651328,
"scriptDurationMs": 99.95099999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.496739130434776,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7985.206000000062,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7861.363999999999,
"heapDeltaBytes": -19898744,
"heapUsedBytes": 178922920,
"domNodes": -3045,
"jsHeapTotalBytes": 3977216,
"scriptDurationMs": 129.36099999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.46946564885496,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 171.87999999998738,
"styleRecalcs": 10,
"styleRecalcDurationMs": 16.386000000000003,
"layouts": 4,
"layoutDurationMs": 2.6229999999999998,
"taskDurationMs": 140.173,
"heapDeltaBytes": -17135204,
"heapUsedBytes": 79798376,
"domNodes": 117,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 12.962000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 164.1740000000027,
"styleRecalcs": 10,
"styleRecalcDurationMs": 19.119,
"layouts": 4,
"layoutDurationMs": 1.9310000000000003,
"taskDurationMs": 124.974,
"heapDeltaBytes": -16811392,
"heapUsedBytes": 80241104,
"domNodes": 95,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 12.901000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1239.426000000094,
"styleRecalcs": 78,
"styleRecalcDurationMs": 121.127,
"layouts": 76,
"layoutDurationMs": 29.657,
"taskDurationMs": 1208.057,
"heapDeltaBytes": -4534788,
"heapUsedBytes": 67291672,
"domNodes": 76,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 492.65500000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.894520547945195,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1236.406999999872,
"styleRecalcs": 78,
"styleRecalcDurationMs": 119.714,
"layouts": 76,
"layoutDurationMs": 29.131,
"taskDurationMs": 1209.5369999999998,
"heapDeltaBytes": -4498548,
"heapUsedBytes": 67332068,
"domNodes": 76,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 483.12899999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.136619718309856,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1527.4010000000544,
"styleRecalcs": 78,
"styleRecalcDurationMs": 270.083,
"layouts": 76,
"layoutDurationMs": 27.123,
"taskDurationMs": 1502.307,
"heapDeltaBytes": 9293032,
"heapUsedBytes": 115941872,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 488.12899999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.104878048780492,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1571.7580000000453,
"styleRecalcs": 78,
"styleRecalcDurationMs": 281.64099999999996,
"layouts": 76,
"layoutDurationMs": 29.015,
"taskDurationMs": 1558.312,
"heapDeltaBytes": -18021904,
"heapUsedBytes": 111340032,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 508.706,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.478313253012036,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## fix/agent-crdt-detach-settles-pending-ops #18642 +/- ##
=============================================================================
+ Coverage 85.12% 85.14% +0.01%
=============================================================================
Files 2341 2343 +2
Lines 134695 134844 +149
Branches 37223 35345 -1878
=============================================================================
+ Hits 114661 114808 +147
- Misses 19680 19682 +2
Partials 354 354
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
The current #18276 diff no longer touches packages/ingest-types (that work moved to #18642 in the retention-store split), so this entry was a merge-conflict-era holdover left behind after narrowing the PR. Per DrJKL's review: #18276 (comment)
…nding-ops' into agent/pending-delete-retention-store-fe-2504 # Conflicts: # src/workbench/extensions/agent/crdt/opSender.test.ts # src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts
…nding-ops' into agent/pending-delete-retention-store-fe-2504 # Conflicts: # src/workbench/extensions/agent/crdt/opSender.test.ts # src/workbench/extensions/agent/crdt/opSender.ts
…nding-ops' into agent/pending-delete-retention-store-fe-2504 # Conflicts: # src/workbench/extensions/agent/AgentPanelRoot.vue # src/workbench/extensions/agent/crdt/opSender.ts # src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts # src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts
|
Closing as superseded by #18700 (the merged graph-first CRDT follower), which removes the materializer/reconciliation layer this stopgap targets. |
Requested by Christian Byrne · Slack thread
Summary
This carries forward the
PendingDeleteRetentionStoresubsystem that was split out of #18276 per DrJKL's review on that PR. #18276 now contains only the narrow, independently-soundopSender.detach()drain/settle fix; this PR carries everything else that had grown on top of it over that PR's review rounds.Base branch: this PR targets
fix/agent-crdt-detach-settles-pending-ops(#18276), notmain. The retention store's reconcile-suppression logic and itsopSenderper-op identity metadata capture build directly on that PR'sdetach()/drainOutstanding()behavior, so this stays stacked on it rather than re-deriving an independent diff againstmain. Once #18276 merges, this PR's base will need to be retargeted tomain(or it will simply show only its own commit once GitHub recomputes the diff after that merge).Before
useAgentCrdtFollowertracked human-confirmed deletes in a localconfirmedDeletes: Set<string>that lived and died with the follower instance, cleared ondoc_reset. Resurrection could still slip through a follower/panel remount or a principal/workspace switch.After
opSender.tscaptures opaque per-opadmissionMetadataat admission time (adelete_node's target Yjs item identity), keyed by the op's ownop_id, and hands it back on that op'sBatchOutcome.PendingDeleteRetentionStore(pendingDeleteRetentionStore.ts) is page-lifetime, not follower-scoped:AgentPanelRoot.vueshares one instance (sharedPendingDeleteRetentionStore) across every follower it creates, so a confirmed delete survives a follower being disposed and a new one mounted for the same workflow (panel dock close/reopen, product-gate toggle).useAgentCrdtFollower's reconcile consults the store (retainedNodeIds) instead of the oldconfirmedDeletesset, with a bounded expiry forunknown-outcome deletes and adocCaughtUpguard so a freshly-reminted, not-yet-caught-up doc can't be read as authoritative proof the node is gone.clearWorkflowondoc_reset; a separateclearAll(), driven byAgentPanelRoot.vue'sonboardingKeywatch, drops every workflow's retention on a signed-in principal or workspace change.Why a stopgap
Per DrJKL's review on #18276, this deepens a store-first/reconciliation-compensation pattern that the FE-2504 rework is meant to remove in favor of one path through
LGraph/LGraphNodecommands with provenance and zero reconciles. This PR is explicitly scoped and time-boxed: it exists to close the resurrection gap now, and should be superseded by FE-2504's rework rather than extended further.Refs #18276.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QSwYxDRtea95cYt1sVq7Nc
Generated by Claude Code