Skip to content

Agent CRDT: pending-delete retention store (long-term, FE-2504 stopgap) - #18642

Closed
claude[bot] wants to merge 4 commits into
fix/agent-crdt-detach-settles-pending-opsfrom
agent/pending-delete-retention-store-fe-2504
Closed

claude[bot] wants to merge 4 commits into
fix/agent-crdt-detach-settles-pending-opsfrom
agent/pending-delete-retention-store-fe-2504

Conversation

@claude

@claude claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Requested by Christian Byrne · Slack thread

Summary

This carries forward the PendingDeleteRetentionStore subsystem that was split out of #18276 per DrJKL's review on that PR. #18276 now contains only the narrow, independently-sound opSender.detach() drain/settle fix; this PR carries everything else that had grown on top of it over that PR's review rounds.

Base branch: this PR targets fix/agent-crdt-detach-settles-pending-ops (#18276), not main. The retention store's reconcile-suppression logic and its opSender per-op identity metadata capture build directly on that PR's detach()/drainOutstanding() behavior, so this stays stacked on it rather than re-deriving an independent diff against main. Once #18276 merges, this PR's base will need to be retargeted to main (or it will simply show only its own commit once GitHub recomputes the diff after that merge).

Before

  • useAgentCrdtFollower tracked human-confirmed deletes in a local confirmedDeletes: Set<string> that lived and died with the follower instance, cleared on doc_reset. Resurrection could still slip through a follower/panel remount or a principal/workspace switch.

After

  • opSender.ts captures opaque per-op admissionMetadata at admission time (a delete_node's target Yjs item identity), keyed by the op's own op_id, and hands it back on that op's BatchOutcome.
  • A new PendingDeleteRetentionStore (pendingDeleteRetentionStore.ts) is page-lifetime, not follower-scoped: AgentPanelRoot.vue shares one instance (sharedPendingDeleteRetentionStore) across every follower it creates, so a confirmed delete survives a follower being disposed and a new one mounted for the same workflow (panel dock close/reopen, product-gate toggle).
  • useAgentCrdtFollower's reconcile consults the store (retainedNodeIds) instead of the old confirmedDeletes set, with a bounded expiry for unknown-outcome deletes and a docCaughtUp guard so a freshly-reminted, not-yet-caught-up doc can't be read as authoritative proof the node is gone.
  • clearWorkflow on doc_reset; a separate clearAll(), driven by AgentPanelRoot.vue's onboardingKey watch, drops every workflow's retention on a signed-in principal or workspace change.

Why a stopgap

Per DrJKL's review on #18276, this deepens a store-first/reconciliation-compensation pattern that the FE-2504 rework is meant to remove in favor of one path through LGraph/LGraphNode commands with provenance and zero reconciles. This PR is explicitly scoped and time-boxed: it exists to close the resurrection gap now, and should be superseded by FE-2504's rework rather than extended further.

Refs #18276.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QSwYxDRtea95cYt1sVq7Nc


Generated by Claude Code

Reintroduces the material split out of #18276 per DrJKL's review, on
top of that PR's narrow detach()-drain fix: a PendingDeleteRetentionStore
subsystem that suppresses resurrection of a human-deleted node across
follower/panel/principal lifecycles, with per-op identity metadata
captured by opSender at admission time and consulted by
useAgentCrdtFollower's reconcile.

This is an explicitly scoped, time-boxed stopgap pending FE-2504's
provenance-based rework (one path through LGraph/LGraphNode commands,
zero reconciles), per DrJKL's review on #18276.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QSwYxDRtea95cYt1sVq7Nc
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: bd68d8cf-799c-4a22-be63-22b6fdec0798

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/28/2026, 09:48:06 PM UTC

Links

🎭 Playwright: ✅ 2159 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2138 / ❌ 0 / ⚠️ 0 / ⏭️ 9)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since dd6f1991955631061531e2fbfde898854d708615

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.5 MB heap
canvas-mouse-sweep: · 59.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.3 MB heap
dom-widget-clipping: · 58.7 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.3 MB heap
dom-widget-order-dense-n200-w200-i120: · 28.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 551ms TBT · 79.4 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 40.8 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 191ms TBT · 75.5 MB heap
extension-clean-combined-draw: · 30.0 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 508ms TBT · 77.3 MB heap
extension-rgthree-prototype-draw: · 30.6 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 573ms TBT · 79.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
legacy-node-drag: · 59.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.2 MB heap
subgraph-mouse-sweep: · 59.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.5 MB heap
subgraph-transition-enter: · 50.1 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 126ms TBT · 93.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap
vue-large-graph-idle: · 39.5 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 19ms TBT · 162.3 MB heap
vue-large-graph-pan: · 26.9 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 28ms TBT · 174.8 MB heap
vue-node-resize-workload: · 33.2 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 160ms TBT · 191.9 MB heap
vue-zoom-out-idle: · 38.5 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 171.2 MB heap
workflow-execution: · 56.5 avg FPS · 39.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 76.3 MB heap
agent-composer-empty-conversation-typing: · 58.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
agent-composer-long-conversation-typing: · 51.8 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 108.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 4ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 523ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 56.5 MB
canvas-idle: DOM nodes -228
canvas-idle: event listeners -153
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 20ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 935ms
canvas-mouse-sweep: script duration 162ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.0 MB
canvas-mouse-sweep: DOM nodes -228
canvas-mouse-sweep: event listeners -142
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 11ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 34
canvas-zoom-sweep: task duration 395ms
canvas-zoom-sweep: script duration 15ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 76.3 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 524ms
dom-widget-clipping: script duration 175ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 77.3 MB
dom-widget-clipping: DOM nodes -99
dom-widget-clipping: event listeners -71
dom-widget-order-dense-n200-w200-i120: avg frame time 35ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 841ms
dom-widget-order-dense-n200-w200-i120: script duration 62ms
dom-widget-order-dense-n200-w200-i120: TBT 551ms
dom-widget-order-dense-n200-w200-i120: heap used 79.4 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 33ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 466ms
dom-widget-order-sparse-n1000-w20-i120: script duration 151ms
dom-widget-order-sparse-n1000-w20-i120: TBT 191ms
dom-widget-order-sparse-n1000-w20-i120: heap used 75.5 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 33ms
extension-clean-combined-draw: p95 frame time 58ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 8413ms
extension-clean-combined-draw: script duration 6692ms
extension-clean-combined-draw: TBT 508ms
extension-clean-combined-draw: heap used 77.3 MB
extension-clean-combined-draw: DOM nodes 0
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 33ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 8399ms
extension-rgthree-prototype-draw: script duration 6705ms
extension-rgthree-prototype-draw: TBT 573ms
extension-rgthree-prototype-draw: heap used 79.9 MB
extension-rgthree-prototype-draw: DOM nodes 0
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 617ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 78.7 MB
large-graph-idle: DOM nodes -228
large-graph-idle: event listeners -153
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1779ms
large-graph-pan: script duration 867ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 71.2 MB
large-graph-pan: DOM nodes -114
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 15ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1830ms
large-graph-zoom: script duration 810ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.6 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 2079ms
legacy-node-drag: script duration 1026ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.7 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 1ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 618ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 79.5 MB
minimap-idle: DOM nodes -114
minimap-idle: event listeners -71
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 461ms
subgraph-dom-widget-clipping: script duration 152ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 89.2 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 4ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 524ms
subgraph-idle: script duration 11ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 59.2 MB
subgraph-idle: DOM nodes -244
subgraph-idle: event listeners -188
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 7ms
subgraph-mouse-sweep: style recalc duration 20ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 72
subgraph-mouse-sweep: task duration 874ms
subgraph-mouse-sweep: script duration 116ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 74.5 MB
subgraph-mouse-sweep: DOM nodes -244
subgraph-mouse-sweep: event listeners -210
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 33ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 16
subgraph-transition-enter: task duration 944ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 126ms
subgraph-transition-enter: heap used 93.8 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 6445ms
viewport-pan-sweep: script duration 2878ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 70.2 MB
viewport-pan-sweep: DOM nodes -228
viewport-pan-sweep: event listeners -153
vue-large-graph-idle: avg frame time 25ms
vue-large-graph-idle: p95 frame time 42ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 13096ms
vue-large-graph-idle: script duration 289ms
vue-large-graph-idle: TBT 19ms
vue-large-graph-idle: heap used 162.3 MB
vue-large-graph-idle: DOM nodes -3045
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 37ms
vue-large-graph-pan: p95 frame time 67ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 137
vue-large-graph-pan: task duration 18845ms
vue-large-graph-pan: script duration 914ms
vue-large-graph-pan: TBT 28ms
vue-large-graph-pan: heap used 174.8 MB
vue-large-graph-pan: DOM nodes -3046
vue-large-graph-pan: event listeners -14915
vue-node-resize-workload: avg frame time 30ms
vue-node-resize-workload: p95 frame time 58ms
vue-node-resize-workload: layout duration 27ms
vue-node-resize-workload: style recalc duration 77ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4881ms
vue-node-resize-workload: script duration 92ms
vue-node-resize-workload: TBT 160ms
vue-node-resize-workload: heap used 191.9 MB
vue-node-resize-workload: DOM nodes -4025
vue-node-resize-workload: event listeners -7462
vue-zoom-out-idle: avg frame time 26ms
vue-zoom-out-idle: p95 frame time 42ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6752ms
vue-zoom-out-idle: script duration 115ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 171.2 MB
vue-zoom-out-idle: DOM nodes -3046
vue-zoom-out-idle: event listeners -14915
workflow-execution: avg frame time 18ms
workflow-execution: p95 frame time 25ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 4
workflow-execution: style recalc count 10
workflow-execution: task duration 133ms
workflow-execution: script duration 13ms
workflow-execution: TBT 0ms
workflow-execution: heap used 76.3 MB
workflow-execution: DOM nodes 106
workflow-execution: event listeners 25
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 29ms
agent-composer-empty-conversation-typing: style recalc duration 120ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 1209ms
agent-composer-empty-conversation-typing: script duration 488ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 64.2 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 19ms
agent-composer-long-conversation-typing: p95 frame time 33ms
agent-composer-long-conversation-typing: layout duration 28ms
agent-composer-long-conversation-typing: style recalc duration 276ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 1530ms
agent-composer-long-conversation-typing: script duration 498ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 108.4 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-09-28T21:54:03.877Z",
  "gitSha": "a42ece0aa07c79b15db81835bdc577800ea0b263",
  "branch": "agent/pending-delete-retention-store-fe-2504",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2042.1340000000328,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.4639999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 538.9759999999999,
      "heapDeltaBytes": -38499300,
      "heapUsedBytes": 59729664,
      "domNodes": -228,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 11.883000000000001,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2020.163000000025,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.304999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.79200000000003,
      "heapDeltaBytes": -20013788,
      "heapUsedBytes": 58777100,
      "domNodes": -228,
      "jsHeapTotalBytes": -524288,
      "scriptDurationMs": 11.77,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1900.314000000094,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 20.865,
      "layouts": 12,
      "layoutDurationMs": 5.059,
      "taskDurationMs": 935.9439999999998,
      "heapDeltaBytes": -18729260,
      "heapUsedBytes": 59938304,
      "domNodes": -228,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 164.36999999999998,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2000.458999999978,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 18.637,
      "layouts": 12,
      "layoutDurationMs": 5.111,
      "taskDurationMs": 934.1780000000001,
      "heapDeltaBytes": -15185652,
      "heapUsedBytes": 63774872,
      "domNodes": -228,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 159.92399999999998,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.94830508474577,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1759.5179999999573,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 11.674999999999997,
      "layouts": 6,
      "layoutDurationMs": 1.4460000000000002,
      "taskDurationMs": 396.304,
      "heapDeltaBytes": 1447956,
      "heapUsedBytes": 80204724,
      "domNodes": 53,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 15.158000000000001,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1747.0500000000584,
      "styleRecalcs": 34,
      "styleRecalcDurationMs": 10.831,
      "layouts": 6,
      "layoutDurationMs": 1.48,
      "taskDurationMs": 393.45799999999997,
      "heapDeltaBytes": -18785548,
      "heapUsedBytes": 79790212,
      "domNodes": 53,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 14.777000000000003,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 790.3129999999692,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.321000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 551.5179999999999,
      "heapDeltaBytes": -14019364,
      "heapUsedBytes": 64572272,
      "domNodes": -198,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 179.033,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.40666666666667,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 763.3180000000266,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.384,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 497.1899999999999,
      "heapDeltaBytes": 18300308,
      "heapUsedBytes": 97532848,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 171.921,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1172.329999999988,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 807.499,
      "heapDeltaBytes": 6426472,
      "heapUsedBytes": 82164704,
      "domNodes": 0,
      "jsHeapTotalBytes": 4620288,
      "scriptDurationMs": 59.74700000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 549,
      "frameDurationMs": 35.351515151515166,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1177.9619999999795,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 874.146,
      "heapDeltaBytes": 6811536,
      "heapUsedBytes": 84283372,
      "domNodes": 0,
      "jsHeapTotalBytes": 3047424,
      "scriptDurationMs": 63.270999999999994,
      "eventListeners": 0,
      "totalBlockingTimeMs": 553,
      "frameDurationMs": 34.8029411764706,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 841.3099999999076,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 460.9409999999996,
      "heapDeltaBytes": -16567564,
      "heapUsedBytes": 68136936,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 145.51500000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 189,
      "frameDurationMs": 24.508823529411742,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 826.814000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 470.8649999999999,
      "heapDeltaBytes": 17055284,
      "heapUsedBytes": 90245652,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 156.236,
      "eventListeners": 0,
      "totalBlockingTimeMs": 193,
      "frameDurationMs": 24.508823529411742,
      "p95FrameDurationMs": 33.30000000000109
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9989.789999999972,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8904.546,
      "heapDeltaBytes": -10042672,
      "heapUsedBytes": 70649468,
      "domNodes": 0,
      "jsHeapTotalBytes": -13631488,
      "scriptDurationMs": 7002.244999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 601,
      "frameDurationMs": 32.51758957654724,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 8545.371000000046,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7922.419000000001,
      "heapDeltaBytes": 11324896,
      "heapUsedBytes": 91466812,
      "domNodes": 0,
      "jsHeapTotalBytes": -16515072,
      "scriptDurationMs": 6381.495,
      "eventListeners": 0,
      "totalBlockingTimeMs": 414,
      "frameDurationMs": 34.062549800796816,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 8383.811000000038,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7720.148999999999,
      "heapDeltaBytes": 1604516,
      "heapUsedBytes": 83060392,
      "domNodes": 0,
      "jsHeapTotalBytes": -15204352,
      "scriptDurationMs": 6205.463,
      "eventListeners": 0,
      "totalBlockingTimeMs": 388,
      "frameDurationMs": 33.66626506024096,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10065.311000000065,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9077.318,
      "heapDeltaBytes": 3761228,
      "heapUsedBytes": 84466528,
      "domNodes": 0,
      "jsHeapTotalBytes": -1572864,
      "scriptDurationMs": 7204.381,
      "eventListeners": 0,
      "totalBlockingTimeMs": 757,
      "frameDurationMs": 31.702208201892745,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2017.7179999999453,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.021000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 622.028,
      "heapDeltaBytes": 20107984,
      "heapUsedBytes": 82053376,
      "domNodes": -228,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 36.611000000000004,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2010.917999999947,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 2.156999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 611.0989999999999,
      "heapDeltaBytes": 20148808,
      "heapUsedBytes": 83020924,
      "domNodes": -228,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 33.985,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3086.021999999957,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 10.3,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1760.116,
      "heapDeltaBytes": 428316,
      "heapUsedBytes": 62887908,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 870.738,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66594594594595,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3101.9390000000158,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 9.431999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1798.8450000000003,
      "heapDeltaBytes": 24218076,
      "heapUsedBytes": 86483788,
      "domNodes": -228,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 863.667,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3968.7679999999546,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 10.74,
      "layouts": 60,
      "layoutDurationMs": 14.754000000000001,
      "taskDurationMs": 1809.9389999999999,
      "heapDeltaBytes": 9807344,
      "heapUsedBytes": 73570624,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 809.856,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665966386554622,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4052.7060000000574,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 11.593,
      "layouts": 60,
      "layoutDurationMs": 14.847,
      "taskDurationMs": 1849.573,
      "heapDeltaBytes": 12894036,
      "heapUsedBytes": 76649672,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 810.554,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665843621399176,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3151.535000000081,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 6.641000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2064.633,
      "heapDeltaBytes": 2751408,
      "heapUsedBytes": 67370512,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 1005.0679999999999,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.84438502673797,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3191.734999999994,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 6.9670000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2093.0559999999996,
      "heapDeltaBytes": 31469840,
      "heapUsedBytes": 95547344,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 1046.8069999999998,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.841578947368426,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2025.2689999999802,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.2829999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 603.6349999999999,
      "heapDeltaBytes": 20713116,
      "heapUsedBytes": 83607740,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 35.06200000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2018.7479999999596,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 1.2840000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 632.8380000000001,
      "heapDeltaBytes": 20867344,
      "heapUsedBytes": 83214400,
      "domNodes": -228,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 37.846000000000004,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 737.844999999993,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 8.006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 452.95300000000003,
      "heapDeltaBytes": 13231280,
      "heapUsedBytes": 93437512,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 146.242,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665909090909096,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 729.5289999999568,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 6.544000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 469.36000000000007,
      "heapDeltaBytes": 13205260,
      "heapUsedBytes": 93646292,
      "domNodes": 0,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 158.48800000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665116279069753,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2038.2199999999102,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.8590000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 531.7689999999999,
      "heapDeltaBytes": -17880036,
      "heapUsedBytes": 63303852,
      "domNodes": -244,
      "jsHeapTotalBytes": -1310720,
      "scriptDurationMs": 11.415000000000001,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2053.062999999952,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.814999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 516.364,
      "heapDeltaBytes": -19143832,
      "heapUsedBytes": 60942624,
      "domNodes": -244,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 10.609999999999998,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1809.7669999999653,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 21.293,
      "layouts": 16,
      "layoutDurationMs": 8.513,
      "taskDurationMs": 928.9110000000001,
      "heapDeltaBytes": -3369668,
      "heapUsedBytes": 78135508,
      "domNodes": -244,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 115.826,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.8214953271028,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1772.805999999946,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 18.759999999999998,
      "layouts": 16,
      "layoutDurationMs": 6.072000000000001,
      "taskDurationMs": 819.5150000000001,
      "heapDeltaBytes": -3334460,
      "heapUsedBytes": 78163576,
      "domNodes": -244,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 115.20400000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.82358490566038,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.2779999999339,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 29.772000000000006,
      "layouts": 5,
      "layoutDurationMs": 11.399000000000003,
      "taskDurationMs": 943.9370000000002,
      "heapDeltaBytes": 23295488,
      "heapUsedBytes": 98330684,
      "domNodes": 13667,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 32.86600000000001,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 126,
      "frameDurationMs": 19.952112676056345,
      "p95FrameDurationMs": 33.30000000000018
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 11318.268999999986,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 35.787,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6424.778,
      "heapDeltaBytes": -55292180,
      "heapUsedBytes": 64110912,
      "domNodes": -228,
      "jsHeapTotalBytes": 425984,
      "scriptDurationMs": 2876.9339999999997,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6905604719764,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 11430.022000000008,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 35.187999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6466.0650000000005,
      "heapDeltaBytes": -35611064,
      "heapUsedBytes": 83211788,
      "domNodes": -228,
      "jsHeapTotalBytes": -167936,
      "scriptDurationMs": 2878.811,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666131386861313,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15380.610999999932,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15045.490999999998,
      "heapDeltaBytes": -64348620,
      "heapUsedBytes": 160542248,
      "domNodes": -3045,
      "jsHeapTotalBytes": 5210112,
      "scriptDurationMs": 302.2,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 5,
      "frameDurationMs": 28.883646616541355,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11490.307999999914,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11146.217,
      "heapDeltaBytes": -48286952,
      "heapUsedBytes": 179926604,
      "domNodes": -3045,
      "jsHeapTotalBytes": 2609152,
      "scriptDurationMs": 275.902,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 32,
      "frameDurationMs": 21.779356060606062,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18926.733000000015,
      "styleRecalcs": 139,
      "styleRecalcDurationMs": 18.647999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18780.260000000002,
      "heapDeltaBytes": -10254724,
      "heapUsedBytes": 187544800,
      "domNodes": -3045,
      "jsHeapTotalBytes": 9146368,
      "scriptDurationMs": 918.755,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 36,
      "frameDurationMs": 36.73009708737864,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19038.89700000002,
      "styleRecalcs": 135,
      "styleRecalcDurationMs": 17.958000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18909.992,
      "heapDeltaBytes": -23154780,
      "heapUsedBytes": 178940380,
      "domNodes": -3046,
      "jsHeapTotalBytes": 6488064,
      "scriptDurationMs": 909.3570000000001,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 20,
      "frameDurationMs": 37.72138613861386,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4220.646999999985,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.55000000000001,
      "layouts": 20,
      "layoutDurationMs": 26.969999999999995,
      "taskDurationMs": 4145.3550000000005,
      "heapDeltaBytes": 14206744,
      "heapUsedBytes": 221350536,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 86.02900000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 14,
      "frameDurationMs": 25.60853658536586,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5639.115000000174,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 75.544,
      "layouts": 20,
      "layoutDurationMs": 26.528999999999996,
      "taskDurationMs": 5615.985,
      "heapDeltaBytes": -4359900,
      "heapUsedBytes": 180990632,
      "domNodes": -8049,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 97.91000000000001,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 306,
      "frameDurationMs": 34.661963190184046,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5925.567999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5642.241,
      "heapDeltaBytes": -19538472,
      "heapUsedBytes": 180204752,
      "domNodes": -3046,
      "jsHeapTotalBytes": 7651328,
      "scriptDurationMs": 99.95099999999995,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.496739130434776,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7985.206000000062,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7861.363999999999,
      "heapDeltaBytes": -19898744,
      "heapUsedBytes": 178922920,
      "domNodes": -3045,
      "jsHeapTotalBytes": 3977216,
      "scriptDurationMs": 129.36099999999996,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.46946564885496,
      "p95FrameDurationMs": 50.099999999998545
    },
    {
      "name": "workflow-execution",
      "durationMs": 171.87999999998738,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 16.386000000000003,
      "layouts": 4,
      "layoutDurationMs": 2.6229999999999998,
      "taskDurationMs": 140.173,
      "heapDeltaBytes": -17135204,
      "heapUsedBytes": 79798376,
      "domNodes": 117,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 12.962000000000002,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.660000000000036,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 164.1740000000027,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 19.119,
      "layouts": 4,
      "layoutDurationMs": 1.9310000000000003,
      "taskDurationMs": 124.974,
      "heapDeltaBytes": -16811392,
      "heapUsedBytes": 80241104,
      "domNodes": 95,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 12.901000000000002,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.75,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 1239.426000000094,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 121.127,
      "layouts": 76,
      "layoutDurationMs": 29.657,
      "taskDurationMs": 1208.057,
      "heapDeltaBytes": -4534788,
      "heapUsedBytes": 67291672,
      "domNodes": 76,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 492.65500000000003,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.894520547945195,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 1236.406999999872,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 119.714,
      "layouts": 76,
      "layoutDurationMs": 29.131,
      "taskDurationMs": 1209.5369999999998,
      "heapDeltaBytes": -4498548,
      "heapUsedBytes": 67332068,
      "domNodes": 76,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 483.12899999999996,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.136619718309856,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1527.4010000000544,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 270.083,
      "layouts": 76,
      "layoutDurationMs": 27.123,
      "taskDurationMs": 1502.307,
      "heapDeltaBytes": 9293032,
      "heapUsedBytes": 115941872,
      "domNodes": 76,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 488.12899999999996,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.104878048780492,
      "p95FrameDurationMs": 33.30000000000109
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1571.7580000000453,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 281.64099999999996,
      "layouts": 76,
      "layoutDurationMs": 29.015,
      "taskDurationMs": 1558.312,
      "heapDeltaBytes": -18021904,
      "heapUsedBytes": 111340032,
      "domNodes": 76,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 508.706,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.478313253012036,
      "p95FrameDurationMs": 33.399999999999636
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52890 80109 66.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1151
src/LGraphNode.ts 70.2% 388
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.1% 330
src/LGraph.ts 78.9% 269
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/app.ts 73.1% 252
src/scripts/pnginfo.ts 20.8% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026
@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.46193% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 93.47% 3 Missing ⚠️
src/workbench/extensions/agent/AgentPanelRoot.vue 85.71% 1 Missing ⚠️
...tensions/agent/crdt/pendingDeleteRetentionStore.ts 98.97% 1 Missing ⚠️
@@                              Coverage Diff                              @@
##           fix/agent-crdt-detach-settles-pending-ops   #18642      +/-   ##
=============================================================================
+ Coverage                                      85.12%   85.14%   +0.01%     
=============================================================================
  Files                                           2341     2343       +2     
  Lines                                         134695   134844     +149     
  Branches                                       37223    35345    -1878     
=============================================================================
+ Hits                                          114661   114808     +147     
- Misses                                         19680    19682       +2     
  Partials                                         354      354              
Flag Coverage Δ
e2e 66.02% <ø> (-0.01%) ⬇️
unit 81.54% <97.46%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/crdt/opSender.ts 100.00% <100.00%> (ø)
...workbench/extensions/agent/crdt/yjsItemIdentity.ts 100.00% <100.00%> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 91.79% <85.71%> (+0.03%) ⬆️
...tensions/agent/crdt/pendingDeleteRetentionStore.ts 98.97% <98.97%> (ø)
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 98.35% <93.47%> (+0.11%) ⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

claude Bot pushed a commit that referenced this pull request Sep 23, 2026
The current #18276 diff no longer touches packages/ingest-types (that
work moved to #18642 in the retention-store split), so this entry was
a merge-conflict-era holdover left behind after narrowing the PR.

Per DrJKL's review: #18276 (comment)
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-docs Agent product architecture, contracts or documentation agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
…nding-ops' into agent/pending-delete-retention-store-fe-2504

# Conflicts:
#	src/workbench/extensions/agent/crdt/opSender.test.ts
#	src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts
…nding-ops' into agent/pending-delete-retention-store-fe-2504

# Conflicts:
#	src/workbench/extensions/agent/crdt/opSender.test.ts
#	src/workbench/extensions/agent/crdt/opSender.ts
…nding-ops' into agent/pending-delete-retention-store-fe-2504

# Conflicts:
#	src/workbench/extensions/agent/AgentPanelRoot.vue
#	src/workbench/extensions/agent/crdt/opSender.ts
#	src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts
#	src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts
@christian-byrne

Copy link
Copy Markdown
Contributor

Closing as superseded by #18700 (the merged graph-first CRDT follower), which removes the materializer/reconciliation layer this stopgap targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations agent-docs Agent product architecture, contracts or documentation agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants