Skip to content

[backport cloud/1.54] fix(litegraph): keep promoted dynamic combo child links on load (FE-258) - #18640

Merged
comfy-pr-bot merged 2 commits into
cloud/1.54from
backport-17486-to-cloud-1.54
Sep 23, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.54from
backport-17486-to-cloud-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #17486 to cloud/1.54

Automatically created by backport workflow.

…58) (#17486)

*PR Created by the Glary-Bot Agent*

---

Fixes the `scale_multiplier` widget on the
`utility_seedvr2_3b_int8_upscale_image` template rendering as a
disconnected input slot, with a duplicate `resize_type.multiplier_1`
appended below it. Reproduces on current `main`; neither #16717 nor its
backport #16751 touched the failing path.

- Fixes FE-258

## Root cause

A node is constructed with its dynamic combo's **default** option laid
out (`resize_type.width/height/crop`), and `ComfyNode.configure`
rewrites `data.inputs` into that definition order, appending the
serialized inputs the definition lacks. Serialized `target_slot` values
count the **saved** layout, so link `50` — saved on
`resize_type.multiplier` at slot 1 — lands on slot 1 of the rebuilt
layout, which is a different input.

Applying the combo's serialized value then tears the group down and
hands each surviving link to the new input of the same name. The link is
sitting on `resize_type.width`, which the selected option does not
define, so it is dropped. Across a subgraph boundary the promoted input
is demoted to a bare slot and a duplicate `_1` promotion is
auto-created.

## Fix

Realign the node's input links by name in `LGraphNode.configure`, after
slots are wired and before widget values are applied — the window in
which the correct slot exists. Scoped to nodes that have a group widget
child input; `LGraph.configure`'s existing pass still runs for
everything else once all nodes are configured.

The node's ordinary inputs join the batch so a link still occupying a
child's destination slot moves in the same atomic update instead of
blocking it. Inputs owned by a group that is not a widget (autogrow)
stay out because their slots grow and renumber during configure.

## Verification

- `pnpm test:unit
src/lib/litegraph/src/LGraph.inputSlotRealign.test.ts`: 21 passed.
- `pnpm test:browser:local
browser_tests/tests/subgraph/subgraphPromotedDynamicComboChild.spec.ts`:
2 passed after the development server warmed up. The first cold-start
run timed out before the app became ready; its second test passed.
- `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm lint`, `pnpm
format:check`, and `pnpm knip` passed.

## Unverified residuals

- An excluded autogrow link can block the early batch and produce a
`Failed to realign input link slots` log. This PR does not include a
complete-config base/head test for the final topology in that case.
- A nested dynamic combo under a non-default outer option is excluded
because its widget does not exist at this point in configure. Base/head
parity for that case was not reverified in this review round.

## Screenshots

![Before, on main: scale_multiplier is a bare disconnected input slot
and a duplicate resize_type.multiplier_1 widget is appended at the
bottom of the
node](https://pub-1fd11710d4c8405b948c9edc4287a3f2.r2.dev/sessions/a48037af157a30f246f73578b4cedea7fcb7acb6473a9fc84046508377963380/pr-images/1789169961897-4970176d-8c5d-45dc-8ac6-c46125b400c4.png)

![After the fix: scale_multiplier renders as a widget with value 4.00 in
its correct position, with no duplicate
input](https://pub-1fd11710d4c8405b948c9edc4287a3f2.r2.dev/sessions/a48037af157a30f246f73578b4cedea7fcb7acb6473a9fc84046508377963380/pr-images/1789169962235-4c9befc5-08de-46f2-a42a-7927a3e8224d.png)

---------

Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Co-authored-by: Amp <amp@ampcode.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 23, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 23, 2026 21:36
@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 9:53pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 09:55:12 PM UTC

Links

🎭 Playwright: ✅ 1943 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1922 / ❌ 0 / ⚠️ 2 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 131ms TBT · 79.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.3 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 165.9 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 67ms TBT · 172.5 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 336ms TBT · 168.5 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 163.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 468ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 59.8 MB
canvas-idle: DOM nodes -131
canvas-idle: event listeners -94
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 31ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 949ms
canvas-mouse-sweep: script duration 155ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 70.1 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -180
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 353ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.3 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 449ms
dom-widget-clipping: script duration 152ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 60.5 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 617ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.8 MB
large-graph-idle: DOM nodes -275
large-graph-idle: event listeners -193
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1542ms
large-graph-pan: script duration 749ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 83.6 MB
large-graph-pan: DOM nodes -274
large-graph-pan: event listeners -79
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1703ms
large-graph-zoom: script duration 716ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 68.4 MB
large-graph-zoom: DOM nodes -285
large-graph-zoom: event listeners -194
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1897ms
legacy-node-drag: script duration 882ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 82.2 MB
legacy-node-drag: DOM nodes -279
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 560ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.9 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -163
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 401ms
subgraph-dom-widget-clipping: script duration 136ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 80.2 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 485ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 60.5 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -241
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 27ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 804ms
subgraph-mouse-sweep: script duration 99ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 66.2 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -242
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 881ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 131ms
subgraph-transition-enter: heap used 79.0 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 41ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5475ms
viewport-pan-sweep: script duration 2433ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 81.3 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -147
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14283ms
vue-large-graph-idle: script duration 267ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 165.9 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 145
vue-large-graph-pan: task duration 17612ms
vue-large-graph-pan: script duration 911ms
vue-large-graph-pan: TBT 67ms
vue-large-graph-pan: heap used 172.5 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14929
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 76ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5213ms
vue-node-resize-workload: script duration 102ms
vue-node-resize-workload: TBT 336ms
vue-node-resize-workload: heap used 168.5 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14932
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7091ms
vue-zoom-out-idle: script duration 123ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 163.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 2
workflow-execution: style recalc count 9
workflow-execution: task duration 75ms
workflow-execution: script duration 4ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.1 MB
workflow-execution: DOM nodes 119
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-09-23T22:04:35.121Z",
  "gitSha": "8d210f6e07eee5a2a4c0c617fc25a55ee3b0dc49",
  "branch": "backport-17486-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2025.5480000000148,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.78,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 513.444,
      "heapDeltaBytes": -9705176,
      "heapUsedBytes": 60642012,
      "domNodes": -279,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.576000000000002,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2034.9640000000022,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.515999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 423.2169999999999,
      "heapDeltaBytes": 600864,
      "heapUsedBytes": 64838164,
      "domNodes": 18,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 9.105000000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2026.5120000000252,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 35.475,
      "layouts": 14,
      "layoutDurationMs": 4.706999999999999,
      "taskDurationMs": 1058.4769999999999,
      "heapDeltaBytes": -3828212,
      "heapUsedBytes": 67087492,
      "domNodes": -280,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 169.655,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1850.5650000000742,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 26.433000000000003,
      "layouts": 14,
      "layoutDurationMs": 4.276999999999999,
      "taskDurationMs": 838.5319999999999,
      "heapDeltaBytes": 8683212,
      "heapUsedBytes": 79869004,
      "domNodes": -281,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 140.52499999999998,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.788999999987,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 16.407,
      "layouts": 6,
      "layoutDurationMs": 1.351,
      "taskDurationMs": 355.29,
      "heapDeltaBytes": 4623828,
      "heapUsedBytes": 75853560,
      "domNodes": 76,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 12.855000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.8839999999745,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 15.276000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.4360000000000002,
      "taskDurationMs": 350.573,
      "heapDeltaBytes": 4651108,
      "heapUsedBytes": 75761164,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.952,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 676.9069999999715,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.947000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 445.91900000000004,
      "heapDeltaBytes": -7204124,
      "heapUsedBytes": 63698132,
      "domNodes": 20,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 150.66,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 709.7330000000284,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.483,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 452.739,
      "heapDeltaBytes": -7837188,
      "heapUsedBytes": 63226260,
      "domNodes": 18,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 153.96200000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2032.7369999999974,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.492,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 626.9129999999999,
      "heapDeltaBytes": 7884920,
      "heapUsedBytes": 84160700,
      "domNodes": -275,
      "jsHeapTotalBytes": -888832,
      "scriptDurationMs": 35.609,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2083.217999999988,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.05,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 607.7620000000002,
      "heapDeltaBytes": 7236568,
      "heapUsedBytes": 83161484,
      "domNodes": -274,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 32.726000000000006,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2332.5609999999983,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 10.804,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1590.4669999999999,
      "heapDeltaBytes": 23344164,
      "heapUsedBytes": 89909696,
      "domNodes": -277,
      "jsHeapTotalBytes": 1011712,
      "scriptDurationMs": 773.316,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2173.1110000000626,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.381,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1493.373,
      "heapDeltaBytes": 19109356,
      "heapUsedBytes": 85485876,
      "domNodes": -271,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 724.797,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3659.7889999999893,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 14.307000000000004,
      "layouts": 60,
      "layoutDurationMs": 13.741000000000001,
      "taskDurationMs": 1730.3719999999998,
      "heapDeltaBytes": -2464048,
      "heapUsedBytes": 75747584,
      "domNodes": -281,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 725.324,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3590.699000000086,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.140999999999998,
      "layouts": 60,
      "layoutDurationMs": 14.036,
      "taskDurationMs": 1674.964,
      "heapDeltaBytes": -10620124,
      "heapUsedBytes": 67607048,
      "domNodes": -288,
      "jsHeapTotalBytes": 4091904,
      "scriptDurationMs": 706.1310000000001,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3107.1680000000015,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.647,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1881.9619999999998,
      "heapDeltaBytes": 19215684,
      "heapUsedBytes": 87149364,
      "domNodes": -276,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 887.3539999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3175.2330000000484,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 8.444,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1912.877,
      "heapDeltaBytes": 4456008,
      "heapUsedBytes": 85153536,
      "domNodes": -282,
      "jsHeapTotalBytes": 53248,
      "scriptDurationMs": 877.419,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2038.5709999999904,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.432000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 578.105,
      "heapDeltaBytes": 8970756,
      "heapUsedBytes": 87707824,
      "domNodes": -271,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 32.87,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.316000000018,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.5400000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 541.9869999999999,
      "heapDeltaBytes": 21867244,
      "heapUsedBytes": 88226468,
      "domNodes": -273,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 33.779,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 605.4639999999836,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.697,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 392.244,
      "heapDeltaBytes": 15008304,
      "heapUsedBytes": 88232896,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 130.614,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 612.4020000000883,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.481000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 409.51599999999996,
      "heapDeltaBytes": 14275688,
      "heapUsedBytes": 79891892,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 141.12199999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2024.7420000000034,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.642000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.151,
      "heapDeltaBytes": -9389112,
      "heapUsedBytes": 63154636,
      "domNodes": -297,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 10.11,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.752999999966,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.260999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 469.9920000000001,
      "heapDeltaBytes": -8787668,
      "heapUsedBytes": 63803700,
      "domNodes": -297,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.590999999999998,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1725.5089999999882,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.371,
      "layouts": 18,
      "layoutDurationMs": 7.901999999999999,
      "taskDurationMs": 828.8050000000001,
      "heapDeltaBytes": -6118148,
      "heapUsedBytes": 67356224,
      "domNodes": -295,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 102.87,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1741.5919999999687,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 25.742,
      "layouts": 18,
      "layoutDurationMs": 4.442000000000001,
      "taskDurationMs": 779.4920000000001,
      "heapDeltaBytes": -1007064,
      "heapUsedBytes": 71574308,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 95.10300000000001,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1368.9560000000256,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 29.097999999999992,
      "layouts": 17,
      "layoutDurationMs": 13.214,
      "taskDurationMs": 880.9660000000001,
      "heapDeltaBytes": -7156464,
      "heapUsedBytes": 82812380,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 30.059,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 131,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8251.967999999977,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 41.245000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5618.52,
      "heapDeltaBytes": 9187040,
      "heapUsedBytes": 85615060,
      "domNodes": -273,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 2503.489,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8193.239999999947,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 40.87299999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5331.684,
      "heapDeltaBytes": 8928120,
      "heapUsedBytes": 84832664,
      "domNodes": -266,
      "jsHeapTotalBytes": -663552,
      "scriptDurationMs": 2361.7909999999997,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14848.872999999969,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14502.184,
      "heapDeltaBytes": -33897776,
      "heapUsedBytes": 170505260,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10760192,
      "scriptDurationMs": 287.43600000000004,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14753.239000000009,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14063.078999999998,
      "heapDeltaBytes": -27477208,
      "heapUsedBytes": 177513412,
      "domNodes": -8068,
      "jsHeapTotalBytes": -8679424,
      "scriptDurationMs": 246.18,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17842.33899999998,
      "styleRecalcs": 143,
      "styleRecalcDurationMs": 20.526000000000018,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17558.039999999997,
      "heapDeltaBytes": -63372296,
      "heapUsedBytes": 168724900,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19050496,
      "scriptDurationMs": 912.109,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 56,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18085.639000000014,
      "styleRecalcs": 146,
      "styleRecalcDurationMs": 20.219000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17666.055,
      "heapDeltaBytes": -25225816,
      "heapUsedBytes": 193057440,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12197888,
      "scriptDurationMs": 909.2500000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 78,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5264.889999999979,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.00199999999998,
      "layouts": 20,
      "layoutDurationMs": 25.112999999999996,
      "taskDurationMs": 5188.57,
      "heapDeltaBytes": -41739464,
      "heapUsedBytes": 176568492,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10428416,
      "scriptDurationMs": 100.76800000000001,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 357,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5318.822999999952,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.72899999999998,
      "layouts": 20,
      "layoutDurationMs": 25.704000000000004,
      "taskDurationMs": 5236.914,
      "heapDeltaBytes": -55353880,
      "heapUsedBytes": 176759268,
      "domNodes": -8068,
      "jsHeapTotalBytes": 15175680,
      "scriptDurationMs": 103.79299999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 314,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7309.492999999975,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7054.883,
      "heapDeltaBytes": -2815292,
      "heapUsedBytes": 164221600,
      "domNodes": 0,
      "jsHeapTotalBytes": -22282240,
      "scriptDurationMs": 118.63299999999998,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7305.5630000000065,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7127.762000000001,
      "heapDeltaBytes": 17169072,
      "heapUsedBytes": 178660584,
      "domNodes": 0,
      "jsHeapTotalBytes": -7602176,
      "scriptDurationMs": 127.18600000000002,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 111.63399999998092,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 10.655999999999999,
      "layouts": 1,
      "layoutDurationMs": 0.3629999999999998,
      "taskDurationMs": 70.507,
      "heapDeltaBytes": 3015236,
      "heapUsedBytes": 71406304,
      "domNodes": 109,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.799999999999999,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 120.0659999999516,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 15.418,
      "layouts": 2,
      "layoutDurationMs": 1.5769999999999997,
      "taskDurationMs": 78.89999999999999,
      "heapDeltaBytes": 2940348,
      "heapUsedBytes": 71463876,
      "domNodes": 129,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.0249999999999995,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50452 75670 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@github-actions
github-actions Bot requested a review from huang47 September 23, 2026 21:37
@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18640   +/-   ##
=============================================
  Coverage              ?   83.72%           
=============================================
  Files                 ?     2109           
  Lines                 ?   124959           
  Branches              ?    33820           
=============================================
  Hits                  ?   104622           
  Misses                ?    20158           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.68% <100.00%> (?)
unit 78.77% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/core/graph/widgets/dynamicWidgets.ts 94.51% <100.00%> (ø)
src/lib/litegraph/src/LGraphNode.ts 69.53% <100.00%> (ø)
src/lib/litegraph/src/linkDeduplication.ts 77.69% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026
@comfy-pr-bot
comfy-pr-bot merged commit 3913cb7 into cloud/1.54 Sep 23, 2026
91 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-17486-to-cloud-1.54 branch September 23, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants