Repository navigation
[backport core/1.54] fix(litegraph): keep promoted dynamic combo child links on load (FE-258) - #18639
Conversation
…58) (#17486) *PR Created by the Glary-Bot Agent* --- Fixes the `scale_multiplier` widget on the `utility_seedvr2_3b_int8_upscale_image` template rendering as a disconnected input slot, with a duplicate `resize_type.multiplier_1` appended below it. Reproduces on current `main`; neither #16717 nor its backport #16751 touched the failing path. - Fixes FE-258 ## Root cause A node is constructed with its dynamic combo's **default** option laid out (`resize_type.width/height/crop`), and `ComfyNode.configure` rewrites `data.inputs` into that definition order, appending the serialized inputs the definition lacks. Serialized `target_slot` values count the **saved** layout, so link `50` — saved on `resize_type.multiplier` at slot 1 — lands on slot 1 of the rebuilt layout, which is a different input. Applying the combo's serialized value then tears the group down and hands each surviving link to the new input of the same name. The link is sitting on `resize_type.width`, which the selected option does not define, so it is dropped. Across a subgraph boundary the promoted input is demoted to a bare slot and a duplicate `_1` promotion is auto-created. ## Fix Realign the node's input links by name in `LGraphNode.configure`, after slots are wired and before widget values are applied — the window in which the correct slot exists. Scoped to nodes that have a group widget child input; `LGraph.configure`'s existing pass still runs for everything else once all nodes are configured. The node's ordinary inputs join the batch so a link still occupying a child's destination slot moves in the same atomic update instead of blocking it. Inputs owned by a group that is not a widget (autogrow) stay out because their slots grow and renumber during configure. ## Verification - `pnpm test:unit src/lib/litegraph/src/LGraph.inputSlotRealign.test.ts`: 21 passed. - `pnpm test:browser:local browser_tests/tests/subgraph/subgraphPromotedDynamicComboChild.spec.ts`: 2 passed after the development server warmed up. The first cold-start run timed out before the app became ready; its second test passed. - `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm lint`, `pnpm format:check`, and `pnpm knip` passed. ## Unverified residuals - An excluded autogrow link can block the early batch and produce a `Failed to realign input link slots` log. This PR does not include a complete-config base/head test for the final topology in that case. - A nested dynamic combo under a non-default outer option is excluded because its widget does not exist at this point in configure. Base/head parity for that case was not reverified in this review round. ## Screenshots   --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1948 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T21:47:10.314Z",
"gitSha": "bfedcc34346095f30decc967619f9f463167b5d5",
"branch": "backport-17486-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2056.2160000000063,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.435,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.4649999999999,
"heapDeltaBytes": 10455044,
"heapUsedBytes": 80938152,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.274,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2017.0520000000352,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.444000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.573,
"heapDeltaBytes": 8615228,
"heapUsedBytes": 78628928,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.406999999999998,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1921.3960000000156,
"styleRecalcs": 78,
"styleRecalcDurationMs": 32.66,
"layouts": 14,
"layoutDurationMs": 4.478999999999999,
"taskDurationMs": 878.822,
"heapDeltaBytes": -2329980,
"heapUsedBytes": 68796204,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 149.363,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1773.490000000038,
"styleRecalcs": 74,
"styleRecalcDurationMs": 29.528,
"layouts": 14,
"layoutDurationMs": 4.4990000000000006,
"taskDurationMs": 856.897,
"heapDeltaBytes": -6867180,
"heapUsedBytes": 64091992,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 139.686,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.0690000000232,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.038999999999998,
"layouts": 6,
"layoutDurationMs": 1.1440000000000001,
"taskDurationMs": 335.538,
"heapDeltaBytes": 4646540,
"heapUsedBytes": 75626120,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.662,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.506000000043,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.853,
"layouts": 6,
"layoutDurationMs": 1.11,
"taskDurationMs": 375.204,
"heapDeltaBytes": 4641240,
"heapUsedBytes": 75804036,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 14.607000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 635.4240000000004,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.475999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.099,
"heapDeltaBytes": -7183780,
"heapUsedBytes": 63557760,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 145.10099999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 581.8209999999908,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.356999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.755,
"heapDeltaBytes": -7868296,
"heapUsedBytes": 62932828,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 133.386,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2053.7459999999896,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.206,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 673.1870000000001,
"heapDeltaBytes": 7645884,
"heapUsedBytes": 84114852,
"domNodes": -271,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 39.102999999999994,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2030.6749999999738,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.574000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 724.2819999999999,
"heapDeltaBytes": 11399780,
"heapUsedBytes": 87253804,
"domNodes": -269,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 42.377,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2468.2809999999904,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.562999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1495.828,
"heapDeltaBytes": 26703680,
"heapUsedBytes": 93206388,
"domNodes": 6,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 696.298,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2467.139999999972,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.268000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1587.7630000000001,
"heapDeltaBytes": 3567280,
"heapUsedBytes": 81121960,
"domNodes": -278,
"jsHeapTotalBytes": 118784,
"scriptDurationMs": 730.775,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3410.159999999962,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.795000000000002,
"layouts": 60,
"layoutDurationMs": 13.061,
"taskDurationMs": 1567.104,
"heapDeltaBytes": 9459008,
"heapUsedBytes": 77154500,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 688.643,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3796.7160000000604,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.249999999999996,
"layouts": 60,
"layoutDurationMs": 13.232999999999999,
"taskDurationMs": 1688.6310000000003,
"heapDeltaBytes": 11775276,
"heapUsedBytes": 79932996,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 732.052,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2877.4650000000292,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.283,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1830.1940000000002,
"heapDeltaBytes": 17555644,
"heapUsedBytes": 84761164,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 898.506,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3018.579999999986,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.616999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1918.943,
"heapDeltaBytes": 24873892,
"heapUsedBytes": 92166732,
"domNodes": -275,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 906.621,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2034.021999999993,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.2059999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.7399999999999,
"heapDeltaBytes": 6887544,
"heapUsedBytes": 85568920,
"domNodes": -269,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 32.940999999999995,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.5410000000365,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.3619999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 662.0020000000001,
"heapDeltaBytes": 21426840,
"heapUsedBytes": 87463920,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.944,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.6159999999973,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.157000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.477,
"heapDeltaBytes": 14612796,
"heapUsedBytes": 80726204,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 132.06099999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 556.8200000000161,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.731,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.69,
"heapDeltaBytes": 14693156,
"heapUsedBytes": 87826656,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 116.63799999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2021.6120000000046,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.637000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.29200000000003,
"heapDeltaBytes": -5603636,
"heapUsedBytes": 67600604,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.286,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.3790000000386,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.930999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.091,
"heapDeltaBytes": -9782352,
"heapUsedBytes": 62775816,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.296000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1701.9999999999982,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.601000000000003,
"layouts": 18,
"layoutDurationMs": 4.8069999999999995,
"taskDurationMs": 738.049,
"heapDeltaBytes": -4809544,
"heapUsedBytes": 68466724,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 95.10000000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.0710000000286,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.101,
"layouts": 18,
"layoutDurationMs": 4.680999999999999,
"taskDurationMs": 793.87,
"heapDeltaBytes": -6852052,
"heapUsedBytes": 66439800,
"domNodes": -296,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 101.601,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1300.9680000000117,
"styleRecalcs": 20,
"styleRecalcDurationMs": 26.777,
"layouts": 16,
"layoutDurationMs": 12.770999999999997,
"taskDurationMs": 846.8309999999999,
"heapDeltaBytes": 21952900,
"heapUsedBytes": 105739432,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 29.318000000000005,
"eventListeners": 2387,
"totalBlockingTimeMs": 101,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9008.291000000043,
"styleRecalcs": 250,
"styleRecalcDurationMs": 46.349999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5408.341,
"heapDeltaBytes": 833576,
"heapUsedBytes": 77374516,
"domNodes": -239,
"jsHeapTotalBytes": 905216,
"scriptDurationMs": 2438.263,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10161.438999999973,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.403999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5392.817,
"heapDeltaBytes": 9152852,
"heapUsedBytes": 85345976,
"domNodes": -270,
"jsHeapTotalBytes": -176128,
"scriptDurationMs": 2339.356,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16413.11300000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16205.721000000001,
"heapDeltaBytes": -17605188,
"heapUsedBytes": 196404716,
"domNodes": -8068,
"jsHeapTotalBytes": -6549504,
"scriptDurationMs": 270.49300000000005,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15901.126999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15460.597,
"heapDeltaBytes": -26421288,
"heapUsedBytes": 186864788,
"domNodes": -8068,
"jsHeapTotalBytes": -14319616,
"scriptDurationMs": 248.53,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19468.506999999987,
"styleRecalcs": 133,
"styleRecalcDurationMs": 20.048999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19347.899,
"heapDeltaBytes": -44807864,
"heapUsedBytes": 168796588,
"domNodes": -8068,
"jsHeapTotalBytes": -12902400,
"scriptDurationMs": 870.987,
"eventListeners": -14929,
"totalBlockingTimeMs": 104,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18558.051999999974,
"styleRecalcs": 127,
"styleRecalcDurationMs": 19.071000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18419.388000000003,
"heapDeltaBytes": -42261352,
"heapUsedBytes": 188850908,
"domNodes": -8068,
"jsHeapTotalBytes": -25047040,
"scriptDurationMs": 852.996,
"eventListeners": -14929,
"totalBlockingTimeMs": 177,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5910.139000000016,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.12899999999996,
"layouts": 20,
"layoutDurationMs": 24.57799999999999,
"taskDurationMs": 5882.107,
"heapDeltaBytes": -48463740,
"heapUsedBytes": 170825264,
"domNodes": -8068,
"jsHeapTotalBytes": 16642048,
"scriptDurationMs": 112.02100000000002,
"eventListeners": -14929,
"totalBlockingTimeMs": 390,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5572.695000000067,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.21199999999999,
"layouts": 20,
"layoutDurationMs": 23.765000000000008,
"taskDurationMs": 5525.918,
"heapDeltaBytes": -45166628,
"heapUsedBytes": 181859492,
"domNodes": -8068,
"jsHeapTotalBytes": 11436032,
"scriptDurationMs": 98.44699999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 291,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8226.508999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8138.631,
"heapDeltaBytes": 7876092,
"heapUsedBytes": 173672444,
"domNodes": 0,
"jsHeapTotalBytes": -22282240,
"scriptDurationMs": 161.43800000000002,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7967.004999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7845.2570000000005,
"heapDeltaBytes": 20906040,
"heapUsedBytes": 176512276,
"domNodes": 0,
"jsHeapTotalBytes": -6029312,
"scriptDurationMs": 123.942,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 88.3049999999912,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.307,
"layouts": 2,
"layoutDurationMs": 0.71,
"taskDurationMs": 58.913999999999994,
"heapDeltaBytes": 3007184,
"heapUsedBytes": 71528648,
"domNodes": 104,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.048000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 450.170000000071,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.991000000000003,
"layouts": 3,
"layoutDurationMs": 1.3030000000000002,
"taskDurationMs": 102.82800000000002,
"heapDeltaBytes": 4753572,
"heapUsedBytes": 73975536,
"domNodes": 117,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.737,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18639 +/- ##
=============================================
+ Coverage 83.41% 83.67% +0.26%
=============================================
Files 2098 2098
Lines 124150 124174 +24
Branches 31418 31419 +1
=============================================
+ Hits 103556 103901 +345
+ Misses 20415 20094 -321
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 63 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #17486 to
core/1.54Automatically created by backport workflow.