Repository navigation
fix(billing): keep member management live for an end-dated Enterprise plan - #18625
comfydesigner wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2130 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-25T17:21:59.114Z",
"gitSha": "f7e38fd2bf5531369ba8597e8224859b80143cc4",
"branch": "comfydesigner/fe-2846-members-enterprise-end",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.883000000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.959,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.2289999999999,
"heapDeltaBytes": 4246712,
"heapUsedBytes": 64877036,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 12.232999999999997,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.174999999961,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.313000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.353,
"heapDeltaBytes": 11325924,
"heapUsedBytes": 73642156,
"domNodes": -228,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.776,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1890.6900000000064,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.066,
"layouts": 12,
"layoutDurationMs": 5.084,
"taskDurationMs": 924.4000000000001,
"heapDeltaBytes": 12169228,
"heapUsedBytes": 72934724,
"domNodes": -228,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 181.971,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1805.4349999999886,
"styleRecalcs": 69,
"styleRecalcDurationMs": 19.346,
"layouts": 12,
"layoutDurationMs": 4.978,
"taskDurationMs": 815.648,
"heapDeltaBytes": 5495156,
"heapUsedBytes": 67981808,
"domNodes": -228,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 180.80700000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.5790000000388,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.448,
"layouts": 6,
"layoutDurationMs": 1.3729999999999998,
"taskDurationMs": 297.97799999999995,
"heapDeltaBytes": 2155132,
"heapUsedBytes": 64620936,
"domNodes": 53,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 14.370000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.7459999999683,
"styleRecalcs": 33,
"styleRecalcDurationMs": 11.629,
"layouts": 6,
"layoutDurationMs": 1.4789999999999999,
"taskDurationMs": 390.05199999999996,
"heapDeltaBytes": 2088572,
"heapUsedBytes": 64413628,
"domNodes": 53,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 14.829000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 719.87299999995,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.7769999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.85499999999996,
"heapDeltaBytes": 18795052,
"heapUsedBytes": 81509852,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 177.809,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 729.9530000000232,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.5409999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.59599999999995,
"heapDeltaBytes": 19335608,
"heapUsedBytes": 86460176,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 175.556,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1285.8549999999696,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 991.5319999999999,
"heapDeltaBytes": -12379212,
"heapUsedBytes": 73840996,
"domNodes": -259,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 75.16099999999999,
"eventListeners": -207,
"totalBlockingTimeMs": 598,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1286.2009999998918,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1007.1970000000001,
"heapDeltaBytes": -14110652,
"heapUsedBytes": 73595888,
"domNodes": -259,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 77.12700000000001,
"eventListeners": -207,
"totalBlockingTimeMs": 615,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 857.6970000000301,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.26700000000045,
"heapDeltaBytes": 14950260,
"heapUsedBytes": 91586868,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 170.18900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 238,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 855.0750000000562,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.09299999999956,
"heapDeltaBytes": 14885752,
"heapUsedBytes": 92234888,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 170.84499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 242,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10498.632999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9552.248000000001,
"heapDeltaBytes": -9476456,
"heapUsedBytes": 72627900,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8084.101000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1712,
"frameDurationMs": 20.55666666666663,
"p95FrameDurationMs": 49.99999999999818
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10898.063999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9968.810999999998,
"heapDeltaBytes": 8961876,
"heapUsedBytes": 83953680,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8467.157000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1700,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11634.39599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10593.237000000001,
"heapDeltaBytes": -7309532,
"heapUsedBytes": 69348568,
"domNodes": -228,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8787.628,
"eventListeners": -164,
"totalBlockingTimeMs": 1594,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 12539.432000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11512.712000000001,
"heapDeltaBytes": 12888720,
"heapUsedBytes": 96132540,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 9574.71,
"eventListeners": 0,
"totalBlockingTimeMs": 2182,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2040.6570000000102,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.633000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 684.706,
"heapDeltaBytes": 2212568,
"heapUsedBytes": 83479836,
"domNodes": -228,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 43.49499999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2050.772000000052,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.207999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.1350000000001,
"heapDeltaBytes": 1930868,
"heapUsedBytes": 82349212,
"domNodes": -228,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 36.790000000000006,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2999.8529999999732,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.712,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1798.3250000000003,
"heapDeltaBytes": 23631872,
"heapUsedBytes": 87734988,
"domNodes": -228,
"jsHeapTotalBytes": 2060288,
"scriptDurationMs": 932.6129999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2827.0950000000994,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.045000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1676.89,
"heapDeltaBytes": 6731028,
"heapUsedBytes": 89069628,
"domNodes": -228,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 949.9830000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4057.9040000000077,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.413999999999996,
"layouts": 60,
"layoutDurationMs": 15.675,
"taskDurationMs": 1991.8580000000002,
"heapDeltaBytes": -24211788,
"heapUsedBytes": 64995148,
"domNodes": -228,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 907.4520000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3833.2169999999905,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.516000000000002,
"layouts": 60,
"layoutDurationMs": 14.642000000000003,
"taskDurationMs": 1834.974,
"heapDeltaBytes": 8767872,
"heapUsedBytes": 74591936,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 855.64,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3146.7889999999556,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.650999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2073.66,
"heapDeltaBytes": -10465316,
"heapUsedBytes": 74186044,
"domNodes": 0,
"jsHeapTotalBytes": 6246400,
"scriptDurationMs": 1068.091,
"eventListeners": 180,
"totalBlockingTimeMs": 42,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3126.9740000000183,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.594000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2024.542,
"heapDeltaBytes": 1101840,
"heapUsedBytes": 66845656,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1024.467,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2029.924000000051,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.020999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.6569999999999,
"heapDeltaBytes": -13198356,
"heapUsedBytes": 75023360,
"domNodes": -228,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 38.38799999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2037.629000000038,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.035000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 659.4069999999999,
"heapDeltaBytes": -3634516,
"heapUsedBytes": 84339120,
"domNodes": -228,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 36.387,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 645.3920000000153,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.098000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.041,
"heapDeltaBytes": 14153140,
"heapUsedBytes": 83951900,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 150.527,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.4439999999022,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.780999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.994,
"heapDeltaBytes": 13649024,
"heapUsedBytes": 77128660,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 151.06300000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.2929999999806,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.476999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.211,
"heapDeltaBytes": 6605932,
"heapUsedBytes": 70400092,
"domNodes": -244,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.972,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.7760000000453,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.111999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.706,
"heapDeltaBytes": 9885764,
"heapUsedBytes": 72517604,
"domNodes": -244,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.624999999999998,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.5059999999858,
"styleRecalcs": 73,
"styleRecalcDurationMs": 19.622,
"layouts": 16,
"layoutDurationMs": 6.037000000000001,
"taskDurationMs": 776.6220000000001,
"heapDeltaBytes": -4208980,
"heapUsedBytes": 59191224,
"domNodes": -244,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 126.26500000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.3580000000702,
"styleRecalcs": 74,
"styleRecalcDurationMs": 19.382000000000005,
"layouts": 16,
"layoutDurationMs": 6.363,
"taskDurationMs": 744.0709999999999,
"heapDeltaBytes": 11203484,
"heapUsedBytes": 74562816,
"domNodes": -244,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 122.701,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.8780000000024,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.150000000000006,
"layouts": 5,
"layoutDurationMs": 13.746,
"taskDurationMs": 1037.422,
"heapDeltaBytes": -6274704,
"heapUsedBytes": 82396164,
"domNodes": 13667,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 36.784,
"eventListeners": 2383,
"totalBlockingTimeMs": 157,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10574.24000000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.51500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6654.051,
"heapDeltaBytes": 5262156,
"heapUsedBytes": 86610964,
"domNodes": -228,
"jsHeapTotalBytes": 1269760,
"scriptDurationMs": 3224.186,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9216.901000000007,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.359,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6179.329,
"heapDeltaBytes": 3254044,
"heapUsedBytes": 84682828,
"domNodes": -228,
"jsHeapTotalBytes": -565248,
"scriptDurationMs": 2968.914,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17203.367999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16873.067,
"heapDeltaBytes": -61375916,
"heapUsedBytes": 178565480,
"domNodes": -8049,
"jsHeapTotalBytes": -16670720,
"scriptDurationMs": 276.727,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17818.277999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17572.208,
"heapDeltaBytes": -41006296,
"heapUsedBytes": 192975492,
"domNodes": -8049,
"jsHeapTotalBytes": -8663040,
"scriptDurationMs": 297.058,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22212.456999999973,
"styleRecalcs": 158,
"styleRecalcDurationMs": 22.359999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22044.525,
"heapDeltaBytes": -47806128,
"heapUsedBytes": 192006932,
"domNodes": -8049,
"jsHeapTotalBytes": -18837504,
"scriptDurationMs": 1018.6949999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 224,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22262.74199999989,
"styleRecalcs": 164,
"styleRecalcDurationMs": 23.036,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22143.694,
"heapDeltaBytes": -58468752,
"heapUsedBytes": 181354480,
"domNodes": -8049,
"jsHeapTotalBytes": -20303872,
"scriptDurationMs": 972.033,
"eventListeners": -14923,
"totalBlockingTimeMs": 123,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-node-resize-workload",
"durationMs": 6505.898999999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.46999999999998,
"layouts": 20,
"layoutDurationMs": 25.064000000000004,
"taskDurationMs": 6437.682,
"heapDeltaBytes": -47600224,
"heapUsedBytes": 192418512,
"domNodes": -8049,
"jsHeapTotalBytes": 7184384,
"scriptDurationMs": 119.95999999999998,
"eventListeners": -14923,
"totalBlockingTimeMs": 427,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6354.385999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.37899999999998,
"layouts": 20,
"layoutDurationMs": 24.561,
"taskDurationMs": 6296.333999999999,
"heapDeltaBytes": -20566740,
"heapUsedBytes": 198661344,
"domNodes": -8049,
"jsHeapTotalBytes": 15982592,
"scriptDurationMs": 111.74799999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 452,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8997.980999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8902.66,
"heapDeltaBytes": 21999600,
"heapUsedBytes": 182539640,
"domNodes": 0,
"jsHeapTotalBytes": -17825792,
"scriptDurationMs": 174.72,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9218.726999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9119.906000000003,
"heapDeltaBytes": 23593376,
"heapUsedBytes": 195689500,
"domNodes": 0,
"jsHeapTotalBytes": -17301504,
"scriptDurationMs": 203.685,
"eventListeners": 0,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 484.89500000005137,
"styleRecalcs": 24,
"styleRecalcDurationMs": 23.633,
"layouts": 4,
"layoutDurationMs": 2.204,
"taskDurationMs": 157.958,
"heapDeltaBytes": 5308176,
"heapUsedBytes": 67186064,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 20.963,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 493.81899999991674,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.072000000000003,
"layouts": 4,
"layoutDurationMs": 2.269,
"taskDurationMs": 148.65100000000004,
"heapDeltaBytes": 5072764,
"heapUsedBytes": 67059192,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.437000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since cff5b4f8a5f3559fa9b8ec2cc2293fa03fe85b42
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## comfydesigner/enterprise-ending-threshold #18625 +/- ##
==========================================================================
Coverage 84.90% 84.91%
==========================================================================
Files 2306 2306
Lines 132585 132592 +7
Branches 33894 33897 +3
==========================================================================
+ Hits 112570 112585 +15
+ Misses 19709 19701 -8
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Verified in the browser against the local billing mock harness (restored + extended locally for the unified token exchange, capabilities, and seat fields — not part of this PR):
Unit + component coverage: helper contract in tierPricing.test.ts, gate behavior in useMembersPanel.test.ts, banner/template seam in MembersPanelContent.test.ts. |
9ef8125 to
1bda5eb
Compare
62ef909 to
21be037
Compare
0362ba8 to
cff5b4f
Compare
… plan # Conflicts: # src/platform/workspace/composables/useMembersPanel.test.ts
21be037 to
78ebb5b
Compare
dante01yoon
left a comment
There was a problem hiding this comment.
The Enterprise symptom is real, but this patch preserves the same frontend-created cancellation entitlement for self-serve plans. The next stacked PR removes that gate in favor of authoritative capability/end state, so #18625 should not land independently in its current form.
| canViewOtherMembers: hasMemberSeats.value, | ||
| canViewPendingInvites: canManageInvites, | ||
| canInviteMembers: canManageInvites && !isCancelled.value, | ||
| canInviteMembers: canManageInvites && !isSelfServeCancelled.value, |
There was a problem hiding this comment.
issue: This adds a frontend entitlement gate after the authoritative can_invite_members capability. For a cancel-scheduled self-serve plan, the backend can explicitly permit invites while this forces them off; #18662’s verified contract says cancellation does not end access and only subscription_status: ended freezes it. The test currently encodes the conflicting behavior. Could we drive this from server capability/end state instead of deriving permission from tier + cancellation fields?
|
Superseded by #18662, per review: this patch removed the cancellation gate only for end-dated Enterprise while re-deriving the entitlement from tier + cancellation fields on the frontend. #18662 now carries the whole members change rebased directly onto main — no frontend cancellation gate at all, invites follow the authoritative |
…ns itself (Comfy-Org#18662) ## What users get - An owner whose plan is **cancel-scheduled but still running** can keep inviting members for the whole paid period. The backend has always allowed this — capability, invite endpoint, and Stripe write path all permit seat adds while `cancel_at_period_end` is set (verified on cloud/main, 2026-09-23) — the freeze was client-side only. - Once the plan has actually **ended** (`subscription_status: ended`), an owner sees the Invite button visible-but-disabled (today it silently vanishes) with a banner naming the state and the route back: "Your team plan has ended" + resume for self-serve, "Your Enterprise plan has ended" + **Contact sales** for sales-managed tiers. Members still see no button (role denial stays hidden). ## How - `useMembersPanel`: the `isSelfServeCancelled` gate (added in Comfy-Org#18625) is removed entirely; the only member-management freeze is `isPlanEnded` (`subscriptionStatus === 'ended'`). `showInviteButton` keeps the control visible for owners in that state via `canManageSubscription`. - `MemberUpsellBanner` rebuilt in the BillingStatusBanner visual system with a `variant` prop (`upgrade` / `reactivate` / `contactSales`); the resume label reuses the plan panel's ending-banner key so the two surfaces can't drift. - Banner renders on ended, not cancelled — the state it was originally designed for (the old wiring keyed on `isCancelled`, making the reactivate variant unreachable). Design record: DES-1200 (banner matrix rows + decisions). Stacked on Comfy-Org#18625; retargets when it lands. Fixes FE-2884 --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: dante01yoon <bunggl@naver.com> Co-authored-by: Amp <amp@ampcode.com>
What users get
An Enterprise workspace with an agreed end date can keep managing members until that date. Today the Members page reads the subscription's
canceledstatus as a lapsed plan: Invite greys out and the banner offers "Upgrade to Team" to a workspace whose Enterprise contract is still running (FE-2846 — Silverside hit this; their end date was removed as a workaround and goes back on once this ships).How
hasScheduledEnterpriseEnd(tier, endDate)intierPricing.ts(strictlyENTERPRISE, end date must parse — same contract as the inline check on the subscription panel).useMembersPanelderivesisSelfServeCancelledfrom it and uses that for the invite permission, the disabled state, the click guard, and the upsell banner. A self-serve cancellation behaves exactly as before; Enterprise without a readable end date keeps the stock cancelled treatment.Tests
tierPricing.test.ts: helper contract (end-dated Enterprise yes; missing/invalid date no; self-serve and unknown tiers never).useMembersPanel.test.ts: invites stay live for end-dated Enterprise (dialog opens), stock treatment without an end date, and a cancelled self-serve plan with an end date never borrows the quiet path.Stacked
Based on
comfydesigner/enterprise-ending-threshold(#16934) for the FE-2035 groundwork; will retarget tomainonce that merges.Fixes FE-2846