Repository navigation
fix(security): harden sanitization against attribute breakout, form injection, and javascript: URLs - #18594
Conversation
…njection, and javascript: URLs - Escape href/alt/title before interpolating them into the markdown image/link renderer output, so a quote in a markdown href/alt can no longer break out of its attribute and inject a new one (e.g. style). - Forbid form/input/button tags and the style attribute in SanitizedHtml's DOMPurify config, so untrusted HTML can no longer render a functional sign-in form or a full-screen overlay. - Add isSafeExternalUrl (http/https only) and use it to gate the repository and license hrefs in the manager's DescriptionTabPanel, which were bound directly from registry data and accepted javascript: URLs.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2138 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 608e850215a6fcb6cbf95c900573aef322a84b1d
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10 MB gzip 🔴 +723 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 134 kB (baseline 134 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.99 MB (baseline 3.99 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 578 kB (baseline 576 kB) • 🔴 +1.33 kBHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 17 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • 🔴 +414 BBundles that do not match a named category
Status: 76 added / 76 removed / 225 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-27T05:11:37.673Z",
"gitSha": "7d621dfb9936b3639c69822425bdc66e3afe183e",
"branch": "fix/sanitization-hardening",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1994.1200000000094,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.3559999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.517,
"heapDeltaBytes": -1407044,
"heapUsedBytes": 61186116,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.383000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2004.9220000000787,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.773,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.526,
"heapDeltaBytes": -1336452,
"heapUsedBytes": 61043904,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.593000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1712.5430000000392,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.413,
"layouts": 12,
"layoutDurationMs": 3.933,
"taskDurationMs": 660.2099999999999,
"heapDeltaBytes": -3115588,
"heapUsedBytes": 59234896,
"domNodes": -228,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 124.728,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.613999999964,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.283000000000001,
"layouts": 12,
"layoutDurationMs": 3.7590000000000003,
"taskDurationMs": 652.143,
"heapDeltaBytes": -3852380,
"heapUsedBytes": 58568360,
"domNodes": -228,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 125.08500000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.664000000003,
"styleRecalcs": 30,
"styleRecalcDurationMs": 8.134999999999998,
"layouts": 6,
"layoutDurationMs": 1.1780000000000002,
"taskDurationMs": 265.34599999999995,
"heapDeltaBytes": 1878032,
"heapUsedBytes": 64733908,
"domNodes": 53,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.781999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.2870000000548,
"styleRecalcs": 28,
"styleRecalcDurationMs": 8.400999999999998,
"layouts": 6,
"layoutDurationMs": 1.057,
"taskDurationMs": 255.326,
"heapDeltaBytes": 2156372,
"heapUsedBytes": 64559444,
"domNodes": 53,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.855000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 517.7279999999769,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.6740000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.066,
"heapDeltaBytes": 18463144,
"heapUsedBytes": 80940140,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 130.456,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 531.6669999999704,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.3159999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.129,
"heapDeltaBytes": 18215140,
"heapUsedBytes": 80483232,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 129.46400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1036.9569999999726,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 699.832,
"heapDeltaBytes": -12783212,
"heapUsedBytes": 73427872,
"domNodes": -259,
"jsHeapTotalBytes": 18743296,
"scriptDurationMs": 47.539,
"eventListeners": -207,
"totalBlockingTimeMs": 396,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1033.138000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 704.763,
"heapDeltaBytes": -16012196,
"heapUsedBytes": 71743676,
"domNodes": -259,
"jsHeapTotalBytes": 19791872,
"scriptDurationMs": 49.020999999999994,
"eventListeners": -207,
"totalBlockingTimeMs": 402,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 764.772999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.70500000000015,
"heapDeltaBytes": 14320144,
"heapUsedBytes": 90931660,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.29000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 767.8909999999632,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.8069999999998,
"heapDeltaBytes": 14275108,
"heapUsedBytes": 91175624,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 109.87799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 157,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7561.9930000000295,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6757.723999999999,
"heapDeltaBytes": 30291056,
"heapUsedBytes": 94810944,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 5450.537,
"eventListeners": 0,
"totalBlockingTimeMs": 68,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7329.367999999988,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.08100000000000121,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6566.638,
"heapDeltaBytes": 12314960,
"heapUsedBytes": 94861048,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 5281.856,
"eventListeners": 0,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7426.767999999982,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6900000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6667.454000000001,
"heapDeltaBytes": 15313504,
"heapUsedBytes": 90218788,
"domNodes": -228,
"jsHeapTotalBytes": 8380416,
"scriptDurationMs": 5387.041,
"eventListeners": -164,
"totalBlockingTimeMs": 83,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7776.3949999999795,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5649999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6962.549,
"heapDeltaBytes": 16934816,
"heapUsedBytes": 93733204,
"domNodes": -228,
"jsHeapTotalBytes": 10215424,
"scriptDurationMs": 5660.608,
"eventListeners": -164,
"totalBlockingTimeMs": 68,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2024.0009999999984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2979999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.70199999999994,
"heapDeltaBytes": -6352432,
"heapUsedBytes": 75225548,
"domNodes": -228,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 28.423000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 1998.199999999997,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.7630000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.9140000000001,
"heapDeltaBytes": 19695084,
"heapUsedBytes": 83469816,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 26.208000000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2152.8999999999883,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.691999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1332.271,
"heapDeltaBytes": -22662756,
"heapUsedBytes": 65807460,
"domNodes": -228,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 683.0880000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2140.6880000000683,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.385,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1276.0570000000002,
"heapDeltaBytes": -18186832,
"heapUsedBytes": 64642896,
"domNodes": -228,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 632.804,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3149.436000000037,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.480000000000002,
"layouts": 60,
"layoutDurationMs": 12.542,
"taskDurationMs": 1327.224,
"heapDeltaBytes": 9499556,
"heapUsedBytes": 75053600,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 618.916,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3155.9990000000653,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.057,
"layouts": 60,
"layoutDurationMs": 12.668,
"taskDurationMs": 1328.8090000000002,
"heapDeltaBytes": 11282908,
"heapUsedBytes": 78062580,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 615.624,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2189.0800000000468,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.772999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1493.5310000000002,
"heapDeltaBytes": 17271808,
"heapUsedBytes": 83746448,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 755.648,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2224.3720000000167,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.8199999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1488.306,
"heapDeltaBytes": 17533572,
"heapUsedBytes": 83455316,
"domNodes": 0,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 762.768,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.244999999979,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.385,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.49699999999996,
"heapDeltaBytes": -9885456,
"heapUsedBytes": 72446952,
"domNodes": -228,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 31.722,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2010.6349999999793,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.079999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.285,
"heapDeltaBytes": -4590640,
"heapUsedBytes": 84181404,
"domNodes": -228,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 28.287,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 532.0929999999748,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.542,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 319.89900000000006,
"heapDeltaBytes": 13728440,
"heapUsedBytes": 77456544,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 120.18699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.9639999999636,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.736999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 314.319,
"heapDeltaBytes": 13740308,
"heapUsedBytes": 76706844,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 118.638,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 1994.3829999999707,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.4870000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.053,
"heapDeltaBytes": 6268504,
"heapUsedBytes": 69936244,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.933999999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1992.0430000000806,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.28,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.305,
"heapDeltaBytes": -6099176,
"heapUsedBytes": 57623164,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.860999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.2159999999594,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.621,
"layouts": 16,
"layoutDurationMs": 4.7139999999999995,
"taskDurationMs": 608.15,
"heapDeltaBytes": -659808,
"heapUsedBytes": 62453492,
"domNodes": -244,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 83.228,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.6050000000005,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.806000000000001,
"layouts": 16,
"layoutDurationMs": 4.933,
"taskDurationMs": 606.052,
"heapDeltaBytes": -13772940,
"heapUsedBytes": 56072420,
"domNodes": -244,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 83.333,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 850.8899999999926,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.187000000000005,
"layouts": 5,
"layoutDurationMs": 9.370999999999999,
"taskDurationMs": 678.4859999999999,
"heapDeltaBytes": -6252116,
"heapUsedBytes": 81832140,
"domNodes": 13667,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 19.584000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 86,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8153.153999999972,
"styleRecalcs": 251,
"styleRecalcDurationMs": 32.662,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4438.954,
"heapDeltaBytes": -2424240,
"heapUsedBytes": 84873348,
"domNodes": -228,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 2139.845,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8197.443000000021,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.825,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4953.088,
"heapDeltaBytes": -2789460,
"heapUsedBytes": 79597344,
"domNodes": -228,
"jsHeapTotalBytes": 8679424,
"scriptDurationMs": 2512.736,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14198.338000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13566.981000000002,
"heapDeltaBytes": -44647588,
"heapUsedBytes": 172174656,
"domNodes": -8049,
"jsHeapTotalBytes": -14266368,
"scriptDurationMs": 195.51000000000002,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14132.388999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13693.964999999998,
"heapDeltaBytes": -27564944,
"heapUsedBytes": 198126796,
"domNodes": -8049,
"jsHeapTotalBytes": -17833984,
"scriptDurationMs": 206.82899999999998,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16713.52000000002,
"styleRecalcs": 113,
"styleRecalcDurationMs": 12.868999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16343.114,
"heapDeltaBytes": -22541664,
"heapUsedBytes": 190572012,
"domNodes": -8049,
"jsHeapTotalBytes": -11587584,
"scriptDurationMs": 678.151,
"eventListeners": -14923,
"totalBlockingTimeMs": 62,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16691.98600000004,
"styleRecalcs": 117,
"styleRecalcDurationMs": 12.844999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16362.230999999998,
"heapDeltaBytes": -30777260,
"heapUsedBytes": 189736508,
"domNodes": -8049,
"jsHeapTotalBytes": -19795968,
"scriptDurationMs": 698.34,
"eventListeners": -14923,
"totalBlockingTimeMs": 6,
"frameDurationMs": 17.226666666666762,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5106.942000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.67,
"layouts": 20,
"layoutDurationMs": 21.039,
"taskDurationMs": 5030.116000000001,
"heapDeltaBytes": -55038480,
"heapUsedBytes": 171004036,
"domNodes": -8049,
"jsHeapTotalBytes": 9953280,
"scriptDurationMs": 83.20300000000002,
"eventListeners": -14923,
"totalBlockingTimeMs": 271,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5078.412000000071,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.039999999999985,
"layouts": 20,
"layoutDurationMs": 20.954,
"taskDurationMs": 5006.124999999999,
"heapDeltaBytes": -30677832,
"heapUsedBytes": 183335008,
"domNodes": -8049,
"jsHeapTotalBytes": 18890752,
"scriptDurationMs": 80.152,
"eventListeners": -14923,
"totalBlockingTimeMs": 234,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7203.058999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6870.035,
"heapDeltaBytes": 16234316,
"heapUsedBytes": 199100580,
"domNodes": 0,
"jsHeapTotalBytes": -22282240,
"scriptDurationMs": 98.93100000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7126.644000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6921.126000000001,
"heapDeltaBytes": 30847144,
"heapUsedBytes": 191890560,
"domNodes": 0,
"jsHeapTotalBytes": -20447232,
"scriptDurationMs": 95.32499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 424.7389999999882,
"styleRecalcs": 15,
"styleRecalcDurationMs": 12.431,
"layouts": 3,
"layoutDurationMs": 0.8730000000000001,
"taskDurationMs": 91.765,
"heapDeltaBytes": 5021604,
"heapUsedBytes": 67099804,
"domNodes": 104,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.199000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 427.1009999999933,
"styleRecalcs": 15,
"styleRecalcDurationMs": 15.87,
"layouts": 4,
"layoutDurationMs": 1.5430000000000001,
"taskDurationMs": 92.712,
"heapDeltaBytes": 4922060,
"heapUsedBytes": 67106432,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.514,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18594 +/- ##
==========================================
- Coverage 83.54% 83.25% -0.30%
==========================================
Files 2991 3162 +171
Lines 148162 158084 +9922
Branches 38251 41329 +3078
==========================================
+ Hits 123780 131607 +7827
- Misses 23097 24872 +1775
- Partials 1285 1605 +320
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 490 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…rties to reduce template complexity Move the safe-href resolution for the repository and license links out of inline template v-if/v-else branches into safeRepositoryHref/safeLicenseHref computed properties. The anchors now always render, binding href to the resolved value (undefined when unsafe), so isSafeExternalUrl gating is unchanged but the template no longer branches on it directly.
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the current security head after follow-up fixes. Attribute escaping, DOMPurify restrictions, URL-scheme validation/canonicalization, plain-text license fallback, unsafe repository omission, and regression coverage are sound. Local targeted tests, shared-utils suite, typecheck, lint, format, knip, and fallow pass.
|
1 similar comment
|
…bute breakout, form injection, and javascript: URLs (#18594) (#19068) Manual backport of #18594 after the shared-utils export map conflicted. Resolution keeps the `core/1.54` package export surface and adds only the new `urlSafety` export. Verification: - 40/40 targeted app tests passed (`SanitizedHtml`, markdown renderer, manager description panel) - URL-safety canonicalization coverage is included; the old release package Vitest config references a missing setup file, so that package-local invocation cannot start on this branch - pre-commit format, stylelint, oxlint, eslint, and `typecheck:app` all passed Original merge: 52f86cb Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
|
1 similar comment
|
…bute breakout, form injection, and javascript: URLs (#18594) (#19138) Manual backport of #18594 to `core/1.55`.\n\nThe label-driven workflow prepared this clean cherry-pick but skipped PR creation because it treated the already-completed `core/1.54` target as a failure. Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…ibute breakout, form injection, and javascript: URLs (#18594) (#19139) Manual backport of #18594 to `cloud/1.55`.\n\nThe label-driven workflow prepared this clean cherry-pick but skipped PR creation because it treated the already-completed `core/1.54` target as a failure. Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Requested by Christian Byrne · Slack thread
Summary
Fixes three related XSS/sanitization bugs found in the same QA pass: markdown attribute breakout, missing form/style forbid-list in
SanitizedHtml, and unvalidatedjavascript:hrefs in the node manager's description panel.Before: A markdown image or link whose
href/altcontained a stray"(e.g.[x](``<y" style="position:fixed;inset:0;background:red">``)) could break out of its HTML attribute and inject a new one, such asstyle, which DOMPurify allows by default — enough to paint a full-screen overlay over the app. Separately,SanitizedHtml(used for release notes, node help text, widget markdown, and agent chat) had noFORBID_TAGS/FORBID_ATTR, so untrusted content containing a<form>with password inputs would render and submit, andstylesurvived, enabling the same kind of overlay or a fake sign-in box. Finally, the node manager's description panel bound a node pack'srepositoryURL and license URL straight tohrefwith either no validation orisValidUrl(a barenew URL()try/catch, which does not rejectjavascript:), so a malicious or compromised registry entry could set either field to ajavascript:URL that runs on click.After: The markdown renderer's
image/linkoverrides inmarkdownRendererUtil.tsnow HTML-attribute-escapehref,alt, andtitlebefore interpolating them, so a quote in any of those values can no longer create a new attribute.SanitizedHtml.vue's DOMPurify config now setsFORBID_TAGS: ['form', 'input', 'button']andFORBID_ATTR: ['style'](none of its current usages — release toasts, node help, widget markdown/text-preview, agent chat — need those tags/attribute, so this is a safe default).DescriptionTabPanel.vuenow gates both the repository link and the license link on a newisSafeExternalUrlhelper (http/https only), falling back to plain, non-clickable text for anything else, includingjavascript:.How: Added an
escapeHtmlhelper used at every attribute-interpolation site in the markdown renderer; addedFORBID_TAGS/FORBID_ATTRtoSanitizedHtml's sanitize config; added a newisSafeExternalUrlhelper (packages/shared-frontend-utils/src/urlSafety.ts, wired through the existing@/utils/*alias pattern) rather than tighteningisValidUrlin place, since that helper has several other call sites (electron mirror check,UrlInput, oauth) outside this task's scope. Added Vitest regression tests for each bug that fail against the pre-fix code and pass after (verified locally viagit stashon each file), plus a benign case for each so normal rendering still works. Ranpnpm typecheck,pnpm lint(oxlint type-aware + eslint), andpnpm knipclean on the full touched file set.Changes
image/linkoverrides;FORBID_TAGS/FORBID_ATTRinSanitizedHtml; newisSafeExternalUrlhelper gating the repository/license hrefs inDescriptionTabPanel.vue.Review Focus
SanitizedHtml.vue'sFORBID_TAGS/FORBID_ATTRapply globally to the component — I checked all current usages (release toasts, node help/preview, widget markdown/text-preview, agent chat/code block) and none render<form>/<input>/<button>or rely on inlinestyle, so this should be a safe default rather than needing a per-usage opt-out.isSafeExternalUrlis a new, narrowly-scoped helper rather than a change toisValidUrl, to avoid touching that function's other call sites (electron mirror check,UrlInput, oauth) which are out of scope here.Generated by Claude Code