Repository navigation
fix(TextPreviewWidget): preserve bracket-delimited text instead of parsing it as HTML - #18589
Conversation
…rsing it as HTML formattedText ran nl2br/linkifyHtml directly on the raw preview text before sanitizing, so any bracket-delimited content that looked like an HTML tag (e.g. `<lora:my_style_v2:0.8>`) was parsed as a tag and silently dropped by DOMPurify's strict allowlist. Escape the raw text's HTML-significant characters first, then run it through the existing nl2br/linkifyHtml/ [[label|url]] pipeline before sanitizing, so literal bracket text now displays as-is while URL auto-linking, line breaks and the custom link syntax keep working. Adds a small escapeHtml() utility and covers the fix with new TextPreviewWidget unit tests.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2123 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fce6d77e36b3f3ec7c00ce405c56628eabc55a12
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.98 MB gzip 🟢 -3.11 kBDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.87 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.44 MB) • 🟢 -2.05 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 4 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.94 MB (baseline 3.95 MB) • 🟢 -5.46 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 577 kB (baseline 577 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 17 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • 🟢 -956 BBundles that do not match a named category
Status: 82 added / 82 removed / 220 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T10:28:27.630Z",
"gitSha": "6dad72cbd9dc04f012dcd71a16bef8ab1f454fe0",
"branch": "fix/preview-widget-bracket-text",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2000.9229999999434,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.102000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.95900000000006,
"heapDeltaBytes": -6088352,
"heapUsedBytes": 61754584,
"domNodes": -258,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.258999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.045000000062,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.633000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.76699999999994,
"heapDeltaBytes": -7761144,
"heapUsedBytes": 59835908,
"domNodes": -262,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.351999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.7009999999955,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.88,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 667.861,
"heapDeltaBytes": -3454920,
"heapUsedBytes": 59101640,
"domNodes": -261,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 123.12499999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.832000000074,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.512,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 728.8619999999999,
"heapDeltaBytes": 9884520,
"heapUsedBytes": 77471076,
"domNodes": -259,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 153.386,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.5380000000569,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.558999999999997,
"layouts": 6,
"layoutDurationMs": 0.9859999999999999,
"taskDurationMs": 285.988,
"heapDeltaBytes": 3192084,
"heapUsedBytes": 70699776,
"domNodes": 80,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.183,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1687.59799999998,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.549,
"layouts": 6,
"layoutDurationMs": 1.0900000000000003,
"taskDurationMs": 333.291,
"heapDeltaBytes": 3134392,
"heapUsedBytes": 70680936,
"domNodes": 79,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.687,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 530.8750000000373,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.101000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.78299999999996,
"heapDeltaBytes": 18871696,
"heapUsedBytes": 86630200,
"domNodes": 22,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 128.41400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 667.8090000000338,
"styleRecalcs": 14,
"styleRecalcDurationMs": 10.268999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.217,
"heapDeltaBytes": 18974596,
"heapUsedBytes": 86569496,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 164.75599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1047.0850000000382,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 713.15,
"heapDeltaBytes": -17402488,
"heapUsedBytes": 73019884,
"domNodes": -293,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 51.89300000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 403,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1181.4550000000281,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 868.1850000000001,
"heapDeltaBytes": -16994312,
"heapUsedBytes": 73369864,
"domNodes": -293,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 66.67500000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 514,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 764.0089999999873,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.52699999999993,
"heapDeltaBytes": 14618160,
"heapUsedBytes": 91688908,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.842,
"eventListeners": 0,
"totalBlockingTimeMs": 157,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 857.4259999999185,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.2159999999999,
"heapDeltaBytes": 14264356,
"heapUsedBytes": 90626316,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.37100000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7485.025999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6656.004999999999,
"heapDeltaBytes": 11650512,
"heapUsedBytes": 93643148,
"domNodes": -18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 5301.861000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 78,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9749.576000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8867.812,
"heapDeltaBytes": 3752048,
"heapUsedBytes": 85630720,
"domNodes": -14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7183.224,
"eventListeners": 0,
"totalBlockingTimeMs": 277,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7464.935000000082,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.09699999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6602.363,
"heapDeltaBytes": -5416024,
"heapUsedBytes": 69162260,
"domNodes": -12,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 5278.508,
"eventListeners": 0,
"totalBlockingTimeMs": 72,
"frameDurationMs": 18.33666666666668,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9507.44199999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8726.442,
"heapDeltaBytes": -11316452,
"heapUsedBytes": 70791404,
"domNodes": -14,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 7073.723999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 561,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2024.5220000000472,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.913999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.9530000000001,
"heapDeltaBytes": -7193584,
"heapUsedBytes": 79977984,
"domNodes": -240,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 29.225999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2049.1329999999834,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.373999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 629.7959999999999,
"heapDeltaBytes": -6953276,
"heapUsedBytes": 80273992,
"domNodes": -245,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 35.94,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2186.884999999961,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.239,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1312.331,
"heapDeltaBytes": -7055184,
"heapUsedBytes": 80284780,
"domNodes": -242,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 668.729,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2399.9800000001414,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.935999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1677.71,
"heapDeltaBytes": 21071776,
"heapUsedBytes": 85190048,
"domNodes": -243,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 881.559,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3195.553000000018,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.633000000000004,
"layouts": 60,
"layoutDurationMs": 12.597999999999999,
"taskDurationMs": 1368.1760000000002,
"heapDeltaBytes": 8428052,
"heapUsedBytes": 74552632,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 640.22,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3643.4439999998176,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.822000000000001,
"layouts": 60,
"layoutDurationMs": 15.665,
"taskDurationMs": 1730.0780000000002,
"heapDeltaBytes": 8437860,
"heapUsedBytes": 74427084,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 808.324,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2374.810000000025,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.455,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1586.5380000000002,
"heapDeltaBytes": 10055064,
"heapUsedBytes": 75607384,
"domNodes": 8,
"jsHeapTotalBytes": 2060288,
"scriptDurationMs": 806.542,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2992.709999999988,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.293999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1910.4920000000002,
"heapDeltaBytes": 25143752,
"heapUsedBytes": 91518552,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 987.311,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.8130000000328,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.539999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.82399999999996,
"heapDeltaBytes": -6397944,
"heapUsedBytes": 82382376,
"domNodes": -243,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 31.937999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1998.9869999999428,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.2670000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.4420000000001,
"heapDeltaBytes": 19860800,
"heapUsedBytes": 84253812,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.284,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 515.0039999999763,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.979000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.72999999999996,
"heapDeltaBytes": 14076456,
"heapUsedBytes": 83916028,
"domNodes": 23,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 120.033,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 562.3320000001968,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.855,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.31899999999996,
"heapDeltaBytes": 14022188,
"heapUsedBytes": 83878008,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 142.402,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.2710000000734,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.086,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.05199999999996,
"heapDeltaBytes": 7157580,
"heapUsedBytes": 76992412,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.153,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1992.8990000000795,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.397999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.71200000000005,
"heapDeltaBytes": 5783880,
"heapUsedBytes": 75255484,
"domNodes": -272,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.516,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.1379999999153,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.284,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.4090000000001,
"heapDeltaBytes": 6129496,
"heapUsedBytes": 74979016,
"domNodes": -273,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 85.227,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.6279999999897,
"styleRecalcs": 47,
"styleRecalcDurationMs": 16.704000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 745.2310000000001,
"heapDeltaBytes": 8708188,
"heapUsedBytes": 78564016,
"domNodes": -273,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 105.004,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1264.599999999973,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.251999999999995,
"layouts": 5,
"layoutDurationMs": 10.235000000000001,
"taskDurationMs": 872.7319999999999,
"heapDeltaBytes": -6222324,
"heapUsedBytes": 82501764,
"domNodes": 13667,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 30.1,
"eventListeners": 2383,
"totalBlockingTimeMs": 115,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8176.955000000021,
"styleRecalcs": 252,
"styleRecalcDurationMs": 38.43000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4219.539,
"heapDeltaBytes": -11172396,
"heapUsedBytes": 75999320,
"domNodes": -236,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 2212.903,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8843.370999999934,
"styleRecalcs": 249,
"styleRecalcDurationMs": 45.547000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5960.283,
"heapDeltaBytes": -19812464,
"heapUsedBytes": 67358140,
"domNodes": -221,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 2902.5319999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 15378.492000000051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15174.176999999998,
"heapDeltaBytes": -34140784,
"heapUsedBytes": 179613328,
"domNodes": -8062,
"jsHeapTotalBytes": -9945088,
"scriptDurationMs": 225.22500000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18526.558000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18368.789,
"heapDeltaBytes": -33989320,
"heapUsedBytes": 191887088,
"domNodes": -8061,
"jsHeapTotalBytes": -12681216,
"scriptDurationMs": 336.67400000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23135.49599999999,
"styleRecalcs": 165,
"styleRecalcDurationMs": 22.625000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23043.953999999998,
"heapDeltaBytes": -42198060,
"heapUsedBytes": 181382852,
"domNodes": -8061,
"jsHeapTotalBytes": -21204992,
"scriptDurationMs": 951.6160000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 122,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 22858.376000000135,
"styleRecalcs": 164,
"styleRecalcDurationMs": 23.981999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22761.414,
"heapDeltaBytes": -29116664,
"heapUsedBytes": 194385600,
"domNodes": -8061,
"jsHeapTotalBytes": -14667776,
"scriptDurationMs": 968.318,
"eventListeners": -14928,
"totalBlockingTimeMs": 331,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6806.572000000074,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.23199999999999,
"layouts": 20,
"layoutDurationMs": 26.00799999999999,
"taskDurationMs": 6766.983000000001,
"heapDeltaBytes": -43610616,
"heapUsedBytes": 193015888,
"domNodes": -8061,
"jsHeapTotalBytes": 12640256,
"scriptDurationMs": 130.291,
"eventListeners": -14928,
"totalBlockingTimeMs": 419,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6662.422000000106,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.67800000000001,
"layouts": 20,
"layoutDurationMs": 25.440999999999992,
"taskDurationMs": 6646.067,
"heapDeltaBytes": -43093012,
"heapUsedBytes": 180590164,
"domNodes": -8061,
"jsHeapTotalBytes": 8941568,
"scriptDurationMs": 134.16500000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 496,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9182.099999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9139.17,
"heapDeltaBytes": 24226664,
"heapUsedBytes": 193723044,
"domNodes": 0,
"jsHeapTotalBytes": -29884416,
"scriptDurationMs": 155.262,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9220.888000000059,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9136.354000000001,
"heapDeltaBytes": -13796128,
"heapUsedBytes": 166961752,
"domNodes": 0,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 155.58399999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 107.72799999995186,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.527999999999999,
"layouts": 2,
"layoutDurationMs": 0.5569999999999998,
"taskDurationMs": 80.21600000000001,
"heapDeltaBytes": 3213412,
"heapUsedBytes": 68812492,
"domNodes": 111,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.915000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 107.33000000004722,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.575000000000003,
"layouts": 3,
"layoutDurationMs": 1.3149999999999997,
"taskDurationMs": 69.18900000000001,
"heapDeltaBytes": 2947156,
"heapUsedBytes": 68531224,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.755000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18589 +/- ##
==========================================
+ Coverage 83.54% 84.55% +1.00%
==========================================
Files 2991 2289 -702
Lines 148162 130889 -17273
Branches 38251 33414 -4837
==========================================
- Hits 123780 110667 -13113
+ Misses 23097 19922 -3175
+ Partials 1285 300 -985
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 709 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the raw-text escaping boundary, custom-link restoration, sanitization allowlist, and bracket-text/link/newline regressions. CI is green.
…rsing it as HTML (#18589)
|
1 similar comment
|
…ted text instead of parsing it as HTML (#18589) (#19137) Manual backport of #18589 to `cloud/1.55`.\n\nThe label-driven workflow prepared this clean cherry-pick but skipped PR creation because it treated the already-completed `core/1.54` target as a failure. Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…ed text instead of parsing it as HTML (#18589) (#19136) Manual backport of #18589 to `core/1.55`.\n\nThe label-driven workflow prepared this clean cherry-pick but skipped PR creation because it treated the already-completed `core/1.54` target as a failure. Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Requested by Christian Byrne · Slack thread
Summary
Fixes the "Preview Any" node's text widget silently dropping bracket-delimited text (e.g. LoRA/embedding syntax) that looks like an HTML tag.
Changes
TextPreviewWidget.vue'sformattedTextcomputed rannl2br/linkifyHtmldirectly on the raw preview text before sanitizing with DOMPurify. Because the raw text was parsed as HTML first, anything shaped like a tag was silently stripped.Before: A preview string like
Loaded lora: <lora:my_style_v2:0.8> applied successfullyrendered asLoaded lora: applied successfully— the entire<lora:...>chunk vanished, since it was parsed as an (unrecognized, allowlist-stripped) HTML tag before DOMPurify ever ran. This is a real workflow-authoring pain point since LoRA/embedding syntax is common in prompt text flowing through this widget.After: The raw text's HTML-significant characters (
& < > " ') are escaped beforenl2br/linkifyHtmlrun on it, so<lora:my_style_v2:0.8>now displays literally instead of being parsed and dropped. Bare URL auto-linking,\n→<br>, and the existing[[label|url]]custom link syntax (#6482) all keep working, since escaping happens first and none of those pipelines emit characters that collide with the escaped entities.How: Added a small
escapeHtml()utility (src/utils/htmlEscape.ts) and applied it to the raw text (and to the[[label|url]]token's label/url) ahead of the existingnl2br(linkifyHtml(...))pipeline, keeping the same DOMPurifyALLOWED_TAGS/ALLOWED_ATTRallowlist afterwards. One existing test asserted that a raw<a href="javascript:...">in the model value became a live (sanitized) anchor; that's the same class of bug (raw text parsed as HTML), so it now asserts the tag displays as literal text instead, and new tests cover bracket text, URLs,[[label|url]], and line breaks together.Review Focus
src/components/graph/widgets/TextPreviewWidget.test.ts: theescapes raw <a> tags instead of turning them into live anchorstest replaces a test that previously expected raw HTML anchors inmodelValueto become live (sanitized)<a>elements — that behavior is now intentionally removed, since raw text should never be parsed as author-supplied HTML.Generated by Claude Code