Repository navigation
fix(VirtualGrid): correctly clamp visible range when item list shrinks or column count grows - #18588
Conversation
…s or column count grows es-toolkit's clamp(value, min, max) produces nonsensical output when min > max. The end-of-range calc clamped against the raw, unclamped fromCol as its lower bound, so once fromCol pointed past a filtered list that just shrank or a column count that just grew while scrolled deep, end came out far past items.length and the rendered slice went empty. The empty slice then produced a negative bottom-spacer height (rejected by the CSSOM, leaving a stale value) and updateItemSize() early-returned with nothing to measure, so the view stayed blank even on further scroll. Clamp end against items.length directly, clamp start against that already-valid end, and when the scroll position still points entirely past the available items, shift the window left to show the trailing items instead of leaving the view blank. Removes the it.fails wrapper from both regression tests pinned in #17626 now that they pass, and adds a case for a filter shrinking the list to empty and then growing again.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2121 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.98 MB gzip 🔴 +282 kBDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.73 kB) • 🔴 +138 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.43 MB) • 🔴 +15.5 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 124 kB) • 🔴 +8.02 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 37.9 kB (baseline 27.8 kB) • 🔴 +10.1 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +740 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 124 kB (baseline 117 kB) • 🔴 +6.54 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.94 MB (baseline 3.6 MB) • 🔴 +339 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 577 kB (baseline 559 kB) • 🔴 +18.8 kBHelpers, composables, and utility bundles
Status: 31 added / 29 removed / 7 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -692 kBExternal libraries and shared vendor chunks
Status: 12 added / 12 removed / 6 unchanged Other — 17.8 MB (baseline 16.4 MB) • 🔴 +1.43 MBBundles that do not match a named category
Status: 179 added / 173 removed / 123 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T10:28:31.225Z",
"gitSha": "c02109827cec9fa999665e51ef934f9da6cf86aa",
"branch": "fix/virtual-grid-clamp-blank",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2003.678999999977,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.885000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.224,
"heapDeltaBytes": -7115504,
"heapUsedBytes": 60456832,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.186000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1990.8249999999725,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.852,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.63800000000003,
"heapDeltaBytes": -3163828,
"heapUsedBytes": 64406876,
"domNodes": -258,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.699999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.4849999999878,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.526999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 686.882,
"heapDeltaBytes": 10557064,
"heapUsedBytes": 77953484,
"domNodes": -260,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 147.891,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.6609999999082,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.879,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 791.122,
"heapDeltaBytes": 10222284,
"heapUsedBytes": 77636268,
"domNodes": -260,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 140.957,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.253999999958,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.139000000000001,
"layouts": 6,
"layoutDurationMs": 1.208,
"taskDurationMs": 254.891,
"heapDeltaBytes": 3052076,
"heapUsedBytes": 70519652,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.452,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.5830000000597,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.551,
"layouts": 6,
"layoutDurationMs": 1.0230000000000001,
"taskDurationMs": 324.581,
"heapDeltaBytes": 3177572,
"heapUsedBytes": 70567964,
"domNodes": 79,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.525,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 651.8050000000244,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.232000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.403,
"heapDeltaBytes": 18929968,
"heapUsedBytes": 86550596,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 167.14000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 631.8799999999101,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.119,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.93499999999995,
"heapDeltaBytes": 18893912,
"heapUsedBytes": 86318980,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 168.166,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1123.9889999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 744.625,
"heapDeltaBytes": 38501132,
"heapUsedBytes": 109023448,
"domNodes": 0,
"jsHeapTotalBytes": 20082688,
"scriptDurationMs": 57.06299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 518,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1154.7649999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 806.6120000000001,
"heapDeltaBytes": 38857544,
"heapUsedBytes": 108196572,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 59.617000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 533,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.7010000000291,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.55100000000016,
"heapDeltaBytes": 15419396,
"heapUsedBytes": 91205412,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 144.30299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.0659999999507,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.0399999999999,
"heapDeltaBytes": 15798116,
"heapUsedBytes": 92894196,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 143.507,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8885.907999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7929.424,
"heapDeltaBytes": -1340492,
"heapUsedBytes": 81577544,
"domNodes": -18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 6660.866999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 277,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9034.39800000001,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.909,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8320.619,
"heapDeltaBytes": 14801844,
"heapUsedBytes": 91884872,
"domNodes": -274,
"jsHeapTotalBytes": 9691136,
"scriptDurationMs": 6668.967000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 308,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9397.515999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8570.182,
"heapDeltaBytes": 10103644,
"heapUsedBytes": 91976932,
"domNodes": -10,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6939.147,
"eventListeners": 0,
"totalBlockingTimeMs": 289,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8649.524000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7942.541,
"heapDeltaBytes": 688660,
"heapUsedBytes": 82402284,
"domNodes": -16,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 6389.840999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 244,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2050.6470000000263,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.395999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 582.8299999999999,
"heapDeltaBytes": -2999992,
"heapUsedBytes": 83428292,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.944,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2034.5089999999573,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.460000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.5769999999999,
"heapDeltaBytes": -3335216,
"heapUsedBytes": 83566872,
"domNodes": -236,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 35.57599999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2107.9790000000003,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.004000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1516.4310000000003,
"heapDeltaBytes": 19029332,
"heapUsedBytes": 83692688,
"domNodes": -250,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 791.2289999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2161.2460000000056,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.171000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1533.9010000000003,
"heapDeltaBytes": 12054388,
"heapUsedBytes": 76210096,
"domNodes": -242,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 784.336,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3469.510000000014,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.015,
"layouts": 60,
"layoutDurationMs": 14.590000000000002,
"taskDurationMs": 1649.1890000000003,
"heapDeltaBytes": 8751496,
"heapUsedBytes": 74467488,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 765.582,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3437.460999999985,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.735000000000003,
"layouts": 60,
"layoutDurationMs": 13.961000000000002,
"taskDurationMs": 1598.4530000000002,
"heapDeltaBytes": 8094504,
"heapUsedBytes": 74116788,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 743.8249999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3134.9859999999694,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.826,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1951.071,
"heapDeltaBytes": -4491612,
"heapUsedBytes": 86429028,
"domNodes": -254,
"jsHeapTotalBytes": 708608,
"scriptDurationMs": 995.1959999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2983.233999999925,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.473,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1876.7749999999999,
"heapDeltaBytes": 26716504,
"heapUsedBytes": 92235344,
"domNodes": -252,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 972.652,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.2970000000514,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.424999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.896,
"heapDeltaBytes": -4605720,
"heapUsedBytes": 84175888,
"domNodes": -246,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.97,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.370000000009,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.798000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.9699999999999,
"heapDeltaBytes": 20614312,
"heapUsedBytes": 84541136,
"domNodes": -245,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.17100000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.0740000000387,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.67,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.705,
"heapDeltaBytes": 13796760,
"heapUsedBytes": 83604912,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.899,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.5929999999835,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.274000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.197,
"heapDeltaBytes": 14062624,
"heapUsedBytes": 83994392,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 144.554,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1992.1550000000252,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.324000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.842,
"heapDeltaBytes": -3731888,
"heapUsedBytes": 66370340,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.988999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1989.9809999999434,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.358,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.755,
"heapDeltaBytes": -14635980,
"heapUsedBytes": 55015460,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.876,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.5539999999728,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.39,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 705.0529999999999,
"heapDeltaBytes": -7704168,
"heapUsedBytes": 62110572,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 94.81400000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.6199999999635,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.595999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 690.399,
"heapDeltaBytes": -6908400,
"heapUsedBytes": 62969036,
"domNodes": -273,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 92.849,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.821000000049,
"styleRecalcs": 18,
"styleRecalcDurationMs": 27.327999999999992,
"layouts": 5,
"layoutDurationMs": 11.971,
"taskDurationMs": 866.19,
"heapDeltaBytes": 20280156,
"heapUsedBytes": 103685236,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 28.218,
"eventListeners": 2383,
"totalBlockingTimeMs": 120,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8334.500999999931,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.312,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5715.902,
"heapDeltaBytes": -6352352,
"heapUsedBytes": 80550652,
"domNodes": -240,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 2688.656,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8256.177999999978,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.593999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5493.905,
"heapDeltaBytes": -19445484,
"heapUsedBytes": 67797656,
"domNodes": -220,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 2641.6850000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17495.085000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16838.887,
"heapDeltaBytes": -56252872,
"heapUsedBytes": 175771908,
"domNodes": -8061,
"jsHeapTotalBytes": -18984960,
"scriptDurationMs": 305.948,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17585.657000000083,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17334.285,
"heapDeltaBytes": -56725688,
"heapUsedBytes": 184135204,
"domNodes": -8061,
"jsHeapTotalBytes": -14938112,
"scriptDurationMs": 284.367,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21331.63400000001,
"styleRecalcs": 153,
"styleRecalcDurationMs": 20.47199999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21102.301,
"heapDeltaBytes": -43873484,
"heapUsedBytes": 191385012,
"domNodes": -8061,
"jsHeapTotalBytes": -11354112,
"scriptDurationMs": 911.969,
"eventListeners": -14928,
"totalBlockingTimeMs": 21,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21266.208000000006,
"styleRecalcs": 157,
"styleRecalcDurationMs": 18.232,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21012.292999999998,
"heapDeltaBytes": -44837076,
"heapUsedBytes": 181565516,
"domNodes": -8062,
"jsHeapTotalBytes": -16683008,
"scriptDurationMs": 851.0680000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 78,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6198.69099999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.42399999999999,
"layouts": 20,
"layoutDurationMs": 24.947999999999997,
"taskDurationMs": 6107.268,
"heapDeltaBytes": -36813988,
"heapUsedBytes": 177790468,
"domNodes": -8061,
"jsHeapTotalBytes": 21483520,
"scriptDurationMs": 117.28800000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 404,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6203.323999999952,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.92199999999998,
"layouts": 20,
"layoutDurationMs": 24.456000000000007,
"taskDurationMs": 6138.570000000001,
"heapDeltaBytes": -43441400,
"heapUsedBytes": 182450336,
"domNodes": -8061,
"jsHeapTotalBytes": 13291520,
"scriptDurationMs": 114.53,
"eventListeners": -14928,
"totalBlockingTimeMs": 390,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8625.632999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8467.551,
"heapDeltaBytes": 9795968,
"heapUsedBytes": 171233236,
"domNodes": 0,
"jsHeapTotalBytes": -10485760,
"scriptDurationMs": 135.71999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8888.65199999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8503.689999999999,
"heapDeltaBytes": -19357776,
"heapUsedBytes": 178348284,
"domNodes": 0,
"jsHeapTotalBytes": -20447232,
"scriptDurationMs": 137.71199999999993,
"eventListeners": -1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 109.80000000006385,
"styleRecalcs": 6,
"styleRecalcDurationMs": 14.618999999999998,
"layouts": 3,
"layoutDurationMs": 1.516,
"taskDurationMs": 80.295,
"heapDeltaBytes": 3166016,
"heapUsedBytes": 68767620,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.845,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 455.4870000000619,
"styleRecalcs": 21,
"styleRecalcDurationMs": 21.801000000000002,
"layouts": 3,
"layoutDurationMs": 1.4020000000000001,
"taskDurationMs": 110.802,
"heapDeltaBytes": 5031652,
"heapUsedBytes": 67292096,
"domNodes": 150,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.857999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fce6d77e36b3f3ec7c00ce405c56628eabc55a12
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18588 +/- ##
==========================================
+ Coverage 83.54% 84.54% +0.99%
==========================================
Files 2991 2288 -703
Lines 148162 130891 -17271
Branches 38251 35308 -2943
==========================================
- Hits 123780 110658 -13122
+ Misses 23097 19933 -3164
+ Partials 1285 300 -985
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 710 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the range-clamping order, empty-to-populated recovery path, and regression coverage. The implementation preserves 0 <= start <= end <= total and CI is green.
|
|
…s or column count grows (#18588)
…when item list shrinks or column count grows (#18588) (#19060) Manual backport of #18588 after automation conflicted in `VirtualGrid.test.ts`. The release branch did not yet have the newer scroll regression-test harness, so this preserves the 1.54 VueUse mock style while adding the three fixed regression cases. Verification: - `pnpm vitest run src/components/common/VirtualGrid.test.ts` (11/11) - pre-commit format, stylelint, oxlint, eslint, and `typecheck:app` all passed Original merge: 59fb54c Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
|
1 similar comment
|
…when item list shrinks or column count grows (#18588) (#19134) Manual backport of #18588 to `core/1.55`.\n\nThe label-driven workflow prepared this clean cherry-pick but skipped PR creation because it treated the already-completed `core/1.54` target as a failure. Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
… when item list shrinks or column count grows (#18588) (#19135) Manual backport of #18588 to `cloud/1.55`.\n\nThe label-driven workflow prepared this clean cherry-pick but skipped PR creation because it treated the already-completed `core/1.54` target as a failure. Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Requested by Christian Byrne · Slack thread
Summary
Fixes the known "grid goes blank" bug in
VirtualGrid.vue(shared by the Assets panel grid, manager dialog, etc.), pinned asit.failsregression tests in #17626.Changes
Before: Scrolled deep into a virtualized grid, two things could make the whole view go permanently blank: (1) the visible column count growing (e.g. a browser zoom or window resize), or (2) the filtered/visible item list shrinking below the currently-scrolled-to index (e.g. changing a type filter). In both cases,
fromCol(the scroll-derived start-of-range index) ended up past the new, smalleritems.length. Theendof the visible range was computed withclamp(toCol, fromCol, items.length), and es-toolkit'sclamp(value, min, max)produces a nonsensical result whenmin > max— here it collapsedenddown tofromCol, a value far pastitems.length. The rendered slice (items.slice(start, end)) then came out empty. That empty render produced a negative bottom-spacer height, which the CSSOM silently rejects (leaving a stale height), andupdateItemSize()early-returns once there's nothing rendered to measure — so the view stayed blank even on further scrolling, with no way to self-correct.After:
endis now clamped directly againstitems.length, andstartis clamped against that already-validend(never against the raw, unclampedfromCol), guaranteeing0 <= start <= end <= items.lengthon every recompute. If the scroll position still points entirely past the available items after that (e.g. the list just got much shorter), the window shifts left to show the trailing items instead of rendering nothing, matching what a user would expect: something is always shown when items exist.How
The fix is scoped to the
statecomputed property insrc/components/common/VirtualGrid.vue(~line 83-105) — no other files needed changes. Both regression tests pinned asit.failsin #17626 (#17626) now pass and had theirit.failswrapper removed inVirtualGrid.test.ts. An additional test case was added covering a filter shrinking the list all the way to empty and then growing back, to make sure the view recovers from that edge case too. All 11 tests inVirtualGrid.test.tspass, along witheslint,oxlint, andvue-tsc --noEmit.Review Focus
The "shift the window left to show trailing items" behavior in the
if (start === end && total > 0)branch is a deliberate UX choice (show the tail of the list rather than a blank view when scrolled past a shrunk list) — flag if a different fallback (e.g. resetting scroll to top) is preferred instead.Generated by Claude Code