Repository navigation
test: assert unpack telemetry and restored links for subgraph conversion - #18578
Conversation
|
Warning Review limit reached
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 7 minutes. View limit detailsLimit details: You’ve used all 8 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2121 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fce6d77e36b3f3ec7c00ce405c56628eabc55a12
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.98 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.87 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.94 MB (baseline 3.94 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 577 kB (baseline 577 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 302 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T09:48:39.282Z",
"gitSha": "bb18a3cbcc0b1aec0ec211a073f811b057b57985",
"branch": "test/subgraph-unpack-telemetry-followup-17330",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.0419999999658,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.659000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.6650000000001,
"heapDeltaBytes": 9872216,
"heapUsedBytes": 77446540,
"domNodes": -262,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 11.542,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1991.4240000000518,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.386999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.79099999999994,
"heapDeltaBytes": 7095376,
"heapUsedBytes": 73839812,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.141000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1725.8649999999989,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.093000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 829.082,
"heapDeltaBytes": 20416984,
"heapUsedBytes": 81612064,
"domNodes": -261,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 154.301,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.2709999999834,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.672,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 776.978,
"heapDeltaBytes": -3749192,
"heapUsedBytes": 64228684,
"domNodes": -258,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 142.221,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.3810000000344,
"styleRecalcs": 29,
"styleRecalcDurationMs": 15.214,
"layouts": 6,
"layoutDurationMs": 1.1570000000000003,
"taskDurationMs": 363.29799999999994,
"heapDeltaBytes": 3154172,
"heapUsedBytes": 70735168,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.610999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.4110000000683,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.328000000000001,
"layouts": 6,
"layoutDurationMs": 1.195,
"taskDurationMs": 346.62699999999995,
"heapDeltaBytes": 3007660,
"heapUsedBytes": 70885832,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.370000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 647.7429999999913,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.204,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.53999999999996,
"heapDeltaBytes": 18923264,
"heapUsedBytes": 86728328,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 168.311,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 628.2069999999749,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.098000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.577,
"heapDeltaBytes": 18941908,
"heapUsedBytes": 86492232,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 174.233,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1211.005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 885.1020000000001,
"heapDeltaBytes": -17512488,
"heapUsedBytes": 72763524,
"domNodes": -295,
"jsHeapTotalBytes": 21889024,
"scriptDurationMs": 64.17800000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 528,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1184.7099999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 885.811,
"heapDeltaBytes": -17099868,
"heapUsedBytes": 72984032,
"domNodes": -295,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 64.966,
"eventListeners": -217,
"totalBlockingTimeMs": 527,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 856.568999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.13099999999986,
"heapDeltaBytes": 14896132,
"heapUsedBytes": 91556436,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 154.547,
"eventListeners": 0,
"totalBlockingTimeMs": 243,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 863.2039999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.9129999999999,
"heapDeltaBytes": 14821264,
"heapUsedBytes": 90126692,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.98699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9551.833999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8673.912000000002,
"heapDeltaBytes": 289488,
"heapUsedBytes": 82267264,
"domNodes": -20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 6986.116,
"eventListeners": 0,
"totalBlockingTimeMs": 318,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9404.787000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8561.941,
"heapDeltaBytes": -14149180,
"heapUsedBytes": 68363560,
"domNodes": -18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6858.448,
"eventListeners": 0,
"totalBlockingTimeMs": 199,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9651.804999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8771.488,
"heapDeltaBytes": 11934220,
"heapUsedBytes": 93933304,
"domNodes": -12,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 7022.004,
"eventListeners": 0,
"totalBlockingTimeMs": 480,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9187.126000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8372.555,
"heapDeltaBytes": -5222984,
"heapUsedBytes": 69448224,
"domNodes": -4,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 6700.8060000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 150,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2105.2970000000073,
"styleRecalcs": 11,
"styleRecalcDurationMs": 14.838000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 767.749,
"heapDeltaBytes": -5177764,
"heapUsedBytes": 81828100,
"domNodes": -238,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 44.533,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.3919999999544,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.393999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.6890000000001,
"heapDeltaBytes": -3035480,
"heapUsedBytes": 83487856,
"domNodes": -246,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 35.18399999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2508.8670000000093,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.74,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1747.2779999999996,
"heapDeltaBytes": 20555840,
"heapUsedBytes": 84606276,
"domNodes": -245,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 866.7579999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2270.74499999992,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.225000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1687.033,
"heapDeltaBytes": -7015960,
"heapUsedBytes": 80573668,
"domNodes": -246,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 827.1780000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3613.4230000000116,
"styleRecalcs": 62,
"styleRecalcDurationMs": 13.180999999999997,
"layouts": 60,
"layoutDurationMs": 15.173999999999998,
"taskDurationMs": 1781.809,
"heapDeltaBytes": 8325184,
"heapUsedBytes": 74206284,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 819.952,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3522.1900000000232,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.644000000000004,
"layouts": 60,
"layoutDurationMs": 14.498000000000001,
"taskDurationMs": 1683.2549999999999,
"heapDeltaBytes": 8133572,
"heapUsedBytes": 74444368,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 787.664,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3162.948999999969,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.486,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2018.125,
"heapDeltaBytes": 29590492,
"heapUsedBytes": 95454952,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1032.339,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3201.0080000000016,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.219000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1974.7930000000001,
"heapDeltaBytes": 25827652,
"heapUsedBytes": 91662928,
"domNodes": 8,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1002.3109999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.6459999999997,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.480000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.864,
"heapDeltaBytes": -4534436,
"heapUsedBytes": 84143708,
"domNodes": -246,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 35.17300000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2060.320000000047,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.038,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 628.738,
"heapDeltaBytes": -7682092,
"heapUsedBytes": 79806012,
"domNodes": -250,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 33.75,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.95100000001,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.338999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.1980000000001,
"heapDeltaBytes": 13917136,
"heapUsedBytes": 83028988,
"domNodes": 21,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 144.834,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.3709999999382,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.655000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.16200000000003,
"heapDeltaBytes": 13806200,
"heapUsedBytes": 83455696,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 145.975,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2021.6499999999655,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.219,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.442,
"heapDeltaBytes": 2270664,
"heapUsedBytes": 71356932,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.329000000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2001.8380000000207,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.760999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.60900000000004,
"heapDeltaBytes": -187700,
"heapUsedBytes": 68853348,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.515000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.3290000000252,
"styleRecalcs": 47,
"styleRecalcDurationMs": 16.511,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 779.999,
"heapDeltaBytes": -4193144,
"heapUsedBytes": 65112444,
"domNodes": -275,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 108.972,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.7890000000853,
"styleRecalcs": 44,
"styleRecalcDurationMs": 13.139999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 710.248,
"heapDeltaBytes": -7586964,
"heapUsedBytes": 62316704,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 99.94200000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.4020000000146,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.858999999999995,
"layouts": 5,
"layoutDurationMs": 12.225,
"taskDurationMs": 960.3759999999996,
"heapDeltaBytes": -6322900,
"heapUsedBytes": 82196384,
"domNodes": 13667,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 32.998,
"eventListeners": 2383,
"totalBlockingTimeMs": 128,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8481.465000000015,
"styleRecalcs": 248,
"styleRecalcDurationMs": 41.586999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6097.415000000001,
"heapDeltaBytes": -10448752,
"heapUsedBytes": 76411184,
"domNodes": -247,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 2796.1969999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8356.284000000072,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.31999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5744.236,
"heapDeltaBytes": -5684220,
"heapUsedBytes": 80625608,
"domNodes": -242,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2742.737,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13257.993999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12749.715999999999,
"heapDeltaBytes": -53338216,
"heapUsedBytes": 188494388,
"domNodes": -8063,
"jsHeapTotalBytes": -11669504,
"scriptDurationMs": 227.238,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17864.66799999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17745.6,
"heapDeltaBytes": -56801984,
"heapUsedBytes": 183786556,
"domNodes": -8065,
"jsHeapTotalBytes": -14573568,
"scriptDurationMs": 289.002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21872.03899999997,
"styleRecalcs": 156,
"styleRecalcDurationMs": 21.699999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21722.388000000003,
"heapDeltaBytes": -73948436,
"heapUsedBytes": 167245068,
"domNodes": -8061,
"jsHeapTotalBytes": -20385792,
"scriptDurationMs": 902.8349999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 119,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21684.80999999997,
"styleRecalcs": 155,
"styleRecalcDurationMs": 23.29200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21512.367,
"heapDeltaBytes": -44908364,
"heapUsedBytes": 180473252,
"domNodes": -8061,
"jsHeapTotalBytes": -15740928,
"scriptDurationMs": 937.168,
"eventListeners": -14928,
"totalBlockingTimeMs": 85,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6330.3620000000365,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.724,
"layouts": 20,
"layoutDurationMs": 24.418999999999997,
"taskDurationMs": 6254.302999999999,
"heapDeltaBytes": -39324040,
"heapUsedBytes": 175149620,
"domNodes": -8061,
"jsHeapTotalBytes": 16453632,
"scriptDurationMs": 116.856,
"eventListeners": -14928,
"totalBlockingTimeMs": 466,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6476.135999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.62200000000001,
"layouts": 20,
"layoutDurationMs": 24.878999999999998,
"taskDurationMs": 6434.609000000001,
"heapDeltaBytes": -49147316,
"heapUsedBytes": 193510676,
"domNodes": -8061,
"jsHeapTotalBytes": 6639616,
"scriptDurationMs": 124.018,
"eventListeners": -14928,
"totalBlockingTimeMs": 414,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9006.378999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8896.614999999998,
"heapDeltaBytes": 31340864,
"heapUsedBytes": 190261400,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 144.02099999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8883.645,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8848.699999999999,
"heapDeltaBytes": 36389632,
"heapUsedBytes": 198961068,
"domNodes": 0,
"jsHeapTotalBytes": -8912896,
"scriptDurationMs": 146.35700000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 112.82699999992474,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.331000000000003,
"layouts": 2,
"layoutDurationMs": 1.701,
"taskDurationMs": 84.30699999999999,
"heapDeltaBytes": 3072240,
"heapUsedBytes": 68730256,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.947000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 449.1890000000467,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.081999999999994,
"layouts": 3,
"layoutDurationMs": 1.0279999999999998,
"taskDurationMs": 105.494,
"heapDeltaBytes": 4787796,
"heapUsedBytes": 70209504,
"domNodes": 119,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.325999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18578 +/- ##
==========================================
+ Coverage 83.54% 84.54% +0.99%
==========================================
Files 2991 2288 -703
Lines 148162 130885 -17277
Branches 38251 35306 -2945
==========================================
- Hits 123780 110655 -13125
+ Misses 23097 19930 -3167
+ Partials 1285 300 -985
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| malformedLink: LLink | ||
| ) { | ||
| expect(mockReportError).toHaveBeenCalledExactlyOnceWith( | ||
| new Error('Cannot unpack subgraph: unresolvable inner link'), |
There was a problem hiding this comment.
This is pretty change-detector
There was a problem hiding this comment.
Tracked as FE-2869. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
Follow-up to review threads on #17330 (merged). Tests only.
reportErrortelemetry call (error_unpacking_subgraph_link, six context keys)subgraphNode.graph!non-null assertions withsubgraph.rootGraphFull context for agent readers
Source: post-merge review threads on #17330 from CodeJuggernaut and CodeRabbit.
Changes, all in
src/lib/litegraph/src/subgraph/SubgraphConversion.test.ts:expectUnresolvableLinkReported(subgraphNode, malformedLink)assertsreportErrorwas called exactly once withnew Error('Cannot unpack subgraph: unresolvable inner link')and{ errorType: 'error_unpacking_subgraph_link', context: { subgraphNodeId, linkId, originId, originSlot, targetId, targetSlot } }. This mirrors the production call insrc/lib/litegraph/src/LGraph.ts(unpackSubgraph, unresolvable-link branch). Called in the five malformed-link tests afterexpectUnpackRejected.expectUnpackRejectedkeeps the strong form: serialized graph unchanged, node count unchanged,beforeChange/afterChangenot called, and the original subgraph node instance still present.sourceandtargetvia thecreateTestNodetitle argument, then assertsgraph.nodestitles equal['source', 'target']and the restored links map to[{ origin: 'source', originSlot: 0, target: 'target', targetSlot: 0 }].subgraphNode.graph!replaced withsubgraph.rootGraph(the fixturecreateTestSubgraphNodeattaches tooptions.parentGraph ?? subgraph.rootGraph, andSubgraph.rootGraphis typed non-null).Declined: CodeRabbit's suggestion to preflight reroute
parentIdchains. Reroute resolution is a separate code path from the link-endpoint check that PR 17330 added; a chain preflight belongs in its own change with its own tests.Verification: relies on hosted CI for this PR; no local test run was performed for this commit.