Repository navigation
feat(agent): park undeliverable human ops in the follower outbox and replay them on resubscribe - #18533
feat(agent): park undeliverable human ops in the follower outbox and replay them on resubscribe#18533christian-byrne wants to merge 1 commit into
Conversation
…replay them on resubscribe The sender's transport retry budget is a delivery budget, not a retention budget. Wire the human-op outbox into useAgentCrdtFollower so a batch that exhausts retries during an outage is parked instead of lost, and hand it back to the sender under its original op_id on the first doc_subscribed ok after reconnected. A doc_reset drops what was parked against the old lineage so nothing replays into the successor doc. Memory-backed store only; a page-lifetime store follows.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 59e71cf30cd5b51f8324b285c3496cf0d9ff2bb8
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2115 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-23T04:45:29.486Z",
"gitSha": "d5b044b9cfc1c53d4cf4f578951f5b44feb4f91a",
"branch": "christian-byrne/mutref3-s3-follower",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.3599999999824,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.047,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.99,
"heapDeltaBytes": 9558340,
"heapUsedBytes": 77159048,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 12.379999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2030.4740000000265,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.587,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.473,
"heapDeltaBytes": 9537896,
"heapUsedBytes": 77229376,
"domNodes": -258,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.980000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.865999999986,
"styleRecalcs": 45,
"styleRecalcDurationMs": 20.548000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 945.117,
"heapDeltaBytes": -5394092,
"heapUsedBytes": 62255084,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 186.235,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1877.6169999999865,
"styleRecalcs": 45,
"styleRecalcDurationMs": 18.305999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 985.786,
"heapDeltaBytes": 10548380,
"heapUsedBytes": 77245068,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 188.34699999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.6119999999892,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.055000000000003,
"layouts": 6,
"layoutDurationMs": 1.611,
"taskDurationMs": 424.857,
"heapDeltaBytes": 3168000,
"heapUsedBytes": 70676436,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 15.738999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1681.5239999999676,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.498000000000005,
"layouts": 6,
"layoutDurationMs": 1.2930000000000001,
"taskDurationMs": 400.64000000000004,
"heapDeltaBytes": 3077424,
"heapUsedBytes": 70625856,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.911000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 743.9299999999776,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.310000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.494,
"heapDeltaBytes": 18944916,
"heapUsedBytes": 86582112,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 188.86700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 730.5639999999585,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.637,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.142,
"heapDeltaBytes": 18878176,
"heapUsedBytes": 86559704,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 182.87599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1208.4899999999834,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 919.399,
"heapDeltaBytes": 38350388,
"heapUsedBytes": 107201036,
"domNodes": 0,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 79.08699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 598,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1220.6259999999247,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 889.377,
"heapDeltaBytes": 38299672,
"heapUsedBytes": 107083584,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 82.36399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 600,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 855.9649999999692,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.4390000000004,
"heapDeltaBytes": 14634660,
"heapUsedBytes": 91055644,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 185.99900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 242,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 919.8069999999916,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.8619999999999,
"heapDeltaBytes": 16043744,
"heapUsedBytes": 92209240,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 196.409,
"eventListeners": 0,
"totalBlockingTimeMs": 246,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12808.130000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11863.377999999999,
"heapDeltaBytes": -1867680,
"heapUsedBytes": 80444236,
"domNodes": -12,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9849.523,
"eventListeners": 0,
"totalBlockingTimeMs": 2349,
"frameDurationMs": 19.446666666666715,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 12055.716000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11158.628999999999,
"heapDeltaBytes": 12744528,
"heapUsedBytes": 94942012,
"domNodes": -14,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9171.544,
"eventListeners": 0,
"totalBlockingTimeMs": 2167,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11807.86599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10905.508,
"heapDeltaBytes": 16313372,
"heapUsedBytes": 98336720,
"domNodes": -18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8940.065,
"eventListeners": 0,
"totalBlockingTimeMs": 1797,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11969.855999999936,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11068.755,
"heapDeltaBytes": 3181924,
"heapUsedBytes": 80241948,
"domNodes": -12,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9067.946000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 2003,
"frameDurationMs": 19.996666666666595,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2047.8239999999914,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.452,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 671.7400000000001,
"heapDeltaBytes": -3809996,
"heapUsedBytes": 83166304,
"domNodes": -244,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 44.74400000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2067.3759999999675,
"styleRecalcs": 6,
"styleRecalcDurationMs": 14.82,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 721.3069999999999,
"heapDeltaBytes": -3042892,
"heapUsedBytes": 83409004,
"domNodes": -246,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 46.068999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3136.618999999996,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.431000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1936.953,
"heapDeltaBytes": 24608332,
"heapUsedBytes": 88757252,
"domNodes": -249,
"jsHeapTotalBytes": 2060288,
"scriptDurationMs": 980.0500000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3158.403000000021,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.855999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2070.145,
"heapDeltaBytes": -3015260,
"heapUsedBytes": 77767292,
"domNodes": -223,
"jsHeapTotalBytes": 3624960,
"scriptDurationMs": 1071.7569999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3951.4770000000112,
"styleRecalcs": 62,
"styleRecalcDurationMs": 14.613000000000001,
"layouts": 60,
"layoutDurationMs": 16.418000000000003,
"taskDurationMs": 1958.7409999999998,
"heapDeltaBytes": 9825184,
"heapUsedBytes": 74915044,
"domNodes": -256,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 907.7160000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4106.55399999996,
"styleRecalcs": 64,
"styleRecalcDurationMs": 20.619,
"layouts": 60,
"layoutDurationMs": 16.337999999999997,
"taskDurationMs": 2070.225,
"heapDeltaBytes": -15296300,
"heapUsedBytes": 73743504,
"domNodes": -258,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 949.063,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3414.478000000031,
"styleRecalcs": 43,
"styleRecalcDurationMs": 9.041,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2318.481,
"heapDeltaBytes": -1038180,
"heapUsedBytes": 89847432,
"domNodes": -260,
"jsHeapTotalBytes": 184320,
"scriptDurationMs": 1157.6609999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 5,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3386.6160000000036,
"styleRecalcs": 41,
"styleRecalcDurationMs": 7.865000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2294.088,
"heapDeltaBytes": 1275184,
"heapUsedBytes": 66844064,
"domNodes": -257,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 1185.154,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2059.518999999966,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.171999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 679.818,
"heapDeltaBytes": -5953488,
"heapUsedBytes": 82723896,
"domNodes": -253,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 41.248000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2030.4330000000164,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.247000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 643.3549999999999,
"heapDeltaBytes": -5213700,
"heapUsedBytes": 84147296,
"domNodes": -249,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 41.83700000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 663.9349999999808,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.561,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.69399999999996,
"heapDeltaBytes": 13987528,
"heapUsedBytes": 83820944,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 157.498,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 662.4699999999848,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.196999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.974,
"heapDeltaBytes": 13854736,
"heapUsedBytes": 77089048,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 163.408,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2013.3829999999762,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.338,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.181,
"heapDeltaBytes": -14078012,
"heapUsedBytes": 55789784,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.918000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.0580000000446,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.735000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.708,
"heapDeltaBytes": -10966716,
"heapUsedBytes": 58752076,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.828000000000003,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.9549999999758,
"styleRecalcs": 46,
"styleRecalcDurationMs": 19.520000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 912.675,
"heapDeltaBytes": 4809740,
"heapUsedBytes": 73790592,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 132.12600000000003,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.7760000000726,
"styleRecalcs": 46,
"styleRecalcDurationMs": 20.680000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 908.1829999999999,
"heapDeltaBytes": 4181904,
"heapUsedBytes": 74030136,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 132.093,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1451.3359999999693,
"styleRecalcs": 15,
"styleRecalcDurationMs": 32.304,
"layouts": 5,
"layoutDurationMs": 14.124,
"taskDurationMs": 1118.999,
"heapDeltaBytes": -6322824,
"heapUsedBytes": 85735584,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 42.59700000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 162,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9936.793000000023,
"styleRecalcs": 249,
"styleRecalcDurationMs": 46.979,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6286.540000000001,
"heapDeltaBytes": -5814256,
"heapUsedBytes": 80721316,
"domNodes": -248,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 3280.3790000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10326.397999999926,
"styleRecalcs": 248,
"styleRecalcDurationMs": 45.67100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6749.213,
"heapDeltaBytes": -1710368,
"heapUsedBytes": 84831752,
"domNodes": -246,
"jsHeapTotalBytes": 1269760,
"scriptDurationMs": 3208.4570000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 18992.867000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18723.671,
"heapDeltaBytes": -50291968,
"heapUsedBytes": 191326976,
"domNodes": -8061,
"jsHeapTotalBytes": -17506304,
"scriptDurationMs": 385.602,
"eventListeners": -14928,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 19099.64000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18830.829,
"heapDeltaBytes": -56968768,
"heapUsedBytes": 170932828,
"domNodes": -8061,
"jsHeapTotalBytes": -15929344,
"scriptDurationMs": 372.73199999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 24411.34999999997,
"styleRecalcs": 180,
"styleRecalcDurationMs": 27.673999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24253.264000000003,
"heapDeltaBytes": -65873544,
"heapUsedBytes": 170581172,
"domNodes": -8061,
"jsHeapTotalBytes": -13643776,
"scriptDurationMs": 1051.465,
"eventListeners": -14928,
"totalBlockingTimeMs": 171,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 24732.984999999986,
"styleRecalcs": 179,
"styleRecalcDurationMs": 31.144000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24603.862,
"heapDeltaBytes": -44044712,
"heapUsedBytes": 181838192,
"domNodes": -8061,
"jsHeapTotalBytes": -16785408,
"scriptDurationMs": 1088.431,
"eventListeners": -14928,
"totalBlockingTimeMs": 304,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6876.860999999963,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.26099999999998,
"layouts": 20,
"layoutDurationMs": 27.069999999999997,
"taskDurationMs": 6842.168,
"heapDeltaBytes": -40954732,
"heapUsedBytes": 174138060,
"domNodes": -8061,
"jsHeapTotalBytes": 7020544,
"scriptDurationMs": 136.64399999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 445,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 7086.5929999999935,
"styleRecalcs": 20,
"styleRecalcDurationMs": 108.19699999999999,
"layouts": 20,
"layoutDurationMs": 29.68,
"taskDurationMs": 7049.638000000001,
"heapDeltaBytes": -34171268,
"heapUsedBytes": 181187284,
"domNodes": -8061,
"jsHeapTotalBytes": 8843264,
"scriptDurationMs": 170.855,
"eventListeners": -14928,
"totalBlockingTimeMs": 512,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10049.799000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9962.385999999999,
"heapDeltaBytes": -25391004,
"heapUsedBytes": 162668252,
"domNodes": 0,
"jsHeapTotalBytes": -15990784,
"scriptDurationMs": 245.32399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 10,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9637.580999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9513.104,
"heapDeltaBytes": -9808768,
"heapUsedBytes": 183504180,
"domNodes": 0,
"jsHeapTotalBytes": -20971520,
"scriptDurationMs": 169.62599999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 112.20000000002983,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.187000000000001,
"layouts": 2,
"layoutDurationMs": 0.858,
"taskDurationMs": 87.68999999999998,
"heapDeltaBytes": 3214484,
"heapUsedBytes": 69175900,
"domNodes": 109,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.355999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 470.46399999999267,
"styleRecalcs": 14,
"styleRecalcDurationMs": 23.793000000000003,
"layouts": 3,
"layoutDurationMs": 1.0730000000000002,
"taskDurationMs": 137.26699999999997,
"heapDeltaBytes": 4911432,
"heapUsedBytes": 70525028,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.545,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## christian-byrne/mutref3-s2-wire #18533 +/- ##
===================================================================
- Coverage 84.38% 84.38% -0.01%
===================================================================
Files 2286 2286
Lines 130642 130651 +9
Branches 33369 35262 +1893
===================================================================
+ Hits 110242 110247 +5
- Misses 20104 20108 +4
Partials 296 296
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 6 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
| sender.abortAll() | ||
| // Lineage break: ops parked against the pre-reset doc must not be | ||
| // replayed into its successor (FC-5), so the outbox forgets them here. | ||
| outbox.drop(detail.workflowId) |
There was a problem hiding this comment.
🟠 High — This outbox.drop() is the only lineage-break guard, but it sits behind the isCurrentWorkflow() check above and LayoutFollowerBridge.onDocReset already discards any doc_reset whose workflowId !== sentWorkflowId — so a reset that lands while this tab is unsubscribed (inactive tab has called bridge.unsubscribe()), while it is following another workflow, or after a subscribe refusal is never witnessed and the parked ops stay replayable. doc_subscribed carries no lineage/epoch identity, and the __applied dedupe ledger lives inside the Y.Doc that the reset just re-minted, so KA-6 does not save it: the replay applies the human edit a second time on top of the successor draft that already carries its effect. Raised by 6 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).
| // resubscribes; this ack is the first moment a send can succeed. | ||
| const subscribed = bridge.subscribedWorkflowId | ||
| if (subscribed !== null) { | ||
| const replayed = replayParkedOps(outbox, sender, subscribed) |
There was a problem hiding this comment.
🟠 High — replayParkedOps → sender.readmit() → place() appends to the tail of the sender's currently open admission group, and the real LayoutFollowerBridge.resubscribe()/reconcile() re-sets sentWorkflowId synchronously on a live socket — so anything the user mints in the subscribe-to-ack window, plus whatever resumeHeldOpsIfSubscribed() just released one line above, goes out ahead of the older parked ops. That inverts mint order on the wire (breaking opSender's documented invariant): a stale parked write can land after and overwrite a newer edit to the same node/widget, and a rejection in the merged batch aborts the remainder, re-parking the replay. Seal the replay into its own batch ordered ahead of the newer work. Raised by 5 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| } | ||
| projection.clearForReset(detail.workflowId, context) | ||
| sender.abortAll() | ||
| // Lineage break: ops parked against the pre-reset doc must not be |
There was a problem hiding this comment.
🟡 Medium — The drop is positioned so it can be both skipped and undone. projection.clearForReset() runs first and can throw while sweeping extension onRemoved hooks — a listener exception does not stop the bridge from replacing and resubscribing the doc, so the outbox survives into the successor lineage. And if any sender.abortAll() settlement callback fires on a microtask/timer instead of synchronously, outboxHooks.onBatchSettled re-parks those aborted ops after drop() has already run. Move the sender/outbox invalidation ahead of the throwable projection call (or into a finally), and confirm abortAll() settles synchronously. Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, gemini-3.1-pro edge-case, kimi-k3-max adversarial).
| confirmedDeletes.add(String(op.node_id)) | ||
| } | ||
| } | ||
| outboxHooks.onBatchSettled(outcome) |
There was a problem hiding this comment.
🟡 Medium — Parked deletes are invisible to the resurrection guard: pendingHumanDeletes() is built from confirmedDeletes plus sender.pendingOps(), but once this hook parks an undeliverable delete_node the sender has already retired it and it was never confirmed. Any reconcile during the park window — now unbounded, since it lasts until the next subscribe ack, and the bridge permits live updates before that ack — makes projection.reconcileLiveGraph re-materialize the node the user deleted, which the replay then deletes again. Feed the outbox's parked deletes into pendingHumanDeletes. Raised by 3 of 8 reviewers (gpt-5.6-sol-max edge-case, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial).
| tab: tabId, | ||
| actor: () => `human:${userId() ?? 'anonymous'}:${tabId}`, | ||
| baseVersion: () => bridge.lastSequence, | ||
| onBatchMinted: outboxHooks.onBatchMinted, |
There was a problem hiding this comment.
🟡 Medium — The sender only fires onBatchMinted when deps.workflowId() is non-null, so an op minted while no subscribe frame has left the transport (user edits during the initial socket/subscribe window, with the active-workflow mint gate already open) settles undeliverable without ever reaching the outbox and is permanently lost — the exact case the feature exists to cover. Either record those batches under the intended workflow this composable already knows, or soften the "every minted human op is recorded here until the host rules on it" claim in the comment above. Raised by 2 of 8 reviewers (gpt-5.6-sol-max adversarial, kimi-k3-max edge-case).
| // mutref-3 s3: the doc is bound again, so anything parked for it during | ||
| // the outage goes back out under its original op_id. `reconnected` only | ||
| // resubscribes; this ack is the first moment a send can succeed. | ||
| const subscribed = bridge.subscribedWorkflowId |
There was a problem hiding this comment.
🟡 Medium — Replay has no attempt or age cap: OutboxEntry carries no counter and every doc_subscribed ok re-requeues the whole parked set, so a batch the host never results on settles unacknowledged, is parked again by verdictOf(), and is resent forever — each cycle occupying the single in-flight FIFO slot for up to 20 s ahead of live human edits, which turns a flapping socket or one poison op into permanent head-of-line blocking. Bound the replays per entry, and consider retiring entries from DocUpdate.opIds (the seam pendingOpLedger.clearOnEffect already uses) so ops whose effect landed but whose result frame was lost stop being resent at all. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial).
| // with their ORIGINAL op_ids once this tab is subscribed again (KA-6: the | ||
| // applier's `__applied` ledger dedupes the id, so a replay can never apply | ||
| // twice). Memory-backed for now; a page-lifetime store is s4. | ||
| const outbox = createHumanOpOutbox({ |
There was a problem hiding this comment.
🟡 Medium — The outbox has no size cap, TTL, or eviction: settle() keeps host-rejected entries forever, drop() explicitly preserves them, and parked entries for a workflow the tab never revisits are never reclaimed. The cost lands on the hot path — record() does a linear indexOf() per minted op and onBatchSettled → recordedWorkflowOf() copies the entire entry array on every settle — so a stream of rejected or multi-megabyte add_node payloads both leaks memory and makes every subsequent edit slower, and a large accumulated backlog replays as one burst that can exceed transport message limits. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial).
| // the outage goes back out under its original op_id. `reconnected` only | ||
| // resubscribes; this ack is the first moment a send can succeed. | ||
| const subscribed = bridge.subscribedWorkflowId | ||
| if (subscribed !== null) { |
There was a problem hiding this comment.
🟡 Medium — Replayed ops keep their mint-time envelope verbatim, including stamp: [base_version, actor], so after an outage of any length the replay loses LWW ordering against everything written meanwhile and is silently discarded by the applier. Because OpsResultView is a binary applied/skipped split, that op comes back as applied and verdictOf() retires it from the outbox — the edit is reported delivered while it never took effect. Reusing op_id is required for dedupe, but the stale stamp needs an explicit decision (re-stamp on replay, or surface the loss) rather than being retired as success. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| // twice). Memory-backed for now; a page-lifetime store is s4. | ||
| const outbox = createHumanOpOutbox({ | ||
| store: createMemoryOutboxStore(), | ||
| key: `agent-human-op-outbox:${tabId}` |
There was a problem hiding this comment.
🟢 Low — tabId is a fresh createUuidv4() minted per startAgentCrdtFollower run, and the productGate.enabled watcher re-invokes that function on every agent-panel toggle — a path this test file already exercises — so a toggle silently discards every parked op. The random per-mount key also makes humanOpOutbox's documented queued→parked rehydrate path unreachable and would orphan each mount's entries under a dead key once the page-lifetime store (s4) lands; use a stable per-tab identity or a single well-known key. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| clientState.transportUp = true | ||
| apiState.target.dispatchEvent(new Event('reconnected')) | ||
| expect(bridge().resubscribe).toHaveBeenCalledTimes(1) | ||
| expect(clientState.sent).toHaveLength(0) |
There was a problem hiding this comment.
🟢 Low — This assertion (and its "nothing may go out until the host acks" comment) passes only because FakeBridge.resubscribe is a bare vi.fn() that leaves subscribedWorkflowId null; the real bridge re-sets sentWorkflowId synchronously in reconcile(), so in production ops minted in that window do go out — the test enshrines fake-only behaviour and hides the ordering window flagged above. The lineage test below has the same problem: it exercises the single configuration where the drop guard fires (reset received while subscribed and target-active), so the suite certifies an FC-5 guarantee the code does not actually provide. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial).
|
Closing as superseded by #18700 (the merged graph-first CRDT follower). This persistent-outbox stack conflicts with the accepted best-effort operation-delivery policy retained there. |
Parked human ops survive the transport retry budget. Replayed under the original op_id on resubscribe. Dropped on doc reset.
Full context for agent readers
Slice 3 of the mutref-3 outbox stack. Stacked on PR 18519 (slice 2: sender-to-outbox wiring adapters), which sits on PR 18510 (slice 1: the outbox itself). Merge those first; this PR's diff against its base is only the follower wiring.
What changes
useAgentCrdtFollower.tsnow owns oneHumanOpOutbox(memory-backed for this slice) and threads it through the op sender:onBatchMintedrecords every minted human op in the outbox.onBatchSettledapplies the sender's terminal outcome to the outbox: acknowledged-and-applied removes the entry, a rejected op is marked rejected, andundeliverable(the transport never carried it within the 5-retry budget) orunconfirmed(no result inside the 10 s window) parks it.doc_subscribedok afterreconnected, the follower callsreplayParkedOpsfor the subscribed workflow: parked entries go back to the sender viareadmit+flush, keeping their originalop_id. A new dev-panel eventhuman_ops_replayedrecords the count.doc_reset, aftersender.abortAll(), the follower callsoutbox.drop(workflowId)so nothing parked against the old lineage is replayed into the successor doc.Why this is safe
The multi-player applier dedupes replayed ops by
op_idthrough its applied ledger, the op_id dedupe invariant (KA-6), so a replay of an op that did land cannot apply twice. Parked entries are keyed by the workflow they were recorded against and are only ever readmitted toward that workflow, the same-workflow addressing invariant (FC-5). If the sender is no longer bound to that workflow at replay time it settles the replayundeliverableagain, which re-parks the same entries; replay is idempotent to attempt.Flow
Tests
Two new cases in
crossWorkflowPending.test.ts:retains an op beyond the retry budget and resends the original op_id after reconnected: six refused attempts settleundeliverable;reconnectedalone sends nothing; the subscribe ack resends exactly one batch whoseop_idequals the first attempt's; after the host applies it, a second reconnect sends nothing more.drops parked ops when the doc lineage breaks instead of replaying them into the successor: park, thendoc_reset, then reconnect and ack: nothing is sent and no replay event is recorded.The first case is the follower-level version of the first
it.failscharacterization in PR 17591 ("retain beyond budget and resend the original op_id after reconnected"). The FakeBridge'sresubscribeis avi.fn, so the tests play the host's part with anackResubscribehelper that marks the workflow subscribed and forwards thedoc_subscribedok frame.Ran locally: the single test file (7 passed),
oxfmt, andeslinton the three touched files.Not in this slice
OutboxStore(sessionStorage) and remount rehydration: slice 4.opSender.tsor the retry constants.Glossary
HumanOpOutboxfrom slice 1; a per-tab record of minted human ops and their fate (queued, parked, rejected).undeliverableorunconfirmed; eligible for replay.doc_ops_resultarrived within 10 s.op_idviareadmit+flush.op_id, so re-sending an op is safe.doc_resetframe; the doc identified by a workflow id is replaced by a new one, so pre-reset ops must not apply to it.