Skip to content

[backport cloud/1.54] fix(touch): stop a lost touchend from permanently freezing the canvas - #18527

Merged
comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-17916-to-cloud-1.54
Sep 23, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-17916-to-cloud-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #17916 to cloud/1.54

Automatically created by backport workflow.

…#17916)

## Summary

Prevents stale touch gesture state from blocking every later canvas
press after a `touchend` is lost.

## Changes

- On a primary touch `pointerdown`, clear stale `touchCount` and
`touchZooming` state before the existing input guard runs.
- Restrict that recovery to touch pointers. Mouse and pen pointers can
be primary while fingers remain active, so they must not clear a live
touch gesture.
- Add four focused tests covering recovery, a live second finger, and
concurrent mouse and pen input.

## Why this boundary is safe

For touch input, Pointer Events marks a `pointerdown` as primary only
when no other touch pointer is active. Any touch state left when that
new sequence starts belongs to an older gesture whose end was missed.

A second finger is non-primary and remains blocked by the existing
guard. Mouse and pen input does not trigger recovery.

## Verification

- `vitest run src/extensions/core/simpleTouchSupport.test.ts`: 4 tests
passed.
- Browser testing with CDP touch input covered detached targets, stopped
propagation, cancel/end imbalance, repeated leaked gestures, and the
live second-finger guard. The stale-state cases failed on `main` and
recovered with this patch.
- No real iOS device verification was available.

## Scope

This is a containment fix. It does not repair the legacy mixed Touch
Events and Pointer Events state model or address the separate reload
symptom from FE-2435.

The retained touch risks and rewrite acceptance criteria are tracked in
[FE-2446](https://linear.app/comfyorg/issue/FE-2446/retained-risks-in-simpletouchsupport-after-the-fe-2435-containment-fix).
The broader pointer gesture work is tracked in
[FE-2040](https://linear.app/comfyorg/issue/FE-2040/overhaul-nodegroup-selection-and-pointer-gesture-handling-single).

Addresses the freeze path in FE-2435.

---------

Co-authored-by: glary-bot <bot@comfy.org>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 23, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 23, 2026 04:05
@vercel

vercel Bot commented Sep 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 4:05am UTC

Request Review

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 04:12:39 AM UTC

Links

🎭 Playwright: ✅ 1933 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1912 / ❌ 0 / ⚠️ 2 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.6 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 156ms TBT · 81.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.4 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.9 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 82ms TBT · 167.6 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 489ms TBT · 169.9 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 559ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.1 MB
canvas-idle: DOM nodes -279
canvas-idle: event listeners -179
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 34ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 997ms
canvas-mouse-sweep: script duration 175ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 71.7 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -180
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 361ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.7 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 455ms
dom-widget-clipping: script duration 163ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.1 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 657ms
large-graph-idle: script duration 38ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.0 MB
large-graph-idle: DOM nodes -272
large-graph-idle: event listeners -162
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1634ms
large-graph-pan: script duration 838ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 80.2 MB
large-graph-pan: DOM nodes -122
large-graph-pan: event listeners -93
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1767ms
large-graph-zoom: script duration 799ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 67.9 MB
large-graph-zoom: DOM nodes -276
large-graph-zoom: event listeners -193
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1949ms
legacy-node-drag: script duration 981ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 87.8 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 606ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.6 MB
minimap-idle: DOM nodes -278
minimap-idle: event listeners -177
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 420ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 80.4 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 523ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.9 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 30ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 861ms
subgraph-mouse-sweep: script duration 119ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 76.7 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -212
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 17ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1016ms
subgraph-transition-enter: script duration 34ms
subgraph-transition-enter: TBT 156ms
subgraph-transition-enter: heap used 81.8 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5829ms
viewport-pan-sweep: script duration 2729ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 77.4 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16806ms
vue-large-graph-idle: script duration 291ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.9 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14931
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 175
vue-large-graph-pan: task duration 21356ms
vue-large-graph-pan: script duration 935ms
vue-large-graph-pan: TBT 82ms
vue-large-graph-pan: heap used 167.6 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14930
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 90ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6395ms
vue-node-resize-workload: script duration 135ms
vue-node-resize-workload: TBT 489ms
vue-node-resize-workload: heap used 169.9 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14926
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8678ms
vue-zoom-out-idle: script duration 140ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 3
workflow-execution: style recalc count 6
workflow-execution: task duration 77ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.1 MB
workflow-execution: DOM nodes 126
workflow-execution: event listeners 17
Raw data
{
  "timestamp": "2026-09-23T04:19:29.926Z",
  "gitSha": "6fd6901b9aab85e6fcf12878fa396bef1d6351fb",
  "branch": "backport-17916-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2038.2089999999948,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.232000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 554.6059999999999,
      "heapDeltaBytes": -2426452,
      "heapUsedBytes": 67120036,
      "domNodes": -278,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 10.91,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2035.6559999999604,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.367999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 562.747,
      "heapDeltaBytes": 1465876,
      "heapUsedBytes": 71584856,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.777999999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2121.5009999999666,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 36.416000000000004,
      "layouts": 14,
      "layoutDurationMs": 6.6339999999999995,
      "taskDurationMs": 1054.953,
      "heapDeltaBytes": -4853648,
      "heapUsedBytes": 66032172,
      "domNodes": -281,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 184.647,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1895.6979999999817,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 32.17,
      "layouts": 14,
      "layoutDurationMs": 4.231,
      "taskDurationMs": 938.687,
      "heapDeltaBytes": 13538856,
      "heapUsedBytes": 84316744,
      "domNodes": -279,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 166.264,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1665.4139999999984,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 14.133,
      "layouts": 6,
      "layoutDurationMs": 0.9730000000000001,
      "taskDurationMs": 357.49600000000004,
      "heapDeltaBytes": 4390004,
      "heapUsedBytes": 74007992,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.117999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1755.6660000000193,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 16.801,
      "layouts": 6,
      "layoutDurationMs": 1.267,
      "taskDurationMs": 364.78999999999996,
      "heapDeltaBytes": 4418508,
      "heapUsedBytes": 74306236,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 10.384999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 673.294999999996,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.476999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 454.4940000000001,
      "heapDeltaBytes": 18074684,
      "heapUsedBytes": 88138260,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 163.802,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 659.6989999999892,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.275000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.288,
      "heapDeltaBytes": -8002132,
      "heapUsedBytes": 63070904,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 161.618,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2082.9909999999927,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 8.62,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 687.294,
      "heapDeltaBytes": 8514340,
      "heapUsedBytes": 85023748,
      "domNodes": -272,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 39.446,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2075.317000000041,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 7.112,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 627.475,
      "heapDeltaBytes": 10928080,
      "heapUsedBytes": 86854804,
      "domNodes": -271,
      "jsHeapTotalBytes": -2465792,
      "scriptDurationMs": 36.05500000000001,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2252.320999999995,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.665000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1589.5960000000002,
      "heapDeltaBytes": 21541688,
      "heapUsedBytes": 88450044,
      "domNodes": 2,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 822.218,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2290.634999999952,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.456,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1677.982,
      "heapDeltaBytes": 2300032,
      "heapUsedBytes": 79702996,
      "domNodes": -246,
      "jsHeapTotalBytes": 643072,
      "scriptDurationMs": 853.53,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3617.4759999999537,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 10.327,
      "layouts": 60,
      "layoutDurationMs": 11.963999999999999,
      "taskDurationMs": 1782.2559999999999,
      "heapDeltaBytes": -7192992,
      "heapUsedBytes": 71615992,
      "domNodes": -262,
      "jsHeapTotalBytes": -892928,
      "scriptDurationMs": 803.111,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3586.593999999991,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 12.185999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.263,
      "taskDurationMs": 1751.874,
      "heapDeltaBytes": -7628956,
      "heapUsedBytes": 70818308,
      "domNodes": -289,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 795.544,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3147.328000000016,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.969000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1937.1689999999999,
      "heapDeltaBytes": 22120600,
      "heapUsedBytes": 90378472,
      "domNodes": 0,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 979.814,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3153.7040000000616,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.413999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1960.2799999999997,
      "heapDeltaBytes": 25261808,
      "heapUsedBytes": 93679504,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 981.825,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2037.5290000000064,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 591.629,
      "heapDeltaBytes": 10686532,
      "heapUsedBytes": 88102724,
      "domNodes": -274,
      "jsHeapTotalBytes": -2727936,
      "scriptDurationMs": 33.457999999999984,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2061.8519999999307,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.221000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 620.226,
      "heapDeltaBytes": 5789280,
      "heapUsedBytes": 82969260,
      "domNodes": -282,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 32.809999999999995,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 607.9200000000355,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.196000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 412.23300000000006,
      "heapDeltaBytes": 15057184,
      "heapUsedBytes": 87991068,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 142.835,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 594.857999999931,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.048000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 428.07699999999994,
      "heapDeltaBytes": 14656512,
      "heapUsedBytes": 80720740,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 148.033,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2040.1360000000182,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.837000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 553.8179999999999,
      "heapDeltaBytes": -1687916,
      "heapUsedBytes": 71309864,
      "domNodes": -294,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.108999999999998,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.0910000000172,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.772,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.54300000000006,
      "heapDeltaBytes": -14408912,
      "heapUsedBytes": 58600572,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.8599999999999985,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1799.4400000000041,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 34.355,
      "layouts": 18,
      "layoutDurationMs": 5.802,
      "taskDurationMs": 905.944,
      "heapDeltaBytes": 7882688,
      "heapUsedBytes": 80813904,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 128.57600000000002,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.6970000000529,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.305,
      "layouts": 18,
      "layoutDurationMs": 4.965000000000001,
      "taskDurationMs": 815.564,
      "heapDeltaBytes": 7219372,
      "heapUsedBytes": 80125768,
      "domNodes": -296,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 109.69699999999999,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1418.7729999999874,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 34.496,
      "layouts": 14,
      "layoutDurationMs": 16.528,
      "taskDurationMs": 1015.8610000000001,
      "heapDeltaBytes": -9218508,
      "heapUsedBytes": 85757496,
      "domNodes": 13751,
      "jsHeapTotalBytes": 13369344,
      "scriptDurationMs": 34.413999999999994,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 156,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8396.996000000001,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.721999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5860.594,
      "heapDeltaBytes": 9313208,
      "heapUsedBytes": 85581984,
      "domNodes": -267,
      "jsHeapTotalBytes": -667648,
      "scriptDurationMs": 2736.2039999999997,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8333.231000000069,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 37.63,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5797.866,
      "heapDeltaBytes": 314092,
      "heapUsedBytes": 76772260,
      "domNodes": -271,
      "jsHeapTotalBytes": -1191936,
      "scriptDurationMs": 2720.847,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17390.932000000023,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16720.069000000003,
      "heapDeltaBytes": -38715516,
      "heapUsedBytes": 178370304,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9449472,
      "scriptDurationMs": 300.63,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17638.79599999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16891.300000000003,
      "heapDeltaBytes": -61131460,
      "heapUsedBytes": 178012280,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16474112,
      "scriptDurationMs": 281.634,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21971.12099999998,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 19.69700000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21640.632,
      "heapDeltaBytes": -35378672,
      "heapUsedBytes": 182697012,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12115968,
      "scriptDurationMs": 957.2859999999998,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 144,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21477.493999999977,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 17.83399999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21070.534,
      "heapDeltaBytes": -63190528,
      "heapUsedBytes": 168886744,
      "domNodes": -8068,
      "jsHeapTotalBytes": -21786624,
      "scriptDurationMs": 911.8250000000002,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 20,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6693.677000000036,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 96.07,
      "layouts": 20,
      "layoutDurationMs": 24.902000000000008,
      "taskDurationMs": 6588.806,
      "heapDeltaBytes": -50806752,
      "heapUsedBytes": 174140080,
      "domNodes": -8068,
      "jsHeapTotalBytes": 3059712,
      "scriptDurationMs": 153.04399999999998,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 493,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6296.330000000012,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 83.15800000000002,
      "layouts": 20,
      "layoutDurationMs": 24.271999999999988,
      "taskDurationMs": 6201.231,
      "heapDeltaBytes": -36219024,
      "heapUsedBytes": 182115900,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12812288,
      "scriptDurationMs": 116.17299999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 485,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9280.85500000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8993.374000000002,
      "heapDeltaBytes": 8226260,
      "heapUsedBytes": 179011756,
      "domNodes": 0,
      "jsHeapTotalBytes": -7602176,
      "scriptDurationMs": 150.16799999999998,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8631.26299999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8363.369999999999,
      "heapDeltaBytes": 3663520,
      "heapUsedBytes": 178602476,
      "domNodes": 0,
      "jsHeapTotalBytes": -16252928,
      "scriptDurationMs": 129.02199999999996,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 100.92200000002549,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 13.474,
      "layouts": 3,
      "layoutDurationMs": 1.74,
      "taskDurationMs": 76.214,
      "heapDeltaBytes": 3054684,
      "heapUsedBytes": 70955060,
      "domNodes": 125,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.7379999999999995,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 102.43899999989026,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 15.232,
      "layouts": 2,
      "layoutDurationMs": 1.4359999999999997,
      "taskDurationMs": 77.91499999999999,
      "heapDeltaBytes": 2984300,
      "heapUsedBytes": 71928396,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.283000000000002,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18527   +/-   ##
=============================================
  Coverage              ?   78.67%           
=============================================
  Files                 ?     2009           
  Lines                 ?   111114           
  Branches              ?    31423           
=============================================
  Hits                  ?    87420           
  Misses                ?    23515           
  Partials              ?      179           
Flag Coverage Δ
unit 78.67% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/extensions/core/simpleTouchSupport.ts 77.66% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 049b1f8 into cloud/1.54 Sep 23, 2026
100 of 103 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-17916-to-cloud-1.54 branch September 23, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants