Repository navigation
[backport core/1.53] fix: tolerate non-cloneable extension fields when serializing nodes - #18517
Conversation
…18252) Fixes #18165. Fixes [FRONTEND-51](https://comfy-org.sentry.io/issues/?query=FRONTEND-51) (`DataCloneError` in `copyExtensionFields`, ~750 events). - `copyExtensionFields` called `structuredClone` on extension-owned node fields; a Proxy over plain JSON passes `isJsonValue` but `structuredClone` throws, so dropping a generated image onto the canvas to load its workflow crashed serialization. - New `safeCloneExtensionValue`: try `structuredClone`, on `DataCloneError` fall back to `JSON.parse(JSON.stringify(v))`, and if both fail warn once and keep the original reference. - `isJsonValue` is now checked on the cloned value; three regression tests added. Linear: [FE-2551](https://linear.app/comfyorg/issue/FE-2551). Needs backport to `core/1.53`. **Why no Playwright regression test.** The failure needs a Proxy-wrapped object sitting in an extension-owned node field at serialize time. In production that object comes from third-party custom nodes (or Vue reactivity leaking through an extension), none of which exist in the `browser_tests/` fixture set; a browser test would have to install a synthetic extension or inject a Proxy through `page.evaluate`, which tests the harness rather than the app. `extensionPersistence.ts` is a pure module with no DOM dependency, so the regression is pinned at the unit level instead: two of the three new tests in `extensionPersistence.test.ts` fail on `main` with `DataCloneError` and pass here. <details><summary>Full context for agent readers</summary> **Root cause.** `src/lib/litegraph/src/extensionPersistence.ts` persists extension-added fields on nodes by `structuredClone`-ing them during `serialize()`. Extensions (and Vue reactivity in some load paths) hand us Proxy-wrapped objects. `isJsonValue` inspects the proxy's visible shape and returns true, but the structured clone algorithm rejects Proxy exotic objects with `DataCloneError`. Reproduced by the GH issue 18165 path: drag a generated PNG onto the canvas, workflow load triggers a serialize pass over nodes carrying proxied extension data. **Change.** `safeCloneExtensionValue(v)` in `extensionPersistence.ts` (lines ~21-40, used at ~148-168): 1. `structuredClone(v)` — normal case. 2. On `DataCloneError`: `JSON.parse(JSON.stringify(v))` — strips functions/symbols, unwraps proxies. 3. If that also throws: `console.warn` once per key and return `v` unchanged (no crash, no data loss). `isJsonValue` is applied to the cloned result rather than the raw input. **Behavior change to be aware of.** Previously a field holding a function anywhere was dropped entirely. Now it is kept with the function keys stripped (JSON round-trip). This is intentional: losing user-visible extension state because one nested key is a callback was the worse outcome. Flag if you disagree and I will revert to drop-on-function. **Tests.** `extensionPersistence.test.ts` lines ~94-160, three new cases: - Proxy over plain JSON is persisted (regression for this bug) — fails on `main` with `DataCloneError`. - Proxy whose target includes a function keeps the plain data — fails on `main`. - Plain object is still deep-cloned (no reference sharing) — guards the fallback path. 7/7 pass on this branch. Confirmed the two Proxy tests fail on `origin/main` by swapping the test file. **Existing-PR check.** No open or recently closed PR references DataCloneError, structuredClone, copyExtensionFields, the linked Sentry issue, or issue 18165; issue timeline has zero cross-referenced PRs. **Signal provenance.** Found by the core-1.53 post-release signal sweep on 2026-09-20 (regression cluster "DataCloneError on workflow load"). Triage: `signals/triage/sig-20260920-run17-post153-core.md` in the ecs-migration workspace. </details> --------- Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit 8ff5db2)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎭 Playwright: ✅ 1910 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T03:46:47.626Z",
"gitSha": "e60ed146439302bdbc9775b4dbeb0e9337838328",
"branch": "backport-18252-to-core-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2084.424999999982,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.302000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.0350000000001,
"heapDeltaBytes": -7162180,
"heapUsedBytes": 61910632,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.68,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2070.368999999914,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.424999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.169,
"heapDeltaBytes": -11294856,
"heapUsedBytes": 59443864,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.683999999999997,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1876.1149999999702,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.236,
"layouts": 14,
"layoutDurationMs": 4.405,
"taskDurationMs": 861.0939999999999,
"heapDeltaBytes": -10318320,
"heapUsedBytes": 60506332,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 155.231,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1806.9080000000213,
"styleRecalcs": 73,
"styleRecalcDurationMs": 35.090999999999994,
"layouts": 14,
"layoutDurationMs": 4.267,
"taskDurationMs": 859.734,
"heapDeltaBytes": -8622272,
"heapUsedBytes": 61822252,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 154.79700000000003,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.5790000000393,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.840000000000003,
"layouts": 6,
"layoutDurationMs": 1.343,
"taskDurationMs": 416.66700000000003,
"heapDeltaBytes": 4438492,
"heapUsedBytes": 75089316,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.847999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1687.1369999998933,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.227,
"layouts": 6,
"layoutDurationMs": 1.234,
"taskDurationMs": 349.107,
"heapDeltaBytes": 4434448,
"heapUsedBytes": 75245468,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.614,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 671.9160000000102,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.607000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.39900000000006,
"heapDeltaBytes": 18679088,
"heapUsedBytes": 88811812,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 156.95700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 657.1559999999863,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.300999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.3710000000001,
"heapDeltaBytes": 17865516,
"heapUsedBytes": 88208332,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 159.729,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.37000000001,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.274000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.8879999999999,
"heapDeltaBytes": -14160652,
"heapUsedBytes": 86534208,
"domNodes": -268,
"jsHeapTotalBytes": -569344,
"scriptDurationMs": 31.696,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2013.983000000053,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.037000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.6410000000001,
"heapDeltaBytes": 22174892,
"heapUsedBytes": 87203616,
"domNodes": -269,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.115,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2248.3100000000036,
"styleRecalcs": 63,
"styleRecalcDurationMs": 7.9700000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1599.231,
"heapDeltaBytes": 21491852,
"heapUsedBytes": 87919804,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 810.5960000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2198.6329999999725,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.466000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1609.7050000000004,
"heapDeltaBytes": 17699848,
"heapUsedBytes": 83916828,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 799.9159999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3613.065000000006,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.734,
"layouts": 60,
"layoutDurationMs": 12.197000000000001,
"taskDurationMs": 1739.7659999999998,
"heapDeltaBytes": 8466056,
"heapUsedBytes": 76159148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 790.786,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3479.385000000093,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.166000000000004,
"layouts": 60,
"layoutDurationMs": 11.47,
"taskDurationMs": 1656.231,
"heapDeltaBytes": 8466492,
"heapUsedBytes": 75873160,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 751.14,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3082.197000000008,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.7890000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1903.028,
"heapDeltaBytes": 22236176,
"heapUsedBytes": 89365944,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 956.0930000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3121.8289999999342,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.572000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1953.6000000000001,
"heapDeltaBytes": 22067452,
"heapUsedBytes": 89182176,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 973.7399999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2051.337999999987,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.193,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 689.4929999999999,
"heapDeltaBytes": 10375416,
"heapUsedBytes": 87191168,
"domNodes": -271,
"jsHeapTotalBytes": -1916928,
"scriptDurationMs": 39.776,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.6530000000294,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.355000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.2090000000001,
"heapDeltaBytes": -15297696,
"heapUsedBytes": 87251768,
"domNodes": -272,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 31.069,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.9819999999982,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.716000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.73900000000003,
"heapDeltaBytes": 14914128,
"heapUsedBytes": 87696360,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.585,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.4039999999222,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.956000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.13800000000003,
"heapDeltaBytes": 14867264,
"heapUsedBytes": 87404056,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 147.565,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2003.5030000000233,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.950999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.13400000000007,
"heapDeltaBytes": -7496148,
"heapUsedBytes": 65119648,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.946000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2014.6919999999682,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.867999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.071,
"heapDeltaBytes": -505260,
"heapUsedBytes": 71927556,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.103999999999997,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.3409999999858,
"styleRecalcs": 77,
"styleRecalcDurationMs": 33.522,
"layouts": 18,
"layoutDurationMs": 4.545000000000001,
"taskDurationMs": 783.015,
"heapDeltaBytes": -12636044,
"heapUsedBytes": 59691892,
"domNodes": -297,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 103.438,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.93700000003,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.058,
"layouts": 18,
"layoutDurationMs": 4.718,
"taskDurationMs": 795.26,
"heapDeltaBytes": -12604308,
"heapUsedBytes": 60043296,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 104.407,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.7560000000913,
"styleRecalcs": 20,
"styleRecalcDurationMs": 31.912999999999997,
"layouts": 16,
"layoutDurationMs": 15.798,
"taskDurationMs": 947.082,
"heapDeltaBytes": -7340880,
"heapUsedBytes": 87110636,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.758999999999997,
"eventListeners": 2381,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8652.27699999997,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.388000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5876.704,
"heapDeltaBytes": 8882604,
"heapUsedBytes": 84842388,
"domNodes": -271,
"jsHeapTotalBytes": -1167360,
"scriptDurationMs": 2663.3559999999998,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8317.968000000064,
"styleRecalcs": 247,
"styleRecalcDurationMs": 32.259,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5834.136,
"heapDeltaBytes": -7805408,
"heapUsedBytes": 92811036,
"domNodes": -271,
"jsHeapTotalBytes": 1490944,
"scriptDurationMs": 2765.321,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16916.75499999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16465.614999999998,
"heapDeltaBytes": -32877460,
"heapUsedBytes": 175681856,
"domNodes": -6548,
"jsHeapTotalBytes": -5115904,
"scriptDurationMs": 277.861,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16727.141999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16019.922999999999,
"heapDeltaBytes": -26924500,
"heapUsedBytes": 176164840,
"domNodes": -6549,
"jsHeapTotalBytes": -4206592,
"scriptDurationMs": 252.27900000000002,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20301.046000000042,
"styleRecalcs": 168,
"styleRecalcDurationMs": 17.137999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19937.347,
"heapDeltaBytes": -29558196,
"heapUsedBytes": 176233612,
"domNodes": -6548,
"jsHeapTotalBytes": -884736,
"scriptDurationMs": 908.625,
"eventListeners": -7471,
"totalBlockingTimeMs": 40,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20194.09399999995,
"styleRecalcs": 169,
"styleRecalcDurationMs": 16.562000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19889.91,
"heapDeltaBytes": -38643384,
"heapUsedBytes": 166431808,
"domNodes": -6548,
"jsHeapTotalBytes": 1789952,
"scriptDurationMs": 905.497,
"eventListeners": -7469,
"totalBlockingTimeMs": 43,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6178.585999999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.84299999999999,
"layouts": 20,
"layoutDurationMs": 22.589,
"taskDurationMs": 6096.213999999999,
"heapDeltaBytes": -21038068,
"heapUsedBytes": 181483472,
"domNodes": -6548,
"jsHeapTotalBytes": 19656704,
"scriptDurationMs": 117.78,
"eventListeners": -7469,
"totalBlockingTimeMs": 403,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5993.020999999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.97900000000003,
"layouts": 20,
"layoutDurationMs": 22.825000000000014,
"taskDurationMs": 5894.32,
"heapDeltaBytes": -25171816,
"heapUsedBytes": 179061400,
"domNodes": -6548,
"jsHeapTotalBytes": 16502784,
"scriptDurationMs": 113.87999999999998,
"eventListeners": -7473,
"totalBlockingTimeMs": 401,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 94.96899999999187,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.493,
"layouts": 2,
"layoutDurationMs": 1.303,
"taskDurationMs": 74.004,
"heapDeltaBytes": 3207144,
"heapUsedBytes": 72013088,
"domNodes": 130,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.327000000000002,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 456.52499999994234,
"styleRecalcs": 12,
"styleRecalcDurationMs": 18.026,
"layouts": 3,
"layoutDurationMs": 0.917,
"taskDurationMs": 106.025,
"heapDeltaBytes": 5053592,
"heapUsedBytes": 73529336,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.704,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.53 #18517 +/- ##
=============================================
+ Coverage 83.29% 83.40% +0.10%
=============================================
Files 2036 2034 -2
Lines 117790 117917 +127
Branches 32698 32717 +19
=============================================
+ Hits 98116 98348 +232
+ Misses 19320 19215 -105
Partials 354 354
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 74 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #18252 to
core/1.53. Node serialization no longer throwsDataCloneErrorwhen a custom-node extension stores a non-cloneable value (function, DOM node, throwing getter) in its extension payload; the offending entry is skipped per entry instead of aborting the whole copy/paste or save. Fixes the copy/paste and save failures on 1.53.x tracked in Linear as FE-2552.Full context for agent readers
git cherry-pick -x;src/lib/litegraph/src/extensionPersistence.tsis byte-identical to main after the pick. The only difference from the main PR is that the 1.53 copy ofextensionPersistence.test.tskeeps its pre-existing PiniabeforeEachsetup.core/1.53(it only attempted and failed oncore/1.54andcloud/1.54, reported as possible stacking conflicts with the open 1.54 backport queue; those are left for the bot once that queue drains).