Repository navigation
test: migrate workbench platform mocks - #18501
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2117 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1a6456b4a6ae3372779407f1e963e0092389c97d
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.97 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.87 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.92 MB (baseline 3.92 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 577 kB (baseline 577 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 302 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T02:50:43.191Z",
"gitSha": "09e02ca2b8915fe4a257b4806ec7e6b9b3c5e8f8",
"branch": "test/automock-07-workbench-platform",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.48699999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.641999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.68199999999996,
"heapDeltaBytes": -3331996,
"heapUsedBytes": 64299544,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.040000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1991.4220000000569,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.245000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.90500000000003,
"heapDeltaBytes": 11725732,
"heapUsedBytes": 79252192,
"domNodes": -258,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.107999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.8259999999796,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.291000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 794.674,
"heapDeltaBytes": -1062608,
"heapUsedBytes": 61272124,
"domNodes": -258,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 162.09,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1739.1200000000708,
"styleRecalcs": 47,
"styleRecalcDurationMs": 16.953,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 730.515,
"heapDeltaBytes": 11092360,
"heapUsedBytes": 78483340,
"domNodes": -259,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 166.907,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.7819999999883,
"styleRecalcs": 29,
"styleRecalcDurationMs": 13.144,
"layouts": 6,
"layoutDurationMs": 1.095,
"taskDurationMs": 316.376,
"heapDeltaBytes": 3126392,
"heapUsedBytes": 70964232,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.964,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.8099999999677,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.616,
"layouts": 6,
"layoutDurationMs": 1.1750000000000003,
"taskDurationMs": 370.104,
"heapDeltaBytes": 2801280,
"heapUsedBytes": 70246980,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.666999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 613.5730000000308,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.145,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.043,
"heapDeltaBytes": 18612792,
"heapUsedBytes": 85971584,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 170.55,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 649.2410000000746,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.888000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.97800000000007,
"heapDeltaBytes": 18917228,
"heapUsedBytes": 86484088,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 170.627,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1173.2250000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 824.1820000000001,
"heapDeltaBytes": 11272192,
"heapUsedBytes": 88928524,
"domNodes": 0,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 69.50399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 554,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1184.6320000000787,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 859.691,
"heapDeltaBytes": 34652368,
"heapUsedBytes": 102411724,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 74.042,
"eventListeners": 0,
"totalBlockingTimeMs": 571,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.2310000000457,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.87400000000014,
"heapDeltaBytes": 14770468,
"heapUsedBytes": 90478424,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.02499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.9540000000061,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.71100000000035,
"heapDeltaBytes": 14762616,
"heapUsedBytes": 90971744,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.68099999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 238,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10058.252999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9129.313,
"heapDeltaBytes": -9297368,
"heapUsedBytes": 72617748,
"domNodes": -18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7755.319,
"eventListeners": 0,
"totalBlockingTimeMs": 1216,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10859.555999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9845.051,
"heapDeltaBytes": -9930920,
"heapUsedBytes": 72768876,
"domNodes": -16,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8391.151,
"eventListeners": 0,
"totalBlockingTimeMs": 1437,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50.00000000000182
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11045.490000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10194.096,
"heapDeltaBytes": 9180452,
"heapUsedBytes": 84958360,
"domNodes": -8,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 8514.455,
"eventListeners": 0,
"totalBlockingTimeMs": 1249,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10836.825999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9976.307999999999,
"heapDeltaBytes": 13125152,
"heapUsedBytes": 94910284,
"domNodes": -10,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8282.696,
"eventListeners": 0,
"totalBlockingTimeMs": 1128,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2028.487000000041,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.123,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.82,
"heapDeltaBytes": -3315420,
"heapUsedBytes": 83452860,
"domNodes": -240,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 28.567000000000007,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2043.5189999999466,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.370999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.2339999999999,
"heapDeltaBytes": 1648684,
"heapUsedBytes": 82690944,
"domNodes": -245,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 44.843999999999994,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2328.5750000000007,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.240999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1638.167,
"heapDeltaBytes": -7276588,
"heapUsedBytes": 80312380,
"domNodes": -244,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 861.629,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2286.658000000102,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.902,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1523.988,
"heapDeltaBytes": -11826496,
"heapUsedBytes": 76101060,
"domNodes": -248,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 870.344,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3530.9310000000096,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.180999999999997,
"layouts": 60,
"layoutDurationMs": 13.055000000000001,
"taskDurationMs": 1684.7979999999998,
"heapDeltaBytes": 7855760,
"heapUsedBytes": 74269804,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 786.705,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3640.390000000025,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.181000000000001,
"layouts": 60,
"layoutDurationMs": 14.001000000000001,
"taskDurationMs": 1756.1139999999998,
"heapDeltaBytes": 8302072,
"heapUsedBytes": 74125020,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 821.4670000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3133.640000000014,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.3999999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1929.54,
"heapDeltaBytes": 1107104,
"heapUsedBytes": 67226824,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 997.776,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3167.0539999998937,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.325,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1982.9769999999999,
"heapDeltaBytes": 1650992,
"heapUsedBytes": 66162112,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1028.263,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2050.8769999999004,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.368000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.6830000000001,
"heapDeltaBytes": -6475268,
"heapUsedBytes": 82588672,
"domNodes": -248,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 31.35,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.059999999935,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.294999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 611.5489999999999,
"heapDeltaBytes": -4162052,
"heapUsedBytes": 84431112,
"domNodes": -244,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 37.01599999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.4870000000287,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.124,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.121,
"heapDeltaBytes": 14045148,
"heapUsedBytes": 83021016,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 145.175,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.1129999999739,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.983999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.764,
"heapDeltaBytes": 13362948,
"heapUsedBytes": 83642816,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 144.346,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.8889999999578,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.602,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.95099999999996,
"heapDeltaBytes": 8900300,
"heapUsedBytes": 77868812,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.602,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.4609999999075,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.597000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.93500000000006,
"heapDeltaBytes": 11295344,
"heapUsedBytes": 81492904,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.462000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.261999999971,
"styleRecalcs": 47,
"styleRecalcDurationMs": 16.046999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 740.2879999999999,
"heapDeltaBytes": 10407344,
"heapUsedBytes": 79278664,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 108.93499999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.885000000033,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.512,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 769.3749999999999,
"heapDeltaBytes": 7107736,
"heapUsedBytes": 76165948,
"domNodes": -276,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 112.52999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.1339999999036,
"styleRecalcs": 16,
"styleRecalcDurationMs": 28.022000000000006,
"layouts": 5,
"layoutDurationMs": 12.917000000000002,
"taskDurationMs": 863.6049999999999,
"heapDeltaBytes": -6207676,
"heapUsedBytes": 84244036,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.469000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 137,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8307.394999999986,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.208000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5769.321000000001,
"heapDeltaBytes": -4926364,
"heapUsedBytes": 76448052,
"domNodes": -242,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2799.982,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8499.111999999968,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.345,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6025.665,
"heapDeltaBytes": -10018476,
"heapUsedBytes": 76491604,
"domNodes": -245,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2913.455,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16797.638000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16101.058000000003,
"heapDeltaBytes": -45269380,
"heapUsedBytes": 177262812,
"domNodes": -8061,
"jsHeapTotalBytes": -18321408,
"scriptDurationMs": 269.21799999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17544.083,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17148.897,
"heapDeltaBytes": -30088936,
"heapUsedBytes": 195317312,
"domNodes": -8061,
"jsHeapTotalBytes": -18358272,
"scriptDurationMs": 304.329,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20718.751999999993,
"styleRecalcs": 172,
"styleRecalcDurationMs": 17.71800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20439.748,
"heapDeltaBytes": -45897912,
"heapUsedBytes": 168832316,
"domNodes": -8062,
"jsHeapTotalBytes": -12914688,
"scriptDurationMs": 904.4420000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 75,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16302.786999999968,
"styleRecalcs": 97,
"styleRecalcDurationMs": 17.486,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16066.347,
"heapDeltaBytes": -48477584,
"heapUsedBytes": 192696256,
"domNodes": -8061,
"jsHeapTotalBytes": -14688256,
"scriptDurationMs": 901.24,
"eventListeners": -14928,
"totalBlockingTimeMs": 18,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6166.123999999968,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.69100000000002,
"layouts": 20,
"layoutDurationMs": 24.225000000000012,
"taskDurationMs": 6067.504000000001,
"heapDeltaBytes": -61466964,
"heapUsedBytes": 179749328,
"domNodes": -8065,
"jsHeapTotalBytes": 8187904,
"scriptDurationMs": 106.81400000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 394,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5052.143000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.83599999999997,
"layouts": 20,
"layoutDurationMs": 26.852,
"taskDurationMs": 4988.410000000001,
"heapDeltaBytes": -44494532,
"heapUsedBytes": 196251612,
"domNodes": -8061,
"jsHeapTotalBytes": 14876672,
"scriptDurationMs": 99.05,
"eventListeners": -14928,
"totalBlockingTimeMs": 251,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8543.222000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8231.298999999999,
"heapDeltaBytes": -25130900,
"heapUsedBytes": 168967396,
"domNodes": 0,
"jsHeapTotalBytes": -26738688,
"scriptDurationMs": 149.27200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8622.397999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8432.167,
"heapDeltaBytes": 30558304,
"heapUsedBytes": 190437528,
"domNodes": 0,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 136.996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 452.0800000000236,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.114,
"layouts": 2,
"layoutDurationMs": 0.49200000000000005,
"taskDurationMs": 107.547,
"heapDeltaBytes": 4861268,
"heapUsedBytes": 70405992,
"domNodes": 122,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.331999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 120.67200000001321,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.098000000000003,
"layouts": 3,
"layoutDurationMs": 1.6820000000000002,
"taskDurationMs": 87.40099999999998,
"heapDeltaBytes": 3032728,
"heapUsedBytes": 68635308,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.530000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (30)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe pull request modernizes test mocks across platform, agent, and manager areas. Tests now use Vitest automatic mocks and configure imported APIs, composables, stores, refs, and services directly. Existing test scenarios and assertions remain covered. ChangesVitest mock modernization
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Other Possibly related PRs
Merge Risk: ⚪ Minimal · up to The migrated test mocks preserve the reviewed test contracts, and no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18501 +/- ##
==========================================
+ Coverage 83.40% 84.37% +0.97%
==========================================
Files 2987 2284 -703
Lines 147801 130536 -17265
Branches 40064 35233 -4831
==========================================
- Hits 123267 110143 -13124
+ Misses 23253 20097 -3156
+ Partials 1281 296 -985
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
## Summary Stacked on Comfy-Org#18501. Remove migration-introduced module-scoped aliases so automocked services are referenced at their lifecycle owner. ## Changes - **What**: Remove 18 module-scoped service/fixture bindings across 14 tests in favor of direct module/composable references or test-local telemetry values. - **What**: Remove 7 redundant `expect(vi.mocked(fn)).toHaveBeenCalled*` wrappers across 3 tests; retain `vi.mocked` only for configuration or typed `.mock` access. ## Review Focus Hoisted functions required by `vi.mock` collection timing and pre-existing lifecycle-owned SUT/store fixtures remain unchanged. The stacked diff contains 15 owned test files and no shared mock changes. Verification: - targeted 15-file union: 564 passed - complete 44-file owned union: 1,004 passed - shuffled 44-file union, seed 707: 1,004 passed - real mock-owner suites: 305 passed, 1 skipped - typecheck, lint, format, Knip, Fallow, diff and ownership checks passed --------- Co-authored-by: Amp <amp@ampcode.com>
Summary
Migrate compatible workbench and platform test factories to shared manual mocks while preserving test-specific contracts.
Changes
Review Focus
The 31 retained factories require contracts absent from the narrow shared mocks, including broader API/socket metadata, import-time app graph/canvas states, missing Axios/VueUse/i18n exports, and specialized traversal behavior.