Skip to content

feat(models): show saved assets as a strip under the output - #18438

Closed
mariana953 wants to merge 14 commits into
ben/router-generation-assetsfrom
claude/models-assets-strip
Closed

mariana953 wants to merge 14 commits into
ben/router-generation-assetsfrom
claude/models-assets-strip

Conversation

@mariana953

@mariana953 mariana953 commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Replaces the standalone "Your generations" section with a thumbnail strip directly under the playground output, per design: the latest saved assets, a click opens one full size with its download and a pager, and "See all in Cloud" carries a reader whose library outgrew the strip to the full one.

Changes

  • What:
    • SavedAssetsStrip.vue — thumbnails under PlaygroundOutput, split into SavedAssetTile, SavedAssetMedia, SavedAssetPreview and SavedAssetPager. Replaces GenerationHistory.vue and SavedGenerationMedia.vue (both deleted).
    • The preview pages between saved assets with arrows, dots, arrow keys and a swipe, so browsing a library does not mean closing and reopening the strip for each asset.
    • lib/workshop/saved-assets.ts — pure tile/merge/filename helpers, unit-tested on their own.
    • WORKSHOP_ASSETS_URL in workshop-env.ts, next to the existing WORKSHOP_CREDITS_URL deep link.
    • Signed asset URLs are resolved once per asset and renewed ahead of expiry, instead of one timer per media element.
    • A generation still running keeps a tile (spinner) so leaving the page and returning still shows it, and its preview carries the cancel action the old section had. When it lands, the preview follows it into the saved asset rather than closing.
    • workshop.history.* strings replaced by workshop.assets.*.
  • Breaking: none — gated by PUBLIC_WORKSHOP_SAVE_ASSETS, as before.

Review Focus

  • Based on ben/router-generation-assets, so the diff to read is the UI swap; the router/asset boundary is unchanged.
  • A renewal bug found while writing the tests: resolveAccess only refetched grants that had already expired, so the renewal timer fired and did nothing — the strip went to broken images the moment a signed URL lapsed under the reader. It now renews ahead of expiry, and halfway through a grant shorter than that headroom so a short TTL cannot turn the renewal into a one-second poll.
  • WORKSHOP_ASSETS_URL points at /?assets=1, the param #18442 adds to the app to open Cloud's Assets panel. Independent of this PR: without it the link still lands the reader in Cloud, just without the panel open.
  • Kept as a component rather than a page section so the workflow playground (V2) can reuse it unchanged.
  • The old section's "all models" toggle and "load more" are gone on purpose — the strip shows the latest 8 and Cloud owns the full library.
  • apps/*/e2e-assets/**/*.spec.ts added to the no-misplaced-spec-files exclusion list — that directory already exists on the base branch, and touching the spec made the rule fire.

Screenshots

Rendered locally against mocked asset responses (the real path needs a session plus the two undeployed Cloud PRs), and shared with the designer. Happy to attach them here if useful.

@mariana953
mariana953 requested review from a team and dante01yoon as code owners September 22, 2026 14:35
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 537f7271-f287-4009-bd11-6820792cf34d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2071 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2050 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (25 changed files).

Kind Finding Where Usual remedy
Complexity <template>() — cyclomatic 48, CRAP undefined apps/website/src/components/workshop/ModelDetail.vue:727 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 2aeedf439a1d1aca727b2eda0601c86cfcf75e59

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-18438.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-5rysq602i-comfyui.vercel.app

Last updated: 2026-09-25T14:58:10Z for 579e226

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 139ms TBT · 76.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.8 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 56ms TBT · 166.4 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 337ms TBT · 176.8 MB heap
vue-zoom-out-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 180.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 388ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 63.0 MB
canvas-idle: DOM nodes -262
canvas-idle: event listeners -163
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 28ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 866ms
canvas-mouse-sweep: script duration 170ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 75.8 MB
canvas-mouse-sweep: DOM nodes -264
canvas-mouse-sweep: event listeners -152
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 276ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 61.4 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 433ms
dom-widget-clipping: script duration 164ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 76.6 MB
dom-widget-clipping: DOM nodes 22
dom-widget-clipping: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 549ms
large-graph-idle: script duration 31ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 78.7 MB
large-graph-idle: DOM nodes -246
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1623ms
large-graph-pan: script duration 852ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 77.3 MB
large-graph-pan: DOM nodes -251
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1574ms
large-graph-zoom: script duration 798ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.7 MB
large-graph-zoom: DOM nodes 3
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1849ms
legacy-node-drag: script duration 963ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 81.6 MB
legacy-node-drag: DOM nodes 2
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 508ms
minimap-idle: script duration 30ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.3 MB
minimap-idle: DOM nodes -253
minimap-idle: event listeners -76
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 381ms
subgraph-dom-widget-clipping: script duration 137ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 74.0 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 425ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 66.9 MB
subgraph-idle: DOM nodes -276
subgraph-idle: event listeners -220
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 26ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 742ms
subgraph-mouse-sweep: script duration 100ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 61.5 MB
subgraph-mouse-sweep: DOM nodes -275
subgraph-mouse-sweep: event listeners -209
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 28ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 884ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 139ms
subgraph-transition-enter: heap used 76.6 MB
subgraph-transition-enter: DOM nodes 13587
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 33ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5600ms
viewport-pan-sweep: script duration 2758ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 69.6 MB
viewport-pan-sweep: DOM nodes -249
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 13676ms
vue-large-graph-idle: script duration 240ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 173.8 MB
vue-large-graph-idle: DOM nodes -8061
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 167
vue-large-graph-pan: task duration 19461ms
vue-large-graph-pan: script duration 844ms
vue-large-graph-pan: TBT 56ms
vue-large-graph-pan: heap used 166.4 MB
vue-large-graph-pan: DOM nodes -8061
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 77ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5756ms
vue-node-resize-workload: script duration 111ms
vue-node-resize-workload: TBT 337ms
vue-node-resize-workload: heap used 176.8 MB
vue-node-resize-workload: DOM nodes -8061
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7919ms
vue-zoom-out-idle: script duration 121ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 180.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 24ms
workflow-execution: layout count 5
workflow-execution: style recalc count 19
workflow-execution: task duration 129ms
workflow-execution: script duration 14ms
workflow-execution: TBT 0ms
workflow-execution: heap used 63.7 MB
workflow-execution: DOM nodes 148
workflow-execution: event listeners 81
Raw data
{
  "timestamp": "2026-09-24T19:42:39.668Z",
  "gitSha": "c6d5b66f62595d92d19c8f160325565761393ea6",
  "branch": "claude/models-assets-strip",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 1993.5440000000426,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.222999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.097,
      "heapDeltaBytes": 13502808,
      "heapUsedBytes": 75135268,
      "domNodes": -263,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 7.147,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2022.2059999999829,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.963,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 334.52500000000003,
      "heapDeltaBytes": -4951852,
      "heapUsedBytes": 56891008,
      "domNodes": -260,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.224999999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1968.6889999999835,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 30.326999999999998,
      "layouts": 14,
      "layoutDurationMs": 4.325,
      "taskDurationMs": 935.5259999999998,
      "heapDeltaBytes": 18018588,
      "heapUsedBytes": 80141140,
      "domNodes": -266,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 176.102,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1756.6869999999426,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 24.938,
      "layouts": 14,
      "layoutDurationMs": 3.967999999999999,
      "taskDurationMs": 797.4540000000001,
      "heapDeltaBytes": 16738848,
      "heapUsedBytes": 78779000,
      "domNodes": -262,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 162.932,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1664.3789999999967,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.775,
      "layouts": 6,
      "layoutDurationMs": 1.0199999999999998,
      "taskDurationMs": 245.51000000000002,
      "heapDeltaBytes": 2181048,
      "heapUsedBytes": 64246164,
      "domNodes": 77,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 10.008,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1661.2069999999903,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 14.063,
      "layouts": 6,
      "layoutDurationMs": 0.9740000000000001,
      "taskDurationMs": 305.985,
      "heapDeltaBytes": 2353988,
      "heapUsedBytes": 64595288,
      "domNodes": 75,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 9.502,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 610.1939999999786,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 8.497,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 432.14000000000004,
      "heapDeltaBytes": 18890092,
      "heapUsedBytes": 80446876,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 164.972,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 610.5080000000953,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 9.436,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.08500000000004,
      "heapDeltaBytes": 18642188,
      "heapUsedBytes": 80111652,
      "domNodes": 21,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 162.641,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.0589999999988,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.5139999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 530.78,
      "heapDeltaBytes": 2843960,
      "heapUsedBytes": 83456280,
      "domNodes": -246,
      "jsHeapTotalBytes": -794624,
      "scriptDurationMs": 29.82,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.7350000000642,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.47,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 566.4139999999999,
      "heapDeltaBytes": 946308,
      "heapUsedBytes": 81650440,
      "domNodes": -246,
      "jsHeapTotalBytes": 552960,
      "scriptDurationMs": 31.652,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2219.348000000025,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 11.651000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1632.501,
      "heapDeltaBytes": -1194148,
      "heapUsedBytes": 80923808,
      "domNodes": -248,
      "jsHeapTotalBytes": -8192,
      "scriptDurationMs": 851.2059999999999,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2334.201999999891,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 11.540000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1613.27,
      "heapDeltaBytes": -1078368,
      "heapUsedBytes": 81151320,
      "domNodes": -254,
      "jsHeapTotalBytes": 778240,
      "scriptDurationMs": 852.368,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3478.6000000000286,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 9.788000000000002,
      "layouts": 60,
      "layoutDurationMs": 11.99,
      "taskDurationMs": 1516.241,
      "heapDeltaBytes": 9742640,
      "heapUsedBytes": 75645540,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 815.584,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3450.010999999904,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 10.377000000000004,
      "layouts": 60,
      "layoutDurationMs": 11.934,
      "taskDurationMs": 1631.2920000000001,
      "heapDeltaBytes": 9243828,
      "heapUsedBytes": 74821524,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 779.4879999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3007.0310000000404,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 5.949,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1872.8979999999997,
      "heapDeltaBytes": 18477616,
      "heapUsedBytes": 84239436,
      "domNodes": 4,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 982.034,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2906.6439999999147,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.843,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1825.253,
      "heapDeltaBytes": 20908704,
      "heapUsedBytes": 86902188,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 943.56,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2019.6430000000305,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.2589999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 531.9680000000001,
      "heapDeltaBytes": -4893884,
      "heapUsedBytes": 84062720,
      "domNodes": -252,
      "jsHeapTotalBytes": -1544192,
      "scriptDurationMs": 31.53,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 1996.635000000083,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.384000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 483.89600000000013,
      "heapDeltaBytes": 20194184,
      "heapUsedBytes": 84283412,
      "domNodes": -254,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 28.967000000000006,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 558.2059999999842,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 387.286,
      "heapDeltaBytes": 14530512,
      "heapUsedBytes": 78040652,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 137.32,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 568.0399999999963,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.348,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 375.618,
      "heapDeltaBytes": 13589004,
      "heapUsedBytes": 77079656,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 137.179,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.6980000000285,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.551000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.782,
      "heapDeltaBytes": 6975664,
      "heapUsedBytes": 70707296,
      "domNodes": -277,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.453,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.3419999999142,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.069,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 423.94,
      "heapDeltaBytes": 6107832,
      "heapUsedBytes": 69649008,
      "domNodes": -275,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 6.450000000000001,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1690.4180000000224,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.304,
      "layouts": 18,
      "layoutDurationMs": 4.634,
      "taskDurationMs": 736.9449999999999,
      "heapDeltaBytes": 676092,
      "heapUsedBytes": 64174088,
      "domNodes": -275,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 99.785,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1737.47800000001,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 26.555000000000003,
      "layouts": 18,
      "layoutDurationMs": 4.7219999999999995,
      "taskDurationMs": 746.506,
      "heapDeltaBytes": 1457140,
      "heapUsedBytes": 64836728,
      "domNodes": -274,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 101.038,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.4070000000102,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 28.385999999999996,
      "layouts": 5,
      "layoutDurationMs": 12.618,
      "taskDurationMs": 883.5320000000002,
      "heapDeltaBytes": -6412456,
      "heapUsedBytes": 80332668,
      "domNodes": 13587,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 31.859999999999992,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 139,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8269.57600000003,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 33.293,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5520.269,
      "heapDeltaBytes": -13749960,
      "heapUsedBytes": 67663844,
      "domNodes": -249,
      "jsHeapTotalBytes": 4222976,
      "scriptDurationMs": 2707.138,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8423.39800000002,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 33.187000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5680.341,
      "heapDeltaBytes": -3005448,
      "heapUsedBytes": 78377412,
      "domNodes": -248,
      "jsHeapTotalBytes": -532480,
      "scriptDurationMs": 2808.7200000000003,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16538.734999999975,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15792.776,
      "heapDeltaBytes": -46283840,
      "heapUsedBytes": 169501948,
      "domNodes": -8061,
      "jsHeapTotalBytes": -10526720,
      "scriptDurationMs": 233.43800000000002,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12556.382999999983,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11558.485,
      "heapDeltaBytes": -19178532,
      "heapUsedBytes": 195080792,
      "domNodes": -8061,
      "jsHeapTotalBytes": -5513216,
      "scriptDurationMs": 246.45499999999998,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20040.11099999991,
      "styleRecalcs": 171,
      "styleRecalcDurationMs": 16.325000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19609.943,
      "heapDeltaBytes": -50764772,
      "heapUsedBytes": 180356664,
      "domNodes": -8061,
      "jsHeapTotalBytes": -12115968,
      "scriptDurationMs": 848.2700000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 103,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19729.874999999993,
      "styleRecalcs": 163,
      "styleRecalcDurationMs": 15.250000000000014,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19311.788,
      "heapDeltaBytes": -40691900,
      "heapUsedBytes": 168563736,
      "domNodes": -8061,
      "jsHeapTotalBytes": -12099584,
      "scriptDurationMs": 839.7059999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 9,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5933.781000000067,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.21399999999998,
      "layouts": 20,
      "layoutDurationMs": 21.941000000000003,
      "taskDurationMs": 5786.801,
      "heapDeltaBytes": -42894996,
      "heapUsedBytes": 189178068,
      "domNodes": -8061,
      "jsHeapTotalBytes": 10375168,
      "scriptDurationMs": 119.60699999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 331,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5836.385999999948,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.58800000000002,
      "layouts": 20,
      "layoutDurationMs": 22.01600000000001,
      "taskDurationMs": 5725.427,
      "heapDeltaBytes": -36007436,
      "heapUsedBytes": 181581256,
      "domNodes": -8061,
      "jsHeapTotalBytes": 17494016,
      "scriptDurationMs": 102.144,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 342,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8270.285999999942,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7969.654,
      "heapDeltaBytes": 11944316,
      "heapUsedBytes": 197331488,
      "domNodes": 0,
      "jsHeapTotalBytes": -23068672,
      "scriptDurationMs": 120.336,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8213.172999999984,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7868.889000000001,
      "heapDeltaBytes": 8334884,
      "heapUsedBytes": 181644536,
      "domNodes": 0,
      "jsHeapTotalBytes": -27525120,
      "scriptDurationMs": 121.53699999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 469.41899999990255,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 25.275,
      "layouts": 5,
      "layoutDurationMs": 2.261,
      "taskDurationMs": 142.618,
      "heapDeltaBytes": 5344844,
      "heapUsedBytes": 66856348,
      "domNodes": 149,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 17.831,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 459.47499999999764,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 22.562999999999995,
      "layouts": 5,
      "layoutDurationMs": 2.973,
      "taskDurationMs": 114.45599999999997,
      "heapDeltaBytes": 5012756,
      "heapUsedBytes": 66634324,
      "domNodes": 146,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.560999999999998,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51684 78308 66.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.9% 1152
src/LGraphNode.ts 70.4% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 316
src/LGraph.ts 79.3% 261
src/scripts/app.ts 72.3% 257
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 0.9% 232
src/scripts/pnginfo.ts 20.8% 221

Replaces the separate "Your generations" section with a thumbnail strip
directly under the playground output: the latest saved assets, a click
opens one full size with its download, and "See all in Cloud" carries a
reader whose library outgrew the strip to the full one.

Keeping this a component rather than a page section is what lets the
workflow playground reuse it unchanged.
@mariana953
mariana953 force-pushed the claude/models-assets-strip branch from 18999c9 to a63eee3 Compare September 22, 2026 14:37
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 22, 2026
@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.81132% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...bsite/src/components/workshop/SavedAssetsStrip.vue 91.42% 0 Missing and 12 partials ⚠️
...site/src/components/workshop/SavedAssetPreview.vue 87.03% 1 Missing and 6 partials ⚠️
...ebsite/src/components/workshop/SavedAssetPager.vue 75.00% 4 Missing ⚠️
...website/src/components/workshop/SavedAssetTile.vue 66.66% 0 Missing and 2 partials ⚠️
...ebsite/src/components/workshop/SavedAssetMedia.vue 91.66% 0 Missing and 1 partial ⚠️
apps/website/src/lib/workshop/saved-assets.ts 95.23% 0 Missing and 1 partial ⚠️
@@                      Coverage Diff                      @@
##           ben/router-generation-assets   #18438   +/-   ##
=============================================================
  Coverage                         83.01%   83.02%           
=============================================================
  Files                              2928     2933    +5     
  Lines                            145397   145492   +95     
  Branches                          39372    39393   +21     
=============================================================
+ Hits                             120697   120788   +91     
- Misses                            23446    23447    +1     
- Partials                           1254     1257    +3     
Flag Coverage Δ
unit 79.38% <ø> (-0.01%) ⬇️
website-unit 75.50% <89.81%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ps/website/src/components/workshop/ModelDetail.vue 88.55% <100.00%> (ø)
apps/website/src/composables/useResumePlayback.ts 100.00% <100.00%> (ø)
apps/website/src/config/workshop-env.ts 94.44% <100.00%> (+0.32%) ⬆️
...ebsite/src/components/workshop/SavedAssetMedia.vue 91.66% <91.66%> (ø)
apps/website/src/lib/workshop/saved-assets.ts 95.23% <95.23%> (ø)
...website/src/components/workshop/SavedAssetTile.vue 66.66% <66.66%> (ø)
...ebsite/src/components/workshop/SavedAssetPager.vue 75.00% <75.00%> (ø)
...site/src/components/workshop/SavedAssetPreview.vue 87.03% <87.03%> (ø)
...bsite/src/components/workshop/SavedAssetsStrip.vue 91.42% <91.42%> (ø)

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…review

Fallow flagged the strip's template and its refresh() as new complexity.
The template's branches were one component doing three jobs; refresh()
carried the list call, the active-request backfill and the reschedule.

Co-locating each job with the markup that needs it also gives the
workflow playground smaller pieces to reuse.
@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 25, 2026 2:56pm UTC
billing-web-test Skipped Skipped Sep 25, 2026 2:56pm UTC

Request Review

resolveAccess only refetched grants that had already expired, so the
renewal timer fired and did nothing: the strip went to broken images the
moment a signed URL ran out under the reader. Renew ahead of expiry, and
halfway through a grant shorter than that headroom so a short TTL cannot
turn the renewal into a one-second poll.

Covers the paths the strip had no test for: a gone asset, a rejected
URL, cancelling from the preview, the poll while a run is in flight, and
the backfill that shows a run the listing has not caught up with.
Opening one asset and closing it to open the next makes the strip the
only way through a library the reader is already looking at. Arrows,
dots, arrow keys and a swipe move between the saved assets without
leaving the preview.

Points "see all" at ?assets=1, the param the app's assets URL loader
reads to open Cloud's Assets panel.
The swipe threshold and the dot jump were the two paths the pager
shipped without a test, and both are how the preview is actually moved
through on a phone.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOULD FIX — Four reproducible regressions in the asset strip: transient access failures never recover, tiles exposed by deleted assets never receive URLs, evicted grants keep an idle renewal loop alive, and URL renewal resets playback.

Severity Count
BLOCKER 0
SHOULD FIX 4
TRIVIAL 0

Reviewed all 19 changed files and the surrounding generation, session, download, and media paths at b792d81815ba56785064fe312300a4214535689d. Read-only checks executed the PR's strip logic in memory and its media component in Chromium. CI confirms the 32 new strip/media/helper tests pass; they do not cover these regressions. No repository changes.

…what is shown

Three faults in one lifecycle, all found in review.

A grant that failed for any reason other than 404/410 was dropped on the
floor: no entry was cached, so no deadline existed, and with the run already
complete the list had stopped polling. The tile sat on its spinner for the
life of the page. A failed grant now carries a retry deadline of its own.

Retiring a gone asset uncovers the one behind it, but the sweep had already
fixed its list of tiles, so the newcomer was never asked for. It repeats
until the visible set stops moving.

An asset pushed out of the strip kept its deadline in the cache, and the
renewal timer took the minimum over every entry, visible or not. Once that
deadline lapsed nothing could advance it, so the timer re-armed at its
one-second floor forever. Grants are pruned to what is on screen.
The strip replaces a signed URL under the reader, and assigning the new src
rewinds the element: a clip four seconds in went back to zero for no reason
the reader could see. The element now carries its position and playing state
across a swap that keeps the same asset, while a move to another asset still
starts from the beginning.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the current head: all four review findings are fixed without altering the approved layout. Transient access failures now retry, newly exposed assets receive grants, stale grants no longer keep the renewal timer alive, and signed-URL renewal preserves media playback. Website unit suite (5,291 tests), website typecheck, and focused lint pass locally.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOULD FIX — Re-reviewed 683b0be3fb96b56fdb7d5ebc5b75cc2622f7b33d. Confirmed fixes for initial access retries, replacement-tile access, and evicted renewal deadlines. Successful renewal now preserves playback position, and paging starts the next asset at zero.

Two issues remain: a failed early renewal discards a still-valid URL and unmounts the player; a successful renewal restarts paused video through autoplay.

Severity Count
BLOCKER 0
SHOULD FIX 2
TRIVIAL 0

Verified the strip changes using the updated source in memory and playback behavior using the updated component in Chromium. Website CI passes all 5,291 unit tests. Repository unchanged.

The renewal deadline sits 30s inside the grant's expiry, so a 503 at that
point still leaves a URL the reader can use. Replacing the entry with one
that has none unmounted the player mid-playback and lost its position for
the 15s until the retry landed. The entry now carries the expiry it was
granted, and a failed attempt keeps the URL while that expiry holds.
The preview's video carries `autoplay`, so restoring only the position let
the renewed source start playing again under a reader who had paused it.
Restoration now pauses as well, which also clears the element's autoplay
flag, and the component test covers the swap the composable cannot reach.
Fallow flagged `grantAccess` as a new complexity finding: the branch that
decides what a tile keeps after a failed request had grown inside a
function already carrying the abort and gone-asset guards. It is a pure
decision, so it moves to `saved-assets.ts` where a table test covers all
three cases directly.
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 22, 2026
…y-Org#18442)

## Summary

Opens Cloud's Assets sidebar panel from an `?assets=1` deep link, so
comfy.org can send a visitor from a saved generation to the library that
holds the rest of them.

## Changes

- **What**: `useAssetsUrlLoader`, mirroring `useSettingsUrlLoader` —
reads the param on boot, strips it in one `router.replace`, and opens
the `assets` sidebar tab. Registered in `useUrlActionLoaders` beside the
other cloud deep links.
- Namespaced in `PRESERVED_QUERY_NAMESPACES` **and registered with the
router's preserved-query tracker**, so it survives the sign-in redirect.
An earlier revision of this PR, and of this description, added only the
constant — which captured nothing, restored an empty stash, and lost the
deep link at exactly the redirect it was meant to survive. Caught in
review. The tracker's definitions now live in
`preservedQueryDefinitions.ts` so a test can assert the registration;
the gap existed because nothing could.
- Each loader now settles once its own strip has landed. They previously
fired `router.replace` and returned, so with two deep links in one URL
the second loader read a query the first had not cleaned yet and wrote
the stripped param back.
- **Handled params are swept once after every loader has run.** The four
loaders this PR does not own (Invite, Create Workspace, Pricing, Top Up)
still fire and forget, so `?topup=1&assets=1` could leave `topup=1` in
the address bar whichever replace won the race. Threading `await`
through their exit paths meant reshuffling billing code unrelated to
this change; the sweep fixes the end state without touching them. It
does not stop a loader reading a query in which an earlier param is
present but doomed — harmless today because each loader reads only its
own key, but an assumption rather than a guarantee.
- `useUrlActionLoaders` creates the cloud-only loaders under a single
guard and runs each through one helper, instead of repeating the same
`isCloud ?` ternary and `if (loader) { try … }` block eight times.
- **Breaking**: none. Only `1` opens the panel; any other value is a
silent no-op with the param stripped, same as `?settings=`.

## Review Focus

- `activeSidebarTabId` is **assigned**, not toggled: a visitor who
already had the panel open must not follow the link and watch it close.
Covered by a test.
- The loaders keep opening their panel synchronously and `await` the
navigation last, so existing non-awaited call sites still observe
`show()` and `clearPreservedQuery()` immediately.
- `useUrlActionLoaders.test.ts` previously mocked neither the router nor
the assets loader, so the assets path it nominally covered was being
swallowed by the error helper. It now drives a real in-memory router and
asserts on the resulting URL.
- **Not covered**: a signed-out E2E proving the stash round-trips
through the redirect. The unit test pins the registration, which is
where the bug was; `setupCloudApp` signs in up front, so the existing
E2E never reaches the capture path.
- Counterpart to
[Comfy-Org#18438](Comfy-Org#18438),
which adds the saved-assets strip to the Models playground and whose
"See all in Cloud" link points at this param. That PR is independent —
this one is useful on its own, and the link degrades to "lands in Cloud"
without it.
- Chose the sidebar panel over `useAssetBrowserDialog().browse()` (the
full-screen modal) because the panel is the app's own home for generated
outputs and leaves the workspace usable behind it.

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: benjcooley <benjcooley@gmail.com>

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOULD FIX — The three new commits fix both prior findings: 09765cf4 keeps a still-valid URL after a failed renewal, df6f85c7 preserves paused playback, and 1d2237de extracts that grant decision without changing behavior. Both prior threads are resolved.

One nonblocking retry-timing issue remains for short grants: the fixed 15-second retry can fall after expiry while the expired URL stays exposed.

Severity Count
BLOCKER 0
SHOULD FIX 1
TRIVIAL 0

Verified only the new commits since 683b0be3, including an in-memory grant lifecycle check and the updated media component in Chromium. Current CI is green. Repository unchanged.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at 1d2237de. The two prior playback and renewal findings are fixed and their threads are resolved. The remaining short-grant retry-timing comment is nonblocking.

A 20-second grant renews at +10s; when that failed, the retry was set for
+25s while the URL it kept expired at +20s, so the tile served a dead URL
for five seconds. My earlier note on that thread said it degraded to the
file icon, which it did not. The retry now lands at the expiry at the
latest, which is where the URL stops being worth keeping.
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 24, 2026 19:14 Inactive

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at 63ae8fdf. The new clamp and short-grant unit case fix the scheduled retry gap from the previous review. The existing thread remains open for one nonblocking residual: an expired URL stays exposed while the replacement request itself is in flight.

A tile kept serving its signed URL until the grant request sent to replace
it settled, so an attempt that ran past the expiry — up to the fetch
timeout — left a dead URL on the tile for that whole window. The held URL
now lapses on its own expiry, whatever becomes of the request.
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 24, 2026 19:30 Inactive

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed only eebf2cc1 since the previous approved head. The prior in-flight-expiry issue is fixed for a single renewal, and that thread is resolved. One new nonblocking race remains when access renewals overlap.

Severity Count
BLOCKER 0
SHOULD FIX 1
TRIVIAL 0

CI is green. Approving because the remaining finding is nonblocking.

function lapseHeld(assetId: string) {
const held = access.value.get(assetId)
if (!held?.url) return undefined
const lapse = () => access.value.set(assetId, { ...held, url: undefined })

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOULD FIX — Prevent a stale lapse timer from overwriting a newer grant.

resolveAccess() can overlap: the renewal timer can start one call while refresh() or mediaError() starts another. Each call captures held but clears only its own timeout. If one request installs a fresh grant while the other remains pending, the pending request’s timeout later replaces that fresh entry with { ...held, url: undefined } at the old expiry. The tile then loses a valid URL until another renewal runs. Make this callback conditional on the map still containing the captured grant, or deduplicate in-flight grants, and cover overlapping renewals in the test.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed and fixed in 579e2269. The timer was armed against one grant but written unconditionally, so a request still out when a later one installed a fresh URL wiped that URL at the old expiry — the tile went blank until the next renewal, which is strictly worse than the case the timer exists to prevent.

Took the first option you named: the callback now fires only while the grant it captured is still the one the tile holds.

const lapse = () => {
  const current = access.value.get(assetId)
  if (
    !current ||
    current.url !== held.url ||
    current.expiresAt !== held.expiresAt
  )
    return
  access.value.set(assetId, { ...held, url: undefined })
}

Compared by url and expiry rather than object identity, so it does not rest on Vue returning a stable reactive proxy for a map entry.

New test, keeps a fresh URL a second renewal landed while the first was still out, drives exactly your sequence: 60 s grant, renewal at +30 s whose request never resolves (arming the lapse timer at +60 s), a media error that starts a second request landing a fresh 900 s grant, then advancing past +60 s. It fails on the unfixed code — the assertion reads expected undefined to be 'https://assets.example/fresh.png', which is the tile losing a valid URL — and passes with the guard.

I did not deduplicate in-flight grants, to keep this to the finding. That leaves one benign ordering: if the stranded request eventually succeeds, it overwrites the newer grant with its own valid-but-earlier-expiring URL, so the tile renews sooner than it needed to. Nothing breaks and no URL is lost. Say the word if you would rather have the dedupe and close that off too.

Before pushing: website suite 395 files / 5301 tests pass, vue-tsc --noEmit exit 0, fallow audit --changed-since 2aeedf43 verdict pass with 0 introduced findings, eslint and oxfmt clean.


Generated by Claude Code

Two access requests for the same asset can be in flight at once — the
renewal timer starts one, a media error or a refresh starts another. Each
armed a lapse timer against the grant it captured but cleared only its own,
so a request still pending when a later one installed a fresh URL would
wipe that URL at the old expiry, leaving the tile blank until the next
renewal. The timer now fires only while the grant it captured is still the
one the tile holds.
@vercel
vercel Bot temporarily deployed to Preview – billing-web-test September 25, 2026 14:56 Inactive

Copy link
Copy Markdown
Contributor Author

Closing: superseded by #18837, which ships the same feature — the saved-asset strip under the playground output, behind PUBLIC_WORKSHOP_SAVE_ASSETS — on top of main instead of ben/router-generation-assets, which never merged.

Nothing is lost by closing it: the one thing #18837 did not already have, the coverage for the signed-URL renewal firing ahead of expiry rather than after it, was carried across. #18837 also fixes two defects found since: a cancelled run left its request id behind, and a refused submit published a request id it should not have.

Reopen this one instead if ben/router-generation-assets does land and the router-side diff is wanted as it was written here.


Generated by Claude Code

@mariana953 mariana953 closed this Sep 25, 2026

This branch was previously deployed

1 inactive deployment
Preview – billing-web-test — 579e2269 Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants