Repository navigation
feat(agent): only suggest explaining a selected node when one is selected - #18427
christian-byrne wants to merge 1 commit into
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2092 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (8 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d01f5310556c742f3e1bafec6c4f134256b20fe1
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.96 MB gzip 🟢 -317 BDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.87 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 2 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 123 kB (baseline 123 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.91 MB (baseline 3.92 MB) • 🟢 -1.1 kBStores, services, APIs, and repositories
Status: 2 added / 2 removed / 14 unchanged Utilities & Hooks — 577 kB (baseline 577 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 301 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T12:50:58.367Z",
"gitSha": "4a1822cfdd6258797df460d9e78b20799f15b2f2",
"branch": "christian-byrne/pm-1103-contextual-suggestions",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.0619999999863,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.339000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.931,
"heapDeltaBytes": 10639272,
"heapUsedBytes": 77998536,
"domNodes": -263,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.822999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2019.941000000017,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.282,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.06600000000003,
"heapDeltaBytes": 8432904,
"heapUsedBytes": 76139068,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.009000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1747.2019999999588,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.461999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 824.2700000000001,
"heapDeltaBytes": -236784,
"heapUsedBytes": 62081328,
"domNodes": -263,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 154.762,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1808.8809999999285,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.114000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 880.7719999999999,
"heapDeltaBytes": 9708436,
"heapUsedBytes": 76296904,
"domNodes": -259,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 157.242,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.215999999999,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.875,
"layouts": 6,
"layoutDurationMs": 1.2759999999999998,
"taskDurationMs": 295.26599999999996,
"heapDeltaBytes": 3119820,
"heapUsedBytes": 70717588,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.799000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.0919999999278,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.95,
"layouts": 6,
"layoutDurationMs": 1.121,
"taskDurationMs": 351.51200000000006,
"heapDeltaBytes": 2836464,
"heapUsedBytes": 70257540,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.176,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 708.6320000000228,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.199000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.079,
"heapDeltaBytes": 18825940,
"heapUsedBytes": 86412848,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 168.827,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 719.9439999999413,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.458999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.25600000000003,
"heapDeltaBytes": 18859012,
"heapUsedBytes": 86384932,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 168.761,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1190.637000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 891.38,
"heapDeltaBytes": 12253484,
"heapUsedBytes": 82912876,
"domNodes": 0,
"jsHeapTotalBytes": 20082688,
"scriptDurationMs": 64.62600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 577,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1267.217999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 998.11,
"heapDeltaBytes": -17063968,
"heapUsedBytes": 73076584,
"domNodes": -293,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 67.47399999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 598,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 840.4139999999529,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.6339999999998,
"heapDeltaBytes": 14603484,
"heapUsedBytes": 91509420,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 146.14200000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 830.5619999999863,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.0680000000006,
"heapDeltaBytes": 14954040,
"heapUsedBytes": 89954508,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 143.228,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9079.765999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8145.914999999999,
"heapDeltaBytes": -9038276,
"heapUsedBytes": 67765788,
"domNodes": -4,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 6735.391,
"eventListeners": 0,
"totalBlockingTimeMs": 264,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9176.051000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8330.912,
"heapDeltaBytes": 2961488,
"heapUsedBytes": 85061348,
"domNodes": -18,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 6679.895,
"eventListeners": 0,
"totalBlockingTimeMs": 258,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10031.675000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9110.588,
"heapDeltaBytes": 4968432,
"heapUsedBytes": 86703416,
"domNodes": -14,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 7324.211,
"eventListeners": 0,
"totalBlockingTimeMs": 536,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10845.037000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10003.701,
"heapDeltaBytes": -4829128,
"heapUsedBytes": 77575380,
"domNodes": -14,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 8169.965000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 813,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2042.8289999999834,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.597999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 654.98,
"heapDeltaBytes": -3992932,
"heapUsedBytes": 83045328,
"domNodes": -241,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 39.217,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.0170000000244,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.451999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 679.2020000000001,
"heapDeltaBytes": -4047920,
"heapUsedBytes": 83010180,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 38.584999999999994,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2348.208999999997,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.643,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1712.7649999999996,
"heapDeltaBytes": -11810932,
"heapUsedBytes": 76436764,
"domNodes": -245,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 846.759,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2673.2020000000603,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.513999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1841.0539999999999,
"heapDeltaBytes": -2174084,
"heapUsedBytes": 86547168,
"domNodes": -248,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 942.3699999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3571.3250000000016,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.573,
"layouts": 60,
"layoutDurationMs": 15.276000000000002,
"taskDurationMs": 1715.405,
"heapDeltaBytes": 8412700,
"heapUsedBytes": 74344144,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 791.767,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3618.6139999999796,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.840000000000002,
"layouts": 60,
"layoutDurationMs": 15.388999999999998,
"taskDurationMs": 1752.385,
"heapDeltaBytes": 9423244,
"heapUsedBytes": 74626844,
"domNodes": -3,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 810.613,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3188.7839999999983,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.604,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2072.0229999999997,
"heapDeltaBytes": -4389412,
"heapUsedBytes": 86812412,
"domNodes": -229,
"jsHeapTotalBytes": 1232896,
"scriptDurationMs": 1043.96,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3126.455999999962,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.676,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1957.3109999999997,
"heapDeltaBytes": 25475284,
"heapUsedBytes": 91575608,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 987.257,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1995.018000000016,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.636000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.85800000000006,
"heapDeltaBytes": 20129784,
"heapUsedBytes": 84714344,
"domNodes": -246,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.306000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2035.6120000000146,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.110000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.5149999999999,
"heapDeltaBytes": -4777940,
"heapUsedBytes": 84424492,
"domNodes": -244,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 37.129999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.1880000000037,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.847,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.53499999999997,
"heapDeltaBytes": 14005400,
"heapUsedBytes": 76977200,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 150.078,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.5449999999546,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.24,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.841,
"heapDeltaBytes": 13698080,
"heapUsedBytes": 83581052,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 150.81,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2016.5620000000217,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.463000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.09900000000005,
"heapDeltaBytes": 8639640,
"heapUsedBytes": 78072724,
"domNodes": -272,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.166000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2024.2729999999938,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.434000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.747,
"heapDeltaBytes": 15683240,
"heapUsedBytes": 79577600,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.227999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.666000000041,
"styleRecalcs": 47,
"styleRecalcDurationMs": 18.821,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 690.46,
"heapDeltaBytes": -9693116,
"heapUsedBytes": 59211132,
"domNodes": -274,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 110.35800000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.9889999999887,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.066999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 781.219,
"heapDeltaBytes": -3033016,
"heapUsedBytes": 66893068,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 108.75699999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.445000000028,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.344,
"layouts": 5,
"layoutDurationMs": 12.220000000000002,
"taskDurationMs": 941.6329999999999,
"heapDeltaBytes": -6243336,
"heapUsedBytes": 83412520,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.09200000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8692.813999999998,
"styleRecalcs": 251,
"styleRecalcDurationMs": 44.686,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6119.287,
"heapDeltaBytes": -6468056,
"heapUsedBytes": 80743812,
"domNodes": -238,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 2784.8799999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8709.904999999935,
"styleRecalcs": 250,
"styleRecalcDurationMs": 45.922000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6308.085,
"heapDeltaBytes": -15545484,
"heapUsedBytes": 71478352,
"domNodes": -216,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 2973.9210000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18202.097999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17975.512000000002,
"heapDeltaBytes": -52905080,
"heapUsedBytes": 187929428,
"domNodes": -8091,
"jsHeapTotalBytes": -14675968,
"scriptDurationMs": 291.51,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17985.529999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17852.05,
"heapDeltaBytes": -32350492,
"heapUsedBytes": 190231684,
"domNodes": -8061,
"jsHeapTotalBytes": -18001920,
"scriptDurationMs": 295.42999999999995,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22667.393000000004,
"styleRecalcs": 167,
"styleRecalcDurationMs": 22.890999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22516.219,
"heapDeltaBytes": -25128484,
"heapUsedBytes": 189862372,
"domNodes": -8061,
"jsHeapTotalBytes": -13246464,
"scriptDurationMs": 921.0440000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 108,
"frameDurationMs": 17.779999999999806,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 22627.830000000016,
"styleRecalcs": 166,
"styleRecalcDurationMs": 23.758000000000028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22484.174,
"heapDeltaBytes": -44174872,
"heapUsedBytes": 171259404,
"domNodes": -8061,
"jsHeapTotalBytes": -10293248,
"scriptDurationMs": 918.7689999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 265,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6599.490999999944,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.07900000000001,
"layouts": 20,
"layoutDurationMs": 25.115000000000013,
"taskDurationMs": 6551.544,
"heapDeltaBytes": -39564920,
"heapUsedBytes": 175737132,
"domNodes": -8061,
"jsHeapTotalBytes": 18554880,
"scriptDurationMs": 121.014,
"eventListeners": -14928,
"totalBlockingTimeMs": 518,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6475.692999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.42399999999999,
"layouts": 20,
"layoutDurationMs": 26.003,
"taskDurationMs": 6457.773,
"heapDeltaBytes": -50131116,
"heapUsedBytes": 176244256,
"domNodes": -8061,
"jsHeapTotalBytes": 14512128,
"scriptDurationMs": 119.547,
"eventListeners": -14928,
"totalBlockingTimeMs": 448,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9105.351000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8943.186999999998,
"heapDeltaBytes": 18328320,
"heapUsedBytes": 185988912,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 151.91199999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8965.755999999943,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8881.942999999997,
"heapDeltaBytes": 28547716,
"heapUsedBytes": 196677440,
"domNodes": 0,
"jsHeapTotalBytes": -7864320,
"scriptDurationMs": 137.95999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 123.68900000001304,
"styleRecalcs": 10,
"styleRecalcDurationMs": 18.623,
"layouts": 2,
"layoutDurationMs": 0.615,
"taskDurationMs": 93.55200000000002,
"heapDeltaBytes": 3197692,
"heapUsedBytes": 68526004,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.996,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 470.84400000005644,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.631999999999994,
"layouts": 4,
"layoutDurationMs": 2.2729999999999997,
"taskDurationMs": 128.82600000000002,
"heapDeltaBytes": 5031540,
"heapUsedBytes": 70543192,
"domNodes": 150,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.461,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe agent empty state now hides “Explain the selected node” when no node is selected. AgentPanel passes selection state to EmptyState. Component and integration tests cover both selection states. ChangesSelected-node suggestion visibility
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The panel now shows the selected-node explanation only when a node is selected, while preserving other suggestion icons. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18427 +/- ##
==========================================
+ Coverage 83.35% 84.34% +0.98%
==========================================
Files 2989 2287 -702
Lines 147185 129980 -17205
Branches 39934 35116 -4818
==========================================
- Hits 122686 109626 -13060
+ Misses 23217 20059 -3158
+ Partials 1282 295 -987
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 708 files with indirect coverage changes 🚀 New features to boost your workflow:
|
## Summary - evaluate `agent-starter-prompt-set` from authenticated remote config with fail-closed control behavior - render a Cloud-only treatment set while preserving the existing control copy - keep both arms on the same locale eligibility rule; unsupported locales, QA overrides, and pre-auth surfaces emit no experiment assignment - carry the rendered assignment through exposure, click, and attributed-send telemetry - consume the generated `/api/features` contract from merged Cloud PR Comfy-Org/cloud#12257 ## Verification - 95 focused Vitest tests pass across seven Agent assignment, panel, composer, prompt, and store files - app typecheck and browser-suite typecheck pass - treatment Playwright path passes locally against the branch (`1 passed`, 6.6s): `/api/features` → treatment render → exposure → attributed send - screenshot fixture passes for control/treatment at docked and maximized widths (`2 passed`, 7.7s) - pre-push knip/fallow gate reports no issues in changed files ## Visuals | Arm | Docked panel | Maximized panel | | --- | --- | --- | | Control |  |  | | Treatment |  |  | ## Rollout state PostHog experiment 469318 is already running. The pre-deploy interval is not a valid treatment period because the Cloud assignment field was not implemented. After this PR deploys, smoke-check both variants and use the first compatible custom exposure, retaining client/Cloud version evidence, as the experiment analysis boundary. ## Compatibility note Open PRs #18384 and #18427 filter prompt slots by index. If either rebases onto this experiment, it must apply visibility per arm and report the visible `prompt_count`, because a slot carries different copy in control and treatment. --------- Co-authored-by: GitHub Action <action@github.com>
|
Superseded by #21924, rebased onto current Agent starter-prompt architecture with stable slot attribution and black-box red-on-parent coverage. |
## Summary Hide the control arm's "Explain the selected nodes" starter prompt until the user adds a node through Agent node-selection mode. Preserve the original five-slot prompt identity and attribution. The graduated Cloud treatment prompt remains available because it is not selection-dependent. Supersedes Comfy-Org#18427 with a current-main implementation and harness coverage. Linear: PM-1103. ## Verification - Black-box Agent harness (local harness-only project; CI unit coverage exercises the same provenance path): `PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_TEST_URL=http://127.0.0.1:6268 PLAYWRIGHT_SETUP_API_URL=http://127.0.0.1:8188 DISTRIBUTION=localhost pnpm exec playwright test browser_tests/tests/agent/agentSelectedNodeStarterPrompt.spec.ts --project=agent-harness --workers=1 --retries=0 --reporter=line` — 1 passed. It proves the prompt is hidden initially, remains hidden after a normal node mention made while selection mode is active, and appears only after a canvas-selected node is added. - Store and empty-state unit suites — 55 passed. - Focused AgentPanelRoot regressions — 4 passed, including mention-during-picking attribution and persistence across an `AgentPanelRoot` remount. - Browser typecheck and ESLint passed. - Pre-commit: formatting, stylelint, type-aware oxlint, ESLint, server-fact lint, app typecheck, and browser typecheck passed. - Pre-push: dependency-cruiser, knip, and changed-file fallow audit passed. - CodeRabbit's exact-head findings were fixed and both review threads were resolved with commit and test evidence. - Rebased onto `main` `ab4de6b66d2779fe1a5464a21b0842b5fb61b50f`; current head is `4dfe115f18d72c391258ee90097580ad5db25ba2`./ CodeRabbit’s stable-node-reference finding was fixed at this head and the thread resolved with harness evidence./
Description
The empty agent panel no longer offers Explain the selected node when there is no selected node, avoiding a first-run suggestion that cannot work. The suggestion appears as soon as a node selection exists.
The suggestion model keeps each prompt paired with its original icon while filtering, so later prompts do not inherit the wrong icon when the selection-only item is hidden.
Linear: PM-1103
How has this been tested?
pnpm vitest run src/workbench/extensions/agent/components/agent/EmptyState.test.ts src/workbench/extensions/agent/components/agent/AgentPanel.test.ts(10 tests)pnpm typecheckpnpm lint:unstagedDocumentation
Screenshots or screen capture
Not included; the change hides one existing chip only in the no-selection state.