Repository navigation
feat(agent): attach pasted clipboard images - #18409
christian-byrne wants to merge 1 commit into
Conversation
|
Warning Review paused — included plan limit reachedKeep your review moving with free on-demand reviews.
On-demand reviews are free for the next 18 days.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Promotion and pricing detailsOn-demand reviews are free for the next 18 days. After that, they cost $0.25 per reviewed file. Review limit detailsOr wait 9 minutes for your next included review. Limit details: You’ve used all 8 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2094 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.96 MB gzip 🔴 +268 kBDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.73 kB) • 🔴 +138 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.43 MB) • 🔴 +13.6 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 124 kB) • 🔴 +8.02 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 37.9 kB (baseline 27.8 kB) • 🔴 +10.1 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +740 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 123 kB (baseline 117 kB) • 🔴 +6.31 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.91 MB (baseline 3.6 MB) • 🔴 +309 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 577 kB (baseline 559 kB) • 🔴 +18.7 kBHelpers, composables, and utility bundles
Status: 31 added / 29 removed / 7 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -692 kBExternal libraries and shared vendor chunks
Status: 11 added / 11 removed / 7 unchanged Other — 17.8 MB (baseline 16.4 MB) • 🔴 +1.42 MBBundles that do not match a named category
Status: 179 added / 173 removed / 123 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T08:24:49.465Z",
"gitSha": "3dbe46da965f899c40283ecfd9d52824cf076636",
"branch": "christian-byrne/pm-1362-clipboard-attachment",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1997.6729999999634,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.027999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.30500000000006,
"heapDeltaBytes": -7448964,
"heapUsedBytes": 60086484,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.758000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2008.295999999973,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.081,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.39700000000005,
"heapDeltaBytes": 8228548,
"heapUsedBytes": 75661660,
"domNodes": -258,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 10.679,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.0390000000102,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.797,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 682.034,
"heapDeltaBytes": 12044500,
"heapUsedBytes": 79392672,
"domNodes": -258,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 120.89800000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1728.2920000000104,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.572999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.838,
"heapDeltaBytes": 928548,
"heapUsedBytes": 63505284,
"domNodes": -259,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 131.735,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.0150000000026,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.935,
"layouts": 6,
"layoutDurationMs": 1.1179999999999999,
"taskDurationMs": 257.284,
"heapDeltaBytes": 2132124,
"heapUsedBytes": 64439064,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 14.383,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.6629999999777,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.086,
"layouts": 6,
"layoutDurationMs": 0.993,
"taskDurationMs": 276.414,
"heapDeltaBytes": 3160976,
"heapUsedBytes": 70702136,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.493,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 526.0149999999726,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.514999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.729,
"heapDeltaBytes": 17976328,
"heapUsedBytes": 80338660,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 130.238,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 548.1029999999691,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.707000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.08200000000005,
"heapDeltaBytes": 18516896,
"heapUsedBytes": 80877064,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 135.72899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1032.8759999999875,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 704.575,
"heapDeltaBytes": 34344748,
"heapUsedBytes": 104805500,
"domNodes": 0,
"jsHeapTotalBytes": 20606976,
"scriptDurationMs": 54.48599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 429,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1063.615000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 754.6259999999999,
"heapDeltaBytes": -17187628,
"heapUsedBytes": 73039136,
"domNodes": -295,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 52.472,
"eventListeners": -217,
"totalBlockingTimeMs": 413,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 778.8100000000213,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.66600000000005,
"heapDeltaBytes": 14950244,
"heapUsedBytes": 91310184,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 124.221,
"eventListeners": 0,
"totalBlockingTimeMs": 162,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 776.1489999999185,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.413,
"heapDeltaBytes": 14131048,
"heapUsedBytes": 90758304,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.14199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 160,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7831.490000000031,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.9930000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6908.423,
"heapDeltaBytes": 3013192,
"heapUsedBytes": 81213676,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 5655.748,
"eventListeners": -174,
"totalBlockingTimeMs": 175,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7693.411999999967,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.12799999999999964,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6834.328,
"heapDeltaBytes": 151260,
"heapUsedBytes": 82462700,
"domNodes": -18,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 5428.674,
"eventListeners": 0,
"totalBlockingTimeMs": 29,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7627.095999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6744.707,
"heapDeltaBytes": -9500776,
"heapUsedBytes": 72325844,
"domNodes": -18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 5350.1050000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 128,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7533.87900000007,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.8480000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6649.249,
"heapDeltaBytes": 4453468,
"heapUsedBytes": 82146288,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 5471.7570000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 101,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2017.8429999999707,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.967999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.3,
"heapDeltaBytes": -4013580,
"heapUsedBytes": 83665680,
"domNodes": -240,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 33.86500000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2040.6410000000506,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.675000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.208,
"heapDeltaBytes": -1793396,
"heapUsedBytes": 79247508,
"domNodes": -245,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 39.766,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2203.9120000000025,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.480999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1506.326,
"heapDeltaBytes": -10091000,
"heapUsedBytes": 78493988,
"domNodes": -213,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 736.125,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2182.4870000000374,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.679999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1364.455,
"heapDeltaBytes": 16179408,
"heapUsedBytes": 80269320,
"domNodes": -241,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 659.328,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3263.1979999999885,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.971000000000004,
"layouts": 60,
"layoutDurationMs": 13.776,
"taskDurationMs": 1491.1799999999998,
"heapDeltaBytes": 10131596,
"heapUsedBytes": 74153140,
"domNodes": -247,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 654.6120000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3271.2710000000698,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.309999999999997,
"layouts": 60,
"layoutDurationMs": 13.03,
"taskDurationMs": 1487.027,
"heapDeltaBytes": -19943452,
"heapUsedBytes": 69790940,
"domNodes": -214,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 652.558,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2536.054999999976,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.911000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1647.3270000000002,
"heapDeltaBytes": 16987016,
"heapUsedBytes": 81615512,
"domNodes": -243,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 814.7299999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2320.856000000049,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.714999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1667.796,
"heapDeltaBytes": -10399268,
"heapUsedBytes": 74004548,
"domNodes": -253,
"jsHeapTotalBytes": 2052096,
"scriptDurationMs": 804.385,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2008.595000000014,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.038,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.2639999999999,
"heapDeltaBytes": 20171888,
"heapUsedBytes": 84596468,
"domNodes": -243,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.375,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2007.7459999999974,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.8580000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.8789999999999,
"heapDeltaBytes": 20112944,
"heapUsedBytes": 84487920,
"domNodes": -241,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.975,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 530.1650000000109,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.884,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.856,
"heapDeltaBytes": 13022812,
"heapUsedBytes": 76925540,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 121.369,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 508.6750000000393,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.721,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.39700000000005,
"heapDeltaBytes": 14039792,
"heapUsedBytes": 83812996,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 119.16900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1993.3909999999742,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.613,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.371,
"heapDeltaBytes": -3417016,
"heapUsedBytes": 66425248,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.423,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1993.4690000000046,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.705,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.294,
"heapDeltaBytes": -4621700,
"heapUsedBytes": 65166152,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.502999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.267999999985,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.316,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 650.467,
"heapDeltaBytes": -1587464,
"heapUsedBytes": 68247704,
"domNodes": -274,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 92.031,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.6150000000462,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.796,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 648.5490000000001,
"heapDeltaBytes": -6659184,
"heapUsedBytes": 63238396,
"domNodes": -274,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 92.102,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1301.5530000000126,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.694000000000006,
"layouts": 5,
"layoutDurationMs": 9.907,
"taskDurationMs": 793.1639999999998,
"heapDeltaBytes": -6346920,
"heapUsedBytes": 86915428,
"domNodes": 13667,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 26.894999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 96,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8294.157999999981,
"styleRecalcs": 252,
"styleRecalcDurationMs": 41.162000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4957.257,
"heapDeltaBytes": -12142492,
"heapUsedBytes": 75549216,
"domNodes": -245,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 2233.513,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8342.365999999969,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.331,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5072.241,
"heapDeltaBytes": 1897896,
"heapUsedBytes": 89883464,
"domNodes": -240,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 2446.774,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14667.389000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14550.649,
"heapDeltaBytes": -48759280,
"heapUsedBytes": 191691516,
"domNodes": -8062,
"jsHeapTotalBytes": -17944576,
"scriptDurationMs": 208.722,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14260.780000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13991.823,
"heapDeltaBytes": -43219700,
"heapUsedBytes": 194843280,
"domNodes": -8062,
"jsHeapTotalBytes": -10858496,
"scriptDurationMs": 204.887,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17406.48799999997,
"styleRecalcs": 123,
"styleRecalcDurationMs": 16.57800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17351.055,
"heapDeltaBytes": -41314292,
"heapUsedBytes": 179688404,
"domNodes": -8062,
"jsHeapTotalBytes": -22233088,
"scriptDurationMs": 727.417,
"eventListeners": -14928,
"totalBlockingTimeMs": 8,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17123.758000000067,
"styleRecalcs": 131,
"styleRecalcDurationMs": 14.613999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16951.356,
"heapDeltaBytes": -50853600,
"heapUsedBytes": 169581060,
"domNodes": -8062,
"jsHeapTotalBytes": -22347776,
"scriptDurationMs": 702.7280000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 11,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5285.299000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.71999999999997,
"layouts": 20,
"layoutDurationMs": 22.381999999999998,
"taskDurationMs": 5266.406,
"heapDeltaBytes": -59368476,
"heapUsedBytes": 177886820,
"domNodes": -8062,
"jsHeapTotalBytes": 18763776,
"scriptDurationMs": 87.728,
"eventListeners": -14928,
"totalBlockingTimeMs": 247,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4197.935999999913,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.88300000000002,
"layouts": 20,
"layoutDurationMs": 21.473000000000006,
"taskDurationMs": 4081.193999999999,
"heapDeltaBytes": -33636684,
"heapUsedBytes": 186987340,
"domNodes": -8062,
"jsHeapTotalBytes": 28704768,
"scriptDurationMs": 74.881,
"eventListeners": -14928,
"totalBlockingTimeMs": 4,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7326.828999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7281.423999999997,
"heapDeltaBytes": -10862964,
"heapUsedBytes": 168699224,
"domNodes": 0,
"jsHeapTotalBytes": -19660800,
"scriptDurationMs": 149.91100000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7194.615999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7065.937,
"heapDeltaBytes": 16078256,
"heapUsedBytes": 182071092,
"domNodes": 0,
"jsHeapTotalBytes": -10485760,
"scriptDurationMs": 102.67199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 462.2630000000072,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.367,
"layouts": 5,
"layoutDurationMs": 1.9200000000000002,
"taskDurationMs": 122.69000000000001,
"heapDeltaBytes": 5278208,
"heapUsedBytes": 70809540,
"domNodes": 153,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.272,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 438.34100000003673,
"styleRecalcs": 13,
"styleRecalcDurationMs": 16.216,
"layouts": 3,
"layoutDurationMs": 0.8230000000000001,
"taskDurationMs": 87.78200000000001,
"heapDeltaBytes": 4877536,
"heapUsedBytes": 66807092,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.795,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18409 +/- ##
==========================================
+ Coverage 83.34% 84.33% +0.99%
==========================================
Files 2985 2283 -702
Lines 147069 129868 -17201
Branches 39913 35097 -4816
==========================================
- Hits 122569 109529 -13040
+ Misses 23218 20044 -3174
+ Partials 1282 295 -987
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 709 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
The feature works, but I ran an experiment on the test coverage and found that the guard this PR is built around has no test holding it in place — details inline, with the reproduction.
Routing pasted images through the existing validated upload pipeline rather than a second ad-hoc path is the right call, and reusing attachment.addFiles means the size and type rules you already have (including the server-feature-driven video limit) apply to paste for free.
One blocking coverage issue and two questions about the ownership boundary, all inline.
| await nextTick() | ||
|
|
||
| const image = new File(['image'], 'canvas.png', { type: 'image/png' }) | ||
| expect(dispatchPaste(document.body, [image])).toBe(false) |
There was a problem hiding this comment.
issue: This test passes whether or not the composer guard exists, so the PR's central mechanism is uncovered.
I verified it rather than eyeballing it. On cac5412, I deleted the guard in AgentPanelRoot.vue:1267, reducing it to if (!(target instanceof Element)) return, and re-ran both new tests:
pnpm test:unit src/workbench/extensions/agent/AgentPanelRoot.test.ts \
-t "clipboard|pasted into the focused composer"
→ Tests 2 passed | 242 skipped (identical to the unmodified run)
The reason is the dispatch target. document.body is an ancestor of the element carrying @paste.capture, not a descendant, so the handler never runs for this event — the guard is never consulted and defaultPrevented is trivially false. The assertion holds for a reason unrelated to what it's meant to prove.
That matters because closest('#agent-composer') is doing real work: it's a magic string matched against an id defined in a different component (Composer.vue:332), with no type relationship between them. A rename there is exactly the regression this test should catch, and today it wouldn't.
Dispatching on something inside the panel but outside the composer covers it — the message list, or the panel root itself. With the guard intact that stays false; with it removed it flips to true and the test fails, which is the signal you want.
| ) | ||
| if (files.length === 0) return | ||
| event.preventDefault() | ||
| event.stopPropagation() |
There was a problem hiding this comment.
question: In the capture phase this stops the event before the composer's own editor ever sees it. Is dropping the accompanying text intended when the clipboard carries both?
The composer is a ProseMirror contenteditable (Composer.vue → InlinePromptEditor.vue), so @paste.capture + stopPropagation() means ProseMirror's paste handling is bypassed entirely whenever clipboardData.files has at least one attachable entry. For an image-only paste that's exactly right.
The case I'm unsure about is a mixed payload. Copying a cell range out of Sheets or Excel puts both a rendered image and text/html/text/plain on the clipboard; same for some rich editors. After this change, pasting that into the composer silently attaches a PNG of the selection and inserts none of the text — where today the user gets the text. Both behaviors are defensible, but the current one is implicit.
If attaching is the intent, no change needed beyond maybe a note here. If text should still land when it's present, gating on files.length > 0 && !event.clipboardData?.getData('text/plain') — or letting the event through and only attaching — would preserve it.
|
|
||
| function onPanelPaste(event: ClipboardEvent): void { | ||
| const target = event.target | ||
| if (!(target instanceof Element) || !target.closest('#agent-composer')) return |
There was a problem hiding this comment.
question: The summary frames this as pasting images "instead of letting the canvas create a Load Image node" — was the canvas actually claiming these pastes?
The document-level handler in usePaste.ts:200 bails immediately via shouldIgnoreCopyPaste(e.target), and that helper returns true for target.isContentEditable (eventHelpers.ts:68-72). With focus in the composer the paste target is the ProseMirror contenteditable, so the canvas path should already have been declining it before this PR.
If that's right, the change is purely additive — it adds attaching, rather than winning a conflict — and the framing in the description (and in the E2E step 3, "verify no Load Image node is added") describes a race that wasn't happening. Not a code problem either way; I'd just rather the recorded motivation match the mechanism, since the next person to touch paste ownership will read this description first.
If you have seen a Load Image node appear from a composer paste, that's more interesting than the fix — it would mean shouldIgnoreCopyPaste is missing the composer in some state, and that gap would still be open for non-attachable files, which this handler returns early on without claiming.
|
Closing unmerged: superseded by #18248 ( Rebasing this branch onto current main was measured and it now regresses main rather than adding behaviour: at cac5412 rebased onto d965cd4, No work is lost by closing: the shipped path is #18248. |
Pull request was closed
Summary
Paste clipboard images into the focused agent composer as attachments instead of letting the canvas create a Load Image node.
Changes
Testing
pnpm vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts --testNamePattern="clipboard|pasted into the focused composer"pnpm typecheckE2E verification
Linear: PM-1362