Repository navigation
backport: autogrow slot can't be reconnected after disconnect without refresh (PM-1496) [cloud/1.54] - #18386
Conversation
…esh (PM-1496) (#18289) <!-- ccr-slack-attribution --> _Requested by **Denys Puziak** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789991789275729?thread_ts=1789991789.275729&cid=C0BGH348Z0C)_ Denys wired an IMAGE output straight into `OpenAIGPTImageNodeV2`'s STRING `prompt` input and asked the in-app agent to fix it ([reconnect report PM-1496 and parent agent-wiring report PM-1145](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789991789275729?thread_ts=1789991789.275729&cid=C0BGH348Z0C)). While investigating, we found that after an autogrow image slot (e.g. `model.images.image_2`) gets disconnected immediately after being connected - with no render frame in between, as happens when the in-app agent applies connect/disconnect CRDT ops back-to-back - `withComfyAutogrow`'s same-slot swap guard in `src/core/graph/widgets/dynamicWidgets.ts` misclassified the disconnect as the tail end of an atomic same-slot swap and skipped scheduling the real compaction. The slot was left stuck, disconnected, in the middle of the group, and the UI silently refused to accept a new link into it until the page was fully reloaded. The swap guard now tracks two things instead of relying only on "did a render frame elapse": whether the slot's own connect event has already fired (`pendingConnectionSeen`), and which specific slot is mid-swap (`swappingSlot`, scoped per-slot rather than node-wide). A disconnect that arrives after its slot's connect event already fired is correctly treated as a separate, later operation rather than a swap, so `autogrowInputDisconnected` runs and the group compacts back down to its one spare slot. Scoping the guard to a single slot also means a genuine connect on a *different* slot of the same node is never mistaken for a swap's own connect and silently dropped. Covered by two new tests in `src/core/graph/widgets/dynamicWidgets.test.ts`: - disconnecting a slot immediately after connecting it (no frame in between) now compacts back to one spare slot - a same-slot swap in progress no longer swallows a genuine connect on a different slot of the same node ``` pnpm vitest run src/core/graph/widgets/dynamicWidgets.test.ts ``` `eslint`/`oxfmt` clean on the changed files. Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01CoKpwnbrjRvnAyVd6dnPiq --- _Generated by [Claude Code](https://claude.ai/code/session_01CoKpwnbrjRvnAyVd6dnPiq)_ Justification: Christian authorized Agent-release source completion and qualified admin merges on September 22. The [current-head approval](#18289 (review)) was produced by agents using Christian's account, not an independent human peer review. No outstanding human correctness objection was found. Three individually verified browser cases passed on a served tree identical to [the reviewed head](5f18ab2); unpack and original in-app agent acceptance remain unproven. Post-merge human peer review remains outstanding. <details><summary>Full context for agent readers</summary> Moving-main merge judgment: the reviewed head is fourteen commits behind [main at qualification](3643a67). Complete check pagination found 87 successful and 16 skipped check/status entries, with none adverse or pending. The merge guard refused staleness; it did not pass. The overlapping `dynamicWidgets.ts` change captures the existing graph reference inside `withComfyMatchType` without changing the autogrow lifecycle guards. The intervening slot synchronization, widget/serialization and asset-drag changes were inspected. A fresh unpublished merge with that main passed 170 targeted tests in eight graph, materializer, slot and widget suites, using the lane's existing dependencies without installation. Earlier prospective-main checks passed another 239 and 44 tests. These checks support this bounded source landing; they are not hosted browser execution on the newer main or deployment acceptance. All fourteen review threads are resolved; the earlier changes-requested review was agent-authored and superseded by the exact-head approval. No human review was dismissed. The selected autogrow conversion, autogrow image loading and ordinary multi-input conversion each passed once without retry in [the hosted shard](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35685320108/job/106612686697). The custom-node unpack case was excluded, not passed. Cloud release inclusion and original user-journey acceptance remain separate obligations. Final main refresh adds one [website-only revert](eb42a09), making fifteen commits behind. Its complete path list is confined to `apps/website/` and `.github/pr-images/`, with no application runtime, build configuration or dependency change. This disjoint delta does not invalidate the targeted prospective-merge tests. Final head/checks/reviews remain unchanged; the guard still refuses staleness only. Subsequent identity refresh stopped the merge before execution because [named-input preservation](4e497de) landed, making sixteen commits behind. Unlike the website delta, this changes interacting agent materialization and remote slot synchronization. After inspecting both production changes, a new unpublished combination passed 242 ordinary tests and one expected failure across six suites: autogrow, node data, materialization, materializer input ordering, graph mutations and the agent follower. The new code preserves named live input slots and realigns saved links after configuration; it does not replace the synchronous connection callbacks whose swap-state tracking this PR repairs. This supersedes the earlier moving-main qualification, with the same existing-dependency and browser-evidence limitations. Glossary: prospective merge means an unpublished combination tested locally; tree-identical means all tracked files match; source landing does not mean a production deployment. </details>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1937 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-22T07:52:38.782Z",
"gitSha": "b13fbb6333aa686780d91948b99967a839b8fd72",
"branch": "backport-18289-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.653000000048,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.883000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.27099999999996,
"heapDeltaBytes": -10891364,
"heapUsedBytes": 58985884,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.063999999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2015.5579999999986,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.461,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.33500000000004,
"heapDeltaBytes": -13207496,
"heapUsedBytes": 57319604,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.587,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1859.296000000029,
"styleRecalcs": 76,
"styleRecalcDurationMs": 22.737000000000002,
"layouts": 14,
"layoutDurationMs": 3.953,
"taskDurationMs": 850.3530000000001,
"heapDeltaBytes": -6821352,
"heapUsedBytes": 63440640,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 129.601,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1737.1989999999755,
"styleRecalcs": 74,
"styleRecalcDurationMs": 20.174999999999997,
"layouts": 14,
"layoutDurationMs": 3.1910000000000003,
"taskDurationMs": 703.1970000000001,
"heapDeltaBytes": 953704,
"heapUsedBytes": 71693908,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 110.25500000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.984999999951,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.178,
"layouts": 6,
"layoutDurationMs": 1.0359999999999998,
"taskDurationMs": 303.48199999999997,
"heapDeltaBytes": 4580312,
"heapUsedBytes": 75606372,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.584000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1657.5739999999541,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.316999999999998,
"layouts": 6,
"layoutDurationMs": 1.1270000000000002,
"taskDurationMs": 310.407,
"heapDeltaBytes": 4625916,
"heapUsedBytes": 75759888,
"domNodes": 75,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 10.193999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 626.4869999999974,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.424999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.85,
"heapDeltaBytes": -7897488,
"heapUsedBytes": 62936580,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 136.156,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 547.3380000000816,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.1190000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.747,
"heapDeltaBytes": 18144144,
"heapUsedBytes": 82970576,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 129.11999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.574999999994,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.086000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.6869999999999,
"heapDeltaBytes": 3196976,
"heapUsedBytes": 79501548,
"domNodes": -282,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 31.206999999999997,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2001.4449999999897,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.893,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.6290000000001,
"heapDeltaBytes": 22252104,
"heapUsedBytes": 87458148,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.376,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2116.8589999999767,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.818000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1331.7020000000002,
"heapDeltaBytes": 24156824,
"heapUsedBytes": 90522340,
"domNodes": -271,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 657.302,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2113.586000000055,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.709999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1365.3080000000002,
"heapDeltaBytes": 22899912,
"heapUsedBytes": 89502888,
"domNodes": 6,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 673.657,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3207.414999999969,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.159999999999997,
"layouts": 60,
"layoutDurationMs": 12.639000000000001,
"taskDurationMs": 1440.1539999999998,
"heapDeltaBytes": -7813064,
"heapUsedBytes": 74486300,
"domNodes": -288,
"jsHeapTotalBytes": 3825664,
"scriptDurationMs": 608.044,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3276.411000000053,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.837000000000005,
"layouts": 60,
"layoutDurationMs": 12.802000000000001,
"taskDurationMs": 1498.1910000000003,
"heapDeltaBytes": -3017948,
"heapUsedBytes": 75248772,
"domNodes": -282,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 626.565,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2180.341999999996,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.743999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1468.664,
"heapDeltaBytes": 17573656,
"heapUsedBytes": 85837220,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 698.446,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2465.0369999999384,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.563,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1544.867,
"heapDeltaBytes": 14123780,
"heapUsedBytes": 82050672,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 756.857,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2043.5580000000186,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.6370000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.36499999999995,
"heapDeltaBytes": 9869620,
"heapUsedBytes": 87193516,
"domNodes": -267,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 28.413000000000007,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2040.0979999999436,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.8430000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 533.1779999999999,
"heapDeltaBytes": 8502044,
"heapUsedBytes": 86094640,
"domNodes": -273,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 33.53999999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 523.7889999999652,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.141999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.32800000000003,
"heapDeltaBytes": 14552168,
"heapUsedBytes": 86623660,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 110.253,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 529.3689999999742,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.676,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.7060000000001,
"heapDeltaBytes": 14197972,
"heapUsedBytes": 86603996,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 110.687,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2039.861999999971,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.431,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.50500000000005,
"heapDeltaBytes": -7106172,
"heapUsedBytes": 65012852,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.406,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.9249999999474,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.029000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.37199999999996,
"heapDeltaBytes": -4415996,
"heapUsedBytes": 61111044,
"domNodes": -297,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.503000000000001,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.956000000001,
"styleRecalcs": 79,
"styleRecalcDurationMs": 21.367000000000004,
"layouts": 18,
"layoutDurationMs": 4.079,
"taskDurationMs": 680.4250000000001,
"heapDeltaBytes": 6268928,
"heapUsedBytes": 78278528,
"domNodes": -291,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 77.68799999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.0990000000374,
"styleRecalcs": 79,
"styleRecalcDurationMs": 19.594,
"layouts": 18,
"layoutDurationMs": 3.8440000000000003,
"taskDurationMs": 660.203,
"heapDeltaBytes": -14930892,
"heapUsedBytes": 58093996,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 76.60700000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 949.5400000000132,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.896999999999995,
"layouts": 15,
"layoutDurationMs": 11.507,
"taskDurationMs": 755.085,
"heapDeltaBytes": 21868312,
"heapUsedBytes": 105861164,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 24.56200000000001,
"eventListeners": 2387,
"totalBlockingTimeMs": 123,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8196.100999999999,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.770999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4732.811,
"heapDeltaBytes": 3865460,
"heapUsedBytes": 80015588,
"domNodes": -279,
"jsHeapTotalBytes": -143360,
"scriptDurationMs": 2085.802,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8169.177999999988,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.84,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4691.008,
"heapDeltaBytes": -13793844,
"heapUsedBytes": 89521800,
"domNodes": -265,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 2100.395,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13715.426999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12793.042,
"heapDeltaBytes": -46525948,
"heapUsedBytes": 176591964,
"domNodes": -8068,
"jsHeapTotalBytes": -28581888,
"scriptDurationMs": 230.558,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13821.669000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13042.841999999999,
"heapDeltaBytes": -41873668,
"heapUsedBytes": 176301716,
"domNodes": -8068,
"jsHeapTotalBytes": -11304960,
"scriptDurationMs": 262.096,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16168.560000000014,
"styleRecalcs": 100,
"styleRecalcDurationMs": 14.793000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15657.239000000001,
"heapDeltaBytes": -22490984,
"heapUsedBytes": 188792300,
"domNodes": -8068,
"jsHeapTotalBytes": -16216064,
"scriptDurationMs": 791.345,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 16927.19899999997,
"styleRecalcs": 132,
"styleRecalcDurationMs": 17.670999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16493.188,
"heapDeltaBytes": -33010972,
"heapUsedBytes": 178413524,
"domNodes": -8068,
"jsHeapTotalBytes": -20602880,
"scriptDurationMs": 816.17,
"eventListeners": -14929,
"totalBlockingTimeMs": 112,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4774.801000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.384,
"layouts": 20,
"layoutDurationMs": 21.54099999999999,
"taskDurationMs": 4633.632,
"heapDeltaBytes": -38151332,
"heapUsedBytes": 179681068,
"domNodes": -8072,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 85.76699999999998,
"eventListeners": -14931,
"totalBlockingTimeMs": 76,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4957.232999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.73899999999999,
"layouts": 20,
"layoutDurationMs": 22.657999999999998,
"taskDurationMs": 4852.299999999999,
"heapDeltaBytes": -41585188,
"heapUsedBytes": 176362460,
"domNodes": -8067,
"jsHeapTotalBytes": 4161536,
"scriptDurationMs": 92.48700000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 122,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6614.985000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6245.194999999999,
"heapDeltaBytes": 7721520,
"heapUsedBytes": 177968572,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 97.96699999999997,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7183.384000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6812.083999999999,
"heapDeltaBytes": -1994480,
"heapUsedBytes": 176794292,
"domNodes": 0,
"jsHeapTotalBytes": -24117248,
"scriptDurationMs": 115.04999999999998,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 445.40600000004815,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.599999999999998,
"layouts": 3,
"layoutDurationMs": 1.432,
"taskDurationMs": 92.874,
"heapDeltaBytes": 4875500,
"heapUsedBytes": 73968936,
"domNodes": 147,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.108,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 93.17199999998138,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.366,
"layouts": 1,
"layoutDurationMs": 0.732,
"taskDurationMs": 62.06100000000001,
"heapDeltaBytes": 2985312,
"heapUsedBytes": 70092716,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.908,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18386 +/- ##
=============================================
Coverage ? 83.59%
=============================================
Files ? 2097
Lines ? 123952
Branches ? 31381
=============================================
Hits ? 103623
Misses ? 20151
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
… refresh (PM-1496) [cloud/1.54] (#18386) Reconnect repair qualified. Required checks passed. Authenticated reload remains open. <details><summary>Full context for agent readers</summary> Reviewed [head 1f35e0f](1f35e0f) against [tested Cloud target 9199835](9199835). The unmodified target-aware guard passed at that target: 76 successes, 12 skips, no unresolved threads or later objections. Fully paginated review and inline-comment collections are empty; issue comments contain only bots. No standing human approval is claimed. The [hosted unit job](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35700635510/job/106658136560) tested [merge b13fbb6](b13fbb6), whose parents are exactly that target and head. Its full tree equals the published head, 2ce4434. Results: 1552 frontend files, 21396 passes, six expected failures and seven skips. This includes dynamicWidgets 27, graphMutations 58, nodeDataStore 32 and materializer input-order two tests in the combined run. Required [lint](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35700635579/job/106657540942) and [browser aggregate](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35700635809/job/106664200450) passed. The newer [risk grading](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35700636057/job/106658217608) succeeded at this head; earlier cancelled risk jobs remain historical, not green evidence. The separate risk-publish step is skipped. The runtime change has the same stable patch identity as [merged source repair](#18289). The backport retained both release Pinia setup imports and the new assertion/callback imports. It preserves the source's immediate disconnect/reconnect and occupied-slot behavior, without importing unrelated main-branch changes. Prior browser evidence covers plain conversion, autogrow load and selected autogrow conversion only; unpack and authenticated in-app acceptance are not credited. The target then advanced by exactly [workflow carrier 18330](86d76db). The normal guard now refuses staleness; it has not passed at that newer target. There is zero file overlap: the target delta changes workflowStore.ts, its tests and test-only composer caret setup; this carrier changes dynamicWidgets.ts, its tests and the subgraph browser specification. The workflow delta filters missing tab entries and aligns tab reorder/navigation with that filtered list. It does not alter graph link storage, slot ordering, connection callbacks or this repair's frame lifecycle. The reconnect repair does not read those workflow-list APIs. A conflict-free merge-tree calculation produces 9757b73. This combined tree has not been executed as a new runtime; compatibility is the explicit inspected-delta judgment authorized by the coordinator, not a fabricated passing guard or repeated CI run. Justification: Necessary Cloud reconnect backport under Christian's explicit admin-merge grant and documented moving-target compatibility decision. Substantive source/backport review and exact-head required checks passed, with no recorded human objection. No new approval round or human approval is invented. Fresh target, head, reviews/comments and checks precede the merge. Authenticated edit/save/reload remains a separate open product blocker; landing does not authorize deployment or exposure widening. Carrier means release backport PR; patch identity compares code changes independently of line offsets; merge-tree checks textual integration, not runtime behavior. </details> <!-- authored-by:agent slack-claude-pilot --> <details><summary>Original author description (historical)</summary> <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789991789275729?thread_ts=1789991789.275729&cid=C0BGH348Z0C)_ Backport of [source reconnect repair](#18289) to `cloud/1.54`. Manual cherry-pick — the automated backport (run [35692714741](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35692714741)) reported a merge conflict in `src/core/graph/widgets/dynamicWidgets.test.ts`. ## Summary (from [source reconnect repair](#18289)) An autogrow image slot (e.g. `model.images.image_2`) that gets disconnected immediately after being connected — with no render frame in between, as happens when the in-app agent applies connect/disconnect CRDT ops back-to-back — was misclassified by `withComfyAutogrow`'s same-slot swap guard as the tail end of an atomic same-slot swap, so the real compaction was never scheduled. The slot stayed stuck, disconnected, in the middle of the group, and the UI refused a new link into it until a full page reload. The swap guard now tracks two things instead of relying only on "did a render frame elapse": whether the slot's own connect event has already fired (`pendingConnectionSeen`), and which specific slot is mid-swap (`swappingSlot`, scoped per-slot rather than node-wide). A disconnect arriving after its slot's connect event already fired is now correctly treated as a separate, later operation, so `autogrowInputDisconnected` runs and the group compacts back down. Scoping the guard per-slot also stops a genuine connect on a *different* slot of the same node from being mistaken for the swap's own connect and silently dropped. ## Conflict resolution Only `src/core/graph/widgets/dynamicWidgets.test.ts` conflicted, in the import block: - `cloud/1.54`'s copy of this test file already sets up `createTestingPinia`/`setActivePinia` (a `beforeEach` Pinia reset used by describe blocks not present in [source reconnect repair](#18289 diff), which `main`'s copy at the time of [source reconnect repair](#18289) didn't need. - [source reconnect repair](#18289) added `assert` (used at `assert.exists(oldLink)` / `assert.exists(newLink)`) and `useChainCallback` (used to compose `node.onConnectionsChange` in the new tests) to the `vitest`/local imports. Resolved by keeping both import sets — the existing Pinia setup imports plus the new `assert`/`useChainCallback` imports — with no other changes. `src/core/graph/widgets/dynamicWidgets.ts` (the runtime fix) and `browser_tests/tests/subgraph/subgraphConvertAutogrowInputs.spec.ts` auto-merged cleanly with no conflicts; nothing else from `main` was pulled in. No lockfile or `package.json` changes were needed. ## Verification - `pnpm vitest run src/core/graph/widgets/dynamicWidgets.test.ts` — 27 passed. - `pnpm typecheck` and `pnpm typecheck:browser` — passed (via pre-commit hook). - `pnpm exec eslint --fix` / `pnpm exec oxlint --type-aware --fix` / `pnpm exec oxfmt --write` on changed files — clean, no warnings. - `.github/scripts/check-ai-co-authors.sh` against the merge-base with `origin/cloud/1.54` — no AI co-author trailers (the inherited `Co-authored-by: Claude <noreply@anthropic.com>` trailer from the `main` squash commit was stripped via `git commit --amend`). ## Coverage note The browser test spec (`browser_tests/tests/subgraph/subgraphConvertAutogrowInputs.spec.ts`) carried over cleanly with its full diff — no browser coverage was dropped in this backport. Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01CoKpwnbrjRvnAyVd6dnPiq --- _Generated by [Claude Code](https://claude.ai/code/session_01CoKpwnbrjRvnAyVd6dnPiq)_ </details> (cherry picked from commit b06429b)
Reconnect repair qualified. Required checks passed. Authenticated reload remains open.
Full context for agent readers
Reviewed head 1f35e0f3 against tested Cloud target 91998353. The unmodified target-aware guard passed at that target: 76 successes, 12 skips, no unresolved threads or later objections. Fully paginated review and inline-comment collections are empty; issue comments contain only bots. No standing human approval is claimed.
The hosted unit job tested merge b13fbb63, whose parents are exactly that target and head. Its full tree equals the published head, 2ce44342e7f1ad35a06de4cb69cf7e98392f6fa6. Results: 1552 frontend files, 21396 passes, six expected failures and seven skips. This includes dynamicWidgets 27, graphMutations 58, nodeDataStore 32 and materializer input-order two tests in the combined run. Required lint and browser aggregate passed. The newer risk grading succeeded at this head; earlier cancelled risk jobs remain historical, not green evidence. The separate risk-publish step is skipped.
The runtime change has the same stable patch identity as merged source repair. The backport retained both release Pinia setup imports and the new assertion/callback imports. It preserves the source's immediate disconnect/reconnect and occupied-slot behavior, without importing unrelated main-branch changes. Prior browser evidence covers plain conversion, autogrow load and selected autogrow conversion only; unpack and authenticated in-app acceptance are not credited.
The target then advanced by exactly workflow carrier 18330. The normal guard now refuses staleness; it has not passed at that newer target. There is zero file overlap: the target delta changes workflowStore.ts, its tests and test-only composer caret setup; this carrier changes dynamicWidgets.ts, its tests and the subgraph browser specification. The workflow delta filters missing tab entries and aligns tab reorder/navigation with that filtered list. It does not alter graph link storage, slot ordering, connection callbacks or this repair's frame lifecycle. The reconnect repair does not read those workflow-list APIs. A conflict-free merge-tree calculation produces 9757b735cba44abb721d55a091ffc6846c8cd8f9. This combined tree has not been executed as a new runtime; compatibility is the explicit inspected-delta judgment authorized by the coordinator, not a fabricated passing guard or repeated CI run.
Justification: Necessary Cloud reconnect backport under Christian's explicit admin-merge grant and documented moving-target compatibility decision. Substantive source/backport review and exact-head required checks passed, with no recorded human objection. No new approval round or human approval is invented. Fresh target, head, reviews/comments and checks precede the merge. Authenticated edit/save/reload remains a separate open product blocker; landing does not authorize deployment or exposure widening.
Carrier means release backport PR; patch identity compares code changes independently of line offsets; merge-tree checks textual integration, not runtime behavior.
Original author description (historical)
Requested by Christian Byrne · Slack thread
Backport of source reconnect repair to
cloud/1.54. Manual cherry-pick — the automated backport (run 35692714741) reported a merge conflict insrc/core/graph/widgets/dynamicWidgets.test.ts.Summary (from source reconnect repair)
An autogrow image slot (e.g.
model.images.image_2) that gets disconnected immediately after being connected — with no render frame in between, as happens when the in-app agent applies connect/disconnect CRDT ops back-to-back — was misclassified bywithComfyAutogrow's same-slot swap guard as the tail end of an atomic same-slot swap, so the real compaction was never scheduled. The slot stayed stuck, disconnected, in the middle of the group, and the UI refused a new link into it until a full page reload.The swap guard now tracks two things instead of relying only on "did a render frame elapse": whether the slot's own connect event has already fired (
pendingConnectionSeen), and which specific slot is mid-swap (swappingSlot, scoped per-slot rather than node-wide). A disconnect arriving after its slot's connect event already fired is now correctly treated as a separate, later operation, soautogrowInputDisconnectedruns and the group compacts back down. Scoping the guard per-slot also stops a genuine connect on a different slot of the same node from being mistaken for the swap's own connect and silently dropped.Conflict resolution
Only
src/core/graph/widgets/dynamicWidgets.test.tsconflicted, in the import block:cloud/1.54's copy of this test file already sets upcreateTestingPinia/setActivePinia(abeforeEachPinia reset used by describe blocks not present in source reconnect repair's diff), whichmain's copy at the time of source reconnect repair didn't need.assert(used atassert.exists(oldLink)/assert.exists(newLink)) anduseChainCallback(used to composenode.onConnectionsChangein the new tests) to thevitest/local imports.Resolved by keeping both import sets — the existing Pinia setup imports plus the new
assert/useChainCallbackimports — with no other changes.src/core/graph/widgets/dynamicWidgets.ts(the runtime fix) andbrowser_tests/tests/subgraph/subgraphConvertAutogrowInputs.spec.tsauto-merged cleanly with no conflicts; nothing else frommainwas pulled in.No lockfile or
package.jsonchanges were needed.Verification
pnpm vitest run src/core/graph/widgets/dynamicWidgets.test.ts— 27 passed.pnpm typecheckandpnpm typecheck:browser— passed (via pre-commit hook).pnpm exec eslint --fix/pnpm exec oxlint --type-aware --fix/pnpm exec oxfmt --writeon changed files — clean, no warnings..github/scripts/check-ai-co-authors.shagainst the merge-base withorigin/cloud/1.54— no AI co-author trailers (the inheritedCo-authored-by: Claude <noreply@anthropic.com>trailer from themainsquash commit was stripped viagit commit --amend).Coverage note
The browser test spec (
browser_tests/tests/subgraph/subgraphConvertAutogrowInputs.spec.ts) carried over cleanly with its full diff — no browser coverage was dropped in this backport.Generated with Claude Code
https://claude.ai/code/session_01CoKpwnbrjRvnAyVd6dnPiq
Generated by Claude Code