Repository navigation
feat(agent): add back navigation to onboarding - #18377
christian-byrne wants to merge 3 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: 9 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 WalkthroughWalkthroughThe onboarding composable now provides backward navigation. The coach displays a Back button after the first step. Unit and browser tests verify returning to the first card without completing onboarding. ChangesOnboarding navigation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The onboarding tour adds Back navigation while preserving incomplete onboarding state, with reported unit and browser coverage and no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 5066805f4ad95987951c97d03d5cc987f9a1b95e
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2094 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.96 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.87 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 123 kB (baseline 123 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.91 MB (baseline 3.91 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 577 kB (baseline 577 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 302 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T09:25:55.077Z",
"gitSha": "b8795d4e2d0f8922435074a73999d21b56f2e59b",
"branch": "christian-byrne/pm-1374-onboarding-back",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.4710000000232,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.277999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.50200000000007,
"heapDeltaBytes": -1827284,
"heapUsedBytes": 60412392,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.534,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1991.2350000000743,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.833,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.10200000000003,
"heapDeltaBytes": 5998304,
"heapUsedBytes": 73418852,
"domNodes": -258,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.388,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1738.4009999999535,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.54,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 765.778,
"heapDeltaBytes": -12501696,
"heapUsedBytes": 54829540,
"domNodes": -259,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 141.513,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1762.2939999999971,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.738000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 780.8389999999999,
"heapDeltaBytes": 10790444,
"heapUsedBytes": 78096372,
"domNodes": -258,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 145.148,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.1190000000302,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.643,
"layouts": 6,
"layoutDurationMs": 1.2619999999999996,
"taskDurationMs": 326.14500000000004,
"heapDeltaBytes": 2227604,
"heapUsedBytes": 64443296,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.383,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.3900000000185,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.617,
"layouts": 6,
"layoutDurationMs": 1.0769999999999997,
"taskDurationMs": 323.875,
"heapDeltaBytes": 2408120,
"heapUsedBytes": 64711952,
"domNodes": 79,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.046,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 633.0389999999966,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.674,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.65900000000005,
"heapDeltaBytes": 18272168,
"heapUsedBytes": 80517912,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 157.484,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 583.9990000000626,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.053,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.42300000000006,
"heapDeltaBytes": 17926192,
"heapUsedBytes": 80201396,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 165.552,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1159.3560000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 865.3100000000001,
"heapDeltaBytes": -17343256,
"heapUsedBytes": 72691856,
"domNodes": -295,
"jsHeapTotalBytes": 19791872,
"scriptDurationMs": 60.224,
"eventListeners": -217,
"totalBlockingTimeMs": 519,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1143.416000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 811.755,
"heapDeltaBytes": 12662876,
"heapUsedBytes": 84211748,
"domNodes": 0,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 60.29000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 531,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.4620000000309,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.94200000000006,
"heapDeltaBytes": 14472464,
"heapUsedBytes": 90056948,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.35000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.6669999999349,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.4769999999998,
"heapDeltaBytes": 14652956,
"heapUsedBytes": 91021080,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 140.02100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8887.464999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8017.614,
"heapDeltaBytes": -10891616,
"heapUsedBytes": 71617988,
"domNodes": -22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 6412.116,
"eventListeners": 0,
"totalBlockingTimeMs": 276,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9053.629,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8206.008,
"heapDeltaBytes": 13803216,
"heapUsedBytes": 95848936,
"domNodes": -16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 6632.988,
"eventListeners": 0,
"totalBlockingTimeMs": 156,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8660.515000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7940.125,
"heapDeltaBytes": 12058692,
"heapUsedBytes": 94088200,
"domNodes": -16,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 6381.625,
"eventListeners": 0,
"totalBlockingTimeMs": 334,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9164.222000000109,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8334.251999999999,
"heapDeltaBytes": 17375484,
"heapUsedBytes": 93346520,
"domNodes": -12,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 6685.151,
"eventListeners": 0,
"totalBlockingTimeMs": 128,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2056.8080000000464,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.355999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.7599999999999,
"heapDeltaBytes": -8713708,
"heapUsedBytes": 78589892,
"domNodes": -251,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 38.236999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.2250000000777,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.633,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576,
"heapDeltaBytes": -3294028,
"heapUsedBytes": 83529752,
"domNodes": -242,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 33.722,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2209.640000000036,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.358999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1587.8770000000002,
"heapDeltaBytes": -3927588,
"heapUsedBytes": 84264924,
"domNodes": -251,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 801.772,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2237.62899999997,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.229000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1603.938,
"heapDeltaBytes": -11798780,
"heapUsedBytes": 76569940,
"domNodes": -218,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 809.7,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3502.96800000001,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.53,
"layouts": 60,
"layoutDurationMs": 14.619,
"taskDurationMs": 1563.205,
"heapDeltaBytes": -79048,
"heapUsedBytes": 89683484,
"domNodes": -264,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 778.1519999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3516.326000000049,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.559999999999999,
"layouts": 60,
"layoutDurationMs": 14.188,
"taskDurationMs": 1645.9660000000001,
"heapDeltaBytes": 8134664,
"heapUsedBytes": 74472716,
"domNodes": -247,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 775.409,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3086.7959999999925,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.416999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1980.3570000000002,
"heapDeltaBytes": 2965452,
"heapUsedBytes": 88838984,
"domNodes": -252,
"jsHeapTotalBytes": 446464,
"scriptDurationMs": 1003.654,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3073.7839999999323,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.938,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1900.914,
"heapDeltaBytes": 30416536,
"heapUsedBytes": 96212524,
"domNodes": 6,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1014.411,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2021.6729999999643,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.119000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.5980000000002,
"heapDeltaBytes": -5245376,
"heapUsedBytes": 84149808,
"domNodes": -247,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 32.50800000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.5080000000262,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.724,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.497,
"heapDeltaBytes": -5568444,
"heapUsedBytes": 84166032,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.178,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.7629999999854,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.848,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.15900000000005,
"heapDeltaBytes": 13644300,
"heapUsedBytes": 83409892,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 143.66500000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.5070000000396,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.485,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.13200000000006,
"heapDeltaBytes": 12784420,
"heapUsedBytes": 76622840,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 145.954,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1992.1809999999596,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.7810000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.9040000000001,
"heapDeltaBytes": -4976960,
"heapUsedBytes": 64742596,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.188,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.846000000024,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.724,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.507,
"heapDeltaBytes": 11742176,
"heapUsedBytes": 81152940,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.146999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.9309999999973,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.597999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 685.89,
"heapDeltaBytes": 11013592,
"heapUsedBytes": 80454972,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 91.609,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.60299999992,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.118000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.314,
"heapDeltaBytes": 8164152,
"heapUsedBytes": 77845548,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 96.466,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.0980000000318,
"styleRecalcs": 18,
"styleRecalcDurationMs": 27.321999999999992,
"layouts": 5,
"layoutDurationMs": 11.635000000000002,
"taskDurationMs": 877.4259999999998,
"heapDeltaBytes": 20265812,
"heapUsedBytes": 103395780,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 29.375999999999994,
"eventListeners": 2383,
"totalBlockingTimeMs": 123,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8272.14399999997,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.373000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5532.785,
"heapDeltaBytes": -10635020,
"heapUsedBytes": 76407784,
"domNodes": -243,
"jsHeapTotalBytes": 1007616,
"scriptDurationMs": 2643.37,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8181.500000000028,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.979,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5440.870999999999,
"heapDeltaBytes": -10953316,
"heapUsedBytes": 76135516,
"domNodes": -240,
"jsHeapTotalBytes": -827392,
"scriptDurationMs": 2621.16,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16814.11300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16525.561,
"heapDeltaBytes": -51808056,
"heapUsedBytes": 170966668,
"domNodes": -8061,
"jsHeapTotalBytes": -18792448,
"scriptDurationMs": 269.51,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17240.35500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16793.146,
"heapDeltaBytes": -61905204,
"heapUsedBytes": 177822920,
"domNodes": -8062,
"jsHeapTotalBytes": -16683008,
"scriptDurationMs": 271.513,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21448.217,
"styleRecalcs": 159,
"styleRecalcDurationMs": 19.175000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21129.803,
"heapDeltaBytes": -53851148,
"heapUsedBytes": 180917240,
"domNodes": -8061,
"jsHeapTotalBytes": -11575296,
"scriptDurationMs": 895.079,
"eventListeners": -14928,
"totalBlockingTimeMs": 78,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20498.630999999932,
"styleRecalcs": 151,
"styleRecalcDurationMs": 17.95800000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20262.321999999996,
"heapDeltaBytes": -68050356,
"heapUsedBytes": 167447380,
"domNodes": -8061,
"jsHeapTotalBytes": -12181504,
"scriptDurationMs": 856.0369999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 52,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6185.539999999946,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.89500000000001,
"layouts": 20,
"layoutDurationMs": 24.128999999999998,
"taskDurationMs": 6133.6410000000005,
"heapDeltaBytes": -66082868,
"heapUsedBytes": 175897120,
"domNodes": -8061,
"jsHeapTotalBytes": 10153984,
"scriptDurationMs": 110.50099999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 394,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6119.4940000000315,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.01599999999999,
"layouts": 20,
"layoutDurationMs": 24.124000000000006,
"taskDurationMs": 6073.776,
"heapDeltaBytes": -49035712,
"heapUsedBytes": 176726288,
"domNodes": -8061,
"jsHeapTotalBytes": 15618048,
"scriptDurationMs": 110.349,
"eventListeners": -14928,
"totalBlockingTimeMs": 376,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8663.68799999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8478.175000000001,
"heapDeltaBytes": -13210292,
"heapUsedBytes": 177088748,
"domNodes": 0,
"jsHeapTotalBytes": -18087936,
"scriptDurationMs": 128.07200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8460.493999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8269.642,
"heapDeltaBytes": 2188904,
"heapUsedBytes": 190755820,
"domNodes": 0,
"jsHeapTotalBytes": -19136512,
"scriptDurationMs": 129.49099999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 486.4230000000589,
"styleRecalcs": 22,
"styleRecalcDurationMs": 28.218,
"layouts": 3,
"layoutDurationMs": 1.7460000000000002,
"taskDurationMs": 141.614,
"heapDeltaBytes": 5172648,
"heapUsedBytes": 67067156,
"domNodes": 151,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 14.746,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 99.91100000002007,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.671000000000001,
"layouts": 3,
"layoutDurationMs": 1.5370000000000001,
"taskDurationMs": 71.27300000000001,
"heapDeltaBytes": 2998908,
"heapUsedBytes": 67623684,
"domNodes": 125,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.537000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18377 +/- ##
==========================================
+ Coverage 83.35% 84.33% +0.98%
==========================================
Files 2998 2283 -715
Lines 147088 129869 -17219
Branches 38033 35126 -2907
==========================================
- Hits 122606 109529 -13077
+ Misses 23193 20045 -3148
+ Partials 1289 295 -994
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 749 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
…omfy-Org#18911) ## Summary Make the agent onboarding tour easier to follow. The tour gets clearer focus, a Back button, a replay button, and copy that matches automatic workflow targeting. Depends on Comfy-Org#18377. Merge Comfy-Org#18377 first. This branch contains the commits from Comfy-Org#18377. ## Changes - **What**: - Add a 2px border around the onboarding spotlight. - Add Back navigation to the cards (from Comfy-Org#18377). The Back button is at the left edge of the card. - In step 4, show the chat history button in its hover state, with its tooltip. The spotlight covers the button and the tooltip. - Show the chat history tooltip to the right of the button, in the tour and on hover. - Add an info button next to the Comfy Agent title. The button starts the tour again from the first card. - Rewrite the step 2 copy. The agent follows the visible tab, so the card does not tell the user to select a workflow. - Wrap card text with `text-pretty`. This prevents a single word on the last line. - Fix the shared tooltip arrow. The arrow colored only its top edge. Tooltips on the right, left, or bottom showed half a triangle. ## Review Focus - The arrow fix changes `buildTooltipConfig` and `useNodeTooltips`. About 15 components use these. Arrows on tooltips that are not above their target now use the tooltip border color. - The step 4 tooltip is a copy that the tour draws. The real PrimeVue tooltip shows only on mouse hover, and it is below the dark overlay. Both use `TOOLTIP_TEXT_CLASS`. - The info button removes the seen flag from local storage. Then it remounts `OnboardingCoach`. If the tour is paused (for example, in App Mode), the tour starts when the pause ends. - Each restart sends the onboarding shown telemetry event again. - This PR does not include the step 3 visibility item from DES-1208. Linear: [DES-1208](https://linear.app/comfyorg/issue/DES-1208/des-design-onboarding-card-navigation-and-step-focus). Parent: [PM-1374](https://linear.app/comfyorg/issue/PM-1374/test-onboarding-cards-need-a-back-button-and-clearer-step-3-and-step-4). ## Screenshots (if applicable) | Change | Before | After | |---|---|---| | Step 2: copy, Back button, spotlight border | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/step2-before.png" width="420" alt="Step 2 card before"> | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/0797967f2d4bcec33325f95d61c28653a73e066f/.github/pr-images/des-1208/step2-after-v2.png" width="420" alt="Step 2 card after"> | | Step 4: hover state, tooltip, spotlight border, text wrap | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/step4-before.png" width="300" alt="Step 4 card before"> | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/step4-after.png" width="400" alt="Step 4 card after"> | | Header: info button with tooltip | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/header-before.png" width="340" alt="Panel header before"> | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/header-after.png" width="340" alt="Panel header after, info button hovered"> | | Chat history tooltip on hover | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/history-tooltip-before.png" width="150" alt="History tooltip before, below the button"> | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/history-tooltip-after.png" width="190" alt="History tooltip after, right of the button"> | --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: GitHub Action <action@github.com>
…18911) Make the agent onboarding tour easier to follow. The tour gets clearer focus, a Back button, a replay button, and copy that matches automatic workflow targeting. Depends on #18377. Merge #18377 first. This branch contains the commits from #18377. - **What**: - Add a 2px border around the onboarding spotlight. - Add Back navigation to the cards (from #18377). The Back button is at the left edge of the card. - In step 4, show the chat history button in its hover state, with its tooltip. The spotlight covers the button and the tooltip. - Show the chat history tooltip to the right of the button, in the tour and on hover. - Add an info button next to the Comfy Agent title. The button starts the tour again from the first card. - Rewrite the step 2 copy. The agent follows the visible tab, so the card does not tell the user to select a workflow. - Wrap card text with `text-pretty`. This prevents a single word on the last line. - Fix the shared tooltip arrow. The arrow colored only its top edge. Tooltips on the right, left, or bottom showed half a triangle. - The arrow fix changes `buildTooltipConfig` and `useNodeTooltips`. About 15 components use these. Arrows on tooltips that are not above their target now use the tooltip border color. - The step 4 tooltip is a copy that the tour draws. The real PrimeVue tooltip shows only on mouse hover, and it is below the dark overlay. Both use `TOOLTIP_TEXT_CLASS`. - The info button removes the seen flag from local storage. Then it remounts `OnboardingCoach`. If the tour is paused (for example, in App Mode), the tour starts when the pause ends. - Each restart sends the onboarding shown telemetry event again. - This PR does not include the step 3 visibility item from DES-1208. Linear: [DES-1208](https://linear.app/comfyorg/issue/DES-1208/des-design-onboarding-card-navigation-and-step-focus). Parent: [PM-1374](https://linear.app/comfyorg/issue/PM-1374/test-onboarding-cards-need-a-back-button-and-clearer-step-3-and-step-4). | Change | Before | After | |---|---|---| | Step 2: copy, Back button, spotlight border | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/step2-before.png" width="420" alt="Step 2 card before"> | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/0797967f2d4bcec33325f95d61c28653a73e066f/.github/pr-images/des-1208/step2-after-v2.png" width="420" alt="Step 2 card after"> | | Step 4: hover state, tooltip, spotlight border, text wrap | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/step4-before.png" width="300" alt="Step 4 card before"> | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/step4-after.png" width="400" alt="Step 4 card after"> | | Header: info button with tooltip | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/header-before.png" width="340" alt="Panel header before"> | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/header-after.png" width="340" alt="Panel header after, info button hovered"> | | Chat history tooltip on hover | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/history-tooltip-before.png" width="150" alt="History tooltip before, below the button"> | <img src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/uy/DES-1208/pr-images/.github/pr-images/des-1208/history-tooltip-after.png" width="190" alt="History tooltip after, right of the button"> | --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit ffc6359)
|
Sorry for the late review on this one. It looks superseded by #18911, which carried these commits and merged on 2026-09-27: |
Pull request was closed
Summary
Testing
pnpm vitest run src/workbench/extensions/agent/components/agent/OnboardingCoach.test.ts(12 passed)pnpm typecheckbrowser_tests/tests/agent/agentOnboarding.spec.tsverifies Back is absent on the first card, returns from the second card to the first, and does not complete the tour1ec7bf1bd8a8f88279680176f62c0f6de63ee50d: 86 successful checks, 16 intentional skips, zero pending checks, zero adverse conclusionsLinear: PM-1371, PM-1374