Skip to content

[backport cloud/1.53] fix: avoid unpolyfilled ES2023 array methods in runtime code - #18359

Merged
DrJKL merged 1 commit into
cloud/1.53from
backport-18251-to-cloud-1.53
Sep 22, 2026
Merged

DrJKL merged 1 commit into
cloud/1.53from
backport-18251-to-cloud-1.53

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #18251 to cloud/1.53. Runtime toReversed / toSorted / toSpliced calls are replaced with copies that work on browsers lacking those newer array methods. Fixes the x.toReversed is not a function errors on 1.53.x tracked in Sentry as FRONTEND-6J and FRONTEND-7X.

Full context for agent readers

Differences from the main-branch PR, on purpose:

  • The new ESLint rule (es2022-compat/no-array-copy-method), its test, and the @typescript-eslint/utils dependency are not included. The cherry-picked lockfile hunks referenced @typescript-eslint/utils@8.69.0 and eslint@10.10.0, which do not exist in this branch's lockfile (it has 8.67.0 and 10.8.1), so a frozen-lockfile install would fail. The rule is a CI guard that main already enforces on anything that later gets backported; the release branch only needs the runtime fix.
  • Conflict resolution: src/utils/requestUtil.ts and src/workbench/extensions/agent/components/agent/Composer.test.ts were hand-merged onto the cloud/1.53 versions. Files that only exist on main (requestUtil.ts, useAgentMentionPicker.ts, useAgentWorkflowResolver.ts, crdtDebugReport*.ts, requestUtil.test.ts) were dropped.
  • Extra 1.53-only call sites fixed: Composer.vue had three toSorted uses that main had already moved into composables; replaced with [...x].sort(...), or .sort(...) where the receiver is a fresh array literal.
  • git grep confirms no remaining .toSorted(, .toReversed(, or .toSpliced( in non-test files under src/ on this branch.

Verification: relies on CI (lint, typecheck, unit tests). No local checks were run on the authoring host.

Fixes
[FRONTEND-6J](https://comfy-org.sentry.io/issues/?query=FRONTEND-6J)
(`TypeError: x.toReversed is not a function`).

Runtime code under `src/` used ES2023 array-copy methods while the Vite
build target is `es2022`, so engines without those methods could throw
at runtime. This change:

- replaces those calls with ES2022-safe non-mutating equivalents;
- adds a type-aware ESLint rule that rejects `toReversed`, `toSorted`,
`toSpliced`, and `with` on array and typed-array receivers in non-test
files under `src/`;
- verifies dotted, computed, template, aliased, generic, intersection,
nullable, mixed-union, and typed-array forms while allowing unrelated
APIs with the same method names; and
- adds representative assertions that request parameters, output arrays,
mention nodes, and retained agent messages are not mutated.

The existing loader in `src/lib/litegraph/src/polyfills.ts` is
LiteGraph-local, does not polyfill these array methods, and is not an
app-wide compatibility boundary. This PR keeps the current browser
target rather than broadening that loader or changing the target.

No Playwright test is included because current Chromium implements these
methods. The type-aware lint test supplies the regression boundary
independently of browser support.

Verification:

- `pnpm exec vitest run tools/eslint-plugins/es2023ArrayMethods.test.ts
src/utils/requestUtil.test.ts
src/platform/assets/utils/outputAssetUtil.test.ts
src/renderer/extensions/linearMode/useOutputHistory.test.ts
src/workbench/extensions/agent/components/agent/Composer.test.ts
src/workbench/extensions/agent/crdt/crdtDebugReport.test.ts` — 6 files,
198 tests passed
- `pnpm typecheck`
- `pnpm typecheck:tools`
- changed-file ESLint and oxfmt checks
- `pnpm oxlint:main` — passed with existing warnings
- `pnpm knip`

Linear: [FE-2554](https://linear.app/comfyorg/issue/FE-2554). Needs
backport to `core/1.53`.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Amp <amp@ampcode.com>
@christian-byrne
christian-byrne requested a review from a team as a code owner September 22, 2026 04:35
@vercel

vercel Bot commented Sep 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 22, 2026 4:35am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: f4bc4b0c-5b6f-45eb-8452-6fbe7d280ec4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/22/2026, 04:54:52 AM UTC

Links

🎭 Playwright: ✅ 1903 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1882 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 145ms TBT · 92.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.9 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.9 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 118ms TBT · 174.8 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 624ms TBT · 171.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 632ms
canvas-idle: script duration 13ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.5 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -172
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 42ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 964ms
canvas-mouse-sweep: script duration 169ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.4 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -155
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 20ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 433ms
canvas-zoom-sweep: script duration 16ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.6 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 21
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 497ms
dom-widget-clipping: script duration 170ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 71.9 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 738ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.5 MB
large-graph-idle: DOM nodes -271
large-graph-idle: event listeners -168
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 63
large-graph-pan: task duration 1778ms
large-graph-pan: script duration 877ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 85.7 MB
large-graph-pan: DOM nodes -140
large-graph-pan: event listeners 7
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1886ms
large-graph-zoom: script duration 853ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.1 MB
large-graph-zoom: DOM nodes -140
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 2056ms
legacy-node-drag: script duration 1010ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 81.1 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 715ms
minimap-idle: script duration 42ms
minimap-idle: TBT 0ms
minimap-idle: heap used 82.9 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -168
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 458ms
subgraph-dom-widget-clipping: script duration 151ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.3 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 597ms
subgraph-idle: script duration 12ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.2 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -201
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 42ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 940ms
subgraph-mouse-sweep: script duration 127ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.0 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1033ms
subgraph-transition-enter: script duration 36ms
subgraph-transition-enter: TBT 145ms
subgraph-transition-enter: heap used 92.8 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 6504ms
viewport-pan-sweep: script duration 2942ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.9 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -134
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17706ms
vue-large-graph-idle: script duration 325ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 168.9 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7475
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 23ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 167
vue-large-graph-pan: task duration 21745ms
vue-large-graph-pan: script duration 988ms
vue-large-graph-pan: TBT 118ms
vue-large-graph-pan: heap used 174.8 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7468
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 32ms
vue-node-resize-workload: style recalc duration 95ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6465ms
vue-node-resize-workload: script duration 118ms
vue-node-resize-workload: TBT 624ms
vue-node-resize-workload: heap used 171.2 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7470
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 30ms
workflow-execution: layout count 4
workflow-execution: style recalc count 16
workflow-execution: task duration 150ms
workflow-execution: script duration 12ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.0 MB
workflow-execution: DOM nodes 136
workflow-execution: event listeners 98
Raw data
{
  "timestamp": "2026-09-22T05:00:32.585Z",
  "gitSha": "784532d0a95221516058804dd9b51fb3e1091f1d",
  "branch": "backport-18251-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2095.9330000000023,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.119000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 665.146,
      "heapDeltaBytes": -3189496,
      "heapUsedBytes": 66616096,
      "domNodes": -279,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 12.694999999999999,
      "eventListeners": -189,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2051.9110000000182,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.931999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 599.5680000000001,
      "heapDeltaBytes": -10013908,
      "heapUsedBytes": 60330216,
      "domNodes": -283,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 12.365999999999998,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1898.5460000000103,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 40.508,
      "layouts": 14,
      "layoutDurationMs": 4.45,
      "taskDurationMs": 957.172,
      "heapDeltaBytes": -8058104,
      "heapUsedBytes": 62263764,
      "domNodes": -281,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 166.086,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1912.5260000000708,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 44.369,
      "layouts": 14,
      "layoutDurationMs": 4.843,
      "taskDurationMs": 970.38,
      "heapDeltaBytes": -7976196,
      "heapUsedBytes": 62276508,
      "domNodes": -280,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 171.6,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.117000000012,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 19.819,
      "layouts": 6,
      "layoutDurationMs": 1.1480000000000001,
      "taskDurationMs": 420.38800000000003,
      "heapDeltaBytes": 4387744,
      "heapUsedBytes": 74967724,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 15.408000000000005,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1729.7399999999925,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 19.373999999999995,
      "layouts": 6,
      "layoutDurationMs": 1.2279999999999998,
      "taskDurationMs": 444.70400000000006,
      "heapDeltaBytes": 4395596,
      "heapUsedBytes": 75103992,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 16.395000000000003,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 703.9710000000241,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.946000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.332,
      "heapDeltaBytes": -7775444,
      "heapUsedBytes": 62803428,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 167.652,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 765.7530000000179,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.751,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 505.46500000000003,
      "heapDeltaBytes": 18472132,
      "heapUsedBytes": 87986368,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 173.066,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2060.3629999999953,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 9.496,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 742.663,
      "heapDeltaBytes": 10457416,
      "heapUsedBytes": 86037552,
      "domNodes": -271,
      "jsHeapTotalBytes": -1392640,
      "scriptDurationMs": 34.779999999999994,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.4409999999634,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 5.202999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 734.3029999999999,
      "heapDeltaBytes": -14054172,
      "heapUsedBytes": 86981488,
      "domNodes": -271,
      "jsHeapTotalBytes": -1617920,
      "scriptDurationMs": 38.413000000000004,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2533.594999999991,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 10.294999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1727.6349999999998,
      "heapDeltaBytes": 22683912,
      "heapUsedBytes": 88569812,
      "domNodes": -280,
      "jsHeapTotalBytes": 1273856,
      "scriptDurationMs": 856.414,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2859.9779999999555,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 9.004000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1828.9550000000002,
      "heapDeltaBytes": 24754740,
      "heapUsedBytes": 91094744,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 897.301,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3864.6659999999997,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.532999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.41,
      "taskDurationMs": 1850.9700000000003,
      "heapDeltaBytes": 9332412,
      "heapUsedBytes": 76843912,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 862.9839999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3902.2169999999505,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.806000000000003,
      "layouts": 60,
      "layoutDurationMs": 13.119,
      "taskDurationMs": 1921.291,
      "heapDeltaBytes": 9754248,
      "heapUsedBytes": 76398548,
      "domNodes": -279,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 842.712,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3169.304000000011,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.2180000000000035,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2010.6420000000003,
      "heapDeltaBytes": 17718940,
      "heapUsedBytes": 84767680,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 983.3170000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3244.4960000000265,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.311999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2100.5789999999997,
      "heapDeltaBytes": 17419836,
      "heapUsedBytes": 85286576,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 1036.4419999999998,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2047.2500000000196,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.457,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 697.0459999999999,
      "heapDeltaBytes": 10700588,
      "heapUsedBytes": 86692244,
      "domNodes": -272,
      "jsHeapTotalBytes": -1916928,
      "scriptDurationMs": 39.663000000000004,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2005.9929999999895,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.2200000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 732.204,
      "heapDeltaBytes": 21854584,
      "heapUsedBytes": 87171336,
      "domNodes": -272,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 43.99699999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 672.4639999999908,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.633000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 441.734,
      "heapDeltaBytes": 14830276,
      "heapUsedBytes": 87499884,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 145.132,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 725.2509999999575,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 473.873,
      "heapDeltaBytes": 14844320,
      "heapUsedBytes": 87225100,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 157.382,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.7960000000326,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.800000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 578.7220000000001,
      "heapDeltaBytes": -7117620,
      "heapUsedBytes": 65640116,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 11.649,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.930999999976,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.769,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 614.705,
      "heapDeltaBytes": -10117224,
      "heapUsedBytes": 62711824,
      "domNodes": -298,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 12.308000000000003,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1742.1410000000037,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 41.809,
      "layouts": 18,
      "layoutDurationMs": 6.248000000000001,
      "taskDurationMs": 908.758,
      "heapDeltaBytes": -12865048,
      "heapUsedBytes": 59826836,
      "domNodes": -296,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 125.057,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1787.1119999999792,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 41.915,
      "layouts": 18,
      "layoutDurationMs": 6.258,
      "taskDurationMs": 972.189,
      "heapDeltaBytes": -10859980,
      "heapUsedBytes": 61867948,
      "domNodes": -298,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 128.636,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1418.6460000000807,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 32.995999999999995,
      "layouts": 14,
      "layoutDurationMs": 16.021,
      "taskDurationMs": 1033.153,
      "heapDeltaBytes": 111700,
      "heapUsedBytes": 97326172,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 36.207,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 145,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9605.709999999988,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 36.826,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6356.392,
      "heapDeltaBytes": 24016332,
      "heapUsedBytes": 89030108,
      "domNodes": -271,
      "jsHeapTotalBytes": 192512,
      "scriptDurationMs": 2892.7709999999997,
      "eventListeners": -135,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10446.970999999961,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 40.403000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6651.847,
      "heapDeltaBytes": -11930968,
      "heapUsedBytes": 89000700,
      "domNodes": -271,
      "jsHeapTotalBytes": -1425408,
      "scriptDurationMs": 2991.886,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18264.560000000016,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17877.525999999998,
      "heapDeltaBytes": -29360344,
      "heapUsedBytes": 178559076,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2756608,
      "scriptDurationMs": 336.771,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18240.42899999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17533.579,
      "heapDeltaBytes": -32767968,
      "heapUsedBytes": 175648712,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3018752,
      "scriptDurationMs": 314.05899999999997,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21852.74700000002,
      "styleRecalcs": 166,
      "styleRecalcDurationMs": 22.078000000000042,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21599.502999999997,
      "heapDeltaBytes": -26371112,
      "heapUsedBytes": 175938312,
      "domNodes": -6548,
      "jsHeapTotalBytes": 782336,
      "scriptDurationMs": 970.0799999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 194,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22044.183999999972,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 23.446000000000023,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21891.086000000003,
      "heapDeltaBytes": -11371284,
      "heapUsedBytes": 190636508,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1499136,
      "scriptDurationMs": 1006.5789999999998,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 41,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6491.331000000002,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 101.31499999999998,
      "layouts": 20,
      "layoutDurationMs": 36.379,
      "taskDurationMs": 6419.237,
      "heapDeltaBytes": -23871844,
      "heapUsedBytes": 178820888,
      "domNodes": -6548,
      "jsHeapTotalBytes": 5287936,
      "scriptDurationMs": 113.46,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 681,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6610.62000000004,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 89.65200000000002,
      "layouts": 20,
      "layoutDurationMs": 27.513999999999996,
      "taskDurationMs": 6511.495,
      "heapDeltaBytes": -22119032,
      "heapUsedBytes": 180201684,
      "domNodes": -6548,
      "jsHeapTotalBytes": 17559552,
      "scriptDurationMs": 122.85100000000001,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 567,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 493.49900000004254,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 24.296,
      "layouts": 3,
      "layoutDurationMs": 1.7650000000000001,
      "taskDurationMs": 141.12599999999998,
      "heapDeltaBytes": 5318684,
      "heapUsedBytes": 72911736,
      "domNodes": 151,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 13.479,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 506.8989999999758,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 35.709,
      "layouts": 4,
      "layoutDurationMs": 1.9899999999999995,
      "taskDurationMs": 158.78499999999997,
      "heapDeltaBytes": 5074128,
      "heapUsedBytes": 73857048,
      "domNodes": 121,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 11.279999999999998,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48223 70921 68.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.2% 1185
src/LGraphNode.ts 69.5% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.1% 305
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.4% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 45.0% 203

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 22, 2026
@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #18359   +/-   ##
=============================================
  Coverage              ?   83.42%           
=============================================
  Files                 ?     2028           
  Lines                 ?   117787           
  Branches              ?    34538           
=============================================
  Hits                  ?    98261           
  Misses                ?    19177           
  Partials              ?      349           
Flag Coverage Δ
e2e 66.50% <66.66%> (?)
unit 76.82% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/composables/queue/useQueueNotificationBanners.ts 94.82% <100.00%> (ø)
src/lib/litegraph/src/LGraphNode.ts 69.28% <100.00%> (ø)
src/lib/litegraph/src/node/slotLinks.ts 94.25% <100.00%> (ø)
src/lib/litegraph/src/subgraph/SubgraphNode.ts 89.85% <ø> (ø)
src/platform/assets/utils/assetMetadataUtils.ts 93.85% <100.00%> (ø)
src/platform/assets/utils/outputAssetUtil.ts 100.00% <ø> (ø)
...renderer/extensions/linearMode/useOutputHistory.ts 92.78% <100.00%> (ø)
...nch/extensions/agent/components/agent/Composer.vue 99.11% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL
DrJKL merged commit 7da74d4 into cloud/1.53 Sep 22, 2026
100 checks passed
@DrJKL
DrJKL deleted the backport-18251-to-cloud-1.53 branch September 22, 2026 18:00
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components and removed agent Comfy Agent product, integration, tests or product documentation agent-test-unit Touches Agent-related unit/component tests or their support agent-session Agent sessions, history, turn lifecycle or workflow binding agent-ui Agent panel, composer, transcript or other user-interface components agent-backport Agent changes targeting a stable cloud/core release branch labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants