Repository navigation
[backport core/1.53] fix: avoid unpolyfilled ES2023 array methods in runtime code - #18358
Conversation
Fixes [FRONTEND-6J](https://comfy-org.sentry.io/issues/?query=FRONTEND-6J) (`TypeError: x.toReversed is not a function`). Runtime code under `src/` used ES2023 array-copy methods while the Vite build target is `es2022`, so engines without those methods could throw at runtime. This change: - replaces those calls with ES2022-safe non-mutating equivalents; - adds a type-aware ESLint rule that rejects `toReversed`, `toSorted`, `toSpliced`, and `with` on array and typed-array receivers in non-test files under `src/`; - verifies dotted, computed, template, aliased, generic, intersection, nullable, mixed-union, and typed-array forms while allowing unrelated APIs with the same method names; and - adds representative assertions that request parameters, output arrays, mention nodes, and retained agent messages are not mutated. The existing loader in `src/lib/litegraph/src/polyfills.ts` is LiteGraph-local, does not polyfill these array methods, and is not an app-wide compatibility boundary. This PR keeps the current browser target rather than broadening that loader or changing the target. No Playwright test is included because current Chromium implements these methods. The type-aware lint test supplies the regression boundary independently of browser support. Verification: - `pnpm exec vitest run tools/eslint-plugins/es2023ArrayMethods.test.ts src/utils/requestUtil.test.ts src/platform/assets/utils/outputAssetUtil.test.ts src/renderer/extensions/linearMode/useOutputHistory.test.ts src/workbench/extensions/agent/components/agent/Composer.test.ts src/workbench/extensions/agent/crdt/crdtDebugReport.test.ts` — 6 files, 198 tests passed - `pnpm typecheck` - `pnpm typecheck:tools` - changed-file ESLint and oxfmt checks - `pnpm oxlint:main` — passed with existing warnings - `pnpm knip` Linear: [FE-2554](https://linear.app/comfyorg/issue/FE-2554). Needs backport to `core/1.53`. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1905 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T04:53:18.970Z",
"gitSha": "f6aa0c0b960b7d48212cee87284b0890ec9497a8",
"branch": "backport-18251-to-core-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.9979999999773,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.293000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.5260000000001,
"heapDeltaBytes": 4851720,
"heapUsedBytes": 73886788,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.749000000000002,
"eventListeners": -189,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2005.5949999999712,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.5749999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.13599999999997,
"heapDeltaBytes": 11134748,
"heapUsedBytes": 80975976,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.0189999999999975,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1834.5520000000306,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.943,
"layouts": 14,
"layoutDurationMs": 4.372,
"taskDurationMs": 900.0020000000001,
"heapDeltaBytes": -10757604,
"heapUsedBytes": 58876144,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 139.804,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.1850000000022,
"styleRecalcs": 74,
"styleRecalcDurationMs": 28.467,
"layouts": 14,
"layoutDurationMs": 3.7020000000000004,
"taskDurationMs": 682.0840000000001,
"heapDeltaBytes": 2934824,
"heapUsedBytes": 73787300,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 112.434,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.0489999999836,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.548000000000002,
"layouts": 6,
"layoutDurationMs": 1.0829999999999997,
"taskDurationMs": 347.06899999999996,
"heapDeltaBytes": 4392828,
"heapUsedBytes": 75264804,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 13.245999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1659.2990000000327,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.241,
"layouts": 6,
"layoutDurationMs": 0.9129999999999999,
"taskDurationMs": 287.813,
"heapDeltaBytes": 4336460,
"heapUsedBytes": 74994736,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.392000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 565.3290000000197,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.0740000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.834,
"heapDeltaBytes": -8101284,
"heapUsedBytes": 62654452,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 130.22899999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 526.6820000000507,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.0169999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.996,
"heapDeltaBytes": -8066316,
"heapUsedBytes": 62648820,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 121.133,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2037.665000000061,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.204000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 635.4000000000001,
"heapDeltaBytes": 10583532,
"heapUsedBytes": 86509884,
"domNodes": -268,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 32.131,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2031.0690000000022,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.853,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.1460000000001,
"heapDeltaBytes": 11009748,
"heapUsedBytes": 85858816,
"domNodes": -269,
"jsHeapTotalBytes": -1654784,
"scriptDurationMs": 33.016000000000005,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2434.286000000043,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.871000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1437.7679999999998,
"heapDeltaBytes": 8510160,
"heapUsedBytes": 84524676,
"domNodes": -277,
"jsHeapTotalBytes": -1167360,
"scriptDurationMs": 658.664,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2113.426000000004,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.536999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1275.219,
"heapDeltaBytes": -16962548,
"heapUsedBytes": 84916460,
"domNodes": -273,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 621.659,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3303.5529999999653,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.469999999999999,
"layouts": 60,
"layoutDurationMs": 12.664000000000001,
"taskDurationMs": 1513.238,
"heapDeltaBytes": 9878092,
"heapUsedBytes": 76677916,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 657.666,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3177.441999999928,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.914000000000003,
"layouts": 60,
"layoutDurationMs": 11.45,
"taskDurationMs": 1374.045,
"heapDeltaBytes": 8487480,
"heapUsedBytes": 75973952,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 617.488,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2548.048999999992,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.798000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1691.1809999999998,
"heapDeltaBytes": 17471448,
"heapUsedBytes": 85007628,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 816.646,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2367.8370000000086,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.012000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1519.727,
"heapDeltaBytes": 13899756,
"heapUsedBytes": 80972356,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 753.415,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2044.6719999999914,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.733,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.6290000000001,
"heapDeltaBytes": 10404396,
"heapUsedBytes": 87122464,
"domNodes": -272,
"jsHeapTotalBytes": -1916928,
"scriptDurationMs": 32.332,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1996.8569999999772,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.9920000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.094,
"heapDeltaBytes": 21745484,
"heapUsedBytes": 87501148,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.403000000000002,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 557.8040000000328,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.815000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.55199999999996,
"heapDeltaBytes": 14851188,
"heapUsedBytes": 87532108,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 122.732,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.3720000000612,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.132,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.40000000000003,
"heapDeltaBytes": 14812856,
"heapUsedBytes": 87556168,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 115.34800000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.8800000000042,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.352,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.159,
"heapDeltaBytes": -12597028,
"heapUsedBytes": 59345480,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.297,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.804999999972,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.273999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.73199999999997,
"heapDeltaBytes": -6671092,
"heapUsedBytes": 66028936,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.292,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.9379999999655,
"styleRecalcs": 77,
"styleRecalcDurationMs": 31.472,
"layouts": 18,
"layoutDurationMs": 4.707,
"taskDurationMs": 744.283,
"heapDeltaBytes": -10684020,
"heapUsedBytes": 61995056,
"domNodes": -294,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 95.418,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.9680000000644,
"styleRecalcs": 78,
"styleRecalcDurationMs": 34.132999999999996,
"layouts": 18,
"layoutDurationMs": 5.388000000000001,
"taskDurationMs": 711.773,
"heapDeltaBytes": -13243176,
"heapUsedBytes": 59689972,
"domNodes": -298,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 93.268,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 899.1209999999228,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.281999999999993,
"layouts": 16,
"layoutDurationMs": 11.921,
"taskDurationMs": 713.8789999999999,
"heapDeltaBytes": 21042712,
"heapUsedBytes": 109176624,
"domNodes": 13751,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 21.736000000000004,
"eventListeners": 2381,
"totalBlockingTimeMs": 87,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8925.493999999959,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.769,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5135.428,
"heapDeltaBytes": -11500012,
"heapUsedBytes": 89002988,
"domNodes": -265,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 2248.2129999999997,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8307.322999999997,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.220000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4728.8009999999995,
"heapDeltaBytes": 8119144,
"heapUsedBytes": 84399852,
"domNodes": -268,
"jsHeapTotalBytes": -643072,
"scriptDurationMs": 2157.1499999999996,
"eventListeners": -165,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14620.902000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14169.068,
"heapDeltaBytes": -54185764,
"heapUsedBytes": 161552560,
"domNodes": -6548,
"jsHeapTotalBytes": 806912,
"scriptDurationMs": 242.907,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14605.609000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14142.673999999999,
"heapDeltaBytes": -29296220,
"heapUsedBytes": 180696804,
"domNodes": -6548,
"jsHeapTotalBytes": 2494464,
"scriptDurationMs": 213.77200000000002,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17492.921999999908,
"styleRecalcs": 130,
"styleRecalcDurationMs": 15.108999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17145.753,
"heapDeltaBytes": -42626592,
"heapUsedBytes": 166595972,
"domNodes": -6548,
"jsHeapTotalBytes": 204800,
"scriptDurationMs": 736.418,
"eventListeners": -7473,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17753.586999999927,
"styleRecalcs": 144,
"styleRecalcDurationMs": 15.655000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17337.618,
"heapDeltaBytes": -21272164,
"heapUsedBytes": 190337668,
"domNodes": -6548,
"jsHeapTotalBytes": -6057984,
"scriptDurationMs": 724.7289999999999,
"eventListeners": -7473,
"totalBlockingTimeMs": 11,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5263.170999999943,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.24600000000002,
"layouts": 20,
"layoutDurationMs": 20.11099999999999,
"taskDurationMs": 5159.087000000001,
"heapDeltaBytes": -31678652,
"heapUsedBytes": 177388332,
"domNodes": -6548,
"jsHeapTotalBytes": 9461760,
"scriptDurationMs": 88.93900000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 177,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5371.888000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.402999999999984,
"layouts": 20,
"layoutDurationMs": 20.751000000000005,
"taskDurationMs": 5295.380000000001,
"heapDeltaBytes": -19758896,
"heapUsedBytes": 182696340,
"domNodes": -6548,
"jsHeapTotalBytes": 16556032,
"scriptDurationMs": 93.69000000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 258,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 457.21499999990556,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.363999999999997,
"layouts": 3,
"layoutDurationMs": 1.146,
"taskDurationMs": 106.456,
"heapDeltaBytes": 5335360,
"heapUsedBytes": 73755428,
"domNodes": 153,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 10.245000000000001,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 97.06000000005588,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.927999999999999,
"layouts": 2,
"layoutDurationMs": 1.0999999999999999,
"taskDurationMs": 57.30499999999999,
"heapDeltaBytes": 3159296,
"heapUsedBytes": 71487504,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.835999999999999,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.53 #18358 +/- ##
=============================================
+ Coverage 83.29% 83.40% +0.11%
=============================================
Files 2036 2034 -2
Lines 117787 117879 +92
Branches 33287 33298 +11
=============================================
+ Hits 98109 98322 +213
+ Misses 19322 19203 -119
+ Partials 356 354 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 68 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #18251 to
core/1.53. RuntimetoReversed/toSorted/toSplicedcalls are replaced with copies that work on browsers lacking those newer array methods. Fixes thex.toReversed is not a functionerrors on 1.53.x tracked in Sentry as FRONTEND-6J and FRONTEND-7X.Full context for agent readers
Differences from the main-branch PR, on purpose:
es2022-compat/no-array-copy-method), its test, and the@typescript-eslint/utilsdependency are not included. The cherry-picked lockfile hunks referenced@typescript-eslint/utils@8.69.0andeslint@10.10.0, which do not exist in this branch's lockfile (it has 8.67.0 and 10.8.1), so a frozen-lockfile install would fail. The rule is a CI guard that main already enforces on anything that later gets backported; the release branch only needs the runtime fix.src/utils/requestUtil.tsandsrc/workbench/extensions/agent/components/agent/Composer.test.tswere hand-merged onto the 1.53 versions. Files that only exist on main (useAgentMentionPicker.ts,useAgentWorkflowResolver.ts,crdtDebugReport*.ts,requestUtil.test.ts) were dropped.Composer.vuehad threetoSorteduses that main had already moved into composables; replaced with[...x].sort(...), or.sort(...)where the receiver is a fresh array literal.git grepconfirms no remaining.toSorted(,.toReversed(, or.toSpliced(in non-test files undersrc/on this branch.Verification: relies on CI (lint, typecheck, unit tests). No local checks were run on the authoring host.