Skip to content

feat(settings): hoisted workspace header with collapse-on-scroll - #18329

Closed
comfydesigner wants to merge 2 commits into
comfydesigner/settings-modal-header-variantsfrom
comfydesigner/settings-workspace-header-hoist
Closed

comfydesigner wants to merge 2 commits into
comfydesigner/settings-modal-header-variantsfrom
comfydesigner/settings-workspace-header-hoist

Conversation

@comfydesigner

Copy link
Copy Markdown
Contributor

Part 2/3 of the settings header redesign (split from #18319). Stacked on #18328.

The settings dialog chrome hoists the workspace identity (name + avatar) into the dialog header using the symmetric padding variant, and collapses it once any nested panel scroller moves. The collapse is one capture-phase listener on the content wrapper — scroll events don't bubble but do capture — so panels need no wiring and can't silently break it (which is exactly how the earlier draft's collapse died when a panel rewrite dropped its hand-wired listener).

Content padding binds per category: workspace categories get none with the wrapper supplying px-6 gutters; every other category keeps the layout's default px-6 pb-10 (resolves CodeJuggernaut's padding-seam finding from #16438).

Panels keep their local headers until part 3 (#18319), so workspace pages show both headers in the interim — the stack is meant to merge in sequence.

Testing

  • Collapse driven from both the layout scroller and a nested panel scroller; threshold hysteresis; reset on section switch
  • Store fixtures updated for membersLoaded/pendingInvitesLoaded

Additive enablers for the settings header redesign: headerPadding defaults
to the existing classes verbatim, and the contentScroll emit is inert for
consumers that don't listen.
The dialog chrome renders the workspace identity in the header (symmetric
padding variant) and collapses it once any nested panel scroller moves —
a capture-phase listener on the content wrapper, so panels need no wiring.
Content padding binds per category: workspace categories get none with the
wrapper supplying gutters, everything else keeps the layout default.
Panels keep their local headers until the adoption PR.
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: bc09a726-e292-4a24-aaed-bedb9ee17562

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🌾 Fallow: ❌ Failed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (15 changed files).

Kind Finding Where Usual remedy
Complexity <template>() — cyclomatic 16, CRAP undefined src/platform/settings/components/SettingDialog.vue:6 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since bb42372375f5a5940f0665ef88343b1db68bc715

Full docs: ADR-DEVEX-LINT-0015

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/22/2026, 01:52:24 AM UTC

Links

🎭 Playwright: ❌ 2070 passed, 1 failed · 3 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 2051 / ❌ 0 / ⚠️ 3 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 1 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.4 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 270ms TBT · 85.7 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 80ms TBT · 86.6 MB heap
extension-clean-combined-draw: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 7ms TBT · 80.5 MB heap
extension-rgthree-prototype-draw: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 23ms TBT · 75.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 52ms TBT · 78.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.4 MB heap
vue-large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 179.9 MB heap
vue-large-graph-pan: · 59.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 20ms TBT · 183.3 MB heap
vue-node-resize-workload: · 59.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 28ms TBT · 175.8 MB heap
vue-zoom-out-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 175.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 259ms
canvas-idle: script duration 5ms
canvas-idle: TBT 0ms
canvas-idle: heap used 57.2 MB
canvas-idle: DOM nodes -257
canvas-idle: event listeners -177
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 19ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 486ms
canvas-mouse-sweep: script duration 93ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 57.2 MB
canvas-mouse-sweep: DOM nodes -258
canvas-mouse-sweep: event listeners -174
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 10ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 189ms
canvas-zoom-sweep: script duration 7ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 61.5 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 275ms
dom-widget-clipping: script duration 103ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 79.4 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 492ms
dom-widget-order-dense-n200-w200-i120: script duration 35ms
dom-widget-order-dense-n200-w200-i120: TBT 270ms
dom-widget-order-dense-n200-w200-i120: heap used 85.7 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -146
dom-widget-order-dense-n200-w200-i120: event listeners -109
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 249ms
dom-widget-order-sparse-n1000-w20-i120: script duration 86ms
dom-widget-order-sparse-n1000-w20-i120: TBT 80ms
dom-widget-order-sparse-n1000-w20-i120: heap used 86.6 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 17ms
extension-clean-combined-draw: p95 frame time 17ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 2ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 3
extension-clean-combined-draw: task duration 4425ms
extension-clean-combined-draw: script duration 3580ms
extension-clean-combined-draw: TBT 7ms
extension-clean-combined-draw: heap used 80.5 MB
extension-clean-combined-draw: DOM nodes -143
extension-clean-combined-draw: event listeners -87
extension-rgthree-prototype-draw: avg frame time 17ms
extension-rgthree-prototype-draw: p95 frame time 17ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 2ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 3
extension-rgthree-prototype-draw: task duration 4777ms
extension-rgthree-prototype-draw: script duration 3788ms
extension-rgthree-prototype-draw: TBT 23ms
extension-rgthree-prototype-draw: heap used 75.9 MB
extension-rgthree-prototype-draw: DOM nodes -139
extension-rgthree-prototype-draw: event listeners -76
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 340ms
large-graph-idle: script duration 17ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 77.9 MB
large-graph-idle: DOM nodes -242
large-graph-idle: event listeners -174
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 71
large-graph-pan: task duration 983ms
large-graph-pan: script duration 516ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 74.8 MB
large-graph-pan: DOM nodes -213
large-graph-pan: event listeners -179
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1021ms
large-graph-zoom: script duration 481ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.7 MB
large-graph-zoom: DOM nodes 11
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1083ms
legacy-node-drag: script duration 584ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 75.0 MB
legacy-node-drag: DOM nodes 10
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 308ms
minimap-idle: script duration 20ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.0 MB
minimap-idle: DOM nodes -244
minimap-idle: event listeners -163
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 238ms
subgraph-dom-widget-clipping: script duration 88ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 76.0 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 5ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 230ms
subgraph-idle: script duration 5ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.6 MB
subgraph-idle: DOM nodes -274
subgraph-idle: event listeners -209
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 20ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 467ms
subgraph-mouse-sweep: script duration 69ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 75.6 MB
subgraph-mouse-sweep: DOM nodes -274
subgraph-mouse-sweep: event listeners -198
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 7ms
subgraph-transition-enter: style recalc duration 17ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 505ms
subgraph-transition-enter: script duration 17ms
subgraph-transition-enter: TBT 52ms
subgraph-transition-enter: heap used 78.1 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 3350ms
viewport-pan-sweep: script duration 1706ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 63.4 MB
viewport-pan-sweep: DOM nodes -232
viewport-pan-sweep: event listeners -174
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 9604ms
vue-large-graph-idle: script duration 127ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 179.9 MB
vue-large-graph-idle: DOM nodes -8062
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 12ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 68
vue-large-graph-pan: task duration 12971ms
vue-large-graph-pan: script duration 569ms
vue-large-graph-pan: TBT 20ms
vue-large-graph-pan: heap used 183.3 MB
vue-large-graph-pan: DOM nodes -8062
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 18ms
vue-node-resize-workload: style recalc duration 48ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 3762ms
vue-node-resize-workload: script duration 58ms
vue-node-resize-workload: TBT 28ms
vue-node-resize-workload: heap used 175.8 MB
vue-node-resize-workload: DOM nodes -8062
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 4682ms
vue-zoom-out-idle: script duration 61ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 175.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 6
workflow-execution: style recalc count 13
workflow-execution: task duration 67ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 63.0 MB
workflow-execution: DOM nodes 137
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-09-22T01:51:36.803Z",
  "gitSha": "4995dd73bf0449733a6b842d72377d6e0a781376",
  "branch": "comfydesigner/settings-workspace-header-hoist",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2009.5059999999876,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.050000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 257.40399999999994,
      "heapDeltaBytes": -2307956,
      "heapUsedBytes": 59995208,
      "domNodes": -258,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 5.114999999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 1989.167000000009,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.951,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 260.316,
      "heapDeltaBytes": -7467908,
      "heapUsedBytes": 59920744,
      "domNodes": -256,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 4.992999999999999,
      "eventListeners": -180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1678.3439999999814,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 20.246,
      "layouts": 14,
      "layoutDurationMs": 3.901,
      "taskDurationMs": 490.713,
      "heapDeltaBytes": -165040,
      "heapUsedBytes": 62273744,
      "domNodes": -258,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 93.35499999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1678.82800000001,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 18.743,
      "layouts": 14,
      "layoutDurationMs": 3.7479999999999998,
      "taskDurationMs": 482.163,
      "heapDeltaBytes": -3933664,
      "heapUsedBytes": 57620496,
      "domNodes": -257,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 91.696,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.9349999999731,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 9.908,
      "layouts": 6,
      "layoutDurationMs": 0.9890000000000001,
      "taskDurationMs": 182.578,
      "heapDeltaBytes": 2176848,
      "heapUsedBytes": 64386216,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 6.765000000000002,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.9270000000406,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 9.762,
      "layouts": 6,
      "layoutDurationMs": 0.9729999999999999,
      "taskDurationMs": 195.03899999999996,
      "heapDeltaBytes": 2118428,
      "heapUsedBytes": 64576248,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 7.646,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 430.84399999997913,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 7.276999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 279.916,
      "heapDeltaBytes": 18629888,
      "heapUsedBytes": 85974416,
      "domNodes": 21,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 104.78,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 398.97600000000466,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.32,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 270.675,
      "heapDeltaBytes": 18189068,
      "heapUsedBytes": 80474088,
      "domNodes": 16,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 101.42000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 891.6449999999827,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 530.448,
      "heapDeltaBytes": -17278816,
      "heapUsedBytes": 72301304,
      "domNodes": -292,
      "jsHeapTotalBytes": 19005440,
      "scriptDurationMs": 33.483,
      "eventListeners": -217,
      "totalBlockingTimeMs": 267,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 858.6419999999748,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 452.797,
      "heapDeltaBytes": 38208372,
      "heapUsedBytes": 107518768,
      "domNodes": 0,
      "jsHeapTotalBytes": 19820544,
      "scriptDurationMs": 35.82999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 272,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 671.6759999999908,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 244.82800000000003,
      "heapDeltaBytes": 14479748,
      "heapUsedBytes": 89762440,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 82.045,
      "eventListeners": 0,
      "totalBlockingTimeMs": 80,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 688.4160000000179,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 254.03699999999984,
      "heapDeltaBytes": 15489872,
      "heapUsedBytes": 91784332,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 90.80099999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 79,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 5597.559999999987,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.1660000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4578.514,
      "heapDeltaBytes": 18254740,
      "heapUsedBytes": 94896816,
      "domNodes": -271,
      "jsHeapTotalBytes": 1302528,
      "scriptDurationMs": 3707.549,
      "eventListeners": -174,
      "totalBlockingTimeMs": 14,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 5118.994999999984,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.018999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4271.602000000001,
      "heapDeltaBytes": -8000576,
      "heapUsedBytes": 73826844,
      "domNodes": -14,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 3452.4159999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 5889.742000000013,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.287,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4844.084,
      "heapDeltaBytes": -8798800,
      "heapUsedBytes": 73196388,
      "domNodes": -10,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 3826.63,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 5712.905000000035,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 1.818,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4709.611000000001,
      "heapDeltaBytes": 11046404,
      "heapUsedBytes": 86056232,
      "domNodes": -268,
      "jsHeapTotalBytes": -270336,
      "scriptDurationMs": 3749.593,
      "eventListeners": -152,
      "totalBlockingTimeMs": 45,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.8329999999773,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.728999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 349.603,
      "heapDeltaBytes": 2790644,
      "heapUsedBytes": 82065140,
      "domNodes": -241,
      "jsHeapTotalBytes": 1302528,
      "scriptDurationMs": 18.542999999999996,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2009.1240000000425,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.3340000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 330.59799999999996,
      "heapDeltaBytes": 2702508,
      "heapUsedBytes": 81304044,
      "domNodes": -242,
      "jsHeapTotalBytes": -532480,
      "scriptDurationMs": 16.080000000000005,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2130.701999999985,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 14.376,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 997.519,
      "heapDeltaBytes": -6791040,
      "heapUsedBytes": 80189984,
      "domNodes": -214,
      "jsHeapTotalBytes": 1826816,
      "scriptDurationMs": 525.5269999999999,
      "eventListeners": -184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2114.868999999999,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 13.887999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 967.503,
      "heapDeltaBytes": -10430672,
      "heapUsedBytes": 76693048,
      "domNodes": -212,
      "jsHeapTotalBytes": 2613248,
      "scriptDurationMs": 507.071,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3078.6399999999503,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 12.920999999999998,
      "layouts": 60,
      "layoutDurationMs": 13.809999999999999,
      "taskDurationMs": 1031.0919999999999,
      "heapDeltaBytes": 8479012,
      "heapUsedBytes": 74102416,
      "domNodes": 12,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 480.27200000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3041.417000000024,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 11.908999999999999,
      "layouts": 60,
      "layoutDurationMs": 13.303,
      "taskDurationMs": 1010.646,
      "heapDeltaBytes": 8503084,
      "heapUsedBytes": 74096352,
      "domNodes": 10,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 481.46399999999994,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2210.9779999999546,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 7.969999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1122.975,
      "heapDeltaBytes": 8190084,
      "heapUsedBytes": 73822292,
      "domNodes": 10,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 585.221,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2130.7319999999663,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 7.882,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1042.574,
      "heapDeltaBytes": 17516344,
      "heapUsedBytes": 83452784,
      "domNodes": 10,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 582.717,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 1996.6400000000135,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 3.6479999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 284.56300000000005,
      "heapDeltaBytes": 20213260,
      "heapUsedBytes": 84066724,
      "domNodes": -245,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 16.038000000000004,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2021.2920000000167,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.056000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 331.86499999999995,
      "heapDeltaBytes": -4950920,
      "heapUsedBytes": 83751832,
      "domNodes": -243,
      "jsHeapTotalBytes": -1019904,
      "scriptDurationMs": 23.073999999999998,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.660000000000007,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 381.0030000000211,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.413000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 240.27300000000002,
      "heapDeltaBytes": 12763848,
      "heapUsedBytes": 76463200,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 88.52600000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 360.21500000003925,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 8.72,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 235.58800000000002,
      "heapDeltaBytes": 13968184,
      "heapUsedBytes": 82851584,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 88.412,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1993.3540000000107,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.851000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 247.66699999999997,
      "heapDeltaBytes": 14882756,
      "heapUsedBytes": 78443428,
      "domNodes": -273,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 4.606000000000001,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2011.2430000000359,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.063999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 212.661,
      "heapDeltaBytes": -4289056,
      "heapUsedBytes": 65480036,
      "domNodes": -274,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 4.442,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1673.291000000006,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 20.228999999999996,
      "layouts": 18,
      "layoutDurationMs": 4.422000000000001,
      "taskDurationMs": 468.09099999999995,
      "heapDeltaBytes": 15104324,
      "heapUsedBytes": 78798712,
      "domNodes": -273,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 68.93299999999999,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1661.0369999999648,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 20.438000000000002,
      "layouts": 18,
      "layoutDurationMs": 4.558,
      "taskDurationMs": 466.758,
      "heapDeltaBytes": 16485576,
      "heapUsedBytes": 79816188,
      "domNodes": -274,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 69.628,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 783.7140000000318,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 17.202,
      "layouts": 5,
      "layoutDurationMs": 7.419999999999998,
      "taskDurationMs": 504.9049999999999,
      "heapDeltaBytes": -8091152,
      "heapUsedBytes": 81904616,
      "domNodes": 13667,
      "jsHeapTotalBytes": 11796480,
      "scriptDurationMs": 16.739000000000004,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 52,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8137.299999999982,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 39.407,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3367.92,
      "heapDeltaBytes": -19765424,
      "heapUsedBytes": 66342648,
      "domNodes": -214,
      "jsHeapTotalBytes": 3698688,
      "scriptDurationMs": 1725.8250000000003,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8120.198000000073,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 38.899,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3332.4539999999997,
      "heapDeltaBytes": -12465888,
      "heapUsedBytes": 66588364,
      "domNodes": -249,
      "jsHeapTotalBytes": 2875392,
      "scriptDurationMs": 1685.978,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 9899.48099999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8921.802,
      "heapDeltaBytes": -40253148,
      "heapUsedBytes": 191924976,
      "domNodes": -8062,
      "jsHeapTotalBytes": -13164544,
      "scriptDurationMs": 116.605,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10931.907999999908,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10286.868999999999,
      "heapDeltaBytes": -46550060,
      "heapUsedBytes": 185259344,
      "domNodes": -8062,
      "jsHeapTotalBytes": -12378112,
      "scriptDurationMs": 136.911,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13368.18900000003,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 11.809000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12882.795,
      "heapDeltaBytes": -38613480,
      "heapUsedBytes": 191746940,
      "domNodes": -8062,
      "jsHeapTotalBytes": -10539008,
      "scriptDurationMs": 529.6850000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13572.119999999926,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.275999999999982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13059.110999999999,
      "heapDeltaBytes": -23315400,
      "heapUsedBytes": 192667540,
      "domNodes": -8062,
      "jsHeapTotalBytes": -18427904,
      "scriptDurationMs": 608.6640000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 39,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3841.752999999983,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 48.85,
      "layouts": 20,
      "layoutDurationMs": 17.608999999999998,
      "taskDurationMs": 3700.598,
      "heapDeltaBytes": -36144920,
      "heapUsedBytes": 196018836,
      "domNodes": -8062,
      "jsHeapTotalBytes": 18554880,
      "scriptDurationMs": 57.398,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 55,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3903.587000000016,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 47.99,
      "layouts": 20,
      "layoutDurationMs": 18.416999999999994,
      "taskDurationMs": 3822.4470000000006,
      "heapDeltaBytes": -59453256,
      "heapUsedBytes": 172590848,
      "domNodes": -8062,
      "jsHeapTotalBytes": 14098432,
      "scriptDurationMs": 58.693,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5245.0959999999895,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4768.258,
      "heapDeltaBytes": 16827968,
      "heapUsedBytes": 179768800,
      "domNodes": 0,
      "jsHeapTotalBytes": -19922944,
      "scriptDurationMs": 63.43900000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333326,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5236.0009999999875,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4596.313,
      "heapDeltaBytes": -8940452,
      "heapUsedBytes": 188368816,
      "domNodes": 0,
      "jsHeapTotalBytes": -25952256,
      "scriptDurationMs": 59.251,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 73.90500000002476,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 11.047999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.7810000000000001,
      "taskDurationMs": 54.134,
      "heapDeltaBytes": 3345032,
      "heapUsedBytes": 65236896,
      "domNodes": 129,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 6.579999999999999,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 416.4250000000038,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 16.631999999999998,
      "layouts": 5,
      "layoutDurationMs": 1.65,
      "taskDurationMs": 80.436,
      "heapDeltaBytes": 5050664,
      "heapUsedBytes": 66786832,
      "domNodes": 145,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 8.84,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52016 78497 66.3% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.9% 1152
src/LGraphNode.ts 70.4% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 316
src/LGraph.ts 79.3% 261
src/scripts/app.ts 72.3% 257
src/platform/workspace/stores/teamWorkspaceStore.ts 39.2% 256
src/core/billing/operationLifecycle.ts 0.9% 232
src/scripts/pnginfo.ts 20.8% 221

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 22, 2026
@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.13208% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/settings/components/SettingDialog.vue 74.19% 7 Missing and 1 partial ⚠️
...rc/platform/workspace/stores/teamWorkspaceStore.ts 66.66% 2 Missing ⚠️
@@                               Coverage Diff                                @@
##           comfydesigner/settings-modal-header-variants   #18329      +/-   ##
================================================================================
- Coverage                                         84.25%   84.23%   -0.03%     
================================================================================
  Files                                              2280     2279       -1     
  Lines                                            129376   129317      -59     
  Branches                                          33050    34931    +1881     
================================================================================
- Hits                                             109011   108933      -78     
- Misses                                            20070    20088      +18     
- Partials                                            295      296       +1     
Flag Coverage Δ
e2e 66.25% <91.66%> (-0.01%) ⬇️
unit 79.76% <80.76%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../settings/composables/useSettingsHeaderCollapse.ts 100.00% <100.00%> (ø)
...tform/workspace/components/WorkspaceProfilePic.vue 100.00% <100.00%> (ø)
...rc/platform/workspace/stores/teamWorkspaceStore.ts 93.09% <66.66%> (-0.35%) ⬇️
src/platform/settings/components/SettingDialog.vue 68.29% <74.19%> (+8.29%) ⬆️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfydesigner
comfydesigner force-pushed the comfydesigner/settings-modal-header-variants branch from bb42372 to 0ce6319 Compare September 23, 2026 23:02
@comfydesigner

Copy link
Copy Markdown
Contributor Author

Closing per the agreed plan in the Slack thread: the contentScroll emit was dead code (superseded by the capture-phase listener), so with it deleted the shared-modal surface is gone and this stack-middle is unnecessary. The stack is now #18328 (headerPadding prop only) → #18319 (full feature, emit deleted).

laurigates pushed a commit to laurigates/ComfyUI_frontend that referenced this pull request Oct 1, 2026
…omfy-Org#18319)

**Final shape per the Slack agreement (2026-09-23):** stacked on Comfy-Org#18328
(headerPadding prop). The dead `contentScroll` emit is deleted —
collapse runs entirely through a capture-phase listener on the settings
content wrapper, replacing the per-panel wiring that silently broke when
a panel swapped its scroller. Comfy-Org#15235 and Comfy-Org#18329 are closed as
absorbed/unnecessary; this PR is the single vehicle for the
members-table + header work.

Still to fix before review completes (from dante01yoon's pass): fallow
template-complexity finding on SettingDialog, mobile-chrome playwright
failure, and the two CodeRabbit findings (paginated member total;
allSettled swallowing fetch errors).

---

Clean restart of Comfy-Org#16438 — same tree, squashed to one commit off current
main. That PR accumulated three merge commits and a stale merge-base
that made GitHub render a 5k-file diff; the actual change is 28 files.

All review history lives on Comfy-Org#16438: Jaewon's early rounds (addressed),
CodeRabbit's rounds (addressed), and CodeJuggernaut's padding-seam
finding — resolved here as `content-padding` per category (workspace
categories 'none' with the hoisted wrapper supplying gutters; every
other category keeps the layout default).

## Summary

Reclaims the settings dialog's vertical space for workspace panels: the
workspace header moves into the dialog's own header bar, and once a
panel scrolls it gives way so the panel's controls take that row.

Supersedes Comfy-Org#15271, which was stacked on the since-merged Comfy-Org#15239 and
could not be rebased cleanly. Based on Comfy-Org#15235 — the scroll-away
teleports the controls row that PR introduces.

## Changes

- **Header hoist**: the workspace avatar and name move onto the
close-button row; `WorkspaceSettingsPanelContent` drops its duplicate
header. Recovers ~200px on every workspace section. Matches [Figma
4157-27354](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Team-Plan---Workspaces?node-id=4157-27354).
- **`headerPadding` prop** on `BaseModalLayout`, defaulting to today's
`h-18 px-6`. Settings opts into `symmetric`, which makes the close
button's top gap equal its right gap.
- **Scroll-away**: `useSettingsHeaderCollapse` — panels report their
scroller's `scrollTop`; past 24px the avatar and name give way,
restoring below 4px (a deadband — collapsing changes the scroller’s own
overflow, so a single threshold oscillates) and the controls row is
teleported into the header beside the close button. Tabs on Plan &
Credits; tabs, search and Invite on Members, all left of the close
button.
- **Breaking**: none.

## Review Focus

**The padding is opt-in for a reason.** Applied unconditionally it cost
the other five full-size modals — ComfyHubPublishDialog,
AssetBrowserModal, SampleModelSelector, WorkflowTemplateSelectorDialog,
ManagerDialog — 20px of header height (72px → 92px, measured at
1440×900) for no benefit, since none has a duplicate header to remove.
`BaseModalLayout.stories.ts` exposes the prop so both variants are
inspectable.

**Why panels report scroll instead of the dialog owning it.** An earlier
attempt hoisted scrolling to the dialog and overlaid the close button.
That undid Comfy-Org#15235's bounded members table, drew a frame around a table
whose header had detached, and floated the close button over unrelated
settings pages. Reacting to each panel's existing scroller leaves those
alone, and the teleport target only exists inside
`isWorkspaceCategoryActive`, so no other category can see the behaviour.

`Teleport` moves the controls rather than rendering a second copy, so
tab state, search text and the invite handler are preserved across the
transition.

**Not yet done**: no transition on the swap — it is instant rather than
animated.

## Screenshots
<img width="1278" height="783" alt="image"
src="https://github.com/user-attachments/assets/a12cc08d-aabf-46a8-b759-e9d684df453e"
/>
<img width="1512" height="620" alt="image"
src="https://github.com/user-attachments/assets/46b9d187-2abd-4e41-870c-4b9c52d6490f"
/>
<img width="1512" height="982" alt="image"
src="https://github.com/user-attachments/assets/1c0fdf0c-1f25-40b5-8dae-129b2d7e1dcf"
/>

---------

Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant