Repository navigation
[backport cloud/1.54] Keep new agent chat from inheriting stale canvas (#18064) - #18317
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1933 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-22T00:14:07.382Z",
"gitSha": "a9b4bbd9b96a871829958236d859eea16653ab93",
"branch": "backport/cloud-1.54-18064-stale-canvas-20260921",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.8599999999897,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.459000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.7579999999999,
"heapDeltaBytes": -4895280,
"heapUsedBytes": 59086844,
"domNodes": -279,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.638,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2054.3099999999868,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.95,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.07499999999993,
"heapDeltaBytes": 3986464,
"heapUsedBytes": 74025784,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.591000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2109.976999999958,
"styleRecalcs": 80,
"styleRecalcDurationMs": 35.397,
"layouts": 14,
"layoutDurationMs": 4.135,
"taskDurationMs": 1004.5410000000002,
"heapDeltaBytes": 10255000,
"heapUsedBytes": 80956220,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 178.784,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1783.6849999999913,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.273,
"layouts": 14,
"layoutDurationMs": 4.1370000000000005,
"taskDurationMs": 856.26,
"heapDeltaBytes": -3935316,
"heapUsedBytes": 65691240,
"domNodes": -276,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 157.056,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1670.2579999999898,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.759,
"layouts": 6,
"layoutDurationMs": 1.084,
"taskDurationMs": 361.72799999999995,
"heapDeltaBytes": 4386800,
"heapUsedBytes": 74216252,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.078999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.6240000000198,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.660000000000004,
"layouts": 6,
"layoutDurationMs": 1.1270000000000002,
"taskDurationMs": 354.12199999999996,
"heapDeltaBytes": 4350760,
"heapUsedBytes": 73310236,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.529999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 659.4230000000039,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.509,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.33900000000006,
"heapDeltaBytes": 18714880,
"heapUsedBytes": 88613416,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 166.956,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 647.1760000000017,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.4750000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.977,
"heapDeltaBytes": 18654912,
"heapUsedBytes": 82515388,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 162.609,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2081.039999999973,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.596000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.4739999999999,
"heapDeltaBytes": 11232592,
"heapUsedBytes": 86796488,
"domNodes": -266,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 39.458999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.867999999942,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.630000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.6679999999999,
"heapDeltaBytes": 10143400,
"heapUsedBytes": 85651144,
"domNodes": -267,
"jsHeapTotalBytes": 155648,
"scriptDurationMs": 34.248,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2519.3239999999832,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.085,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1777.828,
"heapDeltaBytes": 9847540,
"heapUsedBytes": 87116148,
"domNodes": -273,
"jsHeapTotalBytes": -667648,
"scriptDurationMs": 907.696,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2321.1219999999457,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.000000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1669.9709999999998,
"heapDeltaBytes": 8965420,
"heapUsedBytes": 85266368,
"domNodes": -271,
"jsHeapTotalBytes": 118784,
"scriptDurationMs": 831.724,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3753.071000000034,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.278999999999996,
"layouts": 60,
"layoutDurationMs": 12.275999999999998,
"taskDurationMs": 1785.3470000000002,
"heapDeltaBytes": 8786188,
"heapUsedBytes": 76266996,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 815.411,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3616.3210000000845,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.769,
"layouts": 60,
"layoutDurationMs": 12.028,
"taskDurationMs": 1736.615,
"heapDeltaBytes": 11727868,
"heapUsedBytes": 80148404,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 776.982,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3156.7100000000323,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.064000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1998.8809999999999,
"heapDeltaBytes": 3542620,
"heapUsedBytes": 84484220,
"domNodes": -282,
"jsHeapTotalBytes": 49152,
"scriptDurationMs": 985.517,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3078.850999999986,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.749,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1880.297,
"heapDeltaBytes": 18097160,
"heapUsedBytes": 86344112,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 940.0329999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2058.506999999963,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.408,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 651.397,
"heapDeltaBytes": 5753912,
"heapUsedBytes": 83016348,
"domNodes": -277,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 37.286,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2019.2739999999958,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.4259999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.415,
"heapDeltaBytes": 21309388,
"heapUsedBytes": 87267748,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.783000000000015,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.1160000000232,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.384,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.67999999999995,
"heapDeltaBytes": 15042880,
"heapUsedBytes": 87893848,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 139.94600000000003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.3949999999159,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.879999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.868,
"heapDeltaBytes": 14707480,
"heapUsedBytes": 87914968,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 142.178,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.1180000000058,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.352,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.555,
"heapDeltaBytes": -9816040,
"heapUsedBytes": 61876208,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.538000000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.712999999958,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.612000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.67500000000007,
"heapDeltaBytes": -13360920,
"heapUsedBytes": 59729456,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.077,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.7889999999543,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.216000000000005,
"layouts": 18,
"layoutDurationMs": 4.719,
"taskDurationMs": 796.7259999999999,
"heapDeltaBytes": -7126448,
"heapUsedBytes": 64513268,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 106.124,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1715.820000000008,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.266,
"layouts": 18,
"layoutDurationMs": 4.779,
"taskDurationMs": 805.083,
"heapDeltaBytes": 7782832,
"heapUsedBytes": 80730420,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 110.17100000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.2330000000475,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.260999999999996,
"layouts": 13,
"layoutDurationMs": 14.625999999999996,
"taskDurationMs": 896.1220000000001,
"heapDeltaBytes": 21946808,
"heapUsedBytes": 106730800,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 31.165000000000006,
"eventListeners": 2385,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8753.496999999981,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.459,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5993.853,
"heapDeltaBytes": 8890800,
"heapUsedBytes": 85200636,
"domNodes": -272,
"jsHeapTotalBytes": -1191936,
"scriptDurationMs": 2712.184,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8605.409000000009,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6032.817,
"heapDeltaBytes": 6307068,
"heapUsedBytes": 81911696,
"domNodes": -246,
"jsHeapTotalBytes": -143360,
"scriptDurationMs": 2787.045,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16901.684999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16437.41,
"heapDeltaBytes": -63031172,
"heapUsedBytes": 176353928,
"domNodes": -8068,
"jsHeapTotalBytes": -19189760,
"scriptDurationMs": 290.438,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17542.43000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16881.798,
"heapDeltaBytes": -56603940,
"heapUsedBytes": 182304332,
"domNodes": -8068,
"jsHeapTotalBytes": -12759040,
"scriptDurationMs": 281.676,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21093.45000000002,
"styleRecalcs": 176,
"styleRecalcDurationMs": 18.191999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20692.242000000002,
"heapDeltaBytes": -50592168,
"heapUsedBytes": 167008764,
"domNodes": -8068,
"jsHeapTotalBytes": -10444800,
"scriptDurationMs": 891.602,
"eventListeners": -14925,
"totalBlockingTimeMs": 38,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21015.940000000002,
"styleRecalcs": 172,
"styleRecalcDurationMs": 18.428,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20670.493000000002,
"heapDeltaBytes": -47130592,
"heapUsedBytes": 184051200,
"domNodes": -8068,
"jsHeapTotalBytes": -9351168,
"scriptDurationMs": 920.636,
"eventListeners": -14929,
"totalBlockingTimeMs": 63,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6277.107000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.04099999999997,
"layouts": 20,
"layoutDurationMs": 21.092,
"taskDurationMs": 6143.589999999999,
"heapDeltaBytes": -27815472,
"heapUsedBytes": 183773532,
"domNodes": -8068,
"jsHeapTotalBytes": 11358208,
"scriptDurationMs": 110.295,
"eventListeners": -14929,
"totalBlockingTimeMs": 342,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6275.024999999914,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.79999999999998,
"layouts": 20,
"layoutDurationMs": 22.521,
"taskDurationMs": 6186.3679999999995,
"heapDeltaBytes": -37995092,
"heapUsedBytes": 187381668,
"domNodes": -8068,
"jsHeapTotalBytes": 13168640,
"scriptDurationMs": 116.965,
"eventListeners": -14929,
"totalBlockingTimeMs": 402,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8604.008000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8408.965,
"heapDeltaBytes": 1785388,
"heapUsedBytes": 178359476,
"domNodes": -1520,
"jsHeapTotalBytes": -17301504,
"scriptDurationMs": 138.35599999999997,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8880.604000000061,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8505.427,
"heapDeltaBytes": 20471676,
"heapUsedBytes": 178418956,
"domNodes": 0,
"jsHeapTotalBytes": -7864320,
"scriptDurationMs": 137.55399999999995,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 471.44200000002456,
"styleRecalcs": 21,
"styleRecalcDurationMs": 20.81,
"layouts": 3,
"layoutDurationMs": 1.5500000000000003,
"taskDurationMs": 109.85499999999998,
"heapDeltaBytes": 4878924,
"heapUsedBytes": 74108884,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.445,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 94.47899999997844,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.104999999999999,
"layouts": 2,
"layoutDurationMs": 0.7789999999999999,
"taskDurationMs": 64.489,
"heapDeltaBytes": 3001240,
"heapUsedBytes": 71896676,
"domNodes": 104,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.448,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18317 +/- ##
=============================================
Coverage ? 83.56%
=============================================
Files ? 2095
Lines ? 123658
Branches ? 31290
=============================================
Hits ? 103337
Misses ? 20143
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Code path clean; merge held.
- Source semantics are preserved on the release's
EcsFollowerAdapterpath. - Exact head
d977ea76b509e2cd7a2230e9df9e05a1c9500aedis conflict-free, terminal-green, and passes the target-aware guard. - Acceptance gap: no target-native browser case executes clear canvas → delete/start chat → post an empty draft to the same workflow → re-subscribe without resurrecting nodes.
Full context for agent readers
Requirement-by-requirement coverage:
- Source applicability — covered. Source pull request 18064 is merged, and this carrier targets
cloud/1.54from target tip19a4f18b799f228a0faf39d951c22a4fdb53daf8. - Production diff — covered.
opCoalescer.tsandopSender.tsmatch the merged source implementation. The follower changes preserve the source's same-tick admission pinning, flush-before-retarget behavior, reset-timeabortAll(), and teardown, adapted to this release'sEcsFollowerAdapterimplementation. - Conflict adaptation — covered. The three main-only browser files do not exist on
cloud/1.54; the carrier does not silently copy incompatible harness code. - Focused unit/component behavior — covered. Tests pin same-tick batching and order, wire-cap splitting, workflow-at-admission, reset/unbind settlement, empty-draft submission, retained workflow identity, and host application of a coalesced clear. Hosted unit checks pass at the exact head.
- Target-wide regression evidence — covered. Hosted Cloud Playwright reports 1,933 passed and 0 failed; all 80 successful and 13 skipped checks are terminal with no adverse result. The target-aware merge guard reports ready at this exact head.
- Affected black-box behavior — gap. The merged source includes
agentNewChatClearedCanvas.spec.ts, which composes the user clear, delivered delete operations, chat deletion/new chat, sameworkflow_id, empty first draft, re-subscribe, and final one-marker-node graph. This carrier replaces it with isolated fixture/component tests. Those tests can all pass if the integrated browser path still resurrects the old document, so they do not provide equivalent predictive evidence for the reported regression. - Authentic served Cloud behavior — unavailable. The pull request description correctly says backend authority is not proven here. No deployment or served-environment acceptance is inferred.
- Ownership — preserved. The canonical
cloud18064-1claim remains held bygjp8-cloud-backport18064-20260921; this review does not take over or write its branch. - Merge authority — conditional but not exercised. The Agent 1.54 backport grant permits an exact-head admin merge after all gates. The missing composed browser acceptance remains a gate, so no merge is recommended yet.
Executable handoff: the existing gjp8 owner should add or run one target-native composed browser regression equivalent to the source case at this same head (or provide an existing exact-head artifact proving those steps), then rerun the target-aware guard. If the head and target tip remain unchanged and the evidence passes, the existing grant permits the owner to merge with --match-head-commit d977ea76b509e2cd7a2230e9df9e05a1c9500aed and read back cloud/1.54 ancestry.
Glossary: target-native means executed against the actual cloud/1.54 code and harness; composed browser regression means one test traverses all user-visible steps and final graph state; exact head means the reviewed commit identity; served acceptance means behavior demonstrated in a deployed Cloud environment.
#18064) (#18317) ## Summary Backports source PR #18064 to Cloud 1.54 so same-tick human graph operations are coalesced and pending batches are aborted on a document reset, preventing a cleared canvas from returning in a new chat. Source: #18064, merged as `42d44cd31e56071cea90e4a5027ee1d2d7a46830`. Target: `cloud/1.54` at `19a4f18b799f228a0faf39d951c22a4fdb53daf8`. Tracking: https://github.com/christian-byrne/blocked-on-christian/issues/827 ## Changes - **What**: Preserves same-tick operation coalescing, aborts admitted/in-flight human batches on `doc_reset`, and retains the saved workflow identity plus empty current draft for a new chat. - **Dependencies**: None. The release lockfile is unchanged. - **Target adaptation**: Keeps the release's `EcsFollowerAdapter`; adapts the removed conversation/socket regression to `agentConversationHostDoc` and `agentRequestResponseFixture` coverage. ## Review Focus - Coalescer admission/flush ordering around retarget and reset. - Release-specific adapter integration and target-harness regression coverage. - Backend authority behavior is not proven here; authentic served Cloud acceptance remains unavailable. Validation: focused Vitest 8 files / 355 tests; main and browser typechecks; full lint; format; ADR validation. All passed. Backport note (core/1.54): two mechanical conflicts, both resolved to main's end state. - browser_tests/fixtures/agentConversationHostDoc.test.ts keeps core's file. The carrier's extra "coalesced canvas clear" test exists only on cloud (main's #18064 never added it). It also calls HostDoc.applyClient, which core and main replaced with applyWire. - useAgentCrdtFollower.test.ts keeps both imports: core's GraphOperation and the carrier's BatchOutcome. (cherry picked from commit 06068f3)
Summary
Backports source PR #18064 to Cloud 1.54 so same-tick human graph operations are coalesced and pending batches are aborted on a document reset, preventing a cleared canvas from returning in a new chat.
Source: #18064, merged as
42d44cd31e56071cea90e4a5027ee1d2d7a46830.Target:
cloud/1.54at19a4f18b799f228a0faf39d951c22a4fdb53daf8.Tracking: https://github.com/christian-byrne/blocked-on-christian/issues/827
Changes
doc_reset, and retains the saved workflow identity plus empty current draft for a new chat.EcsFollowerAdapter; adapts the removed conversation/socket regression toagentConversationHostDocandagentRequestResponseFixturecoverage.Review Focus
Validation: focused Vitest 8 files / 355 tests; main and browser typechecks; full lint; format; ADR validation. All passed.