Skip to content

[backport cloud/1.54] Keep new agent chat from inheriting stale canvas (#18064) - #18317

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport/cloud-1.54-18064-stale-canvas-20260921
Sep 22, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport/cloud-1.54-18064-stale-canvas-20260921

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports source PR #18064 to Cloud 1.54 so same-tick human graph operations are coalesced and pending batches are aborted on a document reset, preventing a cleared canvas from returning in a new chat.

Source: #18064, merged as 42d44cd31e56071cea90e4a5027ee1d2d7a46830.
Target: cloud/1.54 at 19a4f18b799f228a0faf39d951c22a4fdb53daf8.
Tracking: https://github.com/christian-byrne/blocked-on-christian/issues/827

Changes

  • What: Preserves same-tick operation coalescing, aborts admitted/in-flight human batches on doc_reset, and retains the saved workflow identity plus empty current draft for a new chat.
  • Dependencies: None. The release lockfile is unchanged.
  • Target adaptation: Keeps the release's EcsFollowerAdapter; adapts the removed conversation/socket regression to agentConversationHostDoc and agentRequestResponseFixture coverage.

Review Focus

  • Coalescer admission/flush ordering around retarget and reset.
  • Release-specific adapter integration and target-harness regression coverage.
  • Backend authority behavior is not proven here; authentic served Cloud acceptance remains unavailable.

Validation: focused Vitest 8 files / 355 tests; main and browser typechecks; full lint; format; ADR validation. All passed.

Backport source PR #18064 (42d44cd) to cloud/1.54, adapting regression coverage to the release harness.
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: a81f1937-fb5a-44a7-bb59-ab836e99087d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 21, 2026 11:51pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/22/2026, 12:09:31 AM UTC

Links

🎭 Playwright: ✅ 1933 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1912 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 140ms TBT · 101.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.7 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.0 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 51ms TBT · 167.4 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 372ms TBT · 177.0 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 509ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 63.5 MB
canvas-idle: DOM nodes -279
canvas-idle: event listeners -165
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 32ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 930ms
canvas-mouse-sweep: script duration 168ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 69.9 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -181
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 358ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.3 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 455ms
dom-widget-clipping: script duration 165ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 81.6 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 624ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.2 MB
large-graph-idle: DOM nodes -267
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1724ms
large-graph-pan: script duration 870ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.2 MB
large-graph-pan: DOM nodes -272
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1761ms
large-graph-zoom: script duration 796ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.6 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1940ms
legacy-node-drag: script duration 963ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 81.5 MB
legacy-node-drag: DOM nodes -141
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 608ms
minimap-idle: script duration 38ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.2 MB
minimap-idle: DOM nodes -274
minimap-idle: event listeners -178
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 407ms
subgraph-dom-widget-clipping: script duration 141ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.8 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 484ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 58.0 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 27ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 801ms
subgraph-mouse-sweep: script duration 108ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 69.3 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 13
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 896ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 140ms
subgraph-transition-enter: heap used 101.8 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 6013ms
viewport-pan-sweep: script duration 2750ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 79.7 MB
viewport-pan-sweep: DOM nodes -259
viewport-pan-sweep: event listeners -176
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16660ms
vue-large-graph-idle: script duration 286ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.0 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 174
vue-large-graph-pan: task duration 20681ms
vue-large-graph-pan: script duration 906ms
vue-large-graph-pan: TBT 51ms
vue-large-graph-pan: heap used 167.4 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 79ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6165ms
vue-node-resize-workload: script duration 114ms
vue-node-resize-workload: TBT 372ms
vue-node-resize-workload: heap used 177.0 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8457ms
vue-zoom-out-idle: script duration 138ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.1 MB
vue-zoom-out-idle: DOM nodes -760
vue-zoom-out-idle: event listeners -13
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 3
workflow-execution: style recalc count 14
workflow-execution: task duration 87ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.6 MB
workflow-execution: DOM nodes 127
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-09-22T00:14:07.382Z",
  "gitSha": "a9b4bbd9b96a871829958236d859eea16653ab93",
  "branch": "backport/cloud-1.54-18064-stale-canvas-20260921",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2024.8599999999897,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.459000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 521.7579999999999,
      "heapDeltaBytes": -4895280,
      "heapUsedBytes": 59086844,
      "domNodes": -279,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 8.638,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2054.3099999999868,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.95,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.07499999999993,
      "heapDeltaBytes": 3986464,
      "heapUsedBytes": 74025784,
      "domNodes": -278,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.591000000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2109.976999999958,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 35.397,
      "layouts": 14,
      "layoutDurationMs": 4.135,
      "taskDurationMs": 1004.5410000000002,
      "heapDeltaBytes": 10255000,
      "heapUsedBytes": 80956220,
      "domNodes": -281,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 178.784,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1783.6849999999913,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 28.273,
      "layouts": 14,
      "layoutDurationMs": 4.1370000000000005,
      "taskDurationMs": 856.26,
      "heapDeltaBytes": -3935316,
      "heapUsedBytes": 65691240,
      "domNodes": -276,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 157.056,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1670.2579999999898,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 17.759,
      "layouts": 6,
      "layoutDurationMs": 1.084,
      "taskDurationMs": 361.72799999999995,
      "heapDeltaBytes": 4386800,
      "heapUsedBytes": 74216252,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.078999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.6240000000198,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.660000000000004,
      "layouts": 6,
      "layoutDurationMs": 1.1270000000000002,
      "taskDurationMs": 354.12199999999996,
      "heapDeltaBytes": 4350760,
      "heapUsedBytes": 73310236,
      "domNodes": 78,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.529999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 659.4230000000039,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.509,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 463.33900000000006,
      "heapDeltaBytes": 18714880,
      "heapUsedBytes": 88613416,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 166.956,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 647.1760000000017,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.4750000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 445.977,
      "heapDeltaBytes": 18654912,
      "heapUsedBytes": 82515388,
      "domNodes": 16,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 162.609,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2081.039999999973,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.596000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 623.4739999999999,
      "heapDeltaBytes": 11232592,
      "heapUsedBytes": 86796488,
      "domNodes": -266,
      "jsHeapTotalBytes": -2203648,
      "scriptDurationMs": 39.458999999999996,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.867999999942,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.630000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 624.6679999999999,
      "heapDeltaBytes": 10143400,
      "heapUsedBytes": 85651144,
      "domNodes": -267,
      "jsHeapTotalBytes": 155648,
      "scriptDurationMs": 34.248,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2519.3239999999832,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.085,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1777.828,
      "heapDeltaBytes": 9847540,
      "heapUsedBytes": 87116148,
      "domNodes": -273,
      "jsHeapTotalBytes": -667648,
      "scriptDurationMs": 907.696,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2321.1219999999457,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.000000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1669.9709999999998,
      "heapDeltaBytes": 8965420,
      "heapUsedBytes": 85266368,
      "domNodes": -271,
      "jsHeapTotalBytes": 118784,
      "scriptDurationMs": 831.724,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3753.071000000034,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.278999999999996,
      "layouts": 60,
      "layoutDurationMs": 12.275999999999998,
      "taskDurationMs": 1785.3470000000002,
      "heapDeltaBytes": 8786188,
      "heapUsedBytes": 76266996,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 815.411,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3616.3210000000845,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.769,
      "layouts": 60,
      "layoutDurationMs": 12.028,
      "taskDurationMs": 1736.615,
      "heapDeltaBytes": 11727868,
      "heapUsedBytes": 80148404,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 776.982,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3156.7100000000323,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 7.064000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1998.8809999999999,
      "heapDeltaBytes": 3542620,
      "heapUsedBytes": 84484220,
      "domNodes": -282,
      "jsHeapTotalBytes": 49152,
      "scriptDurationMs": 985.517,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3078.850999999986,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.749,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1880.297,
      "heapDeltaBytes": 18097160,
      "heapUsedBytes": 86344112,
      "domNodes": 0,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 940.0329999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2058.506999999963,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.408,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 651.397,
      "heapDeltaBytes": 5753912,
      "heapUsedBytes": 83016348,
      "domNodes": -277,
      "jsHeapTotalBytes": -2203648,
      "scriptDurationMs": 37.286,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2019.2739999999958,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.4259999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 564.415,
      "heapDeltaBytes": 21309388,
      "heapUsedBytes": 87267748,
      "domNodes": -271,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 38.783000000000015,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 590.1160000000232,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.384,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 403.67999999999995,
      "heapDeltaBytes": 15042880,
      "heapUsedBytes": 87893848,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 139.94600000000003,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 596.3949999999159,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.879999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 409.868,
      "heapDeltaBytes": 14707480,
      "heapUsedBytes": 87914968,
      "domNodes": 16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 142.178,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.1180000000058,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.352,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.555,
      "heapDeltaBytes": -9816040,
      "heapUsedBytes": 61876208,
      "domNodes": -294,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.538000000000001,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.712999999958,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.612000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 477.67500000000007,
      "heapDeltaBytes": -13360920,
      "heapUsedBytes": 59729456,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 7.077,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1735.7889999999543,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.216000000000005,
      "layouts": 18,
      "layoutDurationMs": 4.719,
      "taskDurationMs": 796.7259999999999,
      "heapDeltaBytes": -7126448,
      "heapUsedBytes": 64513268,
      "domNodes": -294,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 106.124,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1715.820000000008,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 28.266,
      "layouts": 18,
      "layoutDurationMs": 4.779,
      "taskDurationMs": 805.083,
      "heapDeltaBytes": 7782832,
      "heapUsedBytes": 80730420,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 110.17100000000002,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.2330000000475,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 31.260999999999996,
      "layouts": 13,
      "layoutDurationMs": 14.625999999999996,
      "taskDurationMs": 896.1220000000001,
      "heapDeltaBytes": 21946808,
      "heapUsedBytes": 106730800,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 31.165000000000006,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 140,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8753.496999999981,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.459,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5993.853,
      "heapDeltaBytes": 8890800,
      "heapUsedBytes": 85200636,
      "domNodes": -272,
      "jsHeapTotalBytes": -1191936,
      "scriptDurationMs": 2712.184,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8605.409000000009,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 35.999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6032.817,
      "heapDeltaBytes": 6307068,
      "heapUsedBytes": 81911696,
      "domNodes": -246,
      "jsHeapTotalBytes": -143360,
      "scriptDurationMs": 2787.045,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16901.684999999987,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16437.41,
      "heapDeltaBytes": -63031172,
      "heapUsedBytes": 176353928,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19189760,
      "scriptDurationMs": 290.438,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17542.43000000008,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16881.798,
      "heapDeltaBytes": -56603940,
      "heapUsedBytes": 182304332,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12759040,
      "scriptDurationMs": 281.676,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21093.45000000002,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 18.191999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20692.242000000002,
      "heapDeltaBytes": -50592168,
      "heapUsedBytes": 167008764,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10444800,
      "scriptDurationMs": 891.602,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 38,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21015.940000000002,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 18.428,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20670.493000000002,
      "heapDeltaBytes": -47130592,
      "heapUsedBytes": 184051200,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9351168,
      "scriptDurationMs": 920.636,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 63,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6277.107000000001,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.04099999999997,
      "layouts": 20,
      "layoutDurationMs": 21.092,
      "taskDurationMs": 6143.589999999999,
      "heapDeltaBytes": -27815472,
      "heapUsedBytes": 183773532,
      "domNodes": -8068,
      "jsHeapTotalBytes": 11358208,
      "scriptDurationMs": 110.295,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 342,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6275.024999999914,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.79999999999998,
      "layouts": 20,
      "layoutDurationMs": 22.521,
      "taskDurationMs": 6186.3679999999995,
      "heapDeltaBytes": -37995092,
      "heapUsedBytes": 187381668,
      "domNodes": -8068,
      "jsHeapTotalBytes": 13168640,
      "scriptDurationMs": 116.965,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 402,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8604.008000000022,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8408.965,
      "heapDeltaBytes": 1785388,
      "heapUsedBytes": 178359476,
      "domNodes": -1520,
      "jsHeapTotalBytes": -17301504,
      "scriptDurationMs": 138.35599999999997,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8880.604000000061,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8505.427,
      "heapDeltaBytes": 20471676,
      "heapUsedBytes": 178418956,
      "domNodes": 0,
      "jsHeapTotalBytes": -7864320,
      "scriptDurationMs": 137.55399999999995,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 471.44200000002456,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 20.81,
      "layouts": 3,
      "layoutDurationMs": 1.5500000000000003,
      "taskDurationMs": 109.85499999999998,
      "heapDeltaBytes": 4878924,
      "heapUsedBytes": 74108884,
      "domNodes": 149,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.445,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 94.47899999997844,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 12.104999999999999,
      "layouts": 2,
      "layoutDurationMs": 0.7789999999999999,
      "taskDurationMs": 64.489,
      "heapDeltaBytes": 3001240,
      "heapUsedBytes": 71896676,
      "domNodes": 104,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.448,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50286 75334 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.3% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.6% 257
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 22, 2026
@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18317   +/-   ##
=============================================
  Coverage              ?   83.56%           
=============================================
  Files                 ?     2095           
  Lines                 ?   123658           
  Branches              ?    31290           
=============================================
  Hits                  ?   103337           
  Misses                ?    20143           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.76% <ø> (?)
unit 78.50% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/crdt/opCoalescer.ts 100.00% <100.00%> (ø)
src/workbench/extensions/agent/crdt/opSender.ts 100.00% <100.00%> (ø)
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 98.02% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code path clean; merge held.

  • Source semantics are preserved on the release's EcsFollowerAdapter path.
  • Exact head d977ea76b509e2cd7a2230e9df9e05a1c9500aed is conflict-free, terminal-green, and passes the target-aware guard.
  • Acceptance gap: no target-native browser case executes clear canvas → delete/start chat → post an empty draft to the same workflow → re-subscribe without resurrecting nodes.
Full context for agent readers

Requirement-by-requirement coverage:

  • Source applicability — covered. Source pull request 18064 is merged, and this carrier targets cloud/1.54 from target tip 19a4f18b799f228a0faf39d951c22a4fdb53daf8.
  • Production diff — covered. opCoalescer.ts and opSender.ts match the merged source implementation. The follower changes preserve the source's same-tick admission pinning, flush-before-retarget behavior, reset-time abortAll(), and teardown, adapted to this release's EcsFollowerAdapter implementation.
  • Conflict adaptation — covered. The three main-only browser files do not exist on cloud/1.54; the carrier does not silently copy incompatible harness code.
  • Focused unit/component behavior — covered. Tests pin same-tick batching and order, wire-cap splitting, workflow-at-admission, reset/unbind settlement, empty-draft submission, retained workflow identity, and host application of a coalesced clear. Hosted unit checks pass at the exact head.
  • Target-wide regression evidence — covered. Hosted Cloud Playwright reports 1,933 passed and 0 failed; all 80 successful and 13 skipped checks are terminal with no adverse result. The target-aware merge guard reports ready at this exact head.
  • Affected black-box behavior — gap. The merged source includes agentNewChatClearedCanvas.spec.ts, which composes the user clear, delivered delete operations, chat deletion/new chat, same workflow_id, empty first draft, re-subscribe, and final one-marker-node graph. This carrier replaces it with isolated fixture/component tests. Those tests can all pass if the integrated browser path still resurrects the old document, so they do not provide equivalent predictive evidence for the reported regression.
  • Authentic served Cloud behavior — unavailable. The pull request description correctly says backend authority is not proven here. No deployment or served-environment acceptance is inferred.
  • Ownership — preserved. The canonical cloud18064-1 claim remains held by gjp8-cloud-backport18064-20260921; this review does not take over or write its branch.
  • Merge authority — conditional but not exercised. The Agent 1.54 backport grant permits an exact-head admin merge after all gates. The missing composed browser acceptance remains a gate, so no merge is recommended yet.

Executable handoff: the existing gjp8 owner should add or run one target-native composed browser regression equivalent to the source case at this same head (or provide an existing exact-head artifact proving those steps), then rerun the target-aware guard. If the head and target tip remain unchanged and the evidence passes, the existing grant permits the owner to merge with --match-head-commit d977ea76b509e2cd7a2230e9df9e05a1c9500aed and read back cloud/1.54 ancestry.

Glossary: target-native means executed against the actual cloud/1.54 code and harness; composed browser regression means one test traverses all user-visible steps and final graph state; exact head means the reviewed commit identity; served acceptance means behavior demonstrated in a deployed Cloud environment.

@christian-byrne
christian-byrne merged commit 06068f3 into cloud/1.54 Sep 22, 2026
94 checks passed
@christian-byrne
christian-byrne deleted the backport/cloud-1.54-18064-stale-canvas-20260921 branch September 22, 2026 05:47
CodeJuggernaut pushed a commit that referenced this pull request Sep 23, 2026
#18064) (#18317)

## Summary

Backports source PR #18064 to Cloud 1.54 so same-tick human graph
operations are coalesced and pending batches are aborted on a document
reset, preventing a cleared canvas from returning in a new chat.

Source: #18064, merged as `42d44cd31e56071cea90e4a5027ee1d2d7a46830`.
Target: `cloud/1.54` at `19a4f18b799f228a0faf39d951c22a4fdb53daf8`.
Tracking:
https://github.com/christian-byrne/blocked-on-christian/issues/827

## Changes

- **What**: Preserves same-tick operation coalescing, aborts
admitted/in-flight human batches on `doc_reset`, and retains the saved
workflow identity plus empty current draft for a new chat.
- **Dependencies**: None. The release lockfile is unchanged.
- **Target adaptation**: Keeps the release's `EcsFollowerAdapter`;
adapts the removed conversation/socket regression to
`agentConversationHostDoc` and `agentRequestResponseFixture` coverage.

## Review Focus

- Coalescer admission/flush ordering around retarget and reset.
- Release-specific adapter integration and target-harness regression
coverage.
- Backend authority behavior is not proven here; authentic served Cloud
acceptance remains unavailable.

Validation: focused Vitest 8 files / 355 tests; main and browser
typechecks; full lint; format; ADR validation. All passed.

Backport note (core/1.54): two mechanical conflicts, both resolved to
main's end state.
- browser_tests/fixtures/agentConversationHostDoc.test.ts keeps core's
  file. The carrier's extra "coalesced canvas clear" test exists only
  on cloud (main's #18064 never added it). It also calls
  HostDoc.applyClient, which core and main replaced with applyWire.
- useAgentCrdtFollower.test.ts keeps both imports: core's
  GraphOperation and the carrier's BatchOutcome.

(cherry picked from commit 06068f3)
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-docs Agent product architecture, contracts or documentation agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-docs Agent product architecture, contracts or documentation agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants