Repository navigation
feat: mint set_node_field for local title and mode changes - #18283
claude[bot] wants to merge 17 commits into
Conversation
Node-title renames write straight onto the LGraphNode instance (useNodeEventHandlers.ts's handleNodeTitleUpdate) with no CRDT emission, so a rename never syncs to other clients. This test exercises the not-yet-built attachTitleMintPort in isolation, mirroring attachWidgetMintPort's test shape; it fails to resolve the import until the port exists. Verified locally: fails with "Failed to resolve import './titleMintPort'" against the current tree.
Adds a titleMintPort mirroring attachWidgetMintPort/attachLinkMintPort's existing local-mutation-to-CRDT-op pathway: the mint ports already listen to a store's own change notification (widgetValueStore.onValueChange, linkStore's $onAction) and enqueue a semantic GraphOperation through the shared mintPortWiring session/gate. Title has no owning Pinia store - a canvas rename writes straight onto the LGraphNode instance via its tracked `title` setter (setTrackedNodeState) - so this instead listens to the ROOT graph's own `node:property:changed` event, filtered to `property === 'title'`. Listening only on the root graph's event target (never a subgraph's) is what scopes this to top-level nodes, matching `set_title` having no interior/subgraph-instance variant (comfy-multi-player ADR-032). The gate, teardown-bracket suppression during graph load/reconcile, and remote-echo avoidance are all inherited for free from the shared MintSession: reconcile writes go straight into nodeDataStore's NodeState object (Object.assign), never through the tracked setter, so a remote title change from the agent CRDT follower never fires the event this port listens to. Pins @comfyorg/comfy-multi-player to the unmerged comfy-multi-player#232 branch commit (adds the set_title op) via a GitHub tarball URL, following the same allowBuilds pattern already present in pnpm-workspace.yaml for a prior unreleased pin. This needs to move to a released version once #232 merges and ships. Verified locally: pnpm exec vitest run on the full src/workbench/extensions/agent/crdt directory plus layoutStoreMintDelivery.test.ts (52 files, 780 passed, 5 pre-existing expected-fail), pnpm exec vue-tsc --noEmit clean, pnpm exec eslint and oxfmt --check clean on every touched file.
Adds VueNodeHelpers.renameNode (double-click the title, fill node-title-input, press Enter - mirrors EditableText's own confirm path) and an e2e spec asserting the mock host actually receives a set_title:<node_id> doc_ops frame from a real canvas rename, using the same agentConversationFixture/clientDocFrames pattern as agentHumanDeleteTabSwitch.spec.ts. Not runnable in this sandbox: Playwright's chromium download is blocked by the outbound proxy here (cdn.playwright.dev), so this could not be executed locally. Reviewed closely against the real DOM wiring (NodeHeader.vue/EditableText.vue/LGraphNode.vue's handleNodeTitleUpdate) and the mock host's op-string format (agentFollowerHostSocket.ts), but relies on CI for actual execution.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 2127 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since fd49e1f866a8c67df13480b064f0f50ea593ffcb
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.99 MB gzip 🔴 +301 kBDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.73 kB) • 🔴 +38 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.43 MB) • 🔴 +22.2 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 134 kB (baseline 124 kB) • 🔴 +9.77 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 39.4 kB (baseline 27.8 kB) • 🔴 +11.6 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +690 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 125 kB (baseline 117 kB) • 🔴 +8.01 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.97 MB (baseline 3.6 MB) • 🔴 +365 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 576 kB (baseline 559 kB) • 🔴 +17.5 kBHelpers, composables, and utility bundles
Status: 30 added / 30 removed / 6 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -686 kBExternal libraries and shared vendor chunks
Status: 12 added / 12 removed / 6 unchanged Other — 17.9 MB (baseline 16.4 MB) • 🔴 +1.49 MBBundles that do not match a named category
Status: 179 added / 174 removed / 122 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-24T22:22:07.995Z",
"gitSha": "268f704d2e0c770e0a5cf67acbff2de74565aeab",
"branch": "feat/emit-set-title-op",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2000.4640000000222,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.89000000000004,
"heapDeltaBytes": -1410880,
"heapUsedBytes": 60923036,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.484000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2003.48699999995,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.944999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.45900000000006,
"heapDeltaBytes": 2151740,
"heapUsedBytes": 64452740,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.91,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1745.5519999999751,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.607000000000003,
"layouts": 12,
"layoutDurationMs": 4.837,
"taskDurationMs": 721.4200000000001,
"heapDeltaBytes": -4091024,
"heapUsedBytes": 58295140,
"domNodes": -228,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 155.086,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.7440000000843,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.991,
"layouts": 12,
"layoutDurationMs": 4.547000000000001,
"taskDurationMs": 800.569,
"heapDeltaBytes": -3550524,
"heapUsedBytes": 58945180,
"domNodes": -228,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 147.891,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.6630000000346,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.489,
"layouts": 6,
"layoutDurationMs": 1.1900000000000002,
"taskDurationMs": 322.604,
"heapDeltaBytes": 2195544,
"heapUsedBytes": 64473388,
"domNodes": 53,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.149,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.1370000000597,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.836999999999998,
"layouts": 6,
"layoutDurationMs": 1.279,
"taskDurationMs": 318.72299999999996,
"heapDeltaBytes": 2269312,
"heapUsedBytes": 64029844,
"domNodes": 53,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.025,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 656.10700000002,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.568,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.1809999999999,
"heapDeltaBytes": 18452636,
"heapUsedBytes": 80683580,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 156.768,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 665.4280000000199,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.8740000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.44000000000005,
"heapDeltaBytes": 18530380,
"heapUsedBytes": 80903128,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 158.086,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1177.1420000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 860.569,
"heapDeltaBytes": -15284512,
"heapUsedBytes": 72316316,
"domNodes": -259,
"jsHeapTotalBytes": 19267584,
"scriptDurationMs": 57.410000000000004,
"eventListeners": -207,
"totalBlockingTimeMs": 517,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1130.6879999999637,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 786.837,
"heapDeltaBytes": 38216184,
"heapUsedBytes": 106729608,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 56.986,
"eventListeners": 0,
"totalBlockingTimeMs": 518,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 832.2039999999902,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.7880000000005,
"heapDeltaBytes": 13969100,
"heapUsedBytes": 90696996,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 140.45799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 826.383000000078,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.11299999999966,
"heapDeltaBytes": 13938856,
"heapUsedBytes": 90505172,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 136.69499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9620.440000000031,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8760.295,
"heapDeltaBytes": -12810812,
"heapUsedBytes": 69776204,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 7120.077,
"eventListeners": 0,
"totalBlockingTimeMs": 412,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9035.883000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8195.444,
"heapDeltaBytes": -8698264,
"heapUsedBytes": 73618752,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 6596.697,
"eventListeners": 0,
"totalBlockingTimeMs": 148,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9317.347999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8379.041000000001,
"heapDeltaBytes": 2467556,
"heapUsedBytes": 85574156,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6776.2570000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 180,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8783.983999999919,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7940.1,
"heapDeltaBytes": -1328204,
"heapUsedBytes": 81207168,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 6406.0509999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 127,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 1995.5040000000395,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8049999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.475,
"heapDeltaBytes": 19741200,
"heapUsedBytes": 83561468,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.033,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.2409999999763,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.1960000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.7159999999999,
"heapDeltaBytes": -5080748,
"heapUsedBytes": 74891740,
"domNodes": -228,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 34.234,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2189.0980000000013,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.389999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1506.4480000000003,
"heapDeltaBytes": 19369780,
"heapUsedBytes": 83783212,
"domNodes": 0,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 790.015,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2251.596999999947,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.909,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1575.5729999999999,
"heapDeltaBytes": -15491836,
"heapUsedBytes": 65130192,
"domNodes": -228,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 785.639,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3588.0220000000236,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.648,
"layouts": 60,
"layoutDurationMs": 14.88,
"taskDurationMs": 1702.003,
"heapDeltaBytes": -15131656,
"heapUsedBytes": 68330940,
"domNodes": -228,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 790.5949999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3601.962999999955,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.41,
"layouts": 60,
"layoutDurationMs": 15.189000000000002,
"taskDurationMs": 1686.2220000000002,
"heapDeltaBytes": -14267160,
"heapUsedBytes": 69356412,
"domNodes": -228,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 778.981,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3161.5999999999644,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.5840000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1956.1100000000001,
"heapDeltaBytes": -11449836,
"heapUsedBytes": 73901264,
"domNodes": 0,
"jsHeapTotalBytes": 8679424,
"scriptDurationMs": 1016.0609999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 18,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3138.9199999999846,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.213999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1903.4769999999996,
"heapDeltaBytes": -11727780,
"heapUsedBytes": 73493284,
"domNodes": 0,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 1020.47,
"eventListeners": 180,
"totalBlockingTimeMs": 31,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.8639999999932,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.2840000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.9110000000001,
"heapDeltaBytes": 20117436,
"heapUsedBytes": 84415628,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.157,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2029.894000000013,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.066000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.828,
"heapDeltaBytes": -14020188,
"heapUsedBytes": 73128696,
"domNodes": -228,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 31.279,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.9640000000186,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.860999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.84700000000004,
"heapDeltaBytes": 13865040,
"heapUsedBytes": 83426028,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 141.397,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 594.4970000000467,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.345,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.286,
"heapDeltaBytes": 13319548,
"heapUsedBytes": 76953136,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 143.464,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.0669999999873,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.6679999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.023,
"heapDeltaBytes": 416188,
"heapUsedBytes": 63956420,
"domNodes": -244,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.020999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1993.2730000000447,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.046000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.73600000000005,
"heapDeltaBytes": -10581264,
"heapUsedBytes": 59272016,
"domNodes": -244,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.818999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.8849999999857,
"styleRecalcs": 72,
"styleRecalcDurationMs": 17.614,
"layouts": 16,
"layoutDurationMs": 6.023000000000001,
"taskDurationMs": 727.658,
"heapDeltaBytes": 15828912,
"heapUsedBytes": 79193244,
"domNodes": -244,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 101.965,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1697.4239999999554,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.935,
"layouts": 16,
"layoutDurationMs": 5.955,
"taskDurationMs": 746.4620000000001,
"heapDeltaBytes": 4425868,
"heapUsedBytes": 73782232,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 102.092,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 899.8190000000932,
"styleRecalcs": 17,
"styleRecalcDurationMs": 27.186000000000003,
"layouts": 5,
"layoutDurationMs": 11.923000000000004,
"taskDurationMs": 678.7129999999999,
"heapDeltaBytes": -6245012,
"heapUsedBytes": 82052928,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 25.08,
"eventListeners": 2383,
"totalBlockingTimeMs": 124,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8370.544000000053,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.259,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5514.131,
"heapDeltaBytes": 4000196,
"heapUsedBytes": 85257244,
"domNodes": -228,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 2666.689,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8327.020000000062,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.236000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5643.549,
"heapDeltaBytes": -10842780,
"heapUsedBytes": 70608668,
"domNodes": -198,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 2761.915,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17649.031999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16843.055,
"heapDeltaBytes": -38713920,
"heapUsedBytes": 175713448,
"domNodes": -8049,
"jsHeapTotalBytes": -12652544,
"scriptDurationMs": 289.51700000000005,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17599.88999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16895.406000000003,
"heapDeltaBytes": -45970040,
"heapUsedBytes": 192017444,
"domNodes": -8049,
"jsHeapTotalBytes": -11730944,
"scriptDurationMs": 274.071,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20870.50599999998,
"styleRecalcs": 153,
"styleRecalcDurationMs": 17.795000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20560.281,
"heapDeltaBytes": -72388208,
"heapUsedBytes": 168528988,
"domNodes": -8049,
"jsHeapTotalBytes": -20910080,
"scriptDurationMs": 871.025,
"eventListeners": -14923,
"totalBlockingTimeMs": 88,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20898.310000000038,
"styleRecalcs": 161,
"styleRecalcDurationMs": 17.22499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20515.242000000002,
"heapDeltaBytes": -34217052,
"heapUsedBytes": 193314952,
"domNodes": -8053,
"jsHeapTotalBytes": -20193280,
"scriptDurationMs": 835.8389999999999,
"eventListeners": -14926,
"totalBlockingTimeMs": 35,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6165.295000000015,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.635,
"layouts": 20,
"layoutDurationMs": 23.899000000000004,
"taskDurationMs": 6082.071999999999,
"heapDeltaBytes": -50043640,
"heapUsedBytes": 175897556,
"domNodes": -8049,
"jsHeapTotalBytes": 14340096,
"scriptDurationMs": 110.856,
"eventListeners": -14923,
"totalBlockingTimeMs": 332,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6222.671999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.09299999999999,
"layouts": 20,
"layoutDurationMs": 23.057999999999996,
"taskDurationMs": 6170.802,
"heapDeltaBytes": -60302676,
"heapUsedBytes": 177301512,
"domNodes": -8049,
"jsHeapTotalBytes": 14221312,
"scriptDurationMs": 113.549,
"eventListeners": -14923,
"totalBlockingTimeMs": 322,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8821.62900000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8440.563,
"heapDeltaBytes": -6291272,
"heapUsedBytes": 184908360,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 158.74500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8678.503999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8348.629999999997,
"heapDeltaBytes": 9428368,
"heapUsedBytes": 173754728,
"domNodes": 0,
"jsHeapTotalBytes": -6291456,
"scriptDurationMs": 134.59700000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 452.98700000000736,
"styleRecalcs": 16,
"styleRecalcDurationMs": 21.499,
"layouts": 4,
"layoutDurationMs": 1.8980000000000001,
"taskDurationMs": 126.273,
"heapDeltaBytes": 5079680,
"heapUsedBytes": 67299600,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.573,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 112.67800000007355,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.091000000000001,
"layouts": 2,
"layoutDurationMs": 0.811,
"taskDurationMs": 80.453,
"heapDeltaBytes": 3165520,
"heapUsedBytes": 68573060,
"domNodes": 95,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.587,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge.
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18283 +/- ##
==========================================
+ Coverage 83.85% 84.82% +0.97%
==========================================
Files 3028 2303 -725
Lines 149683 132151 -17532
Branches 40588 34410 -6178
==========================================
- Hits 125515 112097 -13418
+ Misses 22864 19753 -3111
+ Partials 1304 301 -1003
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 754 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
# Conflicts: # package.json # pnpm-lock.yaml
comfy-multi-player#235 (28d2e61, main-only, unreleased) adds a generalized set_node_field op superseding the narrower set_title this branch previously minted. Move the tarball pin from the set_title-era commit (bed3660e) to this one, plus the matching pnpm-workspace.yaml allowBuilds entry.
comfy-multi-player#235 replaces the narrow set_title op with a generalized
set_node_field op covering title, mode, flags.collapsed and flags.pinned.
Rework titleMintPort.ts into nodeFieldMintPort.ts: it now emits
{ op: 'set_node_field', node_id, field, value } for both a canvas rename
and a mode change, since LGraphNode's mode setter already goes through
the same tracked setTrackedNodeState path as title (both fire
node:property:changed on the root graph).
flags.collapsed/flags.pinned are also writable set_node_field targets,
but LGraphNode.collapsed/pinned mutate `this.flags` in place rather than
going through setTrackedNodeState, so there is no equivalent tracked
change event to mint them from yet - left as a follow-up rather than
inventing new plumbing.
mintPortWiring.ts's node:property:changed listener now dispatches on
both 'title' and 'mode' to the generalized port. Tests and the
agentHumanRenameMintsSetTitle e2e spec (renamed to
agentHumanRenameMintsSetNodeField) are updated to the new op shape.
# Conflicts: # package.json # pnpm-lock.yaml
|
@coderabbitai review |
The agentConversation fixture requires the @vue-nodes tag on every test using it (agentConversationFixture.ts:1005-1009), and the test already exercises agentConversation.vueNodes.renameNode/getNodeLocator. The tag was missing when the spec was authored/renamed in this PR, causing playwright-video-new-tests to fail with: Error: a conversation replay is judged on Vue nodes; tag the test @vue-nodes Every sibling agentConversationTest spec already carries this tag.
082fece to
3519ba9
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 2 |
| 🟢 Low | 4 |
Panel: 8/8 reviewers contributed findings.
- Remove the stale graph-events listener before re-attaching, so a tab switch cannot leave the old graph minting into the newly bound document (and cannot double-register on a later re-attach). - Skip minting when the emitting graph is not the bound document's own root graph, matching layoutMintPort/widgetMintPort's existing scoping. - Skip a no-op property change (oldValue === newValue), matching a routine `configure()`/replacement reassignment rather than a human edit. - Narrow `mode` to LGraphEventMode's finite members and cap a minted title's length, since paste reaches these setters from JSON-parsed clipboard data. - Defer the node-field mint's enqueue by one microtask so it lands after the layout store's own queued `add_node` flush, fixing paste/ duplicate emitting `set_node_field` for a node the document has not seen `add_node` for yet. - Retry late graph-event attachment from a failed load too, not only from `afterConfigureGraph`. - Drop two comfy-multi-player allowBuilds entries pinned to GitHub tarball SHAs the lockfile no longer resolves to.
…yChanged Splits the title/mode validation branches out of handlePropertyChanged into resolveMintableField (plus resolveTitleMint/resolveModeMint), so the dispatcher is a flat sequence of guard clauses instead of nested type/value checks. Fixes the fallow CRAP finding on handlePropertyChanged (cyclomatic 11, CRAP 37.1) with no behavior change.
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed at a6356d77. I traced the core mechanism end to end and it holds up, so most of this is confirmation plus two things I'd like your read on before approving.
Verified independently (not taking the description's word for it):
- The root cause is real:
useNodeEventHandlers.ts:90doesnode.title = newTitle→LGraphNode's tracked setter →setTrackedNodeState→node.graph?.trigger('node:property:changed'). Nothing in that path produced a CRDT op before this PR. - Echo avoidance holds: the remote apply path is
ecsFollowerAdapter→batch.reconcileNode/reconcileNodeFields→graphMutations.tscommit()→nodeDataStore.updateNode/updateNodeFields→assignNodeFields, which is anObject.assignstraight onto theNodeStateobject. It never goes through the tracked setter, so a peer's rename cannot re-fire this event. (Your "not fixed, needs a design discussion" reply on the provenance-guard thread is accurate — this works by implementation detail, not by an explicit guard.) - Root-graph scoping holds:
Subgraphdeclares its ownoverride readonly events(LGraph.ts:3401), so an interior node's property change genuinely cannot reach the root target. - The op vocabulary is derived, not hand-declared:
graphOperations.tsbuildsGraphOperationfrom the package's ownOpunion, and published@comfyorg/comfy-multi-player@0.3.3(already pinned onmain) carriesset_node_field. No contract drift here. - The other
.mode =writers are fine:useNodeReplacement.ts:247assigns beforenewNode.graph = nodeGraphat line 360, so no event fires;useSelectedLiteGraphItems/SetNodeState.vue/groupOptionsare genuine human edits that should mint. - Ran
nodeFieldMintPort.test.ts+mintPortWiring.test.ts(35 passed) andagentPanel.test.ts+layoutStoreMintDelivery.test.ts(45 passed) on this head.playwright-tests (cloud, frontend-dist-cloud)is green, and the new@cloud-tagged spec matches that project'sgrep, so the e2e claim is actually exercised in CI.
Inline: one question: on the title cap, one suggestion:, two nit-pick:s. Plus one unanchored item below.
Unanchored
question: — the Relationship to #18075 section says "#18075 already shipped the same-client half" and that its baseline-comparison workaround "remains useful as defense-in-depth for titles." #18075 is still open (state: OPEN, mergedAt: null), and neither titleReconcileBaseline nor resolveNodeTitle exists on origin/main or on this branch. So there is no defense-in-depth in the tree today.
This matters because it's the stated cover for the deferred local-dirty-guard finding. My own read is that this PR still reduces that exposure rather than adding to it — assignNodeFields replaces title/mode unconditionally with no equivalent of applyWidgetValues's guardLocalEdits, but before this PR a rename never reached the doc at all, so a reconcile stomp was permanent; now the local op wins by LWW once it round-trips. I'm comfortable with the deferral on that basis, but could you correct the description so the next reader isn't relying on a merged PR that isn't merged?
nit-pick (non-blocking): — the Dependency pin bullet describes a package.json GitHub-tarball pin and matching pnpm-workspace.yaml allowBuilds entries, and says it "needs to move to a released version once it ships." Neither file is in the diff any more (you dropped them in 4478ccdc), and package.json pins the released 0.3.3. Worth deleting that bullet so the merge commit doesn't carry a stale TODO.
- Drop the arbitrary 1000-char title truncation: published comfy-multi-player 0.3.3's set_node_field validator has no length bound on title, so capping it made the minted op silently diverge from local state instead of matching the actual contract. - Derive MINTABLE_NODE_MODES from LGraphEventMode's own values instead of hand-listing its members, so a future enum addition can't silently drop out of sync. - Point the oldValue===newValue guard's comment at the callers that actually need it (litegraphService.ts, LGraphCanvas.ts, useNodeErrorFlagSync.ts, which build the event detail directly), not the tracked-setter callers that can never trigger it. - Note in a comment that the re-attach branch in tryAttachGraphEvents is unreachable in production and that firedByBoundRootGraph() is the real guard against minting into an outgoing document.
# Conflicts: # src/workbench/extensions/agent/crdt/mintPortWiring.test.ts
# Conflicts: # src/extensions/core/agentPanel.test.ts
The microtask deferral added to order set_node_field mints after the layout store's add_node flush captured the gate at enqueue time but never rechecked it before acting. A detach, teardown, or flag/doc-bound change landing between enqueue and the microtask running could still let a stale write through. Recheck the gate (and a detached flag) right before the callback enqueues, and add tests covering enqueue -> unsettle -> microtask runs -> no mint for each case.
# Conflicts: # src/extensions/core/agentPanel.test.ts
|
@dante01yoon Both unanchored points from your review are addressed in 2b5342b: the PR description now correctly states #18075 is still open/unmerged (no defense-in-depth in main yet), and the stale "Dependency pin" bullet about the GitHub-tarball pin has been removed now that Generated by Claude Code |
# Conflicts: # .oxlintrc.json
|
🔗 Commit SHA: b2ec2d8 | Docs | View more details | Give us feedback! |
Extracted from FE #18283 so the gap is recorded before the remote-apply refactor (Linear FE-2504, FE #18700) changes where outbound ops are minted. The code half of #18283 mints from a store side effect and stays parked; only the black-box case comes here. On `main` a canvas rename changes the title locally and sends no `doc_ops` frame at all, so the document keeps the old title: the agent's next turn reasons about a name the user has already changed, and a reload that reprojects from the document loses the rename. Pinned with `test.fail()` below the visible-title assertion, which already passes. `set_node_field` is in the shared vocabulary's FROZEN_OPS, and `flags.collapsed`/`flags.pinned`/`title`/`mode` are its writable fields, so the op name pinned here belongs to the op layer rather than to this repo's current plumbing.
|
parking this implementation under the current graph-apply freeze disposition ( |
`opLabel` collapses an op to `op:node_id`, so `toEqual(['set_node_field:4'])` was satisfied by a `set_node_field` on node 4 carrying `field: 'mode'`, or carrying `field: 'title'` with the wrong value. The mint this pin is extracted from (#18283) covers title *and* mode changes, so that is the confusion most likely to actually occur. Adds `ClientDocFrame.opPayloads` -- the op objects as they arrived -- and projects op/node_id/field/value in the spec. Typed as a plain record rather than a wire-op type for the reason `WireOpEnvelope` already documents: the applier's `validateEnvelope` judges payload shape, not this fixture. Kept as ONE assertion. Inside a `test.fail()` body the first failing expect aborts the rest, so a separate follow-up payload check would be dead code in exactly the state this pin describes. Verified by lifting both projections out and running them against synthetic frames: the old label form accepts a wrong `field` AND a wrong title value (both vacuous); the new form rejects both and still accepts the correct op.
|
Closing: the behavior this draft set out to add is on main and in the Comfy Cloud production build. Since #18700, the node's |
Before / After
Before: a canvas rename (
useNodeEventHandlers.ts'shandleNodeTitleUpdate) writes straight onto theLGraphNodeinstance and never produces a CRDT op, so it never syncs to other clients — the root cause PR #18075 worked around client-side (compares the incoming payload against a locally-remembered baseline so a client never stomps its own rename on reconcile). That workaround does nothing for actual cross-client sync: the doc'stitlefield is still silent on every rename, for every client but the one that made it.After: a local canvas rename or mode change mints a
set_node_fieldop through the existing local-mutation-to-CRDT-op pathway, the same oneset_widget/connect/disconnect/layout ops already use.Superseded by comfy-multi-player#235
This PR originally minted a narrow, package-local
set_titleop against an unmerged comfy-multi-player branch. comfy-multi-player#235 landed onmainfirst with a generalized replacement,set_node_field— a closed-set, per-field LWW register (title,mode,flags.collapsed,flags.pinned) that avoids the whole-node clobber anadd_nodeupsert would otherwise cause.set_titleno longer exists in the op vocabulary at all. This PR now wires the realset_node_fieldop instead.Does a local-mutation-to-CRDT-op pathway already exist? Yes.
src/workbench/extensions/agent/crdt/mintPortWiring.tsalready wires mint ports (widgetMintPort.ts,linkMintPort.ts,layoutMintPort.ts) that each listen to a store's own change notification and enqueue a semanticGraphOperationthrough a sharedMintSession/shouldMintgate. Local human edits already feed back into the CRDT doc for widgets, links, and layout.title(and, as of this PR,mode) are the local mutations with no owning Pinia store the way widgets/links do — a rename or a mode toggle writes directly onto theLGraphNodeinstance via its own tracked setter:setTrackedNodeState(src/core/graph/nodeShell/nodeShellState.ts) already fires anode:property:changedevent on the node's owning graph whenever a tracked field actually changes — an existing, unused-by-any-mint-port change-notification signal, exactly analogous towidgetValueStore.onValueChange.modegoes through the exact same tracked setter astitle, so it gets the same treatment for free.What this PR builds
nodeFieldMintPort.ts(renamed/reworked fromtitleMintPort.ts, mirrorswidgetMintPort.ts): on a title or mode change, mints{ op: 'set_node_field', node_id, field, value }.mintPortWiring.ts: subscribes to the root graph's ownnode:property:changedevent (never a subgraph's), filtered toproperty === 'title'orproperty === 'mode'. Subscribing only on the root graph's event target is what scopes this to top-level nodes —set_node_fieldhas no interior/subgraph-instance variant, so subgraph-interior fields are structurally never observed, not filtered out by extra logic.app.rootGraphexists yet: retries ononAfterGraphConfigure().nodeDataStore'sNodeStateobject viaObject.assign, never through the tracked setter, so a remote field change never fires the event this port listens to.flags.collapsed/flags.pinnedare also writableset_node_fieldtargets, but not wired here:LGraphNode.collapsed/pinnedmutatethis.flagsin place rather than going throughsetTrackedNodeState, so there is no equivalent tracked change event to mint them from yet. Flagging as follow-up rather than inventing new plumbing beyond what already exists (a whole-nodeadd_nodeupsert stopgap for these is being explored separately in feat(agent-crdt): write local collapse/pin changes back to the document #18281, which is explicit that it is not meant to merge as-is).Known, accepted gaps (not attempted here)
flags.collapsed/flags.pinned— see above.node:property:changedand mint a redundantset_node_fieldimmediately after that node's ownadd_node. This is harmless (LWW, identical value) but not specifically tested here.set_node_fieldthe same way undo/redo of a widget edit already mintsset_widgettoday (neither is wrapped inrunMintPortsSuppressed) — consistent with existing behavior, not a new risk.Relationship to #18075 and #18281
#18075 is still open (not merged) — its client-side baseline-comparison workaround is not in the tree today. Once merged, it would add useful defense-in-depth for titles on top of this PR's fix; it isn't shipped yet, so there is no such defense-in-depth in
mainright now. #18281 is a separate, explicitly-draft/spike exploration of collapse/pin writeback via a whole-nodeadd_nodeupsert stopgap; this PR does not touch that path and leaves the eventual swap toset_node_fieldfor collapse/pin as its own follow-up.Testing
src/workbench/extensions/agent/crdt/nodeFieldMintPort.test.ts(renamed/reworked fromtitleMintPort.test.ts): isolated port unit tests, table-driven overtitle/mode(product-flag gate, doc-bound gate, teardown-bracket suppression, detach).mintPortWiring.test.ts: table-driven overtitle/modefor the top-level mint case, plus non-writable-property, teardown suppression, late-attachment, and detach cases updated to the new op shape.browser_tests/tests/agent/agentHumanRenameMintsSetTitle.spec.tsrenamed toagentHumanRenameMintsSetNodeField.spec.ts, updated to assert aset_node_field:<node_id>doc_opsframe.pnpm typecheck: clean (full monorepo).pnpm exec eslint/ lint-staged (oxfmt, oxlint, eslint, typecheck) on every touched file via the pre-commit hook: clean.pnpm exec vitest runonsrc/workbench/extensions/agent/crdt(52 files) +layoutStoreMintDelivery.test.ts: all passing, 5 pre-existing expected-fail (unrelated).pnpm knip: no new findings..github/scripts/check-ai-co-authors.shagainst currentmaintip: clean, no AI co-author trailers.Fixes the cross-client half of the title-stomp bug (Slack thread linked below); #18075 (still open) targets the same-client half.
Requested by Christian Byrne · Slack thread
🤖 Generated with Claude Code
https://claude.ai/code/session_01L4WMaCPdk7KSva7vwKfz19