Repository navigation
fix website ComingSoon pages to use locale aware i18n text - #18234
theluckystrike wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged. |
📦 Bundle:
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe ComingSoon component now gets a translation function from ChangesComingSoon localization
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to The affected Chinese pages should render Chinese Coming Soon text. No merge-blocking issue remains after normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: Linked Issues checkExplanation For issue
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
I have read and agree to the Contributor License Agreement |
The ComingSoon component hardcoded English, so /zh-CN/case-studies and /zh-CN/videos showed English text. Read the per-request translator set by the i18n middleware and render the existing demos.comingSoon keys, which already have en and zh-CN strings. ja falls back to en.
75f8197 to
2ac1b4d
Compare
|
This PR makes the ComingSoon page show Chinese text on /zh-CN/case-studies and /zh-CN/videos instead of hardcoded English. Since I opened it, #18013 moved the website copy to vue-i18n. I rebased on main and rewrote the change to use Is |
|
Closing this as superseded, with the reason on the record. I rebased the branch onto current For the record on scope, the branch was one commit: 1 file, +8/-2, with no other conflicts on rebase. The underlying fix is still real, the ComingSoon page served hardcoded English on /zh-CN/case-studies and /zh-CN/videos, but the code it patches no longer lives here. Rather than leave a conflicted PR open against a deleted directory, I'm closing it. If the current site repository would take the equivalent change, I'm glad to redo it there. |
The ComingSoon component on the marketing website shows hardcoded English text, so Chinese visitors on the zh-CN case studies and videos pages see English. The issue lists this case in the ComingSoon.astro bullet.
This change makes the component read the per-request translator from
Astro.locals.t, which the i18n middleware sets from the URL locale since #18013. It renders the existingdemos.comingSoon.titleanddemos.comingSoon.bodykeys, which already have en and zh-CN strings. No page files change. ja has no comingSoon strings yet, so it falls back to en.Part of #12261