Skip to content

fix website ComingSoon pages to use locale aware i18n text - #18234

Closed
theluckystrike wants to merge 1 commit into
Comfy-Org:mainfrom
theluckystrike:i18n-website-coming-soon
Closed

theluckystrike wants to merge 1 commit into
Comfy-Org:mainfrom
theluckystrike:i18n-website-coming-soon

Conversation

@theluckystrike

@theluckystrike theluckystrike commented Sep 21, 2026 •

Copy link
Copy Markdown

The ComingSoon component on the marketing website shows hardcoded English text, so Chinese visitors on the zh-CN case studies and videos pages see English. The issue lists this case in the ComingSoon.astro bullet.

This change makes the component read the per-request translator from Astro.locals.t, which the i18n middleware sets from the URL locale since #18013. It renders the existing demos.comingSoon.title and demos.comingSoon.body keys, which already have en and zh-CN strings. No page files change. ja has no comingSoon strings yet, so it falls back to en.

Part of #12261

@theluckystrike
theluckystrike requested review from a team September 21, 2026 00:45
@vercel

vercel Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 21, 2026 12:45am UTC

Request Review

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

✅ All contributors have signed the CLA. Thank you! This PR is ready to be merged.
Posted by the CLA Assistant Lite bot.

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: ⚠️ Size data collection failed — check the CI workflow logs

⚡ Performance: ⚠️ Performance tests failed — check the CI workflow logs

🔬 E2E Coverage: ⚠️ Coverage collection failed — check the CI workflow logs

🎭 Playwright: ⏳ Running...

🎨 Storybook: ❌ Failed

❌ Storybook failed. Open the workflow run and fix the build before merging.

Details

⏰ Completed at: 11/02/2026, 10:52:32 AM UTC

Links

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: a7b62869-60c3-4f62-8b70-eea73f8c498a
📥 Commits

Reviewing files that changed from the base of the PR and between 75f8197 and 2ac1b4d.

📒 Files selected for processing (1)
  • apps/website/src/components/common/ComingSoon.astro

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The ComingSoon component now gets a translation function from Astro.locals and uses it to render its title and body.

Changes

ComingSoon localization

Layer / File(s) Summary
Localized ComingSoon rendering
apps/website/src/components/common/ComingSoon.astro
The component replaces hardcoded English text with translation lookups for the title and body.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: benceruleanlu

Merge Risk: ⚪ Minimal · up to 2ac1b

The affected Chinese pages should render Chinese Coming Soon text. No merge-blocking issue remains after normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 2ac1b

The change affects 1 system.

Changed systems: apps/website

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — apps/website (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in apps/website/src/components/common/ComingSoon.astro: Added Astro.locals.t access and replaced the hardcoded title and body with translation lookups for demos.comingSoon.title and demos.comingSoon.body.
🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning For issue #12261, the diff replaces the two hardcoded strings in ComingSoon.astro with Astro.locals.t calls. It does not address the issue's other listed hardcoded page and component strings or th… Complete the remaining applicable localization work listed in #12261, including the page and component strings and the requested locale handling. Add or update automated tests to verify localized output on the zh-CN pages.
✅ Passed checks (6 passed)
Check name Status Explanation
Out of Scope Changes check ✅ Passed The whole-PR diff changes only apps/website/src/components/common/ComingSoon.astro. Replacing its hardcoded text with translation calls directly addresses the ComingSoon localization objective in #1…
End-To-End Regression Coverage For Fixes ✅ Passed The PR title and commit subject use bug-fix language. The available changed-file metadata identifies only apps/website/src/components/common/ComingSoon.astro. The check excludes changes exclusively …
Website End-To-End Regression Coverage ✅ Passed The described change replaces hardcoded ComingSoon copy with locale-aware translated text. The check explicitly excludes translation-only changes, so it does not require a website Playwright regressio…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The PR summary identifies only apps/website/src/components/common/ComingSoon.astro as changed. That file is outside src/lib/litegraph/, src/ecs/, and the listed graph-entity areas, so this check…
Title check ✅ Passed The title clearly summarizes the change: the website ComingSoon pages now use locale-aware text.
Description check ✅ Passed The description explains the issue, the localization change, the translation keys, and the affected pages. It does not use the template headings or include a review focus, but it provides the key info…
Full details: Linked Issues check

Explanation

For issue #12261, the diff replaces the two hardcoded strings in ComingSoon.astro with Astro.locals.t calls. It does not address the issue's other listed hardcoded page and component strings or the requested localization of model labels and duplicated zh-CN pages. The zh-CN pages still render <ComingSoon /> without an explicit locale, so this diff also does not establish which locale the calls use.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@theluckystrike

Copy link
Copy Markdown
Author

I have read and agree to the Contributor License Agreement

comfy-legal added a commit to Comfy-Org/comfy-cla that referenced this pull request Sep 21, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 21, 2026
The ComingSoon component hardcoded English, so /zh-CN/case-studies and
/zh-CN/videos showed English text. Read the per-request translator set by
the i18n middleware and render the existing demos.comingSoon keys, which
already have en and zh-CN strings. ja falls back to en.
@theluckystrike

Copy link
Copy Markdown
Author

This PR makes the ComingSoon page show Chinese text on /zh-CN/case-studies and /zh-CN/videos instead of hardcoded English.

Since I opened it, #18013 moved the website copy to vue-i18n. I rebased on main and rewrote the change to use Astro.locals.t from the new middleware. It is now a one-file change, head 2ac1b4d, and Prettier passes on it.

Is Astro.locals.t the pattern you want in shared components, or should ComingSoon take the translator as a prop?

@theluckystrike

Copy link
Copy Markdown
Author

Closing this as superseded, with the reason on the record.

I rebased the branch onto current main to see what was actually left to reconcile. There is exactly one conflict and it is modify/delete on apps/website/src/components/common/ComingSoon.astro. The file is gone upstream, removed in 59201a9 (chore(website): remove the migrated website from the frontend, #21861, 2026-10-26) now that comfy.org and the Hub deploy from a separate repository. git grep -il "coming soon" origin/main -- apps/website/src returns nothing, so there is no surviving location for this change to move to inside this repo.

For the record on scope, the branch was one commit: 1 file, +8/-2, with no other conflicts on rebase.

The underlying fix is still real, the ComingSoon page served hardcoded English on /zh-CN/case-studies and /zh-CN/videos, but the code it patches no longer lives here. Rather than leave a conflicted PR open against a deleted directory, I'm closing it. If the current site repository would take the equivalent change, I'm glad to redo it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant