Repository navigation
chore(agent): close the minor review threads from #16856 - #18230
Conversation
🎭 Playwright: ✅ 2071 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d09ca500f0d2560616c5705863bb1e5edfdd148b
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.95 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.87 MB (baseline 3.87 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 301 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-21T00:08:30.123Z",
"gitSha": "250d0006bf469d809bd826f92fefa4c08c7e1c9e",
"branch": "christian-byrne/fe-16856-batch1",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.6210000000192,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.675,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.5920000000001,
"heapDeltaBytes": 14107440,
"heapUsedBytes": 76007096,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.043999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2012.0000000000573,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.477999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.421,
"heapDeltaBytes": 14269996,
"heapUsedBytes": 75286652,
"domNodes": -265,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.236999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1905.5700000000115,
"styleRecalcs": 80,
"styleRecalcDurationMs": 35.65,
"layouts": 14,
"layoutDurationMs": 4.638,
"taskDurationMs": 947.5440000000001,
"heapDeltaBytes": 15694948,
"heapUsedBytes": 77812656,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 174.868,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1891.9969999999466,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.375,
"layouts": 14,
"layoutDurationMs": 4.454000000000001,
"taskDurationMs": 916.0790000000001,
"heapDeltaBytes": -6049356,
"heapUsedBytes": 55929872,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 171.754,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.9060000000236,
"styleRecalcs": 32,
"styleRecalcDurationMs": 22.253999999999998,
"layouts": 6,
"layoutDurationMs": 1.781,
"taskDurationMs": 478.5930000000001,
"heapDeltaBytes": 2184960,
"heapUsedBytes": 64278236,
"domNodes": 74,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 19.171,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.5940000000392,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.188999999999997,
"layouts": 6,
"layoutDurationMs": 1.248,
"taskDurationMs": 373.92299999999994,
"heapDeltaBytes": 2265052,
"heapUsedBytes": 63783768,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 13.033999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 865.4579999999896,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.876999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.945,
"heapDeltaBytes": 18787020,
"heapUsedBytes": 79872512,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 211.527,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 726.4189999999644,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.600000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.78000000000003,
"heapDeltaBytes": 18229968,
"heapUsedBytes": 80352516,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 167.259,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2059.028000000012,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.641,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 805.8760000000001,
"heapDeltaBytes": 2884120,
"heapUsedBytes": 83691928,
"domNodes": -252,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 41.851,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2036.0919999999396,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.923000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 633.9139999999999,
"heapDeltaBytes": 2283352,
"heapUsedBytes": 83326672,
"domNodes": -249,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 34.410999999999994,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2779.0130000000204,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.258000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1781.549,
"heapDeltaBytes": 7634512,
"heapUsedBytes": 88574888,
"domNodes": -255,
"jsHeapTotalBytes": 1003520,
"scriptDurationMs": 960.218,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2398.130999999921,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.139000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1697.975,
"heapDeltaBytes": 19346620,
"heapUsedBytes": 83938036,
"domNodes": -254,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 865.458,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4003.972000000033,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.594999999999997,
"layouts": 60,
"layoutDurationMs": 14.331,
"taskDurationMs": 1993.592,
"heapDeltaBytes": 8167688,
"heapUsedBytes": 74403040,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 924.321,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3669.8000000000093,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.075999999999999,
"layouts": 60,
"layoutDurationMs": 13.582,
"taskDurationMs": 1783.7200000000003,
"heapDeltaBytes": 8432276,
"heapUsedBytes": 74303936,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 827.0509999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3259.7489999999993,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.631999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2143.604,
"heapDeltaBytes": 834168,
"heapUsedBytes": 66710140,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1097.261,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3140.3179999999793,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.160999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2030.493,
"heapDeltaBytes": 27293860,
"heapUsedBytes": 93529000,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 1069.8780000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.0790000000293,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.492999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 795.665,
"heapDeltaBytes": -3951040,
"heapUsedBytes": 84127568,
"domNodes": -251,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 40.403999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.8020000000988,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.389000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.97999999999985,
"heapDeltaBytes": -5376372,
"heapUsedBytes": 82668708,
"domNodes": -254,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 37.256,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 723.3060000000364,
"styleRecalcs": 44,
"styleRecalcDurationMs": 10.481,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.68999999999994,
"heapDeltaBytes": 14203056,
"heapUsedBytes": 77311204,
"domNodes": 14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 160.12199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.0050000000147,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.258000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.50699999999995,
"heapDeltaBytes": 14613084,
"heapUsedBytes": 78084600,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 145.21900000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.2080000000014,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.807,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.195,
"heapDeltaBytes": 12225536,
"heapUsedBytes": 75655004,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.588999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.1300000000138,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.021999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.19500000000005,
"heapDeltaBytes": -9119496,
"heapUsedBytes": 54417808,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.552999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.9910000000023,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.995,
"layouts": 18,
"layoutDurationMs": 5.931,
"taskDurationMs": 858.916,
"heapDeltaBytes": 11603848,
"heapUsedBytes": 74094600,
"domNodes": -276,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 118.32200000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.8020000000542,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.286999999999995,
"layouts": 18,
"layoutDurationMs": 5.805999999999999,
"taskDurationMs": 852.0070000000001,
"heapDeltaBytes": 17533876,
"heapUsedBytes": 80900444,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 118.93,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.5200000000423,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.311000000000003,
"layouts": 5,
"layoutDurationMs": 13.267999999999999,
"taskDurationMs": 947.58,
"heapDeltaBytes": -6603968,
"heapUsedBytes": 86860620,
"domNodes": 13587,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 32.507,
"eventListeners": 2383,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10639.708999999983,
"styleRecalcs": 245,
"styleRecalcDurationMs": 39.651,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6845.018,
"heapDeltaBytes": 21079256,
"heapUsedBytes": 84400440,
"domNodes": -255,
"jsHeapTotalBytes": 1503232,
"scriptDurationMs": 3203.795,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8417.578000000049,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.051,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5460.622,
"heapDeltaBytes": -12290980,
"heapUsedBytes": 67836648,
"domNodes": -248,
"jsHeapTotalBytes": 3399680,
"scriptDurationMs": 2878.63,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 18442.905999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18056.271,
"heapDeltaBytes": -30744460,
"heapUsedBytes": 185953320,
"domNodes": -8061,
"jsHeapTotalBytes": -11472896,
"scriptDurationMs": 321.055,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17555.746999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17055.721,
"heapDeltaBytes": -48836532,
"heapUsedBytes": 174902948,
"domNodes": -8061,
"jsHeapTotalBytes": -16125952,
"scriptDurationMs": 331.546,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20638.976000000013,
"styleRecalcs": 152,
"styleRecalcDurationMs": 18.508000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20458.677000000003,
"heapDeltaBytes": -34699820,
"heapUsedBytes": 180227240,
"domNodes": -8061,
"jsHeapTotalBytes": -15282176,
"scriptDurationMs": 868.3299999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 123,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21171.70299999998,
"styleRecalcs": 151,
"styleRecalcDurationMs": 18.654000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20937.014000000003,
"heapDeltaBytes": -24266880,
"heapUsedBytes": 190782796,
"domNodes": -8061,
"jsHeapTotalBytes": -15876096,
"scriptDurationMs": 901.926,
"eventListeners": -14928,
"totalBlockingTimeMs": 42,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6057.887999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.07799999999997,
"layouts": 20,
"layoutDurationMs": 22.997000000000003,
"taskDurationMs": 5987.459999999999,
"heapDeltaBytes": -51292132,
"heapUsedBytes": 179728016,
"domNodes": -8061,
"jsHeapTotalBytes": 15134720,
"scriptDurationMs": 113.85399999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 435,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6185.238000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.52500000000002,
"layouts": 20,
"layoutDurationMs": 23.62600000000001,
"taskDurationMs": 6121.465999999999,
"heapDeltaBytes": -35268828,
"heapUsedBytes": 181714588,
"domNodes": -8061,
"jsHeapTotalBytes": 12644352,
"scriptDurationMs": 115.142,
"eventListeners": -14928,
"totalBlockingTimeMs": 407,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8501.178999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8372.65,
"heapDeltaBytes": 24016204,
"heapUsedBytes": 179770592,
"domNodes": 0,
"jsHeapTotalBytes": -7077888,
"scriptDurationMs": 134.2589999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8807.71799999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8617.107,
"heapDeltaBytes": -10470680,
"heapUsedBytes": 170247144,
"domNodes": 0,
"jsHeapTotalBytes": -25952256,
"scriptDurationMs": 139.53400000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 481.93400000002384,
"styleRecalcs": 20,
"styleRecalcDurationMs": 27.726,
"layouts": 5,
"layoutDurationMs": 2.511,
"taskDurationMs": 143.123,
"heapDeltaBytes": 5279652,
"heapUsedBytes": 66718152,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 17.685999999999996,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 113.54300000004969,
"styleRecalcs": 9,
"styleRecalcDurationMs": 21.926000000000002,
"layouts": 3,
"layoutDurationMs": 1.7190000000000003,
"taskDurationMs": 91.50800000000001,
"heapDeltaBytes": 3097616,
"heapUsedBytes": 64768536,
"domNodes": 133,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.721000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Seven mechanical threads left open when #16856 merged. No shipped behavior changes: the only `src` production edit inlines a one-line helper, and everything else is a test, a story, or the browser spec. - FE-2310: inline `generation !== loadGeneration` at the three `performSend` checkpoints and delete `sendWasSuperseded`. The helper was a literal one-line alias, so the three call sites keep the exact same comparison against the same closure variable. - FE-2314: `Unavailable` rendered `kind: 'member'`, so no story exercised the `unavailable` presentation that `agentPaywallPresentation` makes the default and `AgentPaywallCard` gives its own body key. The old story is renamed `ServiceErrorMessage` (it demonstrates the `message` override, which suppresses the body key entirely), and `Unavailable` now renders `{ kind: 'unavailable' }` with no message so the branch actually renders. - FE-2387: split the `pending | denied | unresolved-role` table in `AgentPanelRoot.test.ts`. `pending` and `denied` had identical effective inputs because the root never reads `isReady`, and the row needed a conditional to vary workspace role. Now two explicit wiring tests, one for unresolved capabilities and one for an unresolved role, sharing an assertion helper. Pending-versus-denied capability policy stays with `useBillingCapabilities.test.ts`. - FE-2388: the member-policy case in `agentPaywallPresentation.test.ts` also asserted the local override, and the table below repeated the local branch while varying member capability, so one local regression failed under two policy names. Now one cloud member-capability table and one standalone local-override test; every input/expectation pair from before is still covered. - FE-2389: renamed the `AgentPaywallCard` case that claimed Add credits is "primary" to what it observes - the copy, the two offered actions, and the value each emits. Visual hierarchy is the Storybook surface. - FE-2463: the admission-paywall route override in `agentPanel.spec.ts` shadowed the fixture's GET handler for the same URL; it is now scoped to POST and falls back otherwise. The ad-hoc inline body is replaced by a module-level literal parsed through `zAgentAdmissionError`, the same typed pattern `agentPaywallSubscribe.spec.ts` already uses. - FE-2464: wrapped that test's four phases in behavior-named `test.step` blocks, matching the diagnostic-report flow below it, so a trace failure names the phase. FE-2311 is not included: the hand-written admission shape it targeted (`admissionNoticeText`) no longer exists on main, and the surviving `parseAdmissionError` already infers `reason` from `zAgentAdmissionError`, so the union is not widened.
33628b2 to
55e434e
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe PR strengthens agent paywall test coverage, validates admission-error fixtures, separates unresolved capability and role cases, expands paywall stories and event assertions, and performs direct load-generation checks during message sending. ChangesAgent admission and paywall behavior
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Suggested reviewers: 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18230 +/- ##
==========================================
+ Coverage 83.00% 83.99% +0.99%
==========================================
Files 2956 2260 -696
Lines 145787 128760 -17027
Branches 39463 32836 -6627
==========================================
- Hits 121006 108148 -12858
+ Misses 23511 20322 -3189
+ Partials 1270 290 -980
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 705 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approving. I traced each of the seven threads against the head SHA and the changes are behavior-preserving as described. Findings below are all non-blocking.
Verified
useAgentSession.ts:const generation = loadGeneration(L397) and the three inlinedgeneration !== loadGenerationchecks are byte-for-byte the deleted helper's body, same closure variable, same call order. No remaining references tosendWasSupersededanywhere in the repo.AgentPanelRoot.test.ts: confirmedAgentPanelRoot.vuenever readsisReady— the only capability reads arehasResolvedCapabilitiesandcanTopUp(L136) andworkspaceRole(L141). Sopendinganddeniedreally did have identical effective inputs here and dropping that dimension loses no coverage in this file.agentPaywallPresentation.test.ts: every input/expectation pair from the old two tests survives. Thetier: 'STANDARD' → 'TEAM'change in the member case is inert becauserole === 'member' && !canTopUpreturns beforetieris read.agentPanel.spec.ts: the fixture registers its**/api/agent/threads/*/messageshandler inmockAgentBootduringpagefixture setup, i.e. before the test body. Playwright matches handlers in reverse registration order, so the POST-scoped handler wins androute.fallback()correctly reaches the fixture's GET branch.zAgentAdmissionErroris a genuine re-export of the generated@comfyorg/ingest-types/zodschema, so the "generated admission contract" framing in the comment is accurate — this moves the fixture toward the contract-first workflow rather than away from it.AgentPaywallCard.vueL57 is{{ message || $t(bodyKey) }}, so your reasoning for droppingmessagefrom the newUnavailablestory is right: keeping it as the thread proposed would have suppressed thebodyKeythe thread was about.
On FE-2311 — the second pair of eyes you asked for
I agree it is already fixed; no edit to make. Confirmed on head:
admissionNoticeTextdoes not appear anywhere undersrc/orbrowser_tests/.parseAdmissionError(useAgentSession.tsL102-110) returns{ ...parsed.data.error, retryAfterSeconds }whereparsed.data.errorcomes straight from the generatedzAgentAdmissionError, soreasonis the narrow'no_funds' | 'manual_block' | 'funds_unavailable'union andmessageisstring. Nothing widens it on the way out.- The sole consumer,
recordSendError(L357-375), branches onadmission.reason === 'no_funds'and=== 'funds_unavailable', both members of that union, so a renamed reason fails typecheck rather than silently falling through.
Safe to close the ticket as already-fixed.
Validation
Static review against the PR head plus CI: 86 checks pass, 0 fail, 16 skipped; Playwright 2071 passed / 0 failed, which exercises the rewritten admission-paywall case. I did not install the monorepo's dependencies to re-run vitest locally — for a behavior-preserving refactor with green CI and your reported local run on 33628b25c0, that seemed disproportionate. Flagging it so the gap is explicit.
| it('withholds purchase actions while the workspace role is unresolved, without inventing a sales-managed plan', async () => { | ||
| paywallCapabilities.canTopUp = false | ||
| paywallCapabilities.canSubscribeSelfServe = false | ||
| paywallWorkspace.role = undefined |
There was a problem hiding this comment.
suggestion (non-blocking): could we set paywallCapabilities.hasResolvedCapabilities = true explicitly here?
The old table set it per case (hasResolvedCapabilities = state === 'unresolved-role', so true for this one). This test now inherits true from the beforeEach default at L349 instead. That is correct today, but it makes the two tests depend on a default 400 lines away to stay distinct: if someone flips that default to false, this test silently becomes a duplicate of the capabilities are unresolved case above and the role dimension stops being covered — with both tests still green.
An explicit assignment would keep the isolation your comment at L666 describes ("Each unresolved input is its own wiring test") enforced locally rather than by convention.
There was a problem hiding this comment.
Tracked as FE-2575. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
| } | ||
|
|
||
| // The default presentation. No `message`, so its own body key renders. | ||
| export const Unavailable: Story = { |
There was a problem hiding this comment.
question (non-blocking, pre-existing): now that something finally renders this state, is the copy what we want for it?
unavailable maps to bodyKeys.unavailable = 'agent.paywall.body.subscriptionRequired' in AgentPaywallCard.vue L27, which is "You've run out of available credits." — and none of showAddCredits / showSubscribe / showUpgrade match unavailable, so the card renders that sentence with no action at all.
But unavailable is DEFAULT_AGENT_PAYWALL_PRESENTATION, which AgentPanelRoot.vue L136 returns when capabilities have not resolved — the "we don't know yet" state. So a user whose capability lookup hasn't landed is told definitively that they are out of credits, with no remediation offered.
This is on main already and clearly outside the scope of a thread-closing chore, so nothing to change here. But this story is exactly the surface that makes it visible, which was the thread's point — worth a ticket rather than letting the new story normalize it?
There was a problem hiding this comment.
Tracked as FE-2576. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
| it('makes Add credits primary for a subscribed owner', async () => { | ||
| // Visual hierarchy is the Storybook surface's contract; this asserts the copy, | ||
| // the offered actions, and what each emits. | ||
| it('offers Upgrade plan and Add credits to a subscribed owner and emits each action', async () => { |
There was a problem hiding this comment.
suggestion (non-blocking): kind: 'unavailable' still has no assertion in this file.
The it.for tables below cover member, salesManaged, subscriptionRequired, local, and subscribed (both showUpgrade values), but not unavailable. The new Storybook story is visual-only — there is no storybook test-runner or play-function wired up in this repo (package.json has only storybook dev and build-storybook), so nothing asserts that render in CI.
That matters a little more than usual for this kind, because unavailable shares a bodyKey with subscriptionRequired but must not get its Subscribe button. A one-line case in the L51 table (presentation: { kind: 'unavailable' }, same body text, zero buttons) would close the thread's "nothing exercises unavailable" complaint in CI and not just in Storybook.
Entirely fine to defer to the FE-2314 follow-up if you'd rather keep this PR mechanical.
| try { | ||
| await prepareWorkflow() | ||
| if (sendWasSuperseded(generation)) return false | ||
| if (generation !== loadGeneration) return false |
There was a problem hiding this comment.
nit-pick (non-blocking): small correction to the PR description, not to this line.
The description says "loadGeneration is a module-scope let declared below performSend". It is declared at L523, which is inside the useAgentSession factory, so it is per-composable-instance, not module-scope. (sessionGeneration and rememberedWorkflowId above are module-scope, which is presumably where the slip came from.)
The conclusion still holds exactly as written — let hoists within the function body, so these inlined reads resolve at call time just as the helper's did, and the inlining is sound. Only flagging it so the PR description doesn't leave a future reader thinking the send-generation guard is shared across instances.
There was a problem hiding this comment.
Tracked as FE-2577. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: follow-up requested
No P0 or P1 blockers. I found two material test-structure gaps and several minor cleanup or description issues. The shipped-code inlining itself preserves behavior.
Findings without an anchorable line
- [P3] The summary says "one production edit and five test/story/spec edits, one per thread," but seven thread edits are spread across six files. FE-2463 and FE-2464 both change
agentPanel.spec.ts. Please describe this as one production edit and six test/story/spec edits across six files. - [P3] "Every input/expectation pair from before is still covered" is too strong. The old actionless member row used
tier: 'STANDARD'; the replacement usesTEAM. The production result is unchanged because this branch returns before reading the tier, but the exact tuple is no longer covered. Please narrow the claim to policy outcomes or restoreSTANDARDfor that row. - [P3] The verification section cites
33628b25c0, which is not in the fetched repository history, and the stated 120-file Vitest result has no auditable log here. The checks I ran against the current head are listed below. Please update the section to a reachable SHA and current results.
Existing findings confirmed
- [P3] I confirmed the unresolved-role isolation finding.
beforeEachsupplieshasResolvedCapabilities = trueabout 420 lines above the test. Setting it locally would prevent this test from silently taking the unresolved-capabilities branch if the shared default changes. - [P3] I confirmed the unavailable-state UX observation as pre-existing. The unresolved state renders out-of-credits copy with no action. This PR only adds the story that exposes it, so I am not asking for a code change here.
- [P3] I confirmed the missing unavailable component assertion. Every other presentation kind appears in
AgentPaywallCard.test.ts; this new story has no asserted play or visual test. - [P3] I confirmed the scope correction.
loadGenerationis owned by eachuseAgentSessioninvocation, not module scope. The inlining remains behavior-preserving.
Checked and cleared
- The three inlined generation comparisons use the same closure binding and remain at the same post-prepare, post-POST, and error checkpoints.
- The POST handler falls back correctly for non-POST requests. The concern is that the regression test does not exercise that branch.
- The generated admission schema validates the fixture shape, and the focused unit suite covers the changed component and resolver behavior.
Coverage and checks
Standard-depth correctness, maintainability, idiomaticity, tests, and documentation lanes reviewed all six changed files. The Playwright lane inventoried helpers, traced 19 changed interactions, and applied checks A through H and all 23 repository rulebook items. Fallow found no new scoped structural issue.
At 55e434ea653d143007182807997a6ef642d66f91: source and browser typechecks passed; changed-file ESLint and oxfmt passed; type-aware oxlint passed; focused Vitest passed 247 tests in 3 files; Playwright listed 9 cloud tests but was not executed locally. GitHub reports 86 successful and 19 skipped checks, with no failures or pending checks.
|
|
||
| // Parsed through the generated admission contract so a server-side rename of a | ||
| // `reason` or `type` breaks this fixture instead of silently passing. | ||
| const NO_FUNDS_ERROR = zAgentAdmissionError.parse({ |
There was a problem hiding this comment.
[P2] This moves reusable API test data into another spec-level constant, but the Playwright guide requires typed mock data under browser_tests/fixtures/data/. The same schema-parsed no-funds payload already exists in agentPaywallSubscribe.spec.ts, so these copies can drift. Please export one typed fixture from fixtures/data/agent/ and import it in both specs.
There was a problem hiding this comment.
Tracked as FE-2578. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
| // Scoped to POST so the fixture's GET handler for the same URL still | ||
| // serves the thread's message history. | ||
| await page.route('**/api/agent/threads/*/messages', async (route) => { | ||
| if (route.request().method() !== 'POST') return route.fallback() |
There was a problem hiding this comment.
[P2] This test never drives a GET through the newly registered handler, so replacing this branch with the old unconditional 402 fulfillment would leave every assertion green. That is the exact shadowing regression FE-2463 is meant to protect. Please issue a GET to the matched messages URL and assert the fixture's history response, or exercise and assert the equivalent history-loading UI path before the POST.
| streaming: false, | ||
| thinking: false | ||
| }) | ||
| // Each unresolved input is its own wiring test: the panel reads |
There was a problem hiding this comment.
Nit: [P3] This block records why the old table was removed rather than adding a constraint the resulting tests do not already show. The same issue appears in the added comments at agentPanel.spec.ts:29-30, AgentPaywallCard.stories.ts:44-45,54, AgentPaywallCard.test.ts:10-11, and agentPaywallPresentation.test.ts:66-67,91-92. Repository guidance asks us not to retain comments that paraphrase adjacent names, inputs, or assertions. Please delete those narrative blocks; the POST/fallback comment is worth keeping because it names a nonlocal fixture owner.
There was a problem hiding this comment.
Tracked as FE-2579. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
Summary
Closes seven minor review threads that were still open when #16856 merged, all mechanical and behavior-preserving.
Changes
What: one production edit and five test/story/spec edits, one per thread.
sendWasSupersededinuseAgentSession.tswas a literal one-line alias forgeneration !== loadGeneration. Inlined at the threeperformSendcheckpoints and deleted. Same comparison, same closure variable, same call order.Unavailablestory rendered{ kind: 'member' }, so nothing exercised theunavailablepresentation thatagentPaywallPresentation.tsmakes the default. The old story is renamedServiceErrorMessage, andUnavailablenow renders{ kind: 'unavailable' }. Note the reviewer's proposed fix said to keep themessage; amessagesuppressesbodyKeyentirely inAgentPaywallCard.vue, so the new story drops it in order to render theunavailablebody key the thread was about.pending | denied | unresolved-roletable inAgentPanelRoot.test.tsinto two explicit wiring tests, one for unresolved capabilities and one for an unresolved role, sharing an assertion helper.pendinganddeniedhad identical effective inputs because the root never readsisReady; that dimension is gone and pending-versus-denied policy stays withuseBillingCapabilities.test.ts.agentPaywallPresentation.test.tsnow has one cloud member-capability table and one standalone local-override test, so a local regression no longer fails under two policy names. Every input/expectation pair from before is still covered.AgentPaywallCardcase that claimed Add credits is visually primary to what it observes: the copy, the two offered actions, and the value each emits.page.routeinagentPanel.spec.tsshadowed the fixture's GET handler for the same URL; it is now scoped to POST and callsroute.fallback()otherwise. The ad-hoc inline body is replaced by a module-level literal parsed throughzAgentAdmissionError, the same typed patternagentPaywallSubscribe.spec.tsalready uses, so a renamed serverreasonortypebreaks the fixture.test.stepblocks, matching the diagnostic-report flow below it.Review Focus
FE-2311 (thread) is deliberately not in this PR and its thread is left open. The hand-written shape it targeted,
admissionNoticeText, no longer exists onmain; the survivingparseAdmissionErrorreturnszAgentAdmissionError's inferred type, whosereasonis already the narrow'no_funds' | 'manual_block' | 'funds_unavailable'union rather thanstring. Nothing widens it today, so there is no edit to make. Worth a second pair of eyes before the ticket is closed as already-fixed.useAgentSession.tsis the only shipped-code change.loadGenerationis a module-scopeletdeclared belowperformSend, so the inlined reads resolve at call time exactly as the helper's did.Verification on
33628b25c0:pnpm typecheck— clean (all five projects).NODE_OPTIONS="--no-experimental-webstorage" npx vitest run src/workbench/extensions/agent/— 120 files passed, 1826 passed / 7 expected-fail (1833 total).npx eslintandnpx oxfmt --checkon all six changed files — clean.npx playwright test browser_tests/tests/agent/agentPanel.spec.ts --project=cloud --list— 9 tests discovered in the file, including the rewritten admission-paywall case. Not executed against a live rig locally; CI covers the run.