Repository navigation
fix: preserve workflow document binding identity (core/1.54) - #18218
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1929 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T19:00:16.313Z",
"gitSha": "fa570027f026853b965db006e6a721f1b7efec84",
"branch": "christian/binding-core154",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2082.051999999976,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.6659999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.3100000000001,
"heapDeltaBytes": 10446616,
"heapUsedBytes": 80164332,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.456,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2036.1629999999877,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.2029999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.163,
"heapDeltaBytes": -12364428,
"heapUsedBytes": 56877740,
"domNodes": 2,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.769000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1816.5430000000242,
"styleRecalcs": 76,
"styleRecalcDurationMs": 29.657,
"layouts": 14,
"layoutDurationMs": 4.186999999999999,
"taskDurationMs": 894.8009999999999,
"heapDeltaBytes": 2962220,
"heapUsedBytes": 73662964,
"domNodes": -280,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 163.58800000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1841.2869999999657,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.931,
"layouts": 14,
"layoutDurationMs": 4.005,
"taskDurationMs": 849.591,
"heapDeltaBytes": -12450260,
"heapUsedBytes": 57796920,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 159.699,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.3419999999887,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.361,
"layouts": 6,
"layoutDurationMs": 1.1320000000000001,
"taskDurationMs": 391.09000000000003,
"heapDeltaBytes": 4337308,
"heapUsedBytes": 74205888,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 14.571000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1682.82099999999,
"styleRecalcs": 29,
"styleRecalcDurationMs": 15.996999999999998,
"layouts": 6,
"layoutDurationMs": 1.1270000000000002,
"taskDurationMs": 343.501,
"heapDeltaBytes": 4662816,
"heapUsedBytes": 75631044,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.190000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 710.6170000000134,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.794,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.29300000000006,
"heapDeltaBytes": 18733224,
"heapUsedBytes": 87939112,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 165.74800000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 664.2859999999473,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.270000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.91400000000004,
"heapDeltaBytes": -7927328,
"heapUsedBytes": 62583260,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 164.59600000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2045.4919999999674,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.812,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 633.755,
"heapDeltaBytes": -15895356,
"heapUsedBytes": 87217476,
"domNodes": -268,
"jsHeapTotalBytes": -1380352,
"scriptDurationMs": 37.451,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2061.5490000000136,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.816999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.1439999999999,
"heapDeltaBytes": 10170532,
"heapUsedBytes": 86066696,
"domNodes": -272,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 31.921000000000006,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2429.254999999955,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.142999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1742.097,
"heapDeltaBytes": 17085672,
"heapUsedBytes": 93830468,
"domNodes": -271,
"jsHeapTotalBytes": -1716224,
"scriptDurationMs": 835.7320000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2280.097000000069,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.746999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1685.6620000000003,
"heapDeltaBytes": -252904,
"heapUsedBytes": 76354772,
"domNodes": -282,
"jsHeapTotalBytes": -405504,
"scriptDurationMs": 844.0369999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3785.5670000000146,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.631,
"layouts": 60,
"layoutDurationMs": 12.956,
"taskDurationMs": 1855.627,
"heapDeltaBytes": 1721716,
"heapUsedBytes": 80114764,
"domNodes": -287,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 832.615,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3589.2339999999194,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.550999999999998,
"layouts": 60,
"layoutDurationMs": 12.117999999999999,
"taskDurationMs": 1674.0400000000002,
"heapDeltaBytes": 9468084,
"heapUsedBytes": 76405644,
"domNodes": -277,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 771.6240000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3110.9900000000152,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.161000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1976.795,
"heapDeltaBytes": 22821468,
"heapUsedBytes": 92963340,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 970.765,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3069.0140000000383,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.9750000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1885.8319999999997,
"heapDeltaBytes": 17208160,
"heapUsedBytes": 84999924,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 946.455,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2048.30800000002,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.011000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.921,
"heapDeltaBytes": 9833800,
"heapUsedBytes": 87293668,
"domNodes": -276,
"jsHeapTotalBytes": -2727936,
"scriptDurationMs": 37.599999999999994,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2038.8769999999568,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.344,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.3290000000001,
"heapDeltaBytes": 9887308,
"heapUsedBytes": 87501136,
"domNodes": -269,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 34.394000000000005,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.8219999999706,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.619000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.135,
"heapDeltaBytes": 15089320,
"heapUsedBytes": 87738896,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 143.907,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.1450000000677,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.402000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.5609999999999,
"heapDeltaBytes": 15015692,
"heapUsedBytes": 87871900,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 140.415,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2018.3250000000044,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.146,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.3829999999999,
"heapDeltaBytes": -12803216,
"heapUsedBytes": 59571472,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.216,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.8300000000227,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.561000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.27599999999995,
"heapDeltaBytes": -6260556,
"heapUsedBytes": 65876656,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 7.605999999999998,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1752.6700000000233,
"styleRecalcs": 78,
"styleRecalcDurationMs": 29.875000000000004,
"layouts": 18,
"layoutDurationMs": 5.261,
"taskDurationMs": 858.912,
"heapDeltaBytes": -15217092,
"heapUsedBytes": 57624544,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 117.928,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.9940000000288,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.695999999999998,
"layouts": 18,
"layoutDurationMs": 4.694999999999999,
"taskDurationMs": 810.5749999999999,
"heapDeltaBytes": -1302028,
"heapUsedBytes": 71993368,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 107.54899999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.4419999999373,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.181,
"layouts": 15,
"layoutDurationMs": 15.85,
"taskDurationMs": 918.852,
"heapDeltaBytes": -5449356,
"heapUsedBytes": 87218236,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 27.900000000000002,
"eventListeners": 2385,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8943.76299999999,
"styleRecalcs": 246,
"styleRecalcDurationMs": 35.117,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6149.713999999999,
"heapDeltaBytes": 8738292,
"heapUsedBytes": 85072796,
"domNodes": -274,
"jsHeapTotalBytes": -1224704,
"scriptDurationMs": 2786.036,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8453.286000000047,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.797999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5837.389,
"heapDeltaBytes": 9399352,
"heapUsedBytes": 85011560,
"domNodes": -271,
"jsHeapTotalBytes": -405504,
"scriptDurationMs": 2728.639,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17709.12500000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17001.684,
"heapDeltaBytes": -45583984,
"heapUsedBytes": 177818488,
"domNodes": -8068,
"jsHeapTotalBytes": -15478784,
"scriptDurationMs": 292.942,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16792.619000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16173.443,
"heapDeltaBytes": -37435340,
"heapUsedBytes": 189195856,
"domNodes": -8068,
"jsHeapTotalBytes": -4898816,
"scriptDurationMs": 273.30100000000004,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21591.687999999976,
"styleRecalcs": 178,
"styleRecalcDurationMs": 18.156000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21249.25,
"heapDeltaBytes": -61109204,
"heapUsedBytes": 169904448,
"domNodes": -8068,
"jsHeapTotalBytes": -17739776,
"scriptDurationMs": 896.098,
"eventListeners": -14929,
"totalBlockingTimeMs": 49,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20899.436000000038,
"styleRecalcs": 168,
"styleRecalcDurationMs": 18.057999999999964,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20515.428999999996,
"heapDeltaBytes": -31113420,
"heapUsedBytes": 192491600,
"domNodes": -8068,
"jsHeapTotalBytes": -14516224,
"scriptDurationMs": 920.472,
"eventListeners": -14929,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6241.6560000000345,
"styleRecalcs": 20,
"styleRecalcDurationMs": 97.356,
"layouts": 20,
"layoutDurationMs": 29.741000000000003,
"taskDurationMs": 6123.051000000001,
"heapDeltaBytes": -32728892,
"heapUsedBytes": 178084280,
"domNodes": -8068,
"jsHeapTotalBytes": 6443008,
"scriptDurationMs": 114.57999999999998,
"eventListeners": -14929,
"totalBlockingTimeMs": 499,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6144.5620000000645,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.13399999999999,
"layouts": 20,
"layoutDurationMs": 22.794999999999995,
"taskDurationMs": 6046.7789999999995,
"heapDeltaBytes": -27739492,
"heapUsedBytes": 183756068,
"domNodes": -8068,
"jsHeapTotalBytes": 12144640,
"scriptDurationMs": 113.441,
"eventListeners": -14931,
"totalBlockingTimeMs": 494,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8546.774000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8286.284000000001,
"heapDeltaBytes": 20939920,
"heapUsedBytes": 179376392,
"domNodes": 0,
"jsHeapTotalBytes": -8912896,
"scriptDurationMs": 133.03900000000002,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8881.848999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8492.911,
"heapDeltaBytes": 3465912,
"heapUsedBytes": 178309988,
"domNodes": 0,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 138.63600000000008,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 479.57799999994677,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.274,
"layouts": 4,
"layoutDurationMs": 1.976,
"taskDurationMs": 120.699,
"heapDeltaBytes": 4986488,
"heapUsedBytes": 73260908,
"domNodes": 145,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 13.113000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 479.2459999999892,
"styleRecalcs": 15,
"styleRecalcDurationMs": 22.858000000000004,
"layouts": 4,
"layoutDurationMs": 1.921,
"taskDurationMs": 120.64099999999999,
"heapDeltaBytes": 4751944,
"heapUsedBytes": 73600456,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.171000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #18218 +/- ##
==========================================
Coverage 83.52% 83.53%
==========================================
Files 2094 2094
Lines 123387 123461 +74
Branches 33235 33266 +31
==========================================
+ Hits 103062 103134 +72
- Misses 20146 20148 +2
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Target-native adaptation reviewed; exact-head guard passes.
No unresolved human objection. Admin merge authorized.
Full context for agent readers
Reviewed head 86d39536ee14e17f7d6725dc22ec35ce9c6da30e against live core/1.54 target 04d84bc7163326bdd57ccbba51decc2469423ec9. The release adaptation preserves workflow document identity while retaining the target store/API shape. Published evidence covers 239 focused tests, source and browser typechecks, hooks, and the target-native browser case with the old-store control failing and restored fix passing. The target-aware program guard reports 91 terminal non-adverse checks, fresh receipts, target ancestry, and no unresolved thread or later reviewer objection. Christian’s Agent 1.54 backport grant authorizes guarded admin merge without manufacturing a self-approval. This merge is not deployment or incident closure.
Glossary: target-native means adapted and tested on this release branch; guard means the program’s exact-head ancestry/check/review verification.
Summary
Backport the merged persisted-tab binding fix so a fresh canvas cannot inherit an abandoned chat's workflow identity.
Changes
Review Focus
Document identity, saved-in-place refusal, restoration ordering and cross-tab ownership. The thirty-day retention ADR remains Proposed. Original incident stays open through original-session and release acceptance.
Full context for agent readers
Source: merged commit. This is a manual backport because the test setup and ADR index do not apply unchanged; no unrelated main commits are imported.
Target-native validation: 239 store/component tests, source and browser typechecks, lint, formatting and knip pass. The black-box browser regression passes on a verified Cloud-distribution server against the qualified local backend. It checks the newly saved outgoing workflow identity, rejected stale acknowledgement, unchanged fresh canvas and active tab. Screenshots were inspected.
Sensitivity control on the Cloud release: restoring only the old production store makes the outgoing workflow identity assertion fail with the abandoned workflow ID. The two release carriers use the same production fix and equivalent browser assertions. Earlier browser attempts used an occupied/wrong-checkout port and are not evidence of a product regression. No tests were skipped or weakened.
This PR does not deploy the release or close the broader incident. Glossary: backport applies a merged fix to a release branch; binding associates an Agent workflow with an editor tab.