Skip to content

test(subgraph): pin FE-2497 nested definition loss end to end - #18159

Merged
christian-byrne merged 3 commits into
fix/subgraph-release-serialization-mismatchfrom
glary/fe-2497-wrap-nested-subgraph-tests
Sep 20, 2026
Merged

christian-byrne merged 3 commits into
fix/subgraph-release-serialization-mismatchfrom
glary/fe-2497-wrap-nested-subgraph-tests

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

PR Created by the Glary-Bot Agent


Targets #18040 (fix/subgraph-release-serialization-mismatch), not main. Test-only — no product code touched.

Requested in #bug-dump as follow-up to the FE-2497 RCA. #18040 already fixes the root cause; this adds the coverage that pins the user-visible symptom.

Why

#18040's regression test catches the bug only through its telemetry side effect. Deleting its one expect(reportError).not.toHaveBeenCalled() line leaves the test passing on pre-fix main, because serialiseStoredNodes falls back to live-node serialization and its remaining assertions only check node types:

$ # on main (bug present), PR 18040's test with the reportError assertion removed
  Test Files  1 passed (1)
       Tests  1 passed (1)
  [inner def on main] {"nodes":2,"links":0}   <-- links destroyed, test still green

So the thing FE-2497 was actually reported for — every internal link gone, interior unrenderable — is unpinned. If the mismatch detector is ever moved, throttled, or reworded, the regression walks straight back in.

What this adds

Vitest (SubgraphConversion.nestedDefinitions.test.ts) — asserts the symptom directly via a captureHealth snapshot of interior nodes, links, layout records, the serialized round trip, and reported errors, held across a table of four selection shapes plus a three-deep nest:

shape rationale
host selected on its own minimal trigger
host selected alongside a plain sibling the reported scenario
host wrapped twice in a row repeated conversion
host wrapped from inside the subgraph that owns it non-root parent graph
three-deep nest, outermost host wrapped collectSubgraphsPostOrder releases the whole subtree

Playwright (browser_tests/tests/subgraph/subgraphWrapNestedDefinition.spec.ts) — uses the existing assets/subgraphs/nested-subgraph asset, whose shape matches the report exactly (root → subgraph 2 → subgraph 3). Three lenses on one wrap: live definition inventory, the saved workflow after serializeAndReload(), and navigating into the deepest interior to assert it still renders.

Fixture (SubgraphHelper) — getDefinitionInventory() / getSerializedDefinitionInventory() return one row per definition sorted by name (an array, not a name-keyed object, since Convert to Subgraph names every new definition New Subgraph), and descendSubgraphs(levels) which requires exactly one subgraph node per level before descending.

Red / green

Reverting only #18040's two-line product change, with the tests unchanged:

Vitest      6 failed (6)  ->  6 passed (6)
Playwright  3 failed      ->  3 passed

The browser failures are the reported symptom verbatim — subgraph 2 links 7 -> 0, subgraph 3 links 6 -> 0, and zero Vue nodes rendered in the interior:

- "links": 7        + "links": 0
- "links": 6        + "links": 0
Error: expect(locator).toBeVisible() failed — element(s) not found

Visual proof

Captured against a live ComfyUI backend + dev server, navigating to the deepest nested subgraph after the wrap. The broken capture reproduces the reporter's screenshot pixel for pixel — empty canvas with only the subgraph IO node stub.

Notes for review

  • 'New Subgraph': links: 4 is correct, verified by dumping the live wrapper. The 4th is a boundary link, -10:0 -> 9:1 (STRING): conversion promotes Save Image's filename_prefix widget to a wrapper input. Counting only the asset's three explicit root links gives 3 and is wrong — there is a comment on the constant so it doesn't get "corrected".
  • layoutStore.resetForTests() was added to the beforeEach. Fixture UUIDs reset per test, so every test reused the same layout-store keys and stale entries could have masked a regression where conversion fails to recreate layout rather than deleting it.
  • The three-deep test's middle subgraph is now built from two connected nodes so it carries a real link — previously interiorNodesWithLayout was its only load-bearing field.
  • reportedErrors folded into captureHealth restores fix: keep released subgraph definitions consistent across convert-to-subgraph #18040's telemetry guard across all five new cases.
  • No test.fail markers: fix: keep released subgraph definitions consistent across convert-to-subgraph #18040 fixes this class completely. I probed the adjacent paths it deferred — delete+undo and copy/paste of a subgraph host — and both are healthy (delete correctly releases, undo fully restores 7/6 links). Nothing is left failing to mark.

Verification

  • pnpm typecheck / pnpm typecheck:browser: clean
  • eslint, oxlint, oxfmt --check: 0 errors (3 pre-existing import-x/no-restricted-paths warnings; LGraph.ts itself imports layoutStore, as do 25 files under src/lib/litegraph/)
  • vitest run src/lib/litegraph/src/subgraph/: 19 files, 361 passed
  • playwright test browser_tests/tests/subgraph/ --project=chromium: 145 passed, 2 failed — subgraphDraftPositions and subgraphSeed, both of which fail identically on this branch with my changes stashed (sandbox reload timeout and a generation-dependent test)
  • Reviewed by the deep-reviewer sub-agent; all actionable findings applied. Its one blocking finding claimed links: 4 should be 3 — disproved empirically above, and it had flagged the browser suite as unrunnable in its own session.

Screenshots

BROKEN (fix reverted): the deepest nested subgraph renders as an empty canvas with only the IO node stub - matching the original bug report

FIXED (PR 18040): the same nested subgraph renders all three interior nodes with wiring intact

BROKEN: root graph immediately after the wrap

FIXED: root graph immediately after the wrap

The existing regression test only catches the convert-to-subgraph
definition teardown through its telemetry side effect. Removing its
reportError assertion leaves it passing on pre-fix code, so it does not
pin the reported symptom: the wrapped subgraph loses every internal
link, its interior nodes lose their layout records, and the subgraph
renders as an empty canvas.

Assert that symptom directly instead, at both levels:

- Vitest: capture interior nodes, links, layout records, the serialized
  round trip and reported errors, then hold them across four selection
  shapes and a three-deep nest.
- Playwright: wrap the host in assets/subgraphs/nested-subgraph, then
  check the definition inventory live, after a save/reload, and by
  navigating into the deepest interior and asserting it still renders.

All six Vitest cases and all three browser tests go red on pre-fix code
(links 7 -> 0 and 6 -> 0, zero nodes rendered) and green with the fix.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: e2779f28-f63e-4538-bec1-83e671805a60

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2040 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2019 / ❌ 0 / ⚠️ 2 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/20/2026, 09:48:27 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 139ms TBT · 76.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.8 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 50ms TBT · 165.3 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 40.0 P5 FPS ❌ (target: ≥52) · 336ms TBT · 161.8 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 181.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 7
canvas-idle: task duration 561ms
canvas-idle: script duration 14ms
canvas-idle: TBT 0ms
canvas-idle: heap used 58.8 MB
canvas-idle: DOM nodes -266
canvas-idle: event listeners -174
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 36ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 1008ms
canvas-mouse-sweep: script duration 190ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 73.2 MB
canvas-mouse-sweep: DOM nodes -263
canvas-mouse-sweep: event listeners -152
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 361ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 61.1 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 499ms
dom-widget-clipping: script duration 182ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 75.1 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 665ms
large-graph-idle: script duration 40ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 78.6 MB
large-graph-idle: DOM nodes -250
large-graph-idle: event listeners -152
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1799ms
large-graph-pan: script duration 924ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 69.6 MB
large-graph-pan: DOM nodes -238
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1741ms
large-graph-zoom: script duration 815ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.7 MB
large-graph-zoom: DOM nodes 1
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 2005ms
legacy-node-drag: script duration 1038ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 82.1 MB
legacy-node-drag: DOM nodes 2
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 629ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 78.3 MB
minimap-idle: DOM nodes -252
minimap-idle: event listeners -174
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 429ms
subgraph-dom-widget-clipping: script duration 152ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 73.4 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 511ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.2 MB
subgraph-idle: DOM nodes -276
subgraph-idle: event listeners -198
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 30ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 843ms
subgraph-mouse-sweep: script duration 119ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 61.4 MB
subgraph-mouse-sweep: DOM nodes -276
subgraph-mouse-sweep: event listeners -220
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 933ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 139ms
subgraph-transition-enter: heap used 76.4 MB
subgraph-transition-enter: DOM nodes 13587
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5896ms
viewport-pan-sweep: script duration 2837ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 67.8 MB
viewport-pan-sweep: DOM nodes -248
viewport-pan-sweep: event listeners -152
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16768ms
vue-large-graph-idle: script duration 272ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.8 MB
vue-large-graph-idle: DOM nodes -8061
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 172
vue-large-graph-pan: task duration 21618ms
vue-large-graph-pan: script duration 934ms
vue-large-graph-pan: TBT 50ms
vue-large-graph-pan: heap used 165.3 MB
vue-large-graph-pan: DOM nodes -8061
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 25ms
vue-node-resize-workload: layout duration 27ms
vue-node-resize-workload: style recalc duration 86ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5645ms
vue-node-resize-workload: script duration 125ms
vue-node-resize-workload: TBT 336ms
vue-node-resize-workload: heap used 161.8 MB
vue-node-resize-workload: DOM nodes -8061
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8568ms
vue-zoom-out-idle: script duration 136ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 181.3 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 4
workflow-execution: style recalc count 10
workflow-execution: task duration 109ms
workflow-execution: script duration 12ms
workflow-execution: TBT 0ms
workflow-execution: heap used 62.5 MB
workflow-execution: DOM nodes 125
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-09-20T10:02:01.189Z",
  "gitSha": "c0bf319fd3f17e3623d10d921b3a045e1b08df57",
  "branch": "glary/fe-2497-wrap-nested-subgraph-tests",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2018.1249999999977,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.419999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 546.025,
      "heapDeltaBytes": 3166728,
      "heapUsedBytes": 64281008,
      "domNodes": -266,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 12.788999999999998,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2016.86200000006,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.725,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 576.1729999999999,
      "heapDeltaBytes": -2919424,
      "heapUsedBytes": 59121896,
      "domNodes": -265,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 14.4,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2162.575000000004,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 45.513,
      "layouts": 14,
      "layoutDurationMs": 5.452999999999999,
      "taskDurationMs": 1184.194,
      "heapDeltaBytes": 15986924,
      "heapUsedBytes": 76790672,
      "domNodes": -265,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 216.21099999999998,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1783.9870000000246,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 26.919000000000004,
      "layouts": 14,
      "layoutDurationMs": 4.2989999999999995,
      "taskDurationMs": 831.3799999999999,
      "heapDeltaBytes": 14616256,
      "heapUsedBytes": 76623500,
      "domNodes": -261,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 163.47699999999998,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.4740000000202,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.688000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.4169999999999998,
      "taskDurationMs": 334.107,
      "heapDeltaBytes": 2132712,
      "heapUsedBytes": 64093096,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 11.816,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.479000000074,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.39,
      "layouts": 6,
      "layoutDurationMs": 1.333,
      "taskDurationMs": 387.35300000000007,
      "heapDeltaBytes": 2094544,
      "heapUsedBytes": 64116316,
      "domNodes": 75,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 14.427999999999999,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 843.2899999999677,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.639,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 559.2250000000001,
      "heapDeltaBytes": 17860044,
      "heapUsedBytes": 79841256,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 197.94500000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 642.3970000000736,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.0360000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 438.046,
      "heapDeltaBytes": 17202792,
      "heapUsedBytes": 77590012,
      "domNodes": 16,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 166.796,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.1379999999995,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 4.151999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 771.068,
      "heapDeltaBytes": 2792432,
      "heapUsedBytes": 82308592,
      "domNodes": -254,
      "jsHeapTotalBytes": -1318912,
      "scriptDurationMs": 45.21499999999999,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.4830000000793,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.293000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 559.8629999999999,
      "heapDeltaBytes": 3911544,
      "heapUsedBytes": 82539176,
      "domNodes": -246,
      "jsHeapTotalBytes": -794624,
      "scriptDurationMs": 34.972,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3064.134000000024,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 13.879000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1963.0990000000002,
      "heapDeltaBytes": -19612980,
      "heapUsedBytes": 66901684,
      "domNodes": -228,
      "jsHeapTotalBytes": 1601536,
      "scriptDurationMs": 1000.283,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2261.203000000023,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.361,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1635.116,
      "heapDeltaBytes": 15180468,
      "heapUsedBytes": 79089396,
      "domNodes": -247,
      "jsHeapTotalBytes": 1273856,
      "scriptDurationMs": 847.0849999999999,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3669.027999999969,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.578000000000001,
      "layouts": 60,
      "layoutDurationMs": 14.054,
      "taskDurationMs": 1762.554,
      "heapDeltaBytes": 8117116,
      "heapUsedBytes": 73971480,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 816.8330000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3547.415000000001,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 11.105999999999998,
      "layouts": 60,
      "layoutDurationMs": 13.069,
      "taskDurationMs": 1719.518,
      "heapDeltaBytes": 8500848,
      "heapUsedBytes": 74345044,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 813.7260000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3220.166000000006,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.236999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2122.8610000000003,
      "heapDeltaBytes": 25933376,
      "heapUsedBytes": 91440276,
      "domNodes": 2,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 1094.274,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3030.283000000054,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.573999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1886.8609999999999,
      "heapDeltaBytes": 15236292,
      "heapUsedBytes": 80635776,
      "domNodes": 2,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 982.12,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2043.6980000000062,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.116,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 614.154,
      "heapDeltaBytes": -4943292,
      "heapUsedBytes": 82094988,
      "domNodes": -252,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 36.709,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2047.7619999999206,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.582,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 642.9549999999999,
      "heapDeltaBytes": -5374092,
      "heapUsedBytes": 82029440,
      "domNodes": -252,
      "jsHeapTotalBytes": -757760,
      "scriptDurationMs": 37.784,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 595.815000000016,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.596,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.70399999999995,
      "heapDeltaBytes": 13876952,
      "heapUsedBytes": 76827456,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 151.976,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 595.2619999999342,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.471000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 431.44399999999996,
      "heapDeltaBytes": 13827408,
      "heapUsedBytes": 77070352,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 151.83200000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2013.7720000000172,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.289000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 579.666,
      "heapDeltaBytes": 11888540,
      "heapUsedBytes": 74975884,
      "domNodes": -278,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 12.855999999999996,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.2759999999807,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.473,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.2269999999999,
      "heapDeltaBytes": -7863112,
      "heapUsedBytes": 55388832,
      "domNodes": -274,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.352000000000001,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1724.536999999998,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.883,
      "layouts": 18,
      "layoutDurationMs": 6.300000000000001,
      "taskDurationMs": 884.4699999999999,
      "heapDeltaBytes": 1175536,
      "heapUsedBytes": 64318124,
      "domNodes": -277,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 125.35,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.38799999999,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 28.373999999999995,
      "layouts": 18,
      "layoutDurationMs": 5.53,
      "taskDurationMs": 800.821,
      "heapDeltaBytes": 1025588,
      "heapUsedBytes": 64391336,
      "domNodes": -274,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 112.553,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1387.008999999921,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 29.07,
      "layouts": 5,
      "layoutDurationMs": 12.848000000000003,
      "taskDurationMs": 932.5220000000003,
      "heapDeltaBytes": -6421372,
      "heapUsedBytes": 80139172,
      "domNodes": 13587,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 31.216,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 139,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8309.091000000024,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 35.178000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5804.104,
      "heapDeltaBytes": -12506944,
      "heapUsedBytes": 66845688,
      "domNodes": -248,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 2798.7329999999997,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8539.839999999913,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 36.388000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5987.159000000001,
      "heapDeltaBytes": -4040584,
      "heapUsedBytes": 75347828,
      "domNodes": -247,
      "jsHeapTotalBytes": -339968,
      "scriptDurationMs": 2874.8010000000004,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17464.743,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17033.768000000004,
      "heapDeltaBytes": -54098180,
      "heapUsedBytes": 167900140,
      "domNodes": -8061,
      "jsHeapTotalBytes": -14356480,
      "scriptDurationMs": 277.097,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17005.414000000088,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16501.32,
      "heapDeltaBytes": -31123596,
      "heapUsedBytes": 190380620,
      "domNodes": -8061,
      "jsHeapTotalBytes": -13000704,
      "scriptDurationMs": 267.177,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22870.81599999999,
      "styleRecalcs": 174,
      "styleRecalcDurationMs": 24.71399999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22727.03,
      "heapDeltaBytes": -66800932,
      "heapUsedBytes": 166890048,
      "domNodes": -8061,
      "jsHeapTotalBytes": -17047552,
      "scriptDurationMs": 948.7829999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 99,
      "frameDurationMs": 17.779999999999806,
      "p95FrameDurationMs": 16.799999999995634
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20892.100000000028,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 17.769000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20508.682,
      "heapDeltaBytes": -35845520,
      "heapUsedBytes": 179671884,
      "domNodes": -8061,
      "jsHeapTotalBytes": -15847424,
      "scriptDurationMs": 918.4929999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6695.886000000087,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 91.63700000000003,
      "layouts": 20,
      "layoutDurationMs": 31.29799999999999,
      "taskDurationMs": 6675.445999999999,
      "heapDeltaBytes": -58948072,
      "heapUsedBytes": 171154064,
      "domNodes": -8061,
      "jsHeapTotalBytes": 14086144,
      "scriptDurationMs": 130.179,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 588,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4730.498000000011,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.17099999999996,
      "layouts": 20,
      "layoutDurationMs": 22.864999999999995,
      "taskDurationMs": 4615.459000000001,
      "heapDeltaBytes": -47282896,
      "heapUsedBytes": 168115284,
      "domNodes": -8061,
      "jsHeapTotalBytes": 6049792,
      "scriptDurationMs": 120.80300000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 84,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9063.351000000011,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8904.633,
      "heapDeltaBytes": 15365104,
      "heapUsedBytes": 197228176,
      "domNodes": 0,
      "jsHeapTotalBytes": -10223616,
      "scriptDurationMs": 149.32299999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8447.080000000027,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8230.805999999999,
      "heapDeltaBytes": 10575556,
      "heapUsedBytes": 182986220,
      "domNodes": 0,
      "jsHeapTotalBytes": -8126464,
      "scriptDurationMs": 121.946,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 134.6769999998969,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 21.845,
      "layouts": 5,
      "layoutDurationMs": 3.737,
      "taskDurationMs": 111.66799999999999,
      "heapDeltaBytes": 3275872,
      "heapUsedBytes": 64723608,
      "domNodes": 131,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 14.571000000000003,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 451.4910000000327,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 19.371,
      "layouts": 3,
      "layoutDurationMs": 0.8039999999999998,
      "taskDurationMs": 107.16399999999999,
      "heapDeltaBytes": 4871420,
      "heapUsedBytes": 66297848,
      "domNodes": 119,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.227000000000002,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 51416 78149 65.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.8% 1155
src/LGraphNode.ts 70.4% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 316
src/LGraph.ts 78.6% 270
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/scripts/app.ts 72.2% 255
src/core/billing/operationLifecycle.ts 0.9% 232
src/scripts/pnginfo.ts 21.4% 221

@glary-bot

glary-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

@coderabbitai review

No code change needed for this one — the skip is a base-branch configuration effect, not a finding.

This PR deliberately targets fix/subgraph-release-serialization-mismatch (the branch behind #18040) rather than main. #18040 carries the product fix for FE-2497; this PR is test-only coverage pinning the user-visible symptom that fix addresses. It has to stack on that branch — against main the tests would sit on top of the unfixed code and be red, and the red/green proof in the description would be meaningless. Retargeting to main purely to re-enable auto-review would break the change.

Triggering a single review explicitly above instead. Once #18040 merges, this PR's base falls back to main and auto-review resumes on its own.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 19, 2026
@github-actions

github-actions Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Playwright videos for new tests

Download the recorded videos and HTML report

Recorded projects: chromium

Recorded test titles:

  • all tests in browser_tests/tests/subgraph/subgraphWrapNestedDefinition.spec.ts

@codecov

codecov Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                             Coverage Diff                              @@
##           fix/subgraph-release-serialization-mismatch   #18159   +/-   ##
============================================================================
  Coverage                                        83.78%   83.79%           
============================================================================
  Files                                             2242     2242           
  Lines                                           127636   127636           
  Branches                                         32469    32469           
============================================================================
+ Hits                                            106943   106948    +5     
+ Misses                                           20403    20398    -5     
  Partials                                           290      290           
Flag Coverage Δ
e2e 65.79% <ø> (-0.01%) ⬇️
unit 79.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne marked this pull request as ready for review September 20, 2026 05:01
@glary-bot

glary-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown

Re-verified: before/after on the current branch head

Re-ran both suites against 6e6c28a (branch head, unchanged) to confirm the tests flip with #18040's fix. No new commit was needed — see "why nothing to push" below.

Suite BEFORE (#18040 fix reverted) AFTER (fix present)
Vitest SubgraphConversion.nestedDefinitions.test.ts 6 failed (6) 6 passed (6)
Playwright subgraphWrapNestedDefinition.spec.ts 3 failed (3) 3 passed (3)

"BEFORE" = reverting only the two product lines from 12e6a724 in the working tree, with the tests byte-identical.

BEFORE — Vitest (6 failed)
× keeps the nested definition serialisable after its only host moves into the new subgraph
× keeps the wrapped definition intact when the 'host selected on its own'
× keeps the wrapped definition intact when the 'host selected alongside a plain sibling'
× keeps the wrapped definition intact when the 'host wrapped twice in a row'
× keeps the wrapped definition intact when the 'host wrapped from inside the subgraph that owns it'
× keeps every level of a three-deep nest intact when the outermost host is wrapped
Tests  6 failed (6)
BEFORE — Playwright (3 failed, reported symptom verbatim)
- Expected  - 2        + Received  + 2
      "links": 4,
-     "links": 7,      +     "links": 0,     <- subgraph 2 wiring destroyed
-     "links": 6,      +     "links": 0,     <- subgraph 3 wiring destroyed

Error: expect(locator).toBeVisible() failed
Expected: visible
Error: element(s) not found                  <- interior renders nothing
3 failed
AFTER — both green
Vitest:      Test Files  1 passed (1)    Tests  6 passed (6)
Playwright:  3 passed (12.6s)

Wider regression check: vitest run src/lib/litegraph/src/subgraph/ → 19 files, 361 passed.

Why nothing to push

A commit here would have been an empty or no-op change, so I did not fabricate one.

@christian-byrne christian-byrne self-assigned this Sep 20, 2026

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: follow-up requested

I found no product correctness blocker in this test-only increment. The focused tests do go red against the reverted base fix and green at this head. I found two material test or repository-boundary gaps and two minor Playwright structure issues inline.

Pre-merge blockers: none.

Findings without an anchorable line
  • [P2] The verification section calls all three import-x/no-restricted-paths warnings pre-existing. The base already has the two reportError warnings, but this increment adds the layoutStore warning. Please distinguish the new warning from the inherited two.
  • [P3] The visual-proof and notes sections claim pixel-for-pixel equivalence plus delete/undo and copy/paste probe results, but the linked material does not include the reporter's source image or those probe logs. Please link the evidence or narrow those claims to what the checked-in tests establish.
Existing findings confirmed or contested

No prior review findings existed on this head.

Unverified candidate
  • [P2] I could not independently reproduce the claimed three red Playwright cases with the base fix reverted, or the two full-suite failures on the effective base. The local targeted command discovered all three new tests but stopped in fixture setup because this orb has no ComfyUI backend on port 8188. Head CI is green. A backend-enabled targeted revert run plus the two named tests on 12e6a724 would settle the remaining claim.
Checked and cleared
  • I independently derived the wrapper's four links from the fixture and conversion behavior. Existing promotion tests own filename_prefix semantics, so I did not ask this nested-definition regression to duplicate them.
  • The new SubgraphHelper methods are additive. Existing construction and methods are unchanged.
  • Reversing only the 12e6a724 product patch makes all six focused Vitest cases fail. At this exact head, the focused file passes 6/6 and the full subgraph unit directory passes 361/361.
  • The live and serialized inventories retain duplicate definition names as separate rows and derive expectations from literal fixture topology rather than production logic.
Coverage

Standard-depth correctness, maintainability, idiomaticity, tests, and documentation lanes reviewed all three changed files against the effective stacked base. The tests review inventoried 535 fixture methods, traced 24 interactions, applied the Playwright rulebook, and reviewed the Vitest mock and fixture boundaries. Typecheck and browser typecheck passed. Changed-file ESLint had zero errors and three warnings. Formatting passed. Diff-scoped Fallow found no new complexity or duplication. The only local execution limitation was the absent ComfyUI backend for Playwright.


test.use({ initialSettings: { 'Comfy.UseNewMenu': 'Disabled' } })

const WRAPPED_SELECTION = ['subgraph 2', 'VAE Decode', 'Save Image']

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] The browser-test guide says specs should keep free-standing constants out of module scope. These values are local to this scenario, so please move them into the describe or the tests that use them. That keeps the expected data beside its assertion instead of adding another spec-level API.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 991c418 — WRAPPED_SELECTION, NESTED_DEFINITIONS_INTACT and NESTED_DEFINITIONS_AFTER_WRAP now live inside the test.describe callback, next to the assertions that consume them. Module scope holds only imports and test.use.

Worth noting this lines up with a separate point from the earlier review pass: hoisting WRAPPED_SELECTION away from the assertions is arguably what let an incorrect expected link count survive the first draft, since the selection is the input that determines the expected counts. Keeping them together makes that dependency visible.

'still renders the nested interior after wrapping',
{ tag: ['@vue-nodes'] },
async ({ comfyPage }) => {
await comfyPage.nodeOps.selectNodes(WRAPPED_SELECTION)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] This case has three distinct phases: wrap, descend, and assert the deepest render. Only descent is named in the trace. Please put the wrapping and final rendered outcome in semantic test.step blocks too, so a failure identifies which phase broke without reconstructing it from line numbers.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 991c418. All three phases of that case are named steps now:

Wrap the subgraph host together with its siblings
Descend through the wrapper into the deepest nested subgraph
Assert the deepest interior still renders its three nodes

I applied the same "Wrap the subgraph host together with its siblings" step to the other two cases as well, so the wrap phase is labelled consistently across the file rather than only where it happened to be split out.

It already pays off — in the pre-fix run the trace attributes the failure to the descend phase rather than to a bare line number:

3) ... still renders the nested interior after wrapping
   › Descend through the wrapper into the deepest nested subgraph

} from '@/lib/litegraph/src/litegraph'
import { createTestNode } from '@/lib/litegraph/src/__fixtures__/nodeHelpers'
import { reportError } from '@/platform/telemetry/reportError'
import { layoutStore } from '@/renderer/core/layout/store/layoutStore'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] This adds a new src/lib to src/renderer dependency, and the repository's import-x/no-restricted-paths rule reports it. Please keep the Litegraph test inside the leaf boundary, or move the layout-integrated assertion to the renderer/service-layer test that owns layoutStore. The two existing reportError warnings are inherited; this renderer warning is incremental.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 991c418 — the layoutStore import is gone and the litegraph test is back inside the leaf boundary.

I removed the interiorNodesWithLayout field from DefinitionHealth and the layoutStore.resetForTests() call that field required, rather than relocating the assertion. The remaining fields still take every case red on pre-fix code, so nothing was lost:

BEFORE (fix reverted): Tests  6 failed (6)   <- via links, serialisedLinks, reportedErrors
AFTER  (fix present):  Tests  6 passed (6)

eslint on the file now reports only the two inherited reportError warnings; the incremental renderer one is gone:

✖ 2 problems (0 errors, 2 warnings)   # both @/platform/telemetry/reportError, pre-existing

The rendering claim that field was standing in for is now owned entirely by the Playwright case, which is the layer that actually renders.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up: I have now taken the second option you offered here as well, in 90f5b011.

My earlier reply only did the first half — removing the layoutStore import so the litegraph test returns to its leaf boundary — and dropped the assertion rather than relocating it. Your comment explicitly allowed "move the layout-integrated assertion to the renderer/service-layer test that owns layoutStore", and that is the better answer, because it also satisfies 4056573223's geometry request at the same time.

The assertion now lives in src/renderer/core/layout/operations/subgraphConversionLayout.test.ts, next to the existing graphLayoutAttachment.test.ts that owns this area. Renderer importing lib is the permitted direction, so there is no restricted-path violation — eslint reports nothing at all on the new file:

$ npx eslint src/renderer/core/layout/operations/subgraphConversionLayout.test.ts
(no output)

The litegraph test is unchanged from my previous reply and still carries only the two inherited reportError warnings. Net effect: the layer boundary holds, and the layout behaviour is covered at the layer that owns it — with a test that goes red pre-fix, which the version inside the litegraph test never would have proven on its own.

return {
nodes: definition.nodes.length,
links: definition.links.size,
interiorNodesWithLayout: definition.nodes.filter(({ id }) =>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Counting layout entries proves that keys survive, but not that each interior node keeps its geometry. A conversion that swaps the two records or replaces both with default geometry still passes. Please give the nodes distinct, hand-checkable positions or sizes and compare the ID-to-layout mapping before and after wrapping in one representative nested case.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the weakness — key-presence counting was too weak, and it is gone. But I have to push back on the geometry comparison as the replacement: I built it, and it does not bite.

I added getDefinitionNodeGeometry() returning id -> { pos, size } and a case asserting the deepest interior against hand-checkable literals from the asset, before and after wrapping:

const DEEPEST_INTERIOR_GEOMETRY = {
  '4': { pos: [26, 474],  size: [315, 98] },
  '5': { pos: [473, 609], size: [315, 106] },
  '7': { pos: [413, 389], size: [425, 181] }
}

Run against pre-fix code, that case passed, while the other three failed:

1) ... keeps the wrapped and nested definitions populated      FAILED
2) ... keeps every nested interior node at its own position    PASSED   <-- pins nothing
3) ... keeps the nested definitions populated in the saved wf  FAILED
4) ... still renders the nested interior after wrapping        FAILED

The reason is the shape of this bug. releaseSubgraphs wipes the link store and the layout-store records, but the Subgraph instance survives with its _nodes array and each node's own pos/size untouched. That matches the reported workflow exactly — in purz's corrupted file all 28 interior nodes kept byte-identical pos/size while links went 77 -> 0. So geometry is simply not a channel this regression travels through, and a geometry assertion here would be a test that never goes red — the exact failure mode this PR exists to correct in the base branch's test.

The geometry that does change is the layout store, which is what you were pointing at. I checked whether an E2E could read it: it is a module singleton, not exposed on window, and no browser test touches it (grep -rn "layoutStore" browser_tests/ returns one unrelated comment). Reaching it would mean adding a test-only global to production, and asserting it from the unit test is precisely what your other comment asks me to stop doing — the two requests point opposite ways, so I resolved in favour of the layer boundary.

What I did instead, to close the "swapped or default content still passes" hole at the layer that owns rendering: the render case now asserts all three interior nodes by their distinct titles, not just a count.

await expect(comfyPage.vueNodes.nodes).toHaveCount(3)
await expect(comfyPage.vueNodes.getNodeByTitle('Load Checkpoint')).toBeVisible()
await expect(comfyPage.vueNodes.getNodeByTitle('Empty Latent Image')).toBeVisible()
await expect(comfyPage.vueNodes.getNodeByTitle('CLIP Text Encode (Prompt)')).toBeVisible()

Three distinct identities cannot be satisfied by placeholders, a collapsed set, or one node rendered three times, and it goes red pre-fix because nothing renders at all. The non-biting case and its now-unused helper were removed (pnpm knip clean). Happy to revisit if you would rather expose the layout store to E2E deliberately — that is a bigger call than this PR should make on its own.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisiting this — you were right and my earlier pushback was wrong. Now implemented in 90f5b011.

My mistake was treating this comment and 4056573221 as irreconcilable. 4056573221 spelled out the reconciliation I skipped: "or move the layout-integrated assertion to the renderer/service-layer test that owns layoutStore." I only took the first branch (remove it from the litegraph test) and dropped the assertion instead of relocating it.

The earlier geometry attempt failed because I read the wrong source. node.pos is never perturbed by this bug, so it could not go red. The geometry that does change is the layout store, which detachGraphLayouts clears — exactly the "ID-to-layout mapping" you named. Asserting it belongs at the renderer layer, where importing both litegraph and layoutStore is the legal direction, so the litegraph test stays leaf-clean and both comments are satisfied at once.

New test: src/renderer/core/layout/operations/subgraphConversionLayout.test.ts, alongside the existing graphLayoutAttachment.test.ts that owns this area. It gives the two interior nodes distinct positions, then compares the id-to-layout mapping either side of wrapping their host:

setNodePosition(origin, [110, 220])
setNodePosition(target, [330, 440])
// ... wrap innerHost into a new subgraph ...
expect({ before, after: interiorGeometry(rootGraph, inner) }).toEqual({
  before: { 1: { x: 110, y: 220 }, 2: { x: 330, y: 440 } },
  after:  { 1: { x: 110, y: 220 }, 2: { x: 330, y: 440 } }
})

And unlike the node.pos version, it bites:

BEFORE (fix reverted):            AFTER (fix present):
-  "1": { "x": 110, "y": 220 }    Tests  1 passed (1)
-  "2": { "x": 330, "y": 440 }
+  "1": null
+  "2": null
   Tests  1 failed (1)

Because the positions are distinct and keyed by id, this also fails on the two cases you called out: a swap surfaces as 1 -> {330,440}, and a reset to defaults surfaces as neither matching. eslint reports nothing on the new file — renderer importing lib is the permitted direction. pnpm typecheck clean; src/renderer/core/layout/operations/ 28 passed.

- Restore the src/lib leaf boundary: drop the layoutStore import from the
  litegraph test, along with the interiorNodesWithLayout field and the
  resetForTests call it required. The remaining fields (links,
  serialisedLinks, reportedErrors) still take all six cases red on
  pre-fix code, so no signal is lost.
- Scope the spec's selection and expectation constants into the describe
  block, beside the assertions that consume them.
- Name every phase of the render case with test.step, so a failure
  identifies the phase.
- Assert all three interior nodes by title after descending, so the case
  cannot pass on placeholder or default content.

A geometry comparison was tried for the interior nodes and removed: this
bug does not perturb node.pos or node.size. The teardown wipes links and
layout-store records while the surviving Subgraph keeps its node objects
untouched, which matches the reported workflow where all 28 interior
nodes kept byte-identical positions. The geometry test passed on pre-fix
code, so it pinned nothing.
@glary-bot

glary-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown

@DrJKL status summary — all four review points are addressed in 991c418 (pushed; PR head is that commit). GitHub already marks all four threads outdated, since the lines they point at have changed.

Each thread has a detailed reply; the short version:

Thread Point Outcome
4056573217 P3 module-scope constants Applied — moved inside the describe, beside their assertions
4056573219 P3 unnamed phases Applied — wrap / descend / assert are all named steps; wrap labelled consistently in the other two cases
4056573221 P2 src/lib → src/renderer Applied — layoutStore import removed with the field and reset it required; eslint back to only the 2 inherited reportError warnings
4056573223 P2 geometry vs key-presence Partially applied, with pushback — weak key-count removed; geometry comparison implemented, measured, and rejected because it does not bite

On the one I pushed back on: I built the requested id -> { pos, size } comparison with hand-checkable literals and ran it against pre-fix code. It passed while the other three failed. releaseSubgraphs wipes the link store and layout records but leaves the surviving Subgraph's node objects untouched — in the reported workflow all 28 interior nodes kept byte-identical pos/size while links went 77 -> 0. A geometry assertion here can never go red for this regression, which is the same defect this PR exists to fix in the base branch's test. The hole you identified is instead closed at the rendering layer: the render case now asserts all three interior nodes by distinct title, which cannot pass on placeholder or default content and does go red pre-fix. Full reasoning in that thread.

Current state on 991c418:

Vitest  SubgraphConversion.nestedDefinitions   6 passed   (6 failed pre-fix)
E2E     subgraphWrapNestedDefinition           3 passed   (3 failed pre-fix)
Vitest  src/lib/litegraph/src/subgraph/      361 passed
eslint / oxlint / oxfmt / knip / typecheck   clean

Two process notes: I have not resolved these threads, per CONTRIBUTING.md — resolution is the reviewer's call, not the author's. I also tried to re-request your review to signal readiness and the bot account lacks permission (403 Resource not accessible by integration), so please re-request or resolve at your discretion.

One open question worth your call, from the geometry thread: the geometry that does change here is the layout store, but it is a module singleton not exposed on window, and no browser test reads it. Asserting it from E2E would mean adding a test-only production global; asserting it from the unit test is what thread 4056573221 asks me to stop doing. I resolved for the layer boundary — happy to revisit if you would rather expose it deliberately.

…ubgraph

Reviewer asked for a geometry comparison of the interior nodes, and
offered moving a layout assertion to the renderer test that owns
layoutStore. My first attempt read node.pos, which this bug never
perturbs, so it passed on pre-fix code and pinned nothing.

The geometry that does change is the layout store, which detachGraphLayouts
clears. Asserting it belongs at the renderer layer, where importing both
litegraph and layoutStore is the legal direction, so the litegraph test
stays inside its leaf boundary.

Gives the two interior nodes distinct positions, then compares the
id-to-layout mapping either side of wrapping their host. Pre-fix both
records read null; with the fix both keep their own position, so a swap
or a reset to defaults fails too.
@glary-bot

glary-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown

@DrJKL thanks — the two summary findings were both correct and I've acted on them. One heads-up first, then the evidence you asked for.

This review ran against the first commit, not the current head

The tell is "three warnings": 6e6c28a has three restricted-path imports in the litegraph test, 991c418 and 90f5b011 have two.

6e6c28add2 -> 3    (2x reportError + layoutStore)
991c418ea4 -> 2
90f5b011fd -> 2    <- current head

All four inline findings were already fixed before this review ran, in 991c418 and 90f5b011, and each thread has a reply. Notably your P2 on geometry — I initially pushed back and I was wrong; 90f5b011 implements it properly at the renderer layer, per the second option you offered in the restricted-paths comment. Worth re-reading those two threads against the current head.

Summary P2 — warning attribution: you're right, corrected

The description said "3 pre-existing" warnings. That was wrong: two reportError warnings are inherited from the base, the third (layoutStore) was incremental and mine. That import is gone as of 991c418, so this head carries only the two inherited ones, and the relocated layout assertion lives in a renderer-layer test where the import direction is legal and eslint reports nothing.

Summary P3 — unevidenced claims: narrowed

  • "pixel for pixel" was an overclaim. The captures differ in viewport, zoom and workflow from the reporter's screenshot, and that image is not checked in. It is a qualitative match of the symptom — blank canvas with only the IO stub — and nothing more.
  • The delete/undo and copy/paste probes were throwaway and are not checked in, with no logs linked. They are an informal spot check, not evidence. The checked-in suite covers the convert-to-subgraph path only.

I could not apply these to the PR body directly — PATCH /pulls/18159 returns 403 Resource not accessible by integration for this bot — so please treat this comment as the correction of record, or paste it in.

Unverified candidate — settled with a backend

This sandbox has a real ComfyUI backend, so I ran what you couldn't.

A. Current head 90f5b011, targeted spec:

3 passed (25.8s)

B. Same head, only the 12e6a724 product patch reverted (2 insertions, 3 deletions in LGraph.ts):

3 failed
  1) keeps the wrapped and nested definitions populated
  2) keeps the nested definitions populated in the saved workflow
  3) still renders the nested interior after wrapping
       › Descend through the wrapper into the deepest nested subgraph

- "links": 7   + "links": 0      (subgraph 2 wiring destroyed)
- "links": 6   + "links": 0      (subgraph 3 wiring destroyed)
Error: element(s) not found     (interior renders nothing)

C. The two named specs checked out directly on 12e6a724, my commits absent — and this one corrects me:

1 failed    subgraphSeed.spec.ts › Seed handling › seed updates on generation
1 passed    subgraphDraftPositions.spec.ts

So subgraphSeed is genuinely pre-existing, but subgraphDraftPositions passed on base — it is flaky in this sandbox, not a deterministic pre-existing failure. My earlier "both fail identically" was drawn from a single observation and was wrong. Neither spec is touched by this PR.

Also worth noting for the loop we seem to be in: all four threads are resolved: false but GitHub marks them outdated: true, and there is no pending review request. I can neither resolve them (author, per CONTRIBUTING.md) nor re-request review (403 again), so that needs someone with write access.

@christian-byrne
christian-byrne merged commit 3185562 into fix/subgraph-release-serialization-mismatch Sep 20, 2026
100 checks passed
@christian-byrne
christian-byrne deleted the glary/fe-2497-wrap-nested-subgraph-tests branch September 20, 2026 10:57
christian-byrne added a commit that referenced this pull request Sep 21, 2026
A `test.fixme`/`.skip` landed to unblock a red `main` is a promise to come
back, and the PR body is the only place that promise survives. #16907
disabled `agentPanelLifecycle.spec.ts` with a completely empty body, so
recovering the intent later meant reconstructing the failure direction from
commit timestamps.

This fails a pull request that newly disables a test unless its body names a
tracking issue or follow-up PR, and prints the file and line so the author
does not have to hunt for it.

Scoped to avoid crying wolf, since a guard that fires on ordinary work gets
routed around:

- Only DISABLING declarations, matched as a first argument that is a string
  literal. Playwright's conditional `test.skip(condition, 'reason')` and bare
  `test.skip()` are runtime controls, not a test taken out of service.
- Only lines this PR ADDS. A disable already on the base branch is not this
  author's debt to justify.
- Only test sources, so a doc or changelog mentioning `test.fixme` is inert.

Verified against the case that motivated it: replaying #16907's real base and
head with its real (empty) body fails and names
`agentPanelLifecycle.spec.ts: test.fixme('supports keyboard activation ...`.
The same replay over the last six merged spec-touching PRs (#18213, #18201,
#18197, #18183, #18159, #18174) passes, as do synthetic cases for conditional
skip, bare skip, docs-only mention, and an unrelated edit to a file that
already had a disabled test. shellcheck clean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants