Repository navigation
FE-2502 fix(billing): read the billing SDK flags off /features - #18141
Conversation
🎭 Playwright: ✅ 2039 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.92 MB gzip 🔴 +104 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 566 kB (baseline 565 kB) • 🔴 +401 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 73 added / 73 removed / 225 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T16:28:10.807Z",
"gitSha": "38347c0e2b5f75c386aa9b17a01d2155fe723294",
"branch": "jaewon/fe-2502-read-the-billing-sdk-flags-from-features",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2056.28200000001,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.735000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.254,
"heapDeltaBytes": 8661916,
"heapUsedBytes": 69457908,
"domNodes": -265,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 11.328999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2011.304999999993,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.044,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.999,
"heapDeltaBytes": 9875176,
"heapUsedBytes": 71610096,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.241000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1842.3950000000104,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.133,
"layouts": 14,
"layoutDurationMs": 4.377000000000001,
"taskDurationMs": 835.8520000000001,
"heapDeltaBytes": 2986020,
"heapUsedBytes": 65093272,
"domNodes": -264,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 167.66500000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1839.2880000000105,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.773,
"layouts": 14,
"layoutDurationMs": 4.692,
"taskDurationMs": 840.2749999999999,
"heapDeltaBytes": 12441300,
"heapUsedBytes": 74420488,
"domNodes": -264,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 164.17600000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.6279999999906,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.795999999999998,
"layouts": 6,
"layoutDurationMs": 1.167,
"taskDurationMs": 324.781,
"heapDeltaBytes": 1796492,
"heapUsedBytes": 64026244,
"domNodes": 74,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 10.988999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.7339999999695,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.646,
"layouts": 6,
"layoutDurationMs": 1.2759999999999998,
"taskDurationMs": 326.39399999999995,
"heapDeltaBytes": 2244792,
"heapUsedBytes": 63961648,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.105,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 611.8290000000002,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.782999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.818,
"heapDeltaBytes": 17851616,
"heapUsedBytes": 79930112,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 165.29,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 631.1279999999897,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.647,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.612,
"heapDeltaBytes": 17847644,
"heapUsedBytes": 80046632,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 168.976,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2016.5190000000166,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.6430000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.438,
"heapDeltaBytes": 3453612,
"heapUsedBytes": 83143672,
"domNodes": -253,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 32.09000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2031.865000000039,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.691000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.0260000000001,
"heapDeltaBytes": 1880048,
"heapUsedBytes": 81676296,
"domNodes": -249,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 39.366,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2173.5060000000317,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.231999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1572.2310000000002,
"heapDeltaBytes": 18388976,
"heapUsedBytes": 82579108,
"domNodes": 4,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 812.338,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2204.902000000061,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.851999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1570.0669999999998,
"heapDeltaBytes": 14316480,
"heapUsedBytes": 78636484,
"domNodes": -257,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 816.151,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3498.012000000017,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.008999999999999,
"layouts": 60,
"layoutDurationMs": 12.844,
"taskDurationMs": 1676.0609999999997,
"heapDeltaBytes": 9445164,
"heapUsedBytes": 74389800,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 789.2889999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3498.348000000078,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.131999999999998,
"layouts": 60,
"layoutDurationMs": 12.896,
"taskDurationMs": 1675.999,
"heapDeltaBytes": 7930096,
"heapUsedBytes": 74179032,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 786.785,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3125.8490000000165,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.617999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1890.017,
"heapDeltaBytes": 22792580,
"heapUsedBytes": 88597696,
"domNodes": -258,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 961.884,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3137.248999999997,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1910.721,
"heapDeltaBytes": 18316184,
"heapUsedBytes": 83986608,
"domNodes": 0,
"jsHeapTotalBytes": 2252800,
"scriptDurationMs": 980.4300000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2013.639000000012,
"styleRecalcs": 4,
"styleRecalcDurationMs": 6.265,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.5569999999999,
"heapDeltaBytes": 20116024,
"heapUsedBytes": 83860340,
"domNodes": -254,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.969,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2031.842000000097,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.141000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.8360000000001,
"heapDeltaBytes": -3060772,
"heapUsedBytes": 83667704,
"domNodes": -248,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.823000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.2219999999634,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.921,
"heapDeltaBytes": 13451200,
"heapUsedBytes": 76672724,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 145.02200000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.6679999999833,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.283999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.038,
"heapDeltaBytes": 13717912,
"heapUsedBytes": 77051016,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 138.45499999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2004.1589999999587,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.949999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.78599999999994,
"heapDeltaBytes": 15202496,
"heapUsedBytes": 78443464,
"domNodes": -276,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.950000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2021.8699999999217,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.03,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.76599999999996,
"heapDeltaBytes": 7429096,
"heapUsedBytes": 70778656,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.366000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.7469999999835,
"styleRecalcs": 78,
"styleRecalcDurationMs": 25.79,
"layouts": 18,
"layoutDurationMs": 4.995,
"taskDurationMs": 765.5970000000001,
"heapDeltaBytes": 11688480,
"heapUsedBytes": 74859040,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 104.963,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.1200000000981,
"styleRecalcs": 79,
"styleRecalcDurationMs": 26.726999999999997,
"layouts": 18,
"layoutDurationMs": 4.737,
"taskDurationMs": 759.2540000000001,
"heapDeltaBytes": 774964,
"heapUsedBytes": 64081360,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 105.825,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.2879999999986,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.452000000000005,
"layouts": 5,
"layoutDurationMs": 13.073999999999998,
"taskDurationMs": 879.136,
"heapDeltaBytes": -6433480,
"heapUsedBytes": 81205576,
"domNodes": 13587,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 29.625000000000007,
"eventListeners": 2383,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8374.89800000003,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.776,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5754.2210000000005,
"heapDeltaBytes": -4148244,
"heapUsedBytes": 75543984,
"domNodes": -246,
"jsHeapTotalBytes": 708608,
"scriptDurationMs": 2781.751,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8312.346999999932,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.82599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5929.231,
"heapDeltaBytes": -9290196,
"heapUsedBytes": 69502760,
"domNodes": -248,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 2927.9829999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16915.463999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16509.519,
"heapDeltaBytes": -47857004,
"heapUsedBytes": 190234568,
"domNodes": -8061,
"jsHeapTotalBytes": -16224256,
"scriptDurationMs": 258.252,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17269.333000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16766.420000000002,
"heapDeltaBytes": -38880812,
"heapUsedBytes": 177698248,
"domNodes": -8061,
"jsHeapTotalBytes": -13766656,
"scriptDurationMs": 285.257,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20364.741999999977,
"styleRecalcs": 167,
"styleRecalcDurationMs": 16.455,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20008.619,
"heapDeltaBytes": -38243180,
"heapUsedBytes": 178458264,
"domNodes": -8062,
"jsHeapTotalBytes": -17764352,
"scriptDurationMs": 847.626,
"eventListeners": -14928,
"totalBlockingTimeMs": 40,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21053.05499999997,
"styleRecalcs": 167,
"styleRecalcDurationMs": 17.246999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20741.355,
"heapDeltaBytes": -24389040,
"heapUsedBytes": 190014788,
"domNodes": -8061,
"jsHeapTotalBytes": -15020032,
"scriptDurationMs": 888.944,
"eventListeners": -14928,
"totalBlockingTimeMs": 76,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6179.221999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.66300000000001,
"layouts": 20,
"layoutDurationMs": 23.428000000000004,
"taskDurationMs": 6057.451,
"heapDeltaBytes": -38154212,
"heapUsedBytes": 176875876,
"domNodes": -8061,
"jsHeapTotalBytes": 8151040,
"scriptDurationMs": 112.00500000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 540,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6177.38200000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.161,
"layouts": 20,
"layoutDurationMs": 22.219,
"taskDurationMs": 6055.306999999999,
"heapDeltaBytes": -30918040,
"heapUsedBytes": 181692924,
"domNodes": -8061,
"jsHeapTotalBytes": 14221312,
"scriptDurationMs": 103.02799999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 450,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8462.19400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8299.894,
"heapDeltaBytes": -2163752,
"heapUsedBytes": 167995832,
"domNodes": 0,
"jsHeapTotalBytes": -28573696,
"scriptDurationMs": 163.69500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8573.841000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8322.073999999999,
"heapDeltaBytes": -11066356,
"heapUsedBytes": 175122732,
"domNodes": 0,
"jsHeapTotalBytes": -18874368,
"scriptDurationMs": 153.47,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 502.3959999999761,
"styleRecalcs": 24,
"styleRecalcDurationMs": 28.227000000000004,
"layouts": 6,
"layoutDurationMs": 2.679,
"taskDurationMs": 145.94,
"heapDeltaBytes": 5353796,
"heapUsedBytes": 67076616,
"domNodes": 151,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.354,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 112.97000000001844,
"styleRecalcs": 9,
"styleRecalcDurationMs": 17.556,
"layouts": 2,
"layoutDurationMs": 0.6730000000000002,
"taskDurationMs": 83.41399999999999,
"heapDeltaBytes": 3070240,
"heapUsedBytes": 64719140,
"domNodes": 109,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.761,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe change adds remote configuration fields for embedded checkout and billing SDK flags. Billing getters now use the shared resolution chain with strict boolean handling and server fallback. Tests cover configured values, fallback behavior, malformed values, and cleanup. ChangesBilling feature flag resolution
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant BillingFlagGetter
participant resolveStrictBooleanFlag
participant RemoteConfig
participant ServerFeatureAPI
BillingFlagGetter->>resolveStrictBooleanFlag: Resolve billing feature flag
resolveStrictBooleanFlag->>RemoteConfig: Read configured value
resolveStrictBooleanFlag->>ServerFeatureAPI: Read fallback when key is absent
resolveStrictBooleanFlag-->>BillingFlagGetter: Return true only for literal true
Suggested reviewers: 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18141 +/- ##
==========================================
+ Coverage 82.78% 83.81% +1.02%
==========================================
Files 2939 2244 -695
Lines 144660 127676 -16984
Branches 37220 34353 -2867
==========================================
- Hits 119763 107007 -12756
+ Misses 23630 20380 -3250
+ Partials 1267 289 -978
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 707 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approving. Picked this one out of the thirteen open because it has the smallest diff and the largest blast radius — it decides which rail every other PR in the wave runs on.
The two things that could have gone wrong here are both right.
Precedence is ??, not ||. resolveFlag ends with
return remoteConfigValue ?? api.getServerFeature(flagKey, defaultValue)so an explicit false from /features beats a stale handshake true, and only undefined falls through. With || a staged rollout that had turned a cohort off would silently fall back to the handshake and keep the rail open. That distinction is the whole safety of a staged ramp and it is easy to get wrong.
Strictness survives the refactor. resolveStrictBooleanFlag still ends in === true, so 'true', 1 and a thrown lookup all resolve false. The docstring says why in the right terms — "rather than switching a charge onto a new transport" — which is the correct framing for a flag that moves money, not a generic boolean.
One behaviour change your description does not mention, which we checked before raising. resolveFailClosedBooleanFlag called api.getServerFeature directly; resolveStrictBooleanFlag goes through resolveFlag, so these three payment flags now honour session and dev overrides for the first time.
That is fine, and we verified rather than assumed: getSessionOverride returns undefined unless isCloud and isComfyEmployee(). So it is employee-only on a cloud build, not customer-reachable, and it makes the rail testable by the people who need to test it during the ramp. Worth a line in the PR body anyway, because "payment flags became overridable" is a sentence someone will want to find later.
What we did not verify. The premise — that Comfy-Org/cloud@main already publishes both keys through /api/features with a sticky per-user rollout — is cited precisely (flags.go:224-225, :582, :591, :721-722) but is cross-repo and not checkable from here. We are taking it as stated. If it is wrong the failure is safe in the right direction: remoteConfig would be undefined, the ?? falls through to the handshake, and behaviour is exactly what it is today.
CI clean. Approved.
On the rest of the wave, so it is not silently queued. Twelve of the thirteen open PRs are base main, MERGEABLE, and carry no review decision — including all four consumers #18036 named (FE-2480 #18134, FE-2482 #18133, FE-2484 #18135, FE-2474 #18132), which is the tracked hand-off working exactly as promised. We are not going to pretend to have reviewed thirteen PRs in one pass. We will take them by risk — team checkout (#18136) and pending-operation recovery (#18135) next, then the reads, then the E2E suites. If you want a different order, say so and we will follow it.
|
Following up on our approval, because your flag-timing write-up on #18135 changes how we read this PR — and one thing in it needs your answer before this merges. First, the bookkeeping. That write-up says "I have not fixed it: it is flag plumbing, not billing, and wants its own ticket and reviewer," and asks which team owns the flag layer. It posted at So the ticket ask is stale. Worth saying out loud on the Slack thread, because otherwise Christian goes looking for a flag-layer owner for something you have already fixed and we have already reviewed. Now the part that matters. We verified boot does await But that call is This file already has a resolver for exactly that hazard: function resolveAuthGatedFlag(...) {
...
if (!isAuthenticatedConfigLoaded.value) return cachedValue.value ?? false
return remoteConfigValue ?? api.getServerFeature(flagKey, false)
}
The question we cannot answer from this repo: does the anonymous Two outcomes, and they are very different:
One small piece of evidence that this was not weighed: the diff inserted We are not un-approving — if the keys are absent when anonymous this is safe and still an improvement. But it is a payment rail, so we would rather ask than assume. If the answer is "present and anonymously evaluated", these three should use |
…n that implements it (Comfy-Org#18158) ## Why `Comfy-Org#18141` left the anonymous-window warning on `useFeatureFlags.ts` sitting on top of a function that deliberately does not implement it, and left `resolveAuthGatedFlag` — the function the warning describes — with no docstring at all. This is the file where the next "does this flag need an auth gate?" decision gets made, and on `main` it currently argues the opposite of what the code does. It already cost one review round on Comfy-Org#18135. ## Root cause `Comfy-Org#18141` inserted `resolveStrictBooleanFlag` between `resolveAuthGatedFlag`'s docstring and its body. Mine; a placement slip, not a behavior change. ## How Move the docstring back onto `resolveAuthGatedFlag`, and record on `resolveStrictBooleanFlag` why the three payment flags do not need that gate — the answer is a backend invariant not readable from this repo: `cloud@main:common/featuregates/flags.go:582` and `:591` guard both keys with `if eval.UserID == "" { return false }` before PostHog is consulted, per the documented `FrontendFlags` invariant at `:655`. So the anonymous `/api/features` payload carries these keys as a concrete `false`, the `??` in `resolveFlag` short-circuits there, and the anonymous window resolves to the legacy rail. The hazard `resolveAuthGatedFlag` exists to prevent — booting `true` and flipping `false` once authenticated config lands — is unreachable for them. Comment-only. No behavior change, no test change: `useFeatureFlags.test.ts` passes unchanged at 79/79. ## AS IS / TO BE Not applicable — no user-facing behavior, no rendered surface. The diff is two doc comments in one non-component module.
…ishes on #18141 made /api/features the primary flag channel and demoted the websocket handshake to fallback. Seeding only the handshake left these rows passing on the fallback channel, not the one production prefers. Serve the flag on both channels for the rail-on rows, so neither alone carries the assertion.
…ishes on #18141 made /api/features the primary flag channel and demoted the websocket handshake to fallback. Seeding only the handshake left these rows passing on the fallback channel, not the one production prefers. Serve the flag on both channels for the rail-on rows, so neither alone carries the assertion.
|
Answered in #18158, which landed 84 minutes after this comment — but nothing was posted back here, so the question looked open. Closing that loop. The answer is your first outcome, reached a different way: the keys are present when anonymous, with a concrete
That makes your second outcome unreachable, so no On the race: your conclusion holds — the request ordering is unchanged, and the E2E notes on #18135 and #18140 should stay as they are. What #18141 actually bought is that the four boot reads now resolve against a definite value instead of falling through to a handshake that has not landed; the rail they select at boot is legacy either way. Docstring placement: fixed in #18158 — the anonymous-window warning is back on One thing your comment did not raise, which I checked and want on the record. I looked at whether the So that Go guard is load-bearing and single-point: if |
…og-js flag path (#19074) *PR Created by the Glary-Bot Agent* --- Fixes the root cause behind [PM-1707](https://linear.app/comfyorg/issue/PM-1707/test-agentcomfyorg-shows-the-agent-on-my-phone-but-not-on-desktop-in) / [PM-1706](https://linear.app/comfyorg/issue/PM-1706/fix-agent-does-not-appear-on-desktop-browsers-for-a-user-while-it) — an allowlisted user saw the agent on one browser but not another. Supersedes #18842, which only characterized the old behaviour. ## Why this was happening `agent-in-app-experience` was already published on `/features` (it's in `FrontendFlags` in the cloud repo, evaluated server-side per authenticated user) and the app already fetched that payload into `window.__CONFIG__` at bootstrap. The agent gate ignored it and re-asked PostHog over a second, independently-failing client path — the only flag in the codebase still doing so. Billing was migrated to this rail in #18141; the agent gate was missed. Because posthog-js keys flags by its own `distinct_id` and caches them per-origin in `localStorage` while sharing identity cross-subdomain via cookie, two browsers on the same account could disagree. That's the divergence users saw. ## What changed `agent-in-app-experience` is now a `ServerFeatureFlag` resolved through `useFeatureFlags` off `remoteConfig`, via a new `resolveWhitelistFlag()`: - `false` off the Cloud build, and `false` before the first authenticated answer (the anonymous bootstrap payload cannot answer a per-user allowlist) - after an authenticated answer, a *failed* refresh falls back to that answer, held **in memory for the session only** — never storage. A persisted grant is precisely what made two browsers disagree. - revocation propagates on the next successful poll; 401/403 and sign-out clear it `setupFlagGate` loses the dynamic imports, the `onFeatureFlags` subscription and the delivery plumbing, becoming two reactive watches. Deleted: `postHogFlagSource.ts`, `useAgentFeatureGate.ts` (dead code — nothing but its own test imported it, and it lacked the `errorsLoading` guard, so the two copies behaved differently), and their tests. `posthog-js` stays — telemetry still uses it. This removes only the flag path. ## Verification Every guard is mutation-tested; each of these turns the suite red: | Mutation | | |---|---| | anonymous-window guard removed (fail-open before auth) | caught | | `isCloud` guard removed | caught | | fail-open before the first authenticated answer | caught | | grant fallback removed (a blip unmounts the panel) | caught | | grant survives sign-out / 401 | caught | | grant never recorded on a successful load | caught | | **grant persisted via `useStorage`** — the PM-1707 shape, under either the flag key *or* a renamed key | caught | | gate `enabled` unwired from the flag | caught | | gate settles on the anonymous config | caught | | signed-out settle fallback removed | caught | `pnpm typecheck`, `lint`, `knip`, `format:check` clean; 12,129 unit tests pass. The one broad-run failure (`agentSubgraphDefinitions`) reproduces identically on `main`. Two bugs were caught during review and fixed here rather than shipped: a transient `/features` failure would have unmounted the panel mid-session for a granted user (`DockedAgentPanel` is `v-if`, so composer draft and in-flight turn UI are destroyed), and the E2E fixtures were still feeding the flag through the deleted posthog channel, which would have regressed the whole agent E2E suite to a dead panel. ## Notes for reviewers - **E2E fixtures changed.** All three now put the key at the top level of the `/features` body. Specs can't be executed in my sandbox; the static chain is verified end to end (`cloudBootMocks` serves that body to both fetches, and `WorkspaceAuthGate` throws unless state is `authenticated`, so any spec that renders has reached the state the resolver needs). **One CI run of `--project=cloud` on a single agent spec would settle it conclusively.** - **Retired telemetry slug.** `agent_flag_gate_load_failure` no longer exists — the guarded dynamic import it reported on is gone. Any monitor keyed on it will go silently to zero. - **New Datadog facet.** The flag is added to `startFeatureFlagTelemetry`. It's the first dashed `ServerFeatureFlag`, and the sanitiser rewrites dashes — the RUM facet is `agent_in_app_experience`, not the hyphenated name. - **Deliberately dropped:** an in-session re-offer retry that existed only because `posthog.onFeatureFlags` re-delivered unchanged values. The real retry triggers (`offerHeld && screenIsClear`, identity change) are unaffected and still covered. - **Known residue:** the grant-retention window is unbounded, so a sustained `/features` outage leaves a revoked user with an inert panel until reload. Low impact — the backend enforces the flag independently at four choke points, so every call 404s regardless. --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Why
Milestone 1's ramp (FE-2486 staging, FE-2489 production) raises
billing_sdk_topup_enabledandbilling_sdk_subscription_enabledin stages. Today the client cannot see a staged value, and cannot see any value in time to gate the code that reads it.The backend has been sending these all along. On
Comfy-Org/cloud@main,common/featuregates/flags.godeclares both keys (:224–:225), evaluates them through PostHog with a per-user sticky percentage rollout (:582,:591), and lists both inFrontendFlags(:721–:722) — so/api/featurescarries them. Its own comment says so: "ROLLOUT flags: per user via PostHog, sticky by UserID… the frontend routes on them via/api/features."embedded_checked_enabledis there too (:214,:576).The client throws that value away.
Root cause
resolveFailClosedBooleanFlag(useFeatureFlags.ts:100) was one call toapi.getServerFeature(...). That readsapi.serverFeatureFlags, which only the WebSocketfeature_flagsmessage ever populates (api.ts:1012, the sole assignment in the repo). The/featuresresponse lands in a different object,remoteConfig, andRemoteConfighad no field for any of these keys — so there was no path from the value the server sends to the flag the app reads.Two consequences:
No percentage ramp. The WebSocket pipe delivers a value, not a cohort. The staged rollout exists on the server and is invisible to the client.
The flag arrives after the code that reads it. Every billing rail is
billing_sdk_<flow>_enabled AND unified_cloud_auth.unified_cloud_authcomes off/features, which boot awaits (main.ts:56). The billing key comes off a socketcreateSocket()does not open until the cloud auth token resolves. The billing gate's first reads fire before that. Measured in CI on one page load with the read rail on:Status, balance, plans and capabilities all served by the legacy client. A pending operation at load is adopted by the legacy poller for the same reason, measured 145 ms before the handshake reached the page. Full write-up with traces: #18135 (comment).
How
RemoteConfiggains the three keys, next tounified_cloud_auth,billing_control_enabledandv1_payment_recovery— the billing flags that were already on this channel. The wire key keeps the server's spelling,embedded_checked_enabled; the frontend'sEMBEDDED_CHECKOUT_ENABLEDconstant already carried that value, so nothing is renamed and the two sides still match.The three getters move onto
resolveFlag, which issessionOverride → devOverride → remoteConfigValue ?? getServerFeature(...)./featuresnow wins, and the WebSocket stays as the fallback — so behaviour is unchanged for any environment where/featuresomits a key.resolveStrictBooleanFlagwraps it rather than replacing it. A straight swap toresolveFlagbreaks nine existing tests, for two reasons worth keeping:'true',1) must not enable a payment flow —resolveFlagreturns it as-is, so the getter would hand back a truthy stringfalse, not propagateThe wrapper is four lines over
resolveFlag: same channels, same overrides,=== truenarrowing and a catch.resolveFailClosedBooleanFlagis deleted.Overrides now apply to these three flags, deliberately. An earlier draft kept them banned, on the theory that the old resolver existed to stop a payment flag being switched on by a URL parameter. That theory is not supported:
v1_payment_recovery,billing_control_enabled,legacy_billing_migration_enabled,hosted_billing_destinationandchurnkey_app_idall ride/featureswith overrides on, and the old resolver carries no comment explaining itself. The likelier reading is that embedded checkout had no/featureskey to read, so it got the smallest resolver that worked, and the billing SDK copied it. Both override paths stay narrow anyway —getSessionOverrideneeds a verified@comfy.orgaddress,getDevOverrideisimport.meta.env.DEVonly.AS IS / TO BE
/featuresvalue is read/featuresomits the keyfalsefalse(unchanged)No capture attached: nothing here renders. The change is which transport a request leaves on, which is what the CI traces above measure and what
billingReadsSdkRail.spec.ts(#18140) asserts.Testing
useFeatureFlags.test.ts— the nine existing fail-closed rows pass unchanged, which is the point; the wrapper keeps exactly what they pin. Four new rows: each billing key read off/features, the WebSocket fallback when/featuresomits it, and a malformed/featuresvalue refused without consulting the handshake. Added theremoteConfigreset thebillingSdkTopupEnabledblock was missing — without it these rows leak into the rail tests below.pnpm test:unit src/composables src/platform/workspace src/platform/cloud— 271 files, 4470 tests.pnpm typecheck,pnpm lint,pnpm knippass.Plan position
Milestone 1 — PR plan. Not one of the plan's 22 PRs: this came out of writing the Step 1b browser specs, which is where the race first showed up.
It is a prerequisite for Step 3. Baking in staging before it lands means FE-2487's evidence table records flows the legacy client actually served as "rail proven" — the flag would read false for everything the billing gate touches at boot.