Repository navigation
FE-2470 feat(billing): team checkout on the SDK subscribe command #18136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dante01yoon
merged 3 commits into
main
from
jaewon/fe-2470-team-subscription-checkout-on-the-sdk-subscribe-command
Sep 19, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /** | ||
| * The host's subscribe options as the generated request body, field for field, | ||
| * including the two the workspace client drops when they arrive empty: JSON | ||
| * keeps `''`, so an empty credential would reach the server as present but | ||
| * meaningless. | ||
| * | ||
| * `SubscribeOptions` carries nothing the generated body lacks. `SubscribeInput` | ||
| * also has `checkout_attempt_id` and `idempotency_key`, which no host caller | ||
| * sets: the SDK mints the key itself, and the checkout attempt is carried on | ||
| * the quote rather than the subscribe. | ||
| * | ||
| * Shared so the two call sites that issue a subscribe on the rail — the | ||
| * workspace billing adapter and the team deep-link checkout — send one body. | ||
| */ | ||
| import type { SubscribeInput } from '@comfyorg/account-core/billing' | ||
|
|
||
| import type { SubscribeOptions } from '@/platform/workspace/api/workspaceApi' | ||
|
|
||
| export function subscribeInputFrom( | ||
| planSlug: string, | ||
| options: SubscribeOptions = {} | ||
| ): SubscribeInput { | ||
| return { | ||
| plan_slug: planSlug, | ||
| confirmation_token: options.confirmationToken || undefined, | ||
| saved_payment_method_id: options.savedPaymentMethodId || undefined, | ||
| promotion_code: options.promotionCode, | ||
| quote_id: options.quoteId, | ||
| quote_version: options.quoteVersion, | ||
| return_url: options.returnUrl, | ||
| cancel_url: options.cancelUrl, | ||
| team_credit_stop_id: options.teamCreditStopId, | ||
| billing_cycle: options.billingCycle, | ||
| confirm_reactivation: options.confirmReactivation, | ||
| proration_at: options.prorationAt | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.