Repository navigation
test(agent): repro redo not restoring an undone agent edit - #18116
claude[bot] wants to merge 14 commits into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ❌ 2138 passed, 1 failed · 2 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle: 10 MB gzip 🟢 -109 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 134 kB (baseline 134 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 4 MB (baseline 4 MB) • 🔴 +269 BStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 578 kB (baseline 578 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 17 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category
Status: 74 added / 74 removed / 227 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-27T17:23:42.323Z",
"gitSha": "bd42f74b8ab2f691f181ee1aa159fc350bfdc42a",
"branch": "test/pm914-agent-undo-redo",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.4639999999945,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.3170000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.211,
"heapDeltaBytes": 1988740,
"heapUsedBytes": 64432996,
"domNodes": -228,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.787,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2006.4639999999372,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.751000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.134,
"heapDeltaBytes": -1391616,
"heapUsedBytes": 61154328,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.009,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1868.6670000000163,
"styleRecalcs": 72,
"styleRecalcDurationMs": 17.702,
"layouts": 12,
"layoutDurationMs": 4.725999999999999,
"taskDurationMs": 866.315,
"heapDeltaBytes": 14651108,
"heapUsedBytes": 76891828,
"domNodes": -228,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 154.468,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1875.1999999999498,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.927,
"layouts": 12,
"layoutDurationMs": 4.706,
"taskDurationMs": 884.5749999999999,
"heapDeltaBytes": 8240796,
"heapUsedBytes": 70726684,
"domNodes": -228,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 158.59400000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.2439999999933,
"styleRecalcs": 29,
"styleRecalcDurationMs": 9.833000000000002,
"layouts": 6,
"layoutDurationMs": 1.3980000000000001,
"taskDurationMs": 352.77599999999995,
"heapDeltaBytes": 2103852,
"heapUsedBytes": 63648072,
"domNodes": 53,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 13.026999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.4939999999933,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.402999999999999,
"layouts": 6,
"layoutDurationMs": 1.437,
"taskDurationMs": 275.311,
"heapDeltaBytes": 2171172,
"heapUsedBytes": 64647496,
"domNodes": 53,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.629000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 729.5500000000175,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.66,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.12699999999995,
"heapDeltaBytes": 18959496,
"heapUsedBytes": 81042192,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 162.522,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 731.049999999982,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.087999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.20399999999995,
"heapDeltaBytes": 18490452,
"heapUsedBytes": 80915276,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 176.558,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1208.1769999999779,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 904.767,
"heapDeltaBytes": -15233116,
"heapUsedBytes": 72403564,
"domNodes": -259,
"jsHeapTotalBytes": 19529728,
"scriptDurationMs": 61.73400000000001,
"eventListeners": -185,
"totalBlockingTimeMs": 554,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1165.070999999898,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 848.1890000000001,
"heapDeltaBytes": 34771936,
"heapUsedBytes": 100067756,
"domNodes": -229,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 62.85700000000001,
"eventListeners": -185,
"totalBlockingTimeMs": 556,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 809.0919999999642,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.10400000000004,
"heapDeltaBytes": 15153392,
"heapUsedBytes": 92605832,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 134.237,
"eventListeners": 0,
"totalBlockingTimeMs": 187,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 807.4420000000373,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.3109999999997,
"heapDeltaBytes": 13335996,
"heapUsedBytes": 90552840,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 135.808,
"eventListeners": 0,
"totalBlockingTimeMs": 194,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9667.67999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8882.921999999999,
"heapDeltaBytes": -7174736,
"heapUsedBytes": 75602800,
"domNodes": 0,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 7367.861,
"eventListeners": 0,
"totalBlockingTimeMs": 1085,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9138.043000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8297.946,
"heapDeltaBytes": -1460352,
"heapUsedBytes": 81935124,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 6558.858,
"eventListeners": 0,
"totalBlockingTimeMs": 244,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8730.721000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7987.358,
"heapDeltaBytes": 4571324,
"heapUsedBytes": 87077104,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 6254.988,
"eventListeners": 0,
"totalBlockingTimeMs": 274,
"frameDurationMs": 18.883333333333333,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9683.471999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8830.597000000002,
"heapDeltaBytes": -13277304,
"heapUsedBytes": 69375928,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 7035.490000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 546,
"frameDurationMs": 19.996666666666716,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2055.7919999999967,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.675999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.2889999999999,
"heapDeltaBytes": -3744720,
"heapUsedBytes": 77823048,
"domNodes": -232,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 34.016000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2043.796000000043,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8110000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 625.351,
"heapDeltaBytes": -6383652,
"heapUsedBytes": 74830900,
"domNodes": -228,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 34.702999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2739.5609999999806,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.283000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1724.3139999999999,
"heapDeltaBytes": 2310736,
"heapUsedBytes": 89166288,
"domNodes": -228,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 858.3629999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2880.5139999999483,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.167000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1734.865,
"heapDeltaBytes": -7107632,
"heapUsedBytes": 75327532,
"domNodes": -228,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 850.247,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3926.1470000000145,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.296000000000001,
"layouts": 60,
"layoutDurationMs": 14.123,
"taskDurationMs": 1806.562,
"heapDeltaBytes": 3557516,
"heapUsedBytes": 87117636,
"domNodes": -228,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 795.6350000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3730.425999999966,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.931,
"layouts": 60,
"layoutDurationMs": 13.644,
"taskDurationMs": 1697.52,
"heapDeltaBytes": 7734640,
"heapUsedBytes": 73685344,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 761.846,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3184.549000000004,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.067999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2036.632,
"heapDeltaBytes": -3379352,
"heapUsedBytes": 80559248,
"domNodes": 0,
"jsHeapTotalBytes": 7487488,
"scriptDurationMs": 992.7539999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3112.4320000000125,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.2010000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1943.4989999999996,
"heapDeltaBytes": 22054692,
"heapUsedBytes": 87972248,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 978.533,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2034.5629999999915,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.529,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.933,
"heapDeltaBytes": -4458836,
"heapUsedBytes": 83797092,
"domNodes": -228,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 33.057,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2034.7809999999527,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.7529999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.5160000000001,
"heapDeltaBytes": -14569548,
"heapUsedBytes": 73834392,
"domNodes": -228,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 31.142000000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 621.1719999999445,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.131999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.28099999999995,
"heapDeltaBytes": 13938856,
"heapUsedBytes": 77453032,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 143.972,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.5299999999124,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.136999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.80100000000004,
"heapDeltaBytes": 13309796,
"heapUsedBytes": 77114504,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 139.129,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.1489999999935,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.005000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.95599999999996,
"heapDeltaBytes": 7351532,
"heapUsedBytes": 76961624,
"domNodes": -244,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.797999999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1999.6570000000702,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.602000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.543,
"heapDeltaBytes": 25352076,
"heapUsedBytes": 88260028,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.798,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.1640000000166,
"styleRecalcs": 59,
"styleRecalcDurationMs": 17.521,
"layouts": 16,
"layoutDurationMs": 6.94,
"taskDurationMs": 764.908,
"heapDeltaBytes": -5821856,
"heapUsedBytes": 57110212,
"domNodes": -244,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 109.39400000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.3799999999674,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.912,
"layouts": 16,
"layoutDurationMs": 5.999,
"taskDurationMs": 825.8489999999999,
"heapDeltaBytes": 14536856,
"heapUsedBytes": 77780952,
"domNodes": -244,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 106.694,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1350.621999999987,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.21899999999999,
"layouts": 5,
"layoutDurationMs": 10.852,
"taskDurationMs": 859.086,
"heapDeltaBytes": 21375656,
"heapUsedBytes": 101780004,
"domNodes": 13667,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 27.203,
"eventListeners": 2383,
"totalBlockingTimeMs": 124,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9708.528000000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.865,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6137.839,
"heapDeltaBytes": 6241740,
"heapUsedBytes": 87753832,
"domNodes": -228,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2855.643,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8493.720000000052,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.393,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5297.054,
"heapDeltaBytes": -13122420,
"heapUsedBytes": 66905120,
"domNodes": -228,
"jsHeapTotalBytes": 2088960,
"scriptDurationMs": 2742.406,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15330.271999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15076.699999999999,
"heapDeltaBytes": -66018372,
"heapUsedBytes": 174415484,
"domNodes": -8049,
"jsHeapTotalBytes": -14094336,
"scriptDurationMs": 233.62199999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 15025.740000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14795.942000000001,
"heapDeltaBytes": -64792932,
"heapUsedBytes": 175609112,
"domNodes": -8049,
"jsHeapTotalBytes": -20996096,
"scriptDurationMs": 262.93100000000004,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18167.079,
"styleRecalcs": 136,
"styleRecalcDurationMs": 16.867999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18048.597999999998,
"heapDeltaBytes": -33933960,
"heapUsedBytes": 192629616,
"domNodes": -8049,
"jsHeapTotalBytes": -18018304,
"scriptDurationMs": 856.41,
"eventListeners": -14923,
"totalBlockingTimeMs": 21,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 18209.22699999994,
"styleRecalcs": 135,
"styleRecalcDurationMs": 16.366999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18038.989999999998,
"heapDeltaBytes": -61271280,
"heapUsedBytes": 179082040,
"domNodes": -8049,
"jsHeapTotalBytes": -19464192,
"scriptDurationMs": 835.394,
"eventListeners": -14923,
"totalBlockingTimeMs": 17,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5467.8849999999675,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.36099999999998,
"layouts": 20,
"layoutDurationMs": 23.82200000000001,
"taskDurationMs": 5438.826,
"heapDeltaBytes": -41356644,
"heapUsedBytes": 177810276,
"domNodes": -8049,
"jsHeapTotalBytes": 16769024,
"scriptDurationMs": 94.176,
"eventListeners": -14923,
"totalBlockingTimeMs": 290,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5544.973000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.96700000000003,
"layouts": 20,
"layoutDurationMs": 23.451,
"taskDurationMs": 5482.4169999999995,
"heapDeltaBytes": -61778720,
"heapUsedBytes": 176036636,
"domNodes": -8049,
"jsHeapTotalBytes": 6356992,
"scriptDurationMs": 99.72500000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 258,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7661.915999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7497.978,
"heapDeltaBytes": -21776848,
"heapUsedBytes": 169309212,
"domNodes": 0,
"jsHeapTotalBytes": -26214400,
"scriptDurationMs": 120.85000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7741.904999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7613.808000000001,
"heapDeltaBytes": -1951572,
"heapUsedBytes": 185342168,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 112.60599999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 120.23999999996704,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.296000000000001,
"layouts": 4,
"layoutDurationMs": 2.1879999999999997,
"taskDurationMs": 90.29600000000002,
"heapDeltaBytes": 3127812,
"heapUsedBytes": 65073036,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.059000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 118.61100000010083,
"styleRecalcs": 9,
"styleRecalcDurationMs": 17.217,
"layouts": 4,
"layoutDurationMs": 2.3320000000000003,
"taskDurationMs": 97.207,
"heapDeltaBytes": 3191240,
"heapUsedBytes": 65260020,
"domNodes": 95,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.287,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge.
Top 10 files by uncovered lines
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ec7764faa20087cab1e5f5f28adef2c079e09daf
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18116 +/- ##
==========================================
+ Coverage 84.11% 85.02% +0.90%
==========================================
Files 3164 2314 -850
Lines 154834 133487 -21347
Branches 40141 34520 -5621
==========================================
- Hits 130241 113498 -16743
+ Misses 22989 19671 -3318
+ Partials 1604 318 -1286
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 856 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Now add commit that fixes and toggles test result
|
Pushed the fix and flipped the repro from Root cause: Fix: after Added a unit regression test in |
…nstead of sweeping it A doc_reset no longer clears the canvas. It arms the projection so the new lineage's first frame, which carries its whole state, applies in replace mode: shared node ids are updated in place and live nodes and links the new document lacks are removed in the same change-tracker step. The backend's lazy first mint (system:mint) therefore no longer blanks a freshly opened template until the catch-up lands. Absorbs the reproductions from #18403 (first-mint sweep), #18116 (redo after undoing an agent edit), #18404 (delete_node and clear turns) and #18089 (widget typing versus a remote frame, pinned as a known defect). Amp-Thread-ID: https://ampcode.com/threads/T-01a0d248-f130-743a-a0a7-d90e3334772b
Adds a failing e2e case: after undoing one of an agent's add-node edits, the standard redo shortcut does not bring it back. Reuses the existing agentConversationFixture replay harness (three-sequential- adds recording) and the same undo/redo keybinding convention already used in keyboardShortcutActions.spec.ts.
…do/redo ChangeTracker.updateState() set activeState to the raw JSON just fed into loadGraphData(), but widget/node hydration can still mutate the canvas for a tick after that call resolves. If a generic captureCanvasState() call (a mouseup/keyup from the user's own next action) landed in that window, it saw the canvas as changed relative to the stale activeState, treated it as a real edit, and cleared the queue the undo/redo had just populated -- so pressing redo right after undo silently did nothing. Wait a tick and re-serialize the canvas before setting activeState, so it reflects what actually settled rather than the pre-hydration JSON. Flip the agent undo/redo repro from test.fail() to a real assertion now that it passes, and add a regression test covering the exact mismatch.
|
Taking this over from the paused Claude feedback sweep. Rebased onto current |
a0ff8af to
bc4cfc3
Compare
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested because async restore can snapshot the wrong workflow after a tab switch
The blocking issue is:
- [P1]
updateState()now serializes the process-globalapp.rootGraphafterloadGraphData()finishes. That load explicitly allows workflow switches during its resource-scan awaits, so workflow A's tracker can record workflow B's graph. The inline comment has the trace and the required ownership test.
Findings without an anchorable line
- [P2] The PR description is still for the original repro-only head. It says the PR adds an expected failure, has no root cause or production fix, and could not execute the browser spec. The current head includes the production fix and normal passing unit/E2E tests. Please rewrite the title, summary, review focus, and test plan for the current change.
- [P3] An older status comment says two identical runs rule out a one-off flake and attributes cancelled jobs to supersession without cancellation metadata. Those runs reproduced the result twice, but they do not establish either conclusion. Please treat those statements as historical hypotheses rather than evidence for this head.
Existing findings confirmed or contested
- Confirmed and addressed: Christian Byrne's review asked for the production fix and for the repro to become a passing test. Both are present at
bc4cfc3, and the current-head unit and cloud checks are green. - Contested: the earlier
squashState()hypothesis does not fit this path.captureCanvasState()is blocked while_restoringStateis true, a pending squash returns whileChangeTracker.isLoadingGraphis true, and a timer cannot interleave between theloadGraphData()continuation and Vue's microtask flush. The separate cross-workflow read remains blocking.
Unverified candidate
- [P3] The latest status comment says a focused local cloud replay passed at
bc4cfc3. I can verify the current-head cloud suite and new-test video jobs, but the supplied review context has no focused local Playwright log. Linking that run would settle the narrower claim.
Checked and cleared
- Current-head CI is green, including unit tests, cloud Playwright, browser typecheck, lint/format, and Fallow.
- The focused local
changeTrackerrun passed all 77 tests. Browser typecheck, changed-file ESLint, and formatting also passed locally. - I found no new
any, double assertion, suppression, raw telemetry sink, god-object method, untranslated UI text, PrimeVue usage, Tailwind violation, or ADR change in the diff.
Coverage
- Depth: standard.
- Lanes run: correctness, maintainability, idiomaticity, tests, and documentation. No lane or changed path was skipped.
- Standard lenses run: blast radius, regression history, idempotency/shared-state/boundary/root-cause checks, deletion and reader-load checks, TypeScript/type-system checks, test-suite design, mock quality, Playwright structure and flake checks, setup consolidation, proof, and technical writing. The tests lane also applied the repository's Playwright-writing guidance.
- Local diff-scoped Fallow could not find an
origin/mainmerge base in this shallow worktree; the current-head CI Fallow check passed with no new finding.
Addresses review feedback: #18116 (comment)
Addresses review feedback: #18116 (comment)
Addresses review feedback: #18116 (comment)
Addresses review feedback: #18116 (comment)
Addresses review feedback: #18116 (comment)
Addresses review feedback: #18116 (comment)
Addresses review feedback: #18116 (comment)
Addresses review feedback: #18116 (comment)
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested because invalid settled snapshots corrupt undo/redo state in production
The workflow-ownership guard and its deferred-switch test fix my original blocker. One new production blocker remains in the validation path, and the E2E oracle still omits durable position state.
Prior review disposition:
- Fixed: cross-workflow capture, the next-tick falsifier, the duplicate graph helper, raw keyboard shortcuts, missing replay/undo/redo steps, and the redundant setup comment.
- Partially fixed: the unchecked workflow assertion is now schema-validated, but rejection falls through in production; the node-count oracle now checks IDs, types, widgets, and links, but not node position. The inline comments cover both remaining defects.
- Confirmed and addressed: Christian Byrne's earlier request for a production fix and a passing regression test.
- Contested: deleting validation as unnecessary would restore the unchecked serializer/workflow boundary.
rootGraph.serialize()is not typed asComfyWorkflowJSON, and extension data makes explicit validation useful; the rejection branch needs to be safe instead. The earliersquashState()hypothesis also remains unsupported by this path.
Findings without an anchorable line:
- [P2] The PR description is still for the repro-only head: it says this is an expected failure with no root cause or production fix and no executed browser test. Please rewrite the title, summary, review focus, and test plan for the current production fix and current evidence.
- [P3] The historical status claim that two runs rule out a flake and that cancelled jobs were almost certainly superseded still exceeds the supplied evidence. Two reproductions reduce uncertainty; no cancellation metadata establishes the cause.
- [P3] The focused local cloud Playwright pass remains unverified because no command/SHA/exit log is linked. The available CI artifact can be cited instead, or the focused log can be attached.
Verification at 25df099: the focused changeTracker suite passed 78/78; browser typecheck, changed-file ESLint, and formatting exited 0. Removing the production nextTick or the workflow-ownership branch makes its focused regression fail. Several current CI jobs were still in progress in the supplied snapshot, so I did not treat them as passed.
Coverage: standard depth; correctness, maintainability, idiomaticity, tests, and documentation lanes reviewed every changed path. No lane was sampled.
| settledState, | ||
| 'Undo/redo produced an invalid workflow snapshot' | ||
| ) | ||
| this.activeState = settledState |
There was a problem hiding this comment.
[P1] validateComfyWorkflow() returns null on rejection, but the repository assert() only throws in development; production reports and returns. This therefore assigns null to activeState, then updateModified() dereferences it after the source state was popped and the previous state was pushed to the other queue. A schema-invalid serialization from extension/custom-node data can corrupt the tracker during undo/redo. Please handle null explicitly before assignment, keep canvas/history/tracker state coherent on rejection, and add a validator-rejection regression rather than relying on assert() as production control flow.
| .map((node) => ({ | ||
| id: String(node.id), | ||
| type: node.type, | ||
| widgetsValues: node.serialize().widgets_values |
There was a problem hiding this comment.
[P2] The semantic lens still omits node position. A redo implementation that recreates the right node ID, type, widgets, and links at [0, 0] passes this test even though position is durable undo/redo state; this recording's three add operations have distinct stable positions. Please include serialized pos in the node projection so the redo equality catches spatial corruption.
| await vi.waitFor(() => expect(finishLoad).toBeDefined()) | ||
| useWorkflowStore().activeWorkflow = workflowB | ||
| mockCanvasState(workflowBState) | ||
| finishLoad!(true) |
There was a problem hiding this comment.
[P3] Nit: finishLoad is modeled as optional only to be forced with !; waitFor() cannot narrow a variable assigned inside the Promise executor. Promise.withResolvers<true>() gives this deferred operation a non-optional resolver and removes the unchecked precondition.
| silentAssetErrors: true | ||
| }) | ||
| this.activeState = prevState | ||
| // Widget/node hydration can still mutate the graph for a tick after |
There was a problem hiding this comment.
[P3] The revised unit test proves the code waits for a mutation deliberately scheduled with Vue nextTick, but it still does not identify real widget/node hydration that runs after loadGraphData() resolves. Please narrow this production comment and the root-cause claim to the proven scheduling invariant, or cite the concrete post-resolution producer / red-green browser evidence that establishes the stronger lifecycle claim.
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 4 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 699d0d7 | Docs | View more details | Give us feedback! |
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested because the shared restore path still fails an existing redo regression
Pre-merge blockers:
- [P1] The existing invalid-snapshot blocker remains open: production
assert()reports and returns when validation yieldsnull, soactiveStateis corrupted after the history queues move. - [P1] Current-head CI fails the existing bypass-mode redo case on its initial attempt and all three retries, while the base SHA passed the same shard in two workflows. The focused agent test passes, so it does not establish that the shared
updateState()change preserves other durable graph state. The inline comment asks for diagnosis rather than assuming the exact mechanism.
Findings without an anchorable line
- [P2] The PR description still documents the original repro-only head: expected failure, no root cause or production fix, and no executed browser test. Please rewrite the title, summary, review focus, and test plan for the current fix, whole-turn regression, and current-head results.
- [P3] The historical claim that two identical runs rule out a flake and that cancelled jobs were almost certainly superseded still exceeds the supplied evidence. Two reproductions reduce uncertainty; no cancellation metadata establishes the cause.
Existing findings confirmed
- [P1] The nullable validation result still relies on a production assertion that does not throw: #18116 (comment)
- [P2] The semantic lens still omits durable node position, so both the pre-turn undo comparison and post-turn redo comparison permit spatial corruption: #18116 (comment)
- [P3] The optional deferred resolver is still forced with a non-null assertion: #18116 (comment)
- [P3] The real post-
loadGraphData()hydration/root-cause claim still lacks a concrete producer or red-green browser trace: #18116 (comment)
Unverified candidate
- [P3] The historical focused local cloud Playwright pass still has no inspectable command, SHA, exit status, or log. Linking that evidence, or replacing the claim with the available CI artifact, would settle it.
Checked and cleared
- Replacing the derived “remove the final added node” oracle with the observed pre-turn snapshot correctly tests the turn-level undo boundary. The current-head focused agent test passes in CI.
- The node-position gap, redundant replay poll, naming drift, and top-level constant are separate findings; no other new test-structure issue survived review.
- Diff-scoped Fallow, browser typecheck, ESLint, and Oxlint passed at this head.
Coverage
- Depth: standard.
- Lanes: correctness, maintainability, idiomaticity, tests, and documentation; every lane reviewed the new commit and carried applicable prior findings.
- The tests lane applied the full Playwright helper inventory, interaction table, checks A–H, rulebook, and the requested Playwright-writing guidance.
- Current-head evidence: focused agent Playwright passed; existing bypass-mode redo failed initial run plus three retries; base SHA shard 9 passed in two workflows.
| // it just populated. | ||
| await nextTick() | ||
| if (isActiveTracker(this)) { | ||
| const settledState = await validateComfyWorkflow( |
There was a problem hiding this comment.
[P1] This shared restore change is not safe to merge yet. At this head, the existing errorsTabModeAware.spec.ts bypass-mode case reaches undo successfully but redo leaves node.isBypassed() false on the initial attempt and all three retries. The base SHA passed the same shard in two workflows, while this PR's focused agent test passes, so the new test is too narrow to clear the shared undo/redo path. Please diagnose the mode/flags round-trip, keep the existing case green, and add focused ChangeTracker coverage for the failure once its mechanism is known.
|
|
||
| await test.step('Replay the agent edits', async () => { | ||
| await agentConversation.runTurns() | ||
| await expect |
There was a problem hiding this comment.
[P3] runTurns() already awaits expectCanvasReplayed(), which checks every projected node, exact rendered node count, widget values, and links before returning. This weaker node-count poll duplicates that completion contract immediately before the full snapshot; please delete it so the harness remains the single readiness owner.
| .toEqual(beforeAgentEdit) | ||
| }) | ||
|
|
||
| await test.step('Redo the final agent edit', async () => { |
There was a problem hiding this comment.
[P3] Nit: the new assertion establishes that one undo reverses the whole agent turn, but this label still says only the final edit is redone. Please rename it to Redo the agent turn and update the test title to describe the same turn-level boundary.
| import { agentConversationTest as test } from '@e2e/fixtures/agentConversationFixture' | ||
|
|
||
| // Source: https://linear.app/comfyorg/issue/PM-914 | ||
| const THREE_ADDS_CASE = 'agent-rec-three-sequential-adds' |
There was a problem hiding this comment.
[P3] Nit: browser_tests/README.md limits spec top level to imports, Playwright configuration/hooks, and describe/test blocks. This one-use alias adds indirection without owning policy; please inline the case ID in test.use and keep any issue provenance in test metadata.
|
Merged |
|
Closing as consolidated into #18700. The merged carrier includes |
Summary
Adds a failing e2e case: after undoing one of an agent-authored graph edits, the standard redo shortcut does not restore it.
Changes
browser_tests/tests/agent/agentUndoRedo.spec.tsreplays the existingagent-rec-three-sequential-addsrecording viaagentConversationFixture, undoes one of the agent's three add-node ops (Ctrl/Cmd+Z), asserts that undo itself works (sanity, not the defect), then asserts redo (Ctrl/Cmd+Shift+Z) restores the node. The redo assertion is wrapped intest.fail()since it currently fails — the graph stays at the undone state.Review Focus
tests/keyboardShortcutActions.spec.tscase for a manually-added node, isolating the difference to "the edit was agent-authored, applied through the CRDT/ECS mutation path" rather than a generic undo/redo regression.ChangeTracker.captureCanvasState()'sredoQueue.length = 0firing again from an async post-load effect of the agent's mutation pipeline after_restoringStateis reset, racing the undo). Flagging for whoever picks this up rather than guessing further from static reading alone.Test plan
pnpm exec vue-tsc --project browser_tests/tsconfig.json --noEmit— clean.pnpm exec oxlint browser_tests/tests/agent/agentUndoRedo.spec.ts— clean.pnpm exec playwright test browser_tests/tests/agent/agentUndoRedo.spec.ts --list— collects the one test under thecloudproject.🤖 Generated with Claude Code
Generated by Claude Code